GNU bug report logs - #22721
Make the eww-font-toggle message clear

Previous Next

Package: emacs;

Reported by: Kaushal Modi <kaushal.modi <at> gmail.com>

Date: Wed, 17 Feb 2016 15:03:01 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 22721 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: 22721 <at> debbugs.gnu.org
Subject: Make the eww-font-toggle message clear
Date: Wed, 17 Feb 2016 10:05:31 -0500

[Message part 1 (text/plain, inline)]
Made a "duh" mistake in my earlier patch.

Here's the fixed version:

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index da920c1..185b9e6 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1498,11 +1498,10 @@ eww-set-character-encoding
 (defun eww-toggle-fonts ()
   "Toggle whether to use monospaced or font-enabled layouts."
   (interactive)
-  (message "Fonts are now %s"
-   (if (setq shr-use-fonts (not shr-use-fonts))
-       "on"
-     "off"))
-  (eww-reload))
+  (setq shr-use-fonts (not shr-use-fonts))
+  (eww-reload)
+  (message "Proportional fonts are now %s"
+   (if shr-use-fonts "on" "off")))

 ;;; Bookmarks code





--
Kaushal Modi

[Message part 2 (text/html, inline)]
This bug report was last modified 9 years and 95 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.