From unknown Fri Jun 20 20:01:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#22721 <22721@debbugs.gnu.org> To: bug#22721 <22721@debbugs.gnu.org> Subject: Status: Make the eww-font-toggle message clear Reply-To: bug#22721 <22721@debbugs.gnu.org> Date: Sat, 21 Jun 2025 03:01:14 +0000 retitle 22721 Make the eww-font-toggle message clear reassign 22721 emacs submitter 22721 Kaushal Modi severity 22721 wishlist tag 22721 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 17 10:02:44 2016 Received: (at submit) by debbugs.gnu.org; 17 Feb 2016 15:02:45 +0000 Received: from localhost ([127.0.0.1]:39760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW3cq-0000Rp-Kq for submit@debbugs.gnu.org; Wed, 17 Feb 2016 10:02:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:32892) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW3co-0000Rd-OF for submit@debbugs.gnu.org; Wed, 17 Feb 2016 10:02:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW3cd-000126-SF for submit@debbugs.gnu.org; Wed, 17 Feb 2016 10:02:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3cd-00011s-PL for submit@debbugs.gnu.org; Wed, 17 Feb 2016 10:02:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3cY-0003Kv-2q for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 10:02:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW3cX-0000z5-3i for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 10:02:26 -0500 Received: from mail-ob0-x22e.google.com ([2607:f8b0:4003:c01::22e]:35704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3cW-0000ys-UE for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 10:02:25 -0500 Received: by mail-ob0-x22e.google.com with SMTP id xk3so17700368obc.2 for ; Wed, 17 Feb 2016 07:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=Ny77ptKLp+5bQjcWIUObYH3DadHrjGwzPRmRNmIQ0jQ=; b=OGRG5HeVCLlOgdH4x9yxt/fk8pNwceiyWFJaabS5PR8DbP/DI6plIdGQ2zuS5/G/mI cppYyxN/IAxJaZ3bdKx4yApcZPr8lJn5AoF1ju+4bzb/c5jRhKluoN6NaJVMfb2iFjKz L4W/+fO2Vhf5bHrSkQ1HeVbQOZaMo5bYU+Fc79vYkvsMr5fsUOSQKtkOOTQBG8Gy13aO qtPV4TzPuziR/m1lTez5MPAoxHRNKjVkaqSY1ds3pHNGp0GgWdhoelz0HaQfYF1zQ1nQ gAlAPzhFej9Fkk+eCPyLN73bZ2iQZ1PpdqrVfnrL8QMCifISSsrlWXxeWjDyDpm/Tp2i l0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=Ny77ptKLp+5bQjcWIUObYH3DadHrjGwzPRmRNmIQ0jQ=; b=Do5eGhrWjE9iugUorfRmEN+YfNaZo1HtzN0lcNYXeVPbKcl6aaP7HvTwd7Ztp7bxF8 cZiQOrSMOFPaGITKjS6mylbvRunKIqr5NAmWSaXWj21EjXYT2mVmg/1nsmWN6XC1WvPv 8zojMKpsNB4hsDIQFKAr6qs3OGJXwdCvoegSdfEzI8NbZpAXlXzB/l8hDtMIutPb4KdI WplGnS4BAHyMZlFlLUFAshR17raQEaWmSRyntjlD8XwONjupWye7rHnEK883+DN1isg2 YFg6thawmwZUuP0kx+qK0BeCYfEaWcULm2hh89XFGGy5ar9WZWBifI2KNp8mha6vlqZi yYkQ== X-Gm-Message-State: AG10YOTm9ifMOdQhoGepubVLea6ul5idy8/pJpExUN+dbmtPvoElibbdkNzDQN4AWlfpFiV33he/AVYXORcxTg== X-Received: by 10.60.226.163 with SMTP id rt3mr1557500oec.11.1455721344135; Wed, 17 Feb 2016 07:02:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.201.73 with HTTP; Wed, 17 Feb 2016 07:01:44 -0800 (PST) From: Kaushal Modi Date: Wed, 17 Feb 2016 10:01:44 -0500 Message-ID: Subject: Make the eww-font-toggle message clear To: "bug-gnu-emacs@gnu.org" , Lars Ingebrigtsen Content-Type: multipart/alternative; boundary=001a11369a069bfd25052bf8894d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11369a069bfd25052bf8894d Content-Type: text/plain; charset=UTF-8 Hi, Here's a little patch where I change things a little bit in eww-font-toggle function. (1) The message is printed *after* eww-reload so that the font message is not quickly masked by the "Contacting host.." message put out by eww-reload. That way it is more obvious to the user if the proportional fonts were turned on or off. (2) Instead of "Fonts are now .." message, it now prints "Proportional fonts are now ..". Earlier, I was confused if the monospace fonts were on or proportional fonts were on. Doing "C-h v shr-use-fonts" helped me understand that message better. diff --git a/lisp/net/eww.el b/lisp/net/eww.el index da920c1..8536c63 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1498,11 +1498,11 @@ eww-set-character-encoding (defun eww-toggle-fonts () "Toggle whether to use monospaced or font-enabled layouts." (interactive) - (message "Fonts are now %s" + (eww-reload) + (message "Proportional fonts are now %s" (if (setq shr-use-fonts (not shr-use-fonts)) "on" - "off")) - (eww-reload)) + "off"))) ;;; Bookmarks code -- Kaushal Modi --001a11369a069bfd25052bf8894d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Here's a little patch where I c= hange things a little bit in eww-font-toggle function.

=
(1) The message is printed *after* eww-reload so that the font message= is not quickly masked by the "Contacting host.." message put out= by eww-reload. That way it is more obvious to the user if the proportional= fonts were turned on or off.

(2) Instead of "= ;Fonts are now .." message, it now prints "Proportional fonts are= now ..". Earlier, I was confused if the monospace fonts were on or pr= oportional fonts were on. Doing "C-h v shr-use-fonts" helped me u= nderstand that message better.

diff --git a/l= isp/net/eww.el b/lisp/net/eww.el
index da920c1..8536c63 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ = -1498,11 +1498,11 @@ eww-set-character-encoding
=C2=A0(defun eww-= toggle-fonts ()
=C2=A0 =C2=A0"Toggle whether to use monospac= ed or font-enabled layouts."
=C2=A0 =C2=A0(interactive)
- =C2=A0(message "Fonts are now %s"
+ =C2=A0(eww-= reload)
+ =C2=A0(message "Proportional fonts are now %s"= ;
=C2=A0 =C2= =A0 (if (setq shr-use-fonts (not shr-use-fonts))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "on&quo= t;
- =C2=A0 = =C2=A0 "off"))
- =C2=A0(eww-reload))
+ =C2=A0 =C2=A0 "off")= ))
=C2=A0
=C2=A0;;; Bookmarks code
=C2=A0




--
Kaushal Modi
--001a11369a069bfd25052bf8894d-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 17 10:06:19 2016 Received: (at 22721) by debbugs.gnu.org; 17 Feb 2016 15:06:19 +0000 Received: from localhost ([127.0.0.1]:39765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW3gJ-0000XU-5i for submit@debbugs.gnu.org; Wed, 17 Feb 2016 10:06:19 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:36303) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW3gG-0000XE-K7 for 22721@debbugs.gnu.org; Wed, 17 Feb 2016 10:06:16 -0500 Received: by mail-ob0-f174.google.com with SMTP id gc3so17689312obb.3 for <22721@debbugs.gnu.org>; Wed, 17 Feb 2016 07:06:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=z2CINXZhuOkJxwI8IeJAUHlgu4KkFxNdgVYeOrID5ek=; b=HX80Dw9WEm5XhMiUjD/U3Al0QloAuso9GBttePfakanXkY4g9V9RH4sbFKbANCtLwc p3nzxQFygmkwsgTbyo+sCjmdGx9EkCTIUWZJG1Mxe3sQuhqJKSqa1gWX+U0P49UVdSu5 B5Ayr9ed2WoCWJTkAKLUPOPBze/edyJph6RHpa8HLCjA5V74lfMggk7r9saJnbmp80Rw 31ADoLDxVT7uHTdoOoi0M9DFnfKgXUHJBk0kAIjLDlnq99uCAlalbEe1AqW2DbFxYht3 G5Gt/xSR7msMkFITqUW55PU98moe+DeKUobOaftKLcoOnsaBBMTcnF2URH/PPsrvTKp6 wWnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=z2CINXZhuOkJxwI8IeJAUHlgu4KkFxNdgVYeOrID5ek=; b=f5mVQJYQ8rempvk3tCRkmwt4hRwpAvg6EXMRhYCwWHqt5FDiCtwl1C5FFN72VGiCcL Wg7neI0p8Ow65Vs7B691NiwauTY/B2Ui2PqTLtF8OYmK9e4us8h3XCSY+YeJB1PiIeLy /fChkuq6zYREtpSkOzeTvLocgsgL2KSkKowBQVQIyq67DmbtQ1I00GYxoh8rmlyx866r Wynd6YNM0j1mzLA7oRzo62tgcBJDSlEKYH5bcIEcyispYkS2XZ5GYMKCKS1+jZWVC/Ax zhSfIGJkJ+efBdgLMqy9Wy7JyWd2AFBk3eB8W34KXjpC1QgyOATlNy4JQLgg2t0zzEwz UVyA== X-Gm-Message-State: AG10YOTocOCEeih98kV4XUrQ1ZeLEhZjQBoItKQHYPoTTeKkr40x4vMkIQsgXjLfGQukRdC6rGJEv/Fw9/yejw== X-Received: by 10.202.177.215 with SMTP id a206mr1548490oif.2.1455721570859; Wed, 17 Feb 2016 07:06:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.201.73 with HTTP; Wed, 17 Feb 2016 07:05:31 -0800 (PST) From: Kaushal Modi Date: Wed, 17 Feb 2016 10:05:31 -0500 Message-ID: Subject: Make the eww-font-toggle message clear To: 22721@debbugs.gnu.org Content-Type: multipart/alternative; boundary=001a113ce1641f81f4052bf897e5 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22721 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113ce1641f81f4052bf897e5 Content-Type: text/plain; charset=UTF-8 Made a "duh" mistake in my earlier patch. Here's the fixed version: diff --git a/lisp/net/eww.el b/lisp/net/eww.el index da920c1..185b9e6 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1498,11 +1498,10 @@ eww-set-character-encoding (defun eww-toggle-fonts () "Toggle whether to use monospaced or font-enabled layouts." (interactive) - (message "Fonts are now %s" - (if (setq shr-use-fonts (not shr-use-fonts)) - "on" - "off")) - (eww-reload)) + (setq shr-use-fonts (not shr-use-fonts)) + (eww-reload) + (message "Proportional fonts are now %s" + (if shr-use-fonts "on" "off"))) ;;; Bookmarks code -- Kaushal Modi --001a113ce1641f81f4052bf897e5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Made a "duh" mistake in my earlier patch.
Here's the fixed version:

di= ff --git a/lisp/net/eww.el b/lisp/net/eww.el
index da920c1..185b9= e6 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1498,11 +1498,10 @@ eww-set-character-encoding
=C2= =A0(defun eww-toggle-fonts ()
=C2=A0 =C2=A0"Toggle whether t= o use monospaced or font-enabled layouts."
=C2=A0 =C2=A0(int= eractive)
- =C2=A0(message "Fonts are now %s"
- =C2=A0 (if (setq shr-= use-fonts (not shr-use-fonts))
- =C2=A0 =C2=A0 =C2=A0 "on"
- =C2=A0 =C2=A0 "off"))<= /div>
- =C2=A0(eww-reload))
+ =C2=A0(setq shr-use-fonts (not = shr-use-fonts))
+ =C2=A0(eww-reload)
+ =C2=A0(message &= quot;Proportional fonts are now %s"
+ =C2=A0 (if shr-use-fonts "on" "= ;off")))
=C2=A0
=C2=A0;;; Bookmarks code
=C2=A0




--
Kaushal Modi
--001a113ce1641f81f4052bf897e5-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 00:57:00 2016 Received: (at 22721) by debbugs.gnu.org; 19 Feb 2016 05:57:00 +0000 Received: from localhost ([127.0.0.1]:33411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWe3o-0002W1-7R for submit@debbugs.gnu.org; Fri, 19 Feb 2016 00:57:00 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:32845) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWe3m-0002Vu-RX for 22721@debbugs.gnu.org; Fri, 19 Feb 2016 00:56:59 -0500 Received: from 203-174-152-162.cust.static-ipl.aapt.com.au ([203.174.152.162] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aWe3O-00041C-7j; Fri, 19 Feb 2016 06:56:34 +0100 From: Lars Ingebrigtsen To: Kaushal Modi Subject: Re: bug#22721: Make the eww-font-toggle message clear References: Date: Fri, 19 Feb 2016 16:56:29 +1100 In-Reply-To: (Kaushal Modi's message of "Wed, 17 Feb 2016 10:05:31 -0500") Message-ID: <877fi18cqa.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aWe3O-00041C-7j X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456466196.9589@eHyhDo5UaAzrIntA1msiwA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22721 Cc: 22721@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kaushal Modi writes: > Here's the fixed version: Thanks; applied to emacs-25. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 00:57:08 2016 Received: (at control) by debbugs.gnu.org; 19 Feb 2016 05:57:08 +0000 Received: from localhost ([127.0.0.1]:33415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWe3w-0002Wn-Dt for submit@debbugs.gnu.org; Fri, 19 Feb 2016 00:57:08 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:32851) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWe3u-0002We-LI for control@debbugs.gnu.org; Fri, 19 Feb 2016 00:57:06 -0500 Received: from 203-174-152-162.cust.static-ipl.aapt.com.au ([203.174.152.162] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aWe3X-00041N-KD for control@debbugs.gnu.org; Fri, 19 Feb 2016 06:56:44 +0100 Date: Fri, 19 Feb 2016 16:56:39 +1100 Message-Id: <8760xl8cq0.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22721 X-MailScanner-ID: 1aWe3X-00041N-KD X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456466205.4673@VfJpeMvfDffIPurdREBdOA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 22721 fixed close 22721 25.1 From unknown Fri Jun 20 20:01:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Mar 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator