From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 17 07:01:10 2016 Received: (at submit) by debbugs.gnu.org; 17 Feb 2016 12:01:11 +0000 Received: from localhost ([127.0.0.1]:38882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW0n4-0000or-7E for submit@debbugs.gnu.org; Wed, 17 Feb 2016 07:01:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59110) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW0mx-0000nm-Qo for submit@debbugs.gnu.org; Wed, 17 Feb 2016 07:01:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW0mm-00048C-DU for submit@debbugs.gnu.org; Wed, 17 Feb 2016 07:00:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW0mm-000488-9v for submit@debbugs.gnu.org; Wed, 17 Feb 2016 07:00:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW0mf-0003mW-RZ for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 07:00:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW0mZ-00046R-E7 for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 07:00:41 -0500 Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:34205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW0mZ-000469-1m for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 07:00:35 -0500 Received: by mail-lf0-x236.google.com with SMTP id j78so9183238lfb.1 for ; Wed, 17 Feb 2016 04:00:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Jc7XWQYKs06mFNebupPzck8NgGoqGHEUil3YhwGhr4c=; b=gqYc6oMVR+MxO1AvBJz77D0miciEkZbyWAewFc+HXt7K46Lon8fh0ML8GC3Tq6nakO DAMB8LfwRAptLMNxmZ/Qd1WFUpJKzhOXOsFeotFvuG5pqwu0DPaDoruKp+i1NDTdwwQ7 nCxjMa+y27n5PBqr7KeaEWjD52YkizLgkEFXfukPFxhVAwXapgzlsBNjUPeSEsNwsp3H QSqIcT+1ec3P3+99svCrJ/yDJY2tHK1rxjs1WK6ck0DD1VvHY5LG5X+/LQ9RAQYnSrRF hP/YCIImbPEzbs9rvRJhNTRRYb+u8pABuwVYR1CYT8qDW/gX6t+5dhtMFLSnFxN7dOwW tmGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=Jc7XWQYKs06mFNebupPzck8NgGoqGHEUil3YhwGhr4c=; b=TA0bjd2uJXNzsv5+k8Z31mwPAIoH4nTEbayIIZw84H6u6i4xDVNG94acgZWfBCJUMM NFYjvAB26sbwmGaeEeRqNYzhHFPtKNOa4maAtrQRSO4Cxc/UosdHkiomjdj2cXq926nw tI1XZpt4w2oy0z2zFSyVefwNoP2SLqhPbV3tHSrRezNFPTU5+yDVBdvf5DyERbPkIIDu JgoZc+KjZVrpLD1p5W8JdZbioe4lBQAzknjg/9VtNY20WzQIJCXhIuXnL6RzNZn+VE7X frPcxJlt1W86SzCIzn0LN9HCjqpdGwHpWx1bCjbLc/vLutBuwuGYq522TeFvvhoo4W9E RQbg== X-Gm-Message-State: AG10YOTyet/hwv7XuZsxXgMvP+RSIgaIs0T2vd+dlqMnYyf6cIoxDHLKWDfJOAoL3gIKyftjs0ub6Mn2gAsLOg== MIME-Version: 1.0 X-Received: by 10.25.160.194 with SMTP id j185mr515117lfe.128.1455710433554; Wed, 17 Feb 2016 04:00:33 -0800 (PST) Received: by 10.112.207.227 with HTTP; Wed, 17 Feb 2016 04:00:33 -0800 (PST) Date: Wed, 17 Feb 2016 21:00:33 +0900 Message-ID: Subject: 25.0.91; describe-key causes an error for lambda functions after loading mode-local From: Sho Takemori To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=001a11410efa49b7ce052bf5ffe7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11410efa49b7ce052bf5ffe7 Content-Type: text/plain; charset=UTF-8 After loading "mode-local.el", describe-key causes an error for anonymous commands. To reproduce it, please evaluate the following code in the scratch buffer: (progn (require 'mode-local) (global-set-key [up] (lambda () (interactive))) (describe-key [up])) Best regards, Sho Takemori In GNU Emacs 25.0.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.7) of 2016-02-17 built on K430-Ubuntu Repository revision: 132dbf089ffdc6c77c9383f225f2458d21c869a5 Windowing system distributor 'The X.Org Foundation', version 11.0.11702000 System Description: Ubuntu 15.10 Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LC_MONETARY: ja_JP.UTF-8 value of $LC_NUMERIC: ja_JP.UTF-8 value of $LC_TIME: ja_JP.UTF-8 value of $LANG: ja_JP.UTF-8 value of $XMODIFIERS: @im=fcitx locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Quit Mark set Entering debugger... Back to top level Quit Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils debug help-fns help-mode easymenu cl-loaddefs pcase cl-lib mode-local find-func time-date mule-util japan-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 91710 9142) (symbols 48 20041 0) (miscs 40 328 196) (strings 32 15383 4581) (string-bytes 1 450391) (vectors 16 12878) (vector-slots 8 509828 11245) (floats 8 166 75) (intervals 56 223 2) (buffers 976 13) (heap 1024 22127 862)) --001a11410efa49b7ce052bf5ffe7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
After loading "mode-local.el", describe-key= causes an error for anonymous commands.
To reproduce it, please = evaluate the following code in the scratch buffer:

(progn
=C2=A0 (require 'mode-local)
=C2=A0 (global= -set-key [up] (lambda () (interactive)))
=C2=A0 (describe-key [up= ]))

Best regards,
Sho Takemori

In GNU Emacs 25.0.91.1 (x86_64-unknown-linux-gnu, GTK+ Vers= ion 3.16.7)
=C2=A0of 2016-02-17 built on K430-Ubuntu
Re= pository revision: 132dbf089ffdc6c77c9383f225f2458d21c869a5
Windo= wing system distributor 'The X.Org Foundation', version 11.0.117020= 00
System Description:= Ubuntu 15.10

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important se= ttings:
=C2=A0 value of $LC_MONETARY: ja_JP.UTF-8
=C2= =A0 value of $LC_NUMERIC: ja_JP.UTF-8
=C2=A0 value of $LC_TIME: j= a_JP.UTF-8
=C2=A0 value of $LANG: ja_JP.UTF-8
=C2=A0 va= lue of $XMODIFIERS: @im=3Dfcitx
=C2=A0 locale-coding-system: utf-= 8-unix

Major mode: Lisp Interaction

=
Minor modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mode: t<= /div>
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-= mode: t
=C2=A0 line-number-mode: t
=C2=A0 transient-mar= k-mode: t

Recent messages:
For informati= on about GNU Emacs and the GNU system, type C-h C-a.
Quit
Mark set
Entering debugger...
Back to top level
Quit

Load-path shadows:
None found= .

Features:
(shadow sort mail-extr emacs= bug message dired format-spec rfc822 mml
mml-sec epg epg-config g= nus-util mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabb= rev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-u= til mail-prsvr mail-utils debug help-fns
help-mode easymenu cl-lo= addefs pcase cl-lib mode-local find-func
time-date mule-util japa= n-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-f= loat-type mwheel x-win term/common-win x-dnd
tool-bar dnd fontset= image regexp-opt fringe tabulated-list newcomment
elisp-mode lis= p-mode prog-mode register page menu-bar rfn-eshadow timer
select = scroll-bar mouse jit-lock font-lock syntax facemenu font-core
fra= me cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian=
slovak czech european ethiopic indian cyrillic chinese charscrip= t
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer=
cl-preloaded nadvice loaddefs button faces cus-face macroexp fil= es
text-properties overlay sha1 md5 base64 format env code-pages = mule
custom widget hashtable-print-readable backquote dbusbind in= otify
dynamic-setting system-font-setting font-render-setting mov= e-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 91710 914= 2)
=C2=A0(symbols 48 20041 0)
=C2=A0(miscs 40 328 196)<= /div>
=C2=A0(strings 32 15383 4581)
=C2=A0(string-bytes 1 450= 391)
=C2=A0(vectors 16 12878)
=C2=A0(vector-slots 8 509= 828 11245)
=C2=A0(floats 8 166 75)
=C2=A0(intervals 56 = 223 2)
=C2=A0(buffers 976 13)
=C2=A0(heap 1024 22127 86= 2))

--001a11410efa49b7ce052bf5ffe7-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 17 14:16:42 2016 Received: (at control) by debbugs.gnu.org; 17 Feb 2016 19:16:42 +0000 Received: from localhost ([127.0.0.1]:59942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW7ab-0007KL-Qy for submit@debbugs.gnu.org; Wed, 17 Feb 2016 14:16:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49650) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW7aa-0007K4-06 for control@debbugs.gnu.org; Wed, 17 Feb 2016 14:16:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW7aU-00062B-0t for control@debbugs.gnu.org; Wed, 17 Feb 2016 14:16:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW7aT-000627-U2 for control@debbugs.gnu.org; Wed, 17 Feb 2016 14:16:33 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aW7aT-0003yZ-6C for control@debbugs.gnu.org; Wed, 17 Feb 2016 14:16:33 -0500 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 17 Feb 2016 14:16:33 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 22716 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 20 15:39:17 2016 Received: (at 22716) by debbugs.gnu.org; 20 Mar 2016 19:39:17 +0000 Received: from localhost ([127.0.0.1]:55846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahjC1-00049a-7H for submit@debbugs.gnu.org; Sun, 20 Mar 2016 15:39:17 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:34920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahjBz-00049L-La for 22716@debbugs.gnu.org; Sun, 20 Mar 2016 15:39:16 -0400 Received: by mail-ob0-f174.google.com with SMTP id fp4so159843682obb.2 for <22716@debbugs.gnu.org>; Sun, 20 Mar 2016 12:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc; bh=ufBD7xYecaXsHfHXpPQE7AVb4RlK2aZ6tHWFFme0JM8=; b=aXr96qgPpfgMUQxbsUFUXbNVfvTpGW/72Jcx6xwggpYgWWDIH8O85bx9yEo1RMkwl+ PLeSG/fWAuoEXbkK0lDN6DilA04oC6dk6vE7buphcRBS26sxqA8VQ3XoJHmIoZFfK5RC ZGbnSn+HuT8dIeb7HbS3GK/G+16S/bOVPYSrzQdpDjCtacHXHtD0aKowsFjzBupLOh6r wFMjWxrZPRloz92wIlcOqzUej+eIxVFFg0wRYgvh0XvwD5c7/bNtwL5kP0U+xo/Rz/X4 p07oYl6WqkDW3VPG+LFZiXMBuUwdejpqyie1l+6fJu4IxxjMNK+r0Nr09IK94LqgmdTf hRHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ufBD7xYecaXsHfHXpPQE7AVb4RlK2aZ6tHWFFme0JM8=; b=BjXbw2amif7ZgHI4l2STZOnWCabkVsYaN8RFt3uHlJSKj4Aa9JtAAgpt1m5iL927r6 GKABem6sNDU4EJ35ycu62iwA0DCjfmBzhGqUd2kf1v+AYmGQZq8y501HtbiEgKMxR0aD pNCA81Pp5B39C5kso6HlIWoWCojuho5fgfNDePyWdPRyhorllsocrEsXkieYyEPEa+qp JVEFkBC9wuWrCUJqfOLVlsQPz0VDSh5gxOlzU06ArkNsfmtwv4Okd3TjqQ1Lmm9C5i8N KtMZD4r3Oh/yBO56h3xC/PRXC8YIB+QK9qNgsSkn7DhdQd2cDty9CzY2eVHpvqZhErnm sT0w== X-Gm-Message-State: AD7BkJLJTzdZTwAsgcoVWdKtztH7pynx49+gPBS3SnKUkn1eF1ND1+SAnLzFZwOMvhEGz9jSw2onnb0KHrIDkQ== X-Received: by 10.182.104.138 with SMTP id ge10mr12225812obb.81.1458502749953; Sun, 20 Mar 2016 12:39:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.172.198 with HTTP; Sun, 20 Mar 2016 12:38:30 -0700 (PDT) From: Kaushal Modi Date: Sun, 20 Mar 2016 15:38:30 -0400 Message-ID: Subject: Re: 25.0.91; describe-key causes an error for lambda functions after loading mode-local To: 22716@debbugs.gnu.org Content-Type: multipart/alternative; boundary=089e0160c90850a7c3052e802221 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22716 Cc: Paul Eggert , Stephen Leake X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e0160c90850a7c3052e802221 Content-Type: text/plain; charset=UTF-8 Hi all, Here is my attempt at fixing this bug: >From 3e320b4929710880e352ecbd749e77a20bfef3fe Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Sun, 20 Mar 2016 15:31:08 -0400 Subject: [PATCH] Check if arg is actually a symbol (bug # 22716) * lisp/cedet/mode-local.el (describe-mode-local-overload): Check if the passed argument SYMBOL is actually a symbol before proceeding with `(get symbol 'mode-local-overload)'. This check is required for the case presented in bug # 22716 where a key might be bound to a bare lambda interactive function instead of an interactive function symbol. In addition, the code is re-arranged to follow the standard elisp coding style. --- lisp/cedet/mode-local.el | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/lisp/cedet/mode-local.el b/lisp/cedet/mode-local.el index c7e6615..b39567d 100644 --- a/lisp/cedet/mode-local.el +++ b/lisp/cedet/mode-local.el @@ -638,13 +638,13 @@ describe-function-orig-buffer (defun describe-mode-local-overload (symbol) "For `help-fns-describe-function-functions'; add overloads for SYMBOL." - (when (get symbol 'mode-local-overload) + (when (and (symbolp symbol) + (get symbol 'mode-local-overload)) (let ((default (or (intern-soft (format "%s-default" (symbol-name symbol))) symbol)) (override (with-current-buffer describe-function-orig-buffer (fetch-overload symbol))) modes) - (insert (substitute-command-keys (overload-docstring-extension symbol)) "\n\n") (insert (format-message "default function: `%s'\n" default)) @@ -653,20 +653,16 @@ describe-mode-local-overload describe-function-orig-buffer override)) (insert (format-message "\nno override in buffer `%s'\n" describe-function-orig-buffer))) - - (mapatoms - (lambda (sym) (when (get sym 'mode-local-symbol-table) (push sym modes))) - obarray) - + (mapatoms (lambda (sym) + (when (get sym 'mode-local-symbol-table) + (push sym modes))) + obarray) (dolist (mode modes) (let* ((major-mode mode) (override (fetch-overload symbol))) - (when override (insert (format-message "\noverride in mode `%s': `%s'\n" - major-mode override)) - ))) - ))) + major-mode override)))))))) (add-hook 'help-fns-describe-function-functions 'describe-mode-local-overload) -- 2.6.0.rc0.24.gec371ff I have copied Stephen and Paul as I see that they have past commits in this region of code. So they should provide a good judgement on this patch. -- Kaushal Modi --089e0160c90850a7c3052e802221 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi all,

Here is my attempt at fixing th= is bug:

From 3e320b4929710880e352ecbd749e77a2= 0bfef3fe Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Sun, 20 Mar 2016 15:31:08 -0400
Subject: [PATCH] Check if = arg is actually a symbol (bug # 22716)

* lisp/cede= t/mode-local.el (describe-mode-local-overload): Check if the
=C2= =A0 passed argument SYMBOL is actually a symbol before proceeding with
=C2=A0 `(get symbol 'mode-local-overload)'. This check is req= uired for the
=C2=A0 case presented in bug # 22716 where a key mi= ght be bound to a bare
=C2=A0 lambda interactive function instead= of an interactive function symbol.

In addition, t= he code is re-arranged to follow the standard elisp coding
style.=
---
=C2=A0lisp/cedet/mode-local.el | 18 +++++++-------= ----
=C2=A01 file changed, 7 insertions(+), 11 deletions(-)
=

diff --git a/lisp/cedet/mode-local.el b/lisp/cedet/mode= -local.el
index c7e6615..b39567d 100644
--- a/lisp/cede= t/mode-local.el
+++ b/lisp/cedet/mode-local.el
@@ -638,= 13 +638,13 @@ describe-function-orig-buffer
=C2=A0
=C2= =A0(defun describe-mode-local-overload (symbol)
=C2=A0 =C2=A0&quo= t;For `help-fns-describe-function-functions'; add overloads for SYMBOL.= "
- =C2=A0(when (get symbol 'mode-local-overload)
<= div>+ =C2=A0(when (and (symbolp symbol)
+ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (get symbol 'mode-local-overload))
=C2= =A0 =C2=A0 =C2=A0(let ((default (or (intern-soft (format "%s-default&q= uot; (symbol-name symbol)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 symbol))
=C2=A0 =C2=A0(override (with-current-= buffer describe-function-orig-buffer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(fetch-overload symb= ol)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0modes)
-=
=C2=A0 =C2=A0 =C2=A0 =C2=A0(insert (substitute-command-keys (ove= rload-docstring-extension symbol))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0"\n\n")
=C2=A0 =C2=A0 =C2=A0= =C2=A0(insert (format-message "default function: `%s'\n" def= ault))
@@ -653,20 +653,16 @@ describe-mode-local-overload
=C2=A0 =C2=A0descr= ibe-function-orig-buffer override))
=C2=A0 (insert (format-message "\nno override in= buffer `%s'\n"
=C2=A0 describe-function-orig-buffer)))
-
= - =C2=A0 =C2=A0 =C2=A0(mapatoms
- =C2=A0 =C2=A0 =C2=A0 (lambda (s= ym) (when (get sym 'mode-local-symbol-table) (push sym modes)))
- =C2=A0 =C2=A0 =C2=A0 obarray)
-
+ =C2=A0 =C2=A0 = =C2=A0(mapatoms (lambda (sym)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when (get sym 'mode-local-symbol-table)=
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(push sym modes)))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0obarray)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(dolist (= mode modes)
=C2=A0 (let* ((major-mode mode)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (override (fetch-overload symbol= )))
-
=C2=A0= =C2=A0(when override
=C2=A0 =C2=A0 =C2=A0(insert (format-message "\noverrid= e in mode `%s': `%s'\n"
- =C2=A0 =C2=A0major-mode override))
- = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)))
- =C2=A0 =C2=A0 =C2= =A0)))
+ = =C2=A0 =C2=A0major-mode override))))))))
=C2=A0
=C2=A0(= add-hook 'help-fns-describe-function-functions 'describe-mode-local= -overload)
=C2=A0
--=C2=A0
2.6.0.rc0.24.gec37= 1ff


I have copied Stephen and Paul = as I see that they have past commits in this region of code. So they should= provide a good judgement on this patch.


--
Kaushal Modi
--089e0160c90850a7c3052e802221-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 05 08:43:53 2016 Received: (at 22716) by debbugs.gnu.org; 5 Apr 2016 12:43:53 +0000 Received: from localhost ([127.0.0.1]:51789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anQKn-0000pQ-FM for submit@debbugs.gnu.org; Tue, 05 Apr 2016 08:43:53 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:33992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anQKm-0000pE-9T for 22716@debbugs.gnu.org; Tue, 05 Apr 2016 08:43:52 -0400 Received: by mail-ob0-f172.google.com with SMTP id bg3so8321435obb.1 for <22716@debbugs.gnu.org>; Tue, 05 Apr 2016 05:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PUjwfK6ZkQUftOF5GxceMYRwC6pmuQ+yZSi7wiqq+GY=; b=ohkjkvihZReI1RXmgmrEYq2VFD93U4AOYNvUl1U7CpT66ffgN3nLi2Y6+OeE9/SXkc V66BesBA5og+Hrn83DKVaeidViv4dJbEC8xAtnEUMap/LaDOQS22oLz+ujXDksqJSaFM 2ebKTWjdHkrzgPPVJ5ARGhoZpeGTLUzM4GOGq4OMhgu2M9sl/cZXI6jODv6DUgxLHB78 ZQj4CpvjKeCiYy8h+FJjedI4aVhHo34H7bYgdyIMCbXPK6mkO6S6N5EkbidlcqEWQxNU sQD+9xKGTnwSC3IdiE0i6wkOI0RHVAyEAo4JPCpDC1kE5MWOleauLr5sPtuseYrOYfho lBwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PUjwfK6ZkQUftOF5GxceMYRwC6pmuQ+yZSi7wiqq+GY=; b=AV/iFE6NZ0jCcKzm0Aqh9UYThdDrlhCzts82zaCWvszP7EPEKoV3dvMBYlQVsCvdJK xA2c/agSVh2YfpBXZbZ2fen2Bx6m5xvI7IBqmh/T/4XAxobWnPAnVTXTzNy6zFv82h3G NeyyoieAdtqhIRP+Uz9uw3LcJSeHM0e2MMTeA7hYiqsMTHW0HBjzpdNQG/ehL6tOxHr2 f9qHil7vtOGMCEi7IYRX0NVcxjCIwr5jmvYgoly+8dE5bsl224OGYp77H9tIhKNpXIoj XYvp6i1jNgdT3z24YZ2Jz18OYD+At80Vlw8E7Mfy1kDlwK4teqVJKOIUY+jSNxPit6BJ jJpA== X-Gm-Message-State: AD7BkJI5ewMp7U8Wex6u0/etFkp0xwAVAFDg4Q9BRYDaK/XtEFF8cxw7oZjQQErbzwFlL3WikfqzzZoYlebhQQ== X-Received: by 10.60.135.98 with SMTP id pr2mr8933434oeb.65.1459860226574; Tue, 05 Apr 2016 05:43:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kaushal Modi Date: Tue, 05 Apr 2016 12:43:36 +0000 Message-ID: Subject: Re: 25.0.91; describe-key causes an error for lambda functions after loading mode-local To: 22716@debbugs.gnu.org Content-Type: multipart/alternative; boundary=047d7b4179213a31ce052fbc32c2 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22716 Cc: Paul Eggert , Stephen Leake X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b4179213a31ce052fbc32c2 Content-Type: text/plain; charset=UTF-8 Bump --047d7b4179213a31ce052fbc32c2 Content-Type: text/html; charset=UTF-8
Bump
--047d7b4179213a31ce052fbc32c2-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 05 17:58:32 2016 Received: (at 22716-done) by debbugs.gnu.org; 5 Apr 2016 21:58:32 +0000 Received: from localhost ([127.0.0.1]:50788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anYzX-0008Ck-Vb for submit@debbugs.gnu.org; Tue, 05 Apr 2016 17:58:32 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anYzV-0008CX-QV for 22716-done@debbugs.gnu.org; Tue, 05 Apr 2016 17:58:30 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B1C63161275; Tue, 5 Apr 2016 14:58:23 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id aE1lNp7g_1sM; Tue, 5 Apr 2016 14:58:23 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EC6EF161271; Tue, 5 Apr 2016 14:58:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pccLFuXZHJjs; Tue, 5 Apr 2016 14:58:22 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id CFA10160D1A; Tue, 5 Apr 2016 14:58:22 -0700 (PDT) Subject: Re: 25.0.91; describe-key causes an error for lambda functions after loading mode-local To: 22716-done@debbugs.gnu.org, Sho Takemori References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <570434FE.1050804@cs.ucla.edu> Date: Tue, 5 Apr 2016 14:58:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------060408030606050009000106" X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 22716-done Cc: Kaushal Modi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------060408030606050009000106 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I installed the attached patch, which should fix the problem. Thanks for reporting it. --------------060408030606050009000106 Content-Type: application/x-patch; name="0001-Avoid-describe-key-error-with-lambdas.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Avoid-describe-key-error-with-lambdas.patch" RnJvbSA3NjFkN2NjMTNjM2IzMmJjMWIwYjA5ZTJkNjA2MTg3NTQzMTQ4Y2Q2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDUgQXByIDIwMTYgMTM6NTg6NTcgLTA3MDAKU3ViamVjdDogW1BBVENI XSBBdm9pZCBkZXNjcmliZS1rZXkgZXJyb3Igd2l0aCBsYW1iZGFzCgpQcm9ibGVtIHJlcG9y dGVkIGJ5IFNobyBUYWtlbW9yaSAoQnVnIzIyNzE2KS4KKiBsaXNwL2NlZGV0L21vZGUtbG9j YWwuZWwgKGRlc2NyaWJlLW1vZGUtbG9jYWwtb3ZlcmxvYWQpCih4cmVmLW1vZGUtbG9jYWwt b3ZlcmxvYWQpOiBVc2UgZnVuY3Rpb24tb3ZlcmxvYWQtcCBpbnN0ZWFkCm9mIGFzc3VtaW5n IHRoZSBhcmd1bWVudCBpcyBhIHN5bWJvbC4KLS0tCiBsaXNwL2NlZGV0L21vZGUtbG9jYWwu ZWwgfCA0ICsrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9jZWRldC9tb2RlLWxvY2FsLmVsIGIvbGlzcC9j ZWRldC9tb2RlLWxvY2FsLmVsCmluZGV4IGM3ZTY2MTUuLjRmNDI0MzEgMTAwNjQ0Ci0tLSBh L2xpc3AvY2VkZXQvbW9kZS1sb2NhbC5lbAorKysgYi9saXNwL2NlZGV0L21vZGUtbG9jYWwu ZWwKQEAgLTYzOCw3ICs2MzgsNyBAQCBkZXNjcmliZS1mdW5jdGlvbi1vcmlnLWJ1ZmZlcgog CiAoZGVmdW4gZGVzY3JpYmUtbW9kZS1sb2NhbC1vdmVybG9hZCAoc3ltYm9sKQogICAiRm9y IGBoZWxwLWZucy1kZXNjcmliZS1mdW5jdGlvbi1mdW5jdGlvbnMnOyBhZGQgb3ZlcmxvYWRz IGZvciBTWU1CT0wuIgotICAod2hlbiAoZ2V0IHN5bWJvbCAnbW9kZS1sb2NhbC1vdmVybG9h ZCkKKyAgKHdoZW4gKGZ1bmN0aW9uLW92ZXJsb2FkLXAgc3ltYm9sKQogICAgIChsZXQgKChk ZWZhdWx0IChvciAoaW50ZXJuLXNvZnQgKGZvcm1hdCAiJXMtZGVmYXVsdCIgKHN5bWJvbC1u YW1lIHN5bWJvbCkpKQogCQkgICAgICAgc3ltYm9sKSkKIAkgIChvdmVycmlkZSAod2l0aC1j dXJyZW50LWJ1ZmZlciBkZXNjcmliZS1mdW5jdGlvbi1vcmlnLWJ1ZmZlcgpAQCAtNjg0LDcg KzY4NCw3IEBAIHhyZWYtbW9kZS1sb2NhbC0tb3ZlcnJpZGUtcHJlc2VudAogKGRlZnVuIHhy ZWYtbW9kZS1sb2NhbC1vdmVybG9hZCAoc3ltYm9sKQogICAiRm9yIGBlbGlzcC14cmVmLWZp bmQtZGVmLWZ1bmN0aW9ucyc7IGFkZCBvdmVybG9hZHMgZm9yIFNZTUJPTC4iCiAgIDs7IEN1 cnJlbnQgYnVmZmVyIGlzIHRoZSBidWZmZXIgd2hlcmUgeHJlZi1maW5kLWRlZmluaXRpb25z IHdhcyBpbnZva2VkLgotICAod2hlbiAoZ2V0IHN5bWJvbCAnbW9kZS1sb2NhbC1vdmVybG9h ZCkKKyAgKHdoZW4gKGZ1bmN0aW9uLW92ZXJsb2FkLXAgc3ltYm9sKQogICAgIChsZXQqICgo c3ltYm9sLWZpbGUgKGZpbmQtbGlzcC1vYmplY3QtZmlsZS1uYW1lIHN5bWJvbCAoc3ltYm9s LWZ1bmN0aW9uIHN5bWJvbCkpKQogCSAgIChkZWZhdWx0IChpbnRlcm4tc29mdCAoZm9ybWF0 ICIlcy1kZWZhdWx0IiAoc3ltYm9sLW5hbWUgc3ltYm9sKSkpKQogCSAgIChkZWZhdWx0LWZp bGUgKHdoZW4gZGVmYXVsdCAoZmluZC1saXNwLW9iamVjdC1maWxlLW5hbWUgZGVmYXVsdCAo c3ltYm9sLWZ1bmN0aW9uIGRlZmF1bHQpKSkpCi0tIAoyLjUuNQoK --------------060408030606050009000106-- From unknown Fri Aug 08 22:14:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 May 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator