From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 15 20:02:24 2016 Received: (at submit) by debbugs.gnu.org; 16 Feb 2016 01:02:24 +0000 Received: from localhost ([127.0.0.1]:40604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVU23-0002QU-RU for submit@debbugs.gnu.org; Mon, 15 Feb 2016 20:02:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33061) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVU22-0002QH-8Y for submit@debbugs.gnu.org; Mon, 15 Feb 2016 20:02:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVU1w-0002SC-3m for submit@debbugs.gnu.org; Mon, 15 Feb 2016 20:02:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVU1w-0002S2-0X for submit@debbugs.gnu.org; Mon, 15 Feb 2016 20:02:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVU1u-0001hX-Lr for bug-gnu-emacs@gnu.org; Mon, 15 Feb 2016 20:02:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVU1p-0002O7-Jd for bug-gnu-emacs@gnu.org; Mon, 15 Feb 2016 20:02:14 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:65266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVU1p-0002MO-BK for bug-gnu-emacs@gnu.org; Mon, 15 Feb 2016 20:02:09 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1G124kg002736 for ; Mon, 15 Feb 2016 17:02:05 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: bug-gnu-emacs@gnu.org Subject: 25.0.91; xref-find-definitions fails to prompt X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 15 Feb 2016 17:02:03 -0800 Message-ID: <20283.1455584523@allegro.localdomain> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) If point is on a token that isn't defined in the current tags file, M-. gives me an error (look for "Cygwin" further down in this bug report). I expect to get a prompt. Ditto if point is at the "#" of "#include" or "#ifdef". More broadly, I think the default for xref-prompt-for-identifier is a usability regression. When I'm examining code, point is rarely at the token I want to find the definition for. So with the default behavior, I either have to move my hand to the mouse to set point and then move it back to the keyboard for the "." in M-., or I have to type in a bunch of navigation keystrokes, or I have to add a C-u prefix. Either way, the default behavior is getting in my way, not helping. In GNU Emacs 25.0.91.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bar= s) of 2016-02-14 built on allegro Windowing system distributor 'The X.Org Foundation', version 11.0.11604000 System Description: Debian GNU/Linux 8.3 (jessie) Configured using: 'configure --prefix=3D/usr/new' Configured features: XPM JPEG TIFF GIF PNG SOUND NOTIFY LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 Important settings: value of $LC_TIME: C value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix Major mode: Help Minor modes in effect: diff-auto-refine-mode: t shell-dirtrack-mode: t delete-selection-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t transient-mark-mode: t Recent messages: Please type y or n, or C-v to scroll: y [3 times] user-error: No definitions found for: Cygwin Type "q" in help window to delete it Quit find-tag is not on any key Mark set GNU Emacs 25.0.91.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars) = of 2016-02-14 You can run the command =E2=80=98emacs-version=E2=80=99 with M-x em-v RET GNU Emacs 25.0.91.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars) = of 2016-02-14 Load-path shadows: None found. Features: (shadow emacsbug pulse etags xref project cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs eieio-opt speedbar sb-image ezimage dframe ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff mh-limit sgml-mode diff-mode pp gnus-mh mh-alias crm shr-color color shr seq dom subr-x browse-url mh-search qp mh-thread sort gnus-async gnus-bcklg gnus-kill gnus-dup gnus-ml disp-table timezone url-http url-gw url-cache url-auth url-handlers nnrss xml mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars nndraft nnmh utf-7 rfc2104 network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache flow-fill mm-archive mail-extr character-fold misearch multi-isearch mh-mime mh-identity mh-letter mh-show goto-addr thingatpt gnus-cite gnus-art mm-uu mml2015 gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-win gnus-range gnus gnus-ems nnheader wid-edit mh-comp mh-gnus mm-view mml-smime smime dig mailcap vc-hg org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs pcmpl-unix mh-inc hl-line mh-tool-bar mh-seq mh-xface mh-utils mh-folder which-func imenu mh-scan mh-e mh-compat mh-acros cl mh-buffers mh-loaddefs shell pcomplete mdk-mail smtpmail auth-source cl-seq eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core cl-macs gv password-cache sendmail message format-spec rfc822 mml mml-sec epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode mail-prsvr mailabbrev mail-utils gmm-utils mailheader server noutline outline easy-mmode comint ansi-color ring xcscope easymenu advice ispell delsel vc cl-loaddefs pcase cl-lib vc-dispatcher dired timeclock mdk-hacks time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote inotify dynamic-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 509163 47425) (symbols 48 47223 0) (miscs 40 492 1325) (strings 32 119455 22990) (string-bytes 1 3536292) (vectors 16 42300) (vector-slots 8 881800 34425) (floats 8 791 405) (intervals 56 48671 33) (buffers 976 47) (heap 1024 56510 27603)) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 15 22:44:09 2016 Received: (at 22692) by debbugs.gnu.org; 16 Feb 2016 03:44:09 +0000 Received: from localhost ([127.0.0.1]:40642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVWYb-00067F-0n for submit@debbugs.gnu.org; Mon, 15 Feb 2016 22:44:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34066) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVWYa-000675-Gq for 22692@debbugs.gnu.org; Mon, 15 Feb 2016 22:44:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVWYQ-00022T-I4 for 22692@debbugs.gnu.org; Mon, 15 Feb 2016 22:44:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVWYQ-00022P-Ek; Mon, 15 Feb 2016 22:43:58 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2494 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aVWYP-0005Mk-PW; Mon, 15 Feb 2016 22:43:58 -0500 Date: Tue, 16 Feb 2016 05:44:06 +0200 Message-Id: <83r3gdwc8p.fsf@gnu.org> From: Eli Zaretskii To: Mike Kupfer In-reply-to: <20283.1455584523@allegro.localdomain> (message from Mike Kupfer on Mon, 15 Feb 2016 17:02:03 -0800) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt References: <20283.1455584523@allegro.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Mike Kupfer > Date: Mon, 15 Feb 2016 17:02:03 -0800 > > More broadly, I think the default for xref-prompt-for-identifier is a > usability regression. When I'm examining code, point is rarely at the > token I want to find the definition for. It's exactly the opposite here: point is almost always on the token. > So with the default behavior, > I either have to move my hand to the mouse to set point and then move it > back to the keyboard for the "." in M-., or I have to type in a bunch of > navigation keystrokes, or I have to add a C-u prefix. Either way, the > default behavior is getting in my way, not helping. Perhaps we could have a defcustom for this use case, but making the behavior you want the default sounds wrong to me. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 16 05:10:54 2016 Received: (at 22692) by debbugs.gnu.org; 16 Feb 2016 10:10:55 +0000 Received: from localhost ([127.0.0.1]:40816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVcas-0006X1-OW for submit@debbugs.gnu.org; Tue, 16 Feb 2016 05:10:54 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36234) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVcar-0006Wo-3V for 22692@debbugs.gnu.org; Tue, 16 Feb 2016 05:10:53 -0500 Received: by mail-wm0-f47.google.com with SMTP id g62so98010731wme.1 for <22692@debbugs.gnu.org>; Tue, 16 Feb 2016 02:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=WU0xaZ17ZCO1mZUAlhsZaB3rnjr89qiem5EuE2V9aO8=; b=hbFpHMITNJmLSqfCzcXn6kcLbmjtVqwqI8MVnsVt/sVw2ZeJLwEPSCPpPZMbcsjoV4 Q3ROyVRKXB5sKWwbewFfU86tOekNhD9KZX1FtahwFBsDeQowEUlr2Zkeo7R4uOT/6pS0 8kBq+rGfUVdYVaxkIWOqS+YSjQDuHbzBTOnHr7Aqh4VXso+9zu2PNpoQdGPX4J0rMmD8 pdfU7Y9iASax87TFuxEsk8/qqCbZvtoH3lk+FR3ufaH0/33PDwAVGvkqlxFn0LqPNz4D cFd8kCjz2BVf7+FwWH0Q0hngQTis0flwIbLa3aMHUGsCuOzj9OSwYAgtGcFR7J56iA3t 3Y6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=WU0xaZ17ZCO1mZUAlhsZaB3rnjr89qiem5EuE2V9aO8=; b=UQWEyUFDILjedyOLT/VQmndsxDiWOsdsILY/x5XR7zeUPCCXadhuiFlN+oP6yyWGF6 TEffbZEdGSo35FH+Y67wy1Vr4ttR08SlfEz1a8PfPsRepsoeHPmOIKTx039kDkybhTTe idgrQ5fSEacEQU6HO0CPQ/YmL2/Kzc604yF2tQaScY6xC2CUCm7Ne34AoodcgI5+BjGR RgfRbZGlXIZnT1jZLaGoYWGvkW0jCF2S2+brfkER/SNmINX/tP4pL/K1zK0JjchwpPi4 08HNfF3adjedwP+C/WXQGTZLCWzLdwfDB3flam78mRJXstgjUA09hGBf+YadfAEKSCaq H0PQ== X-Gm-Message-State: AG10YORcsNbRknVbXilG9Nloc/5PaYCL4rWvEWdSd1vxmQdHuNAV79C+chQ4wmuR6rl4xQ== X-Received: by 10.194.205.8 with SMTP id lc8mr20550072wjc.177.1455617446583; Tue, 16 Feb 2016 02:10:46 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id c26sm19749843wmi.24.2016.02.16.02.10.44 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 16 Feb 2016 02:10:45 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Eli Zaretskii , Mike Kupfer References: <20283.1455584523@allegro.localdomain> <83r3gdwc8p.fsf@gnu.org> From: Dmitry Gutov Message-ID: <56C2F5A2.9020402@yandex.ru> Date: Tue, 16 Feb 2016 12:10:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <83r3gdwc8p.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/16/2016 05:44 AM, Eli Zaretskii wrote: >> So with the default behavior, >> I either have to move my hand to the mouse to set point and then move it >> back to the keyboard for the "." in M-., or I have to type in a bunch of >> navigation keystrokes, or I have to add a C-u prefix. Either way, the >> default behavior is getting in my way, not helping. > > Perhaps we could have a defcustom for this use case, Don't we have it already? The aforementioned xref-prompt-for-identifier. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 16 05:13:05 2016 Received: (at 22692) by debbugs.gnu.org; 16 Feb 2016 10:13:05 +0000 Received: from localhost ([127.0.0.1]:40820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVccz-0006aU-2c for submit@debbugs.gnu.org; Tue, 16 Feb 2016 05:13:05 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37585) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVccx-0006a0-Ac for 22692@debbugs.gnu.org; Tue, 16 Feb 2016 05:13:03 -0500 Received: by mail-wm0-f47.google.com with SMTP id g62so144847214wme.0 for <22692@debbugs.gnu.org>; Tue, 16 Feb 2016 02:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=PBlqC4UilOqDFAjOWUiMsFErKTqsGkY2d/WU85v2V7I=; b=Rm/hQREDAqfwmEfPu7i2SkiJ21Ro3biNXut17fMFSDOeE2OHM1SA2v8pL3+CBqbLWg igFlDtZzMXv7iBcWayHOJAxWTy93a4sB+Of9DNiWGcT+JMynRjY3DNKiCdU9R4PGOZVL G6/zGNoY+UzP4vml9zOXJNDkn/WVis+Kv3PyOZ532ahqd2ofhoi8pmEi301v7dIjwB87 o3KDt5LVieQ6IkURfZhovhb+AcghTRNr/HC1GCpgzofJA/3tUSrM1F5vgSLHrhUGf+tr TU00H1AdPCSedjoyWj9aK7030LFKLPo2wHoLaaP1chmX+S4/sXekrGco5HExtHyctXRM FtHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=PBlqC4UilOqDFAjOWUiMsFErKTqsGkY2d/WU85v2V7I=; b=Apr3EmagR9PAoqPj+eKq5x1nTaUW/2wOsH+AdTwk3n6DUk5QIsWi6CizgnjtFIyekX aihUxMwsXqPuS58CjoikBacmyfn0Tyu0R3a6A/xkC6gej5x+LEjDku6DkjFO5xRcgTPg 15p1wMrZgxZYSyuazPN8bBOsdxsuDs45ujXcmPk5J4O2APoN13vYK3xaRTrSc7LlArxj OckRCC4XK3r0jULNyGJu8x894sjt/iJg1CwEyisWaNuPQArwd/leLrXKTdAUdppRReAN 91uK9MNM1Imcu4pCV0YbU9+Qoon/9U7Wvd8BxnO93be7K012NsQMWyHQFR5M3GuZ5UTR PLZQ== X-Gm-Message-State: AG10YOSSdTXCsA3v0yTK5oJnu632qKkJRhj9os6Jj6S3+65TRmn0njsTajH1hsgQGbXLQA== X-Received: by 10.28.57.131 with SMTP id g125mr16998755wma.17.1455617577909; Tue, 16 Feb 2016 02:12:57 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id s8sm29509849wje.35.2016.02.16.02.12.56 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 16 Feb 2016 02:12:56 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Mike Kupfer , 22692@debbugs.gnu.org References: <20283.1455584523@allegro.localdomain> From: Dmitry Gutov Message-ID: <56C2F627.6070308@yandex.ru> Date: Tue, 16 Feb 2016 12:12:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <20283.1455584523@allegro.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/16/2016 03:02 AM, Mike Kupfer wrote: > If point is on a token that isn't defined in the current tags file, > M-. gives me an error (look for "Cygwin" further down in this bug > report). I expect to get a prompt. That doesn't sound right to me: "XXX is not found" is a valid piece of information. Simply showing a prompt would obscure it. If we accept that the command searches for the thing at point by default, the current behavior seems appropriate. And whether or not it prompts, is customizable. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 16 11:01:28 2016 Received: (at 22692) by debbugs.gnu.org; 16 Feb 2016 16:01:28 +0000 Received: from localhost ([127.0.0.1]:38220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVi47-0001Wq-2L for submit@debbugs.gnu.org; Tue, 16 Feb 2016 11:01:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41498) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVi43-0001Wc-53 for 22692@debbugs.gnu.org; Tue, 16 Feb 2016 11:01:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVi3u-0006ZR-V4 for 22692@debbugs.gnu.org; Tue, 16 Feb 2016 11:01:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVi3u-0006ZN-S9; Tue, 16 Feb 2016 11:01:14 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3039 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aVi3s-0003pL-4Z; Tue, 16 Feb 2016 11:01:13 -0500 Date: Tue, 16 Feb 2016 18:01:21 +0200 Message-Id: <83k2m4wsoe.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56C2F5A2.9020402@yandex.ru> (message from Dmitry Gutov on Tue, 16 Feb 2016 12:10:42 +0200) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt References: <20283.1455584523@allegro.localdomain> <83r3gdwc8p.fsf@gnu.org> <56C2F5A2.9020402@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 22692@debbugs.gnu.org > From: Dmitry Gutov > Date: Tue, 16 Feb 2016 12:10:42 +0200 > > On 02/16/2016 05:44 AM, Eli Zaretskii wrote: > > >> So with the default behavior, > >> I either have to move my hand to the mouse to set point and then move it > >> back to the keyboard for the "." in M-., or I have to type in a bunch of > >> navigation keystrokes, or I have to add a C-u prefix. Either way, the > >> default behavior is getting in my way, not helping. > > > > Perhaps we could have a defcustom for this use case, > > Don't we have it already? The aforementioned xref-prompt-for-identifier. Oops! Sorry, you are right. So I guess Michael should just use it. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 16 20:55:35 2016 Received: (at 22692) by debbugs.gnu.org; 17 Feb 2016 01:55:35 +0000 Received: from localhost ([127.0.0.1]:38683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVrL4-00009x-VV for submit@debbugs.gnu.org; Tue, 16 Feb 2016 20:55:35 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:42839 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVrL3-00009o-7r for 22692@debbugs.gnu.org; Tue, 16 Feb 2016 20:55:33 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1H1tUZ8026308; Tue, 16 Feb 2016 17:55:30 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: Dmitry Gutov Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt In-Reply-To: Your message of "Tue\, 16 Feb 2016 12\:12\:55 +0200." <56C2F627.6070308@yandex.ru> X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 16 Feb 2016 17:55:28 -0800 Message-ID: <23698.1455674128@allegro.localdomain> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Dmitry Gutov wrote: > On 02/16/2016 03:02 AM, Mike Kupfer wrote: > > If point is on a token that isn't defined in the current tags file, > > M-. gives me an error (look for "Cygwin" further down in this bug > > report). I expect to get a prompt. >=20 > That doesn't sound right to me: "XXX is not found" is a valid piece of > information. Simply showing a prompt would obscure it. The Help string for xref-find-definitions says > With prefix argument or when there=E2=80=99s no identifier at point, > prompt for it. I guess you could argue that if point is on a token that's not in the tags table, it's still on an "identifier". But "#" is hardly an identifier. And the Info page "Xref Commands" says > With a prefix argument, or if there=E2=80=99s no valid > identifier at point, it prompts for the identifier. Does "valid identifier" mean syntatically correct, or does it mean that the identifier is in the tags table. Please clarify the documentation. > If we accept that the command searches for the thing at point by > default, the current behavior seems appropriate. And whether or not it > prompts, is customizable. Yes, I have already have (setq xref-prompt-for-identifier t) in my .emacs. mike From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 17 22:45:25 2016 Received: (at 22692) by debbugs.gnu.org; 18 Feb 2016 03:45:25 +0000 Received: from localhost ([127.0.0.1]:60113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWFWu-0007Uf-Sb for submit@debbugs.gnu.org; Wed, 17 Feb 2016 22:45:25 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:44467 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWFWt-0007UX-5B for 22692@debbugs.gnu.org; Wed, 17 Feb 2016 22:45:23 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1I3jLBQ024502 for <22692@debbugs.gnu.org>; Wed, 17 Feb 2016 19:45:21 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: 22692@debbugs.gnu.org Subject: docstring for xref-find-definitions X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 17 Feb 2016 19:45:21 -0800 Message-ID: <673.1455767121@allegro.localdomain> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22692 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Based on the behavior that I observe (using "emacs -Q" to visit src/frame.c), the docstring for xref-find-definitions would be more accurate if the first paragraph were replaced by Find the definition of the identifier at point. If there is no identifier at point, use an identifier (or numeric literal) near point on the same line. With a prefix argument or when there=E2=80=99s no identifier on the current line, prompt for the identif= ier to look up. Trying to look up the definition for a numeric literal strikes me as odd, but that's the behavior I'm seeing. mike From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 18 11:50:40 2016 Received: (at 22692) by debbugs.gnu.org; 18 Feb 2016 16:50:40 +0000 Received: from localhost ([127.0.0.1]:33138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWRmq-0006AY-A3 for submit@debbugs.gnu.org; Thu, 18 Feb 2016 11:50:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40922) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWRmo-0006AL-7s for 22692@debbugs.gnu.org; Thu, 18 Feb 2016 11:50:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWRmf-0006ou-8k for 22692@debbugs.gnu.org; Thu, 18 Feb 2016 11:50:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWRmf-0006oj-4u; Thu, 18 Feb 2016 11:50:29 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1847 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aWRme-0000ZO-C2; Thu, 18 Feb 2016 11:50:28 -0500 Date: Thu, 18 Feb 2016 18:50:45 +0200 Message-Id: <83ziuyt122.fsf@gnu.org> From: Eli Zaretskii To: Mike Kupfer In-reply-to: <673.1455767121@allegro.localdomain> (message from Mike Kupfer on Wed, 17 Feb 2016 19:45:21 -0800) Subject: Re: bug#22692: docstring for xref-find-definitions References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Mike Kupfer > Date: Wed, 17 Feb 2016 19:45:21 -0800 > > Based on the behavior that I observe (using "emacs -Q" to visit > src/frame.c), the docstring for xref-find-definitions would be more > accurate if the first paragraph were replaced by > > Find the definition of the identifier at point. > If there is no identifier at point, use an identifier (or numeric > literal) near point on the same line. We cannot be this specific, not as long as the doc string is literal text defined as part of 'defun'. The exact definition of what is "the identifier at point" depends on the xref backend set up by the major mode. That definition could be very smart or it could be less smart. The command doesn't know. If we want to be accurate here, we will need to come up with a way for the back-end to supply its definition, and incorporate that in the doc string that is created dynamically. Do we have infrastructure for that? Failing that, the only band-aid I can offer is something like Find the definition of the identifier at or near point. If you think it's better, we can make that change now. > Trying to look up the definition for a numeric literal strikes me as > odd, but that's the behavior I'm seeing. Did you use M-. in Emacs 24 and before? Because that's exactly what it did in this case, it would say this in the echo area: Find tag (default 1): The reason is that this is what etags.el does when asked to find "the identifier at or near point". Patches to make it smarter are welcome. (The relevant function is find-tag-default-bounds.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 18 13:48:25 2016 Received: (at 22692) by debbugs.gnu.org; 18 Feb 2016 18:48:25 +0000 Received: from localhost ([127.0.0.1]:33190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWTcm-0002An-Qh for submit@debbugs.gnu.org; Thu, 18 Feb 2016 13:48:25 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:23842 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWTcl-0002Af-2K for 22692@debbugs.gnu.org; Thu, 18 Feb 2016 13:48:23 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1IImKxJ084479; Thu, 18 Feb 2016 10:48:21 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: Eli Zaretskii Subject: Re: bug#22692: docstring for xref-find-definitions In-Reply-To: Your message of "Thu, 18 Feb 2016 18:50:45 +0200." <83ziuyt122.fsf@gnu.org> X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2735.1455821296.1@allegro.localdomain> Date: Thu, 18 Feb 2016 10:48:16 -0800 Message-ID: <2736.1455821296@allegro.localdomain> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Eli Zaretskii wrote: > > From: Mike Kupfer > > Date: Wed, 17 Feb 2016 19:45:21 -0800 > > > > Based on the behavior that I observe (using "emacs -Q" to visit > > src/frame.c), the docstring for xref-find-definitions would be more > > accurate if the first paragraph were replaced by > > > > Find the definition of the identifier at point. > > If there is no identifier at point, use an identifier (or numeric > > literal) near point on the same line. > > We cannot be this specific, not as long as the doc string is literal > text defined as part of 'defun'. The exact definition of what is "the > identifier at point" depends on the xref backend set up by the major > mode. That definition could be very smart or it could be less smart. > The command doesn't know. Okay. Is there an easy way for the user to tell which backend is in use? If there is, then maybe the docstring could say something general and then note that the user could also check the backend's documentation. > If we want to be accurate here, we will need to come up with a way for > the back-end to supply its definition, and incorporate that in the doc > string that is created dynamically. Do we have infrastructure for > that? Not that I know of, but I don't know much about Emacs's documentation infrastructure. > Failing that, the only band-aid I can offer is something like > > Find the definition of the identifier at or near point. > > If you think it's better, we can make that change now. Yes, I think that would be an improvement. Thanks. > > Trying to look up the definition for a numeric literal strikes me as > > odd, but that's the behavior I'm seeing. > > Did you use M-. in Emacs 24 and before? Because that's exactly what > it did in this case, it would say this in the echo area: > > Find tag (default 1): Interesting. I use M-. a lot, and I never noticed this. I suppose it's because I know I'm going to type in the name that I'm looking for, so I ignore the default. > The reason is that this is what etags.el does when asked to find "the > identifier at or near point". Patches to make it smarter are welcome. > (The relevant function is find-tag-default-bounds.) Okay. I'll add this to my spare-time projects list. thanks, mike From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 08:01:56 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 13:01:57 +0000 Received: from localhost ([127.0.0.1]:33580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWkh2-0007sy-Ol for submit@debbugs.gnu.org; Fri, 19 Feb 2016 08:01:56 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33587) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWkh1-0007sm-Hk for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 08:01:55 -0500 Received: by mail-wm0-f49.google.com with SMTP id g62so67713625wme.0 for <22692@debbugs.gnu.org>; Fri, 19 Feb 2016 05:01:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=L5KWgVVHnCkQ/qTGbvVW3mYgEf0lEvbh7PdRI4HHN2I=; b=qczksLuuZG02IJAE8Wj/49qF9ktloTdNSQcZ0buUEYOdz7vPhn6VCwGDhz6OD/OazE qD6saF/OXFg/bf+8/pmxzAAOeaU9LyJWH+SmvHg0BNrqbkkd4kXX0MEdZ8/NGeNh/cSM Cdbk7kucY2HHaI8JTRSRT/dWKIGEUJl3GwRD4Vxgygu4VaFNQZoSJz9yntqazT6CYIuO OhtHx3C77UwbNIQdP8IgPCvcd2aHVW4MtKS93osFk/ZfowGPczVWpK3qgbXmF0FOkNIQ N4QeUraaZlWQMSFToXgDH1b8NoyC1rjawmkIPHafkNrRaQ/lVVBWqTs6DkPFJ1x/mUnL 0SDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=L5KWgVVHnCkQ/qTGbvVW3mYgEf0lEvbh7PdRI4HHN2I=; b=ehQdVe1By7DSHx8ubKH+ycfHFwetTpCHwiiRje62gIbhZjc1XIzwmso5EYpO29QryQ 5Hy/LKzeVpYlusj+g5Dg9o3QG0TJN/15CLdfF7VZoyCZtLNkV+3Bb7bdey/daESCW8oO kJpY1wQiaZNDQpAgrOHTftDYlGRpN+VDj1UnGvxwRT1lr3KFRxfshKxuE7cWKumpsmkW RICpB7qm+nJs7zO6D3M3dfAv20MSmNARxtR19utiYvTpP+4v4dN+eGcvEfUZ5PzMs6fE kx/YE3vC8HJFSej1S/x/nmDMpPw5VhVfqnkuYlj6apbb8m9tTJWq7FeWwm4rD+GjebuZ S9IQ== X-Gm-Message-State: AG10YOS72Z7zwAiNWwl55u9Ddyrb0OuGSG9CazZJM+oggmdCrJ2e2vbvEOF6UJ2K3TXA7g== X-Received: by 10.28.131.134 with SMTP id f128mr9444293wmd.41.1455886910013; Fri, 19 Feb 2016 05:01:50 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id pd1sm11154218wjb.19.2016.02.19.05.01.48 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 05:01:48 -0800 (PST) Subject: Re: bug#22692: docstring for xref-find-definitions To: Eli Zaretskii , Mike Kupfer References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> From: Dmitry Gutov Message-ID: <56C7123A.6040408@yandex.ru> Date: Fri, 19 Feb 2016 15:01:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <83ziuyt122.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/18/2016 06:50 PM, Eli Zaretskii wrote: > Failing that, the only band-aid I can offer is something like > > Find the definition of the identifier at or near point. > > If you think it's better, we can make that change now. Do we really want to codify that behavior? I've switched to use find-tag--default because it seemed appropriate for the etags backend, but the "near point" aspect looks fairly awkward to me, and I imagine third-party backends might choose to omit it. I'd prefer to use the more precise behavior in find-tag-default-bounds as well. And if there's general agreement here, I wouldn't mind taking care of that patch. Also note how careful the find-tag-default is in avoiding prescribing the exact behavior. > Did you use M-. in Emacs 24 and before? Because that's exactly what > it did in this case, it would say this in the echo area: > > Find tag (default 1): > > The reason is that this is what etags.el does when asked to find "the > identifier at or near point". Patches to make it smarter are welcome. > (The relevant function is find-tag-default-bounds.) Not necessarily. Every major mode that knows better should define its own find-tag-default-function (but none do, so far). See the dispatch inside find-tag--default. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 08:04:10 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 13:04:10 +0000 Received: from localhost ([127.0.0.1]:33584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWkjC-0007wR-4o for submit@debbugs.gnu.org; Fri, 19 Feb 2016 08:04:10 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:33233) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWkjA-0007wF-VX for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 08:04:09 -0500 Received: by mail-wm0-f51.google.com with SMTP id g62so67798683wme.0 for <22692@debbugs.gnu.org>; Fri, 19 Feb 2016 05:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=k8SY6KuZD9wICAE1thJ3pd+1osyak0llYt9wG0JnUtQ=; b=oF1yLtHiaOGReqI2eLHMGysZT0IMSU3AuUzcPDttANLV4vYpGrs0Ph7qnOFK37PWyl teYhz2UxxRe6jgkQilq/+pYqovVxS+vgDKUrWXBmp+YnM1I/CmkIs4OPwfstZ2sTFPPl sl7cTfrLFUkAtESlaxrhTKYR4GKIDwbmbqBXw+MNKJ4i4bwSDiKmoCTZNM0zV4tL5JGe 6znieiZErbupOpK2i5O9t3O/D03GAMRXVdpp8dgns5zJ/qk2oKVm0xbKXBp7T2Hb8AT9 Jjfpd8vFxtNM7qVNxEAPL1SjU/gbMGEdPtFRC9bHyjd12Eem/WhB2UlA6tIICt0oCZYw EGtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=k8SY6KuZD9wICAE1thJ3pd+1osyak0llYt9wG0JnUtQ=; b=Xe5eVSWalSBoRwV17GWQGtiUKtBkdh4qFrOGNqo243BxQCoOtMnGJKb4hNJmp6W0M5 krVjgHNUqvQb1czOy3X85bs5GMUun+ba0oOm3+s/dmZzuPbgoiH2EIEYvo4inSZIIQJe HpoeJw/lEfp88hvnn9301+rWgt3hYSf+pLa90twYnc71RYczENSc8wyIBWHhWHy1Tt0H mZ5kmIkUuB68yuBJuOvaIuyVK/sLustiPCIGTHTs+oxsq68jf/AxM7B4LftEb7jGFkSF eH57SyS4mQja64nG6Ko0004a05u0aGiFO3szLzlwTtlSXMTMU5nJ6sTt0YwCNNGEB8Lz 4x8A== X-Gm-Message-State: AG10YORpcc7PaiuTB67bFFzcdJBpLndqVZqb+TwmkA2q6HQVo0AWR2FvQvRaK/iFkH42+g== X-Received: by 10.28.144.10 with SMTP id s10mr8696730wmd.97.1455887043531; Fri, 19 Feb 2016 05:04:03 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id l7sm11218311wjx.14.2016.02.19.05.04.01 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 05:04:02 -0800 (PST) Subject: Re: bug#22692: docstring for xref-find-definitions To: Mike Kupfer , Eli Zaretskii References: <20283.1455584523@allegro.localdomain> <2736.1455821296@allegro.localdomain> From: Dmitry Gutov Message-ID: <56C712C1.9010105@yandex.ru> Date: Fri, 19 Feb 2016 15:04:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <2736.1455821296@allegro.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/18/2016 08:48 PM, Mike Kupfer wrote: > Is there an easy way for the user to tell which backend is in use? You can evaluate (xref-find-backend). But that won't help with the docstrings, I think. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 08:44:08 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 13:44:08 +0000 Received: from localhost ([127.0.0.1]:33603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWlLr-0000Qh-Ua for submit@debbugs.gnu.org; Fri, 19 Feb 2016 08:44:08 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36673) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWlLp-0000Q5-OR for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 08:44:06 -0500 Received: by mail-wm0-f50.google.com with SMTP id g62so76850678wme.1 for <22692@debbugs.gnu.org>; Fri, 19 Feb 2016 05:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=NzzsHsMeMbzF0/GyBg93uuhxC0CSyulzztBzOe0A3CE=; b=CkmyVa3O9HG1ZgPbP8if5lMjPo9KPNFdiamK2gr779TDHylBsMndC5RpqCig8AQyl3 2DyJRhePx6VzV2Ygk73JBubEO87RbRSoj7HQ5UDLxfI255tRrb/hPSuwQWUVrrtDxcD9 Q8HI8X5TlEIe4p/DPqacKeWujmKY4lWlrEXp1kgEjo93yT8/fNFSdpI22yg1cmYwx3d0 dh+EbM6qPoBDqS8WNIsUyfc2IdyZIYXmPOgeKyEG+J2FT1yarDBl8vgbUFq62luWlJDe Qslmr5QfZW7y/COxHMQLzCVAavwILo5D7koQF1dtCKDFMtotDHwlxvs6KLdUGLYdtqe7 8Llw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=NzzsHsMeMbzF0/GyBg93uuhxC0CSyulzztBzOe0A3CE=; b=g5JsLfwVa7nVJ0ZLs/BZVXs3NAjsK2C2LyClw/05Hq+0xBsGuAHHuwrIn0isGUlIDe UZ18uI7JceIMe7kiBSaEVsFn/tYfHSBOeG1yxhgNIEZpOQ/F3c+4I7VAQEifyiAKqM1x XsWpSL5Dhisb0sZXJBm/rIRVwaKPe0pjQpXlnLMx+3FD2pC0YoVLoG1M+z2KR+slP6Y9 usqgIGSH3Q3aUBQ2po+arywoFcFDwojmdDMdaBYvetG/CN4NKmQ6X7/K4//tcE/mAgh9 xHxTndLOU8xBRMrHzzYU/jjxkXliOmueEDhLJMBFuz0VHwumSTaOXJOPtkG4PMtw3DUi v41Q== X-Gm-Message-State: AG10YOQF4wvS3C19mmmmlIOXEzfaoy4Ry2LSoTpilR/UYYEQwfcGAcO6h9oAKodrtCWvsg== X-Received: by 10.194.94.40 with SMTP id cz8mr13335637wjb.17.1455889440204; Fri, 19 Feb 2016 05:44:00 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id v22sm7728505wmv.12.2016.02.19.05.43.58 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 05:43:58 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Mike Kupfer References: <23698.1455674128@allegro.localdomain> From: Dmitry Gutov Message-ID: <56C71C1D.8010502@yandex.ru> Date: Fri, 19 Feb 2016 15:43:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <23698.1455674128@allegro.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/17/2016 03:55 AM, Mike Kupfer wrote: > The Help string for xref-find-definitions says > >> With prefix argument or when there’s no identifier at point, >> prompt for it. > > I guess you could argue that if point is on a token that's not in the > tags table, it's still on an "identifier". Whatever identifier the backend says is there. Which, in the case of etags, delegates to find-tag--default. Validating identifiers against the tags table is a sensible suggestion, but that might backfire in several scenarios: - What if the tags table only contains fully qualified names? We have multiple ways the backend can match tags, defined by etags-xref-find-definitions-tag-order, which might apply even if the identifier is not literally one of the elements. And I'm not sure performing that matching logic just when the default identifier to use is returned, is a good idea. - Either xref-backend-identifier-at-point impl for etags will have to be able to use different logic based on the command currently being invoked (that doesn't really fit in the current design), or you won't be able to look for e.g. occurrences of the local variable at point (using xref-find-references), because etags doesn't parse local variables. > But "#" is hardly an identifier. Apparently it is, as far as find-tag-default-bounds is concerned. In the following sense: find-tag-default-bounds uses the notion of "symbol" as defined by the current syntax table. If "#" can't be a part of an identifier name in the programming language in question (C, right?), maybe you should request that character's syntax class to be changed to something like "punctuation" there. > Does "valid identifier" mean syntatically correct, or does it mean that > the identifier is in the tags table. Please clarify the documentation. We probably should just remove the word "valid" from there. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 10:10:49 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 15:10:49 +0000 Received: from localhost ([127.0.0.1]:34166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWmhl-0002Z6-Lj for submit@debbugs.gnu.org; Fri, 19 Feb 2016 10:10:49 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:53013 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWmhj-0002Yy-LM for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 10:10:48 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1JFAjsi056596; Fri, 19 Feb 2016 07:10:46 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: Dmitry Gutov Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt In-Reply-To: Your message of "Fri, 19 Feb 2016 15:43:57 +0200." <56C71C1D.8010502@yandex.ru> X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8098.1455894645.1@allegro.localdomain> Date: Fri, 19 Feb 2016 07:10:45 -0800 Message-ID: <8099.1455894645@allegro.localdomain> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Dmitry Gutov wrote: > On 02/17/2016 03:55 AM, Mike Kupfer wrote: > > Does "valid identifier" mean syntatically correct, or does it mean that > > the identifier is in the tags table. Please clarify the documentation. > > We probably should just remove the word "valid" from there. Yes, I think that's the right fix. I'll review and respond to the other points you made, but it will probably take me a couple of days to get to it. thanks, mike From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 10:34:30 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 15:34:30 +0000 Received: from localhost ([127.0.0.1]:34189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWn4g-00038b-7s for submit@debbugs.gnu.org; Fri, 19 Feb 2016 10:34:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41920) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWn4e-00038P-Mi for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 10:34:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWn4V-0000YR-MO for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 10:34:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWn4V-0000YM-Iy; Fri, 19 Feb 2016 10:34:19 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3914 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aWn4U-0008Pw-8w; Fri, 19 Feb 2016 10:34:18 -0500 Date: Fri, 19 Feb 2016 17:34:06 +0200 Message-Id: <83vb5kr9xt.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56C7123A.6040408@yandex.ru> (message from Dmitry Gutov on Fri, 19 Feb 2016 15:01:46 +0200) Subject: Re: bug#22692: docstring for xref-find-definitions References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 22692@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 19 Feb 2016 15:01:46 +0200 > > On 02/18/2016 06:50 PM, Eli Zaretskii wrote: > > > Failing that, the only band-aid I can offer is something like > > > > Find the definition of the identifier at or near point. > > > > If you think it's better, we can make that change now. > > Do we really want to codify that behavior? I've switched to use > find-tag--default because it seemed appropriate for the etags backend, > but the "near point" aspect looks fairly awkward to me, and I imagine > third-party backends might choose to omit it. > > I'd prefer to use the more precise behavior in find-tag-default-bounds > as well. And if there's general agreement here, I wouldn't mind taking > care of that patch. Making such a change is fine with me, thanks. > > Did you use M-. in Emacs 24 and before? Because that's exactly what > > it did in this case, it would say this in the echo area: > > > > Find tag (default 1): > > > > The reason is that this is what etags.el does when asked to find "the > > identifier at or near point". Patches to make it smarter are welcome. > > (The relevant function is find-tag-default-bounds.) > > Not necessarily. Every major mode that knows better should define its > own find-tag-default-function (but none do, so far). See the dispatch > inside find-tag--default. If find-tag-default-function is also used by xref-find-references, then it won't be TRT to reject constants up front. A request to find all the places where a certain constant is used is a valid use case. It is indeed unlikely to have such a request for the constant 1, but think about constants like 3.14159 or 3.0e+8. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 11:00:12 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 16:00:13 +0000 Received: from localhost ([127.0.0.1]:34199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWnTY-0003jq-M1 for submit@debbugs.gnu.org; Fri, 19 Feb 2016 11:00:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49812) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWnTV-0003iq-E0 for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 11:00:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWnTN-0008Kw-3h for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 11:00:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWnTN-0008Kr-0B; Fri, 19 Feb 2016 11:00:01 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3936 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aWnTM-0002mX-7R; Fri, 19 Feb 2016 11:00:00 -0500 Date: Fri, 19 Feb 2016 17:59:48 +0200 Message-Id: <83r3g8r8qz.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56C71C1D.8010502@yandex.ru> (message from Dmitry Gutov on Fri, 19 Feb 2016 15:43:57 +0200) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Dmitry Gutov > Date: Fri, 19 Feb 2016 15:43:57 +0200 > Cc: 22692@debbugs.gnu.org > > Validating identifiers against the tags table is a sensible suggestion, It is a valid use case to try to find out whether a symbol already has some definition. In that case, saying "no definition" is what the user will expect for an undefined symbol, so asking for a symbol will confuse. > > Does "valid identifier" mean syntatically correct, or does it mean that > > the identifier is in the tags table. Please clarify the documentation. > > We probably should just remove the word "valid" from there. That depends on how you will change the behavior ;-) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 13:08:48 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 18:08:48 +0000 Received: from localhost ([127.0.0.1]:34258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWpTz-0006ih-R8 for submit@debbugs.gnu.org; Fri, 19 Feb 2016 13:08:48 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36607) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWpTy-0006iU-2G for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 13:08:46 -0500 Received: by mail-wm0-f43.google.com with SMTP id g62so88555079wme.1 for <22692@debbugs.gnu.org>; Fri, 19 Feb 2016 10:08:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=UIoqg7J/EJFOfltSYbm3DNSEhpxa471JFBeJehqpkTw=; b=QfTD0lULBFRuGgp7zMEJMNZ3MRJHwGQP/60mwn1vxRGelaS1sOVaN6Uio7X6IUqvvr 3R+XMIUz1NCgVOaBowUuz5udXCv91hp0gUWzzEIYN1m0jEncwa2RYbgserLJJ+sEGMSp cD3zPInc2p96Qk023PA+mzHYtSlXL29KuKsHCLfUZSgiJG71G1GHJZVhMjGNnHYjlgGu tbf/vL81LLgOclmbxgGxNrMuw+0+Uf4zlRlwO+gbxVb9lHMWLqsVpsqse+M+CcN5db7n c97NcknQPAE084LW2Gjn2bs8gpDk7UWFCzIdfAvXXfdnqfZfF2aUqErLMeRMxegJn98s roZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=UIoqg7J/EJFOfltSYbm3DNSEhpxa471JFBeJehqpkTw=; b=g/yqUHzau4EvESEgPo2p7s3okMDYfLABCJ+d+le5Atu8/O+dm4zv8dQ4RreqcB615c OLvnuChV6TQTsq5jMVTvm/nYUtdGHCp07dEQiXMNKE/yAji4P4aNA/fXWDfOVcujWcDY 33xKWpX4kahJLYdM3vCUnlsQVzCnW8TVVkkxbU5wkdOWAzewN118rxQqzW8fHR6GGj/C y/HCaC9yws9nUcdfVFF+OgUqRlvYeURWmfR1+62eEhe6JiBG5R/pU7khD/EGwNW2XNF8 En2UX+aJaETIETlYvR1pINE3pUXb3qrXdOsNU//nyNf2ru3ppmQMYVlz62mUbL5AFm9O 518A== X-Gm-Message-State: AG10YOQ6oK/fCc4iDY3FYSXYi9JrWbiFZAp2WLTBHh5mkZh9KwFmx9FBGOVP1JQpXRcobA== X-Received: by 10.194.92.68 with SMTP id ck4mr14304343wjb.144.1455905320385; Fri, 19 Feb 2016 10:08:40 -0800 (PST) Received: from [192.168.0.185] ([212.50.99.193]) by smtp.googlemail.com with ESMTPSA id b5sm8670416wmh.15.2016.02.19.10.08.38 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 10:08:39 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Eli Zaretskii References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> <83r3g8r8qz.fsf@gnu.org> From: Dmitry Gutov Message-ID: <56C75A25.3090506@yandex.ru> Date: Fri, 19 Feb 2016 20:08:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <83r3g8r8qz.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/19/2016 05:59 PM, Eli Zaretskii wrote: > It is a valid use case to try to find out whether a symbol already has > some definition. In that case, saying "no definition" is what the > user will expect for an undefined symbol, so asking for a symbol will > confuse. Then we don't need to change anything there, do we? >> We probably should just remove the word "valid" from there. > > That depends on how you will change the behavior ;-) Zero change is best change. :-) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 13:38:13 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 18:38:13 +0000 Received: from localhost ([127.0.0.1]:34275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWpwS-0007Pn-Ti for submit@debbugs.gnu.org; Fri, 19 Feb 2016 13:38:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42098) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWpwR-0007Pa-I4 for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 13:38:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWpwL-0005in-Eq for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 13:38:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWpwF-0005hG-Bf; Fri, 19 Feb 2016 13:37:59 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4090 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aWpwE-0005Cs-Em; Fri, 19 Feb 2016 13:37:58 -0500 Date: Fri, 19 Feb 2016 20:37:44 +0200 Message-Id: <83k2m0r1fr.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56C75A25.3090506@yandex.ru> (message from Dmitry Gutov on Fri, 19 Feb 2016 20:08:37 +0200) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> <83r3g8r8qz.fsf@gnu.org> <56C75A25.3090506@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org > From: Dmitry Gutov > Date: Fri, 19 Feb 2016 20:08:37 +0200 > > On 02/19/2016 05:59 PM, Eli Zaretskii wrote: > > > It is a valid use case to try to find out whether a symbol already has > > some definition. In that case, saying "no definition" is what the > > user will expect for an undefined symbol, so asking for a symbol will > > confuse. > > Then we don't need to change anything there, do we? Yes, I think so. > >> We probably should just remove the word "valid" from there. > > > > That depends on how you will change the behavior ;-) > > Zero change is best change. :-) No, I meant the change you wanted to make in finding the symbol at point, to avoid looking for it anywhere on the same line. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 13:52:41 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 18:52:41 +0000 Received: from localhost ([127.0.0.1]:34284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWqAS-0007kp-PX for submit@debbugs.gnu.org; Fri, 19 Feb 2016 13:52:40 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37822) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWqAR-0007kb-64 for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 13:52:39 -0500 Received: by mail-wm0-f47.google.com with SMTP id g62so83859136wme.0 for <22692@debbugs.gnu.org>; Fri, 19 Feb 2016 10:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=ky1C0gdyi9wZ6VIqBKXLsosEYzsZHhY1S+TZKncAq+w=; b=euNHzkdPTxHyGEDNQqQ+XL807/WH2GVP0YLeVYiX0s7jbeQIT4GI+Vr4x6zR8Tcmvm fCpzujkEMDmXdKYCH7jDLrPcN3o7MZOhyAqMGQ06+C9a8yOXffR8VBQJNdRSwAxqT6AF 2uNsYkEJxGE7VMqUctj4fUZ6B0E1gQK9BxzjmAxwBefZHArOz/Bu8/8bk/QregnYKKsS TMPJJp+Iup1a7O3dstlHEVdQCkve4ftOOeGefPsYu9VoQVT/iK9qgh1Sz2UteLfFSt00 wUdBLJfMKC3lSnIOm70l/U+NSyAqJg3o1YOkOz1epc1mnz1wViBYGp4ivOdM6bOoziEk owuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=ky1C0gdyi9wZ6VIqBKXLsosEYzsZHhY1S+TZKncAq+w=; b=LimbEWMuSqClkApvWRa1lVz6bPHEl/rBLyLFm4fmElRJL0r4G1hWLori4Ut47cu/7R 61KZuzCLhXvRNiFOeI78GoGFxylg/GvpAsv62J5w7ri19GgU/hB8FYHX99lohhCZgh1u Y+zeSGzMBj/O+ik+brQjCoLDCV3HDoy8q8z3JqJliHTqip3CvV8t9C8y1F+Ujkqyt6Q+ flgMnFVCSmXOef5Fg2f0p0fOLc36XnClQZrzCECefpynvUohvFpY+Yf0/XtWn25lFg6o yhrn5Zdtf02jKL4U0x2P4K4qnMLNpJGo08n+SR6oEMvYyAH8bZVb/yE6PUx1ndAcvJnS mOQg== X-Gm-Message-State: AG10YOTcg60BeZynkottuDpqyftI+M8fiQ7JkaY0GM+O05xwDI3QXSdWKIyE80Uc+MObJw== X-Received: by 10.28.109.141 with SMTP id b13mr10129609wmi.25.1455907953555; Fri, 19 Feb 2016 10:52:33 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id k8sm1050931wjr.38.2016.02.19.10.52.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 10:52:30 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Eli Zaretskii References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> <83r3g8r8qz.fsf@gnu.org> <56C75A25.3090506@yandex.ru> <83k2m0r1fr.fsf@gnu.org> From: Dmitry Gutov Message-ID: <56C7646C.7060300@yandex.ru> Date: Fri, 19 Feb 2016 20:52:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <83k2m0r1fr.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/19/2016 08:37 PM, Eli Zaretskii wrote: > No, I meant the change you wanted to make in finding the symbol at > point, to avoid looking for it anywhere on the same line. Isn't that orthogonal to the question of using the word "valid"? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 15:24:56 2016 Received: (at 22692) by debbugs.gnu.org; 19 Feb 2016 20:24:56 +0000 Received: from localhost ([127.0.0.1]:34305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWrbk-0001Z3-8A for submit@debbugs.gnu.org; Fri, 19 Feb 2016 15:24:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44615) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWrbi-0001Ys-PM for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 15:24:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWrbc-0006Bn-Qy for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 15:24:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWrbX-0006B7-Rl; Fri, 19 Feb 2016 15:24:43 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4197 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aWrbX-0005LT-2X; Fri, 19 Feb 2016 15:24:43 -0500 Date: Fri, 19 Feb 2016 22:24:27 +0200 Message-Id: <83d1rsqwhw.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56C7646C.7060300@yandex.ru> (message from Dmitry Gutov on Fri, 19 Feb 2016 20:52:28 +0200) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> <83r3g8r8qz.fsf@gnu.org> <56C75A25.3090506@yandex.ru> <83k2m0r1fr.fsf@gnu.org> <56C7646C.7060300@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org > From: Dmitry Gutov > Date: Fri, 19 Feb 2016 20:52:28 +0200 > > On 02/19/2016 08:37 PM, Eli Zaretskii wrote: > > > No, I meant the change you wanted to make in finding the symbol at > > point, to avoid looking for it anywhere on the same line. > > Isn't that orthogonal to the question of using the word "valid"? Maybe. I don't tend thinking of documentation as a collection of words. When you change how the symbol is determined, I could reason about describing that. I agree that the chances of having "valid" there are rather small. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 20:24:28 2016 Received: (at 22692) by debbugs.gnu.org; 20 Feb 2016 01:24:28 +0000 Received: from localhost ([127.0.0.1]:34387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWwHb-00009i-VV for submit@debbugs.gnu.org; Fri, 19 Feb 2016 20:24:28 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:33680) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWwHa-00009V-LX for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 20:24:27 -0500 Received: by mail-wm0-f43.google.com with SMTP id g62so90137653wme.0 for <22692@debbugs.gnu.org>; Fri, 19 Feb 2016 17:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=5v8dnUSvpbbYnmAFnXi6v5gJmWqt+LPIOb7d7yHYEOk=; b=qM2D+9l6EmlkZ3NDqHp1T3ipUukVLsvYWXXRN0o8/8+D5M4yo+/8irNMrGnIwTm70Z sk4KAaSsZPDkbh3qsctGALmFDVb8W3x7BhJ8UvhGikwVCcbRhI8mFFj+RQFYuuFmXnuz WIWVrqYJTlrhIfuNuSPsP9VBbdE1R3RvqOOjp3WwjcexNJGV/GadfirABWRGcWu8PVSf hXbBU+SnXbsQ2dAuyRDln4irL55VSsCL42aPUzPms+YgTHM+maf2Y2SqKiPP2XXWgwEn 9nRt+4EVv38eUWT5dM4sNuf2pjS6wYZmCGFgTT8UmTuonTPl04I0M17oDk3cCXg60e5S IxFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=5v8dnUSvpbbYnmAFnXi6v5gJmWqt+LPIOb7d7yHYEOk=; b=HgscRHAu5XWqFyCBE+1zzufKr1Bro34jWxbbhy/SwS65MbCSbu3s3sHU4S/7aOVcrY OAmeF9xxxrz8jY5rN91Fy/kFlCXZogKJwdaUC23Djri/GlfLzQSpKGtc9jUbsYkYhYqc IbGzM8VNmtKchRnqzJGGy+SYrOWaBnsIOAw1DBdYGl3H1AVVgiwwE+L4ztS5p07zwqDr QRFruQOCjcNNf/YGfqV0EvNoL6VP9g2jrz77XxloMLLgtRGOZPFHnix4o+j+fghJUqht L9UWAR3HlW/bzWmRiRp38QFgt2Uao4E/IbTV5LTtoDiK3fRULg69WIPYMZR8I4eMGIgR 0Uxw== X-Gm-Message-State: AG10YOTPczKL8kborsHYi0S9vBwylQ+wPz3NuDyooiiG5JAXw4kMi6NMsLOQ1qEN2Bh11Q== X-Received: by 10.194.142.135 with SMTP id rw7mr6156934wjb.84.1455931460914; Fri, 19 Feb 2016 17:24:20 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id x65sm9943350wmg.4.2016.02.19.17.24.19 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 17:24:19 -0800 (PST) Subject: Re: bug#22692: docstring for xref-find-definitions To: Eli Zaretskii References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> From: Dmitry Gutov Message-ID: <56C7C042.2010907@yandex.ru> Date: Sat, 20 Feb 2016 03:24:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <83vb5kr9xt.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, Juri Linkov , m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/19/2016 05:34 PM, Eli Zaretskii wrote: >> I'd prefer to use the more precise behavior in find-tag-default-bounds >> as well. And if there's general agreement here, I wouldn't mind taking >> care of that patch. > > Making such a change is fine with me, thanks. The patch is trivial (*). But can we really make this change? And can we do it in emacs-25? It's a breaking one, but it primarily affects xref (aside from the "obsolete" etags commands). And by doing it now, we can avoid similar breakage in the next Emacs release. The only other place find-tag-default-bounds is used, is in isearch-forward-symbol-at-point. Yuri, was there a reason you chose to use it instead of `bounds-of-thing-at-point'? > If find-tag-default-function is also used by xref-find-references, > then it won't be TRT to reject constants up front. A request to find > all the places where a certain constant is used is a valid use case. > It is indeed unlikely to have such a request for the constant 1, but > think about constants like 3.14159 or 3.0e+8. That's a valid argument. I also don't think numeric literals will create too many false positives, even for xref-find-definitions. (*) diff --git a/lisp/subr.el b/lisp/subr.el index c685f95..5f88d99 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -2626,29 +2626,8 @@ find-tag-default-bounds "Determine the boundaries of the default tag, based on text at point. Return a cons cell with the beginning and end of the found tag. If there is no plausible default, return nil." - (let (from to bound) - (when (or (progn - ;; Look at text around `point'. - (save-excursion - (skip-syntax-backward "w_") (setq from (point))) - (save-excursion - (skip-syntax-forward "w_") (setq to (point))) - (> to from)) - ;; Look between `line-beginning-position' and `point'. - (save-excursion - (and (setq bound (line-beginning-position)) - (skip-syntax-backward "^w_" bound) - (> (setq to (point)) bound) - (skip-syntax-backward "w_") - (setq from (point)))) - ;; Look between `point' and `line-end-position'. - (save-excursion - (and (setq bound (line-end-position)) - (skip-syntax-forward "^w_" bound) - (< (setq from (point)) bound) - (skip-syntax-forward "w_") - (setq to (point))))) - (cons from to)))) + (require 'thingatpt) + (bounds-of-thing-at-point 'symbol)) (defun find-tag-default () "Determine default tag to search for, based on text at point. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 19 20:28:53 2016 Received: (at 22692) by debbugs.gnu.org; 20 Feb 2016 01:28:53 +0000 Received: from localhost ([127.0.0.1]:34391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWwLt-0000Fk-Hb for submit@debbugs.gnu.org; Fri, 19 Feb 2016 20:28:53 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37154) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aWwLs-0000FY-78 for 22692@debbugs.gnu.org; Fri, 19 Feb 2016 20:28:52 -0500 Received: by mail-wm0-f50.google.com with SMTP id g62so93478806wme.0 for <22692@debbugs.gnu.org>; Fri, 19 Feb 2016 17:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=EsNq2VqkxcrJJm51tAKVi9Qlol5xjVh+doK1lBFAqdU=; b=pZHw88BfcDDM2Wph1e8Zy+OK6lmPT2H2FcGjhtjdP6TjrFZ6H0Wk0Q3xmb8zB3OGSP cqQhQA+3NH2pmIGXrtIgbtrY0YmcNDgQr81wOYUEi1xYrtdb5sRGcImtrlPgyl3AzUJ8 bqVC0WE02qXUEU20dBgaHe7tQh2GUw7pozPfJA/hhKLwnhXXVjH5wMuReoqqwxnj8uwD 3BBT1l5GRXfgPhATkXatdFwEBdeV9cZGog8uw/V0hQT8pQ6mk9zhYaz6zcdbEEHSp6Gz qlN1eyeSfFlOqTd4aLfDXPDAarYPYls72dFl9cM2IVadDClRidZxbc5PfIFDvhmAjsca HiZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=EsNq2VqkxcrJJm51tAKVi9Qlol5xjVh+doK1lBFAqdU=; b=LM4r9HmpWGab83msQV8sfVvKiSvm4iHETBR4ZbFC4DWydFLA+bPqR2XeVlxSx3H4iy fAVChFOBfoh9xx75JsjH2ENbiM/acJg5+fGgTDX/xPD9n9zThjon5s3pdQf6s/JWP/Pn teR0PVkz1BY+j/o6JY07F49R5VEZrpXaorePRXa68sf2+OI9k/Vh8pu4nuL4HVfBmVt+ LamsguUocd8FH064Wy5bDmFg65yGUX7PtkktXCY8iAutjga09Fzc2/HGmZTenj+GyhoI PhEnZcxxsFxykRBoxGRb0e4s4kME2bFpBC3aqkbWXnVJaVVAeXj8Jion5IWkxzuZWRk0 tPtg== X-Gm-Message-State: AG10YORQ7qMH2D/yfiAGWxOW/uu2LArzxzaf02H6Y/4/DTEpjfrQgyzBAz3YfEFQEiKYyw== X-Received: by 10.194.112.165 with SMTP id ir5mr6509450wjb.113.1455931726730; Fri, 19 Feb 2016 17:28:46 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id a128sm9932561wmh.6.2016.02.19.17.28.45 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 17:28:45 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Eli Zaretskii References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> <83r3g8r8qz.fsf@gnu.org> <56C75A25.3090506@yandex.ru> <83k2m0r1fr.fsf@gnu.org> <56C7646C.7060300@yandex.ru> <83d1rsqwhw.fsf@gnu.org> From: Dmitry Gutov Message-ID: <56C7C14C.6000200@yandex.ru> Date: Sat, 20 Feb 2016 03:28:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <83d1rsqwhw.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/19/2016 10:24 PM, Eli Zaretskii wrote: >> Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org >> From: Dmitry Gutov >> Date: Fri, 19 Feb 2016 20:52:28 +0200 >> >> On 02/19/2016 08:37 PM, Eli Zaretskii wrote: >> >>> No, I meant the change you wanted to make in finding the symbol at >>> point, to avoid looking for it anywhere on the same line. >> >> Isn't that orthogonal to the question of using the word "valid"? > > Maybe. I don't tend thinking of documentation as a collection of > words. When you change how the symbol is determined, I could reason > about describing that. I agree that the chances of having "valid" > there are rather small. Collection of behaviors, then. We're thinking of two axes. The one touched on in this subthread is "valid" (i.e. whether the symbol must be tested against the completion table before it can be used as the default value; apparently we've settled on "no"). The other is whether we look for the symbol "at" point, or are we also allowed to look "near" point (within the current line), if there's no symbol at point. So far we've got two votes for "no" as well. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 20 03:34:26 2016 Received: (at 22692) by debbugs.gnu.org; 20 Feb 2016 08:34:26 +0000 Received: from localhost ([127.0.0.1]:34553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aX2ze-0005ec-OP for submit@debbugs.gnu.org; Sat, 20 Feb 2016 03:34:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44914) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aX2zc-0005eQ-Md for 22692@debbugs.gnu.org; Sat, 20 Feb 2016 03:34:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aX2zW-0005uM-On for 22692@debbugs.gnu.org; Sat, 20 Feb 2016 03:34:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX2zM-0005qr-GG; Sat, 20 Feb 2016 03:34:04 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4827 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aX2zL-0001RF-Mw; Sat, 20 Feb 2016 03:34:04 -0500 Date: Sat, 20 Feb 2016 10:33:48 +0200 Message-Id: <83wppzpyqb.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56C7C042.2010907@yandex.ru> (message from Dmitry Gutov on Sat, 20 Feb 2016 03:24:18 +0200) Subject: Re: bug#22692: docstring for xref-find-definitions References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, juri@linkov.net, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: m.kupfer@acm.org, 22692@debbugs.gnu.org, Juri Linkov > From: Dmitry Gutov > Date: Sat, 20 Feb 2016 03:24:18 +0200 > > On 02/19/2016 05:34 PM, Eli Zaretskii wrote: > > >> I'd prefer to use the more precise behavior in find-tag-default-bounds > >> as well. And if there's general agreement here, I wouldn't mind taking > >> care of that patch. > > > > Making such a change is fine with me, thanks. > > The patch is trivial (*). But can we really make this change? And can we > do it in emacs-25? Yes and yes, IMO. > It's a breaking one, but it primarily affects xref (aside from the > "obsolete" etags commands). And by doing it now, we can avoid similar > breakage in the next Emacs release. Exactly my thoughts. So I think you should push your change, unless Juri objects. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 20 03:46:10 2016 Received: (at 22692) by debbugs.gnu.org; 20 Feb 2016 08:46:10 +0000 Received: from localhost ([127.0.0.1]:34566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aX3B3-0005wT-Oe for submit@debbugs.gnu.org; Sat, 20 Feb 2016 03:46:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47051) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aX3B2-0005w5-W3 for 22692@debbugs.gnu.org; Sat, 20 Feb 2016 03:46:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aX3Ax-0000Gc-23 for 22692@debbugs.gnu.org; Sat, 20 Feb 2016 03:46:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aX3Ar-0000Dl-Nv; Sat, 20 Feb 2016 03:45:57 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4940 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aX3Ar-0002fY-0v; Sat, 20 Feb 2016 03:45:57 -0500 Date: Sat, 20 Feb 2016 10:45:41 +0200 Message-Id: <83twl3py6i.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56C7C14C.6000200@yandex.ru> (message from Dmitry Gutov on Sat, 20 Feb 2016 03:28:44 +0200) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> <83r3g8r8qz.fsf@gnu.org> <56C75A25.3090506@yandex.ru> <83k2m0r1fr.fsf@gnu.org> <56C7646C.7060300@yandex.ru> <83d1rsqwhw.fsf@gnu.org> <56C7C14C.6000200@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org > From: Dmitry Gutov > Date: Sat, 20 Feb 2016 03:28:44 +0200 > > The other is whether we look for the symbol "at" point, or are we also > allowed to look "near" point (within the current line), if there's no > symbol at point. So far we've got two votes for "no" as well. I think it's okay to find the symbol before or after point in the same manner thingatpt does that. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 20 22:36:06 2016 Received: (at 22692) by debbugs.gnu.org; 21 Feb 2016 03:36:06 +0000 Received: from localhost ([127.0.0.1]:35709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXKoY-0002Wo-57 for submit@debbugs.gnu.org; Sat, 20 Feb 2016 22:36:06 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:56814 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXKoV-0002We-Vq for 22692@debbugs.gnu.org; Sat, 20 Feb 2016 22:36:04 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1L3a1Hi071855; Sat, 20 Feb 2016 19:36:02 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: Eli Zaretskii Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt In-Reply-To: Your message of "Sat, 20 Feb 2016 10:45:41 +0200." <83twl3py6i.fsf@gnu.org> X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2248.1456025761.1@allegro.localdomain> Date: Sat, 20 Feb 2016 19:36:01 -0800 Message-ID: <2249.1456025761@allegro.localdomain> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hmm, I'm afraid I've gotten lost in all the recent discussion. If the documentation is made consistent with the (default) behavior, that would address my core concern. But it sounds like finding the right wording ("at" versus "at or near") is a problem because different backends could have different behavior. If that's true, would "at, or possibly near" (or something like that) work? I'd still like for "valid" to be removed from "valid identifier" because of the ambiguity about what counts as "valid" in this context. mike From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 20 22:43:01 2016 Received: (at 22692) by debbugs.gnu.org; 21 Feb 2016 03:43:01 +0000 Received: from localhost ([127.0.0.1]:35713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXKvE-0002g2-SZ for submit@debbugs.gnu.org; Sat, 20 Feb 2016 22:43:01 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:62164 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXKvD-0002fv-Lf for 22692@debbugs.gnu.org; Sat, 20 Feb 2016 22:43:00 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1L3gv6B072295; Sat, 20 Feb 2016 19:42:58 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: Dmitry Gutov Subject: Re: bug#22692: docstring for xref-find-definitions In-Reply-To: Your message of "Sat, 20 Feb 2016 03:24:18 +0200." <56C7C042.2010907@yandex.ru> X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2269.1456026177.1@allegro.localdomain> Date: Sat, 20 Feb 2016 19:42:57 -0800 Message-ID: <2270.1456026177@allegro.localdomain> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, Eli Zaretskii , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Dmitry Gutov wrote: > On 02/19/2016 05:34 PM, Eli Zaretskii wrote: > > If find-tag-default-function is also used by xref-find-references, > > then it won't be TRT to reject constants up front. A request to find > > all the places where a certain constant is used is a valid use case. > > It is indeed unlikely to have such a request for the constant 1, but > > think about constants like 3.14159 or 3.0e+8. > > That's a valid argument. Agreed. I suppose find-tag-default-function could be enhanced to take an optional flag that says whether the request is for finding references or for finding the definition. Though I'm not sure the additional complexity is worth it. And it would certainly not be part of addressing this bug. mike From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 21 17:56:56 2016 Received: (at 22692) by debbugs.gnu.org; 21 Feb 2016 22:56:56 +0000 Received: from localhost ([127.0.0.1]:36669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXcvw-0008ND-NO for submit@debbugs.gnu.org; Sun, 21 Feb 2016 17:56:56 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38019) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXcvv-0008N1-Az for 22692@debbugs.gnu.org; Sun, 21 Feb 2016 17:56:55 -0500 Received: by mail-wm0-f52.google.com with SMTP id a4so139625224wme.1 for <22692@debbugs.gnu.org>; Sun, 21 Feb 2016 14:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=i10E9yfewaHF/5WUiAMpev/2uo6IjJ7OLDxXf8znYZU=; b=06KDk3JZtB6HdXYPTq8/i3VSsJyuMWC6wYzmX/Bep5FeCtPbWR3NVwewBbJLbYcqZR 1C3KaskXtV9LGgimPuftAgXd61wgl0NeQuooxd0DWjQDdgHAfZuxiE6uEsI7gHH01YV3 ha4cidwnwP/uRjHjM46n6FZd0DhxlZC0+GvouYSYp2NWgzPWCpv9AwVQ5K519JZVYhrW xRa0huop+WxVW0wc7vKcS5iC48P0Sk/C4VIXvOh3SZgyYP4wnxWhaTWcRtUH+NPlwLTS NC16tlqwP22City7JRiDSQukz63G2bEfaZjyKNRJ9jC6XvCNhzMiHM40poIiin5S6GFf oL+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=i10E9yfewaHF/5WUiAMpev/2uo6IjJ7OLDxXf8znYZU=; b=AJ1OlXEnqwJD/IWsYif80FNt3p0nf3HRTB8NghloU+KkRbw2ZvM6tzoAG5LsuGzfWa EyCzP/Xhz3UU7b29ocFvkigqff+8econAiTM0t719G8NQFE198cH0z5+t/JET9RXyQvB PBPKwmzsDv5uY5PbAubmTlxv9E4bePe/cFhlMgQOgLw3GcroRemZeODA0lXd/3sD5+bT 1KhitupT5mPu9CT+SDq2AMXJ+xlcmmV1Wtc7uOQ2ah13urx2Fci4XVL6VNdn8X7ArYRg +ebkKGghZZcN2nTqPtUZdM6SXqiTRxBfCdNRFjjxzKpV4KUqM7T17WL3mWnNg7yszWXO mLow== X-Gm-Message-State: AG10YOTwKlBnsuKDp1G9ik0NqCHa7QC2588LOKUidgaKKejhzYdlvJp++QeCkwqg+QukFQ== X-Received: by 10.28.5.77 with SMTP id 74mr9563316wmf.62.1456095409608; Sun, 21 Feb 2016 14:56:49 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id y3sm18324153wmy.17.2016.02.21.14.56.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 21 Feb 2016 14:56:48 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Mike Kupfer , Eli Zaretskii References: <2249.1456025761@allegro.localdomain> From: Dmitry Gutov Message-ID: <56CA40AE.8060506@yandex.ru> Date: Mon, 22 Feb 2016 00:56:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <2249.1456025761@allegro.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/21/2016 05:36 AM, Mike Kupfer wrote: > But it sounds like finding the > right wording ("at" versus "at or near") is a problem because different > backends could have different behavior. If that's true, would "at, or > possibly near" (or something like that) work? Hopefully not. After all, the generic function that the backends implement is called xref-backend-identifier-at-point. > I'd still like for "valid" to be removed from "valid identifier" because > of the ambiguity about what counts as "valid" in this context. Right. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 19:21:24 2016 Received: (at 22692) by debbugs.gnu.org; 23 Feb 2016 00:21:24 +0000 Received: from localhost ([127.0.0.1]:38662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY0jE-0006Go-Hw for submit@debbugs.gnu.org; Mon, 22 Feb 2016 19:21:24 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:36110 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY0jD-0006Gg-0y for 22692@debbugs.gnu.org; Mon, 22 Feb 2016 19:21:23 -0500 Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 37EBD25006B; Mon, 22 Feb 2016 16:21:21 -0800 (PST) Received: from localhost.linkov.net (62.65.219.226.cable.starman.ee [62.65.219.226]) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPA id DA872250069; Mon, 22 Feb 2016 16:21:19 -0800 (PST) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#22692: docstring for xref-find-definitions Organization: LINKOV.NET References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> <83wppzpyqb.fsf@gnu.org> Date: Tue, 23 Feb 2016 02:04:20 +0200 In-Reply-To: <83wppzpyqb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Feb 2016 10:33:48 +0200") Message-ID: <87k2lwz3j6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> It's a breaking one, but it primarily affects xref (aside from the >> "obsolete" etags commands). And by doing it now, we can avoid similar >> breakage in the next Emacs release. > > Exactly my thoughts. > > So I think you should push your change, unless Juri objects. I'm fine with using bounds-of-thing-at-point if you think it's OK to require thingatpt in core packages such as isearch. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 19:35:22 2016 Received: (at 22692) by debbugs.gnu.org; 23 Feb 2016 00:35:22 +0000 Received: from localhost ([127.0.0.1]:38667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY0wj-0006be-Pd for submit@debbugs.gnu.org; Mon, 22 Feb 2016 19:35:21 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38222) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY0wh-0006bR-Uh for 22692@debbugs.gnu.org; Mon, 22 Feb 2016 19:35:20 -0500 Received: by mail-wm0-f41.google.com with SMTP id a4so186936570wme.1 for <22692@debbugs.gnu.org>; Mon, 22 Feb 2016 16:35:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=ssQ3vwEM4E/hnSnpp+nxj8SFB/SpptJ127RGLpcRomk=; b=G/iQGbsFbHUGrxuHP7h854V00P3LY9NylY7GuWuRUyfICxIqW+pyOVYlf4YtX7X7HK uq1p1w4djNcriF1ZkOOt+IB8VSQFVXrMk1ecI13aFijCcVYSK9qhMBHjRjsijWcKndsE wmb0l5Cu0V+MZaK0Vtg3l00krJNVfK4m5PLQPLe8DaCeIW2+pFSNtfamDjLdAwAxWEyg ZtQqGYL/01dyLQR697TQCCGwVG+LcNJ7Vk556oHwmhURtsCmZTu86XM8f+ImEJ/llPjh 09gtJvuhLU5itNn6fU7IBKv92jH6ZJCLkLR6FbtA8MEREilO+wjM6WDgAGdyvAqSKp5w PcPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=ssQ3vwEM4E/hnSnpp+nxj8SFB/SpptJ127RGLpcRomk=; b=Cdl2skvrtjsUekw5+ezIWQZyCmxi9vwMLi/Adk+K2imhtDzm3nfy+R0hmClneZBX5c ZVpJrFq7qCUD5wZq5xWK4TXMF5xuGfdE6rj/hotYuB+RSneulGFvdvSo1Ng9zNmr7QDL cLiu5J/Vkh1riiE/WeSb6w3mw10iu24S+o9myXDJLjzaryRVgZARrWEMYNWOAxVO17nv W/JIoakILCr/W801tE04eDzwLUnWGC4HMgMlAaiMl3EdFM4K5XJUnAmjtBzG7Y1zaRFz YcU9/oQBWtWJsxLFk+t+NCaYHcXeeHiM+Le1GjJXGniP1JzKsGahA2/Mi9HrbcdmnI4z whoA== X-Gm-Message-State: AG10YOQJF401StqiWsO1nAmjFhKZqwZUzxJ7hCN4QCnHAdtKCzUg0ZDCvgibCdT2EuXP0Q== X-Received: by 10.28.195.9 with SMTP id t9mr15666544wmf.9.1456187714374; Mon, 22 Feb 2016 16:35:14 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id k4sm23541691wmc.12.2016.02.22.16.35.12 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Feb 2016 16:35:13 -0800 (PST) Subject: Re: bug#22692: docstring for xref-find-definitions To: Juri Linkov , Eli Zaretskii References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> <83wppzpyqb.fsf@gnu.org> <87k2lwz3j6.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <56CBA940.2080907@yandex.ru> Date: Tue, 23 Feb 2016 02:35:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <87k2lwz3j6.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02/23/2016 02:04 AM, Juri Linkov wrote: > I'm fine with using bounds-of-thing-at-point if you think it's OK > to require thingatpt in core packages such as isearch. Great, I've pushed that change. Requiring thingatpt doesn't seem to be something significant, as long as we don't have to preload it (and we don't, in this case). The new behavior also seems to fit the related docstrings better: find-tag-default-bounds, find-tag-default, find-tag-default-as-regexp, find-tag-default-as-symbol-regexp all say "at point", not "near" or "on the same line", so it seems we don't even need a NEWS entry here. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 19:42:00 2016 Received: (at 22692) by debbugs.gnu.org; 23 Feb 2016 00:42:00 +0000 Received: from localhost ([127.0.0.1]:38674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY13A-0006mw-GP for submit@debbugs.gnu.org; Mon, 22 Feb 2016 19:42:00 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:20654) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY138-0006mi-5b for 22692@debbugs.gnu.org; Mon, 22 Feb 2016 19:41:58 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1N0fmhj024087 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Feb 2016 00:41:49 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u1N0flHA032387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 23 Feb 2016 00:41:47 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u1N0fkjp026288; Tue, 23 Feb 2016 00:41:46 GMT MIME-Version: 1.0 Message-ID: <6dbef992-f8da-4918-a92d-2c866023cdbe@default> Date: Mon, 22 Feb 2016 16:41:45 -0800 (PST) From: Drew Adams To: Juri Linkov , Eli Zaretskii Subject: RE: bug#22692: docstring for xref-find-definitions References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> <83wppzpyqb.fsf@gnu.org> <87k2lwz3j6.fsf@mail.linkov.net> In-Reply-To: <87k2lwz3j6.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > >> It's a breaking one, but it primarily affects xref (aside from the > >> "obsolete" etags commands). And by doing it now, we can avoid similar > >> breakage in the next Emacs release. > > > > Exactly my thoughts. > > So I think you should push your change, unless Juri objects. >=20 > I'm fine with using bounds-of-thing-at-point if you think it's OK > to require thingatpt in core packages such as isearch. Wrt `bounds-of-thing-at-point', please consider fixing bug #9300. The fix was provided, and it is trivial. See also `bounds-of-thing-at-point' bug #8667. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 19:44:02 2016 Received: (at 22692) by debbugs.gnu.org; 23 Feb 2016 00:44:02 +0000 Received: from localhost ([127.0.0.1]:38678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY157-0006qH-S2 for submit@debbugs.gnu.org; Mon, 22 Feb 2016 19:44:02 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34947) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY155-0006pg-Uy for 22692@debbugs.gnu.org; Mon, 22 Feb 2016 19:44:00 -0500 Received: by mail-wm0-f51.google.com with SMTP id c200so197195386wme.0 for <22692@debbugs.gnu.org>; Mon, 22 Feb 2016 16:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=IbTGT6KMYkbDaZa+nRl7XtfOZyDLImg0kycLhJGwc7M=; b=jcsylyk9gru0ibPEXyh3GFLQRejsT/6nOGRxpuRHa4MQKNX5zZKNDfvMLuG9sFAt8L Vh/2lSHiLmeh2Is8BZ6ArcP7x62lZqiQxqHUMELsbR7LacNfgHfctPBROdkRYNfeimWb NVsZ8Dj+Pm26kxflFXNYVk24HRiMcbrWvpgyIXGjQhyO3awcEqKd1xnQlVA/zK7zLRc9 4oXEZQHR04Pbir8bsG3W9Ll5/TM4YqyYA0D5QKBdVB8os3rx+g1CXiYvMiJfxMxEZ/km 2gN3aXzRhUDp2rQI2TNC2ti0nfwDcAlHY38a1PiFNvXpbiR/QjUQTgtAc57hQHE9eu77 dQyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=IbTGT6KMYkbDaZa+nRl7XtfOZyDLImg0kycLhJGwc7M=; b=ZzhLrFJVVJRQ5Q6LG1sXzo+4V5JDWEjl5fyCjGhbmJkNidVCF4dr4Oh8Nk/3XOhTK3 cPDa4l0hf4OJ39Vf9izojtHEgDuzwzcMsnmFb/Att0+Y9T0xowPNrml98Rmx/zUrkq1/ nxgOaCtSaoVbiWXOtwHZJW5z4SsYBbet1r1xo5g2msbWc7kcbro9gC6CedmH98ZH9MEy Hoj8WXukEmCgN5b0M+rLX9Rz9j5cAaVrMg23j/ZYXk7KVJfUbsgdsRfHm0D8CGBByWDu Gcy2wCivQtbU2aJzu9BcI243P+s19F6yx896aZX+v1WhUjsgH88W63Kc16fI7Jt6p2YC 1o9Q== X-Gm-Message-State: AG10YORuoZlJU8dr3vnRka6OfcvDJ96BHH5E6l1ucMZY6RzDRNThFLjMsMb1CXWzVZgHQg== X-Received: by 10.194.91.233 with SMTP id ch9mr30483242wjb.121.1456188234361; Mon, 22 Feb 2016 16:43:54 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id n131sm23380892wmf.9.2016.02.22.16.43.53 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Feb 2016 16:43:53 -0800 (PST) Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt To: Eli Zaretskii References: <23698.1455674128@allegro.localdomain> <56C71C1D.8010502@yandex.ru> <83r3g8r8qz.fsf@gnu.org> From: Dmitry Gutov Message-ID: <56CBAB48.6000209@yandex.ru> Date: Tue, 23 Feb 2016 02:43:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <83r3g8r8qz.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02/19/2016 05:59 PM, Eli Zaretskii wrote: >>> Does "valid identifier" mean syntatically correct, or does it mean that >>> the identifier is in the tags table. Please clarify the documentation. >> >> We probably should just remove the word "valid" from there. > > That depends on how you will change the behavior ;-) I've changed it like we discussed. However, after reading the quoted text, I'm not quite sure we need to remove "valid". To my eyes, "valid identifier" in that text means "syntactically valid", rather than "an identifier defined somewhere in the current project". The latter would be "an existing identifier", I guess? But that's my impression. If that word raises questions, maybe it doe need clarification, or a replacement. The only option that came to my mind, however, is more unwieldy: "discernible identifier", and it doesn't mean the same thing. The two other uses of "valid identifier" we have inside Emacs (in cc-vars.el and idlwave.el) also mean "syntactically valid". Mike, thoughts? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 21:19:33 2016 Received: (at 22692) by debbugs.gnu.org; 23 Feb 2016 02:19:33 +0000 Received: from localhost ([127.0.0.1]:38717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY2ZZ-0000eX-Kv for submit@debbugs.gnu.org; Mon, 22 Feb 2016 21:19:33 -0500 Received: from shell1.rawbw.com ([198.144.192.42]:39829 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY2ZX-0000eQ-LR for 22692@debbugs.gnu.org; Mon, 22 Feb 2016 21:19:32 -0500 Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u1N2JTNP085871; Mon, 22 Feb 2016 18:19:30 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain From: Mike Kupfer To: Dmitry Gutov Subject: Re: bug#22692: 25.0.91; xref-find-definitions fails to prompt In-Reply-To: Your message of "Tue, 23 Feb 2016 02:43:52 +0200." <56CBAB48.6000209@yandex.ru> X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.0.91 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13912.1456193968.1@allegro.localdomain> Date: Mon, 22 Feb 2016 18:19:28 -0800 Message-ID: <13913.1456193968@allegro.localdomain> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Dmitry Gutov wrote: > I've changed it like we discussed. Thanks! > However, after reading the quoted text, I'm not quite sure we need to > remove "valid". To my eyes, "valid identifier" in that text means > "syntactically valid", rather than "an identifier defined somewhere in > the current project". The latter would be "an existing identifier", I > guess? [...] > The two other uses of "valid identifier" we have inside Emacs (in > cc-vars.el and idlwave.el) also mean "syntactically valid". In cc-vars.el, "syntactically valid identifiers" appears earlier in the paragraph, so when "valid identifiers" appears later, the interpretation is clear. In idlwave.el, "valid identifier" is used in a comment. I think it's ambiguous (on its own, without studying the surrounding code), but since it's just a comment, I don't care so much about it. (This is as of Emacs 25.0.91; I didn't check the latest in the emacs-25 git branch.) > Mike, thoughts? I have a slight preference for removing "valid" from the Info text, since that change makes the text a little more concise. But I'd also be fine with changing to it to "syntactically valid identifier". cheers, mike From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 27 05:32:41 2016 Received: (at 22692) by debbugs.gnu.org; 27 Feb 2016 10:32:41 +0000 Received: from localhost ([127.0.0.1]:48184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZcAz-0004fr-68 for submit@debbugs.gnu.org; Sat, 27 Feb 2016 05:32:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42574) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZcAx-0004ff-6l for 22692@debbugs.gnu.org; Sat, 27 Feb 2016 05:32:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZcAp-0006OP-1U for 22692@debbugs.gnu.org; Sat, 27 Feb 2016 05:32:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZcAo-0006OJ-Ts; Sat, 27 Feb 2016 05:32:30 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4605 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aZcAo-00019r-4D; Sat, 27 Feb 2016 05:32:30 -0500 Date: Sat, 27 Feb 2016 12:32:11 +0200 Message-Id: <8360xacul0.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <56CBA940.2080907@yandex.ru> (message from Dmitry Gutov on Tue, 23 Feb 2016 02:35:12 +0200) Subject: Re: bug#22692: docstring for xref-find-definitions References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> <83wppzpyqb.fsf@gnu.org> <87k2lwz3j6.fsf@mail.linkov.net> <56CBA940.2080907@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: m.kupfer@acm.org, 22692@debbugs.gnu.org > From: Dmitry Gutov > Date: Tue, 23 Feb 2016 02:35:12 +0200 > > On 02/23/2016 02:04 AM, Juri Linkov wrote: > > > I'm fine with using bounds-of-thing-at-point if you think it's OK > > to require thingatpt in core packages such as isearch. > > Great, I've pushed that change. Requiring thingatpt doesn't seem to be > something significant, as long as we don't have to preload it (and we > don't, in this case). > > The new behavior also seems to fit the related docstrings better: > find-tag-default-bounds, find-tag-default, find-tag-default-as-regexp, > find-tag-default-as-symbol-regexp all say "at point", not "near" or "on > the same line", so it seems we don't even need a NEWS entry here. The current doc string looks OK to me: it describes the behavior very well. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 27 07:35:30 2016 Received: (at 22692) by debbugs.gnu.org; 27 Feb 2016 12:35:30 +0000 Received: from localhost ([127.0.0.1]:48228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZe5q-0002on-CL for submit@debbugs.gnu.org; Sat, 27 Feb 2016 07:35:30 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37324) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZe5p-0002oc-6C for 22692@debbugs.gnu.org; Sat, 27 Feb 2016 07:35:29 -0500 Received: by mail-wm0-f42.google.com with SMTP id g62so100993296wme.0 for <22692@debbugs.gnu.org>; Sat, 27 Feb 2016 04:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=0QaFk2umZ2cut0PdbQ/yCPdCuV2Wnm/VWm8AO5AWBLw=; b=lYs5g+DFFpKgIjD4sz2ieGNUvxpptiiHJkKZJE/Ozii3pVVMI7A/z3RRtnw157VHbG q3RnwFKyQLBWVCo59JqsGnBlA8+k8GWv58hCnNYVTE91posWWP4yLtS92N8IrDlJC3DF jsDdnqHfgijHb5lU3jEuhroAiPP08xQ/3sdDV8b3IPcaVaiDAD4516Agwu0P9P/8dU4V T7KUiJW5+pX/L6pNFmf4cq8xREKhHb2CESiuFsQy95Hft4iKEl5bsu3HlPZEV4nC3qtN iUg9TxemaYkf7Yl7lG04SvkXNnemLZYQJfb1XWdKPG/Cwd6xhCeUHyKuiiHPFmI9e0SX PHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=0QaFk2umZ2cut0PdbQ/yCPdCuV2Wnm/VWm8AO5AWBLw=; b=mE0NOyuuq6TmSf82rdtzSZOPacTM4r+gMM3DDdExIKx9EYqTth1CYfOEhYvPOqGkRJ zdnFSaqT8wRN4Zk/Wn/QgefgLVgCyM/I9/GpDNTEuOy9jBO3eaPJ5I0/LfhxQiYtPSgY dpRqac4h8KLtn30PHK/z4d06dtw9G1CpnQ3SqLx6Wrzck+Ax819kLFJcXEVdYCeYIm2Q 4CQlrHzc3BCDcE+HfiiXsau2YRzRSzZMJlsZr7MeMl7HBtseZxdOpL5cfQaCQIGOdrVy BzTzMfH84x4leD8xpnD0i0jeACVg0wVpGGD0TGx7v8kZiqJcqSYbrIOo+VPHHZrxzNOZ +Apg== X-Gm-Message-State: AD7BkJI/UhIidTNbgUiFle9LKgYvYvoxjgFN3Nj8UI7DD2X9/FRi54z6evptNmoUH+DUxQ== X-Received: by 10.194.63.144 with SMTP id g16mr7421826wjs.149.1456576523532; Sat, 27 Feb 2016 04:35:23 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id i1sm16469564wjs.45.2016.02.27.04.35.21 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 27 Feb 2016 04:35:22 -0800 (PST) Subject: Re: bug#22692: docstring for xref-find-definitions To: Eli Zaretskii References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> <83wppzpyqb.fsf@gnu.org> <87k2lwz3j6.fsf@mail.linkov.net> <56CBA940.2080907@yandex.ru> <8360xacul0.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Sat, 27 Feb 2016 14:35:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <8360xacul0.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02/27/2016 12:32 PM, Eli Zaretskii wrote: > The current doc string looks OK to me: it describes the behavior very > well. Great. I believe the only thing holding this bug is making the choice about the "valid" in the manual. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 27 07:43:43 2016 Received: (at 22692) by debbugs.gnu.org; 27 Feb 2016 12:43:43 +0000 Received: from localhost ([127.0.0.1]:48236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZeDk-00030L-CL for submit@debbugs.gnu.org; Sat, 27 Feb 2016 07:43:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35341) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZeDi-000308-MF for 22692@debbugs.gnu.org; Sat, 27 Feb 2016 07:43:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZeDc-0004b0-UH for 22692@debbugs.gnu.org; Sat, 27 Feb 2016 07:43:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZeDU-0004a3-6o; Sat, 27 Feb 2016 07:43:24 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aZeDT-00085H-CB; Sat, 27 Feb 2016 07:43:23 -0500 Date: Sat, 27 Feb 2016 14:43:04 +0200 Message-Id: <83twkub9yf.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Sat, 27 Feb 2016 14:35:20 +0200) Subject: Re: bug#22692: docstring for xref-find-definitions References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> <83wppzpyqb.fsf@gnu.org> <87k2lwz3j6.fsf@mail.linkov.net> <56CBA940.2080907@yandex.ru> <8360xacul0.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22692 Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 22692@debbugs.gnu.org, juri@linkov.net, m.kupfer@acm.org > From: Dmitry Gutov > Date: Sat, 27 Feb 2016 14:35:20 +0200 > > On 02/27/2016 12:32 PM, Eli Zaretskii wrote: > > > The current doc string looks OK to me: it describes the behavior very > > well. > > Great. I believe the only thing holding this bug is making the choice > about the "valid" in the manual. You mean, whether to remove the "valid" part from the 2nd sentence reproduced below? ‘M-.’ (‘xref-find-definitions’) shows the definitions of the identifier at point. With a prefix argument, or if there’s no valid identifier at point, it prompts for the identifier. ^^^^^ I'd say let's remove it. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 21:49:05 2016 Received: (at 22692-done) by debbugs.gnu.org; 29 Feb 2016 02:49:05 +0000 Received: from localhost ([127.0.0.1]:51173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaDtR-0001lR-I2 for submit@debbugs.gnu.org; Sun, 28 Feb 2016 21:49:05 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36879) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaDtP-0001kv-UY for 22692-done@debbugs.gnu.org; Sun, 28 Feb 2016 21:49:04 -0500 Received: by mail-wm0-f41.google.com with SMTP id p65so27544282wmp.0 for <22692-done@debbugs.gnu.org>; Sun, 28 Feb 2016 18:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=vSEmb6rlZxs2eLtqGa5Yhky6119fc1HhZXjFkQdVgb8=; b=M6xmfohKxnZ9omSOG5dZVhyA5dQnDdjUNWhSxhIRTFQ+WR0TsEnb7Laary1UMHm6hw Cwlqfg2K6kswdRSsQoBBO8ZWWnBNlNBHO1JD/KwBmqmTPsoRetMuAYbnph4c0kobAqYh ZSo3dbZfAxOTNZEcDN7Yr1UHPvZ/wDaOSK52hRSmT4hedou13wtuHmMzX0oJ3snC/3mC 2PhsRBMt1wwA99Fj4txXaHveiWNWVLO9JkemVTQ4aAHCXV/lrNfGWWpVNFQtzcXwPQJg nh3U2WotelJ9VURwsRrSgUuz7FLo2VWaDSXD4SYMHc/gY/2Wzc+GljOEmLvRRLiLj2kK s3tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=vSEmb6rlZxs2eLtqGa5Yhky6119fc1HhZXjFkQdVgb8=; b=UF2Pw4A2GYq2Ff6KPySMyUE4hGl4IDMePxq4gQODy9ygAudqem7kZUJNQ0I5Ls6G19 Tq4ATZn+moXKxgJ1Jzt2uEoYsCPLzk3ZSEcheNtvY/7dIZttGFXJwNvf4Ag7NuYOxt8J PGAaClHHHbUbMfQfOUhuGnO3/4I3SShEc+b2tXGW8727zD+dPjTLKhu+8q/VQUWRlNcR UlNn65JdXIVvToxCvHND7eodMvH+PrJjIagbN8Kz05+gu0q2/KkVJHx7pI8EWnkOvoQf 7fpOQVrtI4LKjCAy1Kf2M65RSCn4Phc9EDcwKT9FVBetrwenSsei/F2w5dQkNhij9a4K WR/g== X-Gm-Message-State: AD7BkJLEGPcbcTdUpTz0u+bgq4IN8QAidGQb8tWBoElXMr0qsYA+WQTq/Vb/9Xr/vQ1AlQ== X-Received: by 10.194.123.102 with SMTP id lz6mr13988532wjb.2.1456714137998; Sun, 28 Feb 2016 18:48:57 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id gt7sm23724560wjc.1.2016.02.28.18.48.56 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 28 Feb 2016 18:48:56 -0800 (PST) Subject: Re: bug#22692: docstring for xref-find-definitions To: Eli Zaretskii References: <20283.1455584523@allegro.localdomain> <673.1455767121@allegro.localdomain> <83ziuyt122.fsf@gnu.org> <56C7123A.6040408@yandex.ru> <83vb5kr9xt.fsf@gnu.org> <56C7C042.2010907@yandex.ru> <83wppzpyqb.fsf@gnu.org> <87k2lwz3j6.fsf@mail.linkov.net> <56CBA940.2080907@yandex.ru> <8360xacul0.fsf@gnu.org> <83twkub9yf.fsf@gnu.org> From: Dmitry Gutov Message-ID: <23082e9e-0d6e-9dc0-d399-d80b33cb1e26@yandex.ru> Date: Mon, 29 Feb 2016 04:48:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <83twkub9yf.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22692-done Cc: 22692-done@debbugs.gnu.org, m.kupfer@acm.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 02/27/2016 02:43 PM, Eli Zaretskii wrote: > You mean, whether to remove the "valid" part from the 2nd sentence > reproduced below? > > ‘M-.’ (‘xref-find-definitions’) shows the definitions of the > identifier at point. With a prefix argument, or if there’s no valid > identifier at point, it prompts for the identifier. ^^^^^ > > I'd say let's remove it. Indeed, that seems the easier choice. Pushed, and marking this done. From unknown Fri Sep 05 11:50:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 28 Mar 2016 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator