From unknown Mon Jun 23 07:48:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#22624 <22624@debbugs.gnu.org> To: bug#22624 <22624@debbugs.gnu.org> Subject: Status: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd Reply-To: bug#22624 <22624@debbugs.gnu.org> Date: Mon, 23 Jun 2025 14:48:19 +0000 retitle 22624 [bug-coreutils] coreutils-8.25: big success, but problem on G= NU/Hurd reassign 22624 coreutils submitter 22624 "Nelson H. F. Beebe" severity 22624 normal tag 22624 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 16:58:34 2016 Received: (at submit) by debbugs.gnu.org; 10 Feb 2016 21:58:34 +0000 Received: from localhost ([127.0.0.1]:35414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTcmH-0004zA-Q0 for submit@debbugs.gnu.org; Wed, 10 Feb 2016 16:58:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37426) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTcmD-0004yu-CM for submit@debbugs.gnu.org; Wed, 10 Feb 2016 16:58:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTcm6-0007Q0-OW for submit@debbugs.gnu.org; Wed, 10 Feb 2016 16:58:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTcm6-0007Pw-Kr for submit@debbugs.gnu.org; Wed, 10 Feb 2016 16:58:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTcm4-0005iP-Ml for bug-coreutils@gnu.org; Wed, 10 Feb 2016 16:58:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTcm1-0007Op-Ek for bug-coreutils@gnu.org; Wed, 10 Feb 2016 16:58:12 -0500 Received: from mail.math.utah.edu ([155.101.98.135]:52157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTcm0-0007ND-Vh for bug-coreutils@gnu.org; Wed, 10 Feb 2016 16:58:09 -0500 Received: from gamma.math.utah.edu (gamma.math.utah.edu [155.101.96.20]) by mail.math.utah.edu (8.14.8/8.14.8) with ESMTP id u1ALvroF001110; Wed, 10 Feb 2016 14:57:58 -0700 (MST) Received: from gamma.math.utah.edu (localhost [127.0.0.1]) by gamma.math.utah.edu (8.15.1/8.15.1) with ESMTP id u1ALvro7065581; Wed, 10 Feb 2016 14:57:53 -0700 Received: (from beebe@localhost) by gamma.math.utah.edu (8.15.1/8.15.1/Submit) id u1ALvrEg065579; Wed, 10 Feb 2016 14:57:53 -0700 Date: Wed, 10 Feb 2016 14:57:53 -0700 From: "Nelson H. F. Beebe" To: bug-coreutils@gnu.org X-US-Mail: "Department of Mathematics, 110 LCB, University of Utah, 155 S 1400 E RM 233, Salt Lake City, UT 84112-0090, USA" X-Telephone: +1 801 581 5254 X-FAX: +1 801 581 4148 X-URL: http://www.math.utah.edu/~beebe Subject: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd Message-ID: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.8 (mail.math.utah.edu [155.101.98.135]); Wed, 10 Feb 2016 14:57:58 -0700 (MST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: beebe@math.utah.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I'm pleased to report successful builds, validations, and installations of coreutils-8.25 on at least 72 of the 77 machines in our lab running various flavors of Unix. The one problematic system is GNU/Hurd, aka Debian GNU/Hurd stretch/sid. We ran Hurd on VMware/ESX for a couple of years, but it was never stable, and crashed or hung every few hours. Every such failure requires a manual fsck on reboot, preventing automated recovery. Last summer, I moved Hurd to virt-manager + QEMU on my desktop, where it has proved substantially more stable, sometimes staying up for many days. Debian GNU/Hurd has about 47,580 packages available in the Debian apt-get system, so others have clearly done a lot of work on it. There are major, and reasonably-current, packages like these available via apt-get: /usr/bin/clang-3.6 --version Debian clang version 3.6.2-1 (tags/RELEASE_362/final) (based on LLVM 3.6.2) Target: i386-pc--gnu Thread model: posix /usr/bin/gcc --version gcc (Debian 5.2.1-26) 5.2.1 20151125 /bin/ls --version ls (GNU coreutils) 8.23 With builds of coreutils-8.25 at my site, the "make check" run ALWAYS hangs Hurd, requiring a reboot and an fsck. I've just made further experiments that confirm that the hang always happens in the same place, about 60 seconds after starting this command: $ make check ... lots of PASS reports, except FAIL in tests/misc/kill.sh and tests/split/filter.sh ... PASS: tests/split/b-chunk.sh PASS: tests/split/fail.sh PASS: tests/split/lines.sh line-bytes.sh: skipped test: this shell lacks ulimit support SKIP: tests/split/line-bytes.sh Timeout, server 192.168.122.66 not responding. The default memory size is 1GB, but today I got the same results when the VM was restarted with 2GB and with 8GB. I have also run the "make check" in a console window, eliminating possible network timeouts from the dataflow, with "top" running in a separate xterm + ssh window, and got this output at the point of the hang: # in console window SKIP: tests/split/line-bytes.sh no more room for vm_map_find_entry in 8022b080 no more room for kmem_realloc in 8022b080 /hurd/mach-defpage: panic: (default pager): # in simulataneous xterm window % top top - 14:10:49 up 10 min, 8 users, load average: 0.55, 1.33, 1.46 Tasks: 74 total, 2 running, 69 sleeping, 0 stopped, 0 zombie %Cpu(s): 54.3 us, 0.0 sy, 0.0 ni, 45.7 id, 0.0 wa, 0.0 hi, 0.0 si KiB Mem: 1900540 total, 1550052 used, 350488 free, 0 buffers KiB Swap: 0 total, 0 used, 0 free. 1792 cached Mem PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 1015 beebe 20 0 151616 144 0 S 0.0 0.0 0:00.02 -bash 1081 beebe 30 10 150060 148 0 S 0.0 0.0 0:00.00 time The coreutils developers should probably not view this as a coreutils bug, because Hurd has many oddities, and the pager-panic report definitely suggests a kernel issue. However, because coreutils has long been built and distributed on Hurd, I thought it would be worthwhile to at least report my experience, in the hope that other list members with GNU/Hurd systems might be able to report their own result with the latest coreutils. I unfortunately do not have any spare physical hardware on which to run GNU/Hurd; my only access to it is on virtual machines. My desktop is currently running 18 different VMs, on top of its CentOS 7 base operating system. Apart from GNU/Hurd, all of the others have been perfectly stable for 4 to 6 months of operation, so I think that it is unlikely that the above failure is due to the virtual machine environment. There are two significant differences, however: the others have virtual SATA disks and are 64-bit systems, whereas Hurd supports only (virtual) EIDE disks, and is a 32-bit system. Our suspicions of the instability of Hurd on VMware/ESX have to do with the EIDE virtual disk system, which may have been less well tested than SATA. ------------------------------------------------------------------------------- - Nelson H. F. Beebe Tel: +1 801 581 5254 - - University of Utah FAX: +1 801 581 4148 - - Department of Mathematics, 110 LCB Internet e-mail: beebe@math.utah.edu - - 155 S 1400 E RM 233 beebe@acm.org beebe@computer.org - - Salt Lake City, UT 84112-0090, USA URL: http://www.math.utah.edu/~beebe/ - ------------------------------------------------------------------------------- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 21:40:01 2016 Received: (at 22624) by debbugs.gnu.org; 11 Feb 2016 02:40:01 +0000 Received: from localhost ([127.0.0.1]:35559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aThAm-0006R5-Pa for submit@debbugs.gnu.org; Wed, 10 Feb 2016 21:40:00 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59115) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aThAk-0006Qp-JQ for 22624@debbugs.gnu.org; Wed, 10 Feb 2016 21:39:59 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1D8D81601A6; Wed, 10 Feb 2016 18:39:53 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id g3tzBfwPycU1; Wed, 10 Feb 2016 18:39:51 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1D35F1601A8; Wed, 10 Feb 2016 18:39:51 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id YuMYH3-1IRLd; Wed, 10 Feb 2016 18:39:50 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EE6C01601A6; Wed, 10 Feb 2016 18:39:50 -0800 (PST) Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: "Nelson H. F. Beebe" , 22624@debbugs.gnu.org References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <56BBF476.5010902@cs.ucla.edu> Date: Wed, 10 Feb 2016 18:39:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------080606090007070901030708" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 22624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) This is a multi-part message in MIME format. --------------080606090007070901030708 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/10/2016 01:57 PM, Nelson H. F. Beebe wrote: > SKIP: tests/split/line-bytes.sh > Timeout, server 192.168.122.66 not responding. I presume the test that crashes your system is tests/split/l-chunk.sh, which invokes commands like 'split -n l/10 /dev/null' and 'split -n 1/2 /dev/zero'. This sounds like , which was reported for GNU/Hurd. Most likely GNU/Hurd is reporting an st_size of OFF_T_MAX for /dev/zero, and this is messing up 'split'. I will look into fixing this; I expect that the bottom line is that split should not trust st_size for special files like /dev/zero. --------------080606090007070901030708 Content-Type: text/plain; charset=UTF-8; name="hurdtest.c" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="hurdtest.c" I2RlZmluZSBfRklMRV9PRkZTRVRfQklUUyA2NAojaW5jbHVkZSA8ZmNudGwuaD4KI2luY2x1 ZGUgPHN5cy9zdGF0Lmg+CiNpbmNsdWRlIDxzdGRpby5oPgojaW5jbHVkZSA8dW5pc3RkLmg+ CgpzdGF0aWMgaW50CnJlcG9ydCAoY2hhciBjb25zdCAqZmlsZSkKewogIHN0cnVjdCBzdGF0 IHN0OwogIG9mZl90IGN1cl9vZmZzZXQ7CiAgb2ZmX3QgZW5kX29mZnNldDsKICBpbnQgZmQg PSBvcGVuICgiL2Rldi96ZXJvIiwgT19SRE9OTFkpOwogIHByaW50ZiAoImZpbGU9JXNcbiIs IGZpbGUpOwogIGlmIChmZCA8IDApCiAgICByZXR1cm4gcGVycm9yICgib3BlbiIpLCAxOwog IGlmIChmc3RhdCAoZmQsICZzdCkgIT0gMCkKICAgIHJldHVybiBwZXJyb3IgKCJmc3RhdCIp LCAxOwogIGlmIChTX0lTUkVHIChzdC5zdF9tb2RlKSkKICAgIHByaW50ZiAoIklTUkVHXG4i KTsKICBlbHNlIGlmIChTX0lTTE5LIChzdC5zdF9tb2RlKSkKICAgIHByaW50ZiAoIklTTE5L XG4iKTsKI2lmZGVmIFNfVFlQRUlTU0hNCiAgZWxzZSBpZiAoU19UWVBFSVNTSE0gKCZzdCkp CiAgICBwcmludGYgKCJUWVBFSVNTSE1cbiIpOwojZW5kaWYKI2lmZGVmIFNfVFlQRUlTVE1P CiAgZWxzZSBpZiAoU19UWVBFSVNUTU8gKCZzdCkpCiAgICBwcmludGYgKCJUWVBFSVNUTU9c biIpOwojZW5kaWYKICBlbHNlIGlmIChTX0lTQkxLIChzdC5zdF9tb2RlKSkKICAgIHByaW50 ZiAoIkJMS1xuIik7CiAgZWxzZSBpZiAoU19JU0NIUiAoc3Quc3RfbW9kZSkpCiAgICBwcmlu dGYgKCJDSFJcbiIpOwogIGVsc2UKICAgIHByaW50ZiAoInVua25vd24gbW9kZSAwJWxvXG4i LCAodW5zaWduZWQgbG9uZykgc3Quc3RfbW9kZSk7CiAgY3VyX29mZnNldCA9IGxzZWVrIChm ZCwgMCwgU0VFS19DVVIpOwogIGlmIChjdXJfb2Zmc2V0IDwgMCkKICAgIHJldHVybiBwZXJy b3IgKCJsc2VlayBDVVIiKSwgMTsKICBlbmRfb2Zmc2V0ID0gbHNlZWsgKGZkLCAwLCBTRUVL X0VORCk7CiAgaWYgKGVuZF9vZmZzZXQgPCAwKQogICAgcmV0dXJuIHBlcnJvciAoImxzZWVr IEVORCIpLCAxOwogIHByaW50ZiAoInN0X3NpemU9JWxsZFxuIiwgKGxvbmcgbG9uZykgc3Qu c3Rfc2l6ZSk7CiAgcHJpbnRmICgic3RfYmxrc2l6ZT0lbGxkXG4iLCAobG9uZyBsb25nKSBz dC5zdF9ibGtzaXplKTsKICBwcmludGYgKCJzdF9ibG9ja3M9JWxsZFxuIiwgKGxvbmcgbG9u Zykgc3Quc3RfYmxvY2tzKTsKICBwcmludGYgKCJjdXJfb2Zmc2V0PSVsbGRcbiIsIChsb25n IGxvbmcpIGN1cl9vZmZzZXQpOwogIHByaW50ZiAoImVuZF9vZmZzZXQ9JWxsZFxuIiwgKGxv bmcgbG9uZykgZW5kX29mZnNldCk7CiAgcHJpbnRmICgicGFnZXNpemU9JWxsZFxuIiwgKGxv bmcgbG9uZykgZ2V0cGFnZXNpemUgKCkpOwogIHByaW50ZiAoIlxuIik7CiAgaWYgKGxzZWVr IChmZCwgY3VyX29mZnNldCwgU0VFS19TRVQpIDwgMCkKICAgIHJldHVybiBwZXJyb3IgKCJs c2VlayBTRVQiKSwgMTsKICBpZiAoY2xvc2UgKGZkKSAhPSAwKQogICAgcmV0dXJuIHBlcnJv ciAoImNsb3NlIiksIDE7CiAgcmV0dXJuIDA7Cn0KCmludAptYWluIChpbnQgYXJnYywgY2hh ciAqKmFyZ3YpCnsKICBzdGF0aWMgY2hhciBkZXZfemVyb1tdID0gIi9kZXYvemVybyI7CiAg c3RhdGljIGNoYXIgZGV2X251bGxbXSA9ICIvZGV2L3plcm8iOwogIHN0YXRpYyBjaGFyICpk ZXZfemVyb19hcmd2W10gPSB7IGRldl96ZXJvLCBkZXZfbnVsbCwgMCB9OwogIGNoYXIgKiph diA9IGFyZ2MgPT0gMSA/IGRldl96ZXJvX2FyZ3YgOiBhcmd2ICsgMTsKICB3aGlsZSAoKmF2 KQogICAgaWYgKHJlcG9ydCAoKmF2KyspICE9IDApCiAgICAgIHJldHVybiAxOwogIHJldHVy biAwOwp9Cg== --------------080606090007070901030708-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 22:08:51 2016 Received: (at 22624) by debbugs.gnu.org; 11 Feb 2016 03:08:51 +0000 Received: from localhost ([127.0.0.1]:35563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aThch-00075z-4q for submit@debbugs.gnu.org; Wed, 10 Feb 2016 22:08:51 -0500 Received: from mail.magicbluesmoke.com ([82.195.144.49]:42778) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aThce-00075q-Vd for 22624@debbugs.gnu.org; Wed, 10 Feb 2016 22:08:49 -0500 Received: from localhost.localdomain (c-73-70-29-104.hsd1.ca.comcast.net [73.70.29.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id 4388B98BC; Thu, 11 Feb 2016 03:08:45 +0000 (GMT) Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: "Nelson H. F. Beebe" , 22624@debbugs.gnu.org References: From: =?UTF-8?Q?P=c3=a1draig_Brady?= Message-ID: <56BBFB3B.80108@draigBrady.com> Date: Wed, 10 Feb 2016 19:08:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 10/02/16 13:57, Nelson H. F. Beebe wrote: > I'm pleased to report successful builds, validations, and > installations of coreutils-8.25 on at least 72 of the 77 machines in > our lab running various flavors of Unix. Looks like were improving well in portability :) Many thanks for giving access to, support for, and now verification on these machines. It's been invaluable. > The one problematic system is GNU/Hurd, aka Debian GNU/Hurd Paul looks to be on the right track here. cheers, P�draig. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 11 03:31:05 2016 Received: (at 22624) by debbugs.gnu.org; 11 Feb 2016 08:31:05 +0000 Received: from localhost ([127.0.0.1]:35645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTmeX-0006BI-0g for submit@debbugs.gnu.org; Thu, 11 Feb 2016 03:31:05 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:61100) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTmeU-0006Ao-Sm for 22624@debbugs.gnu.org; Thu, 11 Feb 2016 03:31:03 -0500 Received: from [192.168.101.10] ([217.86.69.36]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0MUTsx-1adNAV1t6R-00RLYC; Thu, 11 Feb 2016 09:30:36 +0100 Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: Paul Eggert , "Nelson H. F. Beebe" , 22624@debbugs.gnu.org References: <56BBF476.5010902@cs.ucla.edu> From: Bernhard Voelker Message-ID: <56BC46A7.3000504@bernhard-voelker.de> Date: Thu, 11 Feb 2016 09:30:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56BBF476.5010902@cs.ucla.edu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:lPAK2n2C5lo/BhgXQRIFTBU8Je+DUKiRKr/kmhKQiyZ/Sh5m8fU 6C0yLuWTd4FW/pPi4XKiLUpNwM931we4rdMFkYzvGiIDbey5FSv/ZsC09vY0urDSAmwSkSw m1TG8OJ5YKve9vF0iz3ulspqRudB1pZMAgkJs7LGdyt3oA5F/rgvXaEaZUJJvF+COdJx4dt AZCLYkIMtjXsb5rJxqlHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:D6bRoFdC454=:Nn0EUocXTHR4yExf+6WT1h HLEeJu6iYcOOLujrk/K9bu6Ycl8hh+PKm54NIzM7p6zSa23L2DdfpHIjr/XCC97J8cXfOIa6i CAILZcO8WMI2tMlqM/ii8sTWeiWxcL31kJ2Q0RfmPibvDJ1iN3/9iN+e2PyerW/Nz0Tb+jJbF xccmurwUOm3L6jrMWUWvPKoIpnJ2QLfVNG2OUCpFvi6yrxUC6CcYbOPBSFDMUYXFODYfXiNhX zYFaZmwv1nYQaKZLppdNafgsR+7+whnwxhofISCtkRIdd0JOT/6zGsr7fKmbFCsy1dikAwVlp EwQ+mBL+fEjX3FRsAbbox2IvLe3nK3aUsJXonReFzT0UU9NP5PRcZWl71y5XT6cepYX4Hq3Vp iAKgWUKJexBzLonXo6ePtPBkL8BYzW+ZF9Zm7XpSUF/8bNzV04nkrccMcw/5EmEhg8giOEnzI Xa7cmJDnrsDP91YEMvnrb3y71eAgYXDIo8M/IYm1KS0iDD71AyFSDEDM4mZl/z1HmqbNrlRQf 82yjZMz6c86seQ/mzpRUcAmUmX/9L98Eo3P22QOEJIpKWTP/+6YQSZ9PQ650OU8u9FP69AiO9 LclMxTgOYG6THY1jLtvaOV0N5KkG5qI46O+yC4v7MOKSHk9hzSQWXKqV/WYRKsUDiz+GlafFG 5tMM8su2ZZQXHjgInJY9Mk2T3HdE2qciGHxJVLgsA5ykyoRn/by7fkywfpK8BSrbV4H1q2BLt vf1752NSigD5d63w X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 22624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --- hurdtest.c-ORIG 2016-02-11 09:27:57.422023914 +0100 +++ hurdtest.c 2016-02-11 09:28:29.781433313 +0100 @@ -10,7 +10,7 @@ struct stat st; off_t cur_offset; off_t end_offset; - int fd = open ("/dev/zero", O_RDONLY); + int fd = open (file, O_RDONLY); printf ("file=%s\n", file); if (fd < 0) return perror ("open"), 1; @@ -58,7 +58,7 @@ main (int argc, char **argv) { static char dev_zero[] = "/dev/zero"; - static char dev_null[] = "/dev/zero"; + static char dev_null[] = "/dev/null"; static char *dev_zero_argv[] = { dev_zero, dev_null, 0 }; char **av = argc == 1 ? dev_zero_argv : argv + 1; while (*av) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 11 11:11:24 2016 Received: (at 22624) by debbugs.gnu.org; 11 Feb 2016 16:11:24 +0000 Received: from localhost ([127.0.0.1]:36880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTtq0-0002SU-DK for submit@debbugs.gnu.org; Thu, 11 Feb 2016 11:11:24 -0500 Received: from mail.math.utah.edu ([155.101.98.135]:42958) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTtpx-0002SD-Q4 for 22624@debbugs.gnu.org; Thu, 11 Feb 2016 11:11:22 -0500 Received: from gamma.math.utah.edu (gamma.math.utah.edu [155.101.96.20]) by mail.math.utah.edu (8.14.8/8.14.8) with ESMTP id u1BGApaY026862; Thu, 11 Feb 2016 09:10:56 -0700 (MST) Received: from gamma.math.utah.edu (localhost [127.0.0.1]) by gamma.math.utah.edu (8.15.1/8.15.1) with ESMTP id u1BGAp05016475; Thu, 11 Feb 2016 09:10:51 -0700 Received: (from beebe@localhost) by gamma.math.utah.edu (8.15.1/8.15.1/Submit) id u1BGApVn016472; Thu, 11 Feb 2016 09:10:51 -0700 Date: Thu, 11 Feb 2016 09:10:51 -0700 From: "Nelson H. F. Beebe" To: Paul Eggert X-US-Mail: "Department of Mathematics, 110 LCB, University of Utah, 155 S 1400 E RM 233, Salt Lake City, UT 84112-0090, USA" X-Telephone: +1 801 581 5254 X-FAX: +1 801 581 4148 X-URL: http://www.math.utah.edu/~beebe Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd In-Reply-To: <56BBF476.5010902@cs.ucla.edu> Message-ID: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.8 (mail.math.utah.edu [155.101.98.135]); Thu, 11 Feb 2016 09:10:56 -0700 (MST) X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 22624 Cc: sysstaff@math.utah.edu, "Nelson H. F. Beebe" , 22624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) Thanks, Paul, for hurdtest.c and the subsequent tiny patch to it. Here is the test on my GNU/Hurd system on virt-manager + QEMU-KVM on top of CentOS 7: $ cc hurdtest.c && time ./a.out file=/dev/zero CHR st_size=9223372036854775807 st_blksize=8192 st_blocks=8 cur_offset=0 end_offset=9223372036854775807 pagesize=4096 file=/dev/null CHR st_size=0 st_blksize=1048576 st_blocks=0 cur_offset=0 end_offset=0 pagesize=4096 real 0m0.010s user 0m0.000s sys 0m0.000s ------------------------------------------------------------------------------- - Nelson H. F. Beebe Tel: +1 801 581 5254 - - University of Utah FAX: +1 801 581 4148 - - Department of Mathematics, 110 LCB Internet e-mail: beebe@math.utah.edu - - 155 S 1400 E RM 233 beebe@acm.org beebe@computer.org - - Salt Lake City, UT 84112-0090, USA URL: http://www.math.utah.edu/~beebe/ - ------------------------------------------------------------------------------- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 11 12:43:21 2016 Received: (at 22624) by debbugs.gnu.org; 11 Feb 2016 17:43:21 +0000 Received: from localhost ([127.0.0.1]:36895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTvGy-0004fL-UQ for submit@debbugs.gnu.org; Thu, 11 Feb 2016 12:43:21 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59734) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTvGx-0004f7-LY for 22624@debbugs.gnu.org; Thu, 11 Feb 2016 12:43:20 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BCF33160F56; Thu, 11 Feb 2016 09:43:12 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7dMzLCETmb-X; Thu, 11 Feb 2016 09:43:11 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DFBFD160F57; Thu, 11 Feb 2016 09:43:11 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AKKWbCbDKa98; Thu, 11 Feb 2016 09:43:11 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C14F2160F56; Thu, 11 Feb 2016 09:43:11 -0800 (PST) Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: "Nelson H. F. Beebe" References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <56BCC82F.6090108@cs.ucla.edu> Date: Thu, 11 Feb 2016 09:43:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------070606080204000209040803" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 22624 Cc: sysstaff@math.utah.edu, 22624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) This is a multi-part message in MIME format. --------------070606080204000209040803 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/11/2016 08:10 AM, Nelson H. F. Beebe wrote: > end_offset=9223372036854775807 > Thanks, that confirms my suspicions about GNU/Hurd. I'm attaching a proposed patch; please give it a try if you have a chance. Turned out to be trickier than I thought, but oh well. --------------070606080204000209040803 Content-Type: application/x-patch; name="0001-split-fix-problems-with-dev-zero.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-split-fix-problems-with-dev-zero.patch" RnJvbSBiNGJjYTFiMzA2YTk4MjE0NWEyZmM5Y2VhZTBkNjU3NmMwZDAxNzM0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDExIEZlYiAyMDE2IDA5OjQwOjIwIC0wODAwClN1YmplY3Q6IFtQQVRD SF0gc3BsaXQ6IGZpeCBwcm9ibGVtcyB3aXRoIC9kZXYvemVybwoKUHJvYmxlbSByZXBvcnRl ZCBieSBOZWxzb24gSC5GLiBCZWViZSBpbjogaHR0cDovL2J1Z3MuZ251Lm9yZy8yMjYyNApP dGhlciBwcm9ibGVtcyBhbHNvIGZpeGVkOiBiYXNpY2FsbHksIHRoZSBjb2RlIGdvdCBjb25m dXNlZCBiZWNhdXNlCkdOVS9MaW51eCByZXBvcnRzIHRoYXQgL2Rldi96ZXJvIGhhcyBzaXpl IHplcm8uCiogc3JjL3NwbGl0LmMgKGlucHV0X2ZpbGVfc2l6ZSk6IE5vdyB0YWtlcyBzdHJ1 Y3Qgc3RhdCAqLCBub3QganVzdApzaXplLiAgQWx3YXlzIHN0b3JlIHRoZSBmaXJzdCBidWZm ZXIuICBBbGwgY2FsbGVycyBjaGFuZ2VkLiAgVHJlYXQKL2Rldi96ZXJvIGFzIGFuIGluZmlu aXRlbHktbGFyZ2UgZmlsZSwgYm90aCBvbiBHTlUvTGludXggd2hlcmUKZnN0YXQgYW5kIGxz ZWVrIHNheSBpdHMgc2l6ZSBpcyB6ZXJvLCBhbmQgb24gR05VL0h1cmQgd2hlcmUgdGhleQpz YXkgdGhlIHNpemUgaXMgT0ZGX1RfTUFYLgooY3dyaXRlKTogUmV0dXJuIHRydWUgb24gc3Vj Y2Vzcy4KKGJ5dGVzX3NwbGl0KTogRG9uJ3QgdHJ5IHRvIHJlYWQgcGFzdCBFT0YsIGFuZCBz dG9wIGlmIGEgd3JpdGUgZmFpbHMuCihsaW5lc19ycik6IE9taXQgc3RyYXkgY2hlY2sgZm9y IGlnbm9yYWJsZSBlcnJuby4KKG1haW4pOiBHZXQgZmlsZSBzaXplIG9ubHkgd2hlbiBuX3Vu aXRzID4gMSwgc2luY2UgdGhhdCdzIHRoZSBvbmx5CnRpbWUgaXQgaXMgbmVlZGVkLiAgRGVm ZXIgbW9zdCBvZiB0aGUgd29yayB0byBpbnB1dF9maWxlX3NpemUuCiogdGVzdHMvc3BsaXQv bC1jaHVuay5zaDogQWRqdXN0IHRlc3RzIHRvIG1hdGNoIG5ldyBiZWhhdmlvcgpvbiBvZGRi YWxsIGlucHV0cy4KLS0tCiBzcmMvc3BsaXQuYyAgICAgICAgICAgIHwgMjA1ICsrKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0KIHRlc3RzL3NwbGl0 L2wtY2h1bmsuc2ggfCAgMTYgKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxMjUgaW5zZXJ0aW9u cygrKSwgOTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3NwbGl0LmMgYi9zcmMv c3BsaXQuYwppbmRleCA1MTBhZjEzLi4wYjEwNjAwIDEwMDY0NAotLS0gYS9zcmMvc3BsaXQu YworKysgYi9zcmMvc3BsaXQuYwpAQCAtMjcwLDMyICsyNzAsNjEgQEAgQ0hVTktTIG1heSBi ZTpcblwKICAgZXhpdCAoc3RhdHVzKTsKIH0KIAotLyogUmV0dXJuIHRoZSBudW1iZXIgb2Yg Ynl0ZXMgdGhhdCBjYW4gYmUgcmVhZCBmcm9tIEZELCBhIGZpbGUgd2l0aAotICAgYXBwYXJl bnQgc2l6ZSBTSVpFLiAgQWN0dWFsbHkgcmVhZCB0aGUgZGF0YSBpbnRvIEJVRiAob2Ygc2l6 ZQotICAgQlVGU0laRSkgaWYgdGhlIGZpbGUgYXBwZWFycyB0byBiZSBzbWFsbGVyIHRoYW4g QlVGU0laRSwgYXMgdGhpcwotICAgd29ya3MgYmV0dGVyIG9uIHByb2MtbGlrZSBmaWxlIHN5 c3RlbXMuICBJZiB0aGUgcmV0dXJuZWQgdmFsdWUgaXMKLSAgIGxlc3MgdGhhbiBCVUZTSVpF LCBzdG9yZSBhbGwgdGhlIGZpbGUncyBkYXRhIGludG8gQlVGOyBvdGhlcndpc2UsCi0gICBy ZXN0b3JlIHRoZSBpbnB1dCBmaWxlJ3MgcG9zaXRpb24gc28gdGhhdCB0aGUgZmlsZSBjYW4g YmUgcmVyZWFkIGlmCi0gICBuZWVkZWQuICAqLworLyogUmV0dXJuIHRoZSBudW1iZXIgb2Yg Ynl0ZXMgdGhhdCBjYW4gYmUgcmVhZCBmcm9tIEZEIHdpdGggc3RhdHVzIFNULgorICAgU3Rv cmUgdXAgdG8gdGhlIGZpcnN0IEJVRlNJWkUgYnl0ZXMgb2YgdGhlIGZpbGUncyBkYXRhIGlu dG8gQlVGLAorICAgYW5kIGFkdmFuY2UgdGhlIGZpbGUgcG9zaXRpb24gYnkgdGhlIG51bWJl ciBvZiBieXRlcyByZWFkLiAgT24KKyAgIGlucHV0IGVycm9yLCBzZXQgZXJybm8gYW5kIHJl dHVybiAtMS4gICovCiAKIHN0YXRpYyBvZmZfdAotaW5wdXRfZmlsZV9zaXplIChpbnQgZmQs IG9mZl90IHNpemUsIGNoYXIgKmJ1Ziwgc2l6ZV90IGJ1ZnNpemUpCitpbnB1dF9maWxlX3Np emUgKGludCBmZCwgc3RydWN0IHN0YXQgY29uc3QgKnN0LCBjaGFyICpidWYsIHNpemVfdCBi dWZzaXplKQogewotICBpZiAoc2l6ZSA8IGJ1ZnNpemUpCisgIG9mZl90IHNpemUgPSAwOwor ICBkbwogICAgIHsKLSAgICAgIHNpemUgPSAwOwotICAgICAgd2hpbGUgKHRydWUpCisgICAg ICBzaXplX3Qgbl9yZWFkID0gc2FmZV9yZWFkIChmZCwgYnVmICsgc2l6ZSwgYnVmc2l6ZSAt IHNpemUpOworICAgICAgaWYgKG5fcmVhZCA9PSAwKQorICAgICAgICByZXR1cm4gc2l6ZTsK KyAgICAgIGlmIChuX3JlYWQgPT0gU0FGRV9SRUFEX0VSUk9SKQorICAgICAgICByZXR1cm4g LTE7CisgICAgICBzaXplICs9IG5fcmVhZDsKKyAgICB9CisgIHdoaWxlIChzaXplIDwgYnVm c2l6ZSk7CisKKyAgLyogVGhlIGZpbGUgY29udGFpbnMgYXQgbGVhc3QgQlVGU0laRSBieXRl cy4gIEluZmVyIGl0cyBzaXplIHZpYQorICAgICBzdC0+c3Rfc2l6ZSBpZiB0aGlzIHNlZW1z IHJlbGlhYmxlLCBvciB2aWEgbHNlZWsgaWYgbm90LiAgKi8KKyAgb2ZmX3QgY3VyID0gbHNl ZWsgKGZkLCAwLCBTRUVLX0NVUik7CisgIG9mZl90IGVuZDsKKyAgaWYgKGN1ciA8IDApCisg ICAgcmV0dXJuIC0xOworICBpZiAoY3VyIDwgc2l6ZSkKKyAgICB7CisgICAgICAvKiBFLmcu LCAvZGV2L3plcm8gb24gR05VL0xpbnV4LCB3aGVyZSBDVVIgaXMgemVybyBhbmQgU0laRSA9 PSBCVUZTSVpFLgorICAgICAgICAgQXNzdW1lIHRoZXJlIGlzIG5vIGxpbWl0IHRvIHRoZSBm aWxlIHNpemUuICAqLworICAgICAgZXJybm8gPSBFT1ZFUkZMT1c7CisgICAgICByZXR1cm4g LTE7CisgICAgfQorICBpZiAodXNhYmxlX3N0X3NpemUgKHN0KSAmJiBjdXIgPD0gc3QtPnN0 X3NpemUpCisgICAgZW5kID0gc3QtPnN0X3NpemU7CisgIGVsc2UKKyAgICB7CisgICAgICBl bmQgPSBsc2VlayAoZmQsIDAsIFNFRUtfRU5EKTsKKyAgICAgIGlmIChlbmQgPCAwKQorICAg ICAgICByZXR1cm4gLTE7CisgICAgICBpZiAoZW5kICE9IGN1cikKICAgICAgICAgewotICAg ICAgICAgIHNpemVfdCBzYXZlID0gc2l6ZSA8IGJ1ZnNpemUgPyBzaXplIDogMDsKLSAgICAg ICAgICBzaXplX3Qgbl9yZWFkID0gc2FmZV9yZWFkIChmZCwgYnVmICsgc2F2ZSwgYnVmc2l6 ZSAtIHNhdmUpOwotICAgICAgICAgIGlmIChuX3JlYWQgPT0gMCkKLSAgICAgICAgICAgIGJy ZWFrOwotICAgICAgICAgIGlmIChuX3JlYWQgPT0gU0FGRV9SRUFEX0VSUk9SKQotICAgICAg ICAgICAgZXJyb3IgKEVYSVRfRkFJTFVSRSwgZXJybm8sICIlcyIsIHF1b3RlZiAoaW5maWxl KSk7Ci0gICAgICAgICAgc2l6ZSArPSBuX3JlYWQ7CisgICAgICAgICAgaWYgKGxzZWVrIChm ZCwgY3VyLCBTRUVLX1NFVCkgPCAwKQorICAgICAgICAgICAgcmV0dXJuIC0xOworICAgICAg ICAgIGlmIChlbmQgPCBjdXIpCisgICAgICAgICAgICBlbmQgPSBjdXI7CiAgICAgICAgIH0K LSAgICAgIGlmIChidWZzaXplIDw9IHNpemUgJiYgbHNlZWsgKGZkLCAtIHNpemUsIFNFRUtf Q1VSKSA8IDApCi0gICAgICAgIGVycm9yIChFWElUX0ZBSUxVUkUsIGVycm5vLCAiJXMiLCBx dW90ZWYgKGluZmlsZSkpOworICAgIH0KKworICBzaXplICs9IGVuZCAtIGN1cjsKKyAgaWYg KHNpemUgPT0gT0ZGX1RfTUFYKQorICAgIHsKKyAgICAgIC8qIEUuZy4sIC9kZXYvemVybyBv biBHTlUvSHVyZC4gICovCisgICAgICBlcnJubyA9IEVPVkVSRkxPVzsKKyAgICAgIHJldHVy biAtMTsKICAgICB9CiAKICAgcmV0dXJuIHNpemU7CkBAIC01NDcsMjggKzU3NiwzNiBAQCBj bG9zZW91dCAoRklMRSAqZnAsIGludCBmZCwgcGlkX3QgcGlkLCBjaGFyIGNvbnN0ICpuYW1l KQogCiAvKiBXcml0ZSBCWVRFUyBieXRlcyBhdCBCUCB0byBhbiBvdXRwdXQgZmlsZS4KICAg IElmIE5FV19GSUxFX0ZMQUcgaXMgdHJ1ZSwgb3BlbiB0aGUgbmV4dCBvdXRwdXQgZmlsZS4K LSAgIE90aGVyd2lzZSBhZGQgdG8gdGhlIHNhbWUgb3V0cHV0IGZpbGUgYWxyZWFkeSBpbiB1 c2UuICAqLworICAgT3RoZXJ3aXNlIGFkZCB0byB0aGUgc2FtZSBvdXRwdXQgZmlsZSBhbHJl YWR5IGluIHVzZS4KKyAgIFJldHVybiB0cnVlIGlmIHN1Y2Nlc3NmdWwuICAqLwogCi1zdGF0 aWMgdm9pZAorc3RhdGljIGJvb2wKIGN3cml0ZSAoYm9vbCBuZXdfZmlsZV9mbGFnLCBjb25z dCBjaGFyICpicCwgc2l6ZV90IGJ5dGVzKQogewogICBpZiAobmV3X2ZpbGVfZmxhZykKICAg ICB7CiAgICAgICBpZiAoIWJwICYmIGJ5dGVzID09IDAgJiYgZWxpZGVfZW1wdHlfZmlsZXMp Ci0gICAgICAgIHJldHVybjsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICBjbG9zZW91 dCAoTlVMTCwgb3V0cHV0X2Rlc2MsIGZpbHRlcl9waWQsIG91dGZpbGUpOwogICAgICAgbmV4 dF9maWxlX25hbWUgKCk7Ci0gICAgICBpZiAoKG91dHB1dF9kZXNjID0gY3JlYXRlIChvdXRm aWxlKSkgPCAwKQorICAgICAgb3V0cHV0X2Rlc2MgPSBjcmVhdGUgKG91dGZpbGUpOworICAg ICAgaWYgKG91dHB1dF9kZXNjIDwgMCkKKyAgICAgICAgZXJyb3IgKEVYSVRfRkFJTFVSRSwg ZXJybm8sICIlcyIsIHF1b3RlZiAob3V0ZmlsZSkpOworICAgIH0KKworICBpZiAoZnVsbF93 cml0ZSAob3V0cHV0X2Rlc2MsIGJwLCBieXRlcykgPT0gYnl0ZXMpCisgICAgcmV0dXJuIHRy dWU7CisgIGVsc2UKKyAgICB7CisgICAgICBpZiAoISBpZ25vcmFibGUgKGVycm5vKSkKICAg ICAgICAgZXJyb3IgKEVYSVRfRkFJTFVSRSwgZXJybm8sICIlcyIsIHF1b3RlZiAob3V0Zmls ZSkpOworICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KLSAgaWYgKGZ1bGxfd3JpdGUgKG91 dHB1dF9kZXNjLCBicCwgYnl0ZXMpICE9IGJ5dGVzICYmICEgaWdub3JhYmxlIChlcnJubykp Ci0gICAgZXJyb3IgKEVYSVRfRkFJTFVSRSwgZXJybm8sICIlcyIsIHF1b3RlZiAob3V0Zmls ZSkpOwogfQogCiAvKiBTcGxpdCBpbnRvIHBpZWNlcyBvZiBleGFjdGx5IE5fQllURVMgYnl0 ZXMuCiAgICBVc2UgYnVmZmVyIEJVRiwgd2hvc2Ugc2l6ZSBpcyBCVUZTSVpFLgotICAgSWYg SU5JVElBTF9SRUFEICE9IFNJWkVfTUFYLCB0aGUgZW50aXJlIGlucHV0IGZpbGUgaGFzIGFs cmVhZHkgYmVlbgotICAgcGFydGx5IHJlYWQgaW50byBCVUYgYW5kIEJVRiBjb250YWlucyBJ TklUSUFMX1JFQUQgaW5wdXQgYnl0ZXMuICAqLworICAgQlVGIGNvbnRhaW5zIHRoZSBmaXJz dCBJTklUSUFMX1JFQUQgaW5wdXQgYnl0ZXMuICAqLwogCiBzdGF0aWMgdm9pZAogYnl0ZXNf c3BsaXQgKHVpbnRtYXhfdCBuX2J5dGVzLCBjaGFyICpidWYsIHNpemVfdCBidWZzaXplLCBz aXplX3QgaW5pdGlhbF9yZWFkLApAQCAtNTc2LDEwICs2MTMsOSBAQCBieXRlc19zcGxpdCAo dWludG1heF90IG5fYnl0ZXMsIGNoYXIgKmJ1Ziwgc2l6ZV90IGJ1ZnNpemUsIHNpemVfdCBp bml0aWFsX3JlYWQsCiB7CiAgIHNpemVfdCBuX3JlYWQ7CiAgIGJvb2wgbmV3X2ZpbGVfZmxh ZyA9IHRydWU7Ci0gIHNpemVfdCB0b19yZWFkOwogICB1aW50bWF4X3QgdG9fd3JpdGUgPSBu X2J5dGVzOwotICBjaGFyICpicF9vdXQ7CiAgIHVpbnRtYXhfdCBvcGVuZWQgPSAwOworICBi b29sIGVvZjsKIAogICBkbwogICAgIHsKQEAgLTU4Nyw0NyArNjIzLDQ4IEBAIGJ5dGVzX3Nw bGl0ICh1aW50bWF4X3Qgbl9ieXRlcywgY2hhciAqYnVmLCBzaXplX3QgYnVmc2l6ZSwgc2l6 ZV90IGluaXRpYWxfcmVhZCwKICAgICAgICAgewogICAgICAgICAgIG5fcmVhZCA9IGluaXRp YWxfcmVhZDsKICAgICAgICAgICBpbml0aWFsX3JlYWQgPSBTSVpFX01BWDsKKyAgICAgICAg ICBlb2YgPSBuX3JlYWQgPCBidWZzaXplOwogICAgICAgICB9CiAgICAgICBlbHNlCiAgICAg ICAgIHsKICAgICAgICAgICBuX3JlYWQgPSBzYWZlX3JlYWQgKFNURElOX0ZJTEVOTywgYnVm LCBidWZzaXplKTsKICAgICAgICAgICBpZiAobl9yZWFkID09IFNBRkVfUkVBRF9FUlJPUikK ICAgICAgICAgICAgIGVycm9yIChFWElUX0ZBSUxVUkUsIGVycm5vLCAiJXMiLCBxdW90ZWYg KGluZmlsZSkpOworICAgICAgICAgIGVvZiA9IG5fcmVhZCA9PSAwOwogICAgICAgICB9Ci0g ICAgICBicF9vdXQgPSBidWY7Ci0gICAgICB0b19yZWFkID0gbl9yZWFkOwotICAgICAgd2hp bGUgKHRydWUpCisgICAgICBjaGFyICpicF9vdXQgPSBidWY7CisgICAgICBzaXplX3QgdG9f cmVhZCA9IG5fcmVhZDsKKyAgICAgIHdoaWxlICh0b193cml0ZSA8PSB0b19yZWFkKQogICAg ICAgICB7Ci0gICAgICAgICAgaWYgKHRvX3JlYWQgPCB0b193cml0ZSkKKyAgICAgICAgICBz aXplX3QgdyA9IHRvX3dyaXRlOworICAgICAgICAgIGJvb2wgY3dyaXRlX29rID0gY3dyaXRl IChuZXdfZmlsZV9mbGFnLCBicF9vdXQsIHcpOworICAgICAgICAgIG9wZW5lZCArPSBuZXdf ZmlsZV9mbGFnOworICAgICAgICAgIG5ld19maWxlX2ZsYWcgPSAhbWF4X2ZpbGVzIHx8IChv cGVuZWQgPCBtYXhfZmlsZXMpOworICAgICAgICAgIGlmICghbmV3X2ZpbGVfZmxhZyAmJiAh Y3dyaXRlX29rKQogICAgICAgICAgICAgewotICAgICAgICAgICAgICBpZiAodG9fcmVhZCkJ LyogZG8gbm90IHdyaXRlIDAgYnl0ZXMhICovCi0gICAgICAgICAgICAgICAgewotICAgICAg ICAgICAgICAgICAgY3dyaXRlIChuZXdfZmlsZV9mbGFnLCBicF9vdXQsIHRvX3JlYWQpOwot ICAgICAgICAgICAgICAgICAgb3BlbmVkICs9IG5ld19maWxlX2ZsYWc7Ci0gICAgICAgICAg ICAgICAgICB0b193cml0ZSAtPSB0b19yZWFkOwotICAgICAgICAgICAgICAgICAgbmV3X2Zp bGVfZmxhZyA9IGZhbHNlOwotICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgLyog SWYgZmlsdGVyIG5vIGxvbmdlciBhY2NlcHRpbmcgaW5wdXQsIHN0b3AgcmVhZGluZy4gICov CisgICAgICAgICAgICAgIG5fcmVhZCA9IHRvX3JlYWQgPSAwOwogICAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgICAgIH0KLSAgICAgICAgICBlbHNlCisgICAgICAgICAgYnBfb3V0 ICs9IHc7CisgICAgICAgICAgdG9fcmVhZCAtPSB3OworICAgICAgICAgIHRvX3dyaXRlID0g bl9ieXRlczsKKyAgICAgICAgfQorICAgICAgaWYgKHRvX3JlYWQgIT0gMCkKKyAgICAgICAg eworICAgICAgICAgIGJvb2wgY3dyaXRlX29rID0gY3dyaXRlIChuZXdfZmlsZV9mbGFnLCBi cF9vdXQsIHRvX3JlYWQpOworICAgICAgICAgIG9wZW5lZCArPSBuZXdfZmlsZV9mbGFnOwor ICAgICAgICAgIHRvX3dyaXRlIC09IHRvX3JlYWQ7CisgICAgICAgICAgbmV3X2ZpbGVfZmxh ZyA9IGZhbHNlOworICAgICAgICAgIGlmICghY3dyaXRlX29rKQogICAgICAgICAgICAgewot ICAgICAgICAgICAgICBzaXplX3QgdyA9IHRvX3dyaXRlOwotICAgICAgICAgICAgICBjd3Jp dGUgKG5ld19maWxlX2ZsYWcsIGJwX291dCwgdyk7Ci0gICAgICAgICAgICAgIG9wZW5lZCAr PSBuZXdfZmlsZV9mbGFnOwotICAgICAgICAgICAgICBuZXdfZmlsZV9mbGFnID0gIW1heF9m aWxlcyB8fCAob3BlbmVkIDwgbWF4X2ZpbGVzKTsKLSAgICAgICAgICAgICAgaWYgKCFuZXdf ZmlsZV9mbGFnICYmIGlnbm9yYWJsZSAoZXJybm8pKQotICAgICAgICAgICAgICAgIHsKLSAg ICAgICAgICAgICAgICAgIC8qIElmIGZpbHRlciBubyBsb25nZXIgYWNjZXB0aW5nIGlucHV0 LCBzdG9wIHJlYWRpbmcuICAqLwotICAgICAgICAgICAgICAgICAgbl9yZWFkID0gMDsKLSAg ICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAg ICAgYnBfb3V0ICs9IHc7Ci0gICAgICAgICAgICAgIHRvX3JlYWQgLT0gdzsKLSAgICAgICAg ICAgICAgdG9fd3JpdGUgPSBuX2J5dGVzOworICAgICAgICAgICAgICAvKiBJZiBmaWx0ZXIg bm8gbG9uZ2VyIGFjY2VwdGluZyBpbnB1dCwgc3RvcCByZWFkaW5nLiAgKi8KKyAgICAgICAg ICAgICAgbl9yZWFkID0gMDsKKyAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9 CiAgICAgICAgIH0KICAgICB9Ci0gIHdoaWxlIChuX3JlYWQpOworICB3aGlsZSAoISBlb2Yp OwogCiAgIC8qIEVuc3VyZSBOVU1CRVIgZmlsZXMgYXJlIGNyZWF0ZWQsIHdoaWNoIHRydW5j YXRlcwogICAgICBhbnkgZXhpc3RpbmcgZmlsZXMgb3Igbm90aWZpZXMgYW55IGNvbnN1bWVy cyBvbiBmaWZvcy4KQEAgLTgxNywxMyArODU0LDE3IEBAIGxpbmVzX2NodW5rX3NwbGl0ICh1 aW50bWF4X3QgaywgdWludG1heF90IG4sIGNoYXIgKmJ1Ziwgc2l6ZV90IGJ1ZnNpemUsCiAg ICAgewogICAgICAgLyogU3RhcnQgcmVhZGluZyAxIGJ5dGUgYmVmb3JlIGt0aCBjaHVuayBv ZiBmaWxlLiAgKi8KICAgICAgIG9mZl90IHN0YXJ0ID0gKGsgLSAxKSAqIGNodW5rX3NpemUg LSAxOwotICAgICAgaWYgKGluaXRpYWxfcmVhZCAhPSBTSVpFX01BWCkKKyAgICAgIGlmIChz dGFydCA8IGluaXRpYWxfcmVhZCkKICAgICAgICAgewogICAgICAgICAgIG1lbW1vdmUgKGJ1 ZiwgYnVmICsgc3RhcnQsIGluaXRpYWxfcmVhZCAtIHN0YXJ0KTsKICAgICAgICAgICBpbml0 aWFsX3JlYWQgLT0gc3RhcnQ7CiAgICAgICAgIH0KLSAgICAgIGVsc2UgaWYgKGxzZWVrIChT VERJTl9GSUxFTk8sIHN0YXJ0LCBTRUVLX0NVUikgPCAwKQotICAgICAgICBlcnJvciAoRVhJ VF9GQUlMVVJFLCBlcnJubywgIiVzIiwgcXVvdGVmIChpbmZpbGUpKTsKKyAgICAgIGVsc2UK KyAgICAgICAgeworICAgICAgICAgIGlmIChsc2VlayAoU1RESU5fRklMRU5PLCBzdGFydCAt IGluaXRpYWxfcmVhZCwgU0VFS19DVVIpIDwgMCkKKyAgICAgICAgICAgIGVycm9yIChFWElU X0ZBSUxVUkUsIGVycm5vLCAiJXMiLCBxdW90ZWYgKGluZmlsZSkpOworICAgICAgICAgIGlu aXRpYWxfcmVhZCA9IFNJWkVfTUFYOworICAgICAgICB9CiAgICAgICBuX3dyaXR0ZW4gPSBz dGFydDsKICAgICAgIGNodW5rX25vID0gayAtIDE7CiAgICAgICBjaHVua19lbmQgPSBjaHVu a19ubyAqIGNodW5rX3NpemUgLSAxOwpAQCAtOTMxLDEzICs5NzIsMTcgQEAgYnl0ZXNfY2h1 bmtfZXh0cmFjdCAodWludG1heF90IGssIHVpbnRtYXhfdCBuLCBjaGFyICpidWYsIHNpemVf dCBidWZzaXplLAogICBzdGFydCA9IChrIC0gMSkgKiAoZmlsZV9zaXplIC8gbik7CiAgIGVu ZCA9IChrID09IG4pID8gZmlsZV9zaXplIDogayAqIChmaWxlX3NpemUgLyBuKTsKIAotICBp ZiAoaW5pdGlhbF9yZWFkICE9IFNJWkVfTUFYKQorICBpZiAoaW5pdGlhbF9yZWFkICE9IFNJ WkVfTUFYIHx8IHN0YXJ0IDwgaW5pdGlhbF9yZWFkKQogICAgIHsKICAgICAgIG1lbW1vdmUg KGJ1ZiwgYnVmICsgc3RhcnQsIGluaXRpYWxfcmVhZCAtIHN0YXJ0KTsKICAgICAgIGluaXRp YWxfcmVhZCAtPSBzdGFydDsKICAgICB9Ci0gIGVsc2UgaWYgKGxzZWVrIChTVERJTl9GSUxF Tk8sIHN0YXJ0LCBTRUVLX0NVUikgPCAwKQotICAgIGVycm9yIChFWElUX0ZBSUxVUkUsIGVy cm5vLCAiJXMiLCBxdW90ZWYgKGluZmlsZSkpOworICBlbHNlCisgICAgeworICAgICAgaWYg KGxzZWVrIChTVERJTl9GSUxFTk8sIHN0YXJ0LCBTRUVLX0NVUikgPCAwKQorICAgICAgICBl cnJvciAoRVhJVF9GQUlMVVJFLCBlcnJubywgIiVzIiwgcXVvdGVmIChpbmZpbGUpKTsKKyAg ICAgIGluaXRpYWxfcmVhZCA9IFNJWkVfTUFYOworICAgIH0KIAogICB3aGlsZSAoc3RhcnQg PCBlbmQpCiAgICAgewpAQCAtMTE1MSw4ICsxMTk2LDggQEAgbGluZXNfcnIgKHVpbnRtYXhf dCBrLCB1aW50bWF4X3QgbiwgY2hhciAqYnVmLCBzaXplX3QgYnVmc2l6ZSkKICAgICAgICAg ICAgICAgICAgIGVycm9yIChFWElUX0ZBSUxVUkUsIGVycm5vLCAiJXMiLAogICAgICAgICAg ICAgICAgICAgICAgICAgIHF1b3RlZiAoZmlsZXNbaV9maWxlXS5vZl9uYW1lKSk7CiAgICAg ICAgICAgICAgICAgfQotICAgICAgICAgICAgICBpZiAoISBpZ25vcmFibGUgKGVycm5vKSkK LSAgICAgICAgICAgICAgICB3cm90ZSA9IHRydWU7CisKKyAgICAgICAgICAgICAgd3JvdGUg PSB0cnVlOwogCiAgICAgICAgICAgICAgIGlmIChmaWxlX2xpbWl0KQogICAgICAgICAgICAg ICAgIHsKQEAgLTEyMzcsNyArMTI4Miw3IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJn dikKICAgc3RhdGljIGNoYXIgY29uc3QgbXVsdGlwbGllcnNbXSA9ICJiRUdLa01tUFRZWjAi OwogICBpbnQgYzsKICAgaW50IGRpZ2l0c19vcHRpbmQgPSAwOwotICBvZmZfdCBmaWxlX3Np emUgSUZfTElOVCAoPSAwKTsKKyAgb2ZmX3QgZmlsZV9zaXplID0gT0ZGX1RfTUFYOwogCiAg IGluaXRpYWxpemVfbWFpbiAoJmFyZ2MsICZhcmd2KTsKICAgc2V0X3Byb2dyYW1fbmFtZSAo YXJndlswXSk7CkBAIC0xNTEzLDMxICsxNTU4LDE1IEBAIG1haW4gKGludCBhcmdjLCBjaGFy ICoqYXJndikKICAgY2hhciAqYnVmID0gcHRyX2FsaWduIChiLCBwYWdlX3NpemUpOwogICBz aXplX3QgaW5pdGlhbF9yZWFkID0gU0laRV9NQVg7CiAKLSAgaWYgKHNwbGl0X3R5cGUgPT0g dHlwZV9jaHVua19ieXRlcyB8fCBzcGxpdF90eXBlID09IHR5cGVfY2h1bmtfbGluZXMpCisg IGlmICgoc3BsaXRfdHlwZSA9PSB0eXBlX2NodW5rX2J5dGVzIHx8IHNwbGl0X3R5cGUgPT0g dHlwZV9jaHVua19saW5lcykKKyAgICAgICYmIG5fdW5pdHMgIT0gMSkKICAgICB7Ci0gICAg ICBvZmZfdCBpbnB1dF9vZmZzZXQgPSBsc2VlayAoU1RESU5fRklMRU5PLCAwLCBTRUVLX0NV Uik7Ci0gICAgICBpZiAoMCA8PSBpbnB1dF9vZmZzZXQpCi0gICAgICAgIHsKLSAgICAgICAg ICBpZiAodXNhYmxlX3N0X3NpemUgKCZpbl9zdGF0X2J1ZikgJiYgISBzcGVjaWZpZWRfYnVm X3NpemUpCi0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAgIGFzc2VydCAoU1RfQkxLU0la RSAoaW5fc3RhdF9idWYpIDw9IGluX2Jsa19zaXplKTsKLSAgICAgICAgICAgICAgZmlsZV9z aXplID0gaW5wdXRfZmlsZV9zaXplIChTVERJTl9GSUxFTk8sIGluX3N0YXRfYnVmLnN0X3Np emUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVmLCBp bl9ibGtfc2l6ZSk7Ci0gICAgICAgICAgICAgIGlmIChmaWxlX3NpemUgPCBpbl9ibGtfc2l6 ZSkKLSAgICAgICAgICAgICAgICBpbml0aWFsX3JlYWQgPSBmaWxlX3NpemU7Ci0gICAgICAg ICAgICB9Ci0gICAgICAgICAgZWxzZQotICAgICAgICAgICAgewotICAgICAgICAgICAgICBm aWxlX3NpemUgPSBsc2VlayAoU1RESU5fRklMRU5PLCAwLCBTRUVLX0VORCk7Ci0gICAgICAg ICAgICAgIGlucHV0X29mZnNldCA9IChmaWxlX3NpemUgPCAwCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICA/IGZpbGVfc2l6ZQotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgOiBsc2VlayAoU1RESU5fRklMRU5PLCBpbnB1dF9vZmZzZXQsIFNFRUtfU0VUKSk7Ci0g ICAgICAgICAgICAgIGZpbGVfc2l6ZSAtPSBpbnB1dF9vZmZzZXQ7Ci0gICAgICAgICAgICB9 Ci0gICAgICAgIH0KLSAgICAgIGlmIChpbnB1dF9vZmZzZXQgPCAwKQotICAgICAgICBlcnJv ciAoRVhJVF9GQUlMVVJFLCAwLCBfKCIlczogY2Fubm90IGRldGVybWluZSBmaWxlIHNpemUi KSwKKyAgICAgIGZpbGVfc2l6ZSA9IGlucHV0X2ZpbGVfc2l6ZSAoU1RESU5fRklMRU5PLCAm aW5fc3RhdF9idWYsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1Ziwg aW5fYmxrX3NpemUpOworICAgICAgaWYgKGZpbGVfc2l6ZSA8IDApCisgICAgICAgIGVycm9y IChFWElUX0ZBSUxVUkUsIGVycm5vLCBfKCIlczogY2Fubm90IGRldGVybWluZSBmaWxlIHNp emUiKSwKICAgICAgICAgICAgICAgIHF1b3RlZiAoaW5maWxlKSk7CisgICAgICBpbml0aWFs X3JlYWQgPSBNSU4gKGZpbGVfc2l6ZSwgaW5fYmxrX3NpemUpOwogICAgICAgLyogT3ZlcmZs b3csIGFuZCBzYW5pdHkgY2hlY2tpbmcuICAqLwogICAgICAgaWYgKE9GRl9UX01BWCA8IG5f dW5pdHMpCiAgICAgICAgIHsKZGlmZiAtLWdpdCBhL3Rlc3RzL3NwbGl0L2wtY2h1bmsuc2gg Yi90ZXN0cy9zcGxpdC9sLWNodW5rLnNoCmluZGV4IGRhYzk4ZDAuLmI1YTg5ZjQgMTAwNzU1 Ci0tLSBhL3Rlc3RzL3NwbGl0L2wtY2h1bmsuc2gKKysrIGIvdGVzdHMvc3BsaXQvbC1jaHVu ay5zaApAQCAtMjQsOSArMjQsOSBAQCBlY2hvICJzcGxpdDogaW52YWxpZCBudW1iZXIgb2Yg Y2h1bmtzOiAnMW8nIiA+IGV4cAogc3BsaXQgLW4gbC8xbyAyPmVyciAmJiBmYWlsPTEKIGNv bXBhcmUgZXhwIGVyciB8fCBmYWlsPTEKIAotZWNobyAic3BsaXQ6IC06IGNhbm5vdCBkZXRl cm1pbmUgZmlsZSBzaXplIiA+IGV4cAotZWNobyB8IHNwbGl0IC1uIGwvMSAyPmVyciAmJiBm YWlsPTEKLWNvbXBhcmUgZXhwIGVyciB8fCBmYWlsPTEKK2VjaG8gPiBleHAKK2VjaG8gfCBz cGxpdCAtbiBsLzEgfHwgZmFpbD0xCitjb21wYXJlIGV4cCB4YWEgfHwgZmFpbD0xCiAKICMg TiBjYW4gYmUgZ3JlYXRlciB0aGFuIHRoZSBmaWxlIHNpemUKICMgaW4gd2hpY2ggY2FzZSBu byBkYXRhIGlzIGV4dHJhY3RlZCwgb3IgZW1wdHkgZmlsZXMgYXJlIHdyaXR0ZW4KQEAgLTM0 LDE0ICszNCwxNCBAQCBzcGxpdCAtbiBsLzEwIC9kZXYvbnVsbCB8fCBmYWlsPTEKIHRlc3Qg IiQoc3RhdCAtYyAlcyB4KiB8IHVuaXEgLWMgfCBzZWQgJ3MvXiAqLy87IHMvIC94LycpIiA9 ICIxMHgwIiB8fCBmYWlsPTEKIHJtIHg/PwogCi0jIEVuc3VyZSB0aGUgY29ycmVjdCBudW1i ZXIgb2YgZmlsZXMgd3JpdHRlbgotIyBldmVuIGlmIHRoZXJlIGlzIG1vcmUgZGF0YSB0aGFu IHRoZSByZXBvcnRlZCBmaWxlIHNpemUKLXNwbGl0IC1uIGwvMiAvZGV2L3plcm8KLXRlc3Qg IiQoc3RhdCAtYyAlcyB4KiB8IHdjIC1sKSIgPSAnMicgfHwgZmFpbD0xCisjICdzcGxpdCcg c2hvdWxkIHJlamVjdCBhbnkgYXR0ZW1wdCB0byBjcmVhdGUgYW4gaW5maW5pdGVseQorIyBs b25nIG91dHB1dCBmaWxlLgorc3BsaXQgLW4gbC8yIC9kZXYvemVybyAmJiBmYWlsPTEKIHJt IHg/PwogCiAjIFJlcGVhdCB0aGUgYWJvdmUsICBidXQgd2l0aCAxLzIsIG5vdCBsLzI6Ci1z cGxpdCAtbiAxLzIgL2Rldi96ZXJvIHx8IGZhaWw9MQorc3BsaXQgLW4gMS8yIC9kZXYvemVy byAmJiBmYWlsPTEKK3JtIHg/PwogCiAjIEVuc3VyZSAtLWVsaWRlLWVtcHR5LWZpbGVzIGlz IGhvbm9yZWQKIHNwbGl0IC1lIC1uIGwvMTAgL2Rldi9udWxsIHx8IGZhaWw9MQotLSAKMi41 LjAKCg== --------------070606080204000209040803-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 11 23:13:33 2016 Received: (at 22624) by debbugs.gnu.org; 12 Feb 2016 04:13:33 +0000 Received: from localhost ([127.0.0.1]:37165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aU56r-0004Ch-Ho for submit@debbugs.gnu.org; Thu, 11 Feb 2016 23:13:33 -0500 Received: from mail.magicbluesmoke.com ([82.195.144.49]:45606) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aU56p-0004CX-Jy for 22624@debbugs.gnu.org; Thu, 11 Feb 2016 23:13:31 -0500 Received: from localhost.localdomain (c-73-70-29-104.hsd1.ca.comcast.net [73.70.29.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id D656C1E7; Fri, 12 Feb 2016 04:13:29 +0000 (GMT) Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: Paul Eggert , "Nelson H. F. Beebe" References: <56BCC82F.6090108@cs.ucla.edu> From: =?UTF-8?Q?P=c3=a1draig_Brady?= X-Enigmail-Draft-Status: N1110 Message-ID: <56BD5BE7.9040307@draigBrady.com> Date: Thu, 11 Feb 2016 20:13:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56BCC82F.6090108@cs.ucla.edu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22624 Cc: sysstaff@math.utah.edu, 22624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 11/02/16 09:43, Paul Eggert wrote: > On 02/11/2016 08:10 AM, Nelson H. F. Beebe wrote: >> end_offset=9223372036854775807 >> > > Thanks, that confirms my suspicions about GNU/Hurd. I'm attaching a > proposed patch; please give it a try if you have a chance. Turned out to > be trickier than I thought, but oh well. Thanks for working on this. The changes look good, except for this: $ seq 1000 | split -n4 $ seq 100000 | split -n4 split: -: cannot determine file size: Illegal seek I.E. it would be better to indicate immediately if there is an issue determining the file size, because it's a gotcha that may hit users as data increases, and -n is complex enough anyway, that it's better to do as much checking up front as possible. I'd still disallow this case even for -n1 in case the number was parameterized to number of CPUs or whatever. A small point on the tests is that we use `returns_ 1 ... || fail=1` rather than `... && fail=1` so that we catch seg faults etc. in tests. thanks! Pádraig From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 12 13:18:26 2016 Received: (at 22624) by debbugs.gnu.org; 12 Feb 2016 18:18:26 +0000 Received: from localhost ([127.0.0.1]:38214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUIIU-0001aP-5q for submit@debbugs.gnu.org; Fri, 12 Feb 2016 13:18:26 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34101) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUIIS-0001aA-Gb for 22624@debbugs.gnu.org; Fri, 12 Feb 2016 13:18:25 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6FAC8160192; Fri, 12 Feb 2016 10:18:18 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id KJEfw3UtBSAG; Fri, 12 Feb 2016 10:18:17 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AC746160FC1; Fri, 12 Feb 2016 10:18:17 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0s0LRpkxJDRE; Fri, 12 Feb 2016 10:18:17 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8901F160192; Fri, 12 Feb 2016 10:18:17 -0800 (PST) Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: =?UTF-8?Q?P=c3=a1draig_Brady?= , "Nelson H. F. Beebe" References: <56BCC82F.6090108@cs.ucla.edu> <56BD5BE7.9040307@draigBrady.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <56BE21E6.20401@cs.ucla.edu> Date: Fri, 12 Feb 2016 10:18:14 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56BD5BE7.9040307@draigBrady.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 22624 Cc: sysstaff@math.utah.edu, 22624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) On 02/11/2016 08:13 PM, P=C3=A1draig Brady wrote: > The changes look good, except for this: > > $ seq 1000 | split -n4 > $ seq 100000 | split -n4 > split: -: cannot determine file size: Illegal seek > > I.E. it would be better to indicate immediately > if there is an issue determining the file size, > because it's a gotcha that may hit users as data increases, > and -n is complex enough anyway, that it's better to > do as much checking up front as possible. > I'd still disallow this case even for -n1 in case the > number was parameterized to number of CPUs or whatever. Hmm, well, I already spent too much time on this so I think I'll check=20 in what I have (since it fixes the GNU/Hurd problem) and let it=20 percolate a bit first. I have some qualms about the approach suggested above, as it would cause=20 'split' to give up on files that it currently handles (e.g., typical=20 files in /proc), on the theory that we don't want to spoil users into=20 thinking that 'split' can handle larger files. It'd be better to fix=20 'split' to handle the larger files. It could do this for a troublesome=20 case (e.g., a large /proc file) by copying the file's data into the=20 first output file F1, then doing a split-in-place from F1 to the=20 remaining output files F2 ... Fn (this would be done by copying to F2=20 ... Fn and then truncating F1). If the input file is /dev/zero, though,=20 'split' should just give up right away as it does now, as there's no=20 point in copying forever. Anyway, I view this as relatively low=20 priority, as the troublesome cases should be quite rare in practice. > A small point on the tests is that we use `returns_ 1 ... || fail=3D1` > rather than `... && fail=3D1` so that we catch seg faults etc. in tests= . Thanks, I fixed that before installing the patch. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 12 14:04:34 2016 Received: (at 22624) by debbugs.gnu.org; 12 Feb 2016 19:04:34 +0000 Received: from localhost ([127.0.0.1]:38236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUJ17-0004HE-Ty for submit@debbugs.gnu.org; Fri, 12 Feb 2016 14:04:34 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37554) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUJ16-0004H0-0g for 22624@debbugs.gnu.org; Fri, 12 Feb 2016 14:04:32 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 28553160192; Fri, 12 Feb 2016 11:04:26 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SkWwlSoHrJHv; Fri, 12 Feb 2016 11:04:25 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 452D7160FC1; Fri, 12 Feb 2016 11:04:25 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 763X-d6O4cMn; Fri, 12 Feb 2016 11:04:25 -0800 (PST) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 284D8160192; Fri, 12 Feb 2016 11:04:25 -0800 (PST) Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: "Nelson H. F. Beebe" , P@draigBrady.com, 22624@debbugs.gnu.org References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <56BE2CB8.4090101@cs.ucla.edu> Date: Fri, 12 Feb 2016 11:04:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------000406060009050302030209" X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 22624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) This is a multi-part message in MIME format. --------------000406060009050302030209 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/12/2016 06:25 AM, Nelson H. F. Beebe wrote: > The effectively-zero load, and no CPU consumption, suggests that the > "make check" run is in a wait state. Thanks for checking. I installed the attached patch to try to fix the test script so that it doesn't hang forever in this situation. The old test had a race condition anyway. I don't know if the failure reflects a bug in coreutils, or in bash, or in GNU/Hurd elsewhere. If the revised test passes I guess we don't need to worry about it. --------------000406060009050302030209 Content-Type: application/x-patch; name="0001-tests-don-t-wait-forever-on-GNU-Hurd.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-tests-don-t-wait-forever-on-GNU-Hurd.patch" RnJvbSBkODM5ZTM2NTcxN2ViOTVkNzM1OGMyZjA2Y2ZiYzM0ZTc5NzU5MmQyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDEyIEZlYiAyMDE2IDEwOjU5OjIwIC0wODAwClN1YmplY3Q6IFtQQVRD SF0gdGVzdHM6IGRvbid0IHdhaXQgZm9yZXZlciBvbiBHTlUvSHVyZAoKKiB0ZXN0cy9jcC9w YXJlbnQtcGVybS1yYWNlLnNoOiBBZGQgdGltZW91dHMgc28gdGhhdCB0aGUgdGVzdCBkb2Vz Cm5vdCB3YWl0IGZvcmV2ZXIgb24gR05VL0h1cmQuICBUaGlzIGRvZXMgbm90IGZpeCB0aGUg dW5kZXJseWluZwpidWcgYnV0IGF0IGxlYXN0IGxldHMgdGhlIHRlc3RzIG1ha2UgcHJvZ3Jl c3MuClByb2JsZW0gcmVwb3J0ZWQgYnkgTmVsc29uIEguRi4gQmVlYmUgaW46IGh0dHA6Ly9i dWdzLmdudS5vcmcvMjI2MjQKQWxzbywgY2hlY2sgdGhhdCAnY3AnIGFjdHVhbGx5IGNvcGll cyB0aGUgZGF0YTsgdGhpcyBpcyBhIGJldHRlcgp0ZXN0IGFueXdheSwgYW5kIHNpbXBsaWZp ZXMgdGhlIHRlc3QgY29kZS4KQWxzbywgYXZvaWQgdW5saWtlbHkgcmFjZSBpZiAncGlkJyBp cyBzZXQgaW4gdGhlIGVudmlyb25tZW50LgotLS0KIHRlc3RzL2NwL3BhcmVudC1wZXJtLXJh Y2Uuc2ggfCAyMiArKysrKysrKy0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOCBp bnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0cy9jcC9w YXJlbnQtcGVybS1yYWNlLnNoIGIvdGVzdHMvY3AvcGFyZW50LXBlcm0tcmFjZS5zaAppbmRl eCA3YTczNzQwLi4wZDA4NDFjIDEwMDc1NQotLS0gYS90ZXN0cy9jcC9wYXJlbnQtcGVybS1y YWNlLnNoCisrKyBiL3Rlc3RzL2NwL3BhcmVudC1wZXJtLXJhY2Uuc2gKQEAgLTI2LDcgKzI2 LDggQEAgdW1hc2sgMDAyCiBta2RpciBtb2RlIG93bmVyc2hpcCBkIHx8IGZyYW1ld29ya19m YWlsdXJlXwogY2htb2QgZytzIGQgMj4vZGV2L251bGwgIyBUaGUgY3AgdGVzdCBpcyB2YWxp ZCBlaXRoZXIgd2F5LgogCi0jIFRlcm1pbmF0ZSBhbnkgYmFja2dyb3VuZCBjcCBwcm9jZXNz CisjIFRlcm1pbmF0ZSBhbnkgYmFja2dyb3VuZCBjcCBwcm9jZXNzLgorcGlkPQogY2xlYW51 cF8oKSB7IGtpbGwgJHBpZCAyPi9kZXYvbnVsbCAmJiB3YWl0ICRwaWQ7IH0KIAogZm9yIGF0 dHIgaW4gbW9kZSBvd25lcnNoaXAKQEAgLTM1LDIxICszNiwxNCBAQCBkbwogCiAgICMgQ29w eSBhIGZpZm8ncyBjb250ZW50cy4gIFRoYXQgd2F5LCB3ZSBjYW4gZXhhbWluZSBkLyRhdHRy J3MKICAgIyBzdGF0ZSB3aGlsZSBjcCBpcyBydW5uaW5nLgotICBjcCAtLXByZXNlcnZlPSRh dHRyIC1SIC0tY29weS1jb250ZW50cyAtLXBhcmVudHMgJGF0dHIgZCAmIHBpZD0kIQorICB0 aW1lb3V0IDEwIGNwIC0tcHJlc2VydmU9JGF0dHIgLVIgLS1jb3B5LWNvbnRlbnRzIC0tcGFy ZW50cyAkYXR0ciBkICYgcGlkPSQhCiAKLSAgKAotICAgICMgTm93ICdjcCcgaXMgcmVhZGlu ZyB0aGUgZmlmby4KLSAgICAjIENoZWNrIHRoZSBwZXJtaXNzaW9ucyBvZiB0aGUgdGVtcG9y YXJ5IGRlc3RpbmF0aW9uCi0gICAgIyBkaXJlY3RvcnkgdGhhdCAnY3AnIGhhcyBtYWRlLgot ICAgIGxzIC1sZCBkLyRhdHRyID5kLyRhdHRyLmxzCisgICMgQ2hlY2sgdGhlIHBlcm1pc3Np b25zIG9mIHRoZSBkZXN0aW5hdGlvbiBkaXJlY3RvcnkgdGhhdCAnY3AnIGhhcyBtYWRlLgor ICAjICdscycgd29uJ3Qgc3RhcnQgdW50aWwgYWZ0ZXIgJ2NwJyBoYXMgbWFkZSB0aGUgZGVz dGluYXRpb24gZGlyZWN0b3J5CisgICMgJGQvYXR0ciBhbmQgaGFzIHN0YXJ0ZWQgdG8gcmVh ZCB0aGUgc291cmNlIGZpbGUgJGF0dHIvZmlmby4KKyAgdGltZW91dCAxMCBzaCAtYyAibHMg LWxkIGQvJGF0dHIgPiRhdHRyL2ZpZm8iIHx8IGZhaWw9MQogCi0gICAgIyBDbG9zZSB0aGUg ZmlmbyBzbyB0aGF0ICJjcCIgY2FuIGNvbnRpbnVlLiAgQnV0IG91dHB1dCBmaXJzdCwKLSAg ICAjIGJlZm9yZSBleGl0aW5nLCBvdGhlcndpc2Ugc29tZSBzaGVsbHMgd291bGQgb3B0aW1p emUgYXdheSB0aGUgZmlsZQotICAgICMgZGVzY3JpcHRvciB0aGF0IGhvbGRzIHRoZSBmaWZv IG9wZW4uCi0gICAgZWNobyBmb28KLSAgKSA+JGF0dHIvZmlmbwotCi0gIGxzX291dHB1dD0k KGNhdCBkLyRhdHRyLmxzKSB8fCBmYWlsPTEKKyAgbHNfb3V0cHV0PSQoY2F0IGQvJGF0dHIv ZmlmbykgfHwgZmFpbD0xCiAgIGNhc2UgJGF0dHIsJGxzX291dHB1dCBpbgogICBvd25lcnNo aXAsZD8/Py0tWy1TXS0tWy1TXSogfCBcCiAgIG1vZGUsZD8/Pz8tPz8tPyogfCBcCi0tIAoy LjUuMAoK --------------000406060009050302030209-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 13 00:07:13 2016 Received: (at 22624) by debbugs.gnu.org; 13 Feb 2016 05:07:13 +0000 Received: from localhost ([127.0.0.1]:38423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUSQL-0004WN-6Z for submit@debbugs.gnu.org; Sat, 13 Feb 2016 00:07:13 -0500 Received: from mail.magicbluesmoke.com ([82.195.144.49]:53795) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUSQI-0004WE-R1 for 22624@debbugs.gnu.org; Sat, 13 Feb 2016 00:07:11 -0500 Received: from localhost.localdomain (c-73-70-29-104.hsd1.ca.comcast.net [73.70.29.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.magicbluesmoke.com (Postfix) with ESMTPSA id BDA899A82; Sat, 13 Feb 2016 05:07:08 +0000 (GMT) Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd To: Paul Eggert , "Nelson H. F. Beebe" References: <56BCC82F.6090108@cs.ucla.edu> <56BD5BE7.9040307@draigBrady.com> <56BE21E6.20401@cs.ucla.edu> From: =?UTF-8?Q?P=c3=a1draig_Brady?= X-Enigmail-Draft-Status: N1110 Message-ID: <56BEB9FA.3090801@draigBrady.com> Date: Fri, 12 Feb 2016 21:07:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56BE21E6.20401@cs.ucla.edu> Content-Type: multipart/mixed; boundary="------------040406090200030109000403" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22624 Cc: sysstaff@math.utah.edu, 22624@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------040406090200030109000403 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 12/02/16 10:18, Paul Eggert wrote: > On 02/11/2016 08:13 PM, Pádraig Brady wrote: >> The changes look good, except for this: >> >> $ seq 1000 | split -n4 >> $ seq 100000 | split -n4 >> split: -: cannot determine file size: Illegal seek >> >> I.E. it would be better to indicate immediately >> if there is an issue determining the file size, >> because it's a gotcha that may hit users as data increases, >> and -n is complex enough anyway, that it's better to >> do as much checking up front as possible. >> I'd still disallow this case even for -n1 in case the >> number was parameterized to number of CPUs or whatever. > > Hmm, well, I already spent too much time on this so I think I'll check > in what I have (since it fixes the GNU/Hurd problem) and let it > percolate a bit first. > > I have some qualms about the approach suggested above, as it would cause > 'split' to give up on files that it currently handles (e.g., typical > files in /proc), on the theory that we don't want to spoil users into > thinking that 'split' can handle larger files. I've attached a patch that keeps support for /proc (seekable) files, while immediately failing for pipes. Also it fixes a regression for the the -n r/... case, where it again exits immediately when all --filters have exited. > It'd be better to fix > 'split' to handle the larger files. It could do this for a troublesome > case (e.g., a large /proc file) by copying the file's data into the > first output file F1, then doing a split-in-place from F1 to the > remaining output files F2 ... Fn (this would be done by copying to F2 > ... Fn and then truncating F1). Clever. Theoretically that could support pipes as input too! That also got me thinking that split(1) could be made very efficient with an existing regular file, where reflink(range) is supported, by reflinking the new files to the existing parts of the data. > If the input file is /dev/zero, though, > 'split' should just give up right away as it does now, as there's no > point in copying forever. +1 thanks, Pádraig. --------------040406090200030109000403 Content-Type: text/x-patch; name="split-n-fixes.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="split-n-fixes.patch" =46rom 6148fb80709e83c48895a0c9dc9342b2c937dc42 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?P=3DC3=3DA1draig=3D20Brady?=3D Date: Fri, 12 Feb 2016 20:15:51 -0800 Subject: [PATCH] split: adjust recent --number changes * src/split.c (lines_rr): Reinstate the conditional setting of the WROTE boolean, as otherwise split -n r/1 would spin forever writing to a closed --filter. There was a test in place to check for this, but it was incorrect as detailed below. (input_file_size): Immediately disallow --number with non seekable inputs, as such an invocation is not currently generally supported and will fail as the data overflows the internal buffer. * tests/split/l-chunk.sh: Adjust to again disallow -n /dev/zero. Also change all '&& fail=3D1' checks to use the 'returns_ 1' form. * tests/split/filter.sh: Change the no longer supported /dev/zero case to a regular $OFF_T_MAX file (supported on XFS for example). Also fix the timeout(1) commands so they're not subject to pipefail issues. --- src/split.c | 33 +++++++++++++++++++++------------ tests/split/filter.sh | 12 ++++++++---- tests/split/l-chunk.sh | 12 ++++++------ 3 files changed, 35 insertions(+), 22 deletions(-) diff --git a/src/split.c b/src/split.c index 0b10600..676aa2e 100644 --- a/src/split.c +++ b/src/split.c @@ -278,6 +278,14 @@ CHUNKS may be:\n\ static off_t input_file_size (int fd, struct stat const *st, char *buf, size_t bufsiz= e) { + off_t cur =3D lseek (fd, 0, SEEK_CUR); + if (cur < 0) + { + if (errno =3D=3D ESPIPE) + errno =3D 0; /* Suppress confusing seek error. */ + return -1; + } + off_t size =3D 0; do { @@ -290,19 +298,20 @@ input_file_size (int fd, struct stat const *st, cha= r *buf, size_t bufsize) } while (size < bufsize); =20 - /* The file contains at least BUFSIZE bytes. Infer its size via - st->st_size if this seems reliable, or via lseek if not. */ - off_t cur =3D lseek (fd, 0, SEEK_CUR); - off_t end; - if (cur < 0) - return -1; - if (cur < size) + /* Note we check st_size _after_ the read() above + because /proc files on GNU/Linux are seekable + but have st_size =3D=3D 0. */ + if (st->st_size =3D=3D 0) { - /* E.g., /dev/zero on GNU/Linux, where CUR is zero and SIZE =3D=3D= BUFSIZE. - Assume there is no limit to the file size. */ + /* We've filled the buffer, from a seekable file, + which has an st_size=3D=3D0, E.g., /dev/zero on GNU/Linux. + Assume there is no limit to file size. */ errno =3D EOVERFLOW; return -1; } + + cur +=3D size; + off_t end; if (usable_st_size (st) && cur <=3D st->st_size) end =3D st->st_size; else @@ -1197,7 +1206,8 @@ lines_rr (uintmax_t k, uintmax_t n, char *buf, size= _t bufsize) quotef (files[i_file].of_name)); } =20 - wrote =3D true; + if (! ignorable (errno)) + wrote =3D true; =20 if (file_limit) { @@ -1558,8 +1568,7 @@ main (int argc, char **argv) char *buf =3D ptr_align (b, page_size); size_t initial_read =3D SIZE_MAX; =20 - if ((split_type =3D=3D type_chunk_bytes || split_type =3D=3D type_chun= k_lines) - && n_units !=3D 1) + if (split_type =3D=3D type_chunk_bytes || split_type =3D=3D type_chunk= _lines) { file_size =3D input_file_size (STDIN_FILENO, &in_stat_buf, buf, in_blk_size); diff --git a/tests/split/filter.sh b/tests/split/filter.sh index e4e4dca..a93008b 100755 --- a/tests/split/filter.sh +++ b/tests/split/filter.sh @@ -18,6 +18,8 @@ =20 . "${srcdir=3D.}/tests/init.sh"; path_prepend_ ./src print_ver_ split +require_sparse_support_ # for 'truncate --size=3D$OFF_T_MAX' +eval $(getlimits) # for OFF_T limits xz --version || skip_ "xz (better than gzip/bzip2) required" =20 for total_n_lines in 5 3000 20000; do @@ -41,7 +43,7 @@ done # split does not run the command (and effectively elides the file) # only when the output to that command would have been empty. split -e -n 10 --filter=3D'xz > $FILE.xz' /dev/null || fail=3D1 -stat x?? 2>/dev/null && fail=3D1 +returns_ 1 stat x?? 2>/dev/null || fail=3D1 =20 # Ensure this invalid combination is flagged returns_ 1 split -n 1/2 --filter=3D'true' /dev/null 2>&1 || fail=3D1 @@ -50,8 +52,10 @@ returns_ 1 split -n 1/2 --filter=3D'true' /dev/null 2>= &1 || fail=3D1 # where they would result in a non zero exit from split. yes | head -n200K | split -b1G --filter=3D'head -c1 >/dev/null' || fail=3D= 1 =20 -# Ensure that endless input is ignored when all filters finish -timeout 10 yes | split --filter=3D"head -c1 >/dev/null" -n r/1 || fail=3D= 1 -timeout 10 split --filter=3D"head -c1 >/dev/null" -n 1 /dev/zero || fail= =3D1 +# Ensure that "endless" input is ignored when all filters finish +timeout 10 sh -c 'yes | split --filter=3D"head -c1 >/dev/null" -n r/1' |= | fail=3D1 +if truncate -s$OFF_T_MAX zero.in; then + timeout 10 sh -c 'split --filter=3D"head -c1 >/dev/null" -n 1 zero.in'= || fail=3D1 +fi =20 Exit $fail diff --git a/tests/split/l-chunk.sh b/tests/split/l-chunk.sh index 38297de..a7a9395 100755 --- a/tests/split/l-chunk.sh +++ b/tests/split/l-chunk.sh @@ -21,12 +21,12 @@ print_ver_ split =20 # invalid number of chunks echo "split: invalid number of chunks: '1o'" > exp -split -n l/1o 2>err && fail=3D1 +returns_ 1 split -n l/1o 2>err || fail=3D1 compare exp err || fail=3D1 =20 -echo > exp -echo | split -n l/1 || fail=3D1 -compare exp xaa || fail=3D1 +echo "split: -: cannot determine file size" > exp +: | returns_ 1 split -n l/1 2>err || fail=3D1 +compare exp err || fail=3D1 =20 # N can be greater than the file size # in which case no data is extracted, or empty files are written @@ -45,7 +45,7 @@ rm x?? =20 # Ensure --elide-empty-files is honored split -e -n l/10 /dev/null || fail=3D1 -stat x?? 2>/dev/null && fail=3D1 +returns_ 1 stat x?? 2>/dev/null || fail=3D1 =20 # 80 bytes. ~ transformed to \n below lines=3D\ @@ -79,7 +79,7 @@ for ELIDE_EMPTY in '' '-e'; do =20 if test -z "$ELIDE_EMPTY"; then split ---io-blksize=3D$IO_BLKSIZE -n l/2/$N in > chunk.k - stat x* 2>/dev/null && fail=3D1 + returns_ 1 stat x* 2>/dev/null || fail=3D1 fi =20 split ---io-blksize=3D$IO_BLKSIZE $ELIDE_EMPTY -n l/$N in --=20 2.5.0 --------------040406090200030109000403-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 25 11:50:32 2018 Received: (at 22624) by debbugs.gnu.org; 25 Oct 2018 15:50:32 +0000 Received: from localhost ([127.0.0.1]:42655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFhu3-00048a-Su for submit@debbugs.gnu.org; Thu, 25 Oct 2018 11:50:32 -0400 Received: from mail-it1-f174.google.com ([209.85.166.174]:50215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gFhu2-00048J-A0; Thu, 25 Oct 2018 11:50:30 -0400 Received: by mail-it1-f174.google.com with SMTP id k206-v6so2212650ite.0; Thu, 25 Oct 2018 08:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=snZNoMpRrXZOQFWoLUzKKauzxrVngXOxa8HQEEM7+Qc=; b=kDt5GvuD42BP5rOSm3PuqJImK77jxhA3qsPS7TN/06mwAilb3d5AdzHRmSzGM+qoo6 TsfPuqGH2eDSQJ6jce/4fy+VJ7p16dUAXL6yln0smRxzajAKOHn0v21jSOWc7+3/VPTi IDeT9bGjZEl61qr6GrHjcr8/rlRvV6BJLnPaYfCFy01u1CcDAs8a4EE8KqtNSdLZaSXy vRhrsURqJ59JUeEU4DJ0OfDvfteVOyF8DvJY7CEaqK5H2dq8mxLT19AARlgxgrlKfG9v b1WWtgjRTROOU/eoJ+HAPbddENOPGGGFqfRiubbLyfu5CEV0jhiGQPDmKuQildwWF02X yutw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=snZNoMpRrXZOQFWoLUzKKauzxrVngXOxa8HQEEM7+Qc=; b=R4AlF0PluLHPo0YfGgPyC6fPEtJrB+aVmxvUErbNZY7x9//UYqkWx3Pr1gQLfo8hZA xtBDgbImLpHrMRagphvzoCYI9y74aL7bsAGbr7Po/0cmkZ1ZSMwQAOGEGSB3zDu6uvHq sbscIBG/ho5/5/9RqnQmRcKQ+r1OgY7QSOOR8hBz8MzJW1dhVHeP+xq1ZAcp+rSG7dj7 fVf6rhH97Qr8t1LZ6F8vlx2e9Ryge5BNnOAKQjxTGPrI5Da+v+v17MdpfHmXa/PAPevu q8fU1bPzjmrNDY75JXcElMEvlxA+BnB/3pd2iTJIdQ5pFC4iLh/RHsSTJrZFPjV8fGf6 j64w== X-Gm-Message-State: AGRZ1gL054PH2NUWpjrAavstdXI0uBV9nIBmtXx44V3VDAaCI2Un5Qgc 9sbgax+tDGItIyL2op5bsczXcxsN X-Google-Smtp-Source: AJdET5cRbx1HQgXIwv3HxkV02EQ0hCB42Q6JOd4iBDlR1D21Gg6PrHCAALQyA/jdZFoiWUiBFXSYeQ== X-Received: by 2002:a24:728e:: with SMTP id x136-v6mr1212999itc.40.1540482624196; Thu, 25 Oct 2018 08:50:24 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.gmail.com with ESMTPSA id w20-v6sm2852339ioa.82.2018.10.25.08.50.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Oct 2018 08:50:22 -0700 (PDT) Date: Thu, 25 Oct 2018 09:50:19 -0600 From: Assaf Gordon To: 22624@debbugs.gnu.org Subject: Re: bug#22624: [bug-coreutils] coreutils-8.25: big success, but problem on GNU/Hurd Message-ID: <20181025155019.f4tla4scwtjojcl4@tomato.housegordon.com> References: <56BCC82F.6090108@cs.ucla.edu> <56BD5BE7.9040307@draigBrady.com> <56BE21E6.20401@cs.ucla.edu> <56BEB9FA.3090801@draigBrady.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56BEB9FA.3090801@draigBrady.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22624 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 22624 fixed close 22624 stop (triaging old bugs) With fixes commited in: https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=632eda520f7cf49d9d1662835c7c37e17033e128 https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=62e7af0326786a7dec91d982238948eddab9d6af And no further comments in over a year, I'm marking this as "fixed". -assaf From unknown Mon Jun 23 07:48:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 23 Nov 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator