From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 11:17:40 2016 Received: (at submit) by debbugs.gnu.org; 10 Feb 2016 16:17:40 +0000 Received: from localhost ([127.0.0.1]:35146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXSV-0001p4-St for submit@debbugs.gnu.org; Wed, 10 Feb 2016 11:17:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57444) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXSU-0001op-Jc for submit@debbugs.gnu.org; Wed, 10 Feb 2016 11:17:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTXSL-0007zP-JA for submit@debbugs.gnu.org; Wed, 10 Feb 2016 11:17:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXSL-0007zJ-GB for submit@debbugs.gnu.org; Wed, 10 Feb 2016 11:17:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXSK-00033p-La for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2016 11:17:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTXSG-0007xh-Pj for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2016 11:17:28 -0500 Received: from mail.hostpark.net ([212.243.197.30]:53527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXSG-0007wt-Ic for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2016 11:17:24 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id BEDBE16DBE for ; Wed, 10 Feb 2016 17:17:20 +0100 (CET) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id QEXVbZScAT7L for ; Wed, 10 Feb 2016 17:17:20 +0100 (CET) Received: from hal (84-73-67-69.dclient.hispeed.ch [84.73.67.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 6D61716DBA for ; Wed, 10 Feb 2016 17:17:20 +0100 (CET) User-agent: mu4e 0.9.17; emacs 25.0.50.1 From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Change to lm-header breaks lm-header-multiline Date: Wed, 10 Feb 2016 17:17:15 +0100 Message-ID: <87ziv8o7zo.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body is wrapped with `save-excursion', but `lm-header-multiline' only works properly if `lm-header' doesn't do that. In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25) of 2016-01-28 built on hal Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 11:30:52 2016 Received: (at control) by debbugs.gnu.org; 10 Feb 2016 16:30:53 +0000 Received: from localhost ([127.0.0.1]:35166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXfI-0002Ab-Op for submit@debbugs.gnu.org; Wed, 10 Feb 2016 11:30:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33079) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXfH-0002AK-C4 for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:30:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTXf7-0002yr-Oo for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:30:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXf7-0002yn-LS for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:30:41 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aTXf6-0007oi-Kr for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:30:41 -0500 Subject: control message for bug 22616 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 10 Feb 2016 11:30:40 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) merge 22510 22616 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 11:31:54 2016 Received: (at control) by debbugs.gnu.org; 10 Feb 2016 16:31:54 +0000 Received: from localhost ([127.0.0.1]:35170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXgI-0002Ci-07 for submit@debbugs.gnu.org; Wed, 10 Feb 2016 11:31:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33336) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXgH-0002CT-BA for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:31:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTXgB-0003Py-Lm for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:31:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXgB-0003Pu-Ih for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:31:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aTXgA-0007uC-1X for control@debbugs.gnu.org; Wed, 10 Feb 2016 11:31:46 -0500 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 10 Feb 2016 11:31:46 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) block 19759 by 22510 From debbugs-submit-bounces@debbugs.gnu.org Sun May 08 19:52:35 2016 Received: (at 22616) by debbugs.gnu.org; 8 May 2016 23:52:35 +0000 Received: from localhost ([127.0.0.1]:43586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azYV1-0003v7-8J for submit@debbugs.gnu.org; Sun, 08 May 2016 19:52:35 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azYV0-0003uu-76 for 22616@debbugs.gnu.org; Sun, 08 May 2016 19:52:34 -0400 Received: by mail-wm0-f43.google.com with SMTP id g17so159453129wme.1 for <22616@debbugs.gnu.org>; Sun, 08 May 2016 16:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=K5pGgthlBHU1Eq2LCdq8UW7L6kT6DSzxjaCGDIi95jQ=; b=yqZvMAcRmoreKVxnyivCkybE26mXCr0SrTIu7hIPUOS0eI9uNfeUroL+zZZuUhvQPv pmbZIlZMFnefIXkYDAP7yo4LBdH0AkjVlbq7LdwG0VDru4Tr+/4pkzfDmLdbBdsqukqn g/aLUHFgZ+yzrk1xvsGdywi2E/DuoavVcivaZLEiHgHDBzS3PyK0c4ZVpuxmm+qNEous B+XR/T4MNjx1bx3vzu1oO2pWkGszIXcEjyA2KKuJZvTCXRzKMKRS2iciKHHxl083Uiiw +ffaEyXSjjCjl27opDco3WHjOxnhazTMqk0RfwcOF8jZBHfMbtcFq2uKicDMdepELCqZ 21EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=K5pGgthlBHU1Eq2LCdq8UW7L6kT6DSzxjaCGDIi95jQ=; b=Vzue7T0nIFVGCSLiHyKO43TwGxus/zCVRXlmG6oUP+qjaQT5S1tBBsfKi9iqc6O8IA Z1Co+cIFVoAYWnfkSdg8stqUg4DsytBnqCimUF+YNhYbGBR1BlvCHveHZGzJzMgpJDSi LqJzXJWNuFPyvFO+NOuq+xOzOsrsriRRNXtVpJV9xkZXjqop9MsG9JzD82/4CXsM/rz6 +4d8fph7mVn/9aIdAyXyIyOdUYdGDZwHWANDTRuyorduW7TAt6ffWJH++hIKH5otPD6B dfdmIXuEAHTy9baRRkIC1iyM2cfFDg1Gc10CUu9p/aj2dIfayzudweNleSCiRPsCoxyH QRYA== X-Gm-Message-State: AOPr4FX8K/EH4/DLOdHQJt7Hls5XFWzFqg82y/3M32waK603z7b6PdB7CS8VirFMPfYb+A== X-Received: by 10.28.27.17 with SMTP id b17mr7885797wmb.19.1462751548641; Sun, 08 May 2016 16:52:28 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id w77sm21128408wmw.10.2016.05.08.16.52.27 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 08 May 2016 16:52:28 -0700 (PDT) Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline To: Jonas Bernoulli , 22616@debbugs.gnu.org References: <87ziv8o7zo.fsf@bernoul.li> From: Dmitry Gutov Message-ID: <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru> Date: Mon, 9 May 2016 02:52:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 MIME-Version: 1.0 In-Reply-To: <87ziv8o7zo.fsf@bernoul.li> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22616 Cc: Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Arthur, could you look into this one? And at the bug#22510 merged with it. Do you remember why you made this change? On 02/10/2016 06:17 PM, Jonas Bernoulli wrote: > Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body > is wrapped with `save-excursion', but `lm-header-multiline' only works > properly if `lm-header' doesn't do that. > > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25) > of 2016-01-28 built on hal > Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b From debbugs-submit-bounces@debbugs.gnu.org Sun May 08 22:13:43 2016 Received: (at 22616) by debbugs.gnu.org; 9 May 2016 02:13:43 +0000 Received: from localhost ([127.0.0.1]:43611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azaha-00079T-Nu for submit@debbugs.gnu.org; Sun, 08 May 2016 22:13:42 -0400 Received: from mail-yw0-f169.google.com ([209.85.161.169]:32792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azahY-00079D-IN for 22616@debbugs.gnu.org; Sun, 08 May 2016 22:13:41 -0400 Received: by mail-yw0-f169.google.com with SMTP id t10so272824580ywa.0 for <22616@debbugs.gnu.org>; Sun, 08 May 2016 19:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=hbscEyShBs5+DfkmUOKAf9ZoHfLRP5DISb1SEOHGJgA=; b=j6n4kFbrETw+W6fzyFt1qOS0vnJDq4NZfzwZsU/hMSc1rIzqBtlKLwC+j8ZDT6K9Lc xErRufISPp2BDUO3anYzmB4qOZAVXHYJ9/Y0gxaTV5qCGvGkh9BXgaVP7RVwfCAaFSsf 13lUZB7aGoGG4nqhHNvzmelFbA3afj6DiUT6dKiFAvEJUlsKfpTjfL9IocSA/YxftHM5 O/u3rRvU5G918HZkKVZhhuZYoLpuoCCURXD5TJg5O6/ltJBb3rocrfHnrj1tnIMimTga tM2DIh3F5tKlJCDaO02R3A9TuDe1qOOmQcgnT6+60kZL3PfRWjGCoj3x+lux295twN6l hb/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=hbscEyShBs5+DfkmUOKAf9ZoHfLRP5DISb1SEOHGJgA=; b=dQn5soYOH4SdWJ/qb3KfZM+fDLwBLuGMw6/ifDU3EtBtT6cQNYXpGWG1z7hvl7HXPe R8iop+92v6BJScDNemMQ3vpvqFfwjKCDBhnTV9hT+xNAUFyMoKsBk5qVBpd0C+69rakN kp82AGI0NUapTiBbd/gWjiWooKc/9Vx6UE4uuwCH+JfmiwRw+POvN3EcSNlllVdQco3z w6v+B73PoxNmpHojqe9soOusTg9r+8Q1vA9sqWnuyko2/hcabxd+ZarmIe+K9nndFWs1 +EnOAU3KKFFZ1yLOj1+p6HAMdH6+HGJUO/65tJHBQREQFz+LCM1f7rKp5ylAhcaD4IkR Gg+Q== X-Gm-Message-State: AOPr4FVvMM/L6DIrRC8svizuoiz1A1uVzVFWiZU6w1JWaFEw9SWTDcq09CCO26qr+BYYHRZbvLkq5fqZrNi3aQ== X-Received: by 10.129.155.5 with SMTP id s5mr17892869ywg.43.1462760014638; Sun, 08 May 2016 19:13:34 -0700 (PDT) MIME-Version: 1.0 References: <87ziv8o7zo.fsf@bernoul.li> <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru> In-Reply-To: <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru> From: Artur Malabarba Date: Mon, 09 May 2016 02:13:24 +0000 Message-ID: Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline To: Dmitry Gutov , Jonas Bernoulli , 22616@debbugs.gnu.org Content-Type: multipart/alternative; boundary=94eb2c0b897410773c05325f5bbc X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 22616 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --94eb2c0b897410773c05325f5bbc Content-Type: text/plain; charset=UTF-8 IIRC, I made this change because the previous behaviour caused `package-install-from-buffer' to move point. Since I saw no reason for lm-header to move point, I fixed the issue at its roots. Clearly, we've found a reason now. So the save excursion should be removed from the latter function to the former. On Sun, 8 May 2016 8:52 pm Dmitry Gutov, wrote: > Arthur, > > could you look into this one? And at the bug#22510 merged with it. > > Do you remember why you made this change? > > On 02/10/2016 06:17 PM, Jonas Bernoulli wrote: > > Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body > > is wrapped with `save-excursion', but `lm-header-multiline' only works > > properly if `lm-header' doesn't do that. > > > > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25) > > of 2016-01-28 built on hal > > Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b > --94eb2c0b897410773c05325f5bbc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

IIRC, I made this change because the previous behaviour caus= ed `package-install-from-buffer' to move point. Since I saw no reason f= or lm-header to move point, I fixed the issue at its roots.
Clearly, we've found a reason now. So the save excursion should be remo= ved from the latter function to the former.


On Sun, 8 May 2016 8:52 pm = Dmitry Gutov, <dgutov@yandex.ru&= gt; wrote:
Arthur,

could you look into this one? And at the bug#22510 merged with it.

Do you remember why you made this change?

On 02/10/2016 06:17 PM, Jonas Bernoulli wrote:
> Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header'= s body
> is wrapped with `save-excursion', but `lm-header-multiline' on= ly works
> properly if `lm-header' doesn't do that.
>
> In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25= )
>=C2=A0 of 2016-01-28 built on hal
> Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b
--94eb2c0b897410773c05325f5bbc-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 10 20:00:32 2016 Received: (at 22616) by debbugs.gnu.org; 11 May 2016 00:00:33 +0000 Received: from localhost ([127.0.0.1]:46427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0HZo-0004EZ-Oo for submit@debbugs.gnu.org; Tue, 10 May 2016 20:00:32 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0HZn-0004EM-Cu for 22616@debbugs.gnu.org; Tue, 10 May 2016 20:00:31 -0400 Received: by mail-wm0-f51.google.com with SMTP id a17so54178763wme.0 for <22616@debbugs.gnu.org>; Tue, 10 May 2016 17:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=crKnAiOD7ezn0bsv7Ym3v81LYpz94PaxdLZh6GPfwbI=; b=RjAIN+ETsR4jiAK8Zk+eC/ZWqJIeFyaFN0aQMgL+AdkzGJ3GbMxMaHRIImRg3vy5pS 3vjYaKRcAPASLqUMPGX2YoGv9tdO8lFzYiX298njgcoKycMplZOvCnfr6o2phxBy6ysX jtY/dlZOfKQgnpLS8m2o6i/O3oK/KsRwuyRxNClGS0K+HyvwLBqQTfLNX/rnztMJ4uRQ NrYYqQ5ZQEz4qcBEKTTMUmFTv/kUXjudl6QDa205F04DOZ3PpenX/4t3ZuZmrlm2QIfV USrDg9SUo30OAzb/t5cXzVk+CNuPPd8xggF760ewPR6RL1w4zvdfc/eciPOwmEwfzDDL X/uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=crKnAiOD7ezn0bsv7Ym3v81LYpz94PaxdLZh6GPfwbI=; b=Pxlr2X4hrEHeDb82T+fURNd3s5BqBIj2B93VknSpJ2FnTbDvS41SzbK0o44Ad8aZNA yVqFCiRrtT7LsL/4xn33q6n2VPSRKL2MeAHLwmrM6m5HBa2cw700ZzNIzzxBHHKtvLBZ RQe4RfrmfVnNsaozZymmxTjrW6nvhwvknrvuBYCPASHBXm0KRd8okvvzU3KfV5faRi1y OOKfCZALLCFzptnkA2DScTVfWo5sbjW7vyhsx91+xXukinNwS3FTKJ+Y8s19xrhDaAwO 63I3NJmKbJiYYffVjmjm0VUQvZfDCNfe2aIq/h06iCaRYCIAkb4KOpoLFgmmMMoMhqlB BNcA== X-Gm-Message-State: AOPr4FWpudFEwQCjRWZnLInnAV7yXkbpfDnfa24LFyxHJSIukp89vRKoakKLMJEHYStCzw== X-Received: by 10.195.11.197 with SMTP id ek5mr271871wjd.58.1462924825569; Tue, 10 May 2016 17:00:25 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id o73sm33006892wme.16.2016.05.10.17.00.23 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 10 May 2016 17:00:24 -0700 (PDT) Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline To: Artur Malabarba , Jonas Bernoulli , 22616@debbugs.gnu.org References: <87ziv8o7zo.fsf@bernoul.li> <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru> From: Dmitry Gutov Message-ID: <10d3267b-4566-dbe5-2bf6-7ae9893499b8@yandex.ru> Date: Wed, 11 May 2016 03:00:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22616 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 05/09/2016 05:13 AM, Artur Malabarba wrote: > IIRC, I made this change because the previous behaviour caused > `package-install-from-buffer' to move point. Since I saw no reason for > lm-header to move point, I fixed the issue at its roots. Doesn't package-install-from-buffer currently move point anyway? It jumps to the end of the buffer. Moving save-excursion there does help. diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 3f0e972..f481157 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1979,17 +1979,18 @@ package-install-from-buffer Downloads and installs required packages as needed." (interactive) (let* ((pkg-desc - (cond - ((derived-mode-p 'dired-mode) - ;; This is the only way a package-desc object with a `dir' - ;; desc-kind can be created. Such packages can't be - ;; uploaded or installed from archives, they can only be - ;; installed from local buffers or directories. - (package-dir-info)) - ((derived-mode-p 'tar-mode) - (package-tar-file-info)) - (t - (package-buffer-info)))) + (save-excursion + (cond + ((derived-mode-p 'dired-mode) + ;; This is the only way a package-desc object with a `dir' + ;; desc-kind can be created. Such packages can't be + ;; uploaded or installed from archives, they can only be + ;; installed from local buffers or directories. + (package-dir-info)) + ((derived-mode-p 'tar-mode) + (package-tar-file-info)) + (t + (package-buffer-info))))) (name (package-desc-name pkg-desc))) ;; Download and install the dependencies. (let* ((requires (package-desc-reqs pkg-desc)) From debbugs-submit-bounces@debbugs.gnu.org Wed May 11 18:34:54 2016 Received: (at 22616-done) by debbugs.gnu.org; 11 May 2016 22:34:54 +0000 Received: from localhost ([127.0.0.1]:47792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0ciU-0000Qx-9u for submit@debbugs.gnu.org; Wed, 11 May 2016 18:34:54 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0ciS-0000Qj-7Q for 22616-done@debbugs.gnu.org; Wed, 11 May 2016 18:34:52 -0400 Received: by mail-wm0-f51.google.com with SMTP id e201so236775197wme.0 for <22616-done@debbugs.gnu.org>; Wed, 11 May 2016 15:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=kNg30RS0OMaHYOm+gtaM6gB/NmLlKJgS9Odzr+6OKlU=; b=NMG9nki7YGE6DOg8/A4NFjSnrml9/ekVoSAnkELbwXpaNyw1d8PDQsliPcO68edTs6 Z2qPBOnWUKZbCVt9jp43V4xnCO4H6NLbJeIEti8PZVADsiqYKm8KQ7N4Wrms42NSe8K+ vyyyJx+LnyF0GjoIg9AJll0YvCneWvrx1wTv1f975Li7L04iKvdMHf03oca90bFufrRo RYgTg54XZKgEAqYDadLAhnshlZEmNf4W4z8phVWBrcQpgiOaoAViT4ovZK+28DvlObOC WxfAdiLE1U7EN23TPnDEUqKoO19IIx9dT+AQ4OzcQB7ROhF9JXeG7Hc+XgMKSkNJDruK qGQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=kNg30RS0OMaHYOm+gtaM6gB/NmLlKJgS9Odzr+6OKlU=; b=IUoQBB6Uq/+3+bQ8L8qCMvhzmjIoFafQ7pQ0rCZYEpMgM2fXvzSgg8X3qh0vsKMHuH Kw30Hqq8cD4V2q80mFORSXhYvrQfFUDlqMrWGH9RndifX9qZyUjQ9jgiEtdm8YAb3d9h yZkL+oEN3Fc5CJ8R6mLolGKn7IqACSYrxmgd4kGWngJwOje/FlIjTLyAOXb3QHfECo3g uxfwvHewU5KORI3xZarJOAy4s0j/8lSGDKkbDWhg7wpUDM50MBT7UyiauGCyhamz/cRQ o0MHVHgM5NgPB7FQ0++VK29tQigMmyQtNwEh6pDPWxTsJAs9qYFMnd7vb5qC5+S4IyZW q/Qg== X-Gm-Message-State: AOPr4FVQOCdtIq4nvXlFEGpMrfggPNZIiS9J7O+4YR5e3aVi5UprmYqIWcNHeXnh/ePLGw== X-Received: by 10.28.218.21 with SMTP id r21mr2577581wmg.100.1463006086533; Wed, 11 May 2016 15:34:46 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id ck9sm10218494wjc.22.2016.05.11.15.34.45 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 11 May 2016 15:34:45 -0700 (PDT) Subject: Re: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline To: Artur Malabarba , Jonas Bernoulli , 22616-done@debbugs.gnu.org References: <87ziv8o7zo.fsf@bernoul.li> <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru> <10d3267b-4566-dbe5-2bf6-7ae9893499b8@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 12 May 2016 01:34:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1 MIME-Version: 1.0 In-Reply-To: <10d3267b-4566-dbe5-2bf6-7ae9893499b8@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22616-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Version: 25.1 On 05/11/2016 03:00 AM, Dmitry Gutov wrote: > Moving save-excursion there does help. Applied, and closing. Thanks all. From unknown Sun Jun 22 00:21:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 09 Jun 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator