From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 07 17:54:59 2016 Received: (at submit) by debbugs.gnu.org; 7 Feb 2016 22:54:59 +0000 Received: from localhost ([127.0.0.1]:37693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSYEM-0005pM-RK for submit@debbugs.gnu.org; Sun, 07 Feb 2016 17:54:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:32802) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSYEK-0005p9-7F for submit@debbugs.gnu.org; Sun, 07 Feb 2016 17:54:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSYED-0007Ef-UP for submit@debbugs.gnu.org; Sun, 07 Feb 2016 17:54:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSYED-0007Eb-Qr for submit@debbugs.gnu.org; Sun, 07 Feb 2016 17:54:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSYEC-0002M9-GR for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 17:54:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSYE9-0007DR-2R for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 17:54:48 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSYE8-0007Ci-RB for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 17:54:44 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3694D20875 for ; Sun, 7 Feb 2016 17:54:43 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 07 Feb 2016 17:54:43 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=content-type:date:from:message-id:mime-version:subject:to :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=yCafzm7WxvlaHR47iHAVppCWNRM =; b=iwtK2WlX+BOel0rjL0Kkz9iVSHXQFMUDPLHww/K+zr8UQVGzSHXw71979fN 5E/EjzAGGQYJ3PWFVensvU7nMs+FiA9nfG2sWqL7Xa4pwL49o1essmzkDznhcUwm r3w87gZmDKBYepXZ5P1DhmCs4CB5EBdSTOo+KueyYGtIXxuU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=yC afzm7WxvlaHR47iHAVppCWNRM=; b=RgP0toEoQOq/DMU6NpmCVL1D9pwIEKj9N/ W/ldkP+aqOIgWK62u2YyQoNsaF0Mbv9CgLuXGXRkBZz5gN/ssvkqsFLDC06IP4VA TJMbyFDAqeN4cnv83NFjwAk0FY2gXk9YJF1pKY8OO+nBxd10Vtjv2/QXCXBuA4m8 ZWs+ZVNWU= X-Sasl-enc: n/qt0tFwFxpCq2s+dMZfhbYiMJZZT4NBdWRK5r5R4zzt 1454885682 Received: from shorty.local (cpe-108-185-223-73.socal.res.rr.com [108.185.223.73]) by mail.messagingengine.com (Postfix) with ESMTPA id BFD8A680218 for ; Sun, 7 Feb 2016 17:54:42 -0500 (EST) Received: from localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1aSYE3-0004lo-Ec for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 14:54:39 -0800 From: Dima Kogan To: bug-gnu-emacs@gnu.org Subject: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected Date: Sun, 07 Feb 2016 14:54:39 -0800 Message-ID: <87a8nc2ksw.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hi. Here are two small patches to improve handling of images loaded with the imagemagick backend. They are: 1. Accept integer :rotation parameters. Previously only floating-point ones worked 2. If an EXIF orientation tag exists and no explicit :rotation exists, use the orientation. This happens early in the processing, so all the data (width, height, etc) that emacs sees applies to the rotated image. The motivation for this was that I was tired of seeing upside-down photos in my mu4e mail. Thanks! --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-imagemagick-images-accept-integer-rotation-specs.patch >From 8e7e3d54f6202be3dbff34fd822d259d394fa318 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Sun, 7 Feb 2016 10:37:31 -0800 Subject: [PATCH 1/2] imagemagick images accept integer :rotation specs * src/image.c (imagemagick_load_image): previously we only accepted floating-point specifications, even though the most common rotations are 90, 180 and 270. Now integers work too. --- src/image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/image.c b/src/image.c index 144fe30..133d696 100644 --- a/src/image.c +++ b/src/image.c @@ -8646,7 +8646,7 @@ imagemagick_load_image (struct frame *f, struct image *img, image_spec_value (img->spec, QCbackground, NULL); if (!STRINGP (specified_bg). */ value = image_spec_value (img->spec, QCrotation, NULL); - if (FLOATP (value)) + if (FLOATP (value) || INTEGERP (value)) { rotation = extract_float (value); status = MagickRotateImage (image_wand, bg_wand, rotation); -- 2.1.4 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-imagemagick-respects-the-orientation-EXIF-tag.patch >From b070fb5f8b4e9cb84e15a8a7970e4dcb25696d1c Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Sun, 7 Feb 2016 14:43:24 -0800 Subject: [PATCH 2/2] imagemagick respects the orientation EXIF tag * src/image.c (imagemagick_load_image): images that have an orientation given in EXIF and have no explicit :rotation tag are now pre-rotated. All information such as width/height is reported for the rotated image --- src/image.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/image.c b/src/image.c index 133d696..45abfc7 100644 --- a/src/image.c +++ b/src/image.c @@ -8546,6 +8546,16 @@ imagemagick_load_image (struct frame *f, struct image *img, return 0; } + /* If no :rotation is explicitly specified, apply the automatic + rotation from EXIF. */ + if (NILP (image_spec_value (img->spec, QCrotation, NULL))) + if (MagickAutoOrientImage (image_wand) == MagickFalse) + { + image_error ("Error applying automatic orientation in image `%s'", img->spec); + DestroyMagickWand (image_wand); + return 0; + } + if (ino < 0 || ino >= MagickGetNumberImages (image_wand)) { image_error ("Invalid image number `%s' in image `%s'", image, img->spec); -- 2.1.4 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 08 22:03:19 2016 Received: (at 22591) by debbugs.gnu.org; 9 Feb 2016 03:03:19 +0000 Received: from localhost ([127.0.0.1]:60804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSyaE-0007lv-PS for submit@debbugs.gnu.org; Mon, 08 Feb 2016 22:03:18 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40058) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSyaD-0007ln-0G for 22591@debbugs.gnu.org; Mon, 08 Feb 2016 22:03:17 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aSyZq-0006rp-4T; Tue, 09 Feb 2016 04:02:54 +0100 From: Lars Ingebrigtsen To: Dima Kogan Subject: Re: bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected References: <87a8nc2ksw.fsf@secretsauce.net> Date: Tue, 09 Feb 2016 14:02:49 +1100 In-Reply-To: <87a8nc2ksw.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 07 Feb 2016 14:54:39 -0800") Message-ID: <8737t2lh5y.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aSyZq-0006rp-4T X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455591774.91119@wq0bwpUfP2Ynx/r61cG0yw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22591 Cc: 22591@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Dima Kogan writes: > Hi. Here are two small patches to improve handling of images loaded with > the imagemagick backend. They are: > > 1. Accept integer :rotation parameters. Previously only floating-point > ones worked > > 2. If an EXIF orientation tag exists and no explicit :rotation exists, > use the orientation. This happens early in the processing, so all the > data (width, height, etc) that emacs sees applies to the rotated image. > > The motivation for this was that I was tired of seeing upside-down > photos in my mu4e mail. Looks good. I wonder whether this should go in the trunk, though? It's a new feature of sorts. But we could consider not showing images correctly rotated a bug... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 09 23:41:05 2016 Received: (at 22591) by debbugs.gnu.org; 10 Feb 2016 04:41:05 +0000 Received: from localhost ([127.0.0.1]:34133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTMaM-0005f0-34 for submit@debbugs.gnu.org; Tue, 09 Feb 2016 23:41:05 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:38651) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTMaH-0005eZ-0K for 22591@debbugs.gnu.org; Tue, 09 Feb 2016 23:41:00 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aTMZr-0008DP-P2; Wed, 10 Feb 2016 05:40:32 +0100 From: Lars Ingebrigtsen To: Dima Kogan Subject: Re: bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected References: <87a8nc2ksw.fsf@secretsauce.net> <8737t2lh5y.fsf@gnus.org> Date: Wed, 10 Feb 2016 15:40:25 +1100 In-Reply-To: <8737t2lh5y.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 09 Feb 2016 14:02:49 +1100") Message-ID: <87mvr9i3eu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aTMZr-0008DP-P2 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455684032.585@dwRHSOGIW6Uro9Z2NAbMWQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22591 Cc: 22591@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > Dima Kogan writes: > >> Hi. Here are two small patches to improve handling of images loaded with >> the imagemagick backend. They are: >> >> 1. Accept integer :rotation parameters. Previously only floating-point >> ones worked >> >> 2. If an EXIF orientation tag exists and no explicit :rotation exists, >> use the orientation. This happens early in the processing, so all the >> data (width, height, etc) that emacs sees applies to the rotated image. >> >> The motivation for this was that I was tired of seeing upside-down >> photos in my mu4e mail. > > Looks good. I wonder whether this should go in the trunk, though? It's > a new feature of sorts. But we could consider not showing images > correctly rotated a bug... I applied it to emacs-25. Not respecting EXIF rotations is kinda a bug. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 09 23:46:24 2016 Received: (at control) by debbugs.gnu.org; 10 Feb 2016 04:46:24 +0000 Received: from localhost ([127.0.0.1]:34137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTMfY-0005mr-1I for submit@debbugs.gnu.org; Tue, 09 Feb 2016 23:46:24 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:42316) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTMfW-0005mi-1R for control@debbugs.gnu.org; Tue, 09 Feb 2016 23:46:22 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aTMf9-0008GD-UU for control@debbugs.gnu.org; Wed, 10 Feb 2016 05:46:00 +0100 Date: Wed, 10 Feb 2016 15:45:56 +1100 Message-Id: <87lh6ti35n.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22591 X-MailScanner-ID: 1aTMf9-0008GD-UU X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455684360.78361@OF6uK4zGC8EIKzbqslIhng X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 22591 fixed close 22591 25.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 11:35:26 2016 Received: (at 22591) by debbugs.gnu.org; 10 Feb 2016 16:35:26 +0000 Received: from localhost ([127.0.0.1]:35174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXji-0002Il-Fc for submit@debbugs.gnu.org; Wed, 10 Feb 2016 11:35:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34475) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTXjg-0002IY-Tb for 22591@debbugs.gnu.org; Wed, 10 Feb 2016 11:35:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTXjb-00046Z-2r for 22591@debbugs.gnu.org; Wed, 10 Feb 2016 11:35:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTXjN-00043T-Sp; Wed, 10 Feb 2016 11:35:05 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aTXjL-0008FZ-Rj; Wed, 10 Feb 2016 11:35:03 -0500 From: Glenn Morris To: Lars Ingebrigtsen Subject: Re: bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected References: <87a8nc2ksw.fsf@secretsauce.net> <8737t2lh5y.fsf@gnus.org> <87mvr9i3eu.fsf@gnus.org> X-Spook: SCUD missile Taliban Police secure Albania Consular USCG X-Ran: KYt;g9,_*7.5\EOWP*LypA,6#eUR3"{S*nryO(ing"{0|K (Lars Ingebrigtsen's message of "Wed, 10 Feb 2016 15:40:25 +1100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 22591 Cc: 22591@debbugs.gnu.org, Dima Kogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) This causes a build failure on RHEL 7.2, with ImageMagick-6.7. image.c:8552: undefined reference to `MagickAutoOrientImage' From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 21:28:33 2016 Received: (at 22591) by debbugs.gnu.org; 11 Feb 2016 02:28:33 +0000 Received: from localhost ([127.0.0.1]:35548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTgzh-00069o-Go for submit@debbugs.gnu.org; Wed, 10 Feb 2016 21:28:33 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:38926) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTgzf-00069e-Mz for 22591@debbugs.gnu.org; Wed, 10 Feb 2016 21:28:32 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aTgzF-0003JM-RF; Thu, 11 Feb 2016 03:28:06 +0100 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected References: <87a8nc2ksw.fsf@secretsauce.net> <8737t2lh5y.fsf@gnus.org> <87mvr9i3eu.fsf@gnus.org> Date: Thu, 11 Feb 2016 13:28:00 +1100 In-Reply-To: (Glenn Morris's message of "Wed, 10 Feb 2016 11:35:03 -0500") Message-ID: <874mdgoua7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aTgzF-0003JM-RF X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455762486.56944@YjKKiUV8kFyGK4f11mTYiA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22591 Cc: 22591@debbugs.gnu.org, Dima Kogan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Glenn Morris writes: > This causes a build failure on RHEL 7.2, with ImageMagick-6.7. > > image.c:8552: undefined reference to `MagickAutoOrientImage' Oops. I'll revert the patch in emacs-25, reapply it to the trunk, and then add autoconf tests for it there. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 17:14:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Mar 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator