From unknown Mon Aug 18 11:10:09 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS Reply-To: Eric Hanchrow , 2259@debbugs.gnu.org Resent-From: Eric Hanchrow Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 10 Feb 2009 03:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 2259 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123423707832061 (code B ref -1); Tue, 10 Feb 2009 03:45:02 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 10 Feb 2009 03:37:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=FOURLA,IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1A3boXD032053 for ; Mon, 9 Feb 2009 19:37:51 -0800 Received: from mx10.gnu.org ([199.232.76.166]:58241) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LWjPe-0002HS-Q5 for emacs-pretest-bug@gnu.org; Mon, 09 Feb 2009 22:35:54 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LWjRV-0006i7-7I for emacs-pretest-bug@gnu.org; Mon, 09 Feb 2009 22:37:50 -0500 Received: from wf-out-1314.google.com ([209.85.200.173]:49486) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LWjRU-0006hz-Nj for emacs-pretest-bug@gnu.org; Mon, 09 Feb 2009 22:37:49 -0500 Received: by wf-out-1314.google.com with SMTP id 28so2304072wfc.24 for ; Mon, 09 Feb 2009 19:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=eboYHM99NjpZt0kTUqguMXneSOyUKX0BiuRFjIS/SZk=; b=F24n+fVPja0npqmx2F3YdAXh8prxNZ8UmlnMf/gSsvXcxdKO3McQa2uPx7tcX1bwf+ bavV+86XeJEO98yqVyS+UnXnuFSGFXSKZlMqsDagVdH+XaiAXdBcJmZGE5bmMLxDgvKD t2i0SkmOCwqtH2mAeTrJUGKc2exOiYpeCMddg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=U/PtPiamGyQv50q1HWjpjdgY1DKemDyUBPWcZW0GZM4U24GLr6gogXC7uS8DrcRc/9 /key0niYEQ0P0YY7bCaNU322R7TwRDLrOMoJ7TlH0icf6fbQMhyBnmxJwX7MhXoPYhxp d1hjH5/mPFDIaSQENV5OdGKrycbSvkhrC7Ko8= MIME-Version: 1.0 Received: by 10.142.43.7 with SMTP id q7mr413050wfq.161.1234237067435; Mon, 09 Feb 2009 19:37:47 -0800 (PST) Date: Mon, 9 Feb 2009 19:37:47 -0800 Message-ID: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> From: Eric Hanchrow To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I noticed that (getenv "SSH_TTY" (selected-frame)) returned nil even though (assoc 'environment (frame-parameters (selected-frame))) returned an environment that indeed defined that variable. I poked around and saw that getenv was passing a frame to getenv_internal, but getenv_internal only consults that second argument if it's a CONS. This patch seems to fix the problem. diff --git a/lisp/env.el b/lisp/env.el index 8d8bebe..ad88ba8 100644 --- a/lisp/env.el +++ b/lisp/env.el @@ -198,7 +198,7 @@ in the environment list of the selected frame." (encode-coding-string variable locale-coding-system) variable) - frame))) + (and frame (assoc 'environment (frame-parameters frame)))))) (if (and enable-multibyte-characters value) (setq value (decode-coding-string value locale-coding-system))) (when (interactive-p) If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/local/src/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.90.1 (i686-pc-linux-gnu, GTK+ Version 2.14.4) of 2009-02-05 on debian Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: auto-fill-function: do-auto-fill recentf-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-netsplit-mode: t eldoc-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-autojoin-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-services-mode: t erc-networks-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-readonly-mode: t desktop-save-mode: t display-time-mode: t global-auto-revert-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: F RET C-x n d C-x b RET ESC C-n ESC C-p ESC C-n ESC C-p ESC C-n ESC C-f C-x b RET C-u C-n C-u C-n C-u C-n C-p C-p C-e ESC b C-s C-w C-s C-s C-a C-x b RET C-x b RET ESC C-n ESC C-n C-n C-x n w ESC C-d C-s C-w C-w C-s C-s C-s C-s C-s C-s C-a C-x n d C-x n w C-x 2 C-u C-@ ESC - C-l C-l C-x 0 C-x n d C-e ESC b C-s C-w C-s C-s C-s C-s C-s C-s C-s C-a C-x b RET C-x n w C-x v g l ESC 0 C-l C-x k RET C-x o C-x b i n i RET C-x b s c r RET C-p C-p ESC C-@ ESC w C-x o ESC m C-y ESC C-k TAB ESC b ESC C-u ESC C-k f r a m e C-x o ESC > ESC ( f r a m ESC / SPC n i l C-e C-j ESC C-p C-k C-p ESC C-d C-h f RET C-x b RET C-l ESC m ESC 1 ESC ( a n d SPC f r a m e SPC C-x C-s ESC C-x C-x b C-s RET ESC C-u ESC C-n C-x C-e C-x e DEL C-x b e m a RET C-g C-r s n o g ESC > r u d TAB s e e n SPC s n o g TAB g ESC / RET n u t s . RET C-x b RET C-x o C-x b C-s RET ESC x b y t e - r TAB RET RET RET y C-x v = C-x o ESC x r e p o r t - e m a c s - b u g RET Recent messages: Checking /usr/local/src/emacs/lisp/obsolete... Checking /usr/local/src/emacs/lisp/org... Checking /usr/local/src/emacs/lisp/play... Checking /usr/local/src/emacs/lisp/progmodes... Checking /usr/local/src/emacs/lisp/term... Checking /usr/local/src/emacs/lisp/textmodes... Checking /usr/local/src/emacs/lisp/url... Done (Total of 1 file compiled) Finding changes in /usr/local/src/emacs/lisp/env.el...done Scanning for dabbrevs...100% -- If there were a little guy running around inside the computer executing our programs, he would probably have as long and plaintive a tale to tell about his job as a federal government employee. -- Paul Graham From lekktu@gmail.com Tue Feb 10 00:56:09 2009 Received: (at control) by emacsbugs.donarmstrong.com; 10 Feb 2009 08:56:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1A8u6cp020908 for ; Tue, 10 Feb 2009 00:56:07 -0800 Received: by ewy3 with SMTP id 3so3019585ewy.1 for ; Tue, 10 Feb 2009 00:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=146Znmu0o2BnH/okGLDagcrsq5Tc/189kmHAwZOh/Z8=; b=m7bVZ3+0BzzwoCPgK7ytEnE3aKIEocE/04vSn0xG7bxo2LpmZrL0p6CnWLvF/amsBM yfjrCKxtpbWlPkcqN+GSjYj0DWEH1Am12/1UYOE/mrAQHH3q2dWco6rvNRnv06DnwaX9 j7lMG4ZsT5cdd+gE566GY7iqH1HxaMW9xjN1M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=UC5nwIOKvicGnsCcOY9Xn9g7CvYg/FQJyCJLAbDtnTiH25yGAwHkxfmFT4MmR0lb4R FWBMioSdE59oj16t017TVuf/U9h4XrbLQ2BMJANreHwA7QSs5W08ZUNAW73AdJFKxti8 mGspkSlIFME3uaTgzz14Ye21oTwrqRSlXvaok= MIME-Version: 1.0 Received: by 10.210.19.7 with SMTP id 7mr3008176ebs.41.1234256160712; Tue, 10 Feb 2009 00:56:00 -0800 (PST) Date: Tue, 10 Feb 2009 09:56:00 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit tags 2259 + patch reassign 2262 spam quit From unknown Mon Aug 18 11:10:09 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Eric Hanchrow Subject: bug#2259 closed by Juanma Barranquero (Re: bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS) Message-ID: References: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> X-Emacs-PR-Message: they-closed 2259 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Reply-To: 2259@debbugs.gnu.org Date: Tue, 10 Feb 2009 10:30:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1234261804-16553-1" This is a multi-part message in MIME format... ------------=_1234261804-16553-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #2259: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal,= when it should instead pass a CONS It has been closed by Juanma Barranquero . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Juanma Barranquero by replying to this email. --=20 2259: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D2259 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1234261804-16553-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2259-done) by emacsbugs.donarmstrong.com; 10 Feb 2009 10:24:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.9 required=4.0 tests=FOURLA,GMAIL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1AAOmTn014990 for <2259-done@emacsbugs.donarmstrong.com>; Tue, 10 Feb 2009 02:24:49 -0800 Received: by ewy3 with SMTP id 3so3049695ewy.1 for <2259-done@emacsbugs.donarmstrong.com>; Tue, 10 Feb 2009 02:24:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=eBvo44Mg8HfRD4UPFZ4oDmMuXRLhN/QpULo+NZzINiU=; b=RvKtJ1bKg0sIZUsSZ4zg9o2izJVL3ms6RdMJxu0382hcvpkc60CM91gjio37E5x2Vh ZP/O147mXSlQnKJi/V8ivlUZJxIE75SEHj1+ykQGJ4NvGuf1EOJxK2NKA98zpS1CtKJx SRzNwlOW3qUwVIaRSr/wVmmpekDg7xKjSvpeM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=OanX4/uN9kMYw5zwDwNXSEV0nFPRtwxI0gG5Q/Wj0PqT2JTlcigsZC94+jJjm1AZyc ZPtjY463w0BsN1rbaAM89pBSx08ut1gNKIob5qunxYKqEJ77OgohDgDx0YtLyQ3+qapO kiTDlx3cZrJubhdUOT63+A/Ov+flgbB3UYdkQ= MIME-Version: 1.0 Received: by 10.210.42.20 with SMTP id p20mr1381675ebp.66.1234261482807; Tue, 10 Feb 2009 02:24:42 -0800 (PST) In-Reply-To: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> References: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> Date: Tue, 10 Feb 2009 11:24:42 +0100 Message-ID: Subject: Re: bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS From: Juanma Barranquero To: Eric Hanchrow , Stefan Monnier Cc: 2259-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Tue, Feb 10, 2009 at 04:37, Eric Hanchrow wrote: > I poked around and > saw that getenv was passing a frame to getenv_internal, but > getenv_internal only consults that second argument if it's a CONS. This > patch seems to fix the problem. I think the patch is right, so I'm committing it. getenv-internal's docstring used to say that it searches in the frame environment, but it wasn't right and was recently fixed. (The few) other uses of getenv-internal rightly treat ENV as a list of environment variables. Stefan, I just saw that `server-with-environment' does this: (let ((,value (getenv-internal ,var ,env))) (push (if (null ,value) ,var (concat ,var "=" ,value)) process-environment))) which will fail if ENV contains a negative entry. Is that a bug, or it is known at that point that the ENV arg of `server-with-environment' will never contain negative entries (i.e., can the output of (process-get process 'env) contain negative entries)? If it is intended, perhaps a comment would be in order. Juanma ------------=_1234261804-16553-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 10 Feb 2009 03:37:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=FOURLA,IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1A3boXD032053 for ; Mon, 9 Feb 2009 19:37:51 -0800 Received: from mx10.gnu.org ([199.232.76.166]:58241) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LWjPe-0002HS-Q5 for emacs-pretest-bug@gnu.org; Mon, 09 Feb 2009 22:35:54 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LWjRV-0006i7-7I for emacs-pretest-bug@gnu.org; Mon, 09 Feb 2009 22:37:50 -0500 Received: from wf-out-1314.google.com ([209.85.200.173]:49486) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LWjRU-0006hz-Nj for emacs-pretest-bug@gnu.org; Mon, 09 Feb 2009 22:37:49 -0500 Received: by wf-out-1314.google.com with SMTP id 28so2304072wfc.24 for ; Mon, 09 Feb 2009 19:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=eboYHM99NjpZt0kTUqguMXneSOyUKX0BiuRFjIS/SZk=; b=F24n+fVPja0npqmx2F3YdAXh8prxNZ8UmlnMf/gSsvXcxdKO3McQa2uPx7tcX1bwf+ bavV+86XeJEO98yqVyS+UnXnuFSGFXSKZlMqsDagVdH+XaiAXdBcJmZGE5bmMLxDgvKD t2i0SkmOCwqtH2mAeTrJUGKc2exOiYpeCMddg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=U/PtPiamGyQv50q1HWjpjdgY1DKemDyUBPWcZW0GZM4U24GLr6gogXC7uS8DrcRc/9 /key0niYEQ0P0YY7bCaNU322R7TwRDLrOMoJ7TlH0icf6fbQMhyBnmxJwX7MhXoPYhxp d1hjH5/mPFDIaSQENV5OdGKrycbSvkhrC7Ko8= MIME-Version: 1.0 Received: by 10.142.43.7 with SMTP id q7mr413050wfq.161.1234237067435; Mon, 09 Feb 2009 19:37:47 -0800 (PST) Date: Mon, 9 Feb 2009 19:37:47 -0800 Message-ID: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> Subject: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS From: Eric Hanchrow To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I noticed that (getenv "SSH_TTY" (selected-frame)) returned nil even though (assoc 'environment (frame-parameters (selected-frame))) returned an environment that indeed defined that variable. I poked around and saw that getenv was passing a frame to getenv_internal, but getenv_internal only consults that second argument if it's a CONS. This patch seems to fix the problem. diff --git a/lisp/env.el b/lisp/env.el index 8d8bebe..ad88ba8 100644 --- a/lisp/env.el +++ b/lisp/env.el @@ -198,7 +198,7 @@ in the environment list of the selected frame." (encode-coding-string variable locale-coding-system) variable) - frame))) + (and frame (assoc 'environment (frame-parameters frame)))))) (if (and enable-multibyte-characters value) (setq value (decode-coding-string value locale-coding-system))) (when (interactive-p) If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/local/src/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.90.1 (i686-pc-linux-gnu, GTK+ Version 2.14.4) of 2009-02-05 on debian Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: auto-fill-function: do-auto-fill recentf-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-netsplit-mode: t eldoc-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-autojoin-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-services-mode: t erc-networks-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-readonly-mode: t desktop-save-mode: t display-time-mode: t global-auto-revert-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: F RET C-x n d C-x b RET ESC C-n ESC C-p ESC C-n ESC C-p ESC C-n ESC C-f C-x b RET C-u C-n C-u C-n C-u C-n C-p C-p C-e ESC b C-s C-w C-s C-s C-a C-x b RET C-x b RET ESC C-n ESC C-n C-n C-x n w ESC C-d C-s C-w C-w C-s C-s C-s C-s C-s C-s C-a C-x n d C-x n w C-x 2 C-u C-@ ESC - C-l C-l C-x 0 C-x n d C-e ESC b C-s C-w C-s C-s C-s C-s C-s C-s C-s C-a C-x b RET C-x n w C-x v g l ESC 0 C-l C-x k RET C-x o C-x b i n i RET C-x b s c r RET C-p C-p ESC C-@ ESC w C-x o ESC m C-y ESC C-k TAB ESC b ESC C-u ESC C-k f r a m e C-x o ESC > ESC ( f r a m ESC / SPC n i l C-e C-j ESC C-p C-k C-p ESC C-d C-h f RET C-x b RET C-l ESC m ESC 1 ESC ( a n d SPC f r a m e SPC C-x C-s ESC C-x C-x b C-s RET ESC C-u ESC C-n C-x C-e C-x e DEL C-x b e m a RET C-g C-r s n o g ESC > r u d TAB s e e n SPC s n o g TAB g ESC / RET n u t s . RET C-x b RET C-x o C-x b C-s RET ESC x b y t e - r TAB RET RET RET y C-x v = C-x o ESC x r e p o r t - e m a c s - b u g RET Recent messages: Checking /usr/local/src/emacs/lisp/obsolete... Checking /usr/local/src/emacs/lisp/org... Checking /usr/local/src/emacs/lisp/play... Checking /usr/local/src/emacs/lisp/progmodes... Checking /usr/local/src/emacs/lisp/term... Checking /usr/local/src/emacs/lisp/textmodes... Checking /usr/local/src/emacs/lisp/url... Done (Total of 1 file compiled) Finding changes in /usr/local/src/emacs/lisp/env.el...done Scanning for dabbrevs...100% -- If there were a little guy running around inside the computer executing our programs, he would probably have as long and plaintive a tale to tell about his job as a federal government employee. -- Paul Graham ------------=_1234261804-16553-1-- From unknown Mon Aug 18 11:10:09 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to getenv_internal, when it should instead pass a CONS Reply-To: Juanma Barranquero , 2259@debbugs.gnu.org Resent-From: Juanma Barranquero Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 10 Feb 2009 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2259 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Received: via spool by 2259-submit@emacsbugs.donarmstrong.com id=B2259.123428223424791 (code B ref 2259); Tue, 10 Feb 2009 16:15:02 +0000 Received: (at 2259) by emacsbugs.donarmstrong.com; 10 Feb 2009 16:10:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.9 required=4.0 tests=FOURLA,GMAIL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1AGAQ2q024777 for <2259@emacsbugs.donarmstrong.com>; Tue, 10 Feb 2009 08:10:28 -0800 Received: by ewy3 with SMTP id 3so3183486ewy.1 for <2259@emacsbugs.donarmstrong.com>; Tue, 10 Feb 2009 08:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=YCvtXAVrtZ2g7vJFZjgWLQ+AIfVbz+rslx7vyp2voKA=; b=HyO6f9W/nA7/ZBWVimr0nyf/WmKtTBR4YL1iLxtFWhRhWjQSTP9d1ocPPex/ExPiXp SoFHCAWT1/3sKETUofsf2MC6G+3KkzjdSIGwblB5TxoIEJ3GapPwjorELasWurddsGOJ D0Ywro1K0ADWvdOCOnawUJRKMHsz8AayBcdS8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=XCuzRZtTQjvwBxMC11BTaWUPuu8VjiYSzMfelU10p/D1FAlkC0YlevpYLoiJJd1TIe UCCVieV3gAMMtDhXnOa7DiiZ+VQKRVQxW+mDjOxtQGChfKQuTIOhec7XIXahlGQSlo4a aRuiEzWt+zqm55ljzMMGUChydAX1bcgkI7PLQ= MIME-Version: 1.0 Received: by 10.210.34.19 with SMTP id h19mr3346024ebh.199.1234282220811; Tue, 10 Feb 2009 08:10:20 -0800 (PST) In-Reply-To: References: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> Date: Tue, 10 Feb 2009 17:10:20 +0100 Message-ID: From: Juanma Barranquero To: Eric Hanchrow , Stefan Monnier Cc: 2259@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Tue, Feb 10, 2009 at 11:24, Juanma Barranquero wrote: > or it > is known at that point that the ENV arg of `server-with-environment' > will never contain negative entries (i.e., can the output of > (process-get process 'env) contain negative entries)? If it is > intended, perhaps a comment would be in order. OK, I see now that "ENV should be in the same format as `process-environment'", and that, in `process-environment', "[e]ach element should be a string of the form ENVVARNAME=VALUE". So yes, it is known that there shouldn't be negative entries, and it is even documented. Still, perhaps this change would be useful... Juanma Index: server.el =================================================================== RCS file: /sources/emacs/emacs/lisp/server.el,v retrieving revision 1.188 diff -u -2 -r1.188 server.el --- server.el 7 Feb 2009 21:59:35 -0000 1.188 +++ server.el 10 Feb 2009 15:55:04 -0000 @@ -241,7 +241,7 @@ (dolist (,var ,vars) (let ((,value (getenv-internal ,var ,env))) - (push (if (null ,value) - ,var - (concat ,var "=" ,value)) + (push (if (stringp ,value) + (concat ,var "=" ,value) + ,var) process-environment))) (progn ,@body)))) From unknown Mon Aug 18 11:10:09 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2259: 23.0.90; PATCH: getenv mistakenly passes a frame to Reply-To: Stefan Monnier , 2259@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 11 Feb 2009 01:55:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2259 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Received: via spool by 2259-submit@emacsbugs.donarmstrong.com id=B2259.12343167402661 (code B ref 2259); Wed, 11 Feb 2009 01:55:06 +0000 Received: (at 2259) by emacsbugs.donarmstrong.com; 11 Feb 2009 01:45:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1B1jbr0002645 for <2259@emacsbugs.donarmstrong.com>; Tue, 10 Feb 2009 17:45:38 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArEEADC8kUlFxIvi/2dsb2JhbACBbtFxhBoGgyM X-IronPort-AV: E=Sophos;i="4.38,188,1233550800"; d="scan'208";a="33694772" Received: from 69-196-139-226.dsl.teksavvy.com (HELO pastel.home) ([69.196.139.226]) by ironport2-out.teksavvy.com with ESMTP; 10 Feb 2009 20:45:31 -0500 Received: by pastel.home (Postfix, from userid 20848) id 8E2D27FE6; Tue, 10 Feb 2009 20:45:31 -0500 (EST) From: Stefan Monnier To: Juanma Barranquero Cc: Eric Hanchrow , 2259@debbugs.gnu.org Message-ID: References: <36366a980902091937x40e025cbm6b351ab4620d6281@mail.gmail.com> Date: Tue, 10 Feb 2009 20:45:31 -0500 In-Reply-To: (Juanma Barranquero's message of "Tue, 10 Feb 2009 17:10:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > OK, I see now that "ENV should be in the same format as > `process-environment'", and that, in `process-environment', "[e]ach > element should be a string of the form ENVVARNAME=VALUE". So yes, it > is known that there shouldn't be negative entries, and it is even > documented. > Still, perhaps this change would be useful... Yes, it looks good, Stefan