GNU bug report logs - #22583
25.1.50; find-function-search-for-symbol don't call find-function-after-hook

Previous Next

Package: emacs;

Reported by: Tino Calancha <f92capac <at> gmail.com>

Date: Sun, 7 Feb 2016 15:16:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 25.1.50

Fixed in version 26.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Tino Calancha <f92capac <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Tino Calancha <f92capac <at> gmail.com>, 22583 <at> debbugs.gnu.org
Subject: bug#22583: 25.1.50; find-function-search-for-symbol don't call find-function-after-hook
Date: Mon, 8 Feb 2016 21:50:04 +0900 (JST)

[Message part 1 (text/plain, inline)]
>find-function-search-for-symbol is a querying function. It can be used by different consumers, e.g. xref-location-marker.
>I'm not sure the user would want find-function-after-hook to run in every such case.
Right: the hook may be unnecessary called many times. Not good.

>Maybe help-variable-def's button definition's help-function should run the hook explicitly instead.
Thanks for the tip. This way looks more sensible.
[help-mode.patch (text/plain, attachment)]
This bug report was last modified 8 years and 175 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.