GNU bug report logs - #22580
ls-quotes: shell-escape in tty in ls

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#22580: closed (ls-quotes: shell-escape in tty in ls)
Date: Thu, 13 Dec 2018 20:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 13 Dec 2018 13:22:20 -0700
with message-id <38585bc3-8338-e935-dd89-f29b4e0fbdbe <at> gmail.com>
and subject line Re: bug#22580: shell-escape in tty in ls
has caused the debbugs.gnu.org bug report #22580,
regarding ls-quotes: shell-escape in tty in ls
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
22580: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22580
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Vint <pjvint <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: shell-escape in tty in ls
Date: Sat, 6 Feb 2016 23:28:59 -0500

[Message part 3 (text/plain, inline)]

Maybe I'm the only one, but the new change in ls seems bad:

      set_quoting_style (NULL, shell_escape_quoting_style);

This is set if the output is a TTY.
Why would we want to quote if the output is a TTY?

It makes the output appear strange to me.

Example:
### Begin paste from terminal  ####
pvint <at> localhost ~ $ mkdir ls
pvint <at> localhost ~ $ cd ls
pvint <at> localhost ~/ls $ touch HelloWorld
pvint <at> localhost ~/ls $ touch Hello\ World
pvint <at> localhost ~/ls $ ls
'Hello World'  HelloWorld
pvint <at> localhost ~/ls $ ls -l
total 0
-rw-r--r-- 1 pvint users 0 Feb  6 22:35 'Hello World'
-rw-r--r-- 1 pvint users 0 Feb  6 22:35 HelloWorld
#### end paste from terminal  ####

This change occurred at version 8.25
http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=109b9220cead6e979d22d16327c4d9f8350431cc#patch3

I don't see the benefit to this change (partly because I'm a stubborn old
guy who thinks "it's been this way for decades!"), but if there is a good
one, I'll say "Cool, thanks!".

Cheers,
Paul Vint
pjvint <at> gmail.com

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Paul Vint <pjvint <at> gmail.com>, 22580-done <at> debbugs.gnu.org
Subject: Re: bug#22580: shell-escape in tty in ls
Date: Thu, 13 Dec 2018 13:22:20 -0700

Hello,

On 2016-02-07 12:44 a.m., Pádraig Brady wrote:
> On 06/02/16 20:28, Paul Vint wrote:
>> Maybe I'm the only one, but the new change in ls seems bad:
>>
>>        set_quoting_style (NULL, shell_escape_quoting_style);
>>
>> This is set if the output is a TTY.
>> Why would we want to quote if the output is a TTY?
>>
>> It makes the output appear strange to me.
>>

We created a summary of common issues and FAQ
regarding the quoting change in ls(1):
  https://www.gnu.org/software/coreutils/quotes.html

If there is an issue that is not addressed there,
please send an email to coreutils <at> gnu.org .

regards,
 - assaf

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.