GNU bug report logs - #22577
25.0.50; vc-git-grep fails when searching for `all' files

Previous Next

Full log

Message #8 received at 22577 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Óscar Fuentes <ofv <at> wanadoo.es>, 22577 <at> debbugs.gnu.org
Subject: Re: bug#22577: 25.0.50; vc-git-grep fails when searching for `all'
 files
Date: Mon, 8 Feb 2016 06:46:37 +0200

On 02/07/2016 05:17 AM, Óscar Fuentes wrote:

> I propose the following patch to fix this problem. Shell gurus, please
> review.

(Not a guru here.)

> diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
> index 7e6f157..3f77a2a 100644
> --- a/lisp/progmodes/grep.el
> +++ b/lisp/progmodes/grep.el
> @@ -189,7 +189,7 @@ grep-find-template
>     :group 'grep)
>
>   (defcustom grep-files-aliases
> -  '(("all" .   "* .*")
> +  '(("all" .   "* .[^\\.]*")

I think you don't even need the escape (and it would create a false 
negative for file names starting with '.\'; but nobody should have those 
anyway). Otherwise, it looks good.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.