GNU bug report logs - #22577
25.0.50; vc-git-grep fails when searching for `all' files

Previous Next

Full log

Message #11 received at 22577 <at> debbugs.gnu.org (full text, mbox):

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 22577 <at> debbugs.gnu.org
Subject: Re: bug#22577: 25.0.50;
 vc-git-grep fails when searching for `all' files
Date: Mon, 08 Feb 2016 06:59:33 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> (Not a guru here.)

Thanks for commenting anyways :-)

>> -  '(("all" .   "* .*")
>> +  '(("all" .   "* .[^\\.]*")
>
> I think you don't even need the escape (and it would create a false
> negative for file names starting with '.\'; but nobody should have
> those anyway). Otherwise, it looks good.

It seems that the escape is not required, although every example I saw
on the Internets uses it (one copying the another, I guess.)

What I've discovered while investigating your commentary is that the
[^.] syntax is not POSIX and some shells (posh) does not admit it. The
syntax required by POSIX is [!.]. I checked that .[!.]* works as
expected on GNU/Linux and on Windows (MSYS2 and cmd.exe calling git and
grep). It doesn't work on Eshell, but that doesn't count.

On a few days I'll commit the patch using the [!.] syntax, if nobody
objects to it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.