From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 03:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22577@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145481504115028 (code B ref -1); Sun, 07 Feb 2016 03:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Feb 2016 03:17:21 +0000 Received: from localhost ([127.0.0.1]:36228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSFqi-0003uK-Nz for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34353) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSFqg-0003u6-Ar for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSFqa-0001A8-9v for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSFqa-0001A4-6n for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSFqZ-0006Bq-7t for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 22:17:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSFqU-00019r-8G for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 22:17:11 -0500 Received: from relaycp03.dominioabsoluto.net ([217.116.26.84]:46742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSFqU-00017q-0o for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 22:17:06 -0500 Received: from smtp.movistar.es (smtp08.acens.net [86.109.99.132]) by relaycp03.dominioabsoluto.net (Postfix) with ESMTP id 2CC08BFA130 for ; Sun, 7 Feb 2016 04:17:04 +0100 (CET) X-CTCH-RefID: str=0001.0A0B0203.56B6B730.0027, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Received: from qcore (83.38.42.1) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56A8ACDF00D217A3 for bug-gnu-emacs@gnu.org; Sun, 7 Feb 2016 03:17:04 +0000 From: =?UTF-8?Q?=C3=93scar?= Fuentes Date: Sun, 07 Feb 2016 04:17:03 +0100 Message-ID: <878u2xyztc.fsf@telefonica.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) emacs -Q M-x vc-dir M-x vc-git-grep Search for: foo Search for "foo" in files (default all): In directory: The command fails with -*- mode: grep; default-directory: "~/dev/emacs/emacs/" -*- Grep started at Sun Feb 7 03:54:09 git --no-pager grep -n -e VC -- * .* fatal: ..: '..' is outside repository Grep exited abnormally with code 128 at Sun Feb 7 03:54:09 The problem consists on `all' defaulting to the file patterns "* .*", as defined in the variable `grep-files-aliases'. Those patterns matches ".." (the parent directory) which is outside the git repo (when you execute vc-git-grep on the top directory of the repo.) BTW, this pattern creates unnecesary noise when used with the `grep' commands, adding to the grep output lines such as grep: .: Is a directory grep: ..: Is a directory I propose the following patch to fix this problem. Shell gurus, please review. diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index 7e6f157..3f77a2a 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -189,7 +189,7 @@ grep-find-template :group 'grep) (defcustom grep-files-aliases - '(("all" . "* .*") + '(("all" . "* .[^\\.]*") ("el" . "*.el") ("ch" . "*.[ch]") ("c" . "*.c") In GNU Emacs 25.0.50.29 (x86_64-unknown-linux-gnu, X toolkit) of 2016-01-21 built on qcore Repository revision: 5293d1bdb3e665a565af032a163004c976328cc2 Windowing system distributor 'The X.Org Foundation', version 11.0.11702000 System Description: Ubuntu 15.10 Configured using: 'configure --without-toolkit-scroll-bars --with-x-toolkit=lucid' Configured features: XAW3D XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB LUCID X11 Important settings: value of $LANG: C locale-coding-system: nil Major mode: Emacs-Lisp From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=C3=93scar?= Fuentes , 22577@debbugs.gnu.org Received: via spool by 22577-submit@debbugs.gnu.org id=B22577.14549068134433 (code B ref 22577); Mon, 08 Feb 2016 04:47:02 +0000 Received: (at 22577) by debbugs.gnu.org; 8 Feb 2016 04:46:53 +0000 Received: from localhost ([127.0.0.1]:37839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSdiv-00019R-6Z for submit@debbugs.gnu.org; Sun, 07 Feb 2016 23:46:53 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38590) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSdit-00019E-FH for 22577@debbugs.gnu.org; Sun, 07 Feb 2016 23:46:51 -0500 Received: by mail-wm0-f53.google.com with SMTP id p63so99321499wmp.1 for <22577@debbugs.gnu.org>; Sun, 07 Feb 2016 20:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=P2zKrrAoAEE0fXSt0m/mCWnGgilrubmvkdYunfFkwlQ=; b=LBM3arypiESJjR3q1GGXaSCMoSzve4dquKk93A9uSVxToA1Cu2S86jA5VcRHdLCWV9 GKcX+mdGxZ0NB7ctN3JPdUhMtGp559bFEFMTvqCGRmLeSmnFDEezS4zI9VI1G5yu1qqC /rUR8f9/2pytsAgq+YlUK+T3IiA1wHJmclDDAs4oGlo70EH4DPYAnDM5i246uFKZiM5P Fiyj3y9TcSvZXMetJP7gLvvwYxDu91FEmNr+H+z/zLae3qgtXpm8wgIHfi7k8h3U0W/k Neauuq6iehQtZ/hDCNSMRIytYGpXtMIH+XZpcm4CySKP1XgWMacUY3FWaDSWeZFuzfWT RH3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=P2zKrrAoAEE0fXSt0m/mCWnGgilrubmvkdYunfFkwlQ=; b=dw0qqtmaWQqueRHl+eTzYjW6Kq1REbBY2S1zF7NkGZvMfmOxCRCcNWyxPjgLAeAmmt 927NpdSkyJVnp1H4Ey2rSJpJF+v036Wd+KcI5k1yKXFtiUq7UBTbFvrhHUUUOvcPKc/g j2dTNFogNLhh9z22dak1D5N5qnhY/WsOZaTzQpyf7kHDIW7EPQtd1TnbEjbBeffC1G3c nYl7qf0v9tBviXsWOb/1JhFvtnJR1CY0BIsVqQBMgKrAU+CdHpdZXbo/EowdPlS36QEx b+n3Yyq7Jup7FS8n+QGkJQnX2l/+E9LuEwI/HG/5vEETVmtDnBNOstX+HYUjvZg8H5lJ NghA== X-Gm-Message-State: AG10YOQUXppdCwcQmpinQTVPOB7X9FzCif7ynV1JFporNiUdw/eerJTqPDNo+ebrYU1NsQ== X-Received: by 10.194.133.233 with SMTP id pf9mr25859650wjb.75.1454906805817; Sun, 07 Feb 2016 20:46:45 -0800 (PST) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id lm5sm18804223wjc.12.2016.02.07.20.46.43 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 07 Feb 2016 20:46:44 -0800 (PST) References: <878u2xyztc.fsf@telefonica.net> From: Dmitry Gutov Message-ID: <56B81DAD.8010303@yandex.ru> Date: Mon, 8 Feb 2016 06:46:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <878u2xyztc.fsf@telefonica.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/07/2016 05:17 AM, Óscar Fuentes wrote: > I propose the following patch to fix this problem. Shell gurus, please > review. (Not a guru here.) > diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el > index 7e6f157..3f77a2a 100644 > --- a/lisp/progmodes/grep.el > +++ b/lisp/progmodes/grep.el > @@ -189,7 +189,7 @@ grep-find-template > :group 'grep) > > (defcustom grep-files-aliases > - '(("all" . "* .*") > + '(("all" . "* .[^\\.]*") I think you don't even need the escape (and it would create a false negative for file names starting with '.\'; but nobody should have those anyway). Otherwise, it looks good. From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 06:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 22577@debbugs.gnu.org Received: via spool by 22577-submit@debbugs.gnu.org id=B22577.145491118510684 (code B ref 22577); Mon, 08 Feb 2016 06:00:01 +0000 Received: (at 22577) by debbugs.gnu.org; 8 Feb 2016 05:59:45 +0000 Received: from localhost ([127.0.0.1]:37866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSerQ-0002mF-Se for submit@debbugs.gnu.org; Mon, 08 Feb 2016 00:59:45 -0500 Received: from relaycp02.dominioabsoluto.net ([217.116.26.74]:47065) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSerN-0002ly-Rz for 22577@debbugs.gnu.org; Mon, 08 Feb 2016 00:59:43 -0500 Received: from smtp.movistar.es (smtp09.acens.net [86.109.99.133]) by relaycp02.dominioabsoluto.net (Postfix) with ESMTP id 1D230D2293; Mon, 8 Feb 2016 06:59:34 +0100 (CET) X-CTCH-RefID: str=0001.0A0B0205.56B82EC6.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Received: from qcore (83.38.42.1) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56A37EDC01295818; Mon, 8 Feb 2016 05:59:34 +0000 From: =?UTF-8?Q?=C3=93scar?= Fuentes References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> Date: Mon, 08 Feb 2016 06:59:33 +0100 In-Reply-To: <56B81DAD.8010303@yandex.ru> (Dmitry Gutov's message of "Mon, 8 Feb 2016 06:46:37 +0200") Message-ID: <87k2mfyc6y.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > (Not a guru here.) Thanks for commenting anyways :-) >> - '(("all" . "* .*") >> + '(("all" . "* .[^\\.]*") > > I think you don't even need the escape (and it would create a false > negative for file names starting with '.\'; but nobody should have > those anyway). Otherwise, it looks good. It seems that the escape is not required, although every example I saw on the Internets uses it (one copying the another, I guess.) What I've discovered while investigating your commentary is that the [^.] syntax is not POSIX and some shells (posh) does not admit it. The syntax required by POSIX is [!.]. I checked that .[!.]* works as expected on GNU/Linux and on Windows (MSYS2 and cmd.exe calling git and grep). It doesn't work on Eshell, but that doesn't count. On a few days I'll commit the patch using the [!.] syntax, if nobody objects to it. From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 11:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=C3=93scar?= Fuentes Cc: 22577@debbugs.gnu.org, Dmitry Gutov Received: via spool by 22577-submit@debbugs.gnu.org id=B22577.145493018518695 (code B ref 22577); Mon, 08 Feb 2016 11:17:01 +0000 Received: (at 22577) by debbugs.gnu.org; 8 Feb 2016 11:16:25 +0000 Received: from localhost ([127.0.0.1]:38050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSjnt-0004rT-F0 for submit@debbugs.gnu.org; Mon, 08 Feb 2016 06:16:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:57082) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSjnr-0004rJ-SL for 22577@debbugs.gnu.org; Mon, 08 Feb 2016 06:16:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id F2C31ACAD; Mon, 8 Feb 2016 11:16:22 +0000 (UTC) From: Andreas Schwab References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> <87k2mfyc6y.fsf@wanadoo.es> X-Yow: .. My vaseline is RUNNING... Date: Mon, 08 Feb 2016 12:16:22 +0100 In-Reply-To: <87k2mfyc6y.fsf@wanadoo.es> ("=?UTF-8?Q?=C3=93scar?= Fuentes"'s message of "Mon, 08 Feb 2016 06:59:33 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Óscar Fuentes writes: > On a few days I'll commit the patch using the [!.] syntax, if nobody > objects to it. What about file names starting with ".."? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=C3=93scar?= Fuentes Cc: 22577@debbugs.gnu.org, Dmitry Gutov Received: via spool by 22577-submit@debbugs.gnu.org id=B22577.14549545031356 (code B ref 22577); Mon, 08 Feb 2016 18:02:02 +0000 Received: (at 22577) by debbugs.gnu.org; 8 Feb 2016 18:01:43 +0000 Received: from localhost ([127.0.0.1]:60289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSq86-0000Lo-PE for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:01:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:42638) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSq85-0000Lg-9t for 22577@debbugs.gnu.org; Mon, 08 Feb 2016 13:01:41 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C69B1AB02; Mon, 8 Feb 2016 16:28:16 +0000 (UTC) From: Andreas Schwab References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> <87k2mfyc6y.fsf@wanadoo.es> <878u2vxjcb.fsf@wanadoo.es> X-Yow: Does that mean I'm not a well-adjusted person?? Date: Mon, 08 Feb 2016 17:28:16 +0100 In-Reply-To: <878u2vxjcb.fsf@wanadoo.es> ("=?UTF-8?Q?=C3=93scar?= Fuentes"'s message of "Mon, 08 Feb 2016 17:22:44 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Óscar Fuentes writes: > This is also puzzling to me: > > oscar@qcore:~/dev/emacs/emacs$ ls .? > build dbuild old-emacs ses.patch tooltip_pos.diff > build.script emacs pmodes-tests tooltip_pos2.diff > oscar@qcore:~/dev/emacs/emacs$ ls ? > ls: cannot access ?: No such file or directory A leading dot is never matched by wildcards, but other dots are not special. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 18:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: 22577@debbugs.gnu.org, Dmitry Gutov Received: via spool by 22577-submit@debbugs.gnu.org id=B22577.14549549282005 (code B ref 22577); Mon, 08 Feb 2016 18:09:02 +0000 Received: (at 22577) by debbugs.gnu.org; 8 Feb 2016 18:08:48 +0000 Received: from localhost ([127.0.0.1]:60299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqEy-0000WH-N3 for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:08:48 -0500 Received: from smtp21.acens.net ([86.109.99.145]:23704 helo=smtp.movistar.es) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqEw-0000W2-Hc for 22577@debbugs.gnu.org; Mon, 08 Feb 2016 13:08:47 -0500 X-CTCH-RefID: str=0001.0A0B0203.56B8C0D5.00F2, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Received: from qcore (83.38.42.1) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56B309D3004DE03E; Mon, 8 Feb 2016 16:22:45 +0000 From: =?UTF-8?Q?=C3=93scar?= Fuentes References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> <87k2mfyc6y.fsf@wanadoo.es> Date: Mon, 08 Feb 2016 17:22:44 +0100 In-Reply-To: (Andreas Schwab's message of "Mon, 08 Feb 2016 12:16:22 +0100") Message-ID: <878u2vxjcb.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Andreas Schwab writes: > What about file names starting with ".."? Is there a way to accept them while rejecting the parent directory? If not, I opt for ignoring those rather than having commands that fail when used with the default parameters suggested by Emacs. We could add "..?*" but that doesn't match directories: oscar@qcore:~/dev/emacs/emacs$ ls ..?* ls: cannot access ..?*: No such file or directory oscar@qcore:~/dev/emacs/emacs$ mkdir ..foo oscar@qcore:~/dev/emacs/emacs$ ls ..?* oscar@qcore:~/dev/emacs/emacs$ rmdir ..foo oscar@qcore:~/dev/emacs/emacs$ touch ..foo oscar@qcore:~/dev/emacs/emacs$ ls ..?* ..foo This is also puzzling to me: oscar@qcore:~/dev/emacs/emacs$ ls .? build dbuild old-emacs ses.patch tooltip_pos.diff build.script emacs pmodes-tests tooltip_pos2.diff oscar@qcore:~/dev/emacs/emacs$ ls ? ls: cannot access ?: No such file or directory From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=C3=93scar?= Fuentes , Andreas Schwab Cc: 22577@debbugs.gnu.org Received: via spool by 22577-submit@debbugs.gnu.org id=B22577.14549552682761 (code B ref 22577); Mon, 08 Feb 2016 18:15:02 +0000 Received: (at 22577) by debbugs.gnu.org; 8 Feb 2016 18:14:28 +0000 Received: from localhost ([127.0.0.1]:60376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqKS-0000iS-HX for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:14:28 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:34404) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqKR-0000iF-4I for 22577@debbugs.gnu.org; Mon, 08 Feb 2016 13:14:27 -0500 Received: by mail-wm0-f45.google.com with SMTP id 128so166361492wmz.1 for <22577@debbugs.gnu.org>; Mon, 08 Feb 2016 10:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=w9v/MOQLU8G/yRapiDeuxFDYkYcagINuL9EpbCdHGts=; b=K+iyvCCYpakVcJ64IHkRRlw+exHGWDRnkkeqvHVD3uaKDdrqDpYm9qUvgM1B3+s1oq 8N9Q3FsCupFIXURwJxEYO+MJPqveQCVFe4HLkc6KMNYJDeRqZ0ZtHbb97d6ws38mSiLF /rYHf0OLKTep3k26pulTZrTISUz60iBH6uBCDdgckOm6Ta8dKFwY5CSIPBIdotkcjdaO mePluou4yFXUAcpz0ACUQn7EKsXxOuHW0seXRxPiOZ1uijhPBfYDfMn8aiookSf8wLPg LIhwGEghDJpa+ZNccQemEhBU6Blo1Eewnt5tk6Wvb0S8hAvSIQL905AoTKsMHS3TKq/J 1Dlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=w9v/MOQLU8G/yRapiDeuxFDYkYcagINuL9EpbCdHGts=; b=dm+xdwV10WfyrKUiFHPqMgwewByGOtsMVu8w2WosUlAL4RCqUyztiaBba8+vcn0y3a aWPHgkyIWMOLmGNWM0SV881UPSuZH4zFDbA+376wsnwYVRwYD7NCmQo2K0nwfXPf9S1p Tg1FWTCUmQbRKxTNeVIP1OOL3L/sDrhuXEuTewMf0sK41YgfDzWmm9Wax0SmJhSbLFge FBAWkISq0/cjSVSuLqFt2MRcCNzi+XHFZCMaw/iPMu9dFx8W2r9aiPHNt1A/Oq53OTV4 LR6JUYEBGkjE2jBsJTpLejp5CSNeStJsDwPlEdhK8PqMp6OacgFNU/lgdyp6GMwJQGMX Kelg== X-Gm-Message-State: AG10YORPp0LiN+4TEcZ1Eq8UOez/YaOl8RCDvoEaTBPxefCd08Q7wb7MbYVmWJE7r8HtWQ== X-Received: by 10.28.177.85 with SMTP id a82mr152156wmf.57.1454955261531; Mon, 08 Feb 2016 10:14:21 -0800 (PST) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id qs1sm30931407wjc.2.2016.02.08.10.14.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Feb 2016 10:14:20 -0800 (PST) References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> <87k2mfyc6y.fsf@wanadoo.es> <878u2vxjcb.fsf@wanadoo.es> From: Dmitry Gutov Message-ID: <56B8DAFA.7060804@yandex.ru> Date: Mon, 8 Feb 2016 20:14:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 MIME-Version: 1.0 In-Reply-To: <878u2vxjcb.fsf@wanadoo.es> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 02/08/2016 06:22 PM, Óscar Fuentes wrote: > We could add "..?*" but that doesn't match directories: I don't think grep-files-aliases are supposed to match directories anyway. From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files In-Reply-To: <878u2xyztc.fsf@telefonica.net> Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22577@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14549559984091 (code B ref -1); Mon, 08 Feb 2016 18:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Feb 2016 18:26:38 +0000 Received: from localhost ([127.0.0.1]:60406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqWD-00013u-Nx for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:26:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43544) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqII-0000b7-2Z for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:12:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSoOu-0001AQ-PR for submit@debbugs.gnu.org; Mon, 08 Feb 2016 11:10:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSoOu-0001AJ-Me for submit@debbugs.gnu.org; Mon, 08 Feb 2016 11:10:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSoOt-00030j-Px for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 11:10:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSoOp-00019a-I0 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 11:10:55 -0500 Received: from plane.gmane.org ([80.91.229.3]:49286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSoOp-00019W-0p for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 11:10:51 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aSoOh-0006ho-0l for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 17:10:43 +0100 Received: from 1.red-83-38-42.dynamicip.rima-tde.net ([83.38.42.1]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 08 Feb 2016 17:10:42 +0100 Received: from ofv by 1.red-83-38-42.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 08 Feb 2016 17:10:42 +0100 X-Injected-Via-Gmane: http://gmane.org/ From: =?UTF-8?Q?=C3=93scar?= Fuentes Date: Mon, 08 Feb 2016 17:10:36 +0100 Lines: 7 Message-ID: <87d1s7xjwj.fsf@wanadoo.es> References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> <87k2mfyc6y.fsf@wanadoo.es> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 1.red-83-38-42.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:0eDxcdvqcEQB6EIzLOLprN640KQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Andreas Schwab writes: > What about file names starting with ".."? Is there a way to accept them while rejecting the parent directory? If not, I opt for ignoring those rather than having commands that fail when used with the default parameters suggested by Emacs. From unknown Sun Jun 22 11:46:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?=C3=93scar?= Fuentes Cc: 22577@debbugs.gnu.org, Dmitry Gutov Received: via spool by 22577-submit@debbugs.gnu.org id=B22577.145495688811892 (code B ref 22577); Mon, 08 Feb 2016 18:42:02 +0000 Received: (at 22577) by debbugs.gnu.org; 8 Feb 2016 18:41:28 +0000 Received: from localhost ([127.0.0.1]:60456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqka-00035k-F0 for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:41:28 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:51049) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqkY-00035b-Ar for 22577@debbugs.gnu.org; Mon, 08 Feb 2016 13:41:26 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3pzbm473fsz3hj68; Mon, 8 Feb 2016 19:41:24 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3pzbm45H3Nzvh1y; Mon, 8 Feb 2016 19:41:24 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id 8ankJ-bBi6zQ; Mon, 8 Feb 2016 19:41:23 +0100 (CET) X-Auth-Info: aH/WzN6NBjEYHYRiLI9e49Rv+bZ9MZg8gY1IAj65sHIzrAJveDkbMLLfPhCqokP4 Received: from igel.home (ppp-88-217-23-217.dynamic.mnet-online.de [88.217.23.217]) by mail.mnet-online.de (Postfix) with ESMTPA; Mon, 8 Feb 2016 19:41:23 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 004C62C0AA6; Mon, 8 Feb 2016 19:41:22 +0100 (CET) From: Andreas Schwab References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> <87k2mfyc6y.fsf@wanadoo.es> <878u2vxjcb.fsf@wanadoo.es> X-Yow: Place me on a BUFFER counter while you BELITTLE several BELLHOPS in the Trianon Room!! Let me one of your SUBSIDIARIES! Date: Mon, 08 Feb 2016 19:41:22 +0100 In-Reply-To: <878u2vxjcb.fsf@wanadoo.es> ("=?UTF-8?Q?=C3=93scar?= Fuentes"'s message of "Mon, 08 Feb 2016 17:22:44 +0100") Message-ID: <87vb5zjb8t.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Óscar Fuentes writes: > We could add "..?*" but that doesn't match directories: Why do you think so? > oscar@qcore:~/dev/emacs/emacs$ mkdir ..foo > oscar@qcore:~/dev/emacs/emacs$ ls ..?* Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Sun Jun 22 11:46:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?=C3=93scar?= Fuentes Subject: bug#22577: closed (Re: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files) Message-ID: References: <87d1rzqpqt.fsf@wanadoo.es> <878u2xyztc.fsf@telefonica.net> X-Gnu-PR-Message: they-closed 22577 X-Gnu-PR-Package: emacs Reply-To: 22577@debbugs.gnu.org Date: Sun, 14 Feb 2016 15:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1455463502-27189-1" This is a multi-part message in MIME format... ------------=_1455463502-27189-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #22577: 25.0.50; vc-git-grep fails when searching for `all' files which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 22577@debbugs.gnu.org. --=20 22577: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22577 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1455463502-27189-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 22577-done) by debbugs.gnu.org; 14 Feb 2016 15:24:38 +0000 Received: from localhost ([127.0.0.1]:38948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUyXO-00073r-Di for submit@debbugs.gnu.org; Sun, 14 Feb 2016 10:24:38 -0500 Received: from relaycp04.dominioabsoluto.net ([217.116.26.100]:56013) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aUyXM-00073c-11 for 22577-done@debbugs.gnu.org; Sun, 14 Feb 2016 10:24:37 -0500 Received: from smtp.movistar.es (smtp22.acens.net [86.109.99.146]) by relaycp04.dominioabsoluto.net (Postfix) with ESMTP id CF22C641B8 for <22577-done@debbugs.gnu.org>; Sun, 14 Feb 2016 16:24:27 +0100 (CET) X-CTCH-RefID: str=0001.0A0B0202.56C09C2B.0148, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Received: from qcore (79.153.146.151) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56BC433400396E25 for 22577-done@debbugs.gnu.org; Sun, 14 Feb 2016 15:24:27 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: 22577-done@debbugs.gnu.org Subject: Re: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files References: <878u2xyztc.fsf@telefonica.net> <56B81DAD.8010303@yandex.ru> <87k2mfyc6y.fsf@wanadoo.es> <878u2vxjcb.fsf@wanadoo.es> Date: Sun, 14 Feb 2016 16:24:26 +0100 In-Reply-To: <878u2vxjcb.fsf@wanadoo.es> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Mon, 08 Feb 2016 17:22:44 +0100") Message-ID: <87d1rzqpqt.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22577-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed on 856cd948d1a5a016ad36721246a049d33451902f. The final pattern matches names starting with two dots too. ------------=_1455463502-27189-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Feb 2016 03:17:21 +0000 Received: from localhost ([127.0.0.1]:36228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSFqi-0003uK-Nz for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34353) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSFqg-0003u6-Ar for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSFqa-0001A8-9v for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSFqa-0001A4-6n for submit@debbugs.gnu.org; Sat, 06 Feb 2016 22:17:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSFqZ-0006Bq-7t for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 22:17:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSFqU-00019r-8G for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 22:17:11 -0500 Received: from relaycp03.dominioabsoluto.net ([217.116.26.84]:46742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSFqU-00017q-0o for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 22:17:06 -0500 Received: from smtp.movistar.es (smtp08.acens.net [86.109.99.132]) by relaycp03.dominioabsoluto.net (Postfix) with ESMTP id 2CC08BFA130 for ; Sun, 7 Feb 2016 04:17:04 +0100 (CET) X-CTCH-RefID: str=0001.0A0B0203.56B6B730.0027, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Received: from qcore (83.38.42.1) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56A8ACDF00D217A3 for bug-gnu-emacs@gnu.org; Sun, 7 Feb 2016 03:17:04 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: bug-gnu-emacs@gnu.org Subject: 25.0.50; vc-git-grep fails when searching for `all' files Date: Sun, 07 Feb 2016 04:17:03 +0100 Message-ID: <878u2xyztc.fsf@telefonica.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) emacs -Q M-x vc-dir M-x vc-git-grep Search for: foo Search for "foo" in files (default all): In directory: The command fails with -*- mode: grep; default-directory: "~/dev/emacs/emacs/" -*- Grep started at Sun Feb 7 03:54:09 git --no-pager grep -n -e VC -- * .* fatal: ..: '..' is outside repository Grep exited abnormally with code 128 at Sun Feb 7 03:54:09 The problem consists on `all' defaulting to the file patterns "* .*", as defined in the variable `grep-files-aliases'. Those patterns matches ".." (the parent directory) which is outside the git repo (when you execute vc-git-grep on the top directory of the repo.) BTW, this pattern creates unnecesary noise when used with the `grep' commands, adding to the grep output lines such as grep: .: Is a directory grep: ..: Is a directory I propose the following patch to fix this problem. Shell gurus, please review. diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index 7e6f157..3f77a2a 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -189,7 +189,7 @@ grep-find-template :group 'grep) (defcustom grep-files-aliases - '(("all" . "* .*") + '(("all" . "* .[^\\.]*") ("el" . "*.el") ("ch" . "*.[ch]") ("c" . "*.c") In GNU Emacs 25.0.50.29 (x86_64-unknown-linux-gnu, X toolkit) of 2016-01-21 built on qcore Repository revision: 5293d1bdb3e665a565af032a163004c976328cc2 Windowing system distributor 'The X.Org Foundation', version 11.0.11702000 System Description: Ubuntu 15.10 Configured using: 'configure --without-toolkit-scroll-bars --with-x-toolkit=lucid' Configured features: XAW3D XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB LUCID X11 Important settings: value of $LANG: C locale-coding-system: nil Major mode: Emacs-Lisp ------------=_1455463502-27189-1--