GNU bug report logs - #22557
25.0.90; Saving a buffer under auto-revert turns off file notifications

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 22557 <at> debbugs.gnu.org
Subject: bug#22557: 25.0.90; Saving a buffer under auto-revert turns off file notifications
Date: Fri, 05 Feb 2016 16:41:59 +0200

> From: Michael Albinus <michael.albinus <at> gmx.de>
> Cc: 22557 <at> debbugs.gnu.org
> Date: Fri, 05 Feb 2016 13:24:01 +0100
> 
> > I don't understand the logic of this: at least with w32notify, when a
> > file is in auto-revert-mode, we watch the entire parent directory of
> > that file, so there's no need to send the 'stopped' event when the
> > file is renamed or deleted, only when the parent directory is deleted.
> 
> In `auto-revert-notify-add-watch', only the file named by
> `buffer-file-name' is watched. autorevert.el does not check, what the
> underlying library of filenotify.el is able to do, watching single files
> or whole directories.

I don't think the problem is in autorevert.el.  The problem is in
filenotify.el, which is where 'stopped' is generated.  Filenotify does
know what it watches.

> And as said, a renaming of a file should not turn file notifications
> off. I will try to fix this.

Neither should deleting a file, IMO.  Otherwise you will lose during
saving, since that's what Emacs does then.

> I really hate it that we have no ChangeLog anymore, maintained by the
> developers.

Maybe we should re-introduce them.  git-merge-changelog makes merging
them all but free of problems, so perhaps we are paying a price that's
too heavy for eliminating ChangeLog.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.