From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Feb 2016 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22534@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145439425432152 (code B ref -1); Tue, 02 Feb 2016 06:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Feb 2016 06:24:14 +0000 Received: from localhost ([127.0.0.1]:55627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQUNq-0008MW-1h for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39045) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQUNo-0008MI-Rq for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQUNi-0001hK-Ar for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUNi-0001hG-7H for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUNg-0000kn-Tf for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 01:24:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQUNf-0001h3-IZ for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 01:24:04 -0500 Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:35425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUNf-0001gz-BK for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 01:24:03 -0500 Received: by mail-ob0-x236.google.com with SMTP id xk3so40849815obc.2 for ; Mon, 01 Feb 2016 22:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=ZlbK1ZDOgl8S4hIos2vQm/ErCehHCxOEuSyWqRLWdrM=; b=rVwkR9vTGY/901UfDTx52E/kFYiV+XtSefOhCyNprk66SjjZmi1SVuaUwZ1dL7vcY9 ZPcrGDZklEgNsRjOtm2B0eZ4eE2wBzsfD+6gLYkNZmCeZ1XXueKWBWI8A3kVhI8R/GV7 wXxRI3Bfut9fDwtQlFvtayIgD6estnpHZqb0ezhs3sWc7VXrWS0xfojf7d6XdOVfjlQp opwiSAkTOn/GxBtm0VFpvlTs0h7+1cuC5LueB3a7PWEhOrcK4hBOCOlMHJQcgL3emn4I giDHDL9tQjIO7n14IVt9GVthUI9GKu5cOOE4l7xbta5RB6gUOdwKz2+668CRORutiaVp Xu+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=ZlbK1ZDOgl8S4hIos2vQm/ErCehHCxOEuSyWqRLWdrM=; b=RJip99QoYGc4Owb6pdRX95XfKUkubsbruKKN3Fg2iYyJblAl+OgbCSErTjRfY/5avI Q9Nura9LYMYk8kqX10MOHN7CBA1LCkGGQn+HqTSjnYeVV0wKksE7d9XXJw8TQ+ju7w93 i3xf7u4G5O6D0nftJ1EKTYXfUQkab65M3otC2HgYUAwcwvW4JX1ssN8er+wAjRQJ62DE REj3FCn/xDlLtwdDVGTd3eHTWnr/NbqXckG/ej3wxN4dwOn6JW6LOy+2ayp+wdEHRBUb opGpvG+gdL0e6iO3XHvFVtxhFZvq9iXY0rt3n9ZsvbHSevQ1pkT/KqLwzZI8Ug24tHtL W70g== X-Gm-Message-State: AG10YOT4wVRxVEZHXqfjG+tba29ZH5N9St6JtZREDyYNK3rvte85ZtMoQ2I6lvYaxS2cEIgI1I29f+j/iyPhNQ== X-Received: by 10.60.73.170 with SMTP id m10mr22409907oev.51.1454394242830; Mon, 01 Feb 2016 22:24:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.67 with HTTP; Mon, 1 Feb 2016 22:23:43 -0800 (PST) From: Fabrice Popineau Date: Tue, 2 Feb 2016 07:23:43 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a1135fd06351845052ac38c36 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a1135fd06351845052ac38c36 Content-Type: text/plain; charset=UTF-8 When I run 'make check', the process is stuck on filenotify tests. If I try to run the tests interactively, I have to hit 'Ctrl-g'. Emacs waits forever on the first test. In GNU Emacs 25.0.90.4 (x86_64-w64-mingw32) of 2016-02-02 built on LOBSANG Repository revision: 17b39a44e9106bae6c084441a29c5ec77f36a721 Windowing system distributor 'Microsoft Corp.', version 10.0.10586 Configured using: 'configure --prefix=/c/Local/Emacs --libexecdir=/c/Local/Emacs/bin --datarootdir=/c/Local/Emacs --localstatedir=/c/Local/Emacs --sysconfdir=/c/Local/Emacs/etc --with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2 --with-gnutls --without-imagemagick --enable-checking=no 'CFLAGS=-I/mingw64/include -fomit-frame-pointer -O3 -g0 -mtune=corei7' CPPFLAGS=-I/mingw64/include LDFLAGS=-L/mingw64/lib' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS Important settings: value of $LANG: fr_FR locale-coding-system: cp1252 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify dbusbind w32 multi-tty make-network-process emacs) Memory information: ((conses 16 88664 8174) (symbols 56 19615 0) (miscs 48 37 84) (strings 32 15795 4324) (string-bytes 1 424760) (vectors 16 11609) (vector-slots 8 411396 4797) (floats 8 161 40) (intervals 56 256 6) (buffers 976 12)) --001a1135fd06351845052ac38c36 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

When I run 'make check', the p= rocess is stuck on filenotify tests.
If I try to run the tests in= teractively, I have to hit 'Ctrl-g'.
Emacs waits forever = on the first test.



I= n GNU Emacs 25.0.90.4 (x86_64-w64-mingw32)
=C2=A0of 2016-02-02 bu= ilt on LOBSANG
Repository revision: 17b39a44e9106bae6c084441a29c5= ec77f36a721
Windowing system distributor 'Microsoft Corp.'= ;, version 10.0.10586
Configured using:
=C2=A0'conf= igure --prefix=3D/c/Local/Emacs --libexecdir=3D/c/Local/Emacs/bin
=C2=A0--datarootdir=3D/c/Local/Emacs --localstatedir=3D/c/Local/Emacs
=C2=A0--sysconfdir=3D/c/Local/Emacs/etc --with-jpeg --with-xpm --with= -png
=C2=A0--with-tiff --with-rsvg --with-xml2 --with-gnutls --wi= thout-imagemagick
=C2=A0--enable-checking=3Dno 'CFLAGS=3D-I/m= ingw64/include -fomit-frame-pointer
=C2=A0-O3 -g0 -mtune=3Dcorei7= ' CPPFLAGS=3D-I/mingw64/include
=C2=A0LDFLAGS=3D-L/mingw64/li= b'

Configured features:
XPM JPEG TIF= F GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_= SCROLL_BARS

Important settings:
=C2=A0 v= alue of $LANG: fr_FR
=C2=A0 locale-coding-system: cp1252

Major mode: Lisp Interaction

Mino= r modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 global= -eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mo= use-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-b= ar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 globa= l-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 bli= nk-cursor-mode: t
=C2=A0 auto-composition-mode: t
=C2= =A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t
=
=C2=A0 line-number-mode: t
=C2=A0 transient-mark-mode: t

Recent messages:
For information about GNU = Emacs and the GNU system, type C-h C-a.
Making completion list...=

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug messag= e dired format-spec rfc822 mml
mml-sec epg epg-config gnus-util m= m-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-ut= ils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-f= ns help-mode easymenu cl-loaddefs pcase
cl-lib mail-prsvr mail-ut= ils time-date mule-util tooltip eldoc electric
uniquify ediff-hoo= k vc-hooks lisp-float-type mwheel dos-w32 ls-lisp
disp-table w32-= win w32-vars term/common-win tool-bar dnd fontset image
regexp-op= t fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode= register page menu-bar rfn-eshadow timer select scroll-bar
mouse= jit-lock font-lock syntax facemenu font-core frame cl-generic cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao=
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa= -hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded na= dvice
loaddefs button faces cus-face macroexp files text-properti= es overlay
sha1 md5 base64 format env code-pages mule custom widg= et
hashtable-print-readable backquote w32notify dbusbind w32 mult= i-tty
make-network-process emacs)

Memory= information:
((conses 16 88664 8174)
=C2=A0(symbols 56= 19615 0)
=C2=A0(miscs 48 37 84)
=C2=A0(strings 32 1579= 5 4324)
=C2=A0(string-bytes 1 424760)
=C2=A0(vectors 16= 11609)
=C2=A0(vector-slots 8 411396 4797)
=C2=A0(float= s 8 161 40)
=C2=A0(intervals 56 256 6)
=C2=A0(buffers 9= 76 12))

--001a1135fd06351845052ac38c36-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Feb 2016 16:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145442978612689 (code B ref 22534); Tue, 02 Feb 2016 16:17:01 +0000 Received: (at 22534) by debbugs.gnu.org; 2 Feb 2016 16:16:26 +0000 Received: from localhost ([127.0.0.1]:56992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQdcw-0003Ia-2d for submit@debbugs.gnu.org; Tue, 02 Feb 2016 11:16:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34356) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQdcu-0003IM-J4 for 22534@debbugs.gnu.org; Tue, 02 Feb 2016 11:16:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQdcj-0005tY-UM for 22534@debbugs.gnu.org; Tue, 02 Feb 2016 11:16:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQdcj-0005tU-Rt; Tue, 02 Feb 2016 11:16:13 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1998 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aQdcj-0003ZQ-8K; Tue, 02 Feb 2016 11:16:13 -0500 Date: Tue, 02 Feb 2016 18:15:53 +0200 Message-Id: <83h9hrytom.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Tue, 2 Feb 2016 07:23:43 +0100) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.5 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) > From: Fabrice Popineau > Date: Tue, 2 Feb 2016 07:23:43 +0100 > > When I run 'make check', the process is stuck on filenotify tests. > If I try to run the tests interactively, I have to hit 'Ctrl-g'. > Emacs waits forever on the first test. Can you bisect to find the commit which broke this? Thanks. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Feb 2016 23:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.1454456209539 (code B ref 22534); Tue, 02 Feb 2016 23:37:02 +0000 Received: (at 22534) by debbugs.gnu.org; 2 Feb 2016 23:36:49 +0000 Received: from localhost ([127.0.0.1]:57250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQkV7-00008d-1W for submit@debbugs.gnu.org; Tue, 02 Feb 2016 18:36:49 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:34509) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQkV5-00008Q-BW for 22534@debbugs.gnu.org; Tue, 02 Feb 2016 18:36:47 -0500 Received: by mail-ob0-f177.google.com with SMTP id wb13so6413980obb.1 for <22534@debbugs.gnu.org>; Tue, 02 Feb 2016 15:36:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=2aOHGVKHq3L8ZGY0vkaNPIh/S4Xsb6xZjK+rAnqzzJQ=; b=wfb+s3zEUqUMeAYff60Cg0O3JxBJ1U8omEKNIVr63EpENRze9jh0QC0YA0ma+au4s2 8n6jXGkdL76KhrHYJsgoRKfC2EVmPXmTFhJdQGy8oSldsibsV2TRhJfEGpqq1f+ZuV5O CyC9uZQvUhXnV1svgwRj6D7ogGOgH4hoPZrIpwzHElN7nIjHN/DkiPUANFAwhPu2xu6I gVNotrQOAQwNS+chDdKPw0v2eRlBoa+cc38aORryAlM8iZGrp4lTR7Z8pf1NCjOQ125c L/0T/N48x3oyChSeLi2hk6kw9eTjcf8ft3mbLTqEVNcA2Yi0CPGUvtcf/sGOKmmAEXA4 QKIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=2aOHGVKHq3L8ZGY0vkaNPIh/S4Xsb6xZjK+rAnqzzJQ=; b=Z9uZm9bY06/D+j9y1RilNHYIH2qZxGHpXmJ5z2jsRfc/oqaTbrh5YxmtUCQegOb/ia elNPf+vxt3YjVlm43aH7TWctB3jXSRZBRxRmOn6K8E0tN50EOpRsn+3RgWQ49WiNmbWb FaXGkHmZNp9Qeaor5VQ5TyD638IlWDcP3tSK3mI9C27GCI+OsROYVdrmA1In3IjHeXGU nMrHBzeUb+lIwoLBTXH6eRp+adR3KZUJS6r66iz79mt85cY2Ct+j0blLMkG6JEhuF8lL C9BKBjIBTFVW/MevwCrMBwWcUDKSuf0r4MAz4MyLJ9CYscvTTJT+ZMOaf350JHSC9by0 lVIA== X-Gm-Message-State: AG10YOQ2gYJluxFS8h6p5cYB0GxioA72IJTMtcSLrGV29AU0+MC0Hno6WW51ETaka8jlqbOriKyWZoj6CbgJ1Q== X-Received: by 10.182.153.10 with SMTP id vc10mr2201101obb.10.1454456201807; Tue, 02 Feb 2016 15:36:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.67 with HTTP; Tue, 2 Feb 2016 15:36:22 -0800 (PST) In-Reply-To: <83h9hrytom.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> From: Fabrice Popineau Date: Wed, 3 Feb 2016 00:36:22 +0100 Message-ID: Content-Type: multipart/alternative; boundary=089e013a0996400e00052ad1f916 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e013a0996400e00052ad1f916 Content-Type: text/plain; charset=UTF-8 You will find the commit below (with not too much surprise). However, I don't have much time these days to sort this out. Fabrice $ git bisect good 7bf54d01159eb09bae3c9cd86f2af0812d9afdf6 is the first bad commit commit 7bf54d01159eb09bae3c9cd86f2af0812d9afdf6 Author: Michael Albinus Date: Fri Jan 22 19:56:09 2016 +0100 Backport kqueue integration from master * configure.ac (--with-file-notification): Add kqueue. (top): Remove special test for "${HAVE_NS}" and ${with_file_notification}, this is handled inside gfilenotify tests. Add kqueue tests. Use NOTIFY_CFLAGS and NOTIFY_LIBS instead of library specific variables. Add error message for gfile on Nextstep. * doc/lispref/os.texi (File Notifications): Add kqueue as backend. Fix some glitches in the example. * etc/NEWS: Mention kqueue. * lisp/filenotify.el (file-notify--library) (file-notify-descriptors, file-notify-callback) (file-notify-add-watch, file-notify-rm-watch) (file-notify-valid-p): Add kqueue support. (file-notify--rm-descriptor): Remove WHAT arg. * src/Makefile.in: Use NOTIFY_CFLAGS and NOTIFY_LIBS. * src/emacs.c (main): Call globals_of_kqueue and syms_of_kqueue. * src/inotify.c (inotifyevent_to_event): Extract file name from watch_object if the event doesn't provide it. (Finotify_add_watch): Add file name to watch_object. * src/keyboard.c (make_lispy_event): Check also for HAVE_KQUEUE. * src/kqueue.c: New file. * src/lisp.h: Declare extern globals_of_kqueue and syms_of_kqueue. * test/automated/file-notify-tests.el (file-notify--test-expected-events): Remove. (file-notify--test-cleanup): Do not set that variable. (file-notify--test-timeout) Use different timeouts for different libraries. (file-notify--test-library): New defun. (file-notify--test-event-test): Make stronger checks. (file-notify--test-with-events): EVENTS can also be a list of lists. Flush outstanding events before running the body. Make timeout heuristically depend on the number of events. (file-notify-test01-add-watch, file-notify-test02-events) (file-notify-test04-file-validity, file-notify-test05-dir-validity): Rewrite in order to call file monitors but directory monitors. (file-notify-test02-events, file-notify-test04-file-validity): Do not skip cygwin tests. Add additional test for file creation. Adapt expected result for different backends. (file-notify-test03-autorevert): Some of the tests don't work for w32notify. (file-notify-test06-many-events): New test. :100644 100644 b5e6b77c713ca7fa82c7c23652170dff3c5adfd5 76193fae6dd61d4448b3a304d3a0e4978afb810e M configure.ac :040000 040000 6b5e2cfa75a456e6f4d43e183976d6e8ece21462 41f9bd9c7893cbdccf22e97d7ddc3500c4443d5c M doc :040000 040000 98523d83bfa75e0401f7a1049548c4f94ddb6b0d 4a87e49af135328911e0b31099f0e9d0f4f13aaf M etc :040000 040000 96c8883a122a08fe59a772611eff59a8330a37c1 8e04830234a1d3e8af4fd37ceb3eb9c4503718c3 M lisp :040000 040000 ebdfee938f44d5d2818a29bd07f795521a3583ee 53a01fd613d99e20cb563ab8418ec2776c146f09 M src :040000 040000 9d27cfce0b9d77d43b2180ecd95451469309da92 71329cdc731a284e563265a90876cbf8ea94305b M test 2016-02-02 17:15 GMT+01:00 Eli Zaretskii : > > From: Fabrice Popineau > > Date: Tue, 2 Feb 2016 07:23:43 +0100 > > > > When I run 'make check', the process is stuck on filenotify tests. > > If I try to run the tests interactively, I have to hit 'Ctrl-g'. > > Emacs waits forever on the first test. > > Can you bisect to find the commit which broke this? > > Thanks. > --089e013a0996400e00052ad1f916 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
You will find the commit below (with not too much surprise= ).
However, I don't have much time these days to sort this out.

Fabrice

$ git bisect good=
7bf54d01159eb09bae3c9cd86f2af0812d9afdf6 is the first bad commit=
commit 7bf54d01159eb09bae3c9cd86f2af0812d9afdf6
Author= : Michael Albinus <michael.alb= inus@gmx.de>
Date: =C2=A0 Fri Jan 22 19:56:09 2016 +0100

=C2=A0 =C2=A0 Backport kqueue integration from mast= er

=C2=A0 =C2=A0 * configure.ac (--with-file-notification): Add kqueue.
=C2=A0 = =C2=A0 (top): Remove special test for "${HAVE_NS}" and
= =C2=A0 =C2=A0 ${with_file_notification}, this is handled inside gfilenotify=
=C2=A0 =C2=A0 tests.=C2=A0 Add kqueue tests.=C2=A0 Use NOTIFY_CF= LAGS and NOTIFY_LIBS
=C2=A0 =C2=A0 instead of library specific va= riables.=C2=A0 Add error message for
=C2=A0 =C2=A0 gfile on Nexts= tep.

=C2=A0 =C2=A0 * doc/lispref/os.texi (File Not= ifications): Add kqueue as backend.
=C2=A0 =C2=A0 Fix some glitch= es in the example.

=C2=A0 =C2=A0 * etc/NEWS: Menti= on kqueue.

=C2=A0 =C2=A0 * lisp/filenotify.el (fil= e-notify--library)
=C2=A0 =C2=A0 (file-notify-descriptors, file-n= otify-callback)
=C2=A0 =C2=A0 (file-notify-add-watch, file-notify= -rm-watch)
=C2=A0 =C2=A0 (file-notify-valid-p): Add kqueue suppor= t.
=C2=A0 =C2=A0 (file-notify--rm-descriptor): Remove WHAT arg.

=C2=A0 =C2=A0 * src/Makefile.in: Use NOTIFY_CFLAGS = and NOTIFY_LIBS.

=C2=A0 =C2=A0 * src/emacs.c (main= ): Call globals_of_kqueue and syms_of_kqueue.

=C2= =A0 =C2=A0 * src/inotify.c (inotifyevent_to_event): Extract file name from<= /div>
=C2=A0 =C2=A0 watch_object if the event doesn't provide it.
=C2=A0 =C2=A0 (Finotify_add_watch): Add file name to watch_object.=

=C2=A0 =C2=A0 * src/keyboard.c (make_lispy_event)= : Check also for HAVE_KQUEUE.

=C2=A0 =C2=A0 * src/= kqueue.c: New file.

=C2=A0 =C2=A0 * src/lisp.h: De= clare extern globals_of_kqueue and syms_of_kqueue.

=C2=A0 =C2=A0 * test/automated/file-notify-tests.el
=C2=A0 =C2= =A0 (file-notify--test-expected-events): Remove.
=C2=A0 =C2=A0 (f= ile-notify--test-cleanup): Do not set that variable.
=C2=A0 =C2= =A0 (file-notify--test-timeout) Use different timeouts for
=C2=A0= =C2=A0 different libraries.
=C2=A0 =C2=A0 (file-notify--test-lib= rary): New defun.
=C2=A0 =C2=A0 (file-notify--test-event-test): M= ake stronger checks.
=C2=A0 =C2=A0 (file-notify--test-with-events= ): EVENTS can also be a list of
=C2=A0 =C2=A0 lists.=C2=A0 Flush = outstanding events before running the body.
=C2=A0 =C2=A0 Make ti= meout heuristically depend on the number of events.
=C2=A0 =C2=A0= (file-notify-test01-add-watch, file-notify-test02-events)
=C2=A0= =C2=A0 (file-notify-test04-file-validity, file-notify-test05-dir-validity)= :
=C2=A0 =C2=A0 Rewrite in order to call file monitors but direct= ory monitors.
=C2=A0 =C2=A0 (file-notify-test02-events, file-noti= fy-test04-file-validity): Do
=C2=A0 =C2=A0 not skip cygwin tests.= =C2=A0 Add additional test for file creation.
=C2=A0 =C2=A0 Adapt= expected result for different backends.
=C2=A0 =C2=A0 (file-noti= fy-test03-autorevert): Some of the tests don't work for
=C2= =A0 =C2=A0 w32notify.
=C2=A0 =C2=A0 (file-notify-test06-many-even= ts): New test.

:100644 100644 b5e6b77c713ca7fa82c7= c23652170dff3c5adfd5 76193fae6dd61d4448b3a304d3a0e4978afb810e M =C2=A0 =C2= =A0 =C2=A0configure.ac
:04000= 0 040000 6b5e2cfa75a456e6f4d43e183976d6e8ece21462 41f9bd9c7893cbdccf22e97d7= ddc3500c4443d5c M =C2=A0 =C2=A0 =C2=A0doc
:040000 040000 98523d83= bfa75e0401f7a1049548c4f94ddb6b0d 4a87e49af135328911e0b31099f0e9d0f4f13aaf M= =C2=A0 =C2=A0 =C2=A0etc
:040000 040000 96c8883a122a08fe59a772611= eff59a8330a37c1 8e04830234a1d3e8af4fd37ceb3eb9c4503718c3 M =C2=A0 =C2=A0 = =C2=A0lisp
:040000 040000 ebdfee938f44d5d2818a29bd07f795521a3583e= e 53a01fd613d99e20cb563ab8418ec2776c146f09 M =C2=A0 =C2=A0 =C2=A0src
<= div>:040000 040000 9d27cfce0b9d77d43b2180ecd95451469309da92 71329cdc731a284= e563265a90876cbf8ea94305b M =C2=A0 =C2=A0 =C2=A0test


2= 016-02-02 17:15 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Tue, 2 Feb 2016 07:23:43 +0100
>
> When I run 'make check', the process is stuck on filenotify te= sts.
> If I try to run the tests interactively, I have to hit 'Ctrl-g'= ;.
> Emacs waits forever on the first test.

Can you bisect to find the commit which broke this?

Thanks.

--089e013a0996400e00052ad1f916-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Feb 2016 08:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145448684526933 (code B ref 22534); Wed, 03 Feb 2016 08:08:02 +0000 Received: (at 22534) by debbugs.gnu.org; 3 Feb 2016 08:07:25 +0000 Received: from localhost ([127.0.0.1]:57432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQsTF-00070L-1g for submit@debbugs.gnu.org; Wed, 03 Feb 2016 03:07:25 -0500 Received: from mout.gmx.net ([212.227.15.18]:60719) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQsTD-000707-Mf for 22534@debbugs.gnu.org; Wed, 03 Feb 2016 03:07:24 -0500 Received: from detlef.gmx.de ([79.195.22.217]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LhOO8-1ZeIA11V9E-00ma7i; Wed, 03 Feb 2016 09:07:17 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> Date: Wed, 03 Feb 2016 09:07:15 +0100 In-Reply-To: (Fabrice Popineau's message of "Wed, 3 Feb 2016 00:36:22 +0100") Message-ID: <87lh72xln0.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:+o/KrXiRUV7+QVZQw2jSF8nYZAMchQEy3uvYi8s77GXjwF3tguN /ttCMJNqk/a4yr1/18HoFnQ8p0G3UY7Epwg9dqYbTEIsBDXc47xcXZfWIqVEnyGCjM7puPd ClYIY+WX8/qNMewMzivalnW4f4F6YB89mFnvbZ5qVNyHlh8dppQoK4PEmebmnAgFCWvOuYF yUIWECiyI6lkR3Mob8kQw== X-UI-Out-Filterresults: notjunk:1;V01:K0:x4eYVtW0pHs=:vFAxcso7HlLrlcOM+0ZPuA IWjWR5qm/1fWhj85162SFH7Jgs0Af/+a7iPx5M948jh5gbyspi/Cbwk7FGVX2B5BMjx+Aq2v9 G3dFvQjY9zaCoizNpL171ymVi6cH1Ea5pl6LyQpPpvpCIImJoXbMd/5rgP6yLzaZ+IAa1jnog IkekmjfRAdtCQLoVWjqvop+OX88J2aQurPL3+LhyFxc/G+WVTqBb8v+PVjQJ8DjTDPvbyFP2I /MlMBxYp/OYYhOd8pQ+dvqi3o66XME+TJKjp9LUQr/HEZtJeZFtEU6u6UaBaoZztOd15IUfFT 091PAucBuc2kShoa/GLFusOR45yZR1IOBg+72kuCXtKzcFvmL7JJ9XcwopprLmgt4LFgDn3C3 24g9Tz5CFwZ1FtjugZ9hG6JYjNvb+GnPBxGV4DnwiaeH/3MBmFCbyzTl1d6sDbG9qwZLAs63j +lPlySpxgkX3uyUcv+ZwrMU9/vjwWjMjckaU/3ql35jf69OW42F+ettY6dcqTz4f0hccrU5ip iE0ccDlg4NHTZ5s2jvqQIPUU96tVHCU+tY69q+NT5qkgYaPS1RkHi1NiSeU1zw0kIHgiJ+Uly eADQsJW88Wf+JfP2GgAFnEHWmOaZPe7FZ+PfHayeROXH3fnZ221fRdi78w8DT6zPxHTvM2VAY +joYasP0iw7h1ROJhrCABeqcuMJwinlZ1N9J7aoe/I8vlJwlAh9aoQ1d6sP1PxSnMJcX9qFDl Mn2tpQ6jTXzCOwDlLt/Ed/0MykwfqcYIfiT6UFdepeIqSZHpTt6s/2MXJiueok0S6WfPgLJiF GbvLF6R X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fabrice Popineau writes: > You will find the commit below (with not too much surprise). > However, I don't have much time these days to sort this out. I'll check next days, need to find an MS Windows machine first. > Fabrice Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Feb 2016 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145450177617368 (code B ref 22534); Wed, 03 Feb 2016 12:17:01 +0000 Received: (at 22534) by debbugs.gnu.org; 3 Feb 2016 12:16:16 +0000 Received: from localhost ([127.0.0.1]:57512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQwM4-0004W4-DL for submit@debbugs.gnu.org; Wed, 03 Feb 2016 07:16:16 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:33045) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQwM1-0004Vn-QA for 22534@debbugs.gnu.org; Wed, 03 Feb 2016 07:16:14 -0500 Received: by mail-ob0-f171.google.com with SMTP id is5so26727138obc.0 for <22534@debbugs.gnu.org>; Wed, 03 Feb 2016 04:16:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=6kwrZHJ2KL064DS9u3ZZ3jNAk8m95DVPmonG/3u67HI=; b=JE81cLznt4Dh7jh47L0m0ZYoMb85PG8gZdU3N8bh7KYrRK+TeJmG3oVnAkmWKriRja /v3vE08rLYwoQ4zw7+pMjYxzmXLy3M6kP5j63WYy5mDMIjgnFJKDdbT0i0PlUApm28zQ KSNYutqI015dXLyliHaEq/zg+D8mBaTdTzgoxVmwdUT1nXBB/SfUXAdVValsVVfmbG+Z upvFZgrXYSioHvtCb6zl2WyWhAn8e4qMPS/la8gokaucX94+0A/S9U4HcqUGdt9qhYi4 1eyy3Vw51g5TqRNWITdgWWXZNwNWvl797Vk8SLX0RnQyA6gznRRbRngmKrTCfweByt5u q7hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=6kwrZHJ2KL064DS9u3ZZ3jNAk8m95DVPmonG/3u67HI=; b=OUKGNfG4L2Fqp7H6OUd6hB59NlnOmxyKBReQKwQ1s3YUdvRApYUF5BqjPluUZIMln6 tLTQPuXB5gENUld00WU4Es/JqV9/G+uRoj83SRMaT8mHeqnmDPQ/VHqdYcHCmflizrhL cme8pY41Zynx9JEdMjvzp1gumrUCDJ8VIf/3RUAHI2uhyZKe1RsThZlVB4K2NL8PcUEf jxPJOCkzBa2dff9tjzbBy/bAtQ9icJ4BUvapsrDwRjrC4cVXFyRNqj2oNvotA4H4eO2w 5bYcvU+m+qTni3N0lbewA21hkOFRafnq9dOTlsd2UnS//Q32gI4xf7vUtGQS4pgsYFUw qUaA== X-Gm-Message-State: AG10YOQKk41X04BMaZmSWTcIrNqg/MhOqo0teiHSgZRFUnG4o83jRnHKduRqnqyNDEoT4Sbg4og+IMNJkSBnjg== X-Received: by 10.182.153.10 with SMTP id vc10mr1455085obb.10.1454501767695; Wed, 03 Feb 2016 04:16:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.67 with HTTP; Wed, 3 Feb 2016 04:15:48 -0800 (PST) In-Reply-To: <87lh72xln0.fsf@gmx.de> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> From: Fabrice Popineau Date: Wed, 3 Feb 2016 13:15:48 +0100 Message-ID: Content-Type: multipart/alternative; boundary=089e013a09963079ce052adc9528 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e013a09963079ce052adc9528 Content-Type: text/plain; charset=UTF-8 2016-02-03 9:07 GMT+01:00 Michael Albinus : > Fabrice Popineau writes: > > > You will find the commit below (with not too much surprise). > > However, I don't have much time these days to sort this out. > > I'll check next days, need to find an MS Windows machine first. > > Thanks Michael. I have observed something weird during the file-notify tests. I traced file-notify-test02-events. The read_event function doesn't time out in 0.1s as it is supposed to. It waits for the time specified by (file-notify--test-timeout) before returning the right value. (Well actually, the value returned by the third test in file-notify-test02-events is wrong but it is another story). So I'm afraid some logic is wrong, and possibly not only in file-notify but also in the way w32 should handle those timeouts. Fabrice --089e013a09963079ce052adc9528 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-03 9:07 GMT+01:00 Michael Albinus <michael.albinus@gmx.de= >:
Fabrice Popineau <= fabrice.popineau@gmail.com> writes:

> You will find the commit below (with not too much surprise).
> However, I don't have much time these days to sort this out.

I'll check next days, need to find an MS Windows machine first.<= br>


I have observed something weird during the file-notify tests.
--089e013a09963079ce052adc9528-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 09:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145457940928006 (code B ref 22534); Thu, 04 Feb 2016 09:51:01 +0000 Received: (at 22534) by debbugs.gnu.org; 4 Feb 2016 09:50:09 +0000 Received: from localhost ([127.0.0.1]:58933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRGYC-0007He-Nb for submit@debbugs.gnu.org; Thu, 04 Feb 2016 04:50:09 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:33560) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRGYB-0007HR-Px for 22534@debbugs.gnu.org; Thu, 04 Feb 2016 04:50:08 -0500 Received: by mail-oi0-f45.google.com with SMTP id j125so12088977oih.0 for <22534@debbugs.gnu.org>; Thu, 04 Feb 2016 01:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=fVqumR/EA9/X/Z0UmmvanUhHMvrAKhbP0BWRmB6WHq4=; b=ZK10FjDWKtzKHqdqwoprQGfpWiwdVpkwI0JdEE6bqQPt6MRNze0HRPTqhLyBBWIXVA OzSCkHfRt1zc8H8aRylzRzx4GGiSibcDY8bvI/dT947xyG9RfqMNQl7jmAJ6p4BleLZ0 tK32j4Fs9cGNLOLQGqIek79sr7JMvH1MT2hbI8P23ywuYKp0mTe1IZjDvYx5FMeAIQT5 v8FoiJSLDG3XXGcB9L5ZMC+QMwX/FLTrANUwOvPHbA/XjDyvkq7AmY6sJyIJKa6VttyD ZTZXe2ifF/BugMIV67I4tEJAmq7RUrK/p7a5rSjnJ6wsKJXTzvWoo3odWlACuT9lv4uL 8HpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=fVqumR/EA9/X/Z0UmmvanUhHMvrAKhbP0BWRmB6WHq4=; b=QX0jp5SIh9QD4gfZOAHgzdDJBYnhv13s/11rX9KfbOFvEMWz7unny2xx4bZoLuS5A0 bUDOIxduiTNP0AbddZV/axAZ+OMXQCWS38/VUC9c5XRJOVPlWER5ZI5aUMfZl+uk7/PV 6kowyYH4Fk7KCJbIZ1e77/G1FEvJU6MS9hYby+dsQtE6Bqkrf2vDZKr7k4S5DlIYEHil 9Rc3xIsS3viobGdBDQSwOYwxL7Fyia8l/CxMaDcKi9opajhaXoLfWmoEr8sh9brhg1jN eFLkX3zaqo4E8mKsn/Cc5vQ37t21KwOvK7DiwjqlgBNQD2sggNUNrX0Za/3ib54dbdM/ tFdA== X-Gm-Message-State: AG10YOQJB7N8S47oVu5Q6XMCNg2pUW9d19ZyIBFButJzV4HIhVmyXgTn3xXdRB4SxbVki4xeqQkmUzd3WzbPZw== X-Received: by 10.202.50.139 with SMTP id y133mr2700403oiy.19.1454579401962; Thu, 04 Feb 2016 01:50:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.67 with HTTP; Thu, 4 Feb 2016 01:49:42 -0800 (PST) In-Reply-To: References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> From: Fabrice Popineau Date: Thu, 4 Feb 2016 10:49:42 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a113cf21e8d3a2b052aeea8f0 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113cf21e8d3a2b052aeea8f0 Content-Type: text/plain; charset=UTF-8 A couple of my findings : - notifications returned are not the same whether you run the tests in batch mode or interactive mode. In interactive mode, there is a deleted notification which is sent when your remove the directory being watched. This event is not seen when running in batch mode (make check). I wonder what could make a difference. - in the test file-notify-test06-many-events to check that events are not dropped : I have to lower the 1000 number. The test fails as soon as I go higher than around 260. Is there some limit here ? Once the limit is reached, only the first notification is returned. - there is this small patch that needs to be applied : diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index de64f50..51a898e 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -507,7 +509,7 @@ file-notify--test-with-events ;; w32notify does not distinguish between `changed' and ;; `attribute-changed'. ((string-equal (file-notify--test-library) "w32notify") - '(changed changed changed changed)) + '(changed changed)) ;; For kqueue and in the remote case, `write-region' ;; raises also an `attribute-changed' event. ((or (string-equal (file-notify--test-library) "kqueue") Overall, I don't think anymore that the patch by Michael has broken w32 file notifications but rather that the new tests have highlighted some potential problems with it. Regards, Fabrice 2016-02-03 13:15 GMT+01:00 Fabrice Popineau : > > > 2016-02-03 9:07 GMT+01:00 Michael Albinus : > >> Fabrice Popineau writes: >> >> > You will find the commit below (with not too much surprise). >> > However, I don't have much time these days to sort this out. >> >> I'll check next days, need to find an MS Windows machine first. >> >> > Thanks Michael. > > I have observed something weird during the file-notify tests. > I traced file-notify-test02-events. > The read_event function doesn't time out in 0.1s as it is supposed to. > It waits for the time specified by (file-notify--test-timeout) before > returning the right value. (Well actually, the value returned by the third > test > in file-notify-test02-events is wrong but it is another story). > > So I'm afraid some logic is wrong, and possibly not only in file-notify > but also in the way w32 should handle those timeouts. > > Fabrice > > --001a113cf21e8d3a2b052aeea8f0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
A couple of my findings :

- notificatio= ns returned are not the same whether you run the tests in batch mode or int= eractive mode.
=C2=A0 In interactive mode, there is a deleted not= ification which is sent when your remove the directory being watched.
=
=C2=A0 This event is not seen when running in batch mode (make check).= I wonder what could make a difference.
- in the test file-notify= -test06-many-events to check that events are not dropped : I have to lower = the 1000 number.
=C2=A0 The test fails as soon as I go higher tha= n around 260. Is there some limit here ? Once the limit is reached, only=C2= =A0
=C2=A0 the first notification is returned.
- there = is this small patch that needs to be applied :

diff --git a/test/automated/file-notify-tests.el b/test/automated/file-no= tify-tests.el
index de64f50..51a898e 100644
--- a/test/= automated/file-notify-tests.el
+++ b/test/automated/file-notify-t= ests.el
@@ -507,7 +509,7 @@ file-notify--test-with-events
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; w32notify = does not distinguish between `changed' and
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; `attribute-changed'.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0((string-equal (fil= e-notify--test-library) "w32notify")
- =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(changed changed changed changed))<= /div>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(changed = changed))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= ;; For kqueue and in the remote case, `write-region'
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; raises also an `attribut= e-changed' event.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0((or (string-equal (file-notify--test-library) "kqueue&qu= ot;)

Overall, I don't think anymore that= the patch by Michael has broken w32 file notifications
but rathe= r that the new tests have highlighted some potential problems with it.

Regards,

Fabrice

201= 6-02-03 13:15 GMT+01:00 Fabrice Popineau <fabrice.popineau@gmail.= com>:

=

= 2016-02-03 9:07 GMT+01:00 Michael Albinus <michael.albinus@gmx.de= >:
Fabrice Popineau <fabrice.popineau@gmail.com= > writes:

> You will find the commit below (with not too much surprise).
> However, I don't have much time these days to sort this out.

I'll check next days, need to find an MS Windows machine first.<= br>

Thanks Michael.

<= /div>
I have observed something weird during the file-notify tests.
I traced file-notify-test02-events.
The read_event functio= n doesn't time out in 0.1s as it is supposed to.
It waits for= the time specified =C2=A0by (file-notify--test-timeout) before
r= eturning the right value. (Well actually, the value returned by the third t= est
in file-notify-test02-events is wrong but it is another story= ).

So I'm afraid some logic is wrong, and poss= ibly not only in file-notify
but also in the way w32 should handl= e those timeouts.
=
Fabrice


--001a113cf21e8d3a2b052aeea8f0-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145461164931531 (code B ref 22534); Thu, 04 Feb 2016 18:48:01 +0000 Received: (at 22534) by debbugs.gnu.org; 4 Feb 2016 18:47:29 +0000 Received: from localhost ([127.0.0.1]:60615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aROwD-0008CU-BZ for submit@debbugs.gnu.org; Thu, 04 Feb 2016 13:47:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60486) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aROwB-0008CG-NG for 22534@debbugs.gnu.org; Thu, 04 Feb 2016 13:47:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aROw2-0002LU-Ot for 22534@debbugs.gnu.org; Thu, 04 Feb 2016 13:47:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aROw2-0002LQ-LM; Thu, 04 Feb 2016 13:47:18 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4494 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aROw1-000473-R4; Thu, 04 Feb 2016 13:47:18 -0500 Date: Thu, 04 Feb 2016 20:47:02 +0200 Message-Id: <838u30wbx5.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Thu, 4 Feb 2016 10:49:42 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.5 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) > From: Fabrice Popineau > Date: Thu, 4 Feb 2016 10:49:42 +0100 > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > - notifications returned are not the same whether you run the tests in batch mode or interactive mode. > In interactive mode, there is a deleted notification which is sent when your remove the directory being > watched. > This event is not seen when running in batch mode (make check). I wonder what could make a difference. Support for file notifications in batch mode is fragile: w32notify normally works by sending a message to the main thread whenever it has a notification to report. But in batch mode, the main thread doesn't read Windows messages, so whether an event gets reported depends on whether 'pselect' is called, which depends on what API is called to wait for notifications and read them. > - in the test file-notify-test06-many-events to check that events > are not dropped : I have to lower the 1000 number. The test fails > as soon as I go higher than around 260. Is there some limit here ? Is this in interactive or a batch-mode run? > Once the limit is reached, only the first notification is returned. What do you mean by "the first notification"? AFAIU, the 1000 events are generated as 500 pairs of renames, so what is "the first" here, after 260 were already generated? > Overall, I don't think anymore that the patch by Michael has broken w32 file notifications > but rather that the new tests have highlighted some potential problems with it. I've just found a serious problem, see bug#22557. I'm not sure it is related to what you see here, but IMO until that bug is resolved, there's no sense in trying to analyze what happens with notifications on MS-Windows. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 06:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Michael Albinus Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14546519685981 (code B ref 22534); Fri, 05 Feb 2016 06:00:02 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 05:59:28 +0000 Received: from localhost ([127.0.0.1]:60856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRZQV-0001YP-QY for submit@debbugs.gnu.org; Fri, 05 Feb 2016 00:59:28 -0500 Received: from mail-oi0-f49.google.com ([209.85.218.49]:35386) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRZQT-0001YC-Cg for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 00:59:25 -0500 Received: by mail-oi0-f49.google.com with SMTP id s2so35632550oie.2 for <22534@debbugs.gnu.org>; Thu, 04 Feb 2016 21:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=BeW3McbV8W2e7SU3Ii3gKYKPqJYDHKvo1+vaBBc4E34=; b=Mv9lWisGFpzMWWjSQEiMKZa73dKUr6u3/dsppjtASUrBUbq/xDP6yzMiWRHeJ/Bng9 k9Tg5WocRxRPVs1RMZ6oZLJ+qjYA5QXx9cgJwUFpozNEro/AzXIilAOiX9h8/QgqTZxD 1gkRjM/aXaTWf+V+AYSO2iSjZpaOArWg2+xbNc2E3ihLGoVsvt9SXiKhLaLqHAeGugsH z88v0CvcaTV18PQY/OBd/P1IDSjPLAbkoFIQ6bsd55SZm9JQl7q+N+gmL116WSNCPdBE ILinWnAhVdZeoyNblBX+voqn15tg0berdwycQhPuCeWW+xVrOGDb141vzW4LufMWXuiX xPSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=BeW3McbV8W2e7SU3Ii3gKYKPqJYDHKvo1+vaBBc4E34=; b=QFnGSJvrVe0y8KPcKIYFNZLaRBkrALiI+qGMGK+gQl48zWLd/w2lqbSZ5NvNmoOzdN hBOIiTCLb8FjgSrNLbWMvfIBSmT90J2mVt/DDKQQ3TAnEvrR2/vyYKnxxmABNSgTk5d2 F5K84nKreA2RRjiZGiW5EV+0c9NQ7nTBU485aGp9eB+ngsSI3aAeb45tu1O/ZvEEVtXB fhssfjPMTIAPQYjd+siRnlhSdKHKMgWwe8u/VHiNrbGzWcnJo6o8Z235cU4HtdrSFfuQ 36KHx5HNgzfkbWKe3ujEgcHo4IepbV+ag94LUCciJ+fGl5/oYSWXQy/IgtOzRriIz0Yz 7QKg== X-Gm-Message-State: AG10YORjUvB1zwWfOd9uoroIak+SEiQb7l/sXxn7A2BwyZD+78AWyrbB0zCKZhFVnXCANlMWZKXPokR77hDoDg== X-Received: by 10.202.104.152 with SMTP id o24mr7019840oik.87.1454651959843; Thu, 04 Feb 2016 21:59:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.67 with HTTP; Thu, 4 Feb 2016 21:59:00 -0800 (PST) In-Reply-To: <838u30wbx5.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> From: Fabrice Popineau Date: Fri, 5 Feb 2016 06:59:00 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a1140990e56a257052aff8d2e X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1140990e56a257052aff8d2e Content-Type: text/plain; charset=UTF-8 2016-02-04 19:47 GMT+01:00 Eli Zaretskii : > > From: Fabrice Popineau > > Date: Thu, 4 Feb 2016 10:49:42 +0100 > > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > > > - notifications returned are not the same whether you run the tests in > batch mode or interactive mode. > > In interactive mode, there is a deleted notification which is sent when > your remove the directory being > > watched. > > This event is not seen when running in batch mode (make check). I wonder > what could make a difference. > > Support for file notifications in batch mode is fragile: w32notify > normally works by sending a message to the main thread whenever it has > a notification to report. But in batch mode, the main thread doesn't > read Windows messages, so whether an event gets reported depends on > whether 'pselect' is called, which depends on what API is called to > wait for notifications and read them. > > Ok. Maybe that's the reason, but in this case, the expected events have to be adjusted because 'make check' runs in batch mode. > > - in the test file-notify-test06-many-events to check that events > > are not dropped : I have to lower the 1000 number. The test fails > > as soon as I go higher than around 260. Is there some limit here ? > > Is this in interactive or a batch-mode run? > > In interactive mode. The limit is somewhere between 260 and 280. > > Once the limit is reached, only the first notification is returned. > > What do you mean by "the first notification"? AFAIU, the 1000 events > are generated as 500 pairs of renames, so what is "the first" here, > after 260 were already generated? > > The notification for the first pair in the list, the one numbered 999 is the only one appearing in file-notify--test-events. > > Overall, I don't think anymore that the patch by Michael has broken w32 > file notifications > > but rather that the new tests have highlighted some potential problems > with it. > > I've just found a serious problem, see bug#22557. I'm not sure it is > related to what you see here, but IMO until that bug is resolved, > there's no sense in trying to analyze what happens with notifications > on MS-Windows. > Ok, I have seen that. Maybe I'll try to comment out the part of the patch you have pointed out in this bug report and see how it changes the behavior. Fabrice --001a1140990e56a257052aff8d2e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-04 19:47 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
=
> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Thu, 4 Feb 2016 10:49:42 +0100
> Cc: Eli Zaretskii <eliz@gnu.org= >, 22534@debbugs.gnu.org >
> - notifications returned are not the same whether you run the tests in= batch mode or interactive mode.
> In interactive mode, there is a deleted notification which is sent whe= n your remove the directory being
> watched.
> This event is not seen when running in batch mode (make check). I wond= er what could make a difference.

Support for file notifications in batch mode is fragile: w32notify normally works by sending a message to the main thread whenever it has
a notification to report.=C2=A0 But in batch mode, the main thread doesn= 9;t
read Windows messages, so whether an event gets reported depends on
whether 'pselect' is called, which depends on what API is called to=
wait for notifications and read them.


Ok. Maybe that= 's the reason, but in this case, the expected events have to be adjuste= d because 'make check'
runs in batch mode.
=C2= =A0
> - in the test file-notify-test06-many-events to check that events
> are not dropped : I have to lower the 1000 number.=C2=A0 The test fail= s
> as soon as I go higher than around 260. Is there some limit here ?

Is this in interactive or a batch-mode run?

In interactive mode. The limi= t is somewhere between 260 and 280.
=C2=A0
= > Once the limit is reached, only=C2=A0 the first notification is return= ed.

What do you mean by "the first notification"?=C2=A0 AFAIU,= the 1000 events
are generated as 500 pairs of renames, so what is "the first" her= e,
after 260 were already generated?


The notificati= on for the first pair in the list, the one numbered 999 is the only one
appearing in file-notify--test-events.
=C2=A0
> Overall, I don't think anymore that the patch by Michael has broke= n w32 file notifications
> but rather that the new tests have highlighted some potential problems= with it.

I've just found a serious problem, see bug#22557.=C2=A0 I'm = not sure it is
related to what you see here, but IMO until that bug is resolved,
there's no sense in trying to analyze what happens with notifications on MS-Windows.

Ok, I have seen tha= t. Maybe I'll try to comment out the part of the patch you have pointed= out in this bug report
and see how it chan= ges the behavior.

Fabrice
--001a1140990e56a257052aff8d2e-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 10:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145466704022175 (code B ref 22534); Fri, 05 Feb 2016 10:11:02 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 10:10:40 +0000 Received: from localhost ([127.0.0.1]:32830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRdLc-0005lb-7p for submit@debbugs.gnu.org; Fri, 05 Feb 2016 05:10:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44294) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRdLa-0005lO-BF for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 05:10:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRdLQ-0001HF-AJ for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 05:10:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRdLQ-0001HB-6j; Fri, 05 Feb 2016 05:10:28 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1404 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aRdLP-0003xx-3N; Fri, 05 Feb 2016 05:10:27 -0500 Date: Fri, 05 Feb 2016 12:10:19 +0200 Message-Id: <83fux7v56c.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Fri, 5 Feb 2016 06:59:00 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.5 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) > From: Fabrice Popineau > Date: Fri, 5 Feb 2016 06:59:00 +0100 > Cc: Michael Albinus , 22534@debbugs.gnu.org > > Support for file notifications in batch mode is fragile: w32notify > normally works by sending a message to the main thread whenever it has > a notification to report. But in batch mode, the main thread doesn't > read Windows messages, so whether an event gets reported depends on > whether 'pselect' is called, which depends on what API is called to > wait for notifications and read them. > > Ok. Maybe that's the reason, but in this case, the expected events have to be adjusted because 'make check' > runs in batch mode. True. I have done that several times to fix that test; maybe it's time to do that again. > > Once the limit is reached, only the first notification is returned. > > What do you mean by "the first notification"? AFAIU, the 1000 events > are generated as 500 pairs of renames, so what is "the first" here, > after 260 were already generated? > > The notification for the first pair in the list, the one numbered 999 is the only one > appearing in file-notify--test-events. So you are saying that as soon as the value of n is greater than some threshold, like 260, the test reports only the first pair of renames, is that true? If so, did you try to insert waits in-between the series or renames? Or maybe the preceding series of file creations is the culprit, and we should give Emacs more time to report them? Because right now, it just fires up all of them in a single quick series. Hmm... actually, I might see a problem. If my reading of the test is correct, it first creates 2000 files, and then issues 1000 renames, which on Windows generate 2000 notifications. Together, these add up to 4000, which is awfully close to the 4096 size of the Emacs input event queue. So maybe the test fills up the event queue, and the synchronization between the w32notify thread and the main thread stops working at that point? Or maybe we are hitting on some limit of Windows messages that can be enqueued? (To tell the truth, I'm not sure what is the purpose of that test: AFAIK, none of the available notification back-ends ever promised not to lose events, so what are we testing here? Perhaps Michael can explain.) > I've just found a serious problem, see bug#22557. I'm not sure it is > related to what you see here, but IMO until that bug is resolved, > there's no sense in trying to analyze what happens with notifications > on MS-Windows. > > Ok, I have seen that. Maybe I'll try to comment out the part of the patch you have pointed out in this bug report > and see how it changes the behavior. If you have time, yes, please. Btw, are you doing this on master or on emacs-25? The files involved seem to be identical for now, but they might diverge in the future. Thanks. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Michael Albinus Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145468648525821 (code B ref 22534); Fri, 05 Feb 2016 15:35:02 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 15:34:45 +0000 Received: from localhost ([127.0.0.1]:34554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRiPE-0006iO-MS for submit@debbugs.gnu.org; Fri, 05 Feb 2016 10:34:45 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:33060) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRiPC-0006iA-UV for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 10:34:43 -0500 Received: by mail-ob0-f175.google.com with SMTP id is5so90634479obc.0 for <22534@debbugs.gnu.org>; Fri, 05 Feb 2016 07:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=KmFw+dOftVEfTCDGCRtg4QmaxXiKoK+R3evtkHk1Vqk=; b=rq3graGLqmrkaQ/fyqeTNJ7lDpagEacLP314gl221W9MorLo9CpRM0ROQn1uiGtlXs Xc2x16gLSOpH8rfgO3yNwdjKyfIF/1HUlsoc93N5WI0sW585lRJ0aWL6Wyqb+r07rFjn ULsVYzw9ifAQqKy3PdbX+y+kjVf+l3/CNVRvVw9hV6TrpQ44PG0w2ZW3wYqTyAIIQVkF O05MSbB8VVWFXR1wk7wc1AMxzGEdvWPo39UQCtioJp5UxYck9o8TqMVRXamOsGGnp7Ji RZlm/MrmvQvQGgkh5XM7ID8wVep08aVGFpx6eYTjpJ9y5Z4WaHOKCNM+2/NPIsP9silg 6WsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=KmFw+dOftVEfTCDGCRtg4QmaxXiKoK+R3evtkHk1Vqk=; b=c5L895YwTWUWg6vuDIcC0NTvoSHWYev5kyEhVvue1syqwc64h4Zraa/plJtY2YXrU+ K+fSXsRVnOU3/Y6rBwjE5M7Dow1qjP0mZnikTaOjIzDCuhUl7VCSVP0xVuxP11UTA7Ox 3K9v0QP2tNuYxy1mySxNGMNojYNeU1Mns4B3AGSb5uBzNNsEXAdorV+6zYSYZZu2Q+SX rOVDbfA47+8z04jkrfI3yucVWNi/HuhDFDDAeg6D+s6UbraIrH2qjCzBrLB3XlDzzt+4 BVWPWRRZg0YJJfyQmN71TJxCm9dIJY6MLiAMZ3LCMSvpyJN8IIG/lszl/Bk/IW2qRBns y96Q== X-Gm-Message-State: AG10YORA4LNUAeARA7LQccKQVQQrFUuMCNDw7ATePDp1ZroPj7YRwUWbDL1LT+wmp8A5QVimQQ88FW6VZ8gx6w== X-Received: by 10.182.73.225 with SMTP id o1mr13224285obv.80.1454686477390; Fri, 05 Feb 2016 07:34:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.67 with HTTP; Fri, 5 Feb 2016 07:34:17 -0800 (PST) In-Reply-To: <83fux7v56c.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> From: Fabrice Popineau Date: Fri, 5 Feb 2016 16:34:17 +0100 Message-ID: Content-Type: multipart/alternative; boundary=089e0160b7c6be9a43052b079638 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e0160b7c6be9a43052b079638 Content-Type: text/plain; charset=UTF-8 2016-02-05 11:10 GMT+01:00 Eli Zaretskii : > > From: Fabrice Popineau > > Date: Fri, 5 Feb 2016 06:59:00 +0100 > > Cc: Michael Albinus , 22534@debbugs.gnu.org > > > > > > Once the limit is reached, only the first notification is returned. > > > > What do you mean by "the first notification"? AFAIU, the 1000 events > > are generated as 500 pairs of renames, so what is "the first" here, > > after 260 were already generated? > > > > The notification for the first pair in the list, the one numbered 999 is > the only one > > appearing in file-notify--test-events. > > So you are saying that as soon as the value of n is greater than some > threshold, like 260, the test reports only the first pair of renames, > is that true? > > Yes, this is what I observe with different values of n. > If so, did you try to insert waits in-between the series or renames? > I have tried to add a sit-for in the loop which renames the files, but it does not help. > Or maybe the preceding series of file creations is the culprit, and we > should give Emacs more time to report them? > I have tried with different values of file-notify--test-timeout but it doesn't seem to make any difference. I also boosted the size of the file_notifications[] array (* 16) without any difference. I have tested with sit-for between each rename operation and it does not work either above 260 files Because right now, it just fires up all of them in a single quick > series. > > Hmm... actually, I might see a problem. If my reading of the test is > correct, it first creates 2000 files, and then issues 1000 renames, > which on Windows generate 2000 notifications. Together, these add up > to 4000, which is awfully close to the 4096 size of the Emacs input > event queue. So maybe the test fills up the event queue, and the > synchronization between the w32notify thread and the main thread stops > working at that point? Or maybe we are hitting on some limit of > Windows messages that can be enqueued? > > I would have expected some Win32 function to error at some point ? Also, would it be useful to use the overlap mechanism ? Would it help to overcome this kind of limitation ? > (To tell the truth, I'm not sure what is the purpose of that test: > AFAIK, none of the available notification back-ends ever promised not > to lose events, so what are we testing here? Perhaps Michael can > explain.) > > > I've just found a serious problem, see bug#22557. I'm not sure it is > > related to what you see here, but IMO until that bug is resolved, > > there's no sense in trying to analyze what happens with notifications > > on MS-Windows. > > > > Ok, I have seen that. Maybe I'll try to comment out the part of the > patch you have pointed out in this bug report > > and see how it changes the behavior. > > If you have time, yes, please. > > It does not help with file-notify-test06-many-events but I would have expected it. > Btw, are you doing this on master or on emacs-25? The files involved > seem to be identical for now, but they might diverge in the future. > emacs-25 at this time. Fabrice --089e0160b7c6be9a43052b079638 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-05 11:10 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
=
> From: Fabrice Popineau <fabrice.popineau@gmail.com> > Date: Fri, 5 Feb 2016 06:59:00 +0100
> Cc: Michael Albinus <michael.albinus@gmx.de>, 22534@debbugs.gnu.org
>

>=C2=A0 > Once the limit is reached, only the first notification is r= eturned.
>
>=C2=A0 What do you mean by "the first notification"? AFAIU, t= he 1000 events
>=C2=A0 are generated as 500 pairs of renames, so what is "the firs= t" here,
>=C2=A0 after 260 were already generated?
>
> The notification for the first pair in the list, the one numbered 999 = is the only one
> appearing in file-notify--test-events.

So you are saying that as soon as the value of n is greater than som= e
threshold, like 260, the test reports only the first pair of renames,
is that true?

=C2=A0
Yes, this is what I observe with dif= ferent values of n.

=C2=A0
If so, did you try to insert waits in-between the series or renames?

I have tried to add a sit-for in the loop = which renames the files, but
it does not help.
=C2=A0
Or maybe the preceding series of file creations is the= culprit, and we
should give Emacs more time to report them?
=C2=A0
I have tried with different values of=C2=A0file-notify--test-timeout= but it doesn't seem
to make any difference. I also boosted t= he size of the file_notifications[] array (* 16)
without any diff= erence. I have tested with sit-for between each rename operation
= and it does not work either above 260 files



Because right now, it just fires up all of them in a single quick
series.

Hmm... actually, I might see a problem.=C2=A0 If my reading of the test is<= br> correct, it first creates 2000 files, and then issues 1000 renames,
which on Windows generate 2000 notifications.=C2=A0 Together, these add up<= br> to 4000, which is awfully close to the 4096 size of the Emacs input
event queue.=C2=A0 So maybe the test fills up the event queue, and the
synchronization between the w32notify thread and the main thread stops
working at that point?=C2=A0 Or maybe we are hitting on some limit of
Windows messages that can be enqueued?


I would have expected some Win32 funct= ion to error at some point ?

Also, would it be use= ful to use the overlap mechanism ? Would it help to overcome this kind of l= imitation ?
=C2=A0
(To tell the truth, I'm not sure what is the purpose of that test:
AFAIK, none of the available notification back-ends ever promised not
to lose events, so what are we testing here?=C2=A0 Perhaps Michael can
explain.)

>=C2=A0 I've just found a serious problem, see bug#22557. I'm no= t sure it is
>=C2=A0 related to what you see here, but IMO until that bug is resolved= ,
>=C2=A0 there's no sense in trying to analyze what happens with noti= fications
>=C2=A0 on MS-Windows.
>
> Ok, I have seen that. Maybe I'll try to comment out the part of th= e patch you have pointed out in this bug report
> and see how it changes the behavior.

If you have time, yes, please.


It does not help with file-notify-test= 06-many-events but I would have expected it.
=C2=A0
Btw, are you doing this on master or on emacs-25?=C2=A0 The files involved<= br> seem to be identical for now, but they might diverge in the future.

emacs-25 at this time.

Fabrice

--089e0160b7c6be9a43052b079638-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14546927499266 (code B ref 22534); Fri, 05 Feb 2016 17:20:02 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 17:19:09 +0000 Received: from localhost ([127.0.0.1]:34620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRk2G-0002PO-RW for submit@debbugs.gnu.org; Fri, 05 Feb 2016 12:19:09 -0500 Received: from mout.gmx.net ([212.227.15.15]:57935) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRk2E-0002Ou-RG for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 12:19:07 -0500 Received: from detlef.gmx.de ([87.146.56.6]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MVvB2-1aYHVc1YWu-00X85N; Fri, 05 Feb 2016 18:19:00 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> Date: Fri, 05 Feb 2016 18:18:59 +0100 In-Reply-To: (Fabrice Popineau's message of "Fri, 5 Feb 2016 16:34:17 +0100") Message-ID: <871t8rm5x8.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:f7vT/w01me5KyKZPqWO+h52Mld8YxgxF8fQ6ED0E06hdi6Nx4HX iYOgUpqoOcwQuSG70IDfF0gdYnuPB/JBakyC+i9ny/sFwC/e5gJljcRBG+Dc8b6qHcTcgmk F0mnyaY5jGJemnZdejDMG8ngMzQy8YLG5OWj6VmQbj7WvHrBohz3ZXPZ5BpiJkXvabF0FKw bNLnU1ahdwUXADRlBnQ6w== X-UI-Out-Filterresults: notjunk:1;V01:K0:ag+wDCDUfoU=:iSaYvv4BzpHjOMcZQOYkH0 nuBg4azDsCf8byq4YQx4i2s/c7WzWnccEuAz3tF0Nilv3n9AnOELESUrujLZk8X0RmLl4GOHX 5R6N6mth8CknGyDbdpRuAuFToARchlDAsw5FljZ0imLwLdZXvTtUvfSP6CCH8zoNg6txrUyCn ZYSxw2X7m90fGvJpcdL1ct4sSAnW/KF17rGkIVnmAS/2MAXt9qqfWgGiC5ca4k+SqezbDRqL+ rb5xMzgaxqQZCnGhB30dMubWJ0snOUtCH38GwQPNXi0Oj5zSp53hIi1IaihiEe8NiB5olY/Ia SJAkbRE7fTXqHb/Wc0VdHXVyKHZqLfXo2PAJwMM5x7LOh3xGr9ckhHgCjoRLj/RCCBzllpeQ5 DWd7/EAXKh1D4Tggr28q9Y8Nmzk1zU0EnkVpEaqNCedXanyULiCdkBB+2NiRMDvqJLTsg71dA Eck7bVXttYa4v+2xVPTOq/uWIdq9AczNjxl6AsorR6DvZBLLx13kmZ3YrtbF9kuE9ViYAAyRp 3ukC0FoTVZnSfhLSvr0E2vancr6E7iuEgpkTSIN1HaM7QSvNELyGpa8wTelpm+w+KSKFpcLy6 ttyYxTLvxoMQoVC1K7PhcmL2YmZycj51/2a2+8h80tTStxqfIYvvjVQlRvCwWtscItsa6hl+/ c5z3j/Lk3ptZ6ic1BpyvdYMnTffiULWB/6/Qcsi//oKTtW+Z3T79uoA/mDDuoUwgAVihpBO/5 78ZaE0DBfL+DiffMuSRGgWzdH2zzJL1kSwvmiZ0qtEqJj30DHD8P5whjX4TPDpnghyz2Pf1aw cyBLtoI X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fabrice Popineau writes: Hi, > I have tried with different values of file-notify--test-timeout but it > doesn't seem to make any difference. I also boosted the size of the > file_notifications[] array (* 16) without any difference. I have > tested with sit-for between each rename operation and it does not work > either above 260 files Is it worth to continue to look for the problem in w32notify? I would simply set the loop limit there to 250, that's it. file-notify-test06-many-events is a stress test. Originally, Wolfgang Jenkner proposed it with 10.000 iterations - that was *really* much too long. [Eli] > (To tell the truth, I'm not sure what is the purpose of that test: > AFAIK, none of the available notification back-ends ever promised > not to lose events, so what are we testing here? Perhaps Michael > can explain.) As said, it was intended as stress test. But we are free to adapt it to the limitations of the underlying backend. > Fabrice Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Fabrice Popineau Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14546930459734 (code B ref 22534); Fri, 05 Feb 2016 17:25:02 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 17:24:05 +0000 Received: from localhost ([127.0.0.1]:34624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRk73-0002Ww-EI for submit@debbugs.gnu.org; Fri, 05 Feb 2016 12:24:05 -0500 Received: from mout.gmx.net ([212.227.15.18]:62012) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRk71-0002WT-Jh for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 12:24:04 -0500 Received: from detlef.gmx.de ([87.146.56.6]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MNq8p-1aQLCh3UBH-007RxT; Fri, 05 Feb 2016 18:23:57 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> Date: Fri, 05 Feb 2016 18:23:55 +0100 In-Reply-To: <83fux7v56c.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Feb 2016 12:10:19 +0200") Message-ID: <87wpqjkr4k.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:6yMjh/mvPSRqC7p7NrcGo7FKhj4MKe9zqOvklZID48oO62Xb85A zipWIMgIalNtWl6Xta/PIOZWrZqxM9LzlnUBxX1HzhTBaaRZsmpgFEXZ6bwObyNHTHZyEjf Fvh1bn6Aywq523W8+aOhrxcXZLfjHDwkWoKlO1K63eNQdEm0LS47K4B8fBJkdFfVeT47Rs6 NRBOUqy2cjRWJFxPA0+9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:So/QewGYYS4=:K/d2Ij+ucll3s2VuDxbVKo JdN0avm7l9pZKPiYpPERioM0ZekWNtF+CX2C3vLUemSh/j1e38AvXm3Sc4lU9ILrQEwKEbWS4 o7dNYdKYlI4HxR5OpO6GtXZNkuci8cdVYZtq+dvV4d3fD0vuW7uH0fPMo/49swUFyqRXCIkFx ckClP13u7ZRN6AqznCfX0Ka02NCpcCPGsleEd+fkOdqP31JHPZVHDVmDHa3zIMnsqPvlW1WVJ imjNwHmZVe0AkL2Fo6Heibb81meBDZcWROkZHTXGiHb48CLqKZluxTI/V5fR18cjBzJ3SeBp0 wnP3qyxHkCpH8GQQI2Kn9LTX0kqXxiO2BM8WSWpIsnZ5xteKxTr98tby1BIpB1SXpGEhOp8Xr wlRJeMeQzDuWq8BU3GgTme8iSJdbQmL7mFJjuIfOvKhD3ZQ+i+s3/5CENw/zCUMiHEW642EQa RBPPMcVVziavkS9RLbzD2SR/b7fotUlyZTb/vtTs6IihHkErQG9bQb9tXRlFZg9u4RtH0pCQy nj7m4reiuPM7sUj2qunrEGz3IbSWnnkFRicBqnSjl64VJIyhoOJA5vJMWOQeSaGgDqQCnHL7y pm4kqheY0w4epQ+7YYh4k/ZLiB3NY+UZluPq3uwRKkxEpBScv4+PUoEM7HGbVHF/M7aejVTrU 0wsNRpKQcv1/F+DbivosCb+NeJ3ZXTE/1ndPQyPRiGGrCK7cZzut2N0m6VK703ETrzmD6kQgs KuGESCBA2Z7l1D4eJupsBS+y6ll31R81V5jft+p7S+/R9DjRBKuPQRSISS+gPQi751VCChltn fFcz5AZ X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> Ok. Maybe that's the reason, but in this case, the expected events >> have to be adjusted because 'make check' >> runs in batch mode. > > True. I have done that several times to fix that test; maybe it's > time to do that again. For the records, I'm not able to build Emacs by myself under MS Windows; I use the distribution of Dani Moncayo. It even does not contain the test directory; I must arrange it by myself. I'm grateful if you guys could run the batch tests. And maybe propose something more clever to wait for events in such an environment. > Thanks. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14547007431925 (code B ref 22534); Fri, 05 Feb 2016 19:33:01 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 19:32:23 +0000 Received: from localhost ([127.0.0.1]:34727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRm7C-0000Ux-Oc for submit@debbugs.gnu.org; Fri, 05 Feb 2016 14:32:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36892) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRm7B-0000TL-2a for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 14:32:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRm71-0002Qd-FH for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 14:32:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRm71-0002QZ-BL; Fri, 05 Feb 2016 14:32:11 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1987 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aRm70-0003eo-Gx; Fri, 05 Feb 2016 14:32:10 -0500 Date: Fri, 05 Feb 2016 21:31:49 +0200 Message-Id: <83y4azt0m2.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Fri, 5 Feb 2016 16:34:17 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) > From: Fabrice Popineau > Date: Fri, 5 Feb 2016 16:34:17 +0100 > Cc: Michael Albinus , 22534@debbugs.gnu.org > > Hmm... actually, I might see a problem. If my reading of the test is > correct, it first creates 2000 files, and then issues 1000 renames, > which on Windows generate 2000 notifications. Together, these add up > to 4000, which is awfully close to the 4096 size of the Emacs input > event queue. So maybe the test fills up the event queue, and the > synchronization between the w32notify thread and the main thread stops > working at that point? Or maybe we are hitting on some limit of > Windows messages that can be enqueued? > > I would have expected some Win32 function to error at some point ? Maybe it does, and we don't check error codes? But these are speculations. And since all my other guesses were wrong, this one most probably is as well. I will look into this later if no one beats me to it. > Also, would it be useful to use the overlap mechanism? Where? in reading Windows messages? From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14547014393410 (code B ref 22534); Fri, 05 Feb 2016 19:44:02 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 19:43:59 +0000 Received: from localhost ([127.0.0.1]:34740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRmIR-0000sw-Gl for submit@debbugs.gnu.org; Fri, 05 Feb 2016 14:43:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39027) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRmIQ-0000sh-Id for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 14:43:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRmIH-000523-DQ for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 14:43:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRmIH-00051t-9e; Fri, 05 Feb 2016 14:43:49 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2028 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aRmIG-0000yx-D9; Fri, 05 Feb 2016 14:43:48 -0500 Date: Fri, 05 Feb 2016 21:43:26 +0200 Message-Id: <83si17t02p.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <871t8rm5x8.fsf@gmx.de> (message from Michael Albinus on Fri, 05 Feb 2016 18:18:59 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) > From: Michael Albinus > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > Date: Fri, 05 Feb 2016 18:18:59 +0100 > > > I have tried with different values of file-notify--test-timeout but it > > doesn't seem to make any difference. I also boosted the size of the > > file_notifications[] array (* 16) without any difference. I have > > tested with sit-for between each rename operation and it does not work > > either above 260 files > > Is it worth to continue to look for the problem in w32notify? I would simply > set the loop limit there to 250, that's it. It would be a waste of your time to look into that. Go ahead and lower the number; I will look into the problem when I have time and see what come up with. We can then pick up where we left off. > file-notify-test06-many-events is a stress test. Originally, Wolfgang > Jenkner proposed it with 10.000 iterations - that was *really* much too > long. > > [Eli] > > > (To tell the truth, I'm not sure what is the purpose of that test: > > AFAIK, none of the available notification back-ends ever promised > > not to lose events, so what are we testing here? Perhaps Michael > > can explain.) > > As said, it was intended as stress test. But we are free to adapt it to > the limitations of the underlying backend. My point is that we could legitimately lose events for reasons that have nothing to do with Emacs. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Feb 2016 21:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145470950628026 (code B ref 22534); Fri, 05 Feb 2016 21:59:02 +0000 Received: (at 22534) by debbugs.gnu.org; 5 Feb 2016 21:58:26 +0000 Received: from localhost ([127.0.0.1]:34841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRoOY-0007Hy-Bt for submit@debbugs.gnu.org; Fri, 05 Feb 2016 16:58:26 -0500 Received: from mout.gmx.net ([212.227.17.22]:61463) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRoOW-0007Hk-C1 for 22534@debbugs.gnu.org; Fri, 05 Feb 2016 16:58:24 -0500 Received: from detlef.gmx.de ([87.146.56.6]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LgeFd-1ZeCQ02sSb-00nwsy; Fri, 05 Feb 2016 22:58:17 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> Date: Fri, 05 Feb 2016 22:58:15 +0100 In-Reply-To: <83si17t02p.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Feb 2016 21:43:26 +0200") Message-ID: <87si16lszs.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:AEckKLojPZYsmwT6ZpbB9Ygtskndkug8zUNiipE77R2QIZNEO4M iE1JaHKqQnlbBvILygj6vDZ6UkrCvtotoG6qdfds4tAYTBHiMxYTmpQpHvV/EI8bRh9NA1Y UenjrvWFkH8h7/w4j4Ybzg0A0E4oQOXsSmBGonp1dfasq2YZTxencUKFnGMfCeEmkLo4tgz lK7/m5Nn47V2Gfji3u8bw== X-UI-Out-Filterresults: notjunk:1;V01:K0:IwFlkvqi0/8=:zpSo8kplRJJ2HY+E6o5EQb FQPoV0k6vtzB7visB+LQEcuxfwKzGngBTZfob+qWBUwZ4TQNkP/7zjTwr5bXLQvhSPXwYxd0o 7fpVhlIoXQEbJkMrQq1ZwJcrSp4Pgu3PhpMUydzP/xJsEIkr7m8PBKQt8tT/mjPCNExTwFd1o SSnRdNZMyzuptCLj4UrtCwaNoizM6IymNu2eIuShyGrhVjCEuonUlRJMwzcwCXYaSDStWKqzy 8R/alnVcrRhPApqf3Zg6h6Ht/RoiHeuFP9+h8B0bHgx4+ZASQAoN/3TMDK3IIPlK6UmnKByTT p2wcIQtpZ7lCRt/eEi5QU0ae43EBcs0LkYfbp6Z1XqeJ2l5n42kWD8Yw1ar+rihDB9/5dXmBl v8oo93oZPM0DP9tiFdAYtSxg64YnvYJpEhK0YXCuVIsvISaZkCYk+ERx2uCv9gvP+yQpsbCPn wBFbzhOEWWToZI7ksTqsxiMHL/BDFVnM+lftVWoqxKuGiLwtMDtzBxF4pVOdKG74tBqBWaYG5 fC5v8Og8jEKeUNW6pWdN2RA4HsbkkhUJ5BTAa5PjbhODDqF0/K3qWSwXJbpx6+IVQ2PCVyLJh lQ0Ir4XJBIiUOUtKmX26Ln4DaQK7mFJ+nhFZER8vSXV81sisLEircqbHJ3CPhWlSLzIX9LkHW qY5807yoCgitCV0ou2RwMrkHfI2UZaOA0aUxoJ7/x76GuDJEs3ePqNbZDw2BrE7u/93ae7k06 bn/2rSO5k7JeEEOO63KlCaL543yGez7WrnL0ljt4HuJeoSoFgDTlUDtSntPj1sULwXstLk0Cy S4r4Fxb X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> Is it worth to continue to look for the problem in w32notify? I would simply >> set the loop limit there to 250, that's it. > > It would be a waste of your time to look into that. Go ahead and > lower the number; I will look into the problem when I have time and > see what come up with. We can then pick up where we left off. Done. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2016 16:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: michael.albinus@gmx.de Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145477761923539 (code B ref 22534); Sat, 06 Feb 2016 16:54:02 +0000 Received: (at 22534) by debbugs.gnu.org; 6 Feb 2016 16:53:39 +0000 Received: from localhost ([127.0.0.1]:36028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS678-00067a-Pa for submit@debbugs.gnu.org; Sat, 06 Feb 2016 11:53:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60531) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS677-00067P-U4 for 22534@debbugs.gnu.org; Sat, 06 Feb 2016 11:53:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aS671-0001W2-N5 for 22534@debbugs.gnu.org; Sat, 06 Feb 2016 11:53:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS66x-0001V4-Uq; Sat, 06 Feb 2016 11:53:27 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3034 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aS66x-0002YN-2t; Sat, 06 Feb 2016 11:53:27 -0500 Date: Sat, 06 Feb 2016 18:53:04 +0200 Message-Id: <83wpqhsrv3.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83si17t02p.fsf@gnu.org> (message from Eli Zaretskii on Fri, 05 Feb 2016 21:43:26 +0200) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) > Date: Fri, 05 Feb 2016 21:43:26 +0200 > From: Eli Zaretskii > Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com > > > From: Michael Albinus > > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > Date: Fri, 05 Feb 2016 18:18:59 +0100 > > > > > I have tried with different values of file-notify--test-timeout but it > > > doesn't seem to make any difference. I also boosted the size of the > > > file_notifications[] array (* 16) without any difference. I have > > > tested with sit-for between each rename operation and it does not work > > > either above 260 files > > > > Is it worth to continue to look for the problem in w32notify? I would simply > > set the loop limit there to 250, that's it. > > It would be a waste of your time to look into that. Go ahead and > lower the number; I will look into the problem when I have time and > see what come up with. We can then pick up where we left off. I've looked into this. The simple patch below fixes the test for me. The problem was that all the 1000 renames were run in a single long series. On MS-Windows this generates 2000 events, because the target file exists and needs to be deleted first. However, w32notify has a static limit of about 1000 events it can collect without losing some (that's on a 32-bit system, probably less on a 64-bit OS). The last part of the riddle is that in batch mode file notifications are not read on MS-Windows unless someone calls read-event or a similar function that calls 'pselect' to check for input. If they are not read, they keep accumulating, and are then reported all together. I also suspect that the Windows API use by w32notify has its own limit of events it can accumulate, and beyond that limit simply drops the older events on the floor. The solution is to call read-event while renaming the files. Then I could go back to 1000 renames without failures. Michael, is there a reason not to issue those additional calls to read-event on other platforms? If necessary, those calls could be made conditional on MS-Windows. Here's the proposed patch. Fabrice, please see if this works for you (the full test runs for about 7 minutes, so be patient). Btw, we could make the test run faster by lowering the 0.1 argument to the 2 read-event calls while we create the 2000 files at the beginning of the test, I see no need for waiting that long for a single file creation. diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index 629d85b..5fc4ff8 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -66,7 +66,7 @@ file-notify--test-timeout "Timeout to wait for arriving events, in seconds." (cond ((file-remote-p temporary-file-directory) 6) - ((string-equal (file-notify--test-library) "w32notify") 20) + ((string-equal (file-notify--test-library) "w32notify") 10) ((eq system-type 'cygwin) 10) (t 3))) @@ -797,10 +797,7 @@ file-notify--test-with-events file-notify--test-tmpfile '(change) 'file-notify--test-event-handler))) (unwind-protect - ;; In case of w32notify, the upper limit of events to handle - ;; seems to be 260. Reason unknown. - (let ((n (if (string-equal (file-notify--test-library) "w32notify") - 250 1000)) + (let ((n 1000) source-file-list target-file-list (default-directory file-notify--test-tmpfile)) (dotimes (i n) @@ -832,10 +829,11 @@ file-notify--test-with-events (let ((source-file-list source-file-list) (target-file-list target-file-list)) (while (and source-file-list target-file-list) - (rename-file (pop source-file-list) (pop target-file-list) t)))) + (rename-file (pop source-file-list) (pop target-file-list) t) + (read-event nil nil 0.02)))) (file-notify--test-with-events (make-list n 'deleted) (dolist (file target-file-list) - (delete-file file)))) + (prog1 (delete-file file) (read-event nil nil 0.02))))) (file-notify--test-cleanup))) (file-notify--deftest-remote file-notify-test06-many-events From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2016 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14547866844606 (code B ref 22534); Sat, 06 Feb 2016 19:25:01 +0000 Received: (at 22534) by debbugs.gnu.org; 6 Feb 2016 19:24:44 +0000 Received: from localhost ([127.0.0.1]:36078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS8TL-0001CE-Uy for submit@debbugs.gnu.org; Sat, 06 Feb 2016 14:24:44 -0500 Received: from mout.gmx.net ([212.227.17.22]:53808) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS8TK-0001C0-8W for 22534@debbugs.gnu.org; Sat, 06 Feb 2016 14:24:42 -0500 Received: from detlef.gmx.de ([93.209.75.89]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LfXmv-1ZiOa346Jd-00p8Z0; Sat, 06 Feb 2016 20:24:35 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> Date: Sat, 06 Feb 2016 20:24:32 +0100 In-Reply-To: <83wpqhsrv3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Feb 2016 18:53:04 +0200") Message-ID: <874mdllk0f.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:ZMqGMdtV0vs0cW9P2+4fqOnZi5W4PiXueRGs5ZcLS418rwbZhVB S61e7BAoaPTLCipe5YRf+hTv6tTK0edNRnEsfuuTAe3sgBrPOWJneZQO9UnCJXNk0mnvV5s xrlzB33D8ov3/xGzUojter/iO5rpzhVW2FIXIHEkMYrZUBUfzggQ2xEhFfAw1zmboOZo2ry 9E2I/rE3IGqpnUkprS+vA== X-UI-Out-Filterresults: notjunk:1;V01:K0:tG6SPNeEKMI=:aRDlumYREfoaQz87SLuDMw wtnoX9vxrlFPmEURdWWeqUgaCHcON335DqMDKRy7JErSWghPn9Dpa6+BSkGaK6TQ3H00y+9kp oX8laUmIxcQdfVDjRvB7LmHbEAkjC1BPpVIDf0qXp7Go0J88gkkcR7Itl3c/K8BCmASCGAtAi TSQ4WxKELyia3jXBqjDfSfVIomyK4N2oGntAn0IRLFUpaLQhCmI6rb3nzibRx6xOdvonGFRc4 4la+tB+n7dm5YmjvMPjq/HtORdraFY9ZV+wXYwU027iwqKJ5s4wvDfTe365HeU/5CFY/CJuSa 8rvuczJcnA/+bjhvoF+LQogNETX8kkYhBgWYSqyQ0LmhTgtQZ2pRuUzx+FQ1ylD2WkdlmgfDX KW9oC8tdKT04Ec7U90nd0KQDqpZttTOla6xbmF1h3op8KgbtuT+WXln70hFNY0TyB1cajbZhi hu84FhU80n9GVZNCU4fpm8hQx0jz9uhkY3YGFimqaY86mSo8cyq0B28KkAcm6wHAYTR/dixBH Tev+3bTB3DE6SxBzPMvAv5MoMjka/sRrav4OqMnLERYYeKpGpEdOVK3HpGNrv+3n2mV5wD0HZ UYhC49GyaN0wVHU/450qFjpTG86uHxSvY0jLO4qNgw8Zh9YlV4Mh29jbEMgHx7H6eCYdDmN0+ RiLZ7uC8AQPSgxYmjKT25iCtmtmNHJ2AV66OZbZZmczuhIB/OKQ9CvPPXWvQoLFryAwHLOFt7 kzlBAePtCPns3WQF6IVLRPLyXLqHOmPKGOjIzb54oxo5PMum6ZONgrZ23fyBcgJZUXZqKbvoF elVgVVw X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > The solution is to call read-event while renaming the files. Then I > could go back to 1000 renames without failures. > > Michael, is there a reason not to issue those additional calls to > read-event on other platforms? If necessary, those calls could be > made conditional on MS-Windows. No, it's OK also for the other backends. This might make the test even more robust. > Here's the proposed patch. Fabrice, please see if this works for you > (the full test runs for about 7 minutes, so be patient). Btw, we > could make the test run faster by lowering the 0.1 argument to the 2 > read-event calls while we create the 2000 files at the beginning of > the test, I see no need for waiting that long for a single file > creation. Well, the two Tramp backends aren't such fast. That's why I use a 0.1 sec timeout for all read-event calls. Maybe we could introduce a defconst for this, setting it to 0.02 for local backends, and to 0.1 for remote backends. Please install the patch; I'll test it then for the other 5 backends next days. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2016 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14547885687500 (code B ref 22534); Sat, 06 Feb 2016 19:57:01 +0000 Received: (at 22534) by debbugs.gnu.org; 6 Feb 2016 19:56:08 +0000 Received: from localhost ([127.0.0.1]:36094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS8xj-0001wt-Nu for submit@debbugs.gnu.org; Sat, 06 Feb 2016 14:56:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46159) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS8xi-0001wU-Bk for 22534@debbugs.gnu.org; Sat, 06 Feb 2016 14:56:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aS8xc-0005qc-Ex for 22534@debbugs.gnu.org; Sat, 06 Feb 2016 14:56:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS8xX-0005qO-V9; Sat, 06 Feb 2016 14:55:55 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3460 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aS8xX-0000aw-5n; Sat, 06 Feb 2016 14:55:55 -0500 Date: Sat, 06 Feb 2016 21:55:33 +0200 Message-Id: <83r3gpsjey.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <874mdllk0f.fsf@gmx.de> (message from Michael Albinus on Sat, 06 Feb 2016 20:24:32 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) > From: Michael Albinus > Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com > Date: Sat, 06 Feb 2016 20:24:32 +0100 > > Please install the patch Done. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Michael Albinus Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145485228311754 (code B ref 22534); Sun, 07 Feb 2016 13:39:01 +0000 Received: (at 22534) by debbugs.gnu.org; 7 Feb 2016 13:38:03 +0000 Received: from localhost ([127.0.0.1]:36536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSPXO-00033W-Jg for submit@debbugs.gnu.org; Sun, 07 Feb 2016 08:38:03 -0500 Received: from mail-ob0-f180.google.com ([209.85.214.180]:36572) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSPXM-00032w-VP for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 08:38:01 -0500 Received: by mail-ob0-f180.google.com with SMTP id ba1so125607611obb.3 for <22534@debbugs.gnu.org>; Sun, 07 Feb 2016 05:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=6H903yj5h+d9kFCVvK2NnR0ciL/iWEdE8DUtxv+S3mQ=; b=an2pBAWBfqOD6KacPH/S4wWl61Ycti/SNYVGw41t5wOJRLTbf+r74R4oFQ9V3TZ1Th eou0MHst0l6FoPQhIaWvommul8Ui8a5fJx80hp867rOMEJNUZM2i+o9GB9TgiwJUx+a6 +e0eUDbobmDfR6cooP3wW2a/Lyo4AVgfkywixvz5zDPuuQiySFZ5nYRlA7IlTBstjGXF gBcXDBEhd+qQZu4ZA2yWDEKrhzzESfU2LYgZb+302OEvIC6jKMUgM136wZGvtuvloDjV rjpFdhkbxN0FF/CLZKYuTnCELTojlgrX9TA+nXbuzRwnS9143gA2RzaL2VfTEX5ou1fg +hbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=6H903yj5h+d9kFCVvK2NnR0ciL/iWEdE8DUtxv+S3mQ=; b=e7K2WbSu/0ZowXsfkNxybjFtEvtgbKb6x0qpZSvwIDsoyyjNb0MGaZGF+IzZAkoEBt aJJDUolQTfR4TYEh4mTme52aajQAnjnObhKQUOgnIUCUIDWKhuYEXSEtER4E1TF7bimi 8KFXATbGAtrfStUyauTw6ZYJgUlNIfZvEICVHFjrM2kn+xXVZJXlBdbTPkhPHC3WO9dI 5npgV4OjlQgYCE00tv0tOj8xQy1shiMRGPu8ZK6l8wPHSDrn23Tas6jH7IJ06dvHGvc9 B5uQ7wlJEYw38vuO1a7ce38+eGsqPZ4usaIk58u0xWrznnbzPYfANkCP53fJdCkfRKaE 8oUA== X-Gm-Message-State: AG10YOR68aMgmy2M6p6DxfaXU78r3BZVSxftnbn161LYEpzVYKZtBgr7sq8nuYuEUVAg1MNCzwfVc0dAy4bMig== X-Received: by 10.182.86.98 with SMTP id o2mr4248342obz.27.1454852274321; Sun, 07 Feb 2016 05:37:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.75 with HTTP; Sun, 7 Feb 2016 05:37:34 -0800 (PST) In-Reply-To: <83r3gpsjey.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> From: Fabrice Popineau Date: Sun, 7 Feb 2016 14:37:34 +0100 Message-ID: Content-Type: multipart/alternative; boundary=089e0149d02003007d052b2e312f X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e0149d02003007d052b2e312f Content-Type: text/plain; charset=UTF-8 The situation has improved especially with file-notify-test06-many-events, but I still see problems in batch mode. The remaining problems are in file-notify-test02-events. In the 'check for attribute change', I see only 2 'changed' notifications, and not 4 as expected by the test (around line 512: w32notify does not distinguish between 'changed' and 'attribute-changed'). So I need to apply : diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index 5fc4ff8..943bd7e 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -507,7 +512,7 @@ file-notify--test-with-events ;; w32notify does not distinguish between `changed' and ;; `attribute-changed'. ((string-equal (file-notify--test-library) "w32notify") - '(changed changed changed changed)) + '(changed changed)) ;; For kqueue and in the remote case, `write-region' ;; raises also an `attribute-changed' event. ((or (string-equal (file-notify--test-library) "kqueue") For the rest of this test, whereas the test passes in interactive mode, it fails in batch mode with several 'deleted' notifications. Namely, I need to apply the following for the test to pass. diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index 5fc4ff8..943bd7e 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -396,7 +397,8 @@ file-notify--test-with-events ;; w32notify does raise a `stopped' event when a ;; watched directory is deleted. ((string-equal (file-notify--test-library) "w32notify") - '(created changed deleted)) + '(created changed ; deleted + )) ;; cygwin recognizes only `deleted' and `stopped' events. ((eq system-type 'cygwin) '(deleted stopped)) @@ -430,7 +432,8 @@ file-notify--test-with-events ;; `attribute-changed'. ((string-equal (file-notify--test-library) "w32notify") '(created changed created changed changed changed changed - deleted deleted)) + ;; deleted deleted + )) ;; cygwin recognizes only `deleted' and `stopped' events. ((eq system-type 'cygwin) '(deleted stopped)) @@ -479,6 +482,8 @@ file-notify--test-with-events ;; the directory. Except for kqueue. ((string-equal (file-notify--test-library) "kqueue") '(created changed renamed deleted stopped)) + ((string-equal (file-notify--test-library) "w32notify") + '(created changed renamed)) (t '(created changed renamed deleted deleted stopped))) (read-event nil nil 0.1) (write-region Fabrice 2016-02-06 20:55 GMT+01:00 Eli Zaretskii : > > From: Michael Albinus > > Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com > > Date: Sat, 06 Feb 2016 20:24:32 +0100 > > > > Please install the patch > > Done. > --089e0149d02003007d052b2e312f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The situation has improved especially with=C2=A0file-notif= y-test06-many-events, but I still see problems in batch mode.
The remai= ning problems are in file-notify-test02-events.

In= the 'check for attribute change', I see only 2 'changed' n= otifications, and not 4
as expected by the test (around line 512:= w32notify does not distinguish between=C2=A0
'changed' a= nd 'attribute-changed').

So I need to appl= y :

diff --git a/test/automated/file-notify-t= ests.el b/test/automated/file-notify-tests.el
index 5fc4ff8..943b= d7e 100644
--- a/test/automated/file-notify-tests.el
++= + b/test/automated/file-notify-tests.el
@@ -507,7 +512,7 @@ file-= notify--test-with-events
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 ;; w32notify does not distinguish between `changed'= ; and
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; = `attribute-changed'.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ((string-equal (file-notify--test-library) "w32notif= y")
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '= (changed changed changed changed))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 '(changed changed))
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; For kqueue and in the remote case, `= write-region'
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 ;; raises also an `attribute-changed' event.
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((or (string-equal (fi= le-notify--test-library) "kqueue")

For the rest of this test, whereas the test passes in interactive mode, it= fails in batch mode with
several 'deleted' notifications= . Namely, I need to apply the following for the test to pass.
diff --git a/test/automated/file-notify-tests.el b/test/automat= ed/file-notify-tests.el
index 5fc4ff8..943bd7e 100644
-= -- a/test/automated/file-notify-tests.el
+++ b/test/automated/fil= e-notify-tests.el
@@ -396,7 +397,8 @@ file-notify--test-with-even= ts
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;;= w32notify does raise a `stopped' event when a
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; watched directory is deleted.<= /div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((string-= equal (file-notify--test-library) "w32notify")
- =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created changed deleted))<= /div>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created = changed ; deleted
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0))
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; cygwin recognizes only `deleted&#= 39; and `stopped' events.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 ((eq system-type 'cygwin)
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(deleted stopped))
@@ -430,7 +432,8 @@ file-notify--test-with-events
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; `attribute-changed'.
=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((string-equal= (file-notify--test-library) "w32notify")
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created changed created ch= anged changed changed changed
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 deleted deleted))
+ =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; de= leted deleted
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0))
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; cygwin recognizes only `deleted' = and `stopped' events.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ((eq system-type 'cygwin)
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(deleted stopped))
@@= -479,6 +482,8 @@ file-notify--test-with-events
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; the directory.=C2=A0 Except for k= queue.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((= string-equal (file-notify--test-library) "kqueue")
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created changed = renamed deleted stopped))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ((string-equal (file-notify--test-library) "w32notify&qu= ot;)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(cre= ated changed renamed))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 (t '(created changed renamed deleted deleted stopped)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(read-event nil ni= l 0.1)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(write-reg= ion
=C2=A0

Fabrice

2016-02-06 20:55 GMT+01= :00 Eli Zaretskii <eliz@gnu.org>:
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 22534@debbugs.gnu.org= ,=C2=A0 fabrice.popineau@gmai= l.com
> Date: Sat, 06 Feb 2016 20:24:32 +0100
>
> Please install the patch

Done.

--089e0149d02003007d052b2e312f-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14548671998023 (code B ref 22534); Sun, 07 Feb 2016 17:47:02 +0000 Received: (at 22534) by debbugs.gnu.org; 7 Feb 2016 17:46:39 +0000 Received: from localhost ([127.0.0.1]:37414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSTPy-00025L-UH for submit@debbugs.gnu.org; Sun, 07 Feb 2016 12:46:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48682) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSTPx-000258-NL for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 12:46:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSTPp-0000gc-Ct for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 12:46:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTPp-0000gY-9I; Sun, 07 Feb 2016 12:46:29 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4098 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aSTPn-0007HR-6f; Sun, 07 Feb 2016 12:46:27 -0500 Date: Sun, 07 Feb 2016 19:46:07 +0200 Message-Id: <83a8ncs9b4.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Sun, 7 Feb 2016 14:37:34 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Fabrice Popineau > Date: Sun, 7 Feb 2016 14:37:34 +0100 > Cc: Michael Albinus , 22534@debbugs.gnu.org > > In the 'check for attribute change', I see only 2 'changed' notifications, and not 4 > as expected by the test (around line 512: w32notify does not distinguish between > 'changed' and 'attribute-changed'). > > So I need to apply : > > diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el > index 5fc4ff8..943bd7e 100644 > --- a/test/automated/file-notify-tests.el > +++ b/test/automated/file-notify-tests.el > @@ -507,7 +512,7 @@ file-notify--test-with-events > ;; w32notify does not distinguish between `changed' and > ;; `attribute-changed'. > ((string-equal (file-notify--test-library) "w32notify") > - '(changed changed changed changed)) > + '(changed changed)) > ;; For kqueue and in the remote case, `write-region' > ;; raises also an `attribute-changed' event. > ((or (string-equal (file-notify--test-library) "kqueue") Can you instrument filenotify.el to show the w32notify events this test generates, complete with the corresponding file names? I will then compare to what I see here. > For the rest of this test, whereas the test passes in interactive mode, it fails in batch mode with > several 'deleted' notifications. Namely, I need to apply the following for the test to pass. Does it help to add a call to (read-event nil nil 0.1) after the code that invokes the deletion in each of these cases? From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 18:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Fabrice Popineau Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145487028719082 (code B ref 22534); Sun, 07 Feb 2016 18:39:01 +0000 Received: (at 22534) by debbugs.gnu.org; 7 Feb 2016 18:38:07 +0000 Received: from localhost ([127.0.0.1]:37470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSUDn-0004xi-1n for submit@debbugs.gnu.org; Sun, 07 Feb 2016 13:38:07 -0500 Received: from mout.gmx.net ([212.227.17.20]:54471) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSUDl-0004xC-8V for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 13:38:05 -0500 Received: from detlef.gmx.de ([87.146.58.109]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MWkZL-1aYN0H0cBv-00XwBx; Sun, 07 Feb 2016 19:37:58 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> Date: Sun, 07 Feb 2016 19:37:56 +0100 In-Reply-To: <83a8ncs9b4.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Feb 2016 19:46:07 +0200") Message-ID: <87lh6ws6wr.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:6Oy7Hm9gNyXTXwo0MaLN5ReZqyvPQsdA6bq/q+lsSEkCmJOSARy EOzZs7ph0Y8eXPCdn6cBaWagk5156XLCH+uEIyTcAln+lFPMBjsU5kgALxwYjDZFekHy1Tq tHfA3LIFue+bckSARSsnNSxDQA77Y1px2Z0+NBu/yAP3kNcrSupIq5PZ5pvIlLBRhl2psG2 7j9xeYD9/smBtPTuTdSqA== X-UI-Out-Filterresults: notjunk:1;V01:K0:7pyUEVbuXD0=:dXnZNIznB058FGu8mE8r8S kYRGFG53wAutV4pCg6EanKqFWIJD2boUReFnkQ3RqYyVOjcmLBv49S5wculqb+GaRkyZqPIyk xqKXvRM7EIIfbIjcFGHZu4vFfLxCFKlQVS3SUFRct3BVph8QDwYI+Iti419gN1SnWj+fhtHN9 pWC7FX5s8JSQhb7vPTBdg9LH62BpzmXyH/4VuOJXjgIFngOrImWC2paNExID0O+9o/gKTsxhB 7Vy/RKlAdz9o4fdNXqDIKDe7fya6dZPjbWoQSfQw1R8MBgjjChD8sm0/oGZJuIEesKCzQtvEp uGtFun0Uwt6xs82s+zmsmhp9uLrulhzC7MDWajK00RAP2ADOCQk0PPoCY2+O5X8BC0CkmS05Z O3PfeZdhp7aHfZf8edQTJSfBpYUQIQxI7XmkUpbNwIrkovhCfPAuGt0BRpvG3Kg5UkvVdcTKh LUA7XjIE0iGP57XbGr/dUYfA+rENmGU4q9xJKEslOoNbtlqi9nRoIPDSXFC6Jgq+EgKStdWK1 Ivys9NPtQD5tVACz4mfWmZlDoHY2OVQCeVG+NbzjHnrF0mClmtWhUVQ0na0aWajhUnpDxj0Oq kZqwBpv6x+igZkFTyaGKq+p6iAZDg+8mUUzcecT0Edj4XMb5+w8pxFdM8faIWZ8eBU+fCq0ag GAQUxvYf7hqvUMtrFhp4wdN0euDGXlsIBD+2xzdUhq3q0mZrgAjUjUxbDJpWx6PtOSTJRG3gQ 5rEoBaCY95JvOWipYxCB2TQfLC4kjRPD60/nphuHJG1Iz8jrDRvIN/sXZBCCUBUejSbwHzzwa kuAFRCz X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Can you instrument filenotify.el to show the w32notify events this > test generates, complete with the corresponding file names? I will > then compare to what I see here. In file-notify-handle-event, there is a debug message. Uncomment it. >> For the rest of this test, whereas the test passes in interactive >> mode, it fails in batch mode with >> several 'deleted' notifications. Namely, I need to apply the >> following for the test to pass. > > Does it help to add a call to > > (read-event nil nil 0.1) > > after the code that invokes the deletion in each of these cases? Hopefully, I'll have access to an MS Windows machine next week. So I could test in parallel. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 19:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Michael Albinus Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145487367824054 (code B ref 22534); Sun, 07 Feb 2016 19:35:01 +0000 Received: (at 22534) by debbugs.gnu.org; 7 Feb 2016 19:34:38 +0000 Received: from localhost ([127.0.0.1]:37495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSV6T-0006Fo-Ms for submit@debbugs.gnu.org; Sun, 07 Feb 2016 14:34:38 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:32943) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSV6R-0006FX-IT for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 14:34:36 -0500 Received: by mail-ob0-f179.google.com with SMTP id is5so128866930obc.0 for <22534@debbugs.gnu.org>; Sun, 07 Feb 2016 11:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=y+Wit54yTabQU2NOxXO/pFu26F4FczlAyau+BQgZIPs=; b=yAPerKnuX2Etbc55sOIqiBsaWPkXIJlf6a8+qHHFCXS8h/PWKTyYx0GbQjC5CkiREv BG9jUb6NCjY1uEblxKAcErPV9XOLq5ADlLNU0nilzXpJmDZ2xY7akkD0Lic4h+M68yDq NxTZEwxcJGQTTWo+hdXW6BI0Rg/8ZPmM3AGtxgYuCsm199mwrhnLlWComL9QtC1jU2qf j58H0iKDUMUL8QNBOIqxJlFxkZMWS95sKscmCw4/9ljOnRHDBP5IvSXMpchHriZgVGMp e2sPJZ7NeYyoG9p3vrv2gke97+DXLJGxfcC61/PpHTYcqw5qELIjkvfI2NQv3/xi0foC ALrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=y+Wit54yTabQU2NOxXO/pFu26F4FczlAyau+BQgZIPs=; b=Bss2be+uuHGAFv4IkF8XZVQUKWHlkEagvKMwf1DqKFlEgR6jGiWkIXpFzDBSBmd0gA zcIgzUnM9g7g0ljMuJzh2KX+7G7O69l4cqLRFFI2dzR81ucHl8F3tzVIQ88h6I3U/k24 KZJzEyYpd4L5IE3BPIykuLXPATFuNtvxRLk1eYpbA6mO46pXswImidyuipRrgAyN2F6P eWGJHARHEDYPAx+CXQFBb9YfF2xEWJBtevsyZ/wnsElGqufOIiHW++4bgI7PZmjdgBbO BVrxzwviQ+AmgiPHvy/t//EpiMDHAaTjWLVjm0SSrBqvzQE1egC4mGCaO5KbSb+6GUL0 +uQQ== X-Gm-Message-State: AG10YOSLBnNX7Dc4lc9YLMDNduTDBVh3mJN9Lxg0jW+2zhmhy/U0Sx/HHqr72FJxP3mfQYyZ8nqtahtuHVjP/w== X-Received: by 10.60.67.71 with SMTP id l7mr13994786oet.55.1454873670072; Sun, 07 Feb 2016 11:34:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.75 with HTTP; Sun, 7 Feb 2016 11:34:10 -0800 (PST) In-Reply-To: <83a8ncs9b4.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> From: Fabrice Popineau Date: Sun, 7 Feb 2016 20:34:10 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a11c30ba04c401e052b332c02 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c30ba04c401e052b332c02 Content-Type: text/plain; charset=UTF-8 2016-02-07 18:46 GMT+01:00 Eli Zaretskii : > > From: Fabrice Popineau > > Date: Sun, 7 Feb 2016 14:37:34 +0100 > > Cc: Michael Albinus , 22534@debbugs.gnu.org > > > > In the 'check for attribute change', I see only 2 'changed' > notifications, and not 4 > > as expected by the test (around line 512: w32notify does not distinguish > between > > 'changed' and 'attribute-changed'). > > > > So I need to apply : > > > > diff --git a/test/automated/file-notify-tests.el > b/test/automated/file-notify-tests.el > > index 5fc4ff8..943bd7e 100644 > > --- a/test/automated/file-notify-tests.el > > +++ b/test/automated/file-notify-tests.el > > @@ -507,7 +512,7 @@ file-notify--test-with-events > > ;; w32notify does not distinguish between `changed' and > > ;; `attribute-changed'. > > ((string-equal (file-notify--test-library) "w32notify") > > - '(changed changed changed changed)) > > + '(changed changed)) > > ;; For kqueue and in the remote case, `write-region' > > ;; raises also an `attribute-changed' event. > > ((or (string-equal (file-notify--test-library) "kqueue") > > Can you instrument filenotify.el to show the w32notify events this > test generates, complete with the corresponding file names? I will > then compare to what I see here. > > I printed the expected notifications and the ones that occur: Library: `w32notify' passed 1/6 file-notify-test00-availability passed 2/6 file-notify-test01-add-watch events: ((created changed deleted stopped)) ((17923488 created c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748mQW) (17923488 changed c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748mQW) (17923488 deleted c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748mQW) (17923488 stopped c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748mQW)) events: ((changed changed deleted stopped)) ((17490424 changed c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748zac) (17490424 changed c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748zac) (17490424 deleted c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748zac) (17490424 stopped c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748zac)) events: ((created changed deleted)) ((17491048 created c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo) (17491048 changed c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo)) Test file-notify-test02-events backtrace: #[0 "\306\307\310C\307C\3111(\312\313\314\315$\317\"\32 ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test file-notify-test02-events "Check fi ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes ert-run-tests((not (tag :expensive-test)) #[385 "\306\307\"\203G\2 ert-run-tests-batch((not (tag :expensive-test))) ert-run-tests-batch-and-exit((not (tag :expensive-test))) eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test) command-line-1(("-L" ";../../../emacs/test/automated" "-l" "ert" "-l command-line() normal-top-level() Test file-notify-test02-events condition: (ert-test-failed ((should (dolist (elt events result) (setq result ...))) :form (let ((--dolist-tail-- events)) (while --dolist-tail-- (let ... ... ...)) result) :value nil)) FAILED 3/6 file-notify-test02-events Reverting buffer `file-notify-test20748a5u'. passed 4/6 file-notify-test03-autorevert events: ((changed changed deleted stopped)) ((19211556 changed c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE) (19211556 changed c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE) (19211556 deleted c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE) (19211556 stopped c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE)) passed 5/6 file-notify-test04-file-validity passed 6/6 file-notify-test05-dir-validity > > For the rest of this test, whereas the test passes in interactive mode, > it fails in batch mode with > > several 'deleted' notifications. Namely, I need to apply the following > for the test to pass. > > Does it help to add a call to > > (read-event nil nil 0.1) > > after the code that invokes the deletion in each of these cases? > I have added this wait time after each delete-directory call in file-notify-test02-events with no difference. I must add that the same test works interactively. It is only in batch mode that I don't see the deleted notifications. Fabrice --001a11c30ba04c401e052b332c02 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-07 18:46 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
=
> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Sun, 7 Feb 2016 14:37:34 +0100
> Cc: Michael Albinus <michael.albinus@gmx.de>, 22534@debbugs.gnu.org
>
> In the 'check for attribute change', I= see only 2 'changed' notifications, and not 4
> as expected by the test (around line 512: w32notify does not distingui= sh between
> 'changed' and 'attribute-changed').
>
> So I need to apply :
>
> diff --git a/test/automated/file-notify-tests.el b/test/automated/file= -notify-tests.el
> index 5fc4ff8..943bd7e 100644
> --- a/test/automated/file-notify-tests.el
> +++ b/test/automated/file-notify-tests.el
> @@ -507,7 +512,7 @@ file-notify--test-with-events
> ;; w32notify does not distinguish between `changed' and
> ;; `attribute-changed'.
> ((string-equal (file-notify--test-library) "w32notify")
> - '(changed changed changed changed))
> + '(changed changed))
> ;; For kqueue and in the remote case, `write-region'
> ;; raises also an `attribute-changed' event.
> ((or (string-equal (file-notify--test-library) "kqueue")

Can you instrument filenotify.el to show the w32notify events this test generates, complete with the corresponding file names?=C2=A0 I will then compare to what I see here.


I printed the = expected notifications and the ones that occur:

Li= brary: `w32notify'
=C2=A0 =C2=A0passed =C2=A01/6 =C2=A0file-n= otify-test00-availability
=C2=A0 =C2=A0passed =C2=A02/6 =C2=A0fil= e-notify-test01-add-watch
events: ((created changed deleted stopp= ed)) ((17923488 created c:/Users/Fabrice/AppData/Local/Temp/file-notify-tes= t20748mQW) (17923488 changed c:/Users/Fabrice/AppData/Local/Temp/file-notif= y-test20748mQW) (17923488 deleted c:/Users/Fabrice/AppData/Local/Temp/file-= notify-test20748mQW) (17923488 stopped c:/Users/Fabrice/AppData/Local/Temp/= file-notify-test20748mQW))
events: ((changed changed deleted stop= ped)) ((17490424 changed c:/Users/Fabrice/AppData/Local/Temp/file-notify-te= st20748zac) (17490424 changed c:/Users/Fabrice/AppData/Local/Temp/file-noti= fy-test20748zac) (17490424 deleted c:/Users/Fabrice/AppData/Local/Temp/file= -notify-test20748zac) (17490424 stopped c:/Users/Fabrice/AppData/Local/Temp= /file-notify-test20748zac))
events: ((created changed deleted)) (= (17491048 created c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-pare= nt20748Ali/file-notify-test20748Nvo) (17491048 changed c:/Users/Fabrice/App= Data/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo))<= /div>
Test file-notify-test02-events backtrace:
=C2=A0 #[0 &q= uot;\306\307\310C\307C\3111(\312\313\314\315$\317\"\32
=C2= =A0 ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
=C2=A0 ert-run-test([cl-struct-ert-test file-notify-test02-events &= quot;Check fi
=C2=A0 ert-run-or-rerun-test([cl-struct-ert--stats = (not (tag :expensive-tes
=C2=A0 ert-run-tests((not (tag :expensiv= e-test)) #[385 "\306\307\"\203G\2
=C2=A0 ert-run-tests-= batch((not (tag :expensive-test)))
=C2=A0 ert-run-tests-batch-and= -exit((not (tag :expensive-test)))
=C2=A0 eval((ert-run-tests-bat= ch-and-exit (quote (not (tag :expensive-test)
=C2=A0 command-line= -1(("-L" ";../../../emacs/test/automated" "-l"= ; "ert" "-l
=C2=A0 command-line()
=C2=A0= normal-top-level()
Test file-notify-test02-events condition:
=C2=A0 =C2=A0 (ert-test-failed
=C2=A0 =C2=A0 =C2=A0((shoul= d
=C2=A0 =C2=A0 =C2=A0 =C2=A0(dolist
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(elt events result)
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0(setq result ...)))
=C2=A0 =C2=A0 =C2=A0 :form
=
=C2=A0 =C2=A0 =C2=A0 (let
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= ((--dolist-tail-- events))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (while --= dolist-tail--
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ... ... ...= ))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 result)
=C2=A0 =C2=A0 = =C2=A0 :value nil))
=C2=A0 =C2=A0FAILED =C2=A03/6 =C2=A0file-noti= fy-test02-events
Reverting buffer `file-notify-test20748a5u'.=
=C2=A0 =C2=A0passed =C2=A04/6 =C2=A0file-notify-test03-autorever= t
events: ((changed changed deleted stopped)) ((19211556 changed = c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE) (19211556 cha= nged c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE) (1921155= 6 deleted c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE) (19= 211556 stopped c:/Users/Fabrice/AppData/Local/Temp/file-notify-test20748ZNE= ))
=C2=A0 =C2=A0passed =C2=A05/6 =C2=A0file-notify-test04-file-va= lidity
=C2=A0 =C2=A0passed =C2=A06/6 =C2=A0file-notify-test05-dir= -validity
=C2=A0
> For the rest of this test, whereas the test passes in interactive mode= , it fails in batch mode with
> several 'deleted' notifications. Namely, I need to apply the f= ollowing for the test to pass.

Does it help to add a call to

=C2=A0 (read-event nil nil 0.1)

after the code that invokes the deletion in each of these cases?

I have added this w= ait time after each delete-directory call in file-notify-test02-events
with no difference.

I must add that the same test wor= ks interactively.=C2=A0
It is only in batch= mode that I don't see the deleted notifications.


Fabrice


--001a11c30ba04c401e052b332c02-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 10:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145492688213925 (code B ref 22534); Mon, 08 Feb 2016 10:22:02 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 10:21:22 +0000 Received: from localhost ([127.0.0.1]:38011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSiwc-0003cX-5Z for submit@debbugs.gnu.org; Mon, 08 Feb 2016 05:21:22 -0500 Received: from mout.gmx.net ([212.227.15.19]:60755) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSiwa-0003cK-2c for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 05:21:20 -0500 Received: from detlef.gmx.de ([87.146.47.108]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LbM2k-1ZjArD2yz4-00kwcN; Mon, 08 Feb 2016 11:21:13 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> Date: Mon, 08 Feb 2016 11:21:12 +0100 In-Reply-To: (Fabrice Popineau's message of "Sun, 7 Feb 2016 14:37:34 +0100") Message-ID: <8760xzwlif.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:3uSmiRmiItWk5c7FiECS2KFojYA3vuNOI6iwv23tP92BbeQLOY9 BYjd09VX+LnrQ++O9g/ODDQjo3dtAZOMy1NFkQT3RdMZmV6kcQRwYw+zjxGYOn3OyneCrxY n+iXOI9p2iXhiQL8NY8H7DinS7JxinRf1bKn4qlnudPSxiwtsWhKDHH9s9bsFfw0NwvJM5F 8B/t98PFC9uamPPwU+T9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:beF+wf1Huyo=:DtfRLZMeYveRj32Ba07BDZ Uul5sQXLsMXhrRSmWBlmolvmK8Fa/hb6VnxJFTbRjcWsrUx9Xv0kaisv3bguxtBrtt9o25Sbn Z30iw/9M9aEcNJy/JP8uf2DeWs07T2PEr6tatSvj/JqgzkOb5zG4WrD1fhAk+Y/GxHqklYl4f ccvS70CyTFJuDQjGU8UOMq0rsBgyLboEQVAgKM0ua3D0IDIcKHN8TFa1ft/CiaNldT9I4mZvP KItlqxUgnHx038VUP/T1LerwKbr8XTKOD8zsyvBiiPnsX7U0HAb4DZbHqZuugXW7ZxZzqWmGR xF+1Pi98xLzxTVMBiFemuX7ClHg2OzdFpM2NsVi761sYdIzResRiDc11sd6Yz6KGtD7fOr0PT beEIUkp4NLThUIvGuWO20CXLLCHKA1ieAnnJhV/qUYZvW5w8mMs52voTG8jgKcMlcYhth/CdK uT29Iz24VuPXqIOv15w+YdB+zQC2R29DMK1g3HYcnx8nK+xJGcILlWJC+1V9nwYETngXOIfBV aWeBmSB2i58f/b+pXqMnUgOQ0LN5xHuDTp9iFww6izLuTjk+a0zOQJE/vVbyjgXMYQletISca puUHi32jzctpShUjGV2aA3W6IoOzkYPxw2rGsN9jpFIMe1kWrIn8C2YqIowD0JwGDs/A+1xxW ne/MKJl07YPboJYTVtn4n7GheXjlieRyc80FQ2vTAsyL+fN/gKx7f8MZARnvj9wND+RmZFPvE GKWhyOOxoONRMAtuHJKqDu8GR5e+PUt7agDCHTdkLU4nVMHrTwtVqaiNWS5YK7F7Ug9ueB5qC BBQVXIQ X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fabrice Popineau writes: > In the 'check for attribute change', I see only 2 'changed' > notifications, and not 4 > as expected by the test (around line 512: w32notify does not > distinguish between > 'changed' and 'attribute-changed'). I cannot confirm this, it works for me. I'm running the test on a Windows 7 machine using Emacs build "GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2016-01-29", the one provided by Dani Moncayo, plus the updated filenotify.el and file-notify-tests.el. Do you run Windows 10? Something else different? > Fabrice Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 10:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145492725814443 (code B ref 22534); Mon, 08 Feb 2016 10:28:01 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 10:27:38 +0000 Received: from localhost ([127.0.0.1]:38015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSj2f-0003kt-R7 for submit@debbugs.gnu.org; Mon, 08 Feb 2016 05:27:37 -0500 Received: from mout.gmx.net ([212.227.15.18]:62533) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSj2d-0003kf-Ny for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 05:27:36 -0500 Received: from detlef.gmx.de ([87.146.47.108]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LyEqr-1ZzLeu0KAv-015dO6; Mon, 08 Feb 2016 11:27:29 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> Date: Mon, 08 Feb 2016 11:27:27 +0100 In-Reply-To: (Fabrice Popineau's message of "Sun, 7 Feb 2016 20:34:10 +0100") Message-ID: <871t8nwl80.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:Im8bxPrp/NIcgAUp50CYsE1wgpY9MhbgdhpOps4FPne0bQKFC4l 7q0HYTJ/aVL0EVIrwpUg3UN5DyePH3/lk3Q98NV9jcXLq7vHsOXZFZ8/8vMlILIRxZ8phHa dHPxbI7yaFvJhHJRaEmoPbdxX3yYj54nHmHt8UK7qfNXFGRRAWeYecMPnKUaIgh/wgWFvzG DF0Y46y45egOBHxr8TpOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:RbmBh5FDCOU=:FsQcE1IjiVmD8pMzosUxv8 ZD7z46YRyBGhArJohoDm0q0zdE8dkci1+Q71fPRiSLh+RcsSkZ6/a36RIThYSnl9PQK9MDjrf Yc4KLuh7wuuNK/i4/dvNFHIstROQBHmvyziZhjQVYqn95U/MOz9c8bFpYNk/4ALyE7D3Whrn1 rbs40HbAfcrXLsleVMjJARL4tc/mfVTdxaMZX3GgAMAhEMYd+PvheisfP+0exIZBE1UuPqbTl dbcmtjqW6K4ju8vU2gv31RYAmuemoUISl/3hXgLNWw9ZSj1dlvMd1HrkKDdhmuKlRqmZvDTxO NZFn+HbuOdrQLll0PBnG1PJ3nO+s2PZFNmRmc3mRFxTQTHgpuOKYtpMm//Kyr2eaZhsYwzJuI nEF8Ir8Po29kcAW/q+s4FePiWZTBUHjIdgV0kfUVH+e0cr4YCxZ4fmSfZEtqqAOfi6Qg2uhmX r5NoqYNJN9RaBGf/CbP42zgQBAJc5LvfsDoDgmlJ9kvbtCgReQ5QnY/5wu9Gcby3yQEHKy0ld RZE3DGbsU6lxljQ546bulcoiIjX77LuvfdYx5oCRuAguVquTrRQ8Vh9F4lQzvD0MHVtvwbJ9L pYeFIr2mU6pmyBxH1wXcN1zKpjl3XWwOhYJUY1nr/6Mz7xL3AtoVxW/+9E813SbgQTaCcWBGt QjaGY5ff47l0vBV64NUmym8tAfzNPbCV1z62ipAMlOAb5FHhIqESj0Yc9ZcaBMEm/g5l9Wgy5 LMAv4lekkk1CdrinyEv8r78AIey1vXk7RgR2Jhf+GvlbgdBhwuhk/GcRqNmc7ebTvTSRKlGtH BKEyd35 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fabrice Popineau writes: > events: ((created changed deleted)) ((17491048 created > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo) > (17491048 changed > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo)) Fails also for me in batch mode. Surprisingly, it doesn't fail always, sometimes (about 1 in 10 runs) it succeeds here, and fails in the next step. Strange. If we do not care the missing `deleted' event in batch mode, I could make it optional in the test. But maybe it is an indication for a serious problem in w32notify. Eli? > I must add that the same test works interactively. > It is only in batch mode that I don't see the deleted notifications. Same here. > Fabrice Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 10:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145492803815584 (code B ref 22534); Mon, 08 Feb 2016 10:41:01 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 10:40:38 +0000 Received: from localhost ([127.0.0.1]:38031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSjFG-00043I-3E for submit@debbugs.gnu.org; Mon, 08 Feb 2016 05:40:38 -0500 Received: from mail-ob0-f178.google.com ([209.85.214.178]:34791) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSjFE-000434-An for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 05:40:36 -0500 Received: by mail-ob0-f178.google.com with SMTP id wb13so148372820obb.1 for <22534@debbugs.gnu.org>; Mon, 08 Feb 2016 02:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Ezmc+zWo14sZx6A81rJtYqkgistlmuXbufSsVIFU/Uo=; b=0U/Wzzg87IHxaDNszqi/T4R/Rw7Wjm8x4Oov+DxI0eJ2OSAGH2dzFfi+fBqLABsuew yt9H6WACdQeVTTmGLq/sMAVKE/BPSHF5MCCJUD1wmrKIPl3HB9M9cJ8URYjpDX47L5ND GdB32E136+2857QsGw2he8V246H2wpPGGluU1EouDA0WGVbn+JM/0O7a8ZCYBr2lZWKt 7/VkzG6OqU1pzmGpErng5sooPiViX9nxADmSHp+70gkfEtjr0AjTn5FGnnhuGz8IK+T0 ECqxkS+KWNRJsVFg6rUmSbfllgonOWRmZcqgr0C57GCnkiwZ5OmeddCBweVXlW1eWM/B 9ReQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Ezmc+zWo14sZx6A81rJtYqkgistlmuXbufSsVIFU/Uo=; b=f1v8G8mbA9U2Tb/9xn3Q3gPEsiCjLNl9c4xJ9tOXSt9gclaeqiuEhTiL+hG0ZkKwJD Fop6YnAmjrbdFYc4ynrYZ2QlH/cT1ACS8QdfvlMLG53ruLkATkwtygx12cgTxpcH/mcW 5lsCwHOuIuRxwCz8J69/o2CTL1Zd3uxuD1ESiKj8u94SPKR49vJyhZ20U6GuV1kFFtcQ 42rEVc4P8Q4CBJqWJNN8+a5ZA9cLdPOzTh/3BK+LZhz1wyo2Y5iWSCBvMlxZI8g+MALC e9v0oownO2dLpMXmzNGaOPXpT/0Z7Jv40SsoipGFaHa4+Xl4lRFdBYTcY/289hU25RcQ 55PQ== X-Gm-Message-State: AG10YOQfOIGCEhKjkC2LQPZV4fqssBmLKZlGvMhDaUTIHm4zEodHXxP4aJ2PEnbV0y9cKS3REf6BJtqbq3fTKw== X-Received: by 10.60.227.74 with SMTP id ry10mr23516680oec.48.1454928030852; Mon, 08 Feb 2016 02:40:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.75 with HTTP; Mon, 8 Feb 2016 02:40:11 -0800 (PST) In-Reply-To: <8760xzwlif.fsf@gmx.de> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <8760xzwlif.fsf@gmx.de> From: Fabrice Popineau Date: Mon, 8 Feb 2016 11:40:11 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a1136935e73f0d3052b3fd431 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1136935e73f0d3052b3fd431 Content-Type: text/plain; charset=UTF-8 2016-02-08 11:21 GMT+01:00 Michael Albinus : > Fabrice Popineau writes: > > > In the 'check for attribute change', I see only 2 'changed' > > notifications, and not 4 > > as expected by the test (around line 512: w32notify does not > > distinguish between > > 'changed' and 'attribute-changed'). > > I cannot confirm this, it works for me. I'm running the test on a > Windows 7 machine using Emacs build "GNU Emacs 25.0.50.1 > (i686-pc-mingw32) of 2016-01-29", the one provided by Dani Moncayo, plus > the updated filenotify.el and file-notify-tests.el. > > Ok, I may have been mistaken. At the moment, I see the 4 notifications. > Do you run Windows 10? Something else different? > > Windows 10, and I compile with MSys2-MinGW64. Fabrice --001a1136935e73f0d3052b3fd431 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-08 11:21 GMT+01:00 Michael Albinus <michael.albinus@gmx.d= e>:
Fabrice Popineau <fabrice.popineau@gmai= l.com> writes:

> In the 'check for attribute change', I see only 2 'changed= '
> notifications, and not 4
> as expected by the test (around line 512: w32notify does not
> distinguish between
> 'changed' and 'attribute-changed').

I cannot confirm this, it works for me. I'm running the test on = a
Windows 7 machine using Emacs build "GNU Emacs 25.0.50.1
(i686-pc-mingw32) of 2016-01-29", the one provided by Dani Moncayo, pl= us
the updated filenotify.el and file-notify-tests.el.


Ok, I may have been mistaken. At the m= oment, I see the 4 notifications.
=C2=A0
Do you run Windows 10? Something else different?


Windows 10, and I compile with MSys2-M= inGW64.


Fabrice

--001a1136935e73f0d3052b3fd431-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 10:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145492821815860 (code B ref 22534); Mon, 08 Feb 2016 10:44:01 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 10:43:38 +0000 Received: from localhost ([127.0.0.1]:38046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSjI9-00047k-On for submit@debbugs.gnu.org; Mon, 08 Feb 2016 05:43:37 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:33416) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSjI7-00047Y-Mb for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 05:43:36 -0500 Received: by mail-ob0-f179.google.com with SMTP id is5so146233652obc.0 for <22534@debbugs.gnu.org>; Mon, 08 Feb 2016 02:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=CHSrnw1ZvMbDbd91ME8fx7ULNnM64oqPOkq583NWd74=; b=0Nv8L186wW+7+pINYNBp5Q3bj8cyMI5TNqTD6g7ZLQCY2eP4AHXeREQpBBNTOwYq/U Z1qtxD7iOylSwX/jt2BcBJoFB7S9+q2sk09bQZSpt34CixfUxVsqxui+qZKwILVBix2Z JE6+dI/QLp85usY0BRf0Ds4CUoOd9M9AJkRK3uf2IUcdlMkXMsFUUwMdXC1Jewh4NUg+ Uh4sAZ5iY5T/GNz3oST0GeUdcquuNZZNzlz3UH9SLZZL0fMGcl5WVEtxLdu2vfWHG39w eCHpWuJywnD7IqNB+OpSQDiJpSp9bAdGMnzqJPVCync7pqtgJMb8+mALIrnNCRy2J5jp X7Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=CHSrnw1ZvMbDbd91ME8fx7ULNnM64oqPOkq583NWd74=; b=drWuRIXTMB7fYBtAQlpz+zaVEKUMV+9fnVIFCjga8tX43qCvxMCmWhbfRhcyCwCibT 7fsvipeInYwx+GV75lgCRKvEcgPR27pWNyr8UKMcQl5ACTO0wGS6bthl35T5ZeniQVxC yPIHbPUYu61Lg5rjLDSPpDn9SC75FZrzEN45m5IvwxbQJ1lKLV1V753R7b/YN+NHnwYF LrGLtAqpAHs9MLZqrSU9izgDRldEw6HdajBd0ifIbpLNV0mCxUGptzU/RL9Yev2oDiMM 9lX0nqLS6pBP5N2cb//+xXUSeWccDQdA2WcEAC81om6+xQufT0TsS/pAz5GmZFFjtSyG p29w== X-Gm-Message-State: AG10YOTrvAnA3MHPnTbaeelKHwWr3OtrUDqkRWxn/Eckn10KJS1ys20nYMcAm4V51hIxLIcFihX64ZN6PFmriA== X-Received: by 10.60.117.233 with SMTP id kh9mr9935279oeb.23.1454928210348; Mon, 08 Feb 2016 02:43:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.75 with HTTP; Mon, 8 Feb 2016 02:43:10 -0800 (PST) In-Reply-To: <871t8nwl80.fsf@gmx.de> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> From: Fabrice Popineau Date: Mon, 8 Feb 2016 11:43:10 +0100 Message-ID: Content-Type: multipart/alternative; boundary=047d7b3a92a026d12a052b3fdfc6 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b3a92a026d12a052b3fdfc6 Content-Type: text/plain; charset=UTF-8 2016-02-08 11:27 GMT+01:00 Michael Albinus : > Fabrice Popineau writes: > > > events: ((created changed deleted)) ((17491048 created > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo) > > (17491048 changed > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo)) > > Fails also for me in batch mode. Surprisingly, it doesn't fail always, > sometimes (about 1 in 10 runs) it succeeds here, and fails in the next > step. Strange. > > I see the same. The deleted notifications number vary. When you expect 2, sometimes I see 1. When you expect one, sometimes I see it. But not frequently. > If we do not care the missing `deleted' event in batch mode, I could > make it optional in the test. But maybe it is an indication for a > serious problem in w32notify. > > Fabrice --047d7b3a92a026d12a052b3fdfc6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-08 11:27 GMT+01:00 Michael Albinus <michael.albinus@gmx.d= e>:
Fabric= e Popineau <fabrice.popine= au@gmail.com> writes:

> events: ((created changed deleted)) ((17491048 created
> c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/fi= le-notify-test20748Nvo)
> (17491048 changed
> c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/fi= le-notify-test20748Nvo))

Fails also for me in batch mode. Surprisingly, it doesn't fail a= lways,
sometimes (about 1 in 10 runs) it succeeds here, and fails in the next
step. Strange.

I see the same. The deleted notifications number vary= . When you expect 2, sometimes I see 1.
When you expect one, some= times I see it. But not frequently.
=C2=A0
If we do not care the missing `deleted' event in batch mode, I could make it optional in the test. But maybe it is an indication for a
serious problem in w32notify.


Fabrice
--047d7b3a92a026d12a052b3fdfc6-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 18:13:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14549551272377 (code B ref 22534); Mon, 08 Feb 2016 18:13:03 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 18:12:07 +0000 Received: from localhost ([127.0.0.1]:60316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqIB-0000cA-3y for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:12:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43544) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqI8-0000b7-9V for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 13:12:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSqFw-0007cM-O5 for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 13:09:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSqFw-0007cH-KH; Mon, 08 Feb 2016 13:09:48 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1543 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aSqFv-0004n9-S0; Mon, 08 Feb 2016 13:09:48 -0500 Date: Mon, 08 Feb 2016 20:09:32 +0200 Message-Id: <831t8nqdk3.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Mon, 8 Feb 2016 11:43:10 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Fabrice Popineau > Date: Mon, 8 Feb 2016 11:43:10 +0100 > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > > events: ((created changed deleted)) ((17491048 created > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo) > > (17491048 changed > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo)) > > Fails also for me in batch mode. Surprisingly, it doesn't fail always, > sometimes (about 1 in 10 runs) it succeeds here, and fails in the next > step. Strange. > > I see the same. The deleted notifications number vary. When you expect 2, sometimes I see 1. > When you expect one, sometimes I see it. But not frequently. Did you try adding calls to read-event after the functions that are supposed to produce these events? (I didn't yet have time to look into the traces. Will do when I have time.) Btw, is there an easy way of running just one test out of file-notify-test.el? Running all of them takes a long time, especially now that the 06 test is no longer considered "expensive". Thanks. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14549555333192 (code B ref 22534); Mon, 08 Feb 2016 18:19:02 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 18:18:53 +0000 Received: from localhost ([127.0.0.1]:60384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqOj-0000pQ-8p for submit@debbugs.gnu.org; Mon, 08 Feb 2016 13:18:53 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:34881) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSqOh-0000pF-Ks for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 13:18:51 -0500 Received: by mail-ob0-f177.google.com with SMTP id xk3so163830559obc.2 for <22534@debbugs.gnu.org>; Mon, 08 Feb 2016 10:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=jHogx5D2ETOJ5b4g0ozHYn4ymDx1aQqqe9lSfpogXWI=; b=yBkqQtLXh+YD2ENZLKiyQQwh8iDEX+yQvO0mbXNrY5ntY3KSyzzuBGtWMOocQDJz0A 8gm0LBUy605yYOhTduE7MoRjlhvBGBmW4QRvKgVwJApiG8JLnf03s7H6r8RBLMW1BqXd iuMwCWa+tueFy+iOFBu8ZvkQyHmOXjz4mDXi5rrm8VjFOFbqGpVcxNEC1T0mMifcwhNo FxxbajD4O+6mhbGupIA68Wu1iZ+83LfEb7iV0qMu/UnUmbOhYPRFUa9iSr0iBtwyxodq gdtOWGIqjZpmaL65svX+Ee6eh5OQ1gc7/dJMtfaPvNsM3lYQ11i5fmeX/F/hN6qcvx6e xiQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=jHogx5D2ETOJ5b4g0ozHYn4ymDx1aQqqe9lSfpogXWI=; b=iDzNFz6HS8Im4XTBPunHz/WUU6vTQrBqFnFmaqy4hjynO9P46pCacdOJTTH8wV2v9+ xaNt1lbV/GJ6KNdPh3HL0jA5gcHEUqmskQPu8l3nrOargz77pYrUqS+a8YyPeh6gzWru BArHKyoHVZcEyr5Lq7QKsGm2Ean25TrnV0vjUazLkC1nhszi23iHDG+r0EDs8vS+6BIa qpphIU21RlFB43YmtS5e6EqrImOzDhyMrbZZyKoq3Px8WPu6KXOJoSTeR0r6JryfeSwJ tLZOWBxRC2rEXeoRduHcyb9CnEuCTqNPASZ0qwsN4X27TpJZzMzLx3/NlUibUQoXc6Ys XzLw== X-Gm-Message-State: AG10YOSVRAxmYIScKGCgY3wRekIWIu1Rk1lJymlXkRXw/K7cI+dY95/amtId5HPXT9i3dUJRdZGDC1Z2Et8fHQ== X-Received: by 10.60.58.6 with SMTP id m6mr24661908oeq.47.1454942053753; Mon, 08 Feb 2016 06:34:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.75 with HTTP; Mon, 8 Feb 2016 06:33:54 -0800 (PST) In-Reply-To: References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <8760xzwlif.fsf@gmx.de> From: Fabrice Popineau Date: Mon, 8 Feb 2016 15:33:54 +0100 Message-ID: Content-Type: multipart/alternative; boundary=089e015385ac486a89052b4318ef X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) --089e015385ac486a89052b4318ef Content-Type: text/plain; charset=UTF-8 2016-02-08 11:40 GMT+01:00 Fabrice Popineau : > > > 2016-02-08 11:21 GMT+01:00 Michael Albinus : > >> Fabrice Popineau writes: >> >> > In the 'check for attribute change', I see only 2 'changed' >> > notifications, and not 4 >> > as expected by the test (around line 512: w32notify does not >> > distinguish between >> > 'changed' and 'attribute-changed'). >> >> I cannot confirm this, it works for me. I'm running the test on a >> Windows 7 machine using Emacs build "GNU Emacs 25.0.50.1 >> (i686-pc-mingw32) of 2016-01-29", the one provided by Dani Moncayo, plus >> the updated filenotify.el and file-notify-tests.el. >> >> > Ok, I may have been mistaken. At the moment, I see the 4 notifications. > After a couple of test runs, I can confirm that sometimes, only 2 notifications are reported in batch mode. Same problem as with the deleted events. Fabrice --089e015385ac486a89052b4318ef Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-08 11:40 GMT+01:00 Fabrice Popineau <fabrice.popineau= @gmail.com>:


2016-02-08 11:21 GMT+01:00 Michael Albinus <michael.albinus@gm= x.de>:
Fabrice Popineau <fabrice.popineau@g= mail.com> writes:

> In the 'check for attribute change', I see only 2 'changed= '
> notifications, and not 4
> as expected by the test (around line 512: w32notify does not
> distinguish between
> 'changed' and 'attribute-changed').

I cannot confirm this, it works for me. I'm running the test on = a
Windows 7 machine using Emacs build "GNU Emacs 25.0.50.1
(i686-pc-mingw32) of 2016-01-29", the one provided by Dani Moncayo, pl= us
the updated filenotify.el and file-notify-tests.el.


Ok, I may have been mistaken. A= t the moment, I see the 4 notifications.

After a couple of test runs, I can confirm that somet= imes, only 2 notifications are reported
in batch mode. Same probl= em as with the deleted events.=C2=A0

Fabrice
=

--089e015385ac486a89052b4318ef-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 19:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Fabrice Popineau Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145495887214852 (code B ref 22534); Mon, 08 Feb 2016 19:15:01 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 19:14:32 +0000 Received: from localhost ([127.0.0.1]:60481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrGa-0003rU-8L for submit@debbugs.gnu.org; Mon, 08 Feb 2016 14:14:32 -0500 Received: from mout.gmx.net ([212.227.17.20]:50896) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrGY-0003rI-Tt for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 14:14:31 -0500 Received: from detlef.gmx.de ([87.146.47.108]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LoVja-1ZnU6X3sio-00gUdF; Mon, 08 Feb 2016 20:14:24 +0100 From: Michael Albinus References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> Date: Mon, 08 Feb 2016 20:14:22 +0100 In-Reply-To: <831t8nqdk3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Feb 2016 20:09:32 +0200") Message-ID: <87r3gnvwtt.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:PXNDG5z39NPgJqiSrkyBudc8QtaYXtBn3lpKNZlE4buGjGi0F48 ubR3pP+GzY5aqnTJyCHofXmqJkMFiupr7857gs5IAAcU8ZRE8138/FmwVxxl5Hng+OONAG6 N2dk7QP4Ct3aGcVE1uDjfSBrweMMwi7RRF8JMYzR2GHpmgM7peYzYadA2e51i537QrhE7RV sJ+UAARbuZKM/0wYTzBnQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:jUjYo99CzSE=:clGc+ttss9GDjSC+FLPdf3 OoU7T+YnOQRaFg8dE2eCGGwk1mCPwzvGlXcIrNMNM9sOloMPG44BfJl4pMGrSXL2LCnyUPoh1 7mVEZX4MAa4fmDX84W9IpX3+fEG7Q0NTogsjSZSI6G6dphe6k9dFrybfC4ffX4S4bPtG3hfG2 s7rPrW0MdvPJ+hnke7n6D4dEhIM3uCc41rm78ky8Q4uWSPf3kGA1ho+o6o6MpFrqWsVxjc0YQ guFdWd9Rc+IG2nSxV2/HMzT8CLb5V8VUBIsUiG410SLF/ifIXne1AISO/ZpvcDBGe9CeF4txF IrzrvNzF2JkJzWYPUr+2pcQ1KIBAZekNInmUlmbB+7rHQb/AEdVKejWbLOBgm/7vqOaO11lJV QIan10NXjC+lNVxfBMb7s+Cvz1FLNCD+p7AChbzl/qkCzG/T3e5YcAVagJfN6UIxL4oGQohwr tFKiheIlxUeAqqLmtvE0V9q8H45YsTL4XvNufCWgmyAL7B++9lGwsGX1zO0827utLrdASiezt 7kzEvrH8FMsW/SCAjl74fLIvDmeRkJ01KyEez3LzvB5RQU2IlTxulerTpgUgp7QSSh6VoN00+ FsagJk+i4ZuAPoYjweRfM20Ch+wsNHiOGt0Cy7vQuOzDaxn5zDGWlI1MRntWjwnYc4xFfaEAL ovdPUBmJjPhfe28QW9Q6fo5XKXuaCOd0Hmqd4wMC8zYoeA7eynmF3/3qrbW0t178n30RhLoDT DPazE5F7nJvv9vBbBr5RiXKs1cE4y1EqKnjYn7msJP2wpgWeYhv9lVOBu19wp1PPkUj/vYxF5 g5PcBL3 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Btw, is there an easy way of running just one test out of > file-notify-test.el? Running all of them takes a long time, > especially now that the 06 test is no longer considered "expensive". 06 is still expensive, how do you believe it has changed? "make check" knows the SELECTOR variable. You could do # make SELECTOR='(quote (eql file-notify-test02-events))' \ -C test/automated file-notify-tests > Thanks. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Michael Albinus Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145495898615070 (code B ref 22534); Mon, 08 Feb 2016 19:17:01 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 19:16:26 +0000 Received: from localhost ([127.0.0.1]:60486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrIQ-0003uz-Iv for submit@debbugs.gnu.org; Mon, 08 Feb 2016 14:16:26 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:33410) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrIO-0003un-KQ for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 14:16:24 -0500 Received: by mail-ob0-f175.google.com with SMTP id is5so164425280obc.0 for <22534@debbugs.gnu.org>; Mon, 08 Feb 2016 11:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=LjRcpbhn5atMl85I53If0arB1cwcfZA1MLHpVITfGNI=; b=htuCbp0lyre8Ca0VKPkQhjLoI/Z+UAebjuhRdviLNxvGNmk1NHO9RuUlQCnx+MW4gk HOEE8YZZy1uu4LDDe36Ek5YmCISBou1ica+9rIjS1PwGhRmLIE90qXshqaXELHyC0jfv K9OnJRxPdmfdhnOZj9wMmKOl9NSog2WpDuNdAFbukB/OrmDWXwvgz3dCh8Eyz1W66W5/ i38dHqAz8/eNRgbPPAO++y2Bw4eyn92u7kKKzcV1vtdLi3i7sArYDrNgHKYyIIv3KPgA KfwosrHOkeu//dyNugexNJcYsDpTOhe0Y6KNX+3o79P8FJq66V8yspExFHTjhKhHZrdX fo4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=LjRcpbhn5atMl85I53If0arB1cwcfZA1MLHpVITfGNI=; b=aNmrx2xxdtiX2j1q5OCIp0CoxrzfyXqGVTNODHDJf+F1cFjAePMB4Z9nsZrad8Rjmd 6VALREx2qjfQXlo+94TKZ3djDNYCqPxeB+F7NiIqpwRYefqpncZ2tZmo9rHN7LV354xf NrO4aOWH09Ij3AZauohKhsZqDMOel34e2+2L+gCWX6hf7lr7AWmVKE0CSaf/DmUSESxv mnZAYIA9D6cTUIspQ7JLoo6vQ4GuD5lr6DvDOEABCexqP1fUX8WjrJziVFX9CsxbCnCc LMxETTG5qutkebp8SCXlPZDCkefZGyvBo5V8WNqwU1mrvcZLVAv4uSzFKnFbspmrBsyE 5e5w== X-Gm-Message-State: AG10YOTs1xJykIzGgOkK7kE88vxuG6v0P8a9OO+1i7+H8/21Ewtee9pJnivLX7yjUbTUfTBAbgMHj0Ldl9yPyA== X-Received: by 10.60.67.71 with SMTP id l7mr20147164oet.55.1454958979226; Mon, 08 Feb 2016 11:16:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.75 with HTTP; Mon, 8 Feb 2016 11:15:59 -0800 (PST) In-Reply-To: <831t8nqdk3.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> From: Fabrice Popineau Date: Mon, 8 Feb 2016 20:15:59 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a11c30ba01ea7b1052b47092c X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c30ba01ea7b1052b47092c Content-Type: text/plain; charset=UTF-8 2016-02-08 19:09 GMT+01:00 Eli Zaretskii : > > From: Fabrice Popineau > > Date: Mon, 8 Feb 2016 11:43:10 +0100 > > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > > > > events: ((created changed deleted)) ((17491048 created > > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo) > > > (17491048 changed > > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo)) > > > > Fails also for me in batch mode. Surprisingly, it doesn't fail always, > > sometimes (about 1 in 10 runs) it succeeds here, and fails in the next > > step. Strange. > > > > I see the same. The deleted notifications number vary. When you expect > 2, sometimes I see 1. > > When you expect one, sometimes I see it. But not frequently. > > Did you try adding calls to read-event after the functions that are > supposed to produce these events? > > Yes, but with no results. --001a11c30ba01ea7b1052b47092c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-08 19:09 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
=
> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Mon, 8 Feb 2016 11:43:10 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>, 22534@debbu= gs.gnu.org
>
>=C2=A0 > events: ((created changed deleted))= ((17491048 created
>=C2=A0 > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent= 20748Ali/file-notify-test20748Nvo)
>=C2=A0 > (17491048 changed
>=C2=A0 > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent= 20748Ali/file-notify-test20748Nvo))
>
>=C2=A0 Fails also for me in batch mode. Surprisingly, it doesn't fa= il always,
>=C2=A0 sometimes (about 1 in 10 runs) it succeeds here, and fails in th= e next
>=C2=A0 step. Strange.
>
> I see the same. The deleted notifications number vary. When you expect= 2, sometimes I see 1.
> When you expect one, sometimes I see it. But not frequently.

Did you try adding calls to read-event after the functions that are<= br> supposed to produce these events?

Yes, but with no results.

<= /div>
--001a11c30ba01ea7b1052b47092c-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145496020716893 (code B ref 22534); Mon, 08 Feb 2016 19:37:02 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 19:36:47 +0000 Received: from localhost ([127.0.0.1]:60496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrc7-0004OP-Mt for submit@debbugs.gnu.org; Mon, 08 Feb 2016 14:36:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40894) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrc5-0004OC-Ik for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 14:36:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSrbx-0005rO-QT for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 14:36:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSrbx-0005rK-Mu; Mon, 08 Feb 2016 14:36:37 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1658 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aSrbx-0007VY-05; Mon, 08 Feb 2016 14:36:37 -0500 Date: Mon, 08 Feb 2016 21:36:21 +0200 Message-Id: <83pow7ouyy.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87r3gnvwtt.fsf@gmx.de> (message from Michael Albinus on Mon, 08 Feb 2016 20:14:22 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Michael Albinus > Cc: Fabrice Popineau , 22534@debbugs.gnu.org > Date: Mon, 08 Feb 2016 20:14:22 +0100 > > Eli Zaretskii writes: > > > Btw, is there an easy way of running just one test out of > > file-notify-test.el? Running all of them takes a long time, > > especially now that the 06 test is no longer considered "expensive". > > 06 is still expensive, how do you believe it has changed? Because I see this in file-notify-test.log: passed 13/16 file-notify-test06-many-events Only the remote part of 06 is skipped. Am I missing something? > "make check" knows the SELECTOR variable. You could do > > # make SELECTOR='(quote (eql file-notify-test02-events))' \ > -C test/automated file-notify-tests OK, thanks. I wish this were described on some README, or maybe it could even be less cumbersome to type. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 20:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145496165619086 (code B ref 22534); Mon, 08 Feb 2016 20:01:02 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 20:00:56 +0000 Received: from localhost ([127.0.0.1]:60508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrzU-0004xm-6p for submit@debbugs.gnu.org; Mon, 08 Feb 2016 15:00:56 -0500 Received: from mout.gmx.net ([212.227.17.21]:55759) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSrzS-0004xY-4D for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 15:00:54 -0500 Received: from detlef.gmx.de ([87.146.47.108]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LsD9n-1a1xrc2g1P-013zL1; Mon, 08 Feb 2016 21:00:47 +0100 From: Michael Albinus References: <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> Date: Mon, 08 Feb 2016 21:00:42 +0100 In-Reply-To: <83pow7ouyy.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Feb 2016 21:36:21 +0200") Message-ID: <87mvrbvuol.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:RiA1sHrvcFSB+mvqTvBbohRzK1JyYhbT7fSXj3qkgHCNawKAQk/ hrW6683rQCvtRtp1KY7BrxAL40Mto81d8dCt0x5J97xx5k2s1XjfXl0Ae62arfcyGnXTvaS h2mz50qScIoATWJQdeCddLTEFzyEOlqwfOInMK42wtAkAW3URLIQGsM1qA8j2gfNlqjVSKw 7KHFKPiKPOO6QF3kJA0PQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:OaCE4ghQjuc=:upOZiViMDrqVkd+UhGqP1G AzfFASxC/IjAEEYXH7hOkjTeQD7bLoxMKp1e47Eh21Sve+ANyWMQS0Uf84ME5di3vLE+zusiY Kz87qnoGkOjABV6Hxdg/sgPwMOu6cgc9UzRh9zSEWkBssxxtLGEVOo0G51g0zw5ku2mbQtVXa JjLXJnWt1SNxqRr5JObaDSREX+e/3D2cNaVNgVEvCmASx4RVuNhPppEyOEVJqMPNMCFJMNNG9 SP1Uk7Z4JH94y2XU922z+rXegOB1xZuuhWX+7kmVIMJUmpZj2ulUwvrz9sZCBwr6ggbrEY1TA i72f24440TiCHih8dvX8i0UQxSkaJc1B9WCXg7h2KaiBYPqMkvpYMk4xkvEa4NclsuiOzfwni nSfdUZp4CfCjLk+mlJ2NSkgABrhegUqf+vXmTSrNupsFjEqiyH1SEXbsilalwX56/GOEHu4oA YFMlsFpUtugXXWxrDYOPZmOEzE5kl7ZARkMqsnGvAOU2/I7wyQiyDvDiixncNcgxl69VVX3NK vkDZ2SoclRgRxoJZMbNSz+3NmW6A681ecGK/Bmu5XItUnTw9lPrOrOzZE861UqhRX+NBmlojy EuEhFq8rPC6TMXsQmb9uypSd2Pj6P8301esDNpuLbQXm4jmZfPW53g2Yt6yf4EzcIOLxVpASC yUkCjTRoVA40isG4zF95qrrUKjrbYC2IFHfWIfATwwwgoK0I7zvjOfDZSeL08OhAdf8fGMHaE yGiS3OtLnZSRTLr3RNOLE9E9m5amR8e9K7/lq9JGFfVIlYHTY0JASYdpxNeMvMhKBXwjv/VJn N+JDA6Y X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Because I see this in file-notify-test.log: > > passed 13/16 file-notify-test06-many-events > > Only the remote part of 06 is skipped. Am I missing something? The remote part is skipped because you are on MS Windows. Expensive checks are skipped only for "make check" and "make check-maybe". "make file-notify-tests" run all possible tests in that file. >> "make check" knows the SELECTOR variable. You could do >> >> # make SELECTOR='(quote (eql file-notify-test02-events))' \ >> -C test/automated file-notify-tests > > OK, thanks. I wish this were described on some README, or maybe it > could even be less cumbersome to type. Description of how to run the tests needs more care. I put it on my TODO. The syntax of selectors is given by ert. See (info "(ert) Test Selectors") Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145496274520748 (code B ref 22534); Mon, 08 Feb 2016 20:20:02 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 20:19:05 +0000 Received: from localhost ([127.0.0.1]:60516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSsH2-0005OZ-VR for submit@debbugs.gnu.org; Mon, 08 Feb 2016 15:19:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56224) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSsH0-0005O4-UZ for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 15:19:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSsGs-0001Y0-LJ for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 15:18:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSsGs-0001Xo-HI; Mon, 08 Feb 2016 15:18:54 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1694 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aSsGr-0006yl-Nl; Mon, 08 Feb 2016 15:18:54 -0500 Date: Mon, 08 Feb 2016 22:18:38 +0200 Message-Id: <83k2mfot0h.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87mvrbvuol.fsf@gmx.de> (message from Michael Albinus on Mon, 08 Feb 2016 21:00:42 +0100) References: <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Michael Albinus > Cc: fabrice.popineau@gmail.com, 22534@debbugs.gnu.org > Date: Mon, 08 Feb 2016 21:00:42 +0100 > > Expensive checks are skipped only for "make check" and "make > check-maybe". "make file-notify-tests" run all possible tests in > that file. That's inconsistent, won't you agree? > Description of how to run the tests needs more care. I put it on my > TODO. Thanks. > The syntax of selectors is given by ert. See (info "(ert) Test Selectors") I understood the syntax by looking at what Makefile does. But it's hardly convenient (or pretty) to type Lisp expressions on the Make command line, IMO. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145496467923711 (code B ref 22534); Mon, 08 Feb 2016 20:52:01 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 20:51:19 +0000 Received: from localhost ([127.0.0.1]:60524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSsmE-0006AN-QG for submit@debbugs.gnu.org; Mon, 08 Feb 2016 15:51:18 -0500 Received: from mout.gmx.net ([212.227.17.22]:51292) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSsmD-0006AB-Rp for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 15:51:18 -0500 Received: from detlef.gmx.de ([87.146.47.108]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MFPyK-1aGj9833si-00EMXF; Mon, 08 Feb 2016 21:51:10 +0100 From: Michael Albinus References: <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> Date: Mon, 08 Feb 2016 21:51:09 +0100 In-Reply-To: <83k2mfot0h.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Feb 2016 22:18:38 +0200") Message-ID: <87io1zvsci.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:HwdEB1wbJaIXUIpJ65E8rCUeQ+45k82dAEnyyz1lotGrY0Z7gF3 Zmm0KXS4sHYgUrUcIHpn0X4/HDi8uUOHlZCmh751ggKvpZi8aBKDRAa1AnfQKEgPu0T8KbJ xQWZR1LPv+9ANxxEcbNlyquINmAeKgBuq44xMdvP18V9277k+AJZjKYKCnYVTvKb8l4u7rt 3VySeCObgefzXKKoXs1HA== X-UI-Out-Filterresults: notjunk:1;V01:K0:LWCt85MTD0w=:XboTOBakaYK2whZpWzQeQe s5lD64GaonApvbbnWh4ckJBiWpzkb/NzwWURerH1o1pUh9tRlgn5xAp9VhPLeAG+qjJmwFuLa YwEcipsapMyFIUPCM4nqvhqO2bU+LzR6cr5bpf+GWorCcYwK8OvB0Y6CH2lqxIgFOQZgS0/pg WOwpaBktXW/QihX0GCxcM82kO/8ynydsiE1s4LQDx23c72PHSExMiPqRkEBkQ8KtmOF4WGUdC L0NLVgAbk5C7eccFDBNId3qIo0LIUF/5kYbvU3n86Ing9HMnBgp1qTxLXmMKaB6/FGSd8a20t jE6tEsnJJw54UuEiwCS06oWkv33EH4UI5/nJ+H83a5LxODDxSLI0y/gag0DXtlWrXlOXFr0VU xqta99DZNYzvB4tT+baLqlb2bKN4VkbUAWuxcrj6BDBXoUvCghpxOCgsG1eDuX9ow8M/DXa9T ucykyf2dRf3fUCb5g+V8ulYNx+tioRuQk6o19voFJY0Ai6CCBsAs9trPjO2sUcXhOwox0uVuc TdIF0C2JINE7dEVQ270H58nXVPBmJq0yqHzwNvbDjO9JZw9unISmjfL4+NlyN8iJthHQsX1A2 kBeKGGaC5vv1oAo1E7gnE8qDxlnLorrt6dRxaAaI52H8E2syLgKmz8r2h375yD5fcSt+WKNbl 0LIuowrmRzDEd6+4jHXy7TeJnxz9LWiDuYJmlmR9uD0kpGUrU2Ura9tXJpYGMn0HiG9g+HvqP ECFVzHlBqU85mKWMtAyc7cxhMFDBHbsgnmal7rL4D/tWxZw7TX84J+jChLjbOSOrsg4fbnQ9I L5pSugr X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> Expensive checks are skipped only for "make check" and "make >> check-maybe". "make file-notify-tests" run all possible tests in >> that file. > > That's inconsistent, won't you agree? No. If you want to run the tests of a given file, you don't want to discriminate them. Otherwise, you could run expensive tests in that file only when you call "make check-expensive". Not acceptable, IMO. Discriminating the tests is appropriate when running "make check". This shall give you an overview of Emacs' health in a short time. >> The syntax of selectors is given by ert. See (info "(ert) Test Selectors") > > I understood the syntax by looking at what Makefile does. But it's > hardly convenient (or pretty) to type Lisp expressions on the Make > command line, IMO. What would you recommend else? Introduce another syntax for selectors? Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145496542024953 (code B ref 22534); Mon, 08 Feb 2016 21:04:02 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 21:03:40 +0000 Received: from localhost ([127.0.0.1]:60555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSsyC-0006UP-A8 for submit@debbugs.gnu.org; Mon, 08 Feb 2016 16:03:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42529) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSsyB-0006UE-Gw for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 16:03:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSsy2-0005Nl-0o for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 16:03:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSsy1-0005Nh-Tr; Mon, 08 Feb 2016 16:03:29 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1715 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aSsy0-0001t6-Hw; Mon, 08 Feb 2016 16:03:29 -0500 Date: Mon, 08 Feb 2016 23:03:13 +0200 Message-Id: <83egcmq5im.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87io1zvsci.fsf@gmx.de> (message from Michael Albinus on Mon, 08 Feb 2016 21:51:09 +0100) References: <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Michael Albinus > Cc: fabrice.popineau@gmail.com, 22534@debbugs.gnu.org > Date: Mon, 08 Feb 2016 21:51:09 +0100 > > Eli Zaretskii writes: > > >> Expensive checks are skipped only for "make check" and "make > >> check-maybe". "make file-notify-tests" run all possible tests in > >> that file. > > > > That's inconsistent, won't you agree? > > No. If you want to run the tests of a given file, you don't want to > discriminate them. Otherwise, you could run expensive tests in that file > only when you call "make check-expensive". Not acceptable, IMO. That's your logic, not mine. If I want all the tests, I will say so. > >> The syntax of selectors is given by ert. See (info "(ert) Test Selectors") > > > > I understood the syntax by looking at what Makefile does. But it's > > hardly convenient (or pretty) to type Lisp expressions on the Make > > command line, IMO. > > What would you recommend else? Introduce another syntax for selectors? Something like "make file-notify-tests TEST=06", for example. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2016 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145496599525847 (code B ref 22534); Mon, 08 Feb 2016 21:14:02 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Feb 2016 21:13:15 +0000 Received: from localhost ([127.0.0.1]:60566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSt7S-0006ip-OH for submit@debbugs.gnu.org; Mon, 08 Feb 2016 16:13:14 -0500 Received: from mout.gmx.net ([212.227.15.19]:51875) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSt7Q-0006ib-GM for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 16:13:12 -0500 Received: from detlef.gmx.de ([87.146.47.108]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M8NWM-1a7fF52uzy-00vx8p; Mon, 08 Feb 2016 22:13:05 +0100 From: Michael Albinus References: <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> <83egcmq5im.fsf@gnu.org> Date: Mon, 08 Feb 2016 22:13:02 +0100 In-Reply-To: <83egcmq5im.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Feb 2016 23:03:13 +0200") Message-ID: <87d1s6x5wh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:vNBQyMoDnfILj9VUscQPwX/6rnGkRe5OQRn/+IyTiADz9y9KTfR X1P5nEznnniD4cuUrMEfkLgldn/YEW4SqZXyPNvyU8WKb5CRZLKkggPdgrOyOiefwUruGz8 nx/e8GTQSdI8SANY9zLo5hKi3rIGShlGLyWIiSzIjuuRBrF4T0b9jOksPHbXQt8NWIdrdSP pRlI0zml8KyokBcNhp8XQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:kOxOPw0nSnc=:3S+oJ2rMbzKmOFLdfFEy6V 3dsmUPFtGJ4MZt8XqGTGdv7g5iTsbAm7+TAeDufkfYpmDPM3DHbwOfMfYzjy7Bw7GthMGy4Jc Ooo00YWWx88ATzY9fLBWiEB1XIy5O6GTdesnKlfRehndN6BZT4ppt3CNDDbYw2DfAsM4+M5aA dlDjnjASTFi/JAB96vYuOMa81Twkvzehjk18WBUfnbl6eV7595hWz+yoDsBeDXN2JybhZ47+a TuMyIoz2CUdrio2oJu1TCLX66NBK8cJQ9WcoBlul0c0+2ba4ITY1teRwiD0rf+g4j4048lbfP gOWg+uzYY92cRAAlpGJUmSNEQi2cbIFcP+Iu00dBzybVG6ODuKZa4AkI+pcXonoaZeZkvyDc4 BdDt46Fz/AKm/FE42Os51LtPo+IvlUkxUONRgiGuUJ3HcXJZdxLFsoF1beSLQ9XrJPlzaToLj 0ywhJ4hoC/lmUFYS4Ju1XmxGHQJ6oyT7aJXcE+rbaOtwgkY2Uv8OkulNvuGU9mgwLupe5hD96 9tNu7SaXFeCsFNvDaFCmbxb9L0wKgLhjG4xw3FtkZB5E10zhkcbfyMzxQo8ioTjo3kaDWkgBB AvdYKx61om0FJloZ3yQ6Zpc+2oFgmTAJLfOQHBojkBhrG1eMG+YTM7P3SY+TFuf/cGVHTgMGj DMyz1/u2Te3EpZtn0E0CNk0h2oEIOQ8JwC8XjWIgTw4EMOJqXZW9SetcGOxx5oNc6FhowsIz5 5dPwQV7oW3yifyLZ0r6keZY7B0XqJTDIFsthG1GIvmRgfpoHart8lAD9/Dm1sQAWIhFLEKliH AMhnQtC X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > That's your logic, not mine. If I want all the tests, I will say so. How? >> What would you recommend else? Introduce another syntax for selectors? > > Something like "make file-notify-tests TEST=06", for example. The "06" is just my invention. There's no rule how to name ert tests. Most of the test names do not use numbers. And a selector '(eql file-notify-test02-events) is just one of the possible selectors. Do you want to restrict this to test names? Using tags for selectors sounds also very appealing. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2016 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145498895412882 (code B ref 22534); Tue, 09 Feb 2016 03:36:01 +0000 Received: (at 22534) by debbugs.gnu.org; 9 Feb 2016 03:35:54 +0000 Received: from localhost ([127.0.0.1]:60844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSz5m-0003Li-Ke for submit@debbugs.gnu.org; Mon, 08 Feb 2016 22:35:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45168) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSz5k-0003LU-Nv for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 22:35:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSz5c-0001o3-8I for 22534@debbugs.gnu.org; Mon, 08 Feb 2016 22:35:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSz5c-0001nw-4L; Mon, 08 Feb 2016 22:35:44 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1963 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aSz5b-0000Rn-BA; Mon, 08 Feb 2016 22:35:43 -0500 Date: Tue, 09 Feb 2016 05:35:29 +0200 Message-Id: <83bn7qpncu.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87d1s6x5wh.fsf@gmx.de> (message from Michael Albinus on Mon, 08 Feb 2016 22:13:02 +0100) References: <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> <83egcmq5im.fsf@gnu.org> <87d1s6x5wh.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Michael Albinus > Cc: fabrice.popineau@gmail.com, 22534@debbugs.gnu.org > Date: Mon, 08 Feb 2016 22:13:02 +0100 > > Eli Zaretskii writes: > > > That's your logic, not mine. If I want all the tests, I will say so. > > How? By the same selector scheme we use when running the whole suite. > >> What would you recommend else? Introduce another syntax for selectors? > > > > Something like "make file-notify-tests TEST=06", for example. > > The "06" is just my invention. There's no rule how to name ert > tests. Most of the test names do not use numbers. > > And a selector '(eql file-notify-test02-events) is just one of the > possible selectors. Do you want to restrict this to test names? Using > tags for selectors sounds also very appealing. The name of a test is a good selector, and the syntax could be simpler than it is now, if we could say something like "TESTS='foo bar baz'". From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2016 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145500562211950 (code B ref 22534); Tue, 09 Feb 2016 08:14:02 +0000 Received: (at 22534) by debbugs.gnu.org; 9 Feb 2016 08:13:42 +0000 Received: from localhost ([127.0.0.1]:60911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aT3Qc-00036f-93 for submit@debbugs.gnu.org; Tue, 09 Feb 2016 03:13:42 -0500 Received: from mout.gmx.net ([212.227.17.20]:51702) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aT3Qa-00036S-9P for 22534@debbugs.gnu.org; Tue, 09 Feb 2016 03:13:40 -0500 Received: from detlef.gmx.de ([87.146.41.147]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Lxgnf-1ZwGed3dtb-017GlW; Tue, 09 Feb 2016 09:13:33 +0100 From: Michael Albinus References: <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> <83egcmq5im.fsf@gnu.org> <87d1s6x5wh.fsf@gmx.de> <83bn7qpncu.fsf@gnu.org> Date: Tue, 09 Feb 2016 09:13:31 +0100 In-Reply-To: <83bn7qpncu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Feb 2016 05:35:29 +0200") Message-ID: <874mdiwbbo.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:t2+Nxl0yRwPzvIkqLaReIgEwKDOOyumYKTfRGXdXKquWvmthsMR FMidNl03naTjsETwFXlO+vRISe6MQctncuiJzAAovEeCdbiO/mYtDr4Hl/4yNfElYo+AFnF ILAMQZdyD9Lm/dE7P+xO2AL7u1dGK3QmL1JNsWaaattGzZzYyKQcHsN2FIRnfeHZXpdMYnx 0fn9JctymSJmA/sz/SbdA== X-UI-Out-Filterresults: notjunk:1;V01:K0:UrnPkhcyqyE=:x3IK9PNwxb9JH6w+KQKvJT AFkR8vxJ3GS4ULJd3SeQbB4RAxS9SoxDXm3GUOfOe59drx8AarUuSBAq4t5djpeE/tUGv1qh0 tgclzWESHsi65awzWin+o9ZEq/yVQNRlbhucjBJ96Yv6ETifFqLRTb4+1nZhOWTSuVG0L/7nl TVg0blhnnUF83aP6TbayrsMP9P6udpn0LfzJcu7CB0Sk4mpmiBj1ngyb9BSjUAGtj+N6E8T74 U7marBU2yT6kp/1dUoZD8mVoScwvwzvyNvF7fCDI3Whv3+fhEZ0rgKpiVUVQPtgN0WlLepsex KitbkHe7iJfIUkeVWa2NEL/GYdBHFW6wWQSSxnYO9wWz566XYYauwZYBmGi5l9m7jvtJnXw4z G9xxl4fsM9btd5onELxgWy8eRDb4DcY1+1CTlnw1d2XSFpuap8wQRG3iDjTS9r58b+351dgKv bFHBTXTbvsDqkWXAIDEEnU4wTD76Sxx+Ml3aU2k1RQy3+RY1Fg+n33e+NzYtOaCxuYZ9IPMzI Ian6VrdEZsvqaLH77w276FppF/bnNgrIewgpgH1vJd7WWNOk6kA9Qvhsukl+Ui+zpqvCOrEEG vLIy983DDq5qvXZWT1S6qNM3LIjwwjZaS87/YcO+rsIpr6ukx6IoEnodkPvRvQ+PTkAVLpuXp +6smuZ9ICSmoWrDbO5yWPqJ0cy9thvWziTPyRIWFLI95/bVKY/xPUOv4vBkj7Ce7uxUpb3euX 3GdxBRU1SyuGvzHka5ckBu6tatW0ULHNBZ3I84yFXtO1gngtd/hAHsXtRShTXsujwQcDrcD+I BQikhRG X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> > That's your logic, not mine. If I want all the tests, I will say so. >> >> How? > > By the same selector scheme we use when running the whole suite. Well, the following runs all tests but the expensive ones: # make SELECTOR='$(SELECTOR_DEFAULT)' -C test/automated file-notify-tests So far, we have declared only $(SELECTOR_DEFAULT) and $(SELECTOR_EXPENSIVE). Shall we declare more predefined selectors in the makefile? >> > Something like "make file-notify-tests TEST=06", for example. >> >> The "06" is just my invention. There's no rule how to name ert >> tests. Most of the test names do not use numbers. >> >> And a selector '(eql file-notify-test02-events) is just one of the >> possible selectors. Do you want to restrict this to test names? Using >> tags for selectors sounds also very appealing. > > The name of a test is a good selector, and the syntax could be simpler > than it is now, if we could say something like "TESTS='foo bar baz'". Selectors could be a regexp. So the following works already: # make SELECTOR='\"02\"' -C test/automated file-notify-tests And if you want to run only test 04 and 05 (both about validity), and not the respective remote tests, call this (note the double $ at the end): # make SELECTOR='\"validity$$\"' -C test/automated file-notify-tests Well, I shall start to document somewhere what's already working ... Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2016 10:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145501251921918 (code B ref 22534); Tue, 09 Feb 2016 10:09:01 +0000 Received: (at 22534) by debbugs.gnu.org; 9 Feb 2016 10:08:39 +0000 Received: from localhost ([127.0.0.1]:60930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aT5Dr-0005hS-Da for submit@debbugs.gnu.org; Tue, 09 Feb 2016 05:08:39 -0500 Received: from mout.gmx.net ([212.227.15.15]:50738) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aT5Dq-0005hG-12 for 22534@debbugs.gnu.org; Tue, 09 Feb 2016 05:08:38 -0500 Received: from detlef.gmx.de ([87.146.41.147]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Likl3-1ZsMxG1f81-00cwUY; Tue, 09 Feb 2016 11:08:31 +0100 From: Michael Albinus References: <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> <83egcmq5im.fsf@gnu.org> <87d1s6x5wh.fsf@gmx.de> <83bn7qpncu.fsf@gnu.org> <874mdiwbbo.fsf@gmx.de> Date: Tue, 09 Feb 2016 11:08:29 +0100 In-Reply-To: <874mdiwbbo.fsf@gmx.de> (Michael Albinus's message of "Tue, 09 Feb 2016 09:13:31 +0100") Message-ID: <87si12ci1u.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:GRQ1S2n6t2h2TvlFHe5R2ki4E7Uc4ub+tQDF54zXcp+dmq4YMKW Yh1rNIQPtJLDq1V9b3V462w6256MzkDlyq8RONRNpvylaXgFfo53UrY+UV07Rr4/sPc8e2J cbZ8NbiCDwAnmliVq1RnUyD5gJtvVqK2KfK1n6aK5HudXSqlinM2rgVdvTMFkNiV+0wTy9j T6s6TC6WCu0T0n28J9fOQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:A2Qqe+6QNVc=:YmWQuXUPvau/oOIvTSBBtr Eqmgvem5wdKmHhJ2EPAnYrd7jmV7Fb+nujsoiiA1rg9/5amMxlnXuAxrtP9txRD1BNEd2qhu2 rMmRzdmziH1F4x1egV3y3XW1rGO3OztNNEPvF7SB6Q3setRh7s0hDrqaYKve17qhyMtNxlUod w6aBO/am66IcK6SIcP/H11wDMUUm7hAjjBQ0JQ3WXLjTSWQDi6D9BMIKJwmEv0ULgZTnJiJFh wF1H6FJWErMkoGtMmOw2RvFGkexOLHGpKq8K+2GEU08U3xhweHxAvCM1C7+lUB3XMOzM/CELR jsJUeqOfcFWopATnhPeWzITFHsl/zgVdzG/eY/LLGIV69B0VrCZs5JDCzyky47CMC1qWhfoNW IitHQnOczi5dArQmpVHSGVhfpmeZvsu2dS3rzb7FtOhXTtZxhiBnLpy00VyutjJbriPIxhOo/ +f2K2C0rpBEkhktUzi0JGbTZXOufISVupl+87Sw/yc9qL1g9aGBykc6MbF0fGrdVtrhmCFEw/ dI0fnrHiSM91ab7bMyhS8efFC+1u8okC76SBk5DWvc3JK52JOlrgc/K0lizPa0oYhJjn8lc1t QfTr+FPgb6LrMBXxgMbde5ExZkqVTs3lT8V7GXTvo12Lwfkpu9gnvFwpJTH8cfJLqJNWnnGaX dvFLBrYAypadsWTKQdilQsGr85Vs9qnBcSLdI3518pSP0sdz3URa4A8u5hokVaQklwhwbit4G frZGUlfhOFl1C3PVdlaFUYaf3az3QOTNXXYhdEurwF5lelr2aw/C3rOHxRxtQnU0OiVTiM+U7 8efGv0C X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Michael Albinus writes: > Well, I shall start to document somewhere what's already working ... I've added some examples to CONTRIBUTE. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2016 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14550377701768 (code B ref 22534); Tue, 09 Feb 2016 17:10:02 +0000 Received: (at 22534) by debbugs.gnu.org; 9 Feb 2016 17:09:30 +0000 Received: from localhost ([127.0.0.1]:33793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTBn8-0000SS-I9 for submit@debbugs.gnu.org; Tue, 09 Feb 2016 12:09:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53801) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTBn6-0000SA-Fd for 22534@debbugs.gnu.org; Tue, 09 Feb 2016 12:09:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTBmx-000628-MO for 22534@debbugs.gnu.org; Tue, 09 Feb 2016 12:09:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTBmx-000624-Ih; Tue, 09 Feb 2016 12:09:19 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1256 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aTBmw-0008EL-RU; Tue, 09 Feb 2016 12:09:19 -0500 Date: Tue, 09 Feb 2016 19:09:05 +0200 Message-Id: <837fiddd5a.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87si12ci1u.fsf@gmx.de> (message from Michael Albinus on Tue, 09 Feb 2016 11:08:29 +0100) References: <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> <83egcmq5im.fsf@gnu.org> <87d1s6x5wh.fsf@gmx.de> <83bn7qpncu.fsf@gnu.org> <874mdiwbbo.fsf@gmx.de> <87si12ci1u.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Michael Albinus > Cc: fabrice.popineau@gmail.com, 22534@debbugs.gnu.org > Date: Tue, 09 Feb 2016 11:08:29 +0100 > > Michael Albinus writes: > > > Well, I shall start to document somewhere what's already working ... > > I've added some examples to CONTRIBUTE. Thanks, but I'd rather have them in test/README. CONTRIBUTE is too far away from the tests to believe that interested users will look there (but I don't object to having them there as well, if you'd like that). From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2016 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145504366910637 (code B ref 22534); Tue, 09 Feb 2016 18:48:01 +0000 Received: (at 22534) by debbugs.gnu.org; 9 Feb 2016 18:47:49 +0000 Received: from localhost ([127.0.0.1]:33855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTDKH-0002lU-2z for submit@debbugs.gnu.org; Tue, 09 Feb 2016 13:47:49 -0500 Received: from mout.gmx.net ([212.227.15.18]:52895) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTDKF-0002lH-IH for 22534@debbugs.gnu.org; Tue, 09 Feb 2016 13:47:47 -0500 Received: from detlef.gmx.de ([87.146.41.147]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Mgt3g-1agSr70IKm-00M4E2; Tue, 09 Feb 2016 19:47:41 +0100 From: Michael Albinus References: <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> <83egcmq5im.fsf@gnu.org> <87d1s6x5wh.fsf@gmx.de> <83bn7qpncu.fsf@gnu.org> <874mdiwbbo.fsf@gmx.de> <87si12ci1u.fsf@gmx.de> <837fiddd5a.fsf@gnu.org> Date: Tue, 09 Feb 2016 19:47:39 +0100 In-Reply-To: <837fiddd5a.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Feb 2016 19:09:05 +0200") Message-ID: <87twlhvhys.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:RnvEkmzJQJ+fnZ+MMaQyCMQVagXAxFHDrOdGBk7aIyqEdKiONgm 2hsFiuFlCXrwsr9CfpqMPOImpALTvGnqWBvKc3pNa4tc40ee/X0MEKH+Fpy1LY6fufsIcWW 88t8scbMUGREu8oYkw3B+HrpU6oPTfc424FTGrh51gwjt4DK9LRB03hlj/vv+ORMHTJzE0t PadjE60EYzBQvNbA9QtNA== X-UI-Out-Filterresults: notjunk:1;V01:K0:WwlgeLlE5+o=:CmHOXA09qvVplgziJu7lEB 9KnbRixkNscVtd/WkrhPZr9emNJUMafbAcl1g3bfNTC+4dWgYRQs/5mboC9AEYOojrdeGcE6k fHxQdgxn0ZKHb1CeqvLLXxPTaChXWGxopYjeNEoc47iB8CqXzPLNcN0cEj2HH5sNtm02hiPo8 zAfX0E8YxbSQjpzHdazGrGT0IaoBYW2/Q1jqbL3/MjFiGeJDj8NeFfHzKThDI6P83GdavoKEf coJyawLLXuvPJabU3pf/9R10tfH6QVe4xv7hEcbsqFCCzp3ablonDi/+7+j8cGjp3g/r2tMTs EZKVe3WbSFxr4+GIbH0Cr3vXsqWnCjQwstO5tVthDG/1TTSp3qeZhG8faQIxD0y9yAhwsoGqi JLdlT9u9abO5Z57RR3n8p2EhBa88wz8etO9nP7kkxvBvQWT99XwrwpnSdSq3h9OOVSUT/Zr1t N3A/IfJ8OasPsCOInokL38YXan9pAKqEBeECF3vsib1gN3jFO6G89C0nIkYrvEiWMR94vXm84 /lpJIOuPyU5BkBM7pl1WCNvH9etEUuU05xFNQ0BoucVjh5YzRqPUZJAvqAaWrkS9yx3sEMDj8 X272ZGZ9TEKS8+RMjAHN1LeuT5/36ONO7lgE8RHPrlFprmCiD9qSlVDanp1dNRd+Np0P/2lSa QPTDzbNMWhS62SMtcMU7EeWCmGqHH5fbz09cF5lmoTYqkr5ka+k9r0YxN0Pd3/4dLWeDJfCkj vruMVSCU0jq+HSspelMxkjbdgIYvrRTKnoi/0jyYQ77q50l0csZGfPVXxM8Iw23pVffpmFjkK 9LijSy4 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Thanks, but I'd rather have them in test/README. CONTRIBUTE is too > far away from the tests to believe that interested users will look > there (but I don't object to having them there as well, if you'd like > that). Yes, test/README looks very short. I'll move most of the text about testing from CONTRIBUTE to test/README. Likely, tomorrow. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2016 11:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14551035325601 (code B ref 22534); Wed, 10 Feb 2016 11:26:01 +0000 Received: (at 22534) by debbugs.gnu.org; 10 Feb 2016 11:25:32 +0000 Received: from localhost ([127.0.0.1]:34250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTSto-0001SG-8P for submit@debbugs.gnu.org; Wed, 10 Feb 2016 06:25:32 -0500 Received: from mout.gmx.net ([212.227.17.20]:59674) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTStm-0001S2-19 for 22534@debbugs.gnu.org; Wed, 10 Feb 2016 06:25:30 -0500 Received: from detlef.gmx.de ([87.146.34.48]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LwF9u-1ZxE5t0GeE-0186Rg; Wed, 10 Feb 2016 12:25:23 +0100 From: Michael Albinus References: <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <87r3gnvwtt.fsf@gmx.de> <83pow7ouyy.fsf@gnu.org> <87mvrbvuol.fsf@gmx.de> <83k2mfot0h.fsf@gnu.org> <87io1zvsci.fsf@gmx.de> <83egcmq5im.fsf@gnu.org> <87d1s6x5wh.fsf@gmx.de> <83bn7qpncu.fsf@gnu.org> <874mdiwbbo.fsf@gmx.de> <87si12ci1u.fsf@gmx.de> <837fiddd5a.fsf@gnu.org> <87twlhvhys.fsf@gmx.de> Date: Wed, 10 Feb 2016 12:25:21 +0100 In-Reply-To: <87twlhvhys.fsf@gmx.de> (Michael Albinus's message of "Tue, 09 Feb 2016 19:47:39 +0100") Message-ID: <87fux0ajtq.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:oltd/Cl2xEz7gAcYIWVyR60Q1L3PoiNSqC7P+sugC3EyApz3zcL MTkfwJrcVpROyshfLN0QKlSpSnnwWmdIfIrMoLjt7YaNSfouEBW515AueBEp5dLXx4tdlEA jL6y/TcMaA7HzYl2KnSzRaNUudE6dEq2cC3nk9HfLDlqPc49lKzZAo72hcGpO8vrjt44uCw GCG1kycRiT/eAypcnCFJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:7+TvGgSHSPs=:8Co8RExeE3B9K2IgFqhdBg 226TYo+swmAadtDJdSI3pDbz8rwnEZjMB9Yuas94IrAtHUdGye4YBIJ1XKpKKc2tDbfjE/6zT h+PRr1XtBjq60s8mwNAPBywGE++TOqi8hgYfrn4LlzTEsGK8BM+exHszcJCO7ElPA3+9CQzSE 73SORaTQ0gBTA7aIQGKbiKoRVBFC30R6+WIoePNdlxkuWj1Ymik63Wff8x1Mvbe+W4b1bnI2Q P4hm8esXh8q3gSDV9SkyPFkbQrRUcErmvi8iwz7khwlTlBAqteTfaguEiAKHN/IPt5fSkDoJr xxHfpVCCm3MEiRtaG57G+ci5YK8sqxXmvqcx0/3NbqWUs87KGZaRy1PUihfac/JVGdIQR/g+d 2bhqN9OjKlgQrtOixRtmsd6CDcTE6+mZphbYzspI5VGAmc4jX//34prK0oaJ8BNtV7HpFgQxn cfWg3Ie/FjUtpaomSfYTUDorpwEJqnCUoFt4NiQljIAnwlmHJc1Ve+sZZe7RPAw5Wf08589rh KUd2clS4HEgHtQJMCLnXWYD21iKwHaOCxsZ/9rMFs1CfEjqjlMiodxB/5kwU06MzP4GGbsFFW aXfqzb6g1hSOREakh1trzsouUNdsX2aud/I4MJQE8X73C1JM4KLtdQrKjl0kZ/pQZAsUTo0t4 vsQ1S6h2T+x6z+SKxzcSeD84VuoB8gqUGrETuZUUVpDK9c6Ns/Cb+4ZzzvVAuoJkGpgWCgVjE NoBo1H+0RxqwEQQh7Ii01sdcqg9M5aqWBnlNI6wX/fARZMwodvcR2RKwlCXyciXaXc2cMAjBI s132psJ X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Michael Albinus writes: > Yes, test/README looks very short. I'll move most of the text about > testing from CONTRIBUTE to test/README. Likely, tomorrow. Done. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2016 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145513177330603 (code B ref 22534); Wed, 10 Feb 2016 19:17:01 +0000 Received: (at 22534) by debbugs.gnu.org; 10 Feb 2016 19:16:13 +0000 Received: from localhost ([127.0.0.1]:35276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTaFI-0007xX-Rk for submit@debbugs.gnu.org; Wed, 10 Feb 2016 14:16:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56478) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTaFH-0007xI-DG for 22534@debbugs.gnu.org; Wed, 10 Feb 2016 14:16:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTaF8-0005J6-5L for 22534@debbugs.gnu.org; Wed, 10 Feb 2016 14:16:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTaF8-0005J2-1q; Wed, 10 Feb 2016 14:16:02 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2984 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aTaF7-00023e-6p; Wed, 10 Feb 2016 14:16:01 -0500 Date: Wed, 10 Feb 2016 21:15:50 +0200 Message-Id: <83io1w9y1l.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Mon, 8 Feb 2016 20:15:59 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Fabrice Popineau > Date: Mon, 8 Feb 2016 20:15:59 +0100 > Cc: Michael Albinus , 22534@debbugs.gnu.org > > > From: Fabrice Popineau > > Date: Mon, 8 Feb 2016 11:43:10 +0100 > > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > > > > events: ((created changed deleted)) ((17491048 created > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo) > > > (17491048 changed > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-notify-test20748Nvo)) > > > > Fails also for me in batch mode. Surprisingly, it doesn't fail always, > > sometimes (about 1 in 10 runs) it succeeds here, and fails in the next > > step. Strange. > > > > I see the same. The deleted notifications number vary. When you expect 2, sometimes I see 1. > > When you expect one, sometimes I see it. But not frequently. > > Did you try adding calls to read-event after the functions that are > supposed to produce these events? > > Yes, but with no results. Strange. I see none of that on my machine. Maybe it's because my disk is SSD, maybe because this is XP. Who knows? Michael, I think it's time to do what you suggested: > If we do not care the missing `deleted' event in batch mode, I could > make it optional in the test. Re this: > But maybe it is an indication for a serious problem in w32notify. It might, but it's unlikely, and I won't have time to dig into this in the following weeks, so I guess this will have to wait for a recipe I can reproduce on one of my machines. Thanks. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Feb 2016 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Michael Albinus Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14552040184652 (code B ref 22534); Thu, 11 Feb 2016 15:21:02 +0000 Received: (at 22534) by debbugs.gnu.org; 11 Feb 2016 15:20:18 +0000 Received: from localhost ([127.0.0.1]:36857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTt2X-0001Cw-Gi for submit@debbugs.gnu.org; Thu, 11 Feb 2016 10:20:18 -0500 Received: from mail-ob0-f170.google.com ([209.85.214.170]:33678) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTt2V-0001Ce-1l for 22534@debbugs.gnu.org; Thu, 11 Feb 2016 10:20:15 -0500 Received: by mail-ob0-f170.google.com with SMTP id is5so77522813obc.0 for <22534@debbugs.gnu.org>; Thu, 11 Feb 2016 07:20:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=HWQ3DT0oV6T53oMOp1GOT22yapYnn//jElkacblF/HM=; b=oUqY7iRBpsTdVWnMLwdEh9jJwqXiTrwUkjd719abA1TeFb3pc/FlqOe7Lr9KlEnsuj ijO1Q8vFN+OMdRGGITIoyo/DNPswRqKmuPqHWxt8OG7HgnWYQwjpYZIwvAx8wlwzRXmy JL6YqN9mUT6uTtsxCRvhQlwJbTYjNi3UsPqrkam9MBv8Qd9r6d94HCkQEVuyJUBdut6Q l6K5r42TEcbkj19n9sk6cu5rrMLU5NYplj4k0rl9C8fVUJ9CBBBRyHl8vpCanpSJb/7G jekr9ZiG2bYjjzsmRH4O+ZLucNXpbjMMgLOMpo/D5PIRaojKTYPbTHf+P232jRbCxcWY OkNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=HWQ3DT0oV6T53oMOp1GOT22yapYnn//jElkacblF/HM=; b=LzHbniweHAkqeD+seZ/JlYMc7lASAl6KivHn9JvBAJYiJZ/Axg1T4seMdK32E27Tkh PpBnx7Nquj0lN7Pw3rnjyvYwQLXTnqYKTWf5qdQHv7/Sb5X+vcr6N2JP0jLB40PfdTcG takBMwPi/A2nyGJsb9tQ3AIFA4pacCMYFdsguvZn1SJ6nVy2RW6oLsT2JlSViibPGufu OpzaozM6cdKGKa03J7UjwagZvTpu/lmHRoNzE0FlgXUiEZr1LZS6HO6BcuRfC7ig8jN0 TQdO4NFgNnYw2fqeuR7qzj0iyQTI3fEetYENo0dhcHu5PwLT8rN1GSYxKNDANQE7iPjr FOLw== X-Gm-Message-State: AG10YOQoKNfBzxo5WxY0loHNgTVIhSpnJS6dlgUj6QYpmoH2SVH+nFKfbqKs4SApRhddYS+9qykpb2wYTE3Bzg== X-Received: by 10.60.73.170 with SMTP id m10mr48315552oev.51.1455204009346; Thu, 11 Feb 2016 07:20:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.75 with HTTP; Thu, 11 Feb 2016 07:19:49 -0800 (PST) In-Reply-To: <83io1w9y1l.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <83io1w9y1l.fsf@gnu.org> From: Fabrice Popineau Date: Thu, 11 Feb 2016 16:19:49 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a1135fd060d8d58052b801630 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1135fd060d8d58052b801630 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Some information regarding the original problem. I have turned on some tracing and this is what I get with file-notify-test02-events along these lines: $ git diff -w origin/emacs-25 src/w32notify.c diff --git a/src/w32notify.c b/src/w32notify.c index 71787c4..66ad277 100644 --- a/src/w32notify.c +++ b/src/w32notify.c @@ -207,6 +207,7 @@ watch_completion (DWORD status, DWORD bytes_ret, OVERLAPPED *io_info) freed by someone already? In any case, we cannot do anything with this request, so just punt and skip it. FIXME: should we raise the 'terminate' flag in this case? */ + DebPrint(("status =3D %lx, io_info =3D %lx\n", status, io_info)); if (!io_info) return; @@ -227,6 +228,7 @@ watch_completion (DWORD status, DWORD bytes_ret, OVERLAPPED *io_info) by its buffers; this is done by the main thread in remove_watch. Calling malloc/free from a thread other than the main thread is a no-no. */ + DebPrint(("Operation aborted.")); dirwatch->dir =3D NULL; dirwatch->terminate =3D 1; } @@ -406,11 +408,13 @@ remove_watch (struct notification *dirwatch) break; Sleep (10); } + DebPrint(("status =3D %lx, exit_code =3D %lx\n", status, exit_code))= ; if ((status =3D=3D FALSE && (err =3D GetLastError ()) =3D=3D ERROR_INVALID_HANDLE) || exit_code =3D=3D STILL_ACTIVE) { if (!(status =3D=3D FALSE && err =3D=3D ERROR_INVALID_HANDLE)) { + DebPrint(("Terminating thread.\n")); TerminateThread (dirwatch->thr, 0); if (dirwatch->dir) CloseHandle (dirwatch->dir); @@ -523,7 +527,7 @@ generate notifications correctly, though. */) char *errstr; CHECK_LIST (filter); - + DebPrint(("AddWatch\n")); /* The underlying features are available only since XP. */ if (os_subtype =3D=3D OS_9X || (w32_major_version =3D=3D 5 && w32_minor_version < 1)) I also forced DebPrint to write on stderr. When run in batch mode: $ make SELECTOR=3D'(quote (eql file-notify-test02-events))' -C test/automated file-notify-tests make : on entre dans le r=C3=A9pertoire =C2=AB /d/Source/emacs/build-emacs-25/test/automated =C2=BB make[1] : on entre dans le r=C3=A9pertoire =C2=AB /d/Source/emacs/build-emacs-25/test/automated =C2=BB make[2] : on entre dans le r=C3=A9pertoire =C2=AB /d/Source/emacs/build-emacs-25/test/automated =C2=BB Compiling ../../../emacs/test/automated/file-notify-tests.el make[2] : on quitte le r=C3=A9pertoire =C2=AB /d/Source/emacs/build-emacs-25/test/automated =C2=BB Testing ../../../emacs/test/automated/file-notify-tests.elc Running 1 tests (2016-02-11 16:14:39+0100) AddWatch status =3D 0, io_info =3D 3dd8090 status =3D 0, io_info =3D 3dd8090 status =3D 0, io_info =3D 3dd8090 status =3D 3e3, io_info =3D 3dd8090 Operation aborted. status =3D 1, exit_code =3D 0 AddWatch status =3D 0, io_info =3D 3dd8210 status =3D 0, io_info =3D 3dd8210 status =3D 0, io_info =3D 3dd8210 status =3D 3e3, io_info =3D 3dd8210 Operation aborted. status =3D 1, exit_code =3D 0 AddWatch status =3D 0, io_info =3D 3dd8000 status =3D 0, io_info =3D 3dd8000 watch_worker, abnormal exit: 5 QueueUserAPC failed (31)! status =3D 1, exit_code =3D 1 Test file-notify-test02-events backtrace: #[0 "\306\307\310C\307C\3111(\312\313\314\315$\317\"\32 ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test file-notify-test02-events "Check fi ert-run-or-rerun-test([cl-struct-ert--stats (eql file-notify-test02- ert-run-tests((eql file-notify-test02-events) #[385 "\306\307\"\203 ert-run-tests-batch((eql file-notify-test02-events)) ert-run-tests-batch-and-exit((eql file-notify-test02-events)) eval((ert-run-tests-batch-and-exit (quote (eql file-notify-test02-ev command-line-1(("-L" ";../../../emacs/test/automated" "-l" "ert" "-l command-line() normal-top-level() Test file-notify-test02-events condition: (ert-test-failed ((should (file-notify--test-with-events-check events)) :form (file-notify--test-with-events-check ((created changed deleted))) :value nil :explanation "Received events `(created changed)' do not match expected events `(created changed deleted)'")) FAILED 1/1 file-notify-test02-events Ran 1 tests, 0 results as expected, 1 unexpected (2016-02-11 16:15:20+0100) 1 unexpected results: FAILED file-notify-test02-events When I run in normal mode: $ src/emacs -Q -l ../emacs/test/automated/file-notify-tests.el AddWatch status =3D 0, io_info =3D 42dd0a0 status =3D 0, io_info =3D 42dd0a0 status =3D 0, io_info =3D 42dd0a0 status =3D 0, io_info =3D 42dd0a0 status =3D 3e3, io_info =3D 42dd0a0 Operation aborted.status =3D 1, exit_code =3D 0 AddWatch status =3D 0, io_info =3D 42dcc50 status =3D 0, io_info =3D 42dcc50 status =3D 0, io_info =3D 42dcc50 status =3D 0, io_info =3D 42dcc50 status =3D 3e3, io_info =3D 42dcc50 Operation aborted.status =3D 1, exit_code =3D 0 AddWatch status =3D 0, io_info =3D 42dd310 status =3D 0, io_info =3D 42dd310 status =3D 0, io_info =3D 42dd310 watch_worker, abnormal exit: 5 QueueUserAPC failed (31)! status =3D 1, exit_code =3D 1 AddWatch status =3D 0, io_info =3D 42dd2b0 status =3D 0, io_info =3D 42dd2b0 status =3D 0, io_info =3D 42dd2b0 status =3D 0, io_info =3D 42dd2b0 status =3D 0, io_info =3D 42dd2b0 status =3D 0, io_info =3D 42dd2b0 status =3D 0, io_info =3D 42dd2b0 status =3D 0, io_info =3D 42dd2b0 watch_worker, abnormal exit: 5 QueueUserAPC failed (31)! status =3D 1, exit_code =3D 1 AddWatch status =3D 0, io_info =3D 42dcec0 status =3D 0, io_info =3D 42dcec0 status =3D 0, io_info =3D 42dcec0 status =3D 0, io_info =3D 42dcec0 status =3D 5, io_info =3D 42dcec0 watch_worker, abnormal exit: 5 QueueUserAPC failed (31)! status =3D 1, exit_code =3D 1 AddWatch status =3D 0, io_info =3D 42dcec0 status =3D 0, io_info =3D 42dcec0 status =3D 3e3, io_info =3D 42dcec0 Operation aborted.status =3D 1, exit_code =3D 0 and the test is passed. The first diagnostic is that QueueUserAPC shouldn't fail with error 31. This happens because the worker thread is already terminating, but that does not leave a chance for watch_end to run. Fabrice 2016-02-10 20:15 GMT+01:00 Eli Zaretskii : > > From: Fabrice Popineau > > Date: Mon, 8 Feb 2016 20:15:59 +0100 > > Cc: Michael Albinus , 22534@debbugs.gnu.org > > > > > From: Fabrice Popineau > > > Date: Mon, 8 Feb 2016 11:43:10 +0100 > > > Cc: Eli Zaretskii , 22534@debbugs.gnu.org > > > > > > > events: ((created changed deleted)) ((17491048 created > > > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-= notify-test20748Nvo) > > > > (17491048 changed > > > > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-parent20748Ali/file-= notify-test20748Nvo)) > > > > > > Fails also for me in batch mode. Surprisingly, it doesn't fail alway= s, > > > sometimes (about 1 in 10 runs) it succeeds here, and fails in the ne= xt > > > step. Strange. > > > > > > I see the same. The deleted notifications number vary. When you > expect 2, sometimes I see 1. > > > When you expect one, sometimes I see it. But not frequently. > > > > Did you try adding calls to read-event after the functions that are > > supposed to produce these events? > > > > Yes, but with no results. > > Strange. I see none of that on my machine. Maybe it's because my > disk is SSD, maybe because this is XP. Who knows? > > Michael, I think it's time to do what you suggested: > > > If we do not care the missing `deleted' event in batch mode, I could > > make it optional in the test. > > Re this: > > > But maybe it is an indication for a serious problem in w32notify. > > It might, but it's unlikely, and I won't have time to dig into this in > the following weeks, so I guess this will have to wait for a recipe I > can reproduce on one of my machines. > > Thanks. > --001a1135fd060d8d58052b801630 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Some information regarding the original problem.

<= /div>
I have turned on some tracing and this is what I get with file-no= tify-test02-events
along these lines:

$ git diff -w origin/emacs-25 src/w32notify.c
diff --git a/src= /w32notify.c b/src/w32notify.c
index 71787c4..66ad277 100644
--- a/src/w32notify.c
+++ b/src/w32notify.c
@@ -2= 07,6 +207,7 @@ watch_completion (DWORD status, DWORD bytes_ret, OVERLAPPED = *io_info)
=C2=A0 =C2=A0 =C2=A0 freed by someone already?=C2=A0 In= any case, we cannot do anything
=C2=A0 =C2=A0 =C2=A0 with this r= equest, so just punt and skip it.=C2=A0 FIXME: should we
=C2=A0 = =C2=A0 =C2=A0 raise the 'terminate' flag in this case? =C2=A0*/
+ =C2=A0DebPrint(("status =3D %lx, io_info =3D %lx\n", sta= tus, io_info));
=C2=A0 =C2=A0if (!io_info)
=C2=A0 =C2= =A0 =C2=A0return;

@@ -227,6 +228,7 @@ watch_comple= tion (DWORD status, DWORD bytes_ret, OVERLAPPED *io_info)
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 by its buffers; this is done by the main thread= in
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 remove_watch.=C2=A0 Callin= g malloc/free from a thread other than
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 the main thread is a no-no. =C2=A0*/
+ =C2=A0 =C2=A0 = =C2=A0DebPrint(("Operation aborted."));
=C2=A0 =C2=A0 = =C2=A0 =C2=A0dirwatch->dir =3D NULL;
=C2=A0 =C2=A0 =C2=A0 =C2= =A0dirwatch->terminate =3D 1;
=C2=A0 =C2=A0 =C2=A0}
= @@ -406,11 +408,13 @@ remove_watch (struct notification *dirwatch)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Sleep (10);
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 }
+ =C2=A0 =C2=A0 =C2=A0DebPrint(("status =3D %lx= , exit_code =3D %lx\n", status, exit_code));
=C2=A0 =C2=A0 = =C2=A0 =C2=A0if ((status =3D=3D FALSE && (err =3D GetLastError ()) = =3D=3D ERROR_INVALID_HANDLE)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|| exit_code =3D=3D STILL_ACTIVE)
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!(status =3D= =3D FALSE && err =3D=3D ERROR_INVALID_HANDLE))
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{
+ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0DebPrint(("Terminating thread.\n"));
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0TerminateTh= read (dirwatch->thr, 0);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0if (dirwatch->dir)
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CloseHandle (dirwatch->dir);
@@ -523,7 +527,7 @@ generate notifications correctly, though. =C2=A0*/)
=C2=A0 =C2=A0char *errstr;

=C2=A0 =C2=A0C= HECK_LIST (filter);
-
+ =C2=A0DebPrint(("AddWatch\= n"));
=C2=A0 =C2=A0/* The underlying features are available = only since XP. =C2=A0*/
=C2=A0 =C2=A0if (os_subtype =3D=3D OS_9X<= /div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0|| (w32_major_version =3D=3D 5 &&a= mp; w32_minor_version < 1))

I also forced= DebPrint to write on stderr.


When = run in batch mode:

$ make SELECTOR=3D'(qu= ote (eql file-notify-test02-events))' =C2=A0 -C test/automated file-not= ify-tests
make : on entre dans le r=C3=A9pertoire =C2=AB /d/Sourc= e/emacs/build-emacs-25/test/automated =C2=BB
make[1] : on entre d= ans le r=C3=A9pertoire =C2=AB /d/Source/emacs/build-emacs-25/test/automated= =C2=BB
make[2] : on entre dans le r=C3=A9pertoire =C2=AB /d/Sour= ce/emacs/build-emacs-25/test/automated =C2=BB
Compiling ../../../= emacs/test/automated/file-notify-tests.el
make[2] : on quitte le = r=C3=A9pertoire =C2=AB /d/Source/emacs/build-emacs-25/test/automated =C2=BB=
Testing ../../../emacs/test/automated/file-notify-tests.elc
Running 1 tests (2016-02-11 16:14:39+0100)
AddWatch
status =3D 0, io_info =3D 3dd8090
status =3D 0, io_info =3D 3d= d8090
status =3D 0, io_info =3D 3dd8090
status =3D 3e3,= io_info =3D 3dd8090
Operation aborted.
status =3D 1, e= xit_code =3D 0
AddWatch
status =3D 0, io_info =3D 3dd82= 10
status =3D 0, io_info =3D 3dd8210
status =3D 0, io_i= nfo =3D 3dd8210
status =3D 3e3, io_info =3D 3dd8210
Ope= ration aborted.
status =3D 1, exit_code =3D 0
AddWatch<= /div>
status =3D 0, io_info =3D 3dd8000
status =3D 0, io_info= =3D 3dd8000
watch_worker, abnormal exit: 5
QueueUserAP= C failed (31)!
status =3D 1, exit_code =3D 1
Test file-= notify-test02-events backtrace:
=C2=A0 #[0 "\306\307\310C\30= 7C\3111(\312\313\314\315$\317\"\32
=C2=A0 ert--run-test-inte= rnal([cl-struct-ert--test-execution-info [cl-struc
=C2=A0 ert-run= -test([cl-struct-ert-test file-notify-test02-events "Check fi
=C2=A0 ert-run-or-rerun-test([cl-struct-ert--stats (eql file-notify-test0= 2-
=C2=A0 ert-run-tests((eql file-notify-test02-events) #[385 &qu= ot;\306\307\"\203
=C2=A0 ert-run-tests-batch((eql file-notif= y-test02-events))
=C2=A0 ert-run-tests-batch-and-exit((eql file-n= otify-test02-events))
=C2=A0 eval((ert-run-tests-batch-and-exit (= quote (eql file-notify-test02-ev
=C2=A0 command-line-1(("-L&= quot; ";../../../emacs/test/automated" "-l" "ert&q= uot; "-l
=C2=A0 command-line()
=C2=A0 normal-top-l= evel()
Test file-notify-test02-events condition:
=C2=A0= =C2=A0 (ert-test-failed
=C2=A0 =C2=A0 =C2=A0((should
= =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-notify--test-with-events-check events))
=C2=A0 =C2=A0 =C2=A0 :form
=C2=A0 =C2=A0 =C2=A0 (file-not= ify--test-with-events-check
=C2=A0 =C2=A0 =C2=A0 =C2=A0((created = changed deleted)))
=C2=A0 =C2=A0 =C2=A0 :value nil :explanation &= quot;Received events `(created changed)' do not match expected events `= (created changed deleted)'"))
=C2=A0 =C2=A0FAILED =C2=A0= 1/1 =C2=A0file-notify-test02-events

Ran 1 tests, 0= results as expected, 1 unexpected (2016-02-11 16:15:20+0100)
1 unexpected results:
=C2=A0 =C2=A0FAILED =C2=A0file-= notify-test02-events

When I run in normal mo= de:

$ src/emacs -Q -l ../emacs/test/automated= /file-notify-tests.el
AddWatch
status =3D 0, io_info = =3D 42dd0a0
status =3D 0, io_info =3D 42dd0a0
status = =3D 0, io_info =3D 42dd0a0
status =3D 0, io_info =3D 42dd0a0
status =3D 3e3, io_info =3D 42dd0a0
Operation aborted.statu= s =3D 1, exit_code =3D 0
AddWatch
status =3D 0, io_info= =3D 42dcc50
status =3D 0, io_info =3D 42dcc50
status = =3D 0, io_info =3D 42dcc50
status =3D 0, io_info =3D 42dcc50
status =3D 3e3, io_info =3D 42dcc50
Operation aborted.statu= s =3D 1, exit_code =3D 0
AddWatch
status =3D 0, io_info= =3D 42dd310
status =3D 0, io_info =3D 42dd310
status = =3D 0, io_info =3D 42dd310
watch_worker, abnormal exit: 5
QueueUserAPC failed (31)!
status =3D 1, exit_code =3D 1
<= div>AddWatch
status =3D 0, io_info =3D 42dd2b0
status = =3D 0, io_info =3D 42dd2b0
status =3D 0, io_info =3D 42dd2b0
status =3D 0, io_info =3D 42dd2b0
status =3D 0, io_info =3D= 42dd2b0
status =3D 0, io_info =3D 42dd2b0
status =3D 0= , io_info =3D 42dd2b0
status =3D 0, io_info =3D 42dd2b0
watch_worker, abnormal exit: 5
QueueUserAPC failed (31)!
status =3D 1, exit_code =3D 1
AddWatch
status =3D 0,= io_info =3D 42dcec0
status =3D 0, io_info =3D 42dcec0
= status =3D 0, io_info =3D 42dcec0
status =3D 0, io_info =3D 42dce= c0
status =3D 5, io_info =3D 42dcec0
watch_worker, abno= rmal exit: 5
QueueUserAPC failed (31)!
status =3D 1, ex= it_code =3D 1
AddWatch
status =3D 0, io_info =3D 42dcec= 0
status =3D 0, io_info =3D 42dcec0
status =3D 3e3, io_= info =3D 42dcec0
Operation aborted.status =3D 1, exit_code =3D 0<= /div>

and the test is passed.

=

The first diagnostic is that QueueUserAPC shouldn't= fail with error 31.
This happens because the worker thread is al= ready terminating, but that does not leave
a chance for watch_end= to run.

Fabrice

2016-02-10 20:15 GMT+01:00 Eli Zaretski= i <e= liz@gnu.org>:
> From: Fa= brice Popineau <fabrice.po= pineau@gmail.com>
> Date: Mon, 8 Feb 2016 20:15:59 +0100
> Cc: Michael Albinus <michael.albinus@gmx.de>, 22534@debbugs.gnu.org
>
>=C2=A0 > From: Fabrice Popineau <fabrice.popineau@gmail.com> >=C2=A0 > Date: Mon, 8 Feb 2016 11:43:10 +0100
>=C2=A0 > Cc: Eli Zaretskii <eliz@= gnu.org>, 22534@debbugs.gnu= .org
>=C2=A0 >
>=C2=A0 > > events: ((created changed deleted)) ((17491048 created=
>=C2=A0 > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-p= arent20748Ali/file-notify-test20748Nvo)
>=C2=A0 > > (17491048 changed
>=C2=A0 > > c:/Users/Fabrice/AppData/Local/Temp/file-notify-test-p= arent20748Ali/file-notify-test20748Nvo))
>=C2=A0 >
>=C2=A0 > Fails also for me in batch mode. Surprisingly, it doesn'= ;t fail always,
>=C2=A0 > sometimes (about 1 in 10 runs) it succeeds here, and fails = in the next
>=C2=A0 > step. Strange.
>=C2=A0 >
>=C2=A0 > I see the same. The deleted notifications number vary. When= you expect 2, sometimes I see 1.
>=C2=A0 > When you expect one, sometimes I see it. But not frequently= .
>
>=C2=A0 Did you try adding calls to read-event after the functions that = are
>=C2=A0 supposed to produce these events?
>
> Yes, but with no results.

Strange.=C2=A0 I see none of that on my machine.=C2=A0 Maybe it'= s because my
disk is SSD, maybe because this is XP.=C2=A0 Who knows?

Michael, I think it's time to do what you suggested:

> If we do not care the missing `deleted' event in batch mode, I cou= ld
> make it optional in the test.

Re this:

> But maybe it is an indication for a serious problem in w32notify.

It might, but it's unlikely, and I won't have time to dig in= to this in
the following weeks, so I guess this will have to wait for a recipe I
can reproduce on one of my machines.

Thanks.

--001a1135fd060d8d58052b801630-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Feb 2016 08:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145526631419262 (code B ref 22534); Fri, 12 Feb 2016 08:39:02 +0000 Received: (at 22534) by debbugs.gnu.org; 12 Feb 2016 08:38:34 +0000 Received: from localhost ([127.0.0.1]:37248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aU9FK-00050c-IJ for submit@debbugs.gnu.org; Fri, 12 Feb 2016 03:38:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50699) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aU9FI-00050P-Fl for 22534@debbugs.gnu.org; Fri, 12 Feb 2016 03:38:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aU9FA-0003zx-0D for 22534@debbugs.gnu.org; Fri, 12 Feb 2016 03:38:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43465) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aU9F9-0003zp-TA; Fri, 12 Feb 2016 03:38:23 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1894 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aU9F8-00063X-U0; Fri, 12 Feb 2016 03:38:23 -0500 Date: Fri, 12 Feb 2016 10:38:19 +0200 Message-Id: <83vb5u7284.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Fabrice Popineau on Thu, 11 Feb 2016 16:19:49 +0100) References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <83io1w9y1l.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Fabrice Popineau > Date: Thu, 11 Feb 2016 16:19:49 +0100 > Cc: Michael Albinus , 22534@debbugs.gnu.org > > Some information regarding the original problem. Thanks. > The first diagnostic is that QueueUserAPC shouldn't fail with error 31. > This happens because the worker thread is already terminating, but that does not leave > a chance for watch_end to run. Aren't those the cases when the parent directory of the files being watched is deleted? If so, do you see how to prevent the thread from terminating abnormally? From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Feb 2016 15:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, Fabrice Popineau Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14555502717993 (code B ref 22534); Mon, 15 Feb 2016 15:32:02 +0000 Received: (at 22534) by debbugs.gnu.org; 15 Feb 2016 15:31:11 +0000 Received: from localhost ([127.0.0.1]:40347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVL7G-00024r-Ss for submit@debbugs.gnu.org; Mon, 15 Feb 2016 10:31:11 -0500 Received: from mout.gmx.net ([212.227.17.21]:56978) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVL7E-00024b-NA for 22534@debbugs.gnu.org; Mon, 15 Feb 2016 10:31:09 -0500 Received: from detlef.gmx.de ([87.146.43.79]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LvhC4-1Zuo2s0AJw-017YU4; Mon, 15 Feb 2016 16:31:02 +0100 From: Michael Albinus References: <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <83io1w9y1l.fsf@gnu.org> Date: Mon, 15 Feb 2016 16:31:00 +0100 In-Reply-To: <83io1w9y1l.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Feb 2016 21:15:50 +0200") Message-ID: <87egce0z4b.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:MNGsO/cEfdhKUDxInq31yRELG0ASsz41p3DbcnLATxeTDf/rnbn zMkbbl3fEbrjyg8KI9ceDYmjpRj0XuHnMraujN5k+GGSvMEiBDr8C5dJ8aQo8cR/jP63Zb1 w65wqhNF5IEf6zxA1Vz+imJaCqUsuuKpkinF0dzBqNIqbfUgEAwjbZKvhrjBXcIt0GZqd1R 9ZSdaFsyWc6R7PnDAsNHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wPoouioHmMg=:rROe6XzeIK05u8C8tLRs6x W0qpHVoAa6Elq9d7oclnE3flbOUu1C1hQJ0zoS10tArkC3PZ9a2dX6KGh2vEJ6VDG7Y3HtfYk rETUv1Znn7jQi9Y/sCnNaJJvR0GFcTkkbAaQDxB2362fXzb+mXBkANv3KOXPOQZIiao+NTFx6 DbaUVYyXxuKi3+MlajPN/YAhiyTuUJlRaF5fv9lWw02AN9gE/xg094oC4upTB9bSl6qHd299a 7AH/UJhg4zztj7diZB2+jMBvUomNoUWWG9V4epQ0EmMWyOSTz60x1QAQHyyTzp2J5kcs3JSmy eO+d5+z8aEmpEoz57maerTLuZtQl671lL1ogcqPvtAy06M/RISooAROpEZb1WUpQbYMz7nIHZ QilqbqKV1Xlf7ZDj70PPhPTbih8dlnlHWw4J/8sttcw3sI7kOvq36w8ZdW05FSVqU3YGWvLfp C9/gJRmmt/A5iK7VvLzlB/kn0TYU9+tipd2VIC/LSuWSCg1PzvsqZKICuRyGwCWVRcRVhxNZS 4mSqb35a0Nt4AFsvopiQiEwkwDoEQDZbD5zZXVa0Ro5Ht+m20G3G/jj/C5FNZarSwhiKnFXwg n0irvvGP542GVeXNGsCdKNjTfcuNdC/X7Z3C/wPrY9rUnLhT2vhyGx6E0giJZbSf/+WYudVSE quCZogx59P4O/Sj3A++ubFUOZKAEhB5SflQas/xAx9XvlpK8vwPXCiZpdot+HB3lwiOfr6k5O WiWL3MwY1feqAkTI8M4yWnDEcvS3gstWfwb8RfdPQNUqkeRJhUTyc3JQq/qJIViQyKhRncXg5 +Zvqm+3 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: Hi Eli & Fabrice, > Michael, I think it's time to do what you suggested: > >> If we do not care the missing `deleted' event in batch mode, I could >> make it optional in the test. I'm still undecided. Are there chances there'll be progress before the release? Then I won't touch it. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Feb 2016 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Reply-To: Eli Zaretskii Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145555199110832 (code B ref 22534); Mon, 15 Feb 2016 16:00:02 +0000 Received: (at 22534) by debbugs.gnu.org; 15 Feb 2016 15:59:51 +0000 Received: from localhost ([127.0.0.1]:40352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVLZ1-0002oe-6w for submit@debbugs.gnu.org; Mon, 15 Feb 2016 10:59:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41960) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVLYz-0002oO-O9 for 22534@debbugs.gnu.org; Mon, 15 Feb 2016 10:59:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVLYq-0003lP-I7 for 22534@debbugs.gnu.org; Mon, 15 Feb 2016 10:59:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVLYq-0003lJ-Ec; Mon, 15 Feb 2016 10:59:40 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1671 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aVLYp-000862-MK; Mon, 15 Feb 2016 10:59:40 -0500 Date: Mon, 15 Feb 2016 17:59:46 +0200 Message-Id: <8360xqx8ul.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87egce0z4b.fsf@gmx.de> (message from Michael Albinus on Mon, 15 Feb 2016 16:31:00 +0100) References: <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <83io1w9y1l.fsf@gnu.org> <87egce0z4b.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Albinus > Cc: Fabrice Popineau , 22534@debbugs.gnu.org > Date: Mon, 15 Feb 2016 16:31:00 +0100 > > Eli Zaretskii writes: > > Hi Eli & Fabrice, > > > Michael, I think it's time to do what you suggested: > > > >> If we do not care the missing `deleted' event in batch mode, I could > >> make it optional in the test. > > I'm still undecided. Are there chances there'll be progress before the > release? Not by me, as long as I don't see the problem on my machine. If Fabrice could find time debugging this, I will be glad to help by explaining the code in w32notify.c and elsewhere that is related to injecting the notification events on w32. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Feb 2016 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145555875221500 (code B ref 22534); Mon, 15 Feb 2016 17:53:02 +0000 Received: (at 22534) by debbugs.gnu.org; 15 Feb 2016 17:52:32 +0000 Received: from localhost ([127.0.0.1]:40400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVNK3-0005ag-AF for submit@debbugs.gnu.org; Mon, 15 Feb 2016 12:52:31 -0500 Received: from mout.gmx.net ([212.227.15.15]:50284) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVNK2-0005aU-Ao for 22534@debbugs.gnu.org; Mon, 15 Feb 2016 12:52:30 -0500 Received: from detlef.gmx.de ([87.146.43.79]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LanoO-1a7MFT0rSC-00kOZ7; Mon, 15 Feb 2016 18:52:23 +0100 From: Michael Albinus References: <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <83io1w9y1l.fsf@gnu.org> <87egce0z4b.fsf@gmx.de> <8360xqx8ul.fsf@gnu.org> Date: Mon, 15 Feb 2016 18:52:21 +0100 In-Reply-To: <8360xqx8ul.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Feb 2016 17:59:46 +0200") Message-ID: <8760xp2756.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:Wnjl7ddQSJsxszsSkCmzbZDCv+pCWnWbMs+TVskygwTLTUnyMeM LO/2zhrrPDC8/uWfM5xUSmRIqMDmP/DBO+Kxs0W7+WxURUSOP/vYJlXu01+EVnbQEBd0vQj mSydObc4J65NejOvi9Ez26KsN+t0CMZtGLyiqBjfm4hsW+nYUtqGtDTJ+urLgQhPUN5T9Mj 8cYmvqAnu//3XDaWp70Xw== X-UI-Out-Filterresults: notjunk:1;V01:K0:AFRW86EbRt8=:g50wivxqLJcdqEkEp2C3JR XwV8mrFBbfTXPSFBC56/bd0lXehPO0sZ0pC9lCD2mjA214URsy9J05CFJIsGXN7i+xabpVEB4 bKM6ZNYvTFphdSNyD7R48R2Z0d5DSqeN/qoa/ZTvhd3zKZxx58J/EgGk8c2ujf+uUUlEJFl1n Lvbzc+kB3xOHeh2VXi0W34XKUME3PuMnmo6DBKARUtMZxYgt3p3erhKFiPeUCOY3DuVxNn9QO 8mvXAuepEj6TyPdRdv02rBnWeBPrxF+F9mfBIpJ/sWQXHkDw5MCUX1GdipBIwhUUzw0a8HIvG uI9FVjn6gQGCrG16o6GHtmMap7/oIE9bYz3O5xNeZKR1Pj/nSdqfrlEjX9yYBVuX3s1PhkyF5 qDQT1thRSnNYdTHFAlA1hi+xXOKAUZ33kjOdt6p7MHuj64DwxxguvKMx0EJpZoI07Ijr8bQEZ ZyoWndK2bmKADLFxmdJlAo/iNADHFFG9iRED20juQktqeP2HhfTjm4aUKAeuu0N9Q8IPLlmUV UimVZJ9gxDwDWGOq54f+7CY5IQiTR+qQk1XKIZnVjfVIfofAbWcIErOa3VTDM8CuEo71yXd1G Wvho7597EMnESV74s/kn7YQE91NgQcP42ziXxhWW0fBGWE1CQfUtCH7uFvTaOmvZtDQTRKH8a Nn5poRh0aYfZ18fL/OHmxGkeQp3FOS7Mrw+XBL5gE9adEv775uDIe7dcQkzUfxfI+mAofJTzv 74T1VnasuEhBM0aynp0i1mVZ5P40nutJuduaDwWxk2DTF2hgvht+L+ZSHUfbGMlh7EOcGbk+L fWgGns3 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Not by me, as long as I don't see the problem on my machine. If > Fabrice could find time debugging this, I will be glad to help by > explaining the code in w32notify.c and elsewhere that is related to > injecting the notification events on w32. So I let this decision to Fabrice. Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Feb 2016 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14555656046490 (code B ref 22534); Mon, 15 Feb 2016 19:47:02 +0000 Received: (at 22534) by debbugs.gnu.org; 15 Feb 2016 19:46:44 +0000 Received: from localhost ([127.0.0.1]:40456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVP6a-0001gc-Ds for submit@debbugs.gnu.org; Mon, 15 Feb 2016 14:46:44 -0500 Received: from mail-ob0-f176.google.com ([209.85.214.176]:34764) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aVP6Y-0001gP-PO for 22534@debbugs.gnu.org; Mon, 15 Feb 2016 14:46:43 -0500 Received: by mail-ob0-f176.google.com with SMTP id wb13so227138804obb.1 for <22534@debbugs.gnu.org>; Mon, 15 Feb 2016 11:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=d/ckLu3ylZrRZKqNEDU2yM/x5fQjnvuxmPg3dUTFtiY=; b=lQP9400waADgA4xVWgeaSzJEnPlyC90hraaIVGb+oIe0JJYR4mEdNCuB605VBhoiI0 1CYGzwEC9elip+5F6LwBgMOJjGhWQh8SiQmNQqf7zm44XpcnRYi8aMRv0O+LsB5lQVrq 0cOfL3aocoBBioRKcEJlwkWHjspU+eYtL/2gfF70IvfDL54nt4p/sblWfepcQbf/UxKJ jUZFIFevRwU7mvV9M0WDaGH5P4xLi5ewJrQQZ9nW4TLKdVB47H13oO+H/L8CXg122gSQ czv8/m2Xpx+WM72S24fRvN+9ALLOU6FFGngyh+ByMJtagi0DPGKO0L+JaRwciZYLKvU7 UXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=d/ckLu3ylZrRZKqNEDU2yM/x5fQjnvuxmPg3dUTFtiY=; b=QZlLMyejM7ZrvoCLmLD8TVIc5CfQF+fC3lUMK3CTzB8Ny4o68qU0F3dRWy92ilbB+1 G/HmqWxzQdkT80InzaRDxa2GZ9KDqmxvwgHdCE9PDastEYQaO2nzEGRKFiKT+/wJVJWM rU/Ft21SqiHEgS/GFwcFp4faWLsyFkQM+UhWrCZH416rrw21AKd27ed55In31lkYN8K4 7bSvqw0NH8PgWlZzd1eF9BV0saiMZbd1okKS4nlLSsyZb6myfR29bjcaW6jDP/hJbXnA 4zm+1giWfK/aPs9MmRq9OpjmubaH2JfVUh8ecdHXTCkPTUfYQ7A5Y+kBX/hGHe3mWBXU fckQ== X-Gm-Message-State: AG10YOTth/abGhUoIBHAnWgstVCNC17sS2vMxqZsWTz4IoMUuLOCIkt/AI2JWRcnG4OdGyv+SrtYrURmZEKbeg== X-Received: by 10.182.51.138 with SMTP id k10mr6512799obo.76.1455565597101; Mon, 15 Feb 2016 11:46:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.131 with HTTP; Mon, 15 Feb 2016 11:46:17 -0800 (PST) In-Reply-To: <8760xp2756.fsf@gmx.de> References: <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> <83a8ncs9b4.fsf@gnu.org> <871t8nwl80.fsf@gmx.de> <831t8nqdk3.fsf@gnu.org> <83io1w9y1l.fsf@gnu.org> <87egce0z4b.fsf@gmx.de> <8360xqx8ul.fsf@gnu.org> <8760xp2756.fsf@gmx.de> From: Fabrice Popineau Date: Mon, 15 Feb 2016 20:46:17 +0100 Message-ID: Content-Type: multipart/alternative; boundary=047d7bfeb70a5cd650052bd446c7 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bfeb70a5cd650052bd446c7 Content-Type: text/plain; charset=UTF-8 2016-02-15 18:52 GMT+01:00 Michael Albinus : > Eli Zaretskii writes: > > > Not by me, as long as I don't see the problem on my machine. If > > Fabrice could find time debugging this, I will be glad to help by > > explaining the code in w32notify.c and elsewhere that is related to > > injecting the notification events on w32. > > So I let this decision to Fabrice. > > I will return to my previous investigation of this problem (after bug 22526 interruption) Can't guarantee that I can come with something in a short time however Fabrice --047d7bfeb70a5cd650052bd446c7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-02-15 18:52 GMT+01:00 Michael Albinus <michael.albinus@gmx.d= e>:
Eli Za= retskii <eliz@gnu.org> writes:
> Not by me, as long as I don't see the problem on my machine.=C2=A0= If
> Fabrice could find time debugging this, I will be glad to help by
> explaining the code in w32notify.c and elsewhere that is related to > injecting the notification events on w32.

So I let this decision to Fabrice.


I will return to my previous investiga= tion of this problem (after bug 22526 interruption)
Can't gua= rantee that I can come with something in a short time however

Fabrice
--047d7bfeb70a5cd650052bd446c7-- From unknown Tue Jun 17 01:49:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22534: File notify broken on Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Mar 2016 07:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Fabrice Popineau Cc: Eli Zaretskii , 22534@debbugs.gnu.org Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14574230808121 (code B ref 22534); Tue, 08 Mar 2016 07:45:01 +0000 Received: (at 22534) by debbugs.gnu.org; 8 Mar 2016 07:44:40 +0000 Received: from localhost ([127.0.0.1]:38583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adCJs-00026v-BH for submit@debbugs.gnu.org; Tue, 08 Mar 2016 02:44:40 -0500 Received: from mout.gmx.net ([212.227.15.19]:54712) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adCJq-00026j-Rg for 22534@debbugs.gnu.org; Tue, 08 Mar 2016 02:44:39 -0500 Received: from detlef.gmx.de ([87.146.56.63]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MMCFR-1aVnv833sL-007zIK; Tue, 08 Mar 2016 08:44:31 +0100 From: Michael Albinus References: <83egcbun0o.fsf@gnu.org> <8360xnukzx.fsf@gnu.org> <83a8mvprbg.fsf@gnu.org> <83oabbnxvs.fsf@gnu.org> <83io1glmkg.fsf@gnu.org> <87y4abtwhq.fsf@gmx.de> <8337sjjsql.fsf@gnu.org> <87ziuc3gay.fsf@gmx.de> <83twkkwxdi.fsf@gnu.org> <83mvqcwa2v.fsf@gnu.org> Date: Tue, 08 Mar 2016 08:44:30 +0100 In-Reply-To: (Fabrice Popineau's message of "Tue, 8 Mar 2016 06:45:52 +0100") Message-ID: <8760wxv2g1.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:b0TPWhi/Z/hUGTew3D94XJBOjt5k2cRXzvv3VfHtCROW2iQCWsZ lXN4qGNN76xqFyPM7Yj/yFxJmHYmRWqEQ9lmtNpGrhQFsmQ7Eo104PFEG90tM0pkT3vi45N PBaXhKXO4UCSu0avQMxdoj7Pdx4AgfcExeJ/udH9T1yv4BFpz8fl9EzdJkwq3UwL/wM48nk QQkba2o401B/W/bd/0PCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:CeEN0QjX+8o=:iggLrHO90MFD+SqZzKmhn/ D7RfJjR3keD7W6aS96HghbDowvXGeRwgtchcMzyPlhAeB3MV9JwJXBI35BqF8VLybFPB/dxUc ocRS9nYG3pd6Pqic3kbRNqy+aoo3K0fUFyQV2FRNUGxtwzw5gnpbjbDbBLNnyq5zhKi2H7ym2 wkNpVhd+6Bui9I6iMr1NHnHGzzKTMU+OOCLMYoeuhPY6aCgjwS2MZCGvzotm+hmcL0SvnRfjK 8G6/nnRHYNdTuOCzYkgpLRfA0DN34bY+qR33e+0yt4KYSC510+KrLm39HgsjZKV6X8u10hwak kkdHe2Czb2BfDGsl68sjFSjS/UrZpSHbcIpjRdl2COo3FL0CHxOlxjbQ3DTXmhHUfb6VThm1J 8dP9CzGmZ1nrDZlvOPGyE1iRnHP4BMupgsF3cOI2isD1KeH+WyMbkuAiBxgtAVfBBcNBPf6Q+ 14l2b5WYjh46i9wZ5uWOHAscplEEZB7qEyzueIZqPxyfXDNJX9QdcHu6ulrhHgXdEkxgkO/l1 QcRFta1XexYUh7XI+W07RG9zXjU6bJERMEDMIM47rlb3ugWDdRE4e2DHSb2Di9va+hPw4HgBP 1MJkX5OBLCCOOsxMa0SSc67yULo3cJJO/WcY6CENs3qrFwntMDhWe0KUhu3AlI24allU6A/RQ r9ypch6s+cYcByXS9tM8x2p+C9TDuGE1z/aNs8vWOiTV7jmv3dBKwnY6C6yr2GwlApzmSscH8 bYiCsyXb4CrYd68eOoKBlXHlWO6oTPEGYu+C1c/JKsR33pQfDowhU6xTqMN/x8ZTdO/1r2eR3 TzDMt6u X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fabrice Popineau writes: [Added 22534@debbugs.gnu.org to Cc] > Ok, patch attached. > > The remaining DebPrint() should be left in case of problems. > They all indicate some sort of error (I think). > > I have a disagreement on this test: > > diff --git a/test/lisp/filenotify-tests.el > b/test/lisp/filenotify-tests.el > index bc64f86..20e01fc 100644 > --- a/test/lisp/filenotify-tests.el > +++ b/test/lisp/filenotify-tests.el > @@ -530,7 +530,7 @@ file-notify--test-with-events > ;; w32notify does not distinguish between `changed' and > ;; `attribute-changed'. > ((string-equal (file-notify--test-library) "w32notify") > - '(changed changed changed changed)) > + '(changed changed)) > ;; For kqueue and in the remote case, `write-region' > ;; raises also an `attribute-changed' event. > ((or (string-equal (file-notify--test-library) "kqueue") > > At least on Windows 10, I get only 2 notifications and not 4. > Could you or Michael check about it? As soon as I get a compiled Emacs for w32, including your patch, I'll test it. It will be on a Windows 7 machine, hope there are no differences to your test. > Best regards, Best regards, Michael. From unknown Tue Jun 17 01:49:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Fabrice Popineau Subject: bug#22534: closed (Re: bug#22534: File notify broken on Windows) Message-ID: References: <87twk234hr.fsf@gmx.de> X-Gnu-PR-Message: they-closed 22534 X-Gnu-PR-Package: emacs Reply-To: 22534@debbugs.gnu.org Date: Sat, 19 Mar 2016 14:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1458399122-20818-1" This is a multi-part message in MIME format... ------------=_1458399122-20818-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #22534: File notify broken on Windows which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 22534@debbugs.gnu.org. --=20 22534: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22534 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1458399122-20818-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 22534-done) by debbugs.gnu.org; 19 Mar 2016 14:51:54 +0000 Received: from localhost ([127.0.0.1]:53801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahIEM-0005PS-9a for submit@debbugs.gnu.org; Sat, 19 Mar 2016 10:51:54 -0400 Received: from mout.gmx.net ([212.227.17.20]:65214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahIEJ-0005PD-Vw for 22534-done@debbugs.gnu.org; Sat, 19 Mar 2016 10:51:52 -0400 Received: from detlef.gmx.de ([79.195.13.135]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LyVcA-1Zlakh1MyU-015t7g; Sat, 19 Mar 2016 15:51:45 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#22534: File notify broken on Windows References: <83a8mvprbg.fsf@gnu.org> <83oabbnxvs.fsf@gnu.org> <83io1glmkg.fsf@gnu.org> <87y4abtwhq.fsf@gmx.de> <8337sjjsql.fsf@gnu.org> <87ziuc3gay.fsf@gmx.de> <83twkkwxdi.fsf@gnu.org> <83mvqcwa2v.fsf@gnu.org> <83r3fil7z3.fsf@gnu.org> <83bn6ljbku.fsf@gnu.org> <83fuvm8wjx.fsf@gnu.org> Date: Sat, 19 Mar 2016 15:51:44 +0100 In-Reply-To: <83fuvm8wjx.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Mar 2016 14:46:42 +0200") Message-ID: <87twk234hr.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:X3GEoqU2IzLU0wbbaeeCPYP9LdzIYxAABIL2SkhjxxtFAmClbuj xezl+cBR8oP7gOgfYUGW9VGKBQXxV/ESUA7OnGNxhwG1uczbq2HyHu/X5ij5Rr9fiEoOtq4 JdJWE3CxkySo0ImGiiKL62GILxQ8ogkVI3/p/9TWMu5pAu0X55yFoEWGez/NSB6t2o5zfjh jvrdNczignfo0mPGCy+Dg== X-UI-Out-Filterresults: notjunk:1;V01:K0:CcIb7GBf/jM=:p5h4FCOZHM1EyCkHk+2Dip W1SX7mPRloXQwP/wWEOchD8Dea4ljwONVCVf6GvokUM2MPvCvh3B+lLJnjxU4NJPdd7W+sRQI 3QXBAleCc3GQwBjYqh7Kf9QJrqrUGQRR2dhWDxvLwtkBvjBNcz/a+QMqA3zJUeynHKlA7acGJ cBAa/URbGr/g1buArU/8RTCGXrCGP2b6FF/cK0y65d77QclejpMC10/FgtYMvnEIZGWJVjvT6 5MZWrWiOgKO14vSF2Ec8m/goODi1y2UgJO558xA5x9QZIo3+2VJubhk45e0ZqIdaNmq1mJFsM vksGvCDgBmpB4Sa1PbyMdE+on6mI9mxV6Bqczttl3ljZW6elUlnxt915YSvjEmb/o6HKSTR30 +2BE4EEtY4kELsY+mwc8Ug+zRu/KmJjPGXcTEqh2awjtXum6xXi095XTdFAFgRZAtENRW0f3O TE08FRMq1KJYJTGozLlJ63EMrMcJ+dAv+7RLF25SKVrZ/ZP0t0IQ8QvYnt9nYGOZ2RUsUMi1a AHupuJR+ioNbE4+psa5DV1nuPZTLKJeX0cndu9DlcfBPyy0Q0xAfFWkG1DzpaE64Q2NHGrwbh YviRO3NZqVfTWWbA2nYVfB7THYJU5BRU9Pl/XIvSdDfJTTwrYfyIUjoyHHsaXjaovKYn/Cntz tPz/CII8UJNt1htgVv4vhIXuBjGGPTfI4ulGlyV4zImDU2yONyMpb/5Zj/IM7cLiHEYDIXFP5 O1rSTT0HKGw1FAVUesZTYmw9JPJxE8kvx+tSHGXBZYwaQxt5KIYc6ydZoj00UrmQYGSQ3kPsY hAz9FvG X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22534-done Cc: Fabrice Popineau , 22534-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> New patch attached against master. To mirror malloc(), free() is >> called instead >> of xfree(). > > Thanks, pushed. Thanks to both of you. I'm closing the bug. Best regards, Michael. ------------=_1458399122-20818-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Feb 2016 06:24:14 +0000 Received: from localhost ([127.0.0.1]:55627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQUNq-0008MW-1h for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39045) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQUNo-0008MI-Rq for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQUNi-0001hK-Ar for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUNi-0001hG-7H for submit@debbugs.gnu.org; Tue, 02 Feb 2016 01:24:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUNg-0000kn-Tf for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 01:24:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQUNf-0001h3-IZ for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 01:24:04 -0500 Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:35425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQUNf-0001gz-BK for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 01:24:03 -0500 Received: by mail-ob0-x236.google.com with SMTP id xk3so40849815obc.2 for ; Mon, 01 Feb 2016 22:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=ZlbK1ZDOgl8S4hIos2vQm/ErCehHCxOEuSyWqRLWdrM=; b=rVwkR9vTGY/901UfDTx52E/kFYiV+XtSefOhCyNprk66SjjZmi1SVuaUwZ1dL7vcY9 ZPcrGDZklEgNsRjOtm2B0eZ4eE2wBzsfD+6gLYkNZmCeZ1XXueKWBWI8A3kVhI8R/GV7 wXxRI3Bfut9fDwtQlFvtayIgD6estnpHZqb0ezhs3sWc7VXrWS0xfojf7d6XdOVfjlQp opwiSAkTOn/GxBtm0VFpvlTs0h7+1cuC5LueB3a7PWEhOrcK4hBOCOlMHJQcgL3emn4I giDHDL9tQjIO7n14IVt9GVthUI9GKu5cOOE4l7xbta5RB6gUOdwKz2+668CRORutiaVp Xu+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=ZlbK1ZDOgl8S4hIos2vQm/ErCehHCxOEuSyWqRLWdrM=; b=RJip99QoYGc4Owb6pdRX95XfKUkubsbruKKN3Fg2iYyJblAl+OgbCSErTjRfY/5avI Q9Nura9LYMYk8kqX10MOHN7CBA1LCkGGQn+HqTSjnYeVV0wKksE7d9XXJw8TQ+ju7w93 i3xf7u4G5O6D0nftJ1EKTYXfUQkab65M3otC2HgYUAwcwvW4JX1ssN8er+wAjRQJ62DE REj3FCn/xDlLtwdDVGTd3eHTWnr/NbqXckG/ej3wxN4dwOn6JW6LOy+2ayp+wdEHRBUb opGpvG+gdL0e6iO3XHvFVtxhFZvq9iXY0rt3n9ZsvbHSevQ1pkT/KqLwzZI8Ug24tHtL W70g== X-Gm-Message-State: AG10YOT4wVRxVEZHXqfjG+tba29ZH5N9St6JtZREDyYNK3rvte85ZtMoQ2I6lvYaxS2cEIgI1I29f+j/iyPhNQ== X-Received: by 10.60.73.170 with SMTP id m10mr22409907oev.51.1454394242830; Mon, 01 Feb 2016 22:24:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.78.67 with HTTP; Mon, 1 Feb 2016 22:23:43 -0800 (PST) From: Fabrice Popineau Date: Tue, 2 Feb 2016 07:23:43 +0100 Message-ID: Subject: File notify broken on Windows To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=001a1135fd06351845052ac38c36 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a1135fd06351845052ac38c36 Content-Type: text/plain; charset=UTF-8 When I run 'make check', the process is stuck on filenotify tests. If I try to run the tests interactively, I have to hit 'Ctrl-g'. Emacs waits forever on the first test. In GNU Emacs 25.0.90.4 (x86_64-w64-mingw32) of 2016-02-02 built on LOBSANG Repository revision: 17b39a44e9106bae6c084441a29c5ec77f36a721 Windowing system distributor 'Microsoft Corp.', version 10.0.10586 Configured using: 'configure --prefix=/c/Local/Emacs --libexecdir=/c/Local/Emacs/bin --datarootdir=/c/Local/Emacs --localstatedir=/c/Local/Emacs --sysconfdir=/c/Local/Emacs/etc --with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2 --with-gnutls --without-imagemagick --enable-checking=no 'CFLAGS=-I/mingw64/include -fomit-frame-pointer -O3 -g0 -mtune=corei7' CPPFLAGS=-I/mingw64/include LDFLAGS=-L/mingw64/lib' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS Important settings: value of $LANG: fr_FR locale-coding-system: cp1252 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify dbusbind w32 multi-tty make-network-process emacs) Memory information: ((conses 16 88664 8174) (symbols 56 19615 0) (miscs 48 37 84) (strings 32 15795 4324) (string-bytes 1 424760) (vectors 16 11609) (vector-slots 8 411396 4797) (floats 8 161 40) (intervals 56 256 6) (buffers 976 12)) --001a1135fd06351845052ac38c36 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

When I run 'make check', the p= rocess is stuck on filenotify tests.
If I try to run the tests in= teractively, I have to hit 'Ctrl-g'.
Emacs waits forever = on the first test.



I= n GNU Emacs 25.0.90.4 (x86_64-w64-mingw32)
=C2=A0of 2016-02-02 bu= ilt on LOBSANG
Repository revision: 17b39a44e9106bae6c084441a29c5= ec77f36a721
Windowing system distributor 'Microsoft Corp.'= ;, version 10.0.10586
Configured using:
=C2=A0'conf= igure --prefix=3D/c/Local/Emacs --libexecdir=3D/c/Local/Emacs/bin
=C2=A0--datarootdir=3D/c/Local/Emacs --localstatedir=3D/c/Local/Emacs
=C2=A0--sysconfdir=3D/c/Local/Emacs/etc --with-jpeg --with-xpm --with= -png
=C2=A0--with-tiff --with-rsvg --with-xml2 --with-gnutls --wi= thout-imagemagick
=C2=A0--enable-checking=3Dno 'CFLAGS=3D-I/m= ingw64/include -fomit-frame-pointer
=C2=A0-O3 -g0 -mtune=3Dcorei7= ' CPPFLAGS=3D-I/mingw64/include
=C2=A0LDFLAGS=3D-L/mingw64/li= b'

Configured features:
XPM JPEG TIF= F GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_= SCROLL_BARS

Important settings:
=C2=A0 v= alue of $LANG: fr_FR
=C2=A0 locale-coding-system: cp1252

Major mode: Lisp Interaction

Mino= r modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 global= -eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mo= use-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-b= ar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 globa= l-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 bli= nk-cursor-mode: t
=C2=A0 auto-composition-mode: t
=C2= =A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t
=
=C2=A0 line-number-mode: t
=C2=A0 transient-mark-mode: t

Recent messages:
For information about GNU = Emacs and the GNU system, type C-h C-a.
Making completion list...=

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug messag= e dired format-spec rfc822 mml
mml-sec epg epg-config gnus-util m= m-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-ut= ils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-f= ns help-mode easymenu cl-loaddefs pcase
cl-lib mail-prsvr mail-ut= ils time-date mule-util tooltip eldoc electric
uniquify ediff-hoo= k vc-hooks lisp-float-type mwheel dos-w32 ls-lisp
disp-table w32-= win w32-vars term/common-win tool-bar dnd fontset image
regexp-op= t fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode= register page menu-bar rfn-eshadow timer select scroll-bar
mouse= jit-lock font-lock syntax facemenu font-core frame cl-generic cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
=
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa= -hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded na= dvice
loaddefs button faces cus-face macroexp files text-properti= es overlay
sha1 md5 base64 format env code-pages mule custom widg= et
hashtable-print-readable backquote w32notify dbusbind w32 mult= i-tty
make-network-process emacs)

Memory= information:
((conses 16 88664 8174)
=C2=A0(symbols 56= 19615 0)
=C2=A0(miscs 48 37 84)
=C2=A0(strings 32 1579= 5 4324)
=C2=A0(string-bytes 1 424760)
=C2=A0(vectors 16= 11609)
=C2=A0(vector-slots 8 411396 4797)
=C2=A0(float= s 8 161 40)
=C2=A0(intervals 56 256 6)
=C2=A0(buffers 9= 76 12))

--001a1135fd06351845052ac38c36-- ------------=_1458399122-20818-1--