GNU bug report logs - #225
23.0.60; tool bar icons missing or executing wrong commands

Previous Next

Full log

Message #11 received at 225-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Reiner Steib <reinersteib+gmane <at> imap.cc>,
        "Sebastian P. Luque" <spluque <at> gmail.com>,
        Juanma Barranquero <lekktu <at> gmail.com>,
        Tassilo Horn <thorn+news <at> fastmail.fm>,
        225-done <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: Tool-bar changes
Date: Tue, 13 May 2008 14:19:29 -0400

> The problem was the the use of plist-get and plist-put in
> tool-bar-make-keymap failed to account for the format of menu-item
> lists, which can contain an optional KEY-BINDING-DATA entry that screws
> up the property list ordering.  I just checked in a fix.

Thank you.  I wonder why it never hit me.... Oh yes now I remember:
I threw away this caching code in my own Emacs (I threw it out a long
time ago, i.e. when I added the where-is-internal reverse keymap cache,
since this made on-the-fly recomputation sufficiently fast for me to
make the cache unnecessary (or even harmful since it's not correctly
maaintained: when the cache key-sequence becomes invalid, it is
correclty thrown out, but if a key-sequence becomes later available,
the cache will prevent it from being discovered)).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.