GNU bug report logs - #225
23.0.60; tool bar icons missing or executing wrong commands

Previous Next

Full log

Message #10 received at 225-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Reiner Steib <reinersteib+gmane <at> imap.cc>,
        "Sebastian P. Luque" <spluque <at> gmail.com>,
        Juanma Barranquero <lekktu <at> gmail.com>,
        Tassilo Horn <thorn+news <at> fastmail.fm>,
        225-done <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: Tool-bar changes
Date: Tue, 13 May 2008 14:07:50 -0400

Chong Yidong <cyd <at> stupidchicken.com> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>> I've just installed a change in tool-bar.el which delays the call to
>> find-image.  Instead of being called in tool-bar-setup, it's now called
>> when looking up the tool-bar keymap.  This may also allow the toolbar
>> to use different icons on different displays (e.g. some color, some b&w)
>> in the same Emacs instance.
>
> This change did Something Bad to the tool-bar on i686-pc-linux-gnu, GTK+
> Version 2.12.9.  Only the Cut, Paste, Customize, and Help icons are now
> displayed on the tool-bar; the other images are missing.

The problem was the the use of plist-get and plist-put in
tool-bar-make-keymap failed to account for the format of menu-item
lists, which can contain an optional KEY-BINDING-DATA entry that screws
up the property list ordering.  I just checked in a fix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.