GNU bug report logs - #22481
25.1.50; vc-hg: emacs "deadlocks" after using hg with huge amounts of ignored files in the repo

Previous Next

Package: emacs;

Reported by: Jan Synacek <jsynacek <at> redhat.com>

Date: Thu, 28 Jan 2016 09:12:01 UTC

Severity: normal

Merged with 19304

Found in versions 25.0.50, 25.1.50

Fixed in version 25.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 22481 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Jan Synacek <jsynacek <at> redhat.com>, 22481 <at> debbugs.gnu.org
Subject: Re: bug#22481: 25.1.50; vc-hg: emacs "deadlocks" after using hg with
 huge amounts of ignored files in the repo
Date: Fri, 29 Jan 2016 04:53:58 +0300
On 01/28/2016 12:10 PM, Jan Synacek wrote:

> Emacs freezes because it's running 'hg status -mardui -C <files>'. The
> '-i' is the problem here. Since it takes hg itself a very long time, I'm
> not sure if it can be directly fixed in Emacs. But at least a
> configuration option that would allow one to disable the "-i" option
> would be nice.

Haven't we fixed this already? See 
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19304, I've fixed what I 
could reproduce.

The current definition of vc-hg-status-files looks like this:

(defun vc-hg-dir-status-files (dir files update-function)
  (apply 'vc-hg-command (current-buffer) 'async dir "status"
         (concat "-mardu" (if files "i"))
         "-C" files)
  (vc-run-delayed
    (vc-hg-after-dir-status update-function)))

IOW, we only pass '-i' when we ask the backend for the status of 
specific files. Which shouldn't be slow.

If it is, I'm pretty sure it's Mercurial's problem.

(You can add a (message "files: %s" files) call at the beginning of 
vc-hg-dir-status-files, to see what file list it's called with.





This bug report was last modified 9 years and 118 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.