GNU bug report logs - #22465
xwidget-webkit-scroll-behaviour = image is non-functional

Previous Next

Full log

View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 22465 <at> debbugs.gnu.org, Joakim Verona <joakim <at> verona.se>
Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional
Date: Fri, 06 May 2016 11:42:39 -0400

Paul Eggert wrote:

> Attached is a proposed patch for this bug. It is not fancy, but it
> works for me.

Thanks. I wonder if the 'image scrolling method should simply be
removed, since it doesn't work (to date) and isn't the default.
Are two methods really needed/useful?

> From 879895ad058294eb49d8372ef5dbf053973e45b9 Mon Sep 17 00:00:00 2001
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Thu, 5 May 2016 22:44:16 -0700
> Subject: [PATCH] Fix xwidget-webkit-scroll-forward infloop
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * lisp/xwidget.el (xwidget-webkit-scroll-forward)
> (xwidget-webkit-scroll-backward): Don't loop if
> xwidget-webkit-scroll-behavior's value is 'image' (Bug#22465).
> ---
>  lisp/xwidget.el | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
> index 19f631f..d64237a 100644
> --- a/lisp/xwidget.el
> +++ b/lisp/xwidget.el
> @@ -165,7 +165,7 @@ xwidget-webkit-scroll-forward
>    (interactive)
>    (if (eq xwidget-webkit-scroll-behavior 'native)
>        (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50)
> -    (xwidget-webkit-scroll-forward)))   ; FIXME infloop!
> +    (image-forward-hscroll 5)))
>  
>  (defun xwidget-webkit-scroll-backward ()
>    "Scroll webkit backwards.
> @@ -174,7 +174,7 @@ xwidget-webkit-scroll-backward
>    (interactive)
>    (if (eq xwidget-webkit-scroll-behavior 'native)
>        (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50)
> -    (xwidget-webkit-scroll-backward))) ; FIXME infloop!
> +    (image-backward-hscroll 5)))
>  
>  
>  ;; The xwidget event needs to go into a higher level handler

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.