From unknown Sun Jun 22 07:59:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2016 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22465@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145376400225388 (code B ref -1); Mon, 25 Jan 2016 23:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jan 2016 23:20:02 +0000 Received: from localhost ([127.0.0.1]:36456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNqQU-0006bF-82 for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:20:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53457) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNqQS-0006ar-Fy for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:20:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNqQM-0000qB-Ho for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:19:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNqQM-0000q7-Ef for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:19:54 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aNqQL-0004yk-Lr; Mon, 25 Jan 2016 18:19:53 -0500 From: Glenn Morris X-Spook: rs9512c AQIM Fusion Center Dock Legion of Doom X-Ran: g[PADIs,]I:5qh]S"${[GG=I;1Cz6r~qQ8T$i&p^KD#fa0O3lL:z{sE}R?an0llis1FrrM X-Hue: cyan X-Attribution: GM Date: Mon, 25 Jan 2016 18:19:53 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Package: emacs Version: 25.0.50 When xwidget-webkit-scroll-behavior = image, the functions xwidget-webkit-scroll-forward and xwidget-webkit-scroll-backward are obviously broken (they just call themselves recursively forever). From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 25 18:24:39 2016 Received: (at control) by debbugs.gnu.org; 25 Jan 2016 23:24:39 +0000 Received: from localhost ([127.0.0.1]:36464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNqUx-0006j6-9Y for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:24:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54498) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNqUw-0006iu-Gz for control@debbugs.gnu.org; Mon, 25 Jan 2016 18:24:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNqUq-0001nO-UT for control@debbugs.gnu.org; Mon, 25 Jan 2016 18:24:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNqUq-0001nK-R1 for control@debbugs.gnu.org; Mon, 25 Jan 2016 18:24:32 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aNqUq-0005QV-HE for control@debbugs.gnu.org; Mon, 25 Jan 2016 18:24:32 -0500 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 25 Jan 2016 18:24:32 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 22465 From unknown Sun Jun 22 07:59:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional References: In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 May 2016 05:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 22465@debbugs.gnu.org Received: via spool by 22465-submit@debbugs.gnu.org id=B22465.14625136945526 (code B ref 22465); Fri, 06 May 2016 05:49:02 +0000 Received: (at 22465) by debbugs.gnu.org; 6 May 2016 05:48:14 +0000 Received: from localhost ([127.0.0.1]:40988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayYcY-0001R4-4G for submit@debbugs.gnu.org; Fri, 06 May 2016 01:48:14 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayYcV-0001Qp-Ep for 22465@debbugs.gnu.org; Fri, 06 May 2016 01:48:12 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 91FCB160633; Thu, 5 May 2016 22:48:05 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id G7D-otlBkVRi; Thu, 5 May 2016 22:48:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BA5C116120A; Thu, 5 May 2016 22:48:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Y-GI2kKOnF13; Thu, 5 May 2016 22:48:04 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9BFE9160633; Thu, 5 May 2016 22:48:04 -0700 (PDT) From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <572C3010.6080604@cs.ucla.edu> Date: Thu, 5 May 2016 22:48:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090905020002000306020401" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------090905020002000306020401 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Attached is a proposed patch for this bug. It is not fancy, but it works for me. --------------090905020002000306020401 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-xwidget-webkit-scroll-forward-infloop.fix" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-xwidget-webkit-scroll-forward-infloop.fix" RnJvbSA4Nzk4OTVhZDA1ODI5NGViNDlkODM3MmVmNWRiZjA1Mzk3M2U0NWI5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDUgTWF5IDIwMTYgMjI6NDQ6MTYgLTA3MDAKU3ViamVjdDogW1BBVENI XSBGaXggeHdpZGdldC13ZWJraXQtc2Nyb2xsLWZvcndhcmQgaW5mbG9vcApNSU1FLVZlcnNp b246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVu dC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKKiBsaXNwL3h3aWRnZXQuZWwgKHh3aWRnZXQt d2Via2l0LXNjcm9sbC1mb3J3YXJkKQooeHdpZGdldC13ZWJraXQtc2Nyb2xsLWJhY2t3YXJk KTogRG9u4oCZdCBsb29wIGlmCnh3aWRnZXQtd2Via2l0LXNjcm9sbC1iZWhhdmlvcuKAmXMg dmFsdWUgaXMg4oCYaW1hZ2XigJkgKEJ1ZyMyMjQ2NSkuCi0tLQogbGlzcC94d2lkZ2V0LmVs IHwgNCArKy0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2xpc3AveHdpZGdldC5lbCBiL2xpc3AveHdpZGdldC5lbApp bmRleCAxOWY2MzFmLi5kNjQyMzdhIDEwMDY0NAotLS0gYS9saXNwL3h3aWRnZXQuZWwKKysr IGIvbGlzcC94d2lkZ2V0LmVsCkBAIC0xNjUsNyArMTY1LDcgQEAgeHdpZGdldC13ZWJraXQt c2Nyb2xsLWZvcndhcmQKICAgKGludGVyYWN0aXZlKQogICAoaWYgKGVxIHh3aWRnZXQtd2Vi a2l0LXNjcm9sbC1iZWhhdmlvciAnbmF0aXZlKQogICAgICAgKHh3aWRnZXQtc2V0LWFkanVz dG1lbnQgKHh3aWRnZXQtd2Via2l0LWxhc3Qtc2Vzc2lvbikgJ2hvcml6b250YWwgdCA1MCkK LSAgICAoeHdpZGdldC13ZWJraXQtc2Nyb2xsLWZvcndhcmQpKSkgICA7IEZJWE1FIGluZmxv b3AhCisgICAgKGltYWdlLWZvcndhcmQtaHNjcm9sbCA1KSkpCiAKIChkZWZ1biB4d2lkZ2V0 LXdlYmtpdC1zY3JvbGwtYmFja3dhcmQgKCkKICAgIlNjcm9sbCB3ZWJraXQgYmFja3dhcmRz LgpAQCAtMTc0LDcgKzE3NCw3IEBAIHh3aWRnZXQtd2Via2l0LXNjcm9sbC1iYWNrd2FyZAog ICAoaW50ZXJhY3RpdmUpCiAgIChpZiAoZXEgeHdpZGdldC13ZWJraXQtc2Nyb2xsLWJlaGF2 aW9yICduYXRpdmUpCiAgICAgICAoeHdpZGdldC1zZXQtYWRqdXN0bWVudCAoeHdpZGdldC13 ZWJraXQtbGFzdC1zZXNzaW9uKSAnaG9yaXpvbnRhbCB0IC01MCkKLSAgICAoeHdpZGdldC13 ZWJraXQtc2Nyb2xsLWJhY2t3YXJkKSkpIDsgRklYTUUgaW5mbG9vcCEKKyAgICAoaW1hZ2Ut YmFja3dhcmQtaHNjcm9sbCA1KSkpCiAKIAogOzsgVGhlIHh3aWRnZXQgZXZlbnQgbmVlZHMg dG8gZ28gaW50byBhIGhpZ2hlciBsZXZlbCBoYW5kbGVyCi0tIAoyLjcuNAoK --------------090905020002000306020401-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 06 01:49:54 2016 Received: (at control) by debbugs.gnu.org; 6 May 2016 05:49:54 +0000 Received: from localhost ([127.0.0.1]:40992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayYeA-0001TU-FH for submit@debbugs.gnu.org; Fri, 06 May 2016 01:49:54 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayYe9-0001TI-91 for control@debbugs.gnu.org; Fri, 06 May 2016 01:49:53 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E0A61160633 for ; Thu, 5 May 2016 22:49:47 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id OcwJSJY0vlso for ; Thu, 5 May 2016 22:49:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 49CFD16126F for ; Thu, 5 May 2016 22:49:47 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jfrU7oxoZiEk for ; Thu, 5 May 2016 22:49:47 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 30354160633 for ; Thu, 5 May 2016 22:49:47 -0700 (PDT) To: control@debbugs.gnu.org From: Paul Eggert Subject: 22465 has a patch Organization: UCLA Computer Science Department Message-ID: <572C307B.1070401@cs.ucla.edu> Date: Thu, 5 May 2016 22:49:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 22465 patch From unknown Sun Jun 22 07:59:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 May 2016 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 22465@debbugs.gnu.org, Joakim Verona Received: via spool by 22465-submit@debbugs.gnu.org id=B22465.146254939613667 (code B ref 22465); Fri, 06 May 2016 15:44:02 +0000 Received: (at 22465) by debbugs.gnu.org; 6 May 2016 15:43:16 +0000 Received: from localhost ([127.0.0.1]:41936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayhuO-0003YN-1i for submit@debbugs.gnu.org; Fri, 06 May 2016 11:43:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayhuL-0003YA-Td for 22465@debbugs.gnu.org; Fri, 06 May 2016 11:43:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayhu7-0002dW-Fo for 22465@debbugs.gnu.org; Fri, 06 May 2016 11:43:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayhtv-0002Yy-6W; Fri, 06 May 2016 11:42:47 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ayhtn-0002BC-RF; Fri, 06 May 2016 11:42:40 -0400 From: Glenn Morris References: <572C3010.6080604@cs.ucla.edu> X-Spook: Gangs 2600 Magazine sweep Centro Foot and Mouth pink X-Ran: qPbZ:=8`|(vc9Ow|$/_#OmX}S X-Hue: yellow X-Attribution: GM Date: Fri, 06 May 2016 11:42:39 -0400 In-Reply-To: <572C3010.6080604@cs.ucla.edu> (Paul Eggert's message of "Thu, 5 May 2016 22:48:00 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.1 (-------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.1 (-------) Paul Eggert wrote: > Attached is a proposed patch for this bug. It is not fancy, but it > works for me. Thanks. I wonder if the 'image scrolling method should simply be removed, since it doesn't work (to date) and isn't the default. Are two methods really needed/useful? > From 879895ad058294eb49d8372ef5dbf053973e45b9 Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Thu, 5 May 2016 22:44:16 -0700 > Subject: [PATCH] Fix xwidget-webkit-scroll-forward infloop > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > * lisp/xwidget.el (xwidget-webkit-scroll-forward) > (xwidget-webkit-scroll-backward): Don't loop if > xwidget-webkit-scroll-behavior's value is 'image' (Bug#22465). > --- > lisp/xwidget.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/xwidget.el b/lisp/xwidget.el > index 19f631f..d64237a 100644 > --- a/lisp/xwidget.el > +++ b/lisp/xwidget.el > @@ -165,7 +165,7 @@ xwidget-webkit-scroll-forward > (interactive) > (if (eq xwidget-webkit-scroll-behavior 'native) > (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50) > - (xwidget-webkit-scroll-forward))) ; FIXME infloop! > + (image-forward-hscroll 5))) > > (defun xwidget-webkit-scroll-backward () > "Scroll webkit backwards. > @@ -174,7 +174,7 @@ xwidget-webkit-scroll-backward > (interactive) > (if (eq xwidget-webkit-scroll-behavior 'native) > (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50) > - (xwidget-webkit-scroll-backward))) ; FIXME infloop! > + (image-backward-hscroll 5))) > > > ;; The xwidget event needs to go into a higher level handler From unknown Sun Jun 22 07:59:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Resent-From: joakim@verona.se Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 May 2016 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Glenn Morris Cc: 22465@debbugs.gnu.org, Paul Eggert Received: via spool by 22465-submit@debbugs.gnu.org id=B22465.146255706032361 (code B ref 22465); Fri, 06 May 2016 17:51:02 +0000 Received: (at 22465) by debbugs.gnu.org; 6 May 2016 17:51:00 +0000 Received: from localhost ([127.0.0.1]:42008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayju0-0008Pt-BR for submit@debbugs.gnu.org; Fri, 06 May 2016 13:51:00 -0400 Received: from mx2.bahnhof.se ([213.80.101.12]:5063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayjtv-0008Pe-9t for 22465@debbugs.gnu.org; Fri, 06 May 2016 13:50:58 -0400 Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id E81AE41A3D; Fri, 6 May 2016 19:50:53 +0200 (CEST) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF1) X-Spam-Score: 0.668 X-Spam-Level: X-Spam-Status: No, score=0.668 tagged_above=-99 required=5 tests=[AWL=-0.188, DNS_FROM_AHBL_RHSBL=0.306, NO_REAL_NAME=0.55] Received: from mf1.bahnhof.se ([127.0.0.1]) by localhost (mf1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 048rS8vXOkBD; Fri, 6 May 2016 19:50:48 +0200 (CEST) Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf1.bahnhof.se (Postfix) with ESMTP id 5F673330AD8; Fri, 6 May 2016 19:50:43 +0200 (CEST) Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id A74874F0FC7; Fri, 6 May 2016 17:50:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WV3aNuT-DmFN; Fri, 6 May 2016 19:50:25 +0200 (CEST) Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id C8D724F0FC4; Fri, 6 May 2016 19:50:25 +0200 (CEST) From: joakim@verona.se References: <572C3010.6080604@cs.ucla.edu> Date: Fri, 06 May 2016 19:50:25 +0200 In-Reply-To: (Glenn Morris's message of "Fri, 06 May 2016 11:42:39 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Glenn Morris writes: > Paul Eggert wrote: > >> Attached is a proposed patch for this bug. It is not fancy, but it >> works for me. > > Thanks. I wonder if the 'image scrolling method should simply be > removed, since it doesn't work (to date) and isn't the default. > Are two methods really needed/useful? Short version: It is probably just as well to remove the 'image method. Long version: The 'image method was the original scrolling method, which simply makes a large xwidget and scrolls it using the same method as emacs uses to scroll images. I liked this method because it was consistent with other Emacs scrolling. The 'native method lets webkit do the scrolling. Originally I used the 'image method myself and added the 'native method because users wanted it. Now I never use 'image, only 'native. Perhaps someone still prefers the 'image method though. > >> From 879895ad058294eb49d8372ef5dbf053973e45b9 Mon Sep 17 00:00:00 2001 >> From: Paul Eggert >> Date: Thu, 5 May 2016 22:44:16 -0700 >> Subject: [PATCH] Fix xwidget-webkit-scroll-forward infloop >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> >> * lisp/xwidget.el (xwidget-webkit-scroll-forward) >> (xwidget-webkit-scroll-backward): Don't loop if >> xwidget-webkit-scroll-behavior's value is 'image' (Bug#22465). >> --- >> lisp/xwidget.el | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lisp/xwidget.el b/lisp/xwidget.el >> index 19f631f..d64237a 100644 >> --- a/lisp/xwidget.el >> +++ b/lisp/xwidget.el >> @@ -165,7 +165,7 @@ xwidget-webkit-scroll-forward >> (interactive) >> (if (eq xwidget-webkit-scroll-behavior 'native) >> (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50) >> - (xwidget-webkit-scroll-forward))) ; FIXME infloop! >> + (image-forward-hscroll 5))) >> >> (defun xwidget-webkit-scroll-backward () >> "Scroll webkit backwards. >> @@ -174,7 +174,7 @@ xwidget-webkit-scroll-backward >> (interactive) >> (if (eq xwidget-webkit-scroll-behavior 'native) >> (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50) >> - (xwidget-webkit-scroll-backward))) ; FIXME infloop! >> + (image-backward-hscroll 5))) >> >> >> ;; The xwidget event needs to go into a higher level handler -- Joakim Verona From unknown Sun Jun 22 07:59:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 May 2016 00:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: joakim@verona.se, Glenn Morris Cc: 22465@debbugs.gnu.org Received: via spool by 22465-submit@debbugs.gnu.org id=B22465.146266691712206 (code B ref 22465); Sun, 08 May 2016 00:22:02 +0000 Received: (at 22465) by debbugs.gnu.org; 8 May 2016 00:21:57 +0000 Received: from localhost ([127.0.0.1]:43000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azCTt-0003An-1H for submit@debbugs.gnu.org; Sat, 07 May 2016 20:21:57 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azCTq-0003AX-Gf for 22465@debbugs.gnu.org; Sat, 07 May 2016 20:21:56 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 11ED016120E; Sat, 7 May 2016 17:21:48 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id H1VAQhVpGpbE; Sat, 7 May 2016 17:21:46 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7112A161210; Sat, 7 May 2016 17:21:46 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mR6OOpmlvIrB; Sat, 7 May 2016 17:21:46 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4274E16120E; Sat, 7 May 2016 17:21:46 -0700 (PDT) References: <572C3010.6080604@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <572E8699.5090209@cs.ucla.edu> Date: Sat, 7 May 2016 17:21:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------070000050909070707010008" X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------070000050909070707010008 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit joakim@verona.se wrote: > Perhaps someone still prefers the 'image method though. This seems unlikely, given that it recurses infinitely whenever it scrolls left or right. Anyway, thanks for following up. If nobody objects I would like to install the attached patch to emacs-25 to remove xwidget-webkit-scroll-behavior and therefore fix the bug. --------------070000050909070707010008 Content-Type: text/x-diff; name="0001-Remove-buggy-non-native-image-scrolling.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Remove-buggy-non-native-image-scrolling.patch" >From 58b7ecc4bcba46c775a7edca209587f034185861 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 7 May 2016 17:17:55 -0700 Subject: [PATCH] Remove buggy non-native image scrolling This never worked, and could cause infinite recursion. Problem reported by Glenn Morris (Bug#22465). * lisp/xwidget.el (xwidget-webkit-scroll-behavior): Remove. All uses removed. --- lisp/xwidget.el | 43 +++++++++---------------------------------- 1 file changed, 9 insertions(+), 34 deletions(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index 19f631f..7a0ca8b 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -34,13 +34,6 @@ (require 'cl-lib) (require 'bookmark) -(defcustom xwidget-webkit-scroll-behavior 'native - "Scrolling behavior of the webkit instance. -The possible values are: `native' or `image'." - :version "25.1" - :group 'frames ; TODO add xwidgets group if more options are added - :type '(choice (const native) (const image))) - (declare-function make-xwidget "xwidget.c" (type title width height arguments &optional buffer)) (declare-function xwidget-set-adjustment "xwidget.c" @@ -141,40 +134,24 @@ xwidget-webkit-mode-map "Keymap for `xwidget-webkit-mode'.") (defun xwidget-webkit-scroll-up () - "Scroll webkit up. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit up." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t 50) - (image-scroll-up))) + (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t 50)) (defun xwidget-webkit-scroll-down () - "Scroll webkit down. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit down." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t -50) - (image-scroll-down))) + (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t -50)) (defun xwidget-webkit-scroll-forward () - "Scroll webkit forwards. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit forwards." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50) - (xwidget-webkit-scroll-forward))) ; FIXME infloop! + (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50)) (defun xwidget-webkit-scroll-backward () - "Scroll webkit backwards. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit backwards." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50) - (xwidget-webkit-scroll-backward))) ; FIXME infloop! + (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50)) ;; The xwidget event needs to go into a higher level handler @@ -417,9 +394,7 @@ xwidget-webkit-adjust-size-to-content (defun xwidget-webkit-adjust-size-dispatch () "Adjust size according to mode." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-webkit-adjust-size-to-window) - (xwidget-webkit-adjust-size-to-content)) + (xwidget-webkit-adjust-size-to-window) ;; The recenter is intended to correct a visual glitch. ;; It errors out if the buffer isn't visible, but then we don't get ;; the glitch, so silence errors. -- 2.7.4 --------------070000050909070707010008-- From unknown Sun Jun 22 07:59:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Glenn Morris Subject: bug#22465: closed (Re: xwidget-webkit-scroll-behaviour = image is non-functional) Message-ID: References: <4d8e9b42-2db2-6631-d630-f60382324377@cs.ucla.edu> X-Gnu-PR-Message: they-closed 22465 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 22465@debbugs.gnu.org Date: Fri, 13 May 2016 16:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1463158442-4530-1" This is a multi-part message in MIME format... ------------=_1463158442-4530-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #22465: xwidget-webkit-scroll-behaviour =3D image is non-functional which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 22465@debbugs.gnu.org. --=20 22465: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22465 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1463158442-4530-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 22465-done) by debbugs.gnu.org; 13 May 2016 16:53:49 +0000 Received: from localhost ([127.0.0.1]:50174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1GLV-0001Af-01 for submit@debbugs.gnu.org; Fri, 13 May 2016 12:53:49 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1GLT-0001AR-F8 for 22465-done@debbugs.gnu.org; Fri, 13 May 2016 12:53:48 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D13121612A2; Fri, 13 May 2016 09:53:41 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id U_jcvN3FHdNN; Fri, 13 May 2016 09:53:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 125C11612C8; Fri, 13 May 2016 09:53:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PAhfDMEzgoho; Fri, 13 May 2016 09:53:40 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EE2871612A6; Fri, 13 May 2016 09:53:40 -0700 (PDT) Subject: Re: xwidget-webkit-scroll-behaviour = image is non-functional To: joakim@verona.se References: <572C3010.6080604@cs.ucla.edu> <572E8699.5090209@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <4d8e9b42-2db2-6631-d630-f60382324377@cs.ucla.edu> Date: Fri, 13 May 2016 09:53:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22465-done Cc: 22465-done@debbugs.gnu.org, Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On 05/13/2016 01:05 AM, joakim@verona.se wrote: > I agree, please install this fix. Thanks, installed, and closing the bug. ------------=_1463158442-4530-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Jan 2016 23:20:02 +0000 Received: from localhost ([127.0.0.1]:36456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNqQU-0006bF-82 for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:20:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53457) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNqQS-0006ar-Fy for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:20:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNqQM-0000qB-Ho for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:19:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNqQM-0000q7-Ef for submit@debbugs.gnu.org; Mon, 25 Jan 2016 18:19:54 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aNqQL-0004yk-Lr; Mon, 25 Jan 2016 18:19:53 -0500 From: Glenn Morris To: submit@debbugs.gnu.org Subject: xwidget-webkit-scroll-behaviour = image is non-functional X-Spook: rs9512c AQIM Fusion Center Dock Legion of Doom X-Ran: g[PADIs,]I:5qh]S"${[GG=I;1Cz6r~qQ8T$i&p^KD#fa0O3lL:z{sE}R?an0llis1FrrM X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 25 Jan 2016 18:19:53 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Package: emacs Version: 25.0.50 When xwidget-webkit-scroll-behavior = image, the functions xwidget-webkit-scroll-forward and xwidget-webkit-scroll-backward are obviously broken (they just call themselves recursively forever). ------------=_1463158442-4530-1-- From unknown Sun Jun 22 07:59:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Resent-From: joakim@verona.se Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 May 2016 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 22465@debbugs.gnu.org, Glenn Morris Received: via spool by 22465-submit@debbugs.gnu.org id=B22465.146342282013128 (code B ref 22465); Mon, 16 May 2016 18:21:02 +0000 Received: (at 22465) by debbugs.gnu.org; 16 May 2016 18:20:20 +0000 Received: from localhost ([127.0.0.1]:54227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2N7r-0003Pf-R8 for submit@debbugs.gnu.org; Mon, 16 May 2016 14:20:20 -0400 Received: from mx1.bahnhof.se ([213.80.101.11]:26624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2N7p-0003PX-OY for 22465@debbugs.gnu.org; Mon, 16 May 2016 14:20:18 -0400 Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx1-reinject (Postfix) with ESMTP id F0CC640D3B; Fri, 13 May 2016 10:08:08 +0200 (CEST) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF4) X-Spam-Score: 0.671 X-Spam-Level: X-Spam-Status: No, score=0.671 tagged_above=-99 required=5 tests=[AWL=-0.185, DNS_FROM_AHBL_RHSBL=0.306, NO_REAL_NAME=0.55] Received: from mf4.bahnhof.se ([127.0.0.1]) by localhost (mf4.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NbPd-C2xFL4M; Fri, 13 May 2016 10:08:02 +0200 (CEST) Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf4.bahnhof.se (Postfix) with ESMTP id 35D493D7972; Fri, 13 May 2016 10:05:32 +0200 (CEST) Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id 84A514F1778; Fri, 13 May 2016 08:05:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZLQfbLydGKEe; Fri, 13 May 2016 10:05:17 +0200 (CEST) Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id EAEF44F1777; Fri, 13 May 2016 10:05:16 +0200 (CEST) From: joakim@verona.se References: <572C3010.6080604@cs.ucla.edu> <572E8699.5090209@cs.ucla.edu> Date: Fri, 13 May 2016 10:05:16 +0200 In-Reply-To: <572E8699.5090209@cs.ucla.edu> (Paul Eggert's message of "Sat, 7 May 2016 17:21:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Paul Eggert writes: > joakim@verona.se wrote: >> Perhaps someone still prefers the 'image method though. > > This seems unlikely, given that it recurses infinitely whenever it scrolls left > or right. Anyway, thanks for following up. If nobody objects I would like to > install the attached patch to emacs-25 to remove xwidget-webkit-scroll-behavior > and therefore fix the bug. I agree, please install this fix. > > From 58b7ecc4bcba46c775a7edca209587f034185861 Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Sat, 7 May 2016 17:17:55 -0700 > Subject: [PATCH] Remove buggy non-native image scrolling > > This never worked, and could cause infinite recursion. > Problem reported by Glenn Morris (Bug#22465). > * lisp/xwidget.el (xwidget-webkit-scroll-behavior): Remove. > All uses removed. > --- > lisp/xwidget.el | 43 +++++++++---------------------------------- > 1 file changed, 9 insertions(+), 34 deletions(-) > > diff --git a/lisp/xwidget.el b/lisp/xwidget.el > index 19f631f..7a0ca8b 100644 > --- a/lisp/xwidget.el > +++ b/lisp/xwidget.el > @@ -34,13 +34,6 @@ > (require 'cl-lib) > (require 'bookmark) > > -(defcustom xwidget-webkit-scroll-behavior 'native > - "Scrolling behavior of the webkit instance. > -The possible values are: `native' or `image'." > - :version "25.1" > - :group 'frames ; TODO add xwidgets group if more options are added > - :type '(choice (const native) (const image))) > - > (declare-function make-xwidget "xwidget.c" > (type title width height arguments &optional buffer)) > (declare-function xwidget-set-adjustment "xwidget.c" > @@ -141,40 +134,24 @@ xwidget-webkit-mode-map > "Keymap for `xwidget-webkit-mode'.") > > (defun xwidget-webkit-scroll-up () > - "Scroll webkit up. > -Depending on the value of `xwidget-webkit-scroll-behavior', > -this scrolls in `native' fashion, or like `image-mode' would." > + "Scroll webkit up." > (interactive) > - (if (eq xwidget-webkit-scroll-behavior 'native) > - (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t 50) > - (image-scroll-up))) > + (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t 50)) > > (defun xwidget-webkit-scroll-down () > - "Scroll webkit down. > -Depending on the value of `xwidget-webkit-scroll-behavior', > -this scrolls in `native' fashion, or like `image-mode' would." > + "Scroll webkit down." > (interactive) > - (if (eq xwidget-webkit-scroll-behavior 'native) > - (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t -50) > - (image-scroll-down))) > + (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t -50)) > > (defun xwidget-webkit-scroll-forward () > - "Scroll webkit forwards. > -Depending on the value of `xwidget-webkit-scroll-behavior', > -this scrolls in `native' fashion, or like `image-mode' would." > + "Scroll webkit forwards." > (interactive) > - (if (eq xwidget-webkit-scroll-behavior 'native) > - (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50) > - (xwidget-webkit-scroll-forward))) ; FIXME infloop! > + (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50)) > > (defun xwidget-webkit-scroll-backward () > - "Scroll webkit backwards. > -Depending on the value of `xwidget-webkit-scroll-behavior', > -this scrolls in `native' fashion, or like `image-mode' would." > + "Scroll webkit backwards." > (interactive) > - (if (eq xwidget-webkit-scroll-behavior 'native) > - (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50) > - (xwidget-webkit-scroll-backward))) ; FIXME infloop! > + (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50)) > > > ;; The xwidget event needs to go into a higher level handler > @@ -417,9 +394,7 @@ xwidget-webkit-adjust-size-to-content > (defun xwidget-webkit-adjust-size-dispatch () > "Adjust size according to mode." > (interactive) > - (if (eq xwidget-webkit-scroll-behavior 'native) > - (xwidget-webkit-adjust-size-to-window) > - (xwidget-webkit-adjust-size-to-content)) > + (xwidget-webkit-adjust-size-to-window) > ;; The recenter is intended to correct a visual glitch. > ;; It errors out if the buffer isn't visible, but then we don't get > ;; the glitch, so silence errors. -- Joakim Verona