GNU bug report logs - #22460
'y' command doesn't allow a comment after it one the same line

Previous Next

Package: sed;

Reported by: Thorsten Heymann <hek2mgl <at> metashock.net>

Date: Mon, 25 Jan 2016 01:57:01 UTC

Severity: normal

Tags: fixed

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 22460 <at> debbugs.gnu.org, Thorsten Heymann <hek2mgl <at> metashock.net>
Subject: bug#22460: 'y' command doesn't allow a comment after it one the same line
Date: Tue, 21 Mar 2017 22:00:31 -0700

On Tue, Mar 21, 2017 at 7:54 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> Hello,
>
>> On Mar 18, 2017, at 23:34, Jim Meyering <jim <at> meyering.net> wrote:
>>
>> Would you please separate the factoring-out of your new function and
>> the bug fix into two commits?
>> Maybe even putting the tests in a third.
>
> Thanks for the review.
>
> Please see attached 3 patches, let me know if that's the right direction.

Perfect. I spotted only one nit: in the log of the middle patch,
s/savinh/saving/
Thanks!
This bug report was last modified 8 years and 98 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.