From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 24 13:05:59 2016 Received: (at submit) by debbugs.gnu.org; 24 Jan 2016 18:05:59 +0000 Received: from localhost ([127.0.0.1]:35109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNP31-0005hH-8A for submit@debbugs.gnu.org; Sun, 24 Jan 2016 13:05:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33990) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNP2z-0005h5-GT for submit@debbugs.gnu.org; Sun, 24 Jan 2016 13:05:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNP2t-0002sd-F7 for submit@debbugs.gnu.org; Sun, 24 Jan 2016 13:05:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,XPRIO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNP2t-0002sQ-BV for submit@debbugs.gnu.org; Sun, 24 Jan 2016 13:05:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNP2s-0000UN-DN for bug-gnu-emacs@gnu.org; Sun, 24 Jan 2016 13:05:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNP2p-0002pR-68 for bug-gnu-emacs@gnu.org; Sun, 24 Jan 2016 13:05:50 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:47255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNP2o-0002ok-Ve for bug-gnu-emacs@gnu.org; Sun, 24 Jan 2016 13:05:47 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u0OI5jfG031955 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Sun, 24 Jan 2016 18:05:46 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u0OI5jdC026398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Sun, 24 Jan 2016 18:05:45 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u0OI5jpu015187 for ; Sun, 24 Jan 2016 18:05:45 GMT MIME-Version: 1.0 Message-ID: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> Date: Sun, 24 Jan 2016 10:05:44 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.5; [PATCH] `dired-mark-if' should not count non-changes X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) `dired-mark-if' marks, unmarks, or flags Dired lines that satisfy its PREDICATE argument. But it should do nothing if a given line is already so marked, unmarked, or flagged. More importantly, it should not count that line as having been marked, unmarked, or flagged. The message that echoes the count of changes should not take such non-changes into account. (Also, trivially, the message should not end in a period (.).) Yes, this is a change in behavior (the message) observed by users. But it is TRT, IMO. Here is a fixed version of the macro. The diff is trivial. (defmacro dired-mark-if (predicate msg) "Mark files for PREDICATE, according to `dired-marker-char'. PREDICATE is evaluated on each line, with point at beginning of line. MSG is a noun phrase for the type of files being marked. It should end with a noun that can be pluralized by adding `s'. Return value is the number of files marked, or nil if none were marked." `(let ((inhibit-read-only t) count) (save-excursion (setq count 0) (when ,msg (message "%s %ss%s..." (cond ((eq dired-marker-char ?\040) "U= nmarking") ((eq dired-del-marker dired-marker-char) "F= lagging") (t "M= arking")) ,msg (if (eq dired-del-marker dired-marker-char) " for= deletion" ""))) (goto-char (point-min)) (while (not (eobp)) (when ,predicate (unless (looking-at (char-to-string dired-marker-char)) (delete-char 1) (insert dired-marker-char) (setq count (1+ cou= nt)))) (forward-line 1)) (when ,msg (message "%s %s%s %s%s" count ,msg (dired-plural-s count) (if (eq dired-marker-char ?\040) "un" "") (if (eq dired-marker-char dired-del-marker) "flag= ged" "marked")))) (and (> count 0) count))) In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/usr --host=3Di686-pc-mingw32' From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 10:42:35 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 14:42:35 +0000 Received: from localhost ([127.0.0.1]:33178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfmeZ-00036J-3y for submit@debbugs.gnu.org; Tue, 25 Jun 2019 10:42:35 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfmeX-000369-GX for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 10:42:33 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfmeR-00013Q-CZ; Tue, 25 Jun 2019 16:42:29 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> Date: Tue, 25 Jun 2019 16:42:27 +0200 In-Reply-To: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> (Drew Adams's message of "Sun, 24 Jan 2016 10:05:44 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > `dired-mark-if' marks, unmarks, or flags Dired lines that satisfy its > PREDICATE argument. > > But it should do nothing if a given line is already so marked, unmarked, > or flagged. More importantl [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > `dired-mark-if' marks, unmarks, or flags Dired lines that satisfy its > PREDICATE argument. > > But it should do nothing if a given line is already so marked, unmarked, > or flagged. More importantly, it should not count that line as having > been marked, unmarked, or flagged. The message that echoes the count of > changes should not take such non-changes into account. That sounds like a sensible change, and a cursory look at the code seems to say that nothing uses the return value, anyway. (So it shouldn't break anything.) (But my look was very cursory; this should be confirmed by looking at the code closer.) > Here is a fixed version of the macro. The diff is trivial. No diff was included, which, as usual, is a shame, because the macro has changed slightly in the meantime. > (cond ((eq dired-marker-char ?\040) "Unmarking") ?\040 isn't the recommended way of saying "space". > ((eq dired-del-marker dired-marker-char) "Flagging") > (t "Marking")) Your lines are also too wide; they should be less than 80 characters wide. Could you re-spin your change and submit a patch? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 11:33:26 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 15:33:26 +0000 Received: from localhost ([127.0.0.1]:33272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfnRl-0006dS-MW for submit@debbugs.gnu.org; Tue, 25 Jun 2019 11:33:25 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:55644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfnRj-0006dA-QU for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 11:33:24 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PFIibR008049; Tue, 25 Jun 2019 15:33:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type; s=corp-2018-07-02; bh=h8ByHh6RQT7MyGvwBiBZBHn7DdfrN39TzZ5eJXZE4LA=; b=BmGBFVbxPzsKfe+8gLlpQbYAbtMxjIbpK4WKgwzVpv8xhulzniO7jHMaAMe9rJG+rqKd +75D1pfBrzha6nTeorr0O3DgDWFZTWMvxUl/RVTZVRUXzkqH3uBLr3Nqc3l6Ls+rhPv2 8utWzJ7Z9+1PKu0DYAxoo9aJsiV8VGh6Q0X1WmvVk9WeNgHGibfVNis7TE0/fmd75RRY nBfA/iTOI8M3OaiuamnbcqJErModTy/LD49jAwU4Yur0N6F4Q6z+Q4PCx+bes99opqES 6CefUR8zBwGtLE6+UeiAbcldaEqQPhLrMhsZLKSwqlzk8OoKdjCMszr28UtNGJ8OHtzs sQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2t9brt56kp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 15:33:17 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PFWi6j109304; Tue, 25 Jun 2019 15:33:16 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2t9p6u8hrs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 15:33:16 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5PFXF34027403; Tue, 25 Jun 2019 15:33:15 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 25 Jun 2019 08:33:14 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: multipart/mixed; boundary="__1561476795443103899abhmp0018.oracle.com" X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250117 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --__1561476795443103899abhmp0018.oracle.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable > > Here is a fixed version of the macro. The diff is trivial. >=20 > No diff was included, which, as usual, is a shame, because the macro has > changed slightly in the meantime. That makes no difference. ;-) And the diff is still trivial. ("The macro has changed slightly" =3D=3D ?\040 became ?\s. Nothing more) > Your lines are also too wide; they should be less than 80 characters > wide. Oh, lines 92 chars are too wide for dired.el? Then why does it have lots of lines wider than 80 chars, including lines up to 103 chars wide? > Could you re-spin your change and submit a patch? diff -u dired.el dired-2019-06-25a-patched.el --- dired.el=092019-06-25 07:57:35.886354900 -0700 +++ dired-2019-06-25a-patched.el=092019-06-25 08:09:23.058466400 -0700 @@ -538,7 +538,7 @@ ;;; Macros must be defined before they are used, for the byte compiler. =20 (defmacro dired-mark-if (predicate msg) - "Mark all files for which PREDICATE evals to non-nil. + "Mark files for PREDICATE, according to `dired-marker-char'. PREDICATE is evaluated on each line, with point at beginning of line. MSG is a noun phrase for the type of files being marked. It should end with a noun that can be pluralized by adding `s'. @@ -558,13 +558,11 @@ =09=09 ""))) (goto-char (point-min)) (while (not (eobp)) - (if ,predicate - (progn - (delete-char 1) - (insert dired-marker-char) - (setq count (1+ count)))) + (when ,predicate + (unless (looking-at-p (char-to-string dired-marker-char)) + (delete-char 1) (insert dired-marker-char) (setq count (1+ cou= nt)))) (forward-line 1)) - (if ,msg (message "%s %s%s %s%s." + (when ,msg (message "%s %s%s %s%s" count ,msg (dired-plural-s count) ---- Actually, the _attached_ definition is much better than this - it's what I use in `dired+.el'. The value returned and the message indicate both the number matched and the number changed. And it has optional arg PLURAL, for irregular plurals (e.g. "directories"). But if you want this one you'll have to do your own line shortening, `diff', and adjustment of any callers you might to want to pass an irregular PLURAL form. --__1561476795443103899abhmp0018.oracle.com Content-Type: application/octet-stream; name="throw-dired-mark-if.el" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="throw-dired-mark-if.el" OzsgMS4gVmFsdWUgcmV0dXJuZWQgYW5kIG1lc3NhZ2UgaW5kaWNhdGUgYm90aCB0aGUgbnVtYmVy IG1hdGNoZWQgYW5kIHRoZSBudW1iZXIgY2hhbmdlZC4KOzsgMi4gQWRkZWQgb3B0aW9uYWwgYXJn IFBMVVJBTCwgZm9yIGlycmVndWxhciBwbHVyYWxzIChlLmcuICJkaXJlY3RvcmllcyIpLgo7Owoo ZGVmbWFjcm8gZGlyZWQtbWFyay1pZiAocHJlZGljYXRlIHNpbmd1bGFyICZvcHRpb25hbCBwbHVy YWwpCiAgIk1hcmsgZmlsZXMgZm9yIFBSRURJQ0FURSwgYWNjb3JkaW5nIHRvIGBkaXJlZC1tYXJr ZXItY2hhcicuClBSRURJQ0FURSBpcyBldmFsdWF0ZWQgb24gZWFjaCBsaW5lLCB3aXRoIHBvaW50 IGF0IGJlZ2lubmluZyBvZiBsaW5lLgpTSU5HVUxBUiBpcyBhIHNpbmd1bGFyIG5vdW4gcGhyYXNl IGZvciB0aGUgdHlwZSBvZiBmaWxlcyBiZWluZyBtYXJrZWQuCk9wdGlvbmFsIGFyZyBQTFVSQUwg aXMgYSBwbHVyYWwgbm91biBwaHJhc2UgZm9yIHRoZSB0eXBlIG9mIGZpbGVzCiBiZWluZyBtYXJr ZWQuCklmIFBMVVJBTCBpcyBuaWwgdGhlbiBTSU5HVUxBUiBzaG91bGQgZW5kIHdpdGggYSBub3Vu IHRoYXQgY2FuIGJlCnBsdXJhbGl6ZWQgYnkgYWRkaW5nIGBzJy4KClJldHVybiBuaWwgaWYgbm8g ZmlsZXMgbWF0Y2hlZCBQUkVESUNBVEUuCk90aGVyd2lzZSByZXR1cm4gYSBjb25zIChDSEFOR0VE IC4gTUFUQ0hFRCksIHdoZXJlOgogQ0hBTkdFRCBpcyB0aGUgbnVtYmVyIG9mIG1hcmtpbmdzIHRo YXQgd2VyZSBjaGFuZ2VkIGJ5IHRoZSBvcGVyYXRpb24uCiBNQVRDSEVEIGlzIHRoZSBudW1iZXIg b2YgZmlsZXMgdGhhdCBtYXRjaGVkIFBSRURJQ0FURS4iCiAgYChsZXQgKChpbmhpYml0LXJlYWQt b25seSAgdCkKICAgICAgICAgY2hhbmdlZCBtYXRjaGVkKQogICAgIChzYXZlLWV4Y3Vyc2lvbgog ICAgICAgKHNldHEgbWF0Y2hlZCAgMAogICAgICAgICAgICAgY2hhbmdlZCAgMCkKICAgICAgICh3 aGVuICxzaW5ndWxhciAobWVzc2FnZSAiJXMgJXMlcy4uLiIKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoY29uZCAoKGVxIGRpcmVkLW1hcmtlci1jaGFyID9cMDQwKSAgICAgICAgICAg ICJVbm1hcmtpbmciKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgoZXEg ZGlyZWQtZGVsLW1hcmtlciBkaXJlZC1tYXJrZXItY2hhcikgIkZsYWdnaW5nIikKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJNYXJraW5nIikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KG9yICxwbHVyYWwgIChjb25jYXQgLHNpbmd1bGFyICJzIikpCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGlmIChlcSBkaXJlZC1kZWwtbWFya2VyIGRpcmVkLW1hcmtlci1jaGFyKSAi IGZvciBkZWxldGlvbiIgIiIpKSkKICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCiAgICAg ICAod2hpbGUgKG5vdCAoZW9icCkpCiAgICAgICAgICh3aGVuICxwcmVkaWNhdGUKICAgICAgICAg ICAoc2V0cSBtYXRjaGVkICAoMSsgbWF0Y2hlZCkpCiAgICAgICAgICAgKHVubGVzcyAoZGlyZWRw LWxvb2tpbmctYXQtcCAoY2hhci10by1zdHJpbmcgZGlyZWQtbWFya2VyLWNoYXIpKQogICAgICAg ICAgICAgKGRlbGV0ZS1jaGFyIDEpIChpbnNlcnQgZGlyZWQtbWFya2VyLWNoYXIpIChzZXRxIGNo YW5nZWQgICgxKyBjaGFuZ2VkKSkpKQogICAgICAgICAoZm9yd2FyZC1saW5lIDEpKQogICAgICAg KHdoZW4gLHNpbmd1bGFyIChtZXNzYWdlICIlcyAlcyVzJXMgbmV3bHkgJXMlcyIKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBtYXRjaGVkCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGlmICg9IG1hdGNoZWQgMSkgLHNpbmd1bGFyIChvciAscGx1cmFsICAoY29uY2F0ICxz aW5ndWxhciAicyIpKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKG5vdCAo PSBtYXRjaGVkIGNoYW5nZWQpKSAiIG1hdGNoZWQsICIgIiIpCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGlmIChub3QgKD0gbWF0Y2hlZCBjaGFuZ2VkKSkgY2hhbmdlZCAiIikKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWYgKGVxIGRpcmVkLW1hcmtlci1jaGFyID9c MDQwKSAidW4iICIiKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAoZXEgZGly ZWQtbWFya2VyLWNoYXIgZGlyZWQtZGVsLW1hcmtlcikgImZsYWdnZWQiICJtYXJrZWQiKSkpKQog ICAgIChhbmQgKD4gbWF0Y2hlZCAwKSAgKGNvbnMgY2hhbmdlZCBtYXRjaGVkKSkpKQo= --__1561476795443103899abhmp0018.oracle.com-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 11:44:39 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 15:44:39 +0000 Received: from localhost ([127.0.0.1]:33291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfncd-0006wA-BM for submit@debbugs.gnu.org; Tue, 25 Jun 2019 11:44:39 -0400 Received: from quimby.gnus.org ([80.91.231.51]:51690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfncb-0006w1-Oz for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 11:44:38 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfncX-0001W8-IV; Tue, 25 Jun 2019 17:44:35 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> Date: Tue, 25 Jun 2019 17:44:33 +0200 In-Reply-To: (Drew Adams's message of "Tue, 25 Jun 2019 08:33:14 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: >> Could you re-spin your change and submit a patch? > > diff -u dired.el dired-2019-06-25a-patched.el > --- dired.el 2019-06-25 07:57:35.886354900 -0700 > +++ dired-2019-06-25a-patched.el 2019-06-25 [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: >> Could you re-spin your change and submit a patch? > > diff -u dired.el dired-2019-06-25a-patched.el > --- dired.el 2019-06-25 07:57:35.886354900 -0700 > +++ dired-2019-06-25a-patched.el 2019-06-25 08:09:23.058466400 -0700 Thanks; applied to the Emacs trunk. As this is a user-visible change (but a good one, I think), it might be controversial. The change is basically what I put in NEWS: -- *** The marking commands now report how many files were marked by the command itself, not how many files are marked in total. -- Perhaps somebody will want to weigh in here; feel free to revert the commit if this is felt to be a confusing change. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 11:44:48 2019 Received: (at control) by debbugs.gnu.org; 25 Jun 2019 15:44:49 +0000 Received: from localhost ([127.0.0.1]:33294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfncm-0006wU-Kq for submit@debbugs.gnu.org; Tue, 25 Jun 2019 11:44:48 -0400 Received: from quimby.gnus.org ([80.91.231.51]:51704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfnck-0006wM-BW for control@debbugs.gnu.org; Tue, 25 Jun 2019 11:44:46 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfnch-0001WF-Pz for control@debbugs.gnu.org; Tue, 25 Jun 2019 17:44:45 +0200 Date: Tue, 25 Jun 2019 17:44:43 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22457 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 22457 fixed close 22457 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 22457 fixed close 22457 27.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 11:47:03 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 15:47:03 +0000 Received: from localhost ([127.0.0.1]:33301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfnex-0000FW-47 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 11:47:03 -0400 Received: from quimby.gnus.org ([80.91.231.51]:51764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfnev-0000E1-Vg for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 11:47:02 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfnet-0001Wf-1X; Tue, 25 Jun 2019 17:47:01 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHBgXW1tZkY2IYFxYF AwMKCAdn2ceNAAACZ0lEQVQ4jU2UTW7jMAyFido6gBR0X0vw3hbLvYEqe44V3v8q8yg7nVFTBdZn /j1SIVK7Vjc1nZ/vJyIj68yCDc+thQsw+ZZzZnYopE9T9Vfxn6OvFFORvRjcuVknO3NeBoq51GKE 83aETn1PufpxWVLpQkQADYCX5CapGDY4usBhxAVhgTJA9PAEZzNAXyl0kLL9ifFhPG2v2YMQiyKx vHy2Halx51VnIgCvxoM/6I8nxozEyEKgwNY93bTuvos82AL+iKoZjlCC4yKGnN0LaQ12elirOSbV gAQGCP7ZI7ToCPU9/3zaIEQBup9woUGW+DWH1Uyqg6EyTfxqanmlA08Znv28s1bh0D7wsueve3yM fuiJV8KTP1LNW3uGnisP4IUklyouaYPvDlkdQCposY2WPMhbi/KFPOMa13mGVYxfDUKNuKQ0h5q+ 27GXKcbt1Q4aVuSrFmnPpXBFgVfFNzgXzEmFslncz5DcG0lnLLxAx1zYg2q4QfuA3NYFBsJK18gB zMd0z0+UcRJuUDX8D2xM7QAr+QhhUCLEUm/rbfFFOQuGEPXae9gZ4Oe7hVrdz/kPdIDDx2iA/gtw DXwhDYFyPZe3Ix7gOMI03h0bOt1LYZJA7Zj0bXdZFHSwozWtKwYWV0WuCThzqmQzOhDa62gULrMu veRCrq9SQ3Z0LTcpMV/fFcJWXAVov3qMeAOokR8AvtaJx8EAfK8y7nQw4ZrorjRM5ZKKaBOBa7pr wowyq19OpId48RfcQ4yhaZwfHGk+/JoiV72aBEV7Zlj4D4Ff7G1oMcMVWRUA+LyWmuAXBpVrPyH0 Xwhi31X7JUg5AAAAAElFTkSuQmCC Date: Tue, 25 Jun 2019 17:46:58 +0200 In-Reply-To: (Drew Adams's message of "Tue, 25 Jun 2019 08:33:14 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: And why is dired-mark-if a macro in the first place? It's pretty long to be a macro; it could be rewritten as a function that take a predicate... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) And why is dired-mark-if a macro in the first place? It's pretty long to be a macro; it could be rewritten as a function that take a predicate... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 12:06:59 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 16:06:59 +0000 Received: from localhost ([127.0.0.1]:33330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfnyF-0003PI-CJ for submit@debbugs.gnu.org; Tue, 25 Jun 2019 12:06:59 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfnyC-0003P1-RV for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 12:06:57 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PFxCHb052978; Tue, 25 Jun 2019 16:06:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=2EpU8sXuMaHLh083k24zjPjAIcK/MtnoxbDWRn3vGyw=; b=men7ms/Z+yuET6pYC/B+FJ8ubbo7nQLfQxidjRCExr5qWczps1zFmgNZsauYeBvd0efw d7y1wXbqtIU99wTRQaEvw9SEq1bCDXAa+eTc2uxi+qsxlNyOsLa2yxKt1zombqkW8V8d WMZLlYgqbumFkrwC5iFGl8vqqUrXgGu7fnOJgaCBAjfvU4mtxmV2jo/8xxGxluTCy/lu wppO3avNnNkVdVlAndaecNJMCLYsxscdADjaVLoumeRvhXEO5ZyqCKTtD0JKhIWApvxf rFDq1/0deR5mS7doeL8q83Ii4s+Gv/PCg6p8i6ImnnJQLxMIZ8HcE8LE7ZujB/AXVDwk YQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2t9cyqdafm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 16:06:49 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PG5Ton135150; Tue, 25 Jun 2019 16:06:49 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2t9acc6mm8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 16:06:48 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5PG6lq0005245; Tue, 25 Jun 2019 16:06:48 GMT MIME-Version: 1.0 Message-ID: <81cf46a6-c57a-4f90-a203-7e963b232f6a@default> Date: Tue, 25 Jun 2019 09:06:46 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250121 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250121 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > And why is dired-mark-if a macro in the first place? It's pretty long > to be a macro; it could be rewritten as a function that take a > predicate... (Length of a macro's code makes no difference, if the code using it is compiled.) I would say leave this sleeping dog lie... --- The PREDICATE arg is really code (a sexp), not a predicate (function). See also the use of `dired-mark-if' in command `dired-mark-sexp' (in `dired-x.el'). See the doc string of that command. There too the PREDICATE arg is code (a sexp), not a predicate. And there you can use a set of predefined variables in the "PREDICATE" sexp that gets evaluated and then passed to `dired-mark-if'. See also the uses of `dired-mark-if' in `dired-aux.el', where an anonymous function is constructed using the macro. This is the way things have been since about Day One of Emacs. Could things have been coded differently for this? Likely. Should they be? Doubtful. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 18:52:36 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 22:52:36 +0000 Received: from localhost ([127.0.0.1]:33793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuIj-0008Su-9T for submit@debbugs.gnu.org; Tue, 25 Jun 2019 18:52:36 -0400 Received: from mout.web.de ([212.227.17.12]:37213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuIh-0008Se-7E for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 18:52:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561503142; bh=tWwhPuz9FeN6ceoXVtBA/evRWlPGPYZQm1I/av/lfs4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=icTOndTQutq9HR0mujMOT3L7rJD4/6g9MhAN4dO9lx/gSuZIg1lCWJVlLAmIsXkN8 RXslNWWLZzbR+C+ma7bR3lVZsBGjo31S4ls7eVEv/9rEhUt4bK6jdCrwJC3713t93R 4JoXcVTkbvemF8DMUcSAB3xDyMswTUYY8N2GJTIs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.184.73]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MgfFr-1hu0xO1vZ1-00O0dt; Wed, 26 Jun 2019 00:47:01 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> Date: Wed, 26 Jun 2019 00:47:00 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 25 Jun 2019 17:44:33 +0200") Message-ID: <87o92lmgez.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:FvEE7Pbbum3h33dx7pHzYK237wY40UhxMGsd95aRx0yOlekLjEt RPWrovjo6H0f5EiSPH2DqFLV+A+fkecXCwj7tBv0ffoqpUNNgLwSuk3zH7bDtMK2fWAlYQj ziOQeCEgsEL+jiXOXy5Ic0cdPXVNAOdWv8DPWLZu/2bSaerGIU1r7SmALZ//FbUrvYiQt23 O0apkIdxLnkGphV5g1kwQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+kRyhOwqd9w=:qm978erya/1NtS0OU7C4ES 8114uy/b5NJ6XyOOMvfuYYt57kbvkUBL7EIUNjniURaQ3ff7j1zr/CjUI7IVtTYwllIvO1/Lw rOVIQNT+N0u2jzaZ4Z8iWP2T+pMPPsdMtonqIpH5g2mtYQbNdHQgseSTJkyP/9wysub40mvBx fZQt8yLXSCfqxp1z9D8AtOnITerEQzg2syZ+YxPpuDUJyACe3tY97fGYzMN+gxqinRUw0vOnN 76omnW8LsE822wGeO8uMQek/x1esZabTivs3kET6YH/noBWxVAeoUcGpY8i9w0w6+eDcFMH7K T6cFTRZb/8ppfVsnju+rZYznAxLtWu9v6eYmadu1/MU8ewF+WS66PYk/ef8MDG7ptwosrQeZ7 nEauqJq9xLvV9zTU64q7aVOpaCLs37R1Q65EwlE41tTEo5Zt8ryCOe9bU11QxaKSY8AeqFy3Y zusU13wQCuwmJJYI7sfsSlSyQhyPdW4mGeCz2omELQJo3b272zipQnDgMAQ5gCXJ+zom/LPWc qvzSjTapMztreoCGxupdy0InjeRD9WVJ6aySmrFc4Pa+H3Nzu2OPBtOokqQmSMoFf3FBxTVmv e4z0MroCd8wy4NhP6kjRrEZEq2QbLNw7IV2QKqmdHIVYBMYsDAzwoL7YK84NMv8+9O+SipQr4 EvN+dbEc0rRt+1/PDq8vHJPr/TI9iOk6eoRaIwtUq3ImUF5gw0uQxjOqIfVQxxIkJLR5x2dks D9mc3UiIwVsOYKt+6ieGqUis/r+v9W4cqW/PW1Xmy++CfvKhrzg0l8UZY48Wm7EdPEwG8iRbx 4wsKx1BzkHUXzg8BBZEOsNcbgdaLnfo0GaXlanf31NRX3R7i4B8uHmMM6DCd9RWc75+kznlFc 7Ur29K1WJ0PT5jwoAbbFhQSf0mnkhVaFxLj1KJ8cxISmX+iOqrZLLkifHxRlIDhH2zeZG0PQJ Bnoj7AGjiyiStCsrx0hF3mut9qsHBEjIQpP6DGltROMlHvqcntkp3 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22457 Cc: Drew Adams , 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > -- > *** The marking commands now report how many files were marked by the > command itself, not how many files are marked in total. > -- I don't think this exactly describes what the patch changed: it is not about new vs total marks, but about marks of files that were already marked before, right? > Perhaps somebody will want to weigh in here; feel free to revert the > commit if this is felt to be a confusing change. IIUC: Maybe we could add to the summary message something like "(N already were marked)" or so if a command finds existent marks on files to be marked? That might be useful information, even independent from this change, because it might also be a hint for a pilot error. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 18:53:21 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 22:53:21 +0000 Received: from localhost ([127.0.0.1]:33800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuJV-0008Uw-I0 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 18:53:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuJR-0008Uj-W2 for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 18:53:20 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfuJM-0005Kv-IR; Wed, 26 Jun 2019 00:53:16 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHBgXW1tZkY2IYFxYF AwMKCAdn2ceNAAACZ0lEQVQ4jU2UTW7jMAyFido6gBR0X0vw3hbLvYEqe44V3v8q8yg7nVFTBdZn /j1SIVK7Vjc1nZ/vJyIj68yCDc+thQsw+ZZzZnYopE9T9Vfxn6OvFFORvRjcuVknO3NeBoq51GKE 83aETn1PufpxWVLpQkQADYCX5CapGDY4usBhxAVhgTJA9PAEZzNAXyl0kLL9ifFhPG2v2YMQiyKx vHy2Halx51VnIgCvxoM/6I8nxozEyEKgwNY93bTuvos82AL+iKoZjlCC4yKGnN0LaQ12elirOSbV gAQGCP7ZI7ToCPU9/3zaIEQBup9woUGW+DWH1Uyqg6EyTfxqanmlA08Znv28s1bh0D7wsueve3yM fuiJV8KTP1LNW3uGnisP4IUklyouaYPvDlkdQCposY2WPMhbi/KFPOMa13mGVYxfDUKNuKQ0h5q+ 27GXKcbt1Q4aVuSrFmnPpXBFgVfFNzgXzEmFslncz5DcG0lnLLxAx1zYg2q4QfuA3NYFBsJK18gB zMd0z0+UcRJuUDX8D2xM7QAr+QhhUCLEUm/rbfFFOQuGEPXae9gZ4Oe7hVrdz/kPdIDDx2iA/gtw DXwhDYFyPZe3Ix7gOMI03h0bOt1LYZJA7Zj0bXdZFHSwozWtKwYWV0WuCThzqmQzOhDa62gULrMu veRCrq9SQ3Z0LTcpMV/fFcJWXAVov3qMeAOokR8AvtaJx8EAfK8y7nQw4ZrorjRM5ZKKaBOBa7pr wowyq19OpId48RfcQ4yhaZwfHGk+/JoiV72aBEV7Zlj4D4Ff7G1oMcMVWRUA+LyWmuAXBpVrPyH0 Xwhi31X7JUg5AAAAAElFTkSuQmCC Date: Wed, 26 Jun 2019 00:53:12 +0200 In-Reply-To: <87o92lmgez.fsf@web.de> (Michael Heerdegen's message of "Wed, 26 Jun 2019 00:47:00 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: > Lars Ingebrigtsen writes: > >> -- >> *** The marking commands now report how many files were marked by the >> command itself, not how many files are marked in total. >> -- > > I don [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22457 Cc: Drew Adams , 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Lars Ingebrigtsen writes: > >> -- >> *** The marking commands now report how many files were marked by the >> command itself, not how many files are marked in total. >> -- > > I don't think this exactly describes what the patch changed: it is not > about new vs total marks, but about marks of files that were already > marked before, right? It's this code: (unless (looking-at-p (char-to-string dired-marker-char)) (delete-char 1) (insert dired-marker-char) (setq count (1+ count)))) So now it says how many lines that are marked this time. Previously it gave you a total tally of all marked files. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 19:08:11 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:08:11 +0000 Received: from localhost ([127.0.0.1]:33827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuXr-0002g3-8M for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:08:11 -0400 Received: from mout.web.de ([217.72.192.78]:47637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuXp-0002fj-Gk for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:08:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561504082; bh=DaVRr7OQ8tlGgFYoVTcznUkMWkuvvaAuLbTNMsC79W8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=BxvN1m9QUMCwj8spdPqCwdEfvDfwOPoaRQ8LJ0gRedZVMCeyAHcl4nchDK+MoAcJB 6MsJbL14+y7FjTwRYNoF/7ZDNtNzlk7aELBtT+hG0PQiPK1bFnb2SoF5NCw9qDjJqi 0cHSjQSQm2Ay4FyiDOwJVgnEBFNgaBUzTiVBIQDE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.184.73]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MTh2S-1i6LJS1bii-00QSmS; Wed, 26 Jun 2019 01:02:50 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> Date: Wed, 26 Jun 2019 01:02:47 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 26 Jun 2019 00:53:12 +0200") Message-ID: <87ftnxmfoo.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Bj5HwRTpqQnHU54OLLb4oecMS9zeX1Tkzh7I5SON0LsEVw9W6On Eh3JyNO9MmmswCC4Oe0UfFknD7cGq3rQW5B2SnlOoHl9nRki6ehr5M9OCxXcmADQo419d7u gzl4glM6GxmfNYJU150O0ajmpBtMl/EOPhoOfYy2YbipgsljiEiDXBmVAJPAGkrI7mcqODc YJu0rhetjGYVyE6ynBCHg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:tI3pL4qUkf4=:fJxUnvFu/N8RDjpsMx73sI L0t9f/yEcqsqQSYoTJpXkf9dzdOUBeDITxxAEi9+d0DES9+QrxJ0oR5PBWPtewIX1gv4qabq5 gEb/NC1y6PjsyYvMV/y7+FEfohKQkjGpl8Ike/AL2zfPjd6kdeyCJxOf+l159gMWB7+Ksq5sf ns/OmzmFrtVlAnh27Qa41YhAbeQscnBgqg72vPbByKUslnK/Nf8lwmYZQU9mbcdMz1bXujpoQ 7IFz+o5d4JsyuySSOVWIP59Na2dWJftD7ZjBMI9xXMIrRFOX66wJ825SEunyoZBjbV+9R1u9Z XFaNcbrlONaSIp0bfs9QjJKbj1Edb/aMwm59Pe5RokrZIHgfx4Tx1thf9SniCutWlI6FgSVRD xAy79qy6N0b+ULVIi3TR1zEX1hW0ccp2CyXB6dlbsqSQb94fnztXO+usnxhoV3WaHvaAVApS9 RRmv+ySqjG+sfl+b9upjH0oyJ4ktJu2v62DTv37woCeLTROCFLEn50pKQfHXfyr7TgUL07sun LV8uKIuFL2EBbeQ4hQb3wZcn3t5nW9m3a/uKkwv5uEcQN9GscpB4XJ/2JSNYjxsWmYOgl+8UW oqymdW/SuOCql6cFdPhW76yhOAwT2vuhh5pFPwz4p5Zoz/bKmJVHDpuJksOmBVRz2BL8hHtsV ruBD/6teqRv7ZhAVXleHB6WVJ5Dw+y2ItdfYJh35N0pvGAPxm1Laq3SGgxx0NOf2jnDecvlAf flzpnO+n/FJyamCjfyHwErajZSLGgbVg69rOPSnBHwiDDTpS+/njsIaogot9hXxvrxYgHiB2u 8M4f8BUaOeHnc7NaZKi3z72wKSjBk/D6pW048JGTqm5ZdEDP0pX1yuqPK0vMJlRVdaOJmlmLw RjRgwypENHyF8ug9mHadKHQdNbHVT//oG+x5DGHkPIw0FxpFaZJYH0Keyn9DhEzNIKGK0Mhj9 YEpP8T020g8z7tS4z5PNdMAFq6RCKXacXxIPQzfdOmIiYC0FYGIIW Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > > I don't think this exactly describes what the patch changed: it is not > > about new vs total marks, but about marks of files that were already > > marked before, right? > > It's this code: > > (unless (looking-at-p (char-to-string dired-marker-char)) > (delete-char 1) > (insert dired-marker-char) > (setq count (1+ count)))) > > So now it says how many lines that are marked this time. Previously it > gave you a total tally of all marked files. Yes, I think I understand. My problem is that "[...] not how many files are marked in total" sounds like as if marked files that were not even touched by the command (that are not matched by the predicate) were previously included. You mean it relative to the files matched, right? Oh, btw, this patch line (looking-at-p (char-to-string dired-marker-char)) is not good if dired-marker-char is a regexp special like . or ?, I guess (regexp-quote missing)? Michael From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 19:12:34 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:12:34 +0000 Received: from localhost ([127.0.0.1]:33843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuc6-0002oX-I1 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:12:34 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuc4-0002oP-WA for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:12:33 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfubx-0005eq-Jv; Wed, 26 Jun 2019 01:12:27 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <87ftnxmfoo.fsf@web.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHBgXW1tZkY2IYFxYF AwMKCAdn2ceNAAACZ0lEQVQ4jU2UTW7jMAyFido6gBR0X0vw3hbLvYEqe44V3v8q8yg7nVFTBdZn /j1SIVK7Vjc1nZ/vJyIj68yCDc+thQsw+ZZzZnYopE9T9Vfxn6OvFFORvRjcuVknO3NeBoq51GKE 83aETn1PufpxWVLpQkQADYCX5CapGDY4usBhxAVhgTJA9PAEZzNAXyl0kLL9ifFhPG2v2YMQiyKx vHy2Halx51VnIgCvxoM/6I8nxozEyEKgwNY93bTuvos82AL+iKoZjlCC4yKGnN0LaQ12elirOSbV gAQGCP7ZI7ToCPU9/3zaIEQBup9woUGW+DWH1Uyqg6EyTfxqanmlA08Znv28s1bh0D7wsueve3yM fuiJV8KTP1LNW3uGnisP4IUklyouaYPvDlkdQCposY2WPMhbi/KFPOMa13mGVYxfDUKNuKQ0h5q+ 27GXKcbt1Q4aVuSrFmnPpXBFgVfFNzgXzEmFslncz5DcG0lnLLxAx1zYg2q4QfuA3NYFBsJK18gB zMd0z0+UcRJuUDX8D2xM7QAr+QhhUCLEUm/rbfFFOQuGEPXae9gZ4Oe7hVrdz/kPdIDDx2iA/gtw DXwhDYFyPZe3Ix7gOMI03h0bOt1LYZJA7Zj0bXdZFHSwozWtKwYWV0WuCThzqmQzOhDa62gULrMu veRCrq9SQ3Z0LTcpMV/fFcJWXAVov3qMeAOokR8AvtaJx8EAfK8y7nQw4ZrorjRM5ZKKaBOBa7pr wowyq19OpId48RfcQ4yhaZwfHGk+/JoiV72aBEV7Zlj4D4Ff7G1oMcMVWRUA+LyWmuAXBpVrPyH0 Xwhi31X7JUg5AAAAAElFTkSuQmCC Date: Wed, 26 Jun 2019 01:12:25 +0200 In-Reply-To: <87ftnxmfoo.fsf@web.de> (Michael Heerdegen's message of "Wed, 26 Jun 2019 01:02:47 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: > Yes, I think I understand. My problem is that "[...] not how many files > are marked in total" sounds like as if marked files that were not even > touched by the command (that are not matched by the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Yes, I think I understand. My problem is that "[...] not how many files > are marked in total" sounds like as if marked files that were not even > touched by the command (that are not matched by the predicate) were > previously included. You mean it relative to the files matched, right? Well... this is the patch: - (if ,predicate - (progn - (delete-char 1) - (insert dired-marker-char) - (setq count (1+ count)))) + (when ,predicate + (unless (looking-at-p (char-to-string dired-marker-char)) + (delete-char 1) + (insert dired-marker-char) + (setq count (1+ count)))) So if the predicate matches, if there was a mark, it would delete the mark, and then add it back, and then count it. But you're right, files where the predicate doesn't say non-nil are not counted, so it doesn't report the total number of marked files... > Oh, btw, this patch line > > (looking-at-p (char-to-string dired-marker-char)) > > is not good if dired-marker-char is a regexp special like . or ?, I > guess (regexp-quote missing)? Indeed. I'll fix it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 19:17:17 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:17:17 +0000 Received: from localhost ([127.0.0.1]:33848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfugf-0002xk-6a for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:17:17 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:46974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfugc-0002xV-IL for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:17:15 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNEGYI096667; Tue, 25 Jun 2019 23:17:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=xEe6bWA/H6WnJxq6T+VVaPD0YX/ellqnZr/rm1mnVoo=; b=456O/H9tauGZ86uTaz8qMrXmCioJomdPStG9AQjxmu8t5/lqxhK/G1MoZvgi2T1PgKEC JwpqBMaSakjN/cjmHMuSPzvNOpz766shwx5UhBeABiuZQDZtEHDGlU4LgYPfLbL7flx8 dKdwKH6iMYSrcPj3NtrsXZkBgesC678wiakC29wNz6ndhqduWJU/AUhUcpnJspEyKosi ELZsVJc6lbjL7aXd2acwe7PgNQtynoIYsvIX2n491SN+W3L7GuPg0p2RWVY8GPnF7N9H nefq7E08EEeAy3RW4Ct6kFzWVrKJIV8Ih/LDku9BzB9rrDqdx8keRlC+eeDBvrEpyXXW /A== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2t9c9pq49y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 23:17:08 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNFrrY045919; Tue, 25 Jun 2019 23:17:07 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2t99f454hn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 23:17:07 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5PNH3Ms002046; Tue, 25 Jun 2019 23:17:05 GMT MIME-Version: 1.0 Message-ID: <6eba02d9-7143-4b47-85e9-ee381b4b5494@default> Date: Tue, 25 Jun 2019 16:17:02 -0700 (PDT) From: Drew Adams To: Michael Heerdegen , Lars Ingebrigtsen Subject: RE: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> In-Reply-To: <87o92lmgez.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250188 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250188 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > *** The marking commands now report how many files were marked by the > > command itself, not how many files are marked in total. > > -- >=20 > I don't think this exactly describes what the patch changed: it is not > about new vs total marks, but about marks of files that were already > marked before, right? It's about making the reported count refer to the number of marks that were changed or added. The old way counted all of the matches. The new way counts only matches that are not already marked the same way. > > Perhaps somebody will want to weigh in here; feel free to revert the > > commit if this is felt to be a confusing change. >=20 > IIUC: Maybe we could add to the summary message something like > "(N already were marked)" or so if a command finds existent marks on file= s > to be marked? That might be useful information, even independent from > this change, because it might also be a hint for a pilot error. That's what the "better" version does that I sent as an _attachment_. If some were already marked as directed it says: "42 foobars matched, 35 newly marked" or "42 foobars matched, 35 newly unmarked" or "42 foobars matched, 35 newly flagged" or "42 foobars matched, 35 newly unflagged" (If all that were matched were already marked as directed then instead of "35" it says "0".) Otherwise (no matches were already marked as directed) it says: "42 foobars newly marked" or "42 foobars newly unmarked" or "42 foobars newly flagged" or "42 foobars newly unflagged" From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 19:27:09 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:27:09 +0000 Received: from localhost ([127.0.0.1]:33868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuqD-0003HR-99 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:27:09 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:40914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuqB-0003HE-QJ for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:27:08 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNPja2195065; Tue, 25 Jun 2019 23:27:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=07o6smSQjpRt0rSFiBgTQQMm+JOT3Omb8JhrcC1M47M=; b=LSKEoSW8msU1ChsIILJISDaZTB711QAB0gGUsnzr2AOxjDXiHXCZ/FiZXi/1gIX1aKVk LZ3PQYXOFuo7mdHzqs8FDGjUStgO2pGgFMBjp0ND8/gmAfTGaq2as48WmKmI2JdQEuXJ 9mq6yi28rim/JlfRRFWXKkpnCIIporVB6P1BvUI/KrfiPH6F/CrBn9g7eo/2fz5wn+Bc LbTOcf63Wr6+xpTLJF48/NXPej+0DU1jdk4QfjJWFeOwVfCa9itmwXuF2AeYN+zTl8Jn chHpzJmt8j6EeCYJeRfXG1DJaBVorzniwSrgdciU+0lbqLu+aPXXzikYsd0L5nCy/oC9 wQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2t9brt77e8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 23:27:01 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNQkGp065013; Tue, 25 Jun 2019 23:27:01 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2t9p6uf8f0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 23:27:01 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5PNQxk7021252; Tue, 25 Jun 2019 23:27:00 GMT MIME-Version: 1.0 Message-ID: <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> Date: Tue, 25 Jun 2019 16:26:58 -0700 (PDT) From: Drew Adams To: Michael Heerdegen , Lars Ingebrigtsen Subject: RE: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <87ftnxmfoo.fsf@web.de> In-Reply-To: <87ftnxmfoo.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250190 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250191 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22457 Cc: 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Oh, btw, this patch line >=20 > (looking-at-p (char-to-string dired-marker-char)) >=20 > is not good if dired-marker-char is a regexp special like . or ?, I > guess (regexp-quote missing)? It's a good point; it would be clearer to wrap the arg to `looking-at-p' with `regexp-quote'. It works as coded, however, because Emacs regexp matching treats a special char such as `*' as non-special in such a context. I'm not saying it's good to rely on that (documented) behavior - it's better to use `regexp-quote'. See (elisp)`Syntax of Regexps': *Please note:* For historical compatibility, special characters are treated as ordinary ones if they are in contexts where their special meanings make no sense. For example, '*foo' treats '*' as ordinary since there is no preceding expression on which the '*' can act. It is poor practice to depend on this behavior; quote the special character anyway, regardless of where it appears. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 19:31:18 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:31:18 +0000 Received: from localhost ([127.0.0.1]:33873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuuD-0003Pt-UX for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:31:18 -0400 Received: from mout.web.de ([212.227.15.3]:58997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuuB-0003Pc-Ip for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:31:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561505461; bh=fLoLyM71X23tvVXjbvDQDQ7w2DS41A1aSXRVncQoY6o=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TIVHji37zp76r07ieRpJhtplMIPZb427CwH4DSfhYVssW5i3+hMuZHyM7zDz0HYU7 DjhLi4bqE5yBZWvv3+613rLnDWLxPbg7yyPMN1UKsFF1vSMpxqFt0hti2orDhXytmk 0jYncTuqZ5ckzJLExkydjEqOgTHZ6A95suVT5uB4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.184.73]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MINI7-1hivZi0GFj-00488S; Wed, 26 Jun 2019 01:31:01 +0200 From: Michael Heerdegen To: Drew Adams Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <87ftnxmfoo.fsf@web.de> <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> Date: Wed, 26 Jun 2019 01:30:58 +0200 In-Reply-To: <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> (Drew Adams's message of "Tue, 25 Jun 2019 16:26:58 -0700 (PDT)") Message-ID: <875zotmedp.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:FIcJcn7VeLkPs2qkQynucsuIhMBatdsCNkFCWHMCrv2C5F1dXGd /5DLvrtigP4WHj0FRwaLBmPuZvemICxTFVSOltM9sWCYTHsYt3Bv/fgdLvH/gKCfdt95OIT 689usdaqt8YLA16Ub0FklcbWKwk3Va8SdIPwbpks0XBb/1E5ucUHrdrrt+50JLcLCRA2rkT b8A2B/e8y+iyyVZsntK/Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:wD8tImgRv6s=:RLcWFI5RSop/ES1RZdf4wW wKUpuh5oS2S2hvwEQizvNIgoh4SpDOqonF8vBe5eps38uxx9DqfPjFIXdpNPp+uYxjVk5EWPQ WOm5sSo/lNJb7c9Hoi0Q0RXK74htGlTecTWMnG2DPvhtDj/51uk4aUx5ptYBLmpaoTkvLWh8c V+/ARkPtoyvW6q2XVo0zU/KkhVJJUxcmGCcsAyj5pNPd4s8XJHK5MdiJj9KwK228jxLmZvURp fCQqoRsce672EaTceJ7StAv3cv514kLjphRAnp44gzS4U82diYKz6c7ZzkEj0bzUSUQZEsies FEqKKLIflNUrHALZBF3oa1oBBaff1iVG89CEDiMNyTsejMuVLMag5B4wl3DJ6r4xLItyu11d5 c6AORjPIQrVXNhfiuEznC42CeEUAEMtYKBJzOSzfRHIa1oSmQ2+JtFlLNHYFNE795YeIX5ZHq Z8H5oDiZpbOttxehhMsHz3n63qbHpLUzc3SKM7CaXn5CKPTSu99fxLAB98AxB94QThaMK8Ves k8jg00/U2i9mfnO6iCnfrwWhDTP2BoV+uGkT5a8sFMerC5pG1v2i0hBc8hfj2yF8LI/Q5905f iRffIdzTU/7gw2oAgqAN5VqC509rVcLLnbIMpSBFIg1SbK7w/gu05W25OqSuUt6O1j1zvfR8Q 9w/I0ugzbCmbZYDjbR8vMI1/IL9xuTo3RXlfC6EEgwz614rS03o50drHrd7MZumgDUfbRe0EL ND7ghTKkbkDTcs2dFaWrEjIJa3XRoOBs2iOp1KiEJVNX2n9ZUaJn8uNieY9/xAwu2Y6GwNwXW rw1mVSpJ3l1d1uKtwDtS4rO7nW6oMxIU532UQ4+eFVTxs3zSYsJaC8c1Mv7LCrmTiSQKLvacc UthFAJNWIRmVpvqVwGYpvnwnir4D1j2TmkepT8Z9X9akOTwSsIxyIIxySSIOgqie/u8dM1hyg RWMIXsEk9X+1g3UEFW+VYMtIUfRq/4sUjvRA3XR3k4H4kx0NmSZSI9C809/OhCPgq89Broc7u iK8ges0n3DaivkuarQu14vlSuY02//C3BeqKXtZhZbT/v4gHoqCG4ZJskOXBMuBE1qxei8zv2 RKFmOIFtYeTIBnbht1dq52SHEUI4K36XzuE X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22457 Cc: Lars Ingebrigtsen , 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > It works as coded, however, because Emacs regexp matching treats a > special char such as `*' as non-special in such a context. Oh, indeed. But not for `.' I think. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 19:34:04 2019 Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:34:04 +0000 Received: from localhost ([127.0.0.1]:33881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuwt-0003VA-Ro for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:34:04 -0400 Received: from mout.web.de ([217.72.192.78]:56147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuws-0003Uc-4I for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561505635; bh=ElbypJ6E+LrZn72KMfDCLN45zU5vHYdW+CEhrk0GfSM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=fAbMpkF+pMKdetcE30sQMdsFOohG+vhYVkIEcQT7yrPBst58Rxy0XTzrSsHTX7AkD wrldgrJCj4SaHzHRdNdZv7QyCVyqhStry1/zJntKCSl8LS3HczCGlhESNoFwwuG8WN LHo8oZqmCdg7yLQIOYPzTf3HSLLodoIUS4L+FiiQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.184.73]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LnB9V-1iE9oK36yL-00hKzO; Wed, 26 Jun 2019 01:28:25 +0200 From: Michael Heerdegen To: Drew Adams Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <6eba02d9-7143-4b47-85e9-ee381b4b5494@default> Date: Wed, 26 Jun 2019 01:28:24 +0200 In-Reply-To: <6eba02d9-7143-4b47-85e9-ee381b4b5494@default> (Drew Adams's message of "Tue, 25 Jun 2019 16:17:02 -0700 (PDT)") Message-ID: <87a7e5mehz.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:M+XcrPhSmi4VOPDNAf3G2ORxIcTz3Vq3bSkcXK9tSkoU9hOfKPz Qog9mFCtC8kaHmSTcL1CyxEf2gHiJmPEQWf694ePi9xnYp6brk3rQ89NrPBVb6ggY1qYljK 2TN8ZHTEa2auFDBZviC8eflAEdidErgf5ftpXS1lmmL6iG66DmFRW8wbk2UQwUkEjmV892H Rh6PSuJMNWowJ1FRrAFPw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:5c41cH/loYI=:32WadkI8njkc5+og5hDJUi aMlK8y41whQi8iXksCQU76EJ/U0p5/FQUoG/6CnixvnR3343R5jN2nTD92F+4H6+xfdUXGdkh 1bZ76x69spgchMLlyLLfR5srA6qVhEM/aaZY687VTAEpEr1aXPZWz6KEXXZk5dLLytFL8C7Qj YiONrNcEYS1M5Y2aMtOVd26nw1RfZFWGvDf8tnVe7xHsYNJ+vMxb3vZCOi2z9XR5oyMDSgFKt EEjzqzlS8dF06ede+DzOT1n+TfBilpApF1FX2ODVX7lB/KDKIanIYHYlViW0JsfBy3Y0nyk1l HsMhbFzqnzi+FlprWeDeNL87bLdJlmuJBz34GZaFwIA4gtnkEEjkpZkQzdX15RnkEp+PyEjKF MLORp2CQPVb+6I+8mQfRG+ebZxgUHMYLg4GawoqvXtkVmQH6VsL5unShVbL0G18rKwRXTZR2M QuJ9Pzm8k8vN+5RaXlJT1knY08MEM5hU9qaRa0eCvD9pIMTEo4GM+47jyzUreidCwMPMotwrN L6M9MSn07XgRK2hfM5vriAKbAfEPUK9gdXY4+aypN+0pPSEYFF/6bSnFpTA31rod/AvyoNTrm OVPJM8fxCxbFIFOvdcCPLAlpQrkxc/Sefxf8yL0RQKuZge59vH/hmFyFjudXXYtavP0IV6xTv OZhaTnl4NlxaQlbjxwcjX/Ap98nsARNPyCdY1LJLYVGPFscLth5jvFFIF1Yx0UeqjFzZYgXNx cKUZxW71g+0D0tJV7LthvG0lahUTHopWxsMaMo9m4+lRBImoAbgfpMMoaU115w1fCki2N+L5c K91woWYKKf0ak1pF+gnBWynAf8bZllt3HkuzchgIJvkS2d5JPVLXsrHlscac3ufD59lwCVWrw nE1FdEspC+U57LUbDxj9c7lPDLMyk+GUxrGCbkVcZ1LUMrfdS05ZJkbyLbD+yNjatPio7FJl8 mm7/DeOALuxlkdh91ISNI6jdoClfEGccy/pkIHoauC3kZnr4X4Z1E X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22457 Cc: Lars Ingebrigtsen , 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Drew Adams writes: > That's what the "better" version does that I sent > as an _attachment_. Yes, something like that. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 20:01:02 2019 Received: (at 22457) by debbugs.gnu.org; 26 Jun 2019 00:01:02 +0000 Received: from localhost ([127.0.0.1]:33904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfvMz-0004Hb-Pi for submit@debbugs.gnu.org; Tue, 25 Jun 2019 20:01:02 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:59542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfvMy-0004Gz-0H for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 20:01:00 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNxO2R027808; Wed, 26 Jun 2019 00:00:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=GvT2N/xQdvEfLgP8a+UIfxgh0roUXmiZtX6DLZPGH+8=; b=oYTUNlGlEYzsUvRzt0irBGb6JT32JiFthF+z848S/yktb3qD88hm8v97Ck1xB5XnGXxR gM+05BCyzaU70eRb7ZXlEfLg1iztZDKjgSWsujQj0IHi4nQfvNJwI9AtzkrhJajlLuOZ S5HKPzXNv7ZdOkxXKCakFgs2HAMVx2qo8OaDBQhfa+x/sYw7Zkj0Bxt3KnG13ez5mLJx IENZrJdVOVAz/fw6asgDRyyia0qzv98q8O4A5swafj1yftaiXCk4HQoWwg7+9FNhXBx7 ymdtz3SH6NTl3aVrpUcZZpw4A9+Sblf21E+npi75YKAVMqFN8q5Hs8b1XZQtqdJEanzZ Ig== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2t9cyqf6pu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 00:00:53 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PNxTE2181108; Wed, 26 Jun 2019 00:00:53 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2tat7ch5yh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 00:00:53 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5Q00mNj007195; Wed, 26 Jun 2019 00:00:50 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 25 Jun 2019 17:00:47 -0700 (PDT) From: Drew Adams To: Michael Heerdegen Subject: RE: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <87ftnxmfoo.fsf@web.de> <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> <875zotmedp.fsf@web.de> In-Reply-To: <875zotmedp.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=973 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250198 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250198 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22457 Cc: Lars Ingebrigtsen , 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > It works as coded, however, because Emacs regexp matching treats a > > special char such as `*' as non-special in such a context. >=20 > Oh, indeed. But not for `.' I think. Right again. (And yes, one can use `.' as a marker char.) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 04:50:35 2019 Received: (at 22457) by debbugs.gnu.org; 26 Jun 2019 08:50:35 +0000 Received: from localhost ([127.0.0.1]:34219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg3dS-0008JM-2c for submit@debbugs.gnu.org; Wed, 26 Jun 2019 04:50:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:42124 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg3dP-0008J8-Vf for 22457@debbugs.gnu.org; Wed, 26 Jun 2019 04:50:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CA87AACA7; Wed, 26 Jun 2019 08:50:25 +0000 (UTC) From: Andreas Schwab To: Drew Adams Subject: Re: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <87ftnxmfoo.fsf@web.de> <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> X-Yow: I just heard the SEVENTIES were over!! And I was just getting in touch with my LEISURE SUIT!! Date: Wed, 26 Jun 2019 10:50:24 +0200 In-Reply-To: <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> (Drew Adams's message of "Tue, 25 Jun 2019 16:26:58 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22457 Cc: Michael Heerdegen , Lars Ingebrigtsen , 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Jun 25 2019, Drew Adams wrote: >> Oh, btw, this patch line >> >> (looking-at-p (char-to-string dired-marker-char)) >> >> is not good if dired-marker-char is a regexp special like . or ?, I >> guess (regexp-quote missing)? > > It's a good point; it would be clearer to wrap the > arg to `looking-at-p' with `regexp-quote'. I think it's better to say (eq (char-after) dired-marker-char). Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 09:32:59 2019 Received: (at 22457) by debbugs.gnu.org; 26 Jun 2019 13:32:59 +0000 Received: from localhost ([127.0.0.1]:34521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg82k-0006wB-Ou for submit@debbugs.gnu.org; Wed, 26 Jun 2019 09:32:58 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg82i-0006vz-MD for 22457@debbugs.gnu.org; Wed, 26 Jun 2019 09:32:57 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QDT6Ju044421; Wed, 26 Jun 2019 13:32:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=+94KiGKcfWDtW9odqdwbu35VKHZnQlYmADV3PdqJhnU=; b=IrIngQIAOSXxlx/JB3TPqVfHY3Fy9zPL1RzC1CdigwjRcUevRx6sZDqoodJWMgaSz76n AyUnsAdgz/v1CdT0mCN8gw6sX+0Lw7vEc7dzAut8hzVCXPV606TBwaTLDxXpj/iKDXfA G6TIXWqUWgSnoah8gkiHAgQNDDzE1qPadNKB3D7ZhIUw+yh+iDfZvx/hk7jAE+nXBkcG kEOkM8I8401Byy9xQ53yBk2EqZbitFieOeScCXrUoxGpP4tq13mhBBg+3lD/Wihd9oJX vpv5OMisNJKuRTO8egzgM2lY22aB1UDULjYlNyHlpNvfC3T029HTO45/AxFSXdOZC+TA nQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2t9cyqj9v3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 13:32:49 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QDVWUZ037704; Wed, 26 Jun 2019 13:32:49 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2t9accpv6k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 13:32:48 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5QDWla6005576; Wed, 26 Jun 2019 13:32:48 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 26 Jun 2019 06:32:46 -0700 (PDT) From: Drew Adams To: Andreas Schwab Subject: RE: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <87ftnxmfoo.fsf@web.de> <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=922 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260161 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=989 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260161 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22457 Cc: Michael Heerdegen , Lars Ingebrigtsen , 22457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I think it's better to say (eq (char-after) dired-marker-char). Yes, good. Not a big deal either way, but that's simpler and clearer. From unknown Sun Jul 27 03:52:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 25 Jul 2019 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator