From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 10:53:20 2016 Received: (at submit) by debbugs.gnu.org; 22 Jan 2016 15:53:20 +0000 Received: from localhost ([127.0.0.1]:58013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMe1X-00063Y-Ez for submit@debbugs.gnu.org; Fri, 22 Jan 2016 10:53:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41201) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMV5m-0003mq-Fh for submit@debbugs.gnu.org; Fri, 22 Jan 2016 01:21:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMV5f-0005Mz-OF for submit@debbugs.gnu.org; Fri, 22 Jan 2016 01:21:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMV5f-0005Mv-LY for submit@debbugs.gnu.org; Fri, 22 Jan 2016 01:20:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMV5d-0002oR-P9 for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 01:20:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMV5a-0005Ml-F0 for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 01:20:57 -0500 Received: from idmx01.uzh.ch ([130.60.205.53]:48055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMV5a-0005Md-0T for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 01:20:54 -0500 Received: from idsmtp02.uzh.ch ([130.60.206.121]:46099) by idmx01.uzh.ch with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aMV5W-0004LS-0c for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 07:20:50 +0100 Received: from [31.24.15.133] (helo=[192.168.178.47]) by idsmtp02.uzh.ch with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aMV5V-0005Fa-Dv for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 07:20:49 +0100 To: bug-gnu-emacs@gnu.org From: "Pascal A. Niklaus" Subject: 25.0.50; recentf pastes X clipboard upon opening Message-ID: <56A1CA3F.1000303@ieu.uzh.ch> Date: Fri, 22 Jan 2016 07:20:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="------------020403060501070907090603" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 22 Jan 2016 10:53:17 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------020403060501070907090603 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit When opening a file with recentf-open-files, the X clipboard content is pasted into the opened file, where the mouse pointer is at that moment. To reproduce this behaviour: Start emacs with "emacs -Q" Evaluate to following lines: (M-:) (require 'recentf) (recentf-mode 1) Fill the clipboard with something by selecting some text (in e.g. a terminal window... text that would typically be pasted by a middle button click) M-x recentf-open-files Choose a file from the menu In my setup at least, the selected text is pasted into the file right where the mouse pointer was when I chose the file from recentf's menu with a left-click. In GNU Emacs 25.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2015-10-28 on pnX230 Windowing system distributor `The X.Org Foundation', version 11.0.11501000 System Description: Linux Mint 17.2 Rafaela Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB Important settings: value of $LC_MONETARY: de_CH.UTF-8 value of $LC_NUMERIC: de_CH.UTF-8 value of $LC_TIME: en_DK.utf8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: C/l Minor modes in effect: diff-auto-refine-mode: t shell-dirtrack-mode: t recentf-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t abbrev-mode: t Recent messages: Making completion list... Loading /home/...my-user-name....../.emacs.d/recentf...done Cleaning up the recentf list...done (0 removed) t 25 (#o31, #x19, ?\C-y) Mark set Making completion list... [3 times] Open /file-name-removed.../filename Mark set Undo! Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils vc-git diff-mode easy-mmode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs tramp-cache tramp-sh tramp tramp-compat auth-source cl-macs cl-seq eieio byte-opt gv bytecomp byte-compile cl-extra seq cconv eieio-core gnus-util mm-util mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color ring format-spec advice help-fns recentf tree-widget wid-edit cl-loaddefs pcase cl-lib easymenu time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 127118 7299) (symbols 48 24176 1) (miscs 40 170 115) (strings 32 29125 4789) (string-bytes 1 1014631) (vectors 16 17393) (vector-slots 8 471761 6290) (floats 8 163 51) (intervals 56 424 2) (buffers 976 13) (heap 1024 31663 1058)) --------------020403060501070907090603 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

When opening a file with recentf-open-files, the X clipboard content is

pasted into the opened file, where the mouse pointer is at that moment.


To reproduce this behaviour:


Start emacs with "emacs -Q"


Evaluate to following lines: (M-:)

(require 'recentf)

(recentf-mode 1)


Fill the clipboard with something by selecting some text (in e.g. a terminal window... text that would typically be pasted by a

middle button click)


M-x recentf-open-files


Choose a file from the menu

In my setup at least, the selected text is pasted into the file right where the

mouse pointer was when I chose the file from recentf's menu with a

left-click.



In GNU Emacs 25.0.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)

of 2015-10-28 on pnX230

Windowing system distributor `The X.Org Foundation', version 11.0.11501000

System Description: Linux Mint 17.2 Rafaela


Configured features:

XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS

NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB


Important settings:

value of $LC_MONETARY: de_CH.UTF-8

value of $LC_NUMERIC: de_CH.UTF-8

value of $LC_TIME: en_DK.utf8

value of $LANG: en_US.UTF-8

locale-coding-system: utf-8-unix


Major mode: C/l


Minor modes in effect:

diff-auto-refine-mode: t

shell-dirtrack-mode: t

recentf-mode: t

tooltip-mode: t

global-eldoc-mode: t

electric-indent-mode: t

mouse-wheel-mode: t

tool-bar-mode: t

menu-bar-mode: t

file-name-shadow-mode: t

global-font-lock-mode: t

font-lock-mode: t

blink-cursor-mode: t

auto-composition-mode: t

auto-encryption-mode: t

auto-compression-mode: t

line-number-mode: t

abbrev-mode: t


Recent messages:

Making completion list...

Loading /home/...my-user-name....../.emacs.d/recentf...done

Cleaning up the recentf list...done (0 removed)

t

25 (#o31, #x19, ?\C-y)

Mark set

Making completion list... [3 times]

Open /file-name-removed.../filename

Mark set

Undo!


Load-path shadows:

None found.


Features:

(shadow sort mail-extr emacsbug message dired rfc822 mml mml-sec

mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils

mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils vc-git

diff-mode easy-mmode cc-mode cc-fonts cc-guess cc-menus cc-cmds

cc-styles cc-align cc-engine cc-vars cc-defs tramp-cache tramp-sh tramp

tramp-compat auth-source cl-macs cl-seq eieio byte-opt gv bytecomp

byte-compile cl-extra seq cconv eieio-core gnus-util mm-util mail-prsvr

password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color

ring format-spec advice help-fns recentf tree-widget wid-edit

cl-loaddefs pcase cl-lib easymenu time-date mule-util tooltip eldoc

electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win

term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe

tabulated-list newcomment elisp-mode lisp-mode prog-mode register page

menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock

syntax facemenu font-core frame cl-generic cham georgian utf-8-lang

misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms

cp51932 hebrew greek romanian slovak czech european ethiopic indian

cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev

minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp

files text-properties overlay sha1 md5 base64 format env code-pages mule

custom widget hashtable-print-readable backquote dbusbind gfilenotify

dynamic-setting system-font-setting font-render-setting move-toolbar gtk

x-toolkit x multi-tty make-network-process emacs)


Memory information:

((conses 16 127118 7299)

(symbols 48 24176 1)

(miscs 40 170 115)

(strings 32 29125 4789)

(string-bytes 1 1014631)

(vectors 16 17393)

(vector-slots 8 471761 6290)

(floats 8 163 51)

(intervals 56 424 2)

(buffers 976 13)

(heap 1024 31663 1058))

--------------020403060501070907090603-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 16:44:39 2016 Received: (at control) by debbugs.gnu.org; 22 Jan 2016 21:44:40 +0000 Received: from localhost ([127.0.0.1]:58139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMjVX-0000lq-MJ for submit@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52594) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMjVV-0000lb-Hs for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMjVP-0006Jh-S5 for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMjVP-0006Jd-PA for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:31 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aMjVP-0000YT-FP for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:31 -0500 Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Fri, 22 Jan 2016 16:44:31 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 22434 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 16:44:52 2016 Received: (at control) by debbugs.gnu.org; 22 Jan 2016 21:44:52 +0000 Received: from localhost ([127.0.0.1]:58142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMjVj-0000mH-Tv for submit@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52619) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMjVj-0000m3-1f for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMjVd-0006KZ-F5 for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMjVd-0006KV-CM for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:45 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aMjVd-0000ZJ-2x for control@debbugs.gnu.org; Fri, 22 Jan 2016 16:44:45 -0500 Subject: control message for bug 22434 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Fri, 22 Jan 2016 16:44:45 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) tag 22434 confirmed From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 13:12:53 2016 Received: (at 22434) by debbugs.gnu.org; 28 Feb 2016 18:12:53 +0000 Received: from localhost ([127.0.0.1]:50974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aa5ps-0006Ed-MA for submit@debbugs.gnu.org; Sun, 28 Feb 2016 13:12:53 -0500 Received: from p654789.hkidff01.ap.so-net.ne.jp ([121.101.71.137]:52334 helo=gw.atmark-techno.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZzXV-0006JG-Jn for 22434@debbugs.gnu.org; Sun, 28 Feb 2016 06:29:30 -0500 Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by gw.atmark-techno.com (Postfix) with ESMTPS id 628A91FF99 for <22434@debbugs.gnu.org>; Sun, 28 Feb 2016 20:29:14 +0900 (JST) Received: by mail-pa0-f42.google.com with SMTP id yy13so75765292pab.3 for <22434@debbugs.gnu.org>; Sun, 28 Feb 2016 03:29:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:subject:user-agent :mime-version; bh=u/WV8tjSj3wh5a8wyS4dp9vuk75E65/3t7dxn7AoMYw=; b=fa7ScrWNlHIZH1WKgD5WnlmV2L4xrlj5pXCQZ1YWC/k3xYu0YK+albTZ+Gpw7ydbSP +Ysf7kPpZwEuDaOEAN6i3aIZMSAhaDWBGrMw42vkEmD+S9MjqKARbYDMI6ttLgpRPuYL 8wF6849Hz6exx4LqsIe1n2Jbvz2iX7UyTD3fH5u+ePFdfSe4gPWLZFG0taYRs2PHFPOk BcSzfahrG+2oPPyiBYp1WrJkAXCE2JJ3pH40X7vzm7ptwIIPosgRWMQory02d+E4eeJh y0iNQIk6W7B2XpfHy9YOW6L6E327x7Y433XNZLalP9ZZxkdOm3nbIAZkEg/1Qm8mFyEc /fHQ== X-Gm-Message-State: AD7BkJKaGKd5F7l4pi2HX1kyel1nsC9iK6+PD0yV8pNDCtekqngrMaE2hXnL27NbHkcfdZ1oBEmT8c1LYZE1s7udiibBgNA+HukjUU/THjZy4qfgvEduM0TQ4ij5ZEG44Rs17q+eU8IxUA== X-Received: by 10.66.147.74 with SMTP id ti10mr14957211pab.128.1456658952892; Sun, 28 Feb 2016 03:29:12 -0800 (PST) X-Received: by 10.66.147.74 with SMTP id ti10mr14957204pab.128.1456658952794; Sun, 28 Feb 2016 03:29:12 -0800 (PST) Received: from leno.local-network (ec2-176-32-85-91.ap-northeast-1.compute.amazonaws.com. [176.32.85.91]) by smtp.gmail.com with ESMTPSA id x1sm30931498pfi.42.2016.02.28.03.29.11 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 28 Feb 2016 03:29:12 -0800 (PST) Date: Sun, 28 Feb 2016 20:29:10 +0900 Message-ID: <87wpppvzsp.wl@dns1.atmark-techno.com> From: Yasushi SHOJI To: 22434@debbugs.gnu.org Subject: Re: 25.0.50; recentf pastes X clipboard upon opening User-Agent: Wanderlust/2.15.9 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I've tracked down with git bisect to 18b8557f5ab154625d72891bdb982da14091da4d which is a fix to #18015 [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 TRACKER_ID BODY: Incorporates a tracking ID number X-Debbugs-Envelope-To: 22434 X-Mailman-Approved-At: Sun, 28 Feb 2016 13:12:51 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.4 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I've tracked down with git bisect to 18b8557f5ab154625d72891bdb982da14091da4d which is a fix to #18015 [...] Content analysis details: (2.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RCVD_IN_RP_RNBL RBL: Relay in RNBL, https://senderscore.org/blacklistlookup/ [121.101.71.137 listed in bl.score.senderscore.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 TRACKER_ID BODY: Incorporates a tracking ID number I've tracked down with git bisect to 18b8557f5ab154625d72891bdb982da14091da4d which is a fix to #18015 http://debbugs.gnu.org/18015 In the commit `mouse--down-1-maybe-follows-link' is changed to read event using `read-key' instead of `read-event'. Changing back to `read-event' fixes this bug, however, I assume that will re-introduce the xterm-mouse-mode problem. Mouse 1 event is converted to Mouse 2 event, which is an event to past X selection. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 11:40:11 2016 Received: (at control) by debbugs.gnu.org; 14 Apr 2016 15:40:11 +0000 Received: from localhost ([127.0.0.1]:35503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjNL-00067E-6y for submit@debbugs.gnu.org; Thu, 14 Apr 2016 11:40:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjNK-00066V-9x for control@debbugs.gnu.org; Thu, 14 Apr 2016 11:40:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqjID-0005B5-Vi for control@debbugs.gnu.org; Thu, 14 Apr 2016 11:34:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqjID-0005Az-TA for control@debbugs.gnu.org; Thu, 14 Apr 2016 11:34:53 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aqjID-0002Uh-Ib for control@debbugs.gnu.org; Thu, 14 Apr 2016 11:34:53 -0400 Subject: control message for bug 23288 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 14 Apr 2016 11:34:53 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 22434 23288 From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 15:18:05 2016 Received: (at 22434) by debbugs.gnu.org; 21 May 2016 19:18:05 +0000 Received: from localhost ([127.0.0.1]:60180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4CPV-0005Ry-F0 for submit@debbugs.gnu.org; Sat, 21 May 2016 15:18:05 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4CPT-0005RU-Ux for 22434@debbugs.gnu.org; Sat, 21 May 2016 15:18:04 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DF6F1161352; Sat, 21 May 2016 12:17:57 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nJh-Io7T-lTn; Sat, 21 May 2016 12:17:57 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 105E9161355; Sat, 21 May 2016 12:17:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Gx3RZqqWQcmX; Sat, 21 May 2016 12:17:56 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DCF5B161352; Sat, 21 May 2016 12:17:56 -0700 (PDT) To: Stefan Monnier From: Paul Eggert Subject: Re: 25.0.50; recentf pastes X clipboard upon opening Organization: UCLA Computer Science Department Message-ID: <5740B464.6020008@cs.ucla.edu> Date: Sat, 21 May 2016 12:17:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 Cc: 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Stefan, it appears that your commit 18b8557f5ab154625d72891bdb982da14091da4d dated 2014-10-21 is associated with Bug#22434, which is listed as a blocker for Emacs 25. Could you please take a look at it and let us know what you think? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 16:32:30 2016 Received: (at 22434) by debbugs.gnu.org; 21 May 2016 20:32:30 +0000 Received: from localhost ([127.0.0.1]:60193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4DZW-0007A6-E4 for submit@debbugs.gnu.org; Sat, 21 May 2016 16:32:30 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:45444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4DZU-00079y-12 for 22434@debbugs.gnu.org; Sat, 21 May 2016 16:32:29 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u4LKWH0P023481; Sat, 21 May 2016 16:32:17 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 85085AE2FF; Sat, 21 May 2016 16:32:17 -0400 (EDT) From: Stefan Monnier To: Paul Eggert Subject: Re: 25.0.50; recentf pastes X clipboard upon opening Message-ID: References: <5740B464.6020008@cs.ucla.edu> Date: Sat, 21 May 2016 16:32:17 -0400 In-Reply-To: <5740B464.6020008@cs.ucla.edu> (Paul Eggert's message of "Sat, 21 May 2016 12:17:56 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5679=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5679> : inlines <4840> : streams <1639134> : uri <2214346> X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 22434 Cc: 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > Stefan, it appears that your commit 18b8557f5ab154625d72891bdb982da14091da4d > dated 2014-10-21 is associated with Bug#22434, which is listed as a blocker > for Emacs 25. Could you please take a look at it and let us know what you > think? Thanks. I'll take a look, thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 13:15:00 2016 Received: (at 22434) by debbugs.gnu.org; 22 May 2016 17:15:00 +0000 Received: from localhost ([127.0.0.1]:32991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4Wxw-0002hu-3Y for submit@debbugs.gnu.org; Sun, 22 May 2016 13:15:00 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:39398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4Wxt-0002hf-Lh for 22434@debbugs.gnu.org; Sun, 22 May 2016 13:14:58 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b4Wxn-00072T-4H; Sun, 22 May 2016 19:14:51 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b4Wxn-00040B-1e; Sun, 22 May 2016 19:14:51 +0200 From: Benjamin Riefenstahl To: 22434@debbugs.gnu.org Subject: 25.0.50; recentf pastes X clipboard upon opening Date: Sun, 22 May 2016 19:14:50 +0200 Message-ID: <8737pa9fqt.fsf@justinian.turtle-trading.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) For the record, I can reproduce this. Additional notes for the recipe: > M-x recentf-open-files One needs to have a recentf file "~/.emacs.d/recentf" from a previous use at this point. > Choose a file from the menu. Choose using the mouse. C-h l results in this log: [widget-button-click] [mouse-yank-primary] C-h l [view-lossage] >From where does the come here? Reviewing Stefan's change, reverting this hunk in lisp/mouse.el fixes the issue for me, but than that change was intentional of course :-( : @@ -112,7 +111,7 @@ mouse--down-1-maybe-follows-link timedout (not timedout)) nil - (let ((event (read-event))) + (let ((event (read-key))) ;Use read-key so it works for xterm-mouse-mode! (if (eq (car-safe event) (if (eq mouse-1-click-follows-link 'double) 'double-mouse-1 'mouse-1)) ;; Turn the mouse-1 into a mouse-2 to follow links. From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 13:30:46 2016 Received: (at 22434) by debbugs.gnu.org; 22 May 2016 17:30:46 +0000 Received: from localhost ([127.0.0.1]:33002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4XDB-00036R-QE for submit@debbugs.gnu.org; Sun, 22 May 2016 13:30:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4XDA-00036E-Pp for 22434@debbugs.gnu.org; Sun, 22 May 2016 13:30:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4XD1-00045E-Qb for 22434@debbugs.gnu.org; Sun, 22 May 2016 13:30:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4XD1-000458-MR; Sun, 22 May 2016 13:30:35 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b4XCy-0002AH-La; Sun, 22 May 2016 13:30:33 -0400 Date: Sun, 22 May 2016 20:30:29 +0300 Message-Id: <83wpmm57be.fsf@gnu.org> From: Eli Zaretskii To: Benjamin Riefenstahl In-reply-to: <8737pa9fqt.fsf@justinian.turtle-trading.net> (message from Benjamin Riefenstahl on Sun, 22 May 2016 19:14:50 +0200) Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 22434 Cc: 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Benjamin Riefenstahl > Date: Sun, 22 May 2016 19:14:50 +0200 > > C-h l results in this log: > > > [widget-button-click] > [mouse-yank-primary] > C-h l [view-lossage] > > >From where does the come here? See below: > @@ -112,7 +111,7 @@ mouse--down-1-maybe-follows-link > timedout (not timedout)) > nil > > - (let ((event (read-event))) > + (let ((event (read-key))) ;Use read-key so it works for xterm-mouse-mode! > (if (eq (car-safe event) (if (eq mouse-1-click-follows-link 'double) > 'double-mouse-1 'mouse-1)) > ;; Turn the mouse-1 into a mouse-2 to follow links. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Which continues: (let ((newup (if (eq mouse-1-click-follows-link 'double) 'double-mouse-2 'mouse-2))) From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 15:13:00 2016 Received: (at 22434) by debbugs.gnu.org; 22 May 2016 19:13:01 +0000 Received: from localhost ([127.0.0.1]:33044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4Yo8-000786-Op for submit@debbugs.gnu.org; Sun, 22 May 2016 15:13:00 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:39496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4Yo6-00077s-VB for 22434@debbugs.gnu.org; Sun, 22 May 2016 15:12:59 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b4Ynz-00075b-7G; Sun, 22 May 2016 21:12:51 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b4Ynz-0004MF-4I; Sun, 22 May 2016 21:12:51 +0200 From: Benjamin Riefenstahl To: Eli Zaretskii Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> Date: Sun, 22 May 2016 21:12:51 +0200 In-Reply-To: <83wpmm57be.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 May 2016 20:30:29 +0300") Message-ID: <877fel9aa4.fsf@blei.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 Cc: 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > From: Benjamin Riefenstahl >> From where does the come here? Eli Zaretskii writes: > See below: > >> @@ -112,7 +111,7 @@ mouse--down-1-maybe-follows-link >> timedout (not timedout)) >> nil >> >> - (let ((event (read-event))) >> + (let ((event (read-key))) ;Use read-key so it works for xterm-mouse-mode! >> (if (eq (car-safe event) (if (eq mouse-1-click-follows-link 'double) >> 'double-mouse-1 'mouse-1)) >> ;; Turn the mouse-1 into a mouse-2 to follow links. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Which continues: > > (let ((newup (if (eq mouse-1-click-follows-link 'double) > 'double-mouse-2 'mouse-2))) Right. I also see now that bug #23288 had a solution, but it does not work for me in this case. It depends on mouse-on-link-p to return a string or a vector, but what I get at this point is just t. Inside mouse-on-link-p the first branch of the cond is taken, because the follow-link property is 'mouse-face. This whole translation business seems fishy to me. There is no check that the cursor or at least the window are still the same when the mouse-2 handler is eventually called (it isn't here, I believe). There is no check that mouse-2 is actually bound to anything meaningfull that we want in addition to the mouse-1 handler. And what is the formal definition of 'meaningfull' here? And why is there a need to fall back to a mouse-2 handler when there is an explicit handler for mouse-1 already, widget-button-click in this case? Let the mouse-1 handler do what it wants to have done. From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 16:02:19 2016 Received: (at 22434) by debbugs.gnu.org; 22 May 2016 20:02:19 +0000 Received: from localhost ([127.0.0.1]:33062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4ZZq-0008Jt-R8 for submit@debbugs.gnu.org; Sun, 22 May 2016 16:02:19 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:39543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4ZZp-0008Jg-4d for 22434@debbugs.gnu.org; Sun, 22 May 2016 16:02:17 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b4ZZj-000777-0R; Sun, 22 May 2016 22:02:11 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b4ZZi-0004XF-Th; Sun, 22 May 2016 22:02:10 +0200 From: Benjamin Riefenstahl To: Eli Zaretskii Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> Date: Sun, 22 May 2016 22:02:10 +0200 In-Reply-To: <877fel9aa4.fsf@blei.turtle-trading.net> (Benjamin Riefenstahl's message of "Sun, 22 May 2016 21:12:51 +0200") Message-ID: <871t4t97zx.fsf@blei.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 Cc: 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Benjamin Riefenstahl writes: > I also see now that bug #23288 had a solution, but it does not work for > me in this case. It depends on mouse-on-link-p to return a string or a > vector, but what I get at this point is just t. Inside mouse-on-link-p > the first branch of the cond is taken, because the follow-link property > is 'mouse-face. I can make it work with the patch from #23288, when I also add this change to trigger the new code: diff --git a/lisp/recentf.el b/lisp/recentf.el index df7f3e2..f241cd4 100644 --- a/lisp/recentf.el +++ b/lisp/recentf.el @@ -1187,6 +1187,7 @@ recentf-open-files-item :format "%[%t\n%]" :help-echo ,(concat "Open " (cdr menu-element)) :action recentf-open-files-action + :follow-link [ignore] ,(cdr menu-element)))) (defun recentf-open-files-items (files) From debbugs-submit-bounces@debbugs.gnu.org Tue May 24 12:11:40 2016 Received: (at 22434) by debbugs.gnu.org; 24 May 2016 16:11:40 +0000 Received: from localhost ([127.0.0.1]:36595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5Evj-0006Om-Qw for submit@debbugs.gnu.org; Tue, 24 May 2016 12:11:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5Evh-0006OZ-Lj for 22434@debbugs.gnu.org; Tue, 24 May 2016 12:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5EvZ-0007tR-73 for 22434@debbugs.gnu.org; Tue, 24 May 2016 12:11:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5EvZ-0007tM-3Q; Tue, 24 May 2016 12:11:29 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4468 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b5EvX-00038g-A9; Tue, 24 May 2016 12:11:27 -0400 Date: Tue, 24 May 2016 19:11:29 +0300 Message-Id: <83eg8r4ery.fsf@gnu.org> From: Eli Zaretskii To: Benjamin Riefenstahl In-reply-to: <871t4t97zx.fsf@blei.turtle-trading.net> (message from Benjamin Riefenstahl on Sun, 22 May 2016 22:02:10 +0200) Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 22434 Cc: 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Benjamin Riefenstahl > Cc: 22434@debbugs.gnu.org > Date: Sun, 22 May 2016 22:02:10 +0200 > > Benjamin Riefenstahl writes: > > I also see now that bug #23288 had a solution, but it does not work for > > me in this case. It depends on mouse-on-link-p to return a string or a > > vector, but what I get at this point is just t. Inside mouse-on-link-p > > the first branch of the cond is taken, because the follow-link property > > is 'mouse-face. > > I can make it work with the patch from #23288, when I also add this > change to trigger the new code: Thanks, but we'd prefer to have a solution for this bug that doesn't require the #23288 patch, so we could fix recentf on the release branch. Could you perhaps come up with such a patch? From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 13:16:49 2016 Received: (at 22434) by debbugs.gnu.org; 25 May 2016 17:16:49 +0000 Received: from localhost ([127.0.0.1]:38522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5cQL-0003hq-FL for submit@debbugs.gnu.org; Wed, 25 May 2016 13:16:49 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:43027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5cQI-0003hc-UA for 22434@debbugs.gnu.org; Wed, 25 May 2016 13:16:47 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b5cQC-0001HC-N3; Wed, 25 May 2016 19:16:40 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b5cQC-0001VM-K9; Wed, 25 May 2016 19:16:40 +0200 From: Benjamin Riefenstahl To: Eli Zaretskii Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> Date: Wed, 25 May 2016 19:16:40 +0200 In-Reply-To: <83eg8r4ery.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 May 2016 19:11:29 +0300") Message-ID: <87vb22awhz.fsf@justinian.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 Cc: 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --=-=-= Content-Type: text/plain Hi Eli, Eli Zaretskii writes: > Thanks, but we'd prefer to have a solution for this bug that doesn't > require the #23288 patch, so we could fix recentf on the release > branch. Could you perhaps come up with such a patch? Does the attached fit the bill? It works for me. I hope I got the formalities right. IMO on master we really should either fix mouse--down-1-maybe-follows-link like in #23288 or re-think this strategy of generating an event for some random unknown consumer. so long, benny --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-bug-22434-recentf-pastes-X-clipboard.patch >From f1e368b62f9cb817c23bf1933f6820815ec20609 Mon Sep 17 00:00:00 2001 From: Benjamin Riefenstahl Date: Wed, 25 May 2016 19:03:36 +0200 Subject: [PATCH] Fix bug#22434, recentf pastes X clipboard A quick hack to avoid bug#22434. Introduces a special symbol for this purpose. * lisp/mouse.el (mouse--down-1-maybe-follows-link): React to 'do-not-follow-link. * lisp/recentf.el (recentf-open-files-item): Set :follow-link to 'do-not-follow-link. --- lisp/mouse.el | 9 ++++++++- lisp/recentf.el | 6 ++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/lisp/mouse.el b/lisp/mouse.el index fa355ff..4c31d65 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -98,7 +98,14 @@ mouse--down-1-maybe-follows-link (eq (if (eq mouse-1-click-follows-link 'double) 'double-down-mouse-1 'down-mouse-1) (car-safe last-input-event)) - (mouse-on-link-p (event-start last-input-event)) + ;; Hack: Conspire with recentf-open-files-item to not do + ;; this in the recentf-open-files dialog. The documented + ;; way would be to set :follow-link to a string or vector + ;; with a do-nothing event, but that does not work at + ;; this point, because this function does not implement + ;; that aspect. + (let ((action (mouse-on-link-p (event-start last-input-event)))) + (and action (not (eq action 'do-not-follow-link)))) (or mouse-1-click-in-non-selected-windows (eq (selected-window) (posn-window (event-start last-input-event))))) diff --git a/lisp/recentf.el b/lisp/recentf.el index df7f3e2..15114e3 100644 --- a/lisp/recentf.el +++ b/lisp/recentf.el @@ -1187,6 +1187,12 @@ recentf-open-files-item :format "%[%t\n%]" :help-echo ,(concat "Open " (cdr menu-element)) :action recentf-open-files-action + ;; Hack: Conspire with mouse--down-1-maybe-follows-link to + ;; not add a spurious mouse-2 event. The documented way + ;; would be to set :follow-link to a string or vector with + ;; a do-nothing event, but that does not work at this + ;; point. + :follow-link do-not-follow-link ,(cdr menu-element)))) (defun recentf-open-files-items (files) -- 2.1.4 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 25 16:58:17 2016 Received: (at 22434) by debbugs.gnu.org; 25 May 2016 20:58:17 +0000 Received: from localhost ([127.0.0.1]:38683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5fsb-0005W0-5U for submit@debbugs.gnu.org; Wed, 25 May 2016 16:58:17 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:58901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5fsZ-0005Vp-1z for 22434@debbugs.gnu.org; Wed, 25 May 2016 16:58:11 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u4PKw9c4005530; Wed, 25 May 2016 16:58:09 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 02960661A1; Wed, 25 May 2016 16:59:14 -0400 (EDT) From: Stefan Monnier To: Benjamin Riefenstahl Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening Message-ID: References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> Date: Wed, 25 May 2016 16:59:14 -0400 In-Reply-To: <87vb22awhz.fsf@justinian.turtle-trading.net> (Benjamin Riefenstahl's message of "Wed, 25 May 2016 19:16:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5683=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5683> : inlines <4862> : streams <1641283> : uri <2217034> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) > Does the attached fit the bill? It works for me. I hope I got the > formalities right. > IMO on master we really should either fix > mouse--down-1-maybe-follows-link like in #23288 or re-think this > strategy of generating an event for some random unknown consumer. Thinking about it some more, I think we have a deeper problem: it's not just for these recentf buttons that we shouldn't remap mouse-1 to mouse-2. It's for all widget buttons that have a mouse-1 binding to widget-button-click (of course, I consider the `down-mouse-1' binding to widget-button-click to be a bug as well (it should be bound to `mouse-1' instead) but I'd rather not touch this for now). The mouse-1 to mouse-2 remapping is to magically let mouse-1 work for "follow-link" depending on the value of mouse-1-click-follows-link, but here mouse-1 will always follow the link anyway, so remapping is undesirable. AFAIK we inherit the follow-link property from wid-edit's (define-widget 'link 'item "An embedded link." :button-prefix 'widget-link-prefix :button-suffix 'widget-link-suffix :follow-link 'mouse-face :help-echo "Follow the link." :format "%[%t%]") but I don't understand why we need this follow-link property there. I understand that changing this part of wid-edit in emacs-25 is too risky at this stage, so we'll probably want some stop-gap fix in the mean time, but I'd prefer for the stop-gap not to add too much ugly hack. How 'bout the patch below, which seems to do the trick for me? Stefan diff --git a/lisp/recentf.el b/lisp/recentf.el index df7f3e2..cab4a27 100644 --- a/lisp/recentf.el +++ b/lisp/recentf.el @@ -1064,7 +1064,7 @@ recentf-dialog-mode-map (define-key km "q" 'recentf-cancel-dialog) (define-key km "n" 'next-line) (define-key km "p" 'previous-line) - (define-key km [follow-link] "\C-m") + ;; (define-key km [follow-link] "\C-m") km) "Keymap used in recentf dialogs.") @@ -1186,7 +1186,10 @@ recentf-open-files-item :button-face default :format "%[%t\n%]" :help-echo ,(concat "Open " (cdr menu-element)) - :action recentf-open-files-action + :action ,#'recentf-open-files-action + ;; Override the (problematic) follow-link property of the + ;; `link' widget (bug#22434). + :follow-link nil ,(cdr menu-element)))) (defun recentf-open-files-items (files) From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 10:55:17 2016 Received: (at 22434) by debbugs.gnu.org; 29 May 2016 14:55:17 +0000 Received: from localhost ([127.0.0.1]:46542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b727Z-0001wy-5r for submit@debbugs.gnu.org; Sun, 29 May 2016 10:55:17 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:23187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b727W-0001wl-W3 for 22434@debbugs.gnu.org; Sun, 29 May 2016 10:55:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A3FgA731xV//v1SC1cgxCBMoJQhVW7QIdLBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBVh4FBQsLDiYSFBgNJBOIJAjPIwEBAQEBAQQBAQEBHos6hQUHhC0FtQQjggocgW4iMYJHAQEB X-IPAS-Result: A0A3FgA731xV//v1SC1cgxCBMoJQhVW7QIdLBAICgTw7EgEBAQEBAQGBCkEFg10BAQMBVh4FBQsLDiYSFBgNJBOIJAjPIwEBAQEBAQQBAQEBHos6hQUHhC0FtQQjggocgW4iMYJHAQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="239857597" Received: from 45-72-245-251.cpe.teksavvy.com (HELO pastel.home) ([45.72.245.251]) by ironport2-out.teksavvy.com with ESMTP; 29 May 2016 10:55:08 -0400 Received: by pastel.home (Postfix, from userid 20848) id 4D8CD61374; Sun, 29 May 2016 10:55:08 -0400 (EDT) From: Stefan Monnier To: Benjamin Riefenstahl Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening Message-ID: References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> Date: Sun, 29 May 2016 10:55:08 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 25 May 2016 16:59:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Ping? Stefan >>>>> "Stefan" == Stefan Monnier writes: [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [206.248.154.181 listed in list.dnswl.org] 1.0 FSL_HELO_HOME No description available. 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Ping? Stefan >>>>> "Stefan" == Stefan Monnier writes: [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [206.248.154.181 listed in list.dnswl.org] 1.0 FSL_HELO_HOME No description available. 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) Ping? Stefan >>>>> "Stefan" == Stefan Monnier writes: >> Does the attached fit the bill? It works for me. I hope I got the >> formalities right. >> IMO on master we really should either fix >> mouse--down-1-maybe-follows-link like in #23288 or re-think this >> strategy of generating an event for some random unknown consumer. > Thinking about it some more, I think we have a deeper problem: it's not > just for these recentf buttons that we shouldn't remap mouse-1 to > mouse-2. It's for all widget buttons that have a mouse-1 binding to > widget-button-click (of course, I consider the `down-mouse-1' binding to > widget-button-click to be a bug as well (it should be bound to `mouse-1' > instead) but I'd rather not touch this for now). > The mouse-1 to mouse-2 remapping is to magically let mouse-1 work for > "follow-link" depending on the value of mouse-1-click-follows-link, but > here mouse-1 will always follow the link anyway, so remapping > is undesirable. > AFAIK we inherit the follow-link property from wid-edit's > (define-widget 'link 'item > "An embedded link." > :button-prefix 'widget-link-prefix > :button-suffix 'widget-link-suffix > :follow-link 'mouse-face > :help-echo "Follow the link." > :format "%[%t%]") > but I don't understand why we need this follow-link property there. > I understand that changing this part of wid-edit in emacs-25 is too > risky at this stage, so we'll probably want some stop-gap fix in the > mean time, but I'd prefer for the stop-gap not to add too much ugly hack. > How 'bout the patch below, which seems to do the trick for me? > Stefan > diff --git a/lisp/recentf.el b/lisp/recentf.el > index df7f3e2..cab4a27 100644 > --- a/lisp/recentf.el > +++ b/lisp/recentf.el > @@ -1064,7 +1064,7 @@ recentf-dialog-mode-map > (define-key km "q" 'recentf-cancel-dialog) > (define-key km "n" 'next-line) > (define-key km "p" 'previous-line) > - (define-key km [follow-link] "\C-m") > + ;; (define-key km [follow-link] "\C-m") > km) > "Keymap used in recentf dialogs.") > @@ -1186,7 +1186,10 @@ recentf-open-files-item > :button-face default > :format "%[%t\n%]" > :help-echo ,(concat "Open " (cdr menu-element)) > - :action recentf-open-files-action > + :action ,#'recentf-open-files-action > + ;; Override the (problematic) follow-link property of the > + ;; `link' widget (bug#22434). > + :follow-link nil > ,(cdr menu-element)))) > (defun recentf-open-files-items (files) From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 12:52:44 2016 Received: (at 22434) by debbugs.gnu.org; 29 May 2016 16:52:44 +0000 Received: from localhost ([127.0.0.1]:46591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b73xE-0006I8-45 for submit@debbugs.gnu.org; Sun, 29 May 2016 12:52:44 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:47782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b73xC-0006Hu-7u for 22434@debbugs.gnu.org; Sun, 29 May 2016 12:52:42 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b73x2-0003qE-5M; Sun, 29 May 2016 18:52:32 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b73x2-0000xB-1t; Sun, 29 May 2016 18:52:32 +0200 From: Benjamin Riefenstahl To: Stefan Monnier Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> Date: Sun, 29 May 2016 18:52:31 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 29 May 2016 10:55:08 -0400") Message-ID: <87bn3o9580.fsf@justinian.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Stefan Monnier writes: > Ping? Sorry for the delay. >>>>>> "Stefan" == Stefan Monnier writes: >> How 'bout the patch below, which seems to do the trick for me? Works for me, too. >> AFAIK we inherit the follow-link property from wid-edit's > >> (define-widget 'link 'item >> "An embedded link." >> :button-prefix 'widget-link-prefix >> :button-suffix 'widget-link-suffix >> :follow-link 'mouse-face >> :help-echo "Follow the link." >> :format "%[%t%]") > >> but I don't understand why we need this follow-link property there. In principle we probably don't. Unless the property has some other use, I haven't studied this yet enough to say. Removing it would of course change the functionality, as we see in our use case here. benny From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 20:35:27 2016 Received: (at 22434) by debbugs.gnu.org; 30 May 2016 00:35:27 +0000 Received: from localhost ([127.0.0.1]:46733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7BB1-0000g4-GX for submit@debbugs.gnu.org; Sun, 29 May 2016 20:35:27 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7BAy-0000ft-Pb for 22434@debbugs.gnu.org; Sun, 29 May 2016 20:35:25 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u4U0ZNOJ020189; Sun, 29 May 2016 20:35:23 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 44E72AE29E; Sun, 29 May 2016 20:35:23 -0400 (EDT) From: Stefan Monnier To: Benjamin Riefenstahl Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening Message-ID: References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> <87bn3o9580.fsf@justinian.turtle-trading.net> Date: Sun, 29 May 2016 20:35:23 -0400 In-Reply-To: <87bn3o9580.fsf@justinian.turtle-trading.net> (Benjamin Riefenstahl's message of "Sun, 29 May 2016 18:52:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5687=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5687> : inlines <4880> : streams <1643510> : uri <2219902> X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >>> How 'bout the patch below, which seems to do the trick for me? > Works for me, too. Thanks, I installed only the second hunk since it seems to be sufficient. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 20:47:36 2016 Received: (at 22434) by debbugs.gnu.org; 30 May 2016 00:47:36 +0000 Received: from localhost ([127.0.0.1]:46737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7BMg-0000wT-LX for submit@debbugs.gnu.org; Sun, 29 May 2016 20:47:36 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7BMe-0000wK-WB for 22434@debbugs.gnu.org; Sun, 29 May 2016 20:47:29 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u4U0lMd5020621; Sun, 29 May 2016 20:47:26 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 7CBABAE29E; Sun, 29 May 2016 20:47:21 -0400 (EDT) From: Stefan Monnier To: Benjamin Riefenstahl Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening Message-ID: References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> <87bn3o9580.fsf@justinian.turtle-trading.net> Date: Sun, 29 May 2016 20:47:21 -0400 In-Reply-To: <87bn3o9580.fsf@justinian.turtle-trading.net> (Benjamin Riefenstahl's message of "Sun, 29 May 2016 18:52:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5687=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5687> : inlines <4880> : streams <1643515> : uri <2219907> X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >>> but I don't understand why we need this follow-link property there. > In principle we probably don't. Unless the property has some other use, > I haven't studied this yet enough to say. Removing it would of course > change the functionality, as we see in our use case here. I removed it in the `master' branch. I believe 22434 can be closed now, right? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 11:41:14 2016 Received: (at 22434) by debbugs.gnu.org; 30 May 2016 15:41:14 +0000 Received: from localhost ([127.0.0.1]:47745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7PJa-0008CM-GW for submit@debbugs.gnu.org; Mon, 30 May 2016 11:41:14 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:48971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7PJY-0008C9-KN for 22434@debbugs.gnu.org; Mon, 30 May 2016 11:41:13 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b7PJQ-0004ck-EJ; Mon, 30 May 2016 17:41:04 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b7PJQ-0004Oj-BS; Mon, 30 May 2016 17:41:04 +0200 From: Benjamin Riefenstahl To: Stefan Monnier Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> <87bn3o9580.fsf@justinian.turtle-trading.net> Date: Mon, 30 May 2016 17:41:04 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 29 May 2016 20:35:23 -0400") Message-ID: <87inxvsgdr.fsf@justinian.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Stefan Monnier writes: > Thanks, I installed only the second hunk since it seems to be sufficient. With only that, I can still reproduce the problem. If I read this right, mouse-on-link-p first looks at the property follow-link and it that is not set, it looks at the keybinding for follow-link. Stefan Monnier writes: > I believe 22434 can be closed now, right? When the key binding is deactivated, yes, that should be enough here. benny From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 12:34:02 2016 Received: (at 22434) by debbugs.gnu.org; 30 May 2016 16:34:02 +0000 Received: from localhost ([127.0.0.1]:47757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Q8f-00010e-VS for submit@debbugs.gnu.org; Mon, 30 May 2016 12:34:02 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Q8d-00010R-MT for 22434@debbugs.gnu.org; Mon, 30 May 2016 12:34:00 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u4UGXwoT021014; Mon, 30 May 2016 12:33:58 -0400 Received: by ceviche.home (Postfix, from userid 20848) id E4FA8661D3; Mon, 30 May 2016 12:35:09 -0400 (EDT) From: Stefan Monnier To: Benjamin Riefenstahl Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening Message-ID: References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> <87bn3o9580.fsf@justinian.turtle-trading.net> <87inxvsgdr.fsf@justinian.turtle-trading.net> Date: Mon, 30 May 2016 12:35:09 -0400 In-Reply-To: <87inxvsgdr.fsf@justinian.turtle-trading.net> (Benjamin Riefenstahl's message of "Mon, 30 May 2016 17:41:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5688=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5688> : inlines <4886> : streams <1643868> : uri <2220336> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) >> I believe 22434 can be closed now, right? > When the key binding is deactivated, yes, that should be enough here. OK. Can you install that change into emacs-25 for me? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 12:48:49 2016 Received: (at 22434) by debbugs.gnu.org; 30 May 2016 16:48:49 +0000 Received: from localhost ([127.0.0.1]:47761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7QMz-0001lA-BI for submit@debbugs.gnu.org; Mon, 30 May 2016 12:48:49 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:49038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7QMx-0001jN-Jw for 22434@debbugs.gnu.org; Mon, 30 May 2016 12:48:48 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b7QMp-0004er-KC; Mon, 30 May 2016 18:48:39 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b7QMp-0004ZH-HH; Mon, 30 May 2016 18:48:39 +0200 From: Benjamin Riefenstahl To: Stefan Monnier Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> <87bn3o9580.fsf@justinian.turtle-trading.net> <87inxvsgdr.fsf@justinian.turtle-trading.net> Date: Mon, 30 May 2016 18:48:39 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 30 May 2016 12:35:09 -0400") Message-ID: <87bn3nsd94.fsf@justinian.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434 Cc: Eli Zaretskii , 22434@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Stefan Monnier writes: > OK. Can you install that change into emacs-25 for me? I don't have access. @Eli, can you install it? We were talking about: diff --git a/lisp/recentf.el b/lisp/recentf.el index df7f3e2..cab4a27 100644 --- a/lisp/recentf.el +++ b/lisp/recentf.el @@ -1064,7 +1064,7 @@ recentf-dialog-mode-map (define-key km "q" 'recentf-cancel-dialog) (define-key km "n" 'next-line) (define-key km "p" 'previous-line) - (define-key km [follow-link] "\C-m") + ;; (define-key km [follow-link] "\C-m") km) "Keymap used in recentf dialogs.") benny From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 20:45:47 2016 Received: (at 22434-done) by debbugs.gnu.org; 31 May 2016 00:45:47 +0000 Received: from localhost ([127.0.0.1]:47928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7XoZ-0006Ce-Eh for submit@debbugs.gnu.org; Mon, 30 May 2016 20:45:47 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7XoY-0006CW-P6 for 22434-done@debbugs.gnu.org; Mon, 30 May 2016 20:45:47 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u4V0jh1r001858; Mon, 30 May 2016 20:45:43 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 18C61661CE; Mon, 30 May 2016 20:46:56 -0400 (EDT) From: Stefan Monnier To: Benjamin Riefenstahl Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening Message-ID: References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> <87bn3o9580.fsf@justinian.turtle-trading.net> <87inxvsgdr.fsf@justinian.turtle-trading.net> <87bn3nsd94.fsf@justinian.turtle-trading.net> Date: Mon, 30 May 2016 20:46:56 -0400 In-Reply-To: <87bn3nsd94.fsf@justinian.turtle-trading.net> (Benjamin Riefenstahl's message of "Mon, 30 May 2016 18:48:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5688=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5688> : inlines <4888> : streams <1644053> : uri <2220558> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 22434-done Cc: Eli Zaretskii , 22434-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) >> OK. Can you install that change into emacs-25 for me? > I don't have access. Sorry 'bout that. Installed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 31 15:18:01 2016 Received: (at 22434-done) by debbugs.gnu.org; 31 May 2016 19:18:01 +0000 Received: from localhost ([127.0.0.1]:48642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7pAv-0001u7-5J for submit@debbugs.gnu.org; Tue, 31 May 2016 15:18:01 -0400 Received: from odoacer.turtle-trading.net ([217.91.34.180]:50368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7pAt-0001tp-FE for 22434-done@debbugs.gnu.org; Tue, 31 May 2016 15:17:59 -0400 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1b7pAj-0005Nr-AF; Tue, 31 May 2016 21:17:49 +0200 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84_2) (envelope-from ) id 1b7pAj-0008Tb-72; Tue, 31 May 2016 21:17:49 +0200 From: Benjamin Riefenstahl To: Stefan Monnier Subject: Re: bug#22434: 25.0.50; recentf pastes X clipboard upon opening References: <56A1CA3F.1000303@ieu.uzh.ch> <8737pa9fqt.fsf@justinian.turtle-trading.net> <83wpmm57be.fsf@gnu.org> <877fel9aa4.fsf@blei.turtle-trading.net> <871t4t97zx.fsf@blei.turtle-trading.net> <83eg8r4ery.fsf@gnu.org> <87vb22awhz.fsf@justinian.turtle-trading.net> <87bn3o9580.fsf@justinian.turtle-trading.net> <87inxvsgdr.fsf@justinian.turtle-trading.net> <87bn3nsd94.fsf@justinian.turtle-trading.net> Date: Tue, 31 May 2016 21:17:49 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 30 May 2016 20:46:56 -0400") Message-ID: <87d1o2jaua.fsf@justinian.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 22434-done Cc: Eli Zaretskii , "Pascal A. Niklaus" , 22434-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Stefan Monnier writes: > Sorry 'bout that. Installed, No problem. It works for me now, so from my side it can be closed. benny From unknown Mon Aug 11 18:16:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 Jun 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator