GNU bug report logs -
#22392
25.0.50; NS Emacs run from OS X GUI doesn't set locale
Previous Next
Reported by: Alan Third <alan <at> idiocy.org>
Date: Sun, 17 Jan 2016 14:28:02 UTC
Severity: normal
Tags: patch
Found in version 25.0.50
Done: Paul Eggert <eggert <at> cs.ucla.edu>
Bug is archived. No further changes may be made.
Full log
Message #50 received at 22392 <at> debbugs.gnu.org (full text, mbox):
> Date: Wed, 27 Jan 2016 07:21:41 +0100
> From: Anders Lindgren <andlind <at> gmail.com>
> Cc: 22392 <at> debbugs.gnu.org, emacs-devel <emacs-devel <at> gnu.org>
>
> > * Why a separate source file? Is there any technical reasons why this
> > couldn't reside in, say, nsterm.m?
>
> No, I just wasn't sure what the deal was with including files like that
> in emacs.c since there's quite a lot in it. If that's an acceptable way
> to do it then I'd be happy to do so.
>
> Ah, I see. Including "nsterm.h" from "emacs.c" sounds like a bad idea, as it
> would increase the rebuild times.
Why is that? We already include nsterm.h in at least 2 other *.c
files, so why would a third one matter so much?
> In this case, introducing a new source file seems like the right
> choice.
I'd rather avoid a new file, especially as it's going to be very
small.
Thanks.
This bug report was last modified 9 years and 162 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.