From unknown Tue Jun 24 06:59:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22380: 24.5; erc doesn't handle the ! prefix Resent-From: David Edmondson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2016 16:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22380@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145287657511651 (code B ref -1); Fri, 15 Jan 2016 16:50:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Jan 2016 16:49:35 +0000 Received: from localhost ([127.0.0.1]:50155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aK7Z8-00031r-RF for submit@debbugs.gnu.org; Fri, 15 Jan 2016 11:49:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51527) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aK7Z7-00031f-Fk for submit@debbugs.gnu.org; Fri, 15 Jan 2016 11:49:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK7Z0-0007QE-IY for submit@debbugs.gnu.org; Fri, 15 Jan 2016 11:49:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7Z0-0007QA-FG for submit@debbugs.gnu.org; Fri, 15 Jan 2016 11:49:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7Yy-0004QO-Ke for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2016 11:49:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK7Yw-0007NB-TP for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2016 11:49:24 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:33238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK7Yw-0007Mp-EZ for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2016 11:49:22 -0500 Received: by mail-wm0-x22d.google.com with SMTP id f206so30516767wmf.0 for ; Fri, 15 Jan 2016 08:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:from:date:message-id:mime-version:content-type; bh=YlTDCNjXoNny5aJO2qigh3y2LNhMxbVQYgbhJDAaAx8=; b=jLHosik2658zGESwGCqjaXyGQ4qQbBwOyxQFI+rKRxitj7eFDCrt/IhtRGk9uDBU3+ oS57BHRl5w6X009oGFhLE0fblE64HxI15YH7f269pAPRjHFN21WlIA40xaj34i/2rChx UwfzFDaT9xs30NG/zPb8hMsGV+ZuJKhSns955lGaQgWh95pdafYvGhu1xKE3Er3nRZjm +QGZAD2S/oeHLNZWINkdeGJa//dvrJz/FL36WDOu+OzoatW2cKKSlZZ9jRz+4BGun44a zG6rm7YWxOzlpMl6qxnOrDb36Kw9TD8gYEl1YOipWGoDSDMIo7EIDxEs1xoVPT0J6hSF 9JUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:from:date:message-id:mime-version :content-type; bh=YlTDCNjXoNny5aJO2qigh3y2LNhMxbVQYgbhJDAaAx8=; b=UWD2rytATxVRkhN/ltes46JNCW568T6sRDIePfi80Wevvxm5KteE+Vmt81BhGLWcrh smGoP3FtbM8I1qZ7/opmLn9SOPfYPg9sdxohQ/Pta82xBPBXXRil51wrzoK9fjv3SEFA fbUd/LXnWNj3wU9xe6S4UoLH8DeXFHv3T6AWTC0JYgkmAuhcZ0TpDJOcyQE3CRY62mTo dIWtNxe3Cavoel+jjOaK1rmcpkauwihHZpNGwMY7Cmj71jMVyLZ9PLeiUW33ghUxPoxV 8nNbmd+r3dSBYn6TSSUfGAl3UdbkM/4Wx89Q5LthDxOF4S9xDYV17n41gA8uG+ZxUTt+ VGxQ== X-Gm-Message-State: AG10YORaZWw7/f4cDu85/M6WQDKQ+PujlqP++pdju0fjOJHuBFI1OBGOWRpey+4oZiqaEQ== X-Received: by 10.28.5.16 with SMTP id 16mr4552009wmf.71.1452876560725; Fri, 15 Jan 2016 08:49:20 -0800 (PST) Received: from disaster-area.hh.sledj.net ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) by smtp.gmail.com with ESMTPSA id u69sm3284397wmu.20.2016.01.15.08.49.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jan 2016 08:49:19 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 8413a671; Fri, 15 Jan 2016 16:49:18 +0000 (UTC) From: David Edmondson Date: Fri, 15 Jan 2016 16:49:19 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.4 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) Connect to a new IRC server at $employer (over SSL using built-in gnutls, but that doesn't seem relevant). See the errors (copied from the *Messages* buffer): error in process filter: erc-channel-receive-names: Unknown prefix char `33' error in process filter: Unknown prefix char `33' Examining the code, `erc-channel-receive-names' is trying to map prefix characters on the name to particular user capabilities. The set of allowed prefixes can be read from the server by `erc-parse-prefix'. In this case, the server is returning: "(yqaohvV)!~&@%+-" One of the users in a joined channel has the !/y prefix. `erc-channel-receive-names' doesn't know about the !/y prefix, so it emits an error at line 4793: (_ (error "Unknown prefix char `%S'" ch) voice)) It would be preferable if this was simply a notice rather than an error (or even silent). Adding support for the !/y prefix would also be great, but this problem would just re-arise if another currently unknown prefix is added by a server. Thanks for emacs! In GNU Emacs 24.5.1 (x86_64-apple-darwin15.0.0, NS apple-appkit-1404.11) of 2015-10-05 on heart-of-gold Windowing system distributor `Apple', version 10.3.1404 Configured using: `configure --prefix=/usr/local/Cellar/emacs/24.5 --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/24.5/share/info/emacs --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-ns --disable-ns-self-contained' Important settings: locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t erc-track-mode: t erc-track-minor-mode: t erc-spelling-mode: t erc-ring-mode: t erc-netsplit-mode: t erc-match-mode: t erc-list-mode: t erc-fill-mode: t erc-pcomplete-mode: t erc-autojoin-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-keep-place-mode: t erc-move-to-prompt-mode: t auto-revert-mode: t diff-auto-refine-mode: t show-paren-mode: t pdf-occur-global-minor-mode: t paredit-mode: t winner-mode: t ido-vertical-mode: t ido-everywhere: t eldoc-mode: t override-global-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Auto-saving...done Window Switching Mode On... Window Switching Mode Off. Window Switching Mode On... Window Switching Mode Off. Window Switching Mode On... Window Switching Mode Off. Window Switching Mode On... Window Switching Mode Off. Undo! Load-path shadows: /Users/dme/.emacs.d/elpa/let-alist-1.0.4/let-alist hides /usr/local/share/emacs/site-lisp/let-alist/let-alist /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-virtual hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-virtual /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-view hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-view /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-util hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-util /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-tools hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-tools /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-sync hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-sync /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-outline hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-outline /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-occur hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-occur /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-misc hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-misc /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-links hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-links /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-isearch hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-isearch /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-info hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-info /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-history hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-history /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-dev hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-dev /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-cache hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-cache /Users/dme/.emacs.d/elpa/pdf-tools-20151224.1159/pdf-annot hides /usr/local/share/emacs/site-lisp/pdf-tools/pdf-annot /Users/dme/.emacs.d/elpa/tablist-20150618.2218/tablist hides /usr/local/share/emacs/site-lisp/tablist/tablist /Users/dme/.emacs.d/elpa/tablist-20150618.2218/tablist-filter hides /usr/local/share/emacs/site-lisp/tablist/tablist-filter /Users/dme/.emacs.d/elpa/emms-20151211.1153/tq hides /usr/local/Cellar/emacs/24.5/share/emacs/24.5/lisp/emacs-lisp/tq Features: (shadow emacsbug cal-move view tramp-cmds conf-mode man dired-x pcmpl-unix linum magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-process magit-popup magit-mode magit-git magit-section magit-utils git-commit log-edit pcvs-util add-log with-editor async-bytecomp async tramp-sh dash eieio-opt speedbar sb-image ezimage dframe debug mingus libmpdee tabify image-file erc-log sendmail parse-time sort org-table org-element org-indent org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view org-bibtex bibtex org-bbdb org-w3m org-notmuch org-protocol org-capture org-location-google-maps org-agenda google-maps google-maps-static google-maps-geocode google-maps-base json org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func company-files company-oddmuse company-keywords company-etags etags company-gtags company-dabbrev-code company-dabbrev company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company pcase mail-extr win-switch windmove gnutls ruby-mode help-mode sh-script smie executable dired-aux tramp-cache tramp tramp-compat tramp-loaddefs trampver shell network-stream starttls tls erc-track erc-spelling erc-ring erc-netsplit erc-match erc-list erc-fill erc-pcomplete pcomplete erc-join erc-stamp erc-goodies erc erc-backend erc-compat vc-git autorevert filenotify smex shr-color color url-util url-parse auth-source gnus-util url-vars mm-archive misearch multi-isearch shr browse-url notmuch-config notmuch hl-line notmuch-message notmuch-maildir-fcc notmuch-tree notmuch-show notmuch-print notmuch-crypto notmuch-wash diff-mode coolj notmuch-query goto-addr icalendar diary-lib diary-loaddefs cal-menu calendar cal-loaddefs notmuch-tag crm server paren pdf-occur ibuf-ext ibuffer tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw eieio eieio-core mode-local cedet pdf-isearch let-alist pdf-misc imenu pdf-tools compile comint ansi-color cus-edit cus-start cus-load pdf-view mule-util bookmark pp jka-compr pdf-cache pdf-info tq pdf-util image-mode cl-macs notmuch-jump notmuch-hello notmuch-mua notmuch-address notmuch-company notmuch-parser wid-edit notmuch-lib cl gv mm-view mml-smime smime password-cache dig mailcap message idna format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader footnote cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs markdown-mode thingatpt noutline outline paredit flyspell ispell git-annex byte-opt advice winner ring ido-vertical-mode ido finder-inf eldoc help-fns edmacro kmacro dired exec-path-from-shell use-package diminish bytecomp byte-compile cl-extra cconv bind-key easy-mmode cl-loaddefs cl-lib tex-site info easymenu package epg-config time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) Memory information: ((conses 16 561789 76675) (symbols 48 53884 0) (miscs 40 2529 5293) (strings 32 144618 19496) (string-bytes 1 4207350) (vectors 16 58417) (vector-slots 8 1687920 55023) (floats 8 761 1110) (intervals 56 21321 1465) (buffers 960 122)) From unknown Tue Jun 24 06:59:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22380: [PATCH v1] erc: Don't raise an error for unknown user modes References: In-Reply-To: Resent-From: David Edmondson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jan 2016 10:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22380@debbugs.gnu.org Received: via spool by 22380-submit@debbugs.gnu.org id=B22380.145328732131019 (code B ref 22380); Wed, 20 Jan 2016 10:56:02 +0000 Received: (at 22380) by debbugs.gnu.org; 20 Jan 2016 10:55:21 +0000 Received: from localhost ([127.0.0.1]:54353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLqQ4-00084E-P0 for submit@debbugs.gnu.org; Wed, 20 Jan 2016 05:55:20 -0500 Received: from disaster-area.hh.sledj.net ([81.149.164.25]:61999 helo=heart-of-gold.hh.sledj.net) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLqQ2-000841-PN for 22380@debbugs.gnu.org; Wed, 20 Jan 2016 05:55:19 -0500 Received: by heart-of-gold.hh.sledj.net (Postfix, from userid 501) id CC7B3E82DD6; Wed, 20 Jan 2016 10:55:06 +0000 (GMT) From: David Edmondson Date: Wed, 20 Jan 2016 10:55:06 +0000 Message-Id: <1453287306-68145-1-git-send-email-dme@dme.org> X-Mailer: git-send-email 2.6.3 X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) If a user has a mode which is unknown, emit a message rather than raising an error. --- lisp/erc/erc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 56317b8..b7f40a8 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -4830,7 +4830,7 @@ channel." ((pred (eq op-ch)) op) ((pred (eq adm-ch)) admin) ((pred (eq own-ch)) owner) - (_ (error "Unknown prefix char `%S'" ch) voice)) + (_ (message "Unknown prefix char `%S'" ch) voice)) 'on))) (when updatep ;; If we didn't issue the NAMES request (consider two clients -- 2.6.3 From unknown Tue Jun 24 06:59:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22380: [PATCH v1] erc: Don't raise an error for unknown user modes References: In-Reply-To: Resent-From: David Edmondson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jan 2016 10:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22380@debbugs.gnu.org Received: via spool by 22380-submit@debbugs.gnu.org id=B22380.145328741831171 (code B ref 22380); Wed, 20 Jan 2016 10:57:01 +0000 Received: (at 22380) by debbugs.gnu.org; 20 Jan 2016 10:56:58 +0000 Received: from localhost ([127.0.0.1]:54357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLqRe-00086h-2J for submit@debbugs.gnu.org; Wed, 20 Jan 2016 05:56:58 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34874) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLqRc-00086Q-6G for 22380@debbugs.gnu.org; Wed, 20 Jan 2016 05:56:56 -0500 Received: by mail-wm0-f51.google.com with SMTP id r129so125901225wmr.0 for <22380@debbugs.gnu.org>; Wed, 20 Jan 2016 02:56:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=bPc6C8UixhoBkBFXBvosla8ctdhRkh66k5jrcKcOXWo=; b=guU+0c+and6vtzSVFc39Mod2timzKlpt5aIrHC6zFv4BSf5uvf/9CQdMGL4ix7j6/v bbaFhehTva6WD4d39PxGWmbu+B4uPx0EFRpIFAXPhqWISw7DXgkCwCAJabWFg/j9hHcE FHxDWTp4ptOwUq09VJxTHU2zLNwfQfF8x9aIHVta+cdyDzitYquwwYORhfBgzFgIga8k Ny06W1l5CLzRsYgru3aFkCQs96WgjOepvP60zwbiHQoJvxN7FSZZRhzgIYNlrZPSW8CZ HM0y/OgmQdC9XasvT5S//uspHBU9odtl+m6fBwkPXw9UNXW5KeG3dc+KrbWzsqKLFBfi RSkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=bPc6C8UixhoBkBFXBvosla8ctdhRkh66k5jrcKcOXWo=; b=mrctusZiQxjvvIzCvJkh4EQaxOB0IsjOwLhKK3+stnxtH+FhWJc5hARaFYAgByUlug HbWsynXFaipqcyVJ2Ix32m2gwfrsXhF1fpF7rVCkVySi3i/uI3NE2ESLKHAg7eLjjjax pGNHppmkQofQlzMb321pv1b+6y3vLSoTm1OoG+xfYjiB2o8no3i9JLArDKGo4+AGp2Rj mOsz6i1Dl0vObvw0IJ8JKcD7C3QaCbMAGaRPKjMJP1t9xeDpcFTWP0F/85H6JESc6emW gYBjkfC98WZhevmm1ILBdTkOeLk4RgjE/scByGiHa1HCMKb4zv2t7pDJfG6A4jrJuUY2 XYfA== X-Gm-Message-State: AG10YOSEdzaUogDCb3cAhmqScdkFw28lPZd5yJ8OfGRZVbnPthPQ+Zv8J61xz9B76HM01w== X-Received: by 10.28.90.133 with SMTP id o127mr3445981wmb.101.1453287410442; Wed, 20 Jan 2016 02:56:50 -0800 (PST) Received: from disaster-area.hh.sledj.net ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) by smtp.gmail.com with ESMTPSA id g187sm24558254wmf.8.2016.01.20.02.56.49 for <22380@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jan 2016 02:56:49 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id aa4b0007 for <22380@debbugs.gnu.org>; Wed, 20 Jan 2016 10:56:48 +0000 (UTC) From: David Edmondson Date: Wed, 20 Jan 2016 10:56:48 +0000 Message-Id: <1453287408-68247-1-git-send-email-dme@dme.org> X-Mailer: git-send-email 2.6.3 X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) If a user has a mode which is unknown, emit a message rather than raising an error. --- lisp/erc/erc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 56317b8..b7f40a8 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -4830,7 +4830,7 @@ channel." ((pred (eq op-ch)) op) ((pred (eq adm-ch)) admin) ((pred (eq own-ch)) owner) - (_ (error "Unknown prefix char `%S'" ch) voice)) + (_ (message "Unknown prefix char `%S'" ch) voice)) 'on))) (when updatep ;; If we didn't issue the NAMES request (consider two clients -- 2.6.3 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 22 08:32:58 2016 Received: (at control) by debbugs.gnu.org; 22 Jan 2016 13:32:58 +0000 Received: from localhost ([127.0.0.1]:57172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMbpi-0000uW-9v for submit@debbugs.gnu.org; Fri, 22 Jan 2016 08:32:58 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37409) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMbpg-0000u1-GH for control@debbugs.gnu.org; Fri, 22 Jan 2016 08:32:56 -0500 Received: by mail-wm0-f54.google.com with SMTP id n5so132350008wmn.0 for ; Fri, 22 Jan 2016 05:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=date:message-id:to:from:subject; bh=rdrA2u8sfBJ9ePZn784WF6dHM/fASq5NSINsI8CuCWs=; b=agJSqcKurdP0BFp2E5jzzPm8CIqCAuGlkeoDje/vJUCtrj/mgscy8z6A68UFp3tziN zTycfa1Wiq7AA83iItQCMTrgnawjRerZhsngVkYR/4CPh+dEPOvz02SesNi9PeWcwmBV ZztdNlVSnMxJWADh5hDXGc7tvGovnqi/VZa9/xQAXcy8FqNqg4uNFfiWXPxi6yA8ilzn u41M+6voY06cxsK7I5g7h6rE1XaUwuPjJwhzFV62W2LTW+bat6enwiW7s62+gX8P75qR JWKY8H238Pz7gALtgcf4hGFNpMmpeSn2iqWDX9RNnI1YLC78DhC6nXIaotYMM4tGzjWg Jfhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:to:from:subject; bh=rdrA2u8sfBJ9ePZn784WF6dHM/fASq5NSINsI8CuCWs=; b=Jlp6j2JlbLYmppjnyxD65q10IVJut0UUNaOPEZoCm0LKG8L0uH/zhMTK1iBVZrHeIc WP+5zv4HlDb6OR3fC6Vnp4D+DU1umVG8F9H+/TJbCNSABYRSYWjYrfzSOCg2E5fqP/TJ 9agCLyi/G6B/ytBMcb/wu2jI3/Bb8H5LCLaqshVsvERnjdQNzVudtji5DAHsjF2c/53c 2UbQPvVZhkuQKEjHGVfuhx6zWbbh3mTw5scwOabigliTf6jO1V6zue/VOctdRFI6sBY6 pIv1/I7iH2nCyynD5oj5MjpAgFVnp7GvG7uzVChp+3UvDfWDM9C9ksKWD2ZyXbrrlGJg krhg== X-Gm-Message-State: AG10YOSn6xWkTJfgbMf/D8PHl9tskvUlQS7ZuZ1CiTE0SOAPkBQOKWTuRdolPVD2cvyl2g== X-Received: by 10.194.133.10 with SMTP id oy10mr3062428wjb.93.1453469570892; Fri, 22 Jan 2016 05:32:50 -0800 (PST) Received: from disaster-area.hh.sledj.net ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) by smtp.gmail.com with ESMTPSA id t199sm2951916wmt.23.2016.01.22.05.32.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2016 05:32:49 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 00a4d983 for ; Fri, 22 Jan 2016 13:32:48 +0000 (UTC) Date: Fri, 22 Jan 2016 13:32:48 +0000 (GMT) Message-Id: <11868902936843688821.enqueue@disaster-area.hh.sledj.net> To: control@debbugs.gnu.org From: David Edmondson Subject: control message for bug #22380 X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) tags 22380 patch From unknown Tue Jun 24 06:59:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22380: [PATCH v1] erc: Don't raise an error for unknown user modes Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 05:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: David Edmondson Cc: 22380@debbugs.gnu.org Received: via spool by 22380-submit@debbugs.gnu.org id=B22380.145456516713891 (code B ref 22380); Thu, 04 Feb 2016 05:53:02 +0000 Received: (at 22380) by debbugs.gnu.org; 4 Feb 2016 05:52:47 +0000 Received: from localhost ([127.0.0.1]:58768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCqV-0003bz-47 for submit@debbugs.gnu.org; Thu, 04 Feb 2016 00:52:47 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:48647) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCqT-0003br-6y for 22380@debbugs.gnu.org; Thu, 04 Feb 2016 00:52:45 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRCq6-0008Fy-Qf; Thu, 04 Feb 2016 06:52:23 +0100 From: Lars Ingebrigtsen References: <1453287408-68247-1-git-send-email-dme@dme.org> Date: Thu, 04 Feb 2016 16:52:18 +1100 In-Reply-To: <1453287408-68247-1-git-send-email-dme@dme.org> (David Edmondson's message of "Wed, 20 Jan 2016 10:56:48 +0000") Message-ID: <87lh7110q5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aRCq6-0008Fy-Qf X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455169943.65871@gTdAOesAa4LF4QfpEKw0Ow X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) David Edmondson writes: > If a user has a mode which is unknown, emit a message rather than > raising an error. > --- > lisp/erc/erc.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el > index 56317b8..b7f40a8 100644 > --- a/lisp/erc/erc.el > +++ b/lisp/erc/erc.el > @@ -4830,7 +4830,7 @@ channel." > ((pred (eq op-ch)) op) > ((pred (eq adm-ch)) admin) > ((pred (eq own-ch)) owner) > - (_ (error "Unknown prefix char `%S'" ch) voice)) > + (_ (message "Unknown prefix char `%S'" ch) voice)) Thanks; applied to emacs-25. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 00:52:55 2016 Received: (at control) by debbugs.gnu.org; 4 Feb 2016 05:52:55 +0000 Received: from localhost ([127.0.0.1]:58771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCqd-0003cJ-Bj for submit@debbugs.gnu.org; Thu, 04 Feb 2016 00:52:55 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:48653) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCqb-0003cC-NY for control@debbugs.gnu.org; Thu, 04 Feb 2016 00:52:53 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRCqF-0008GA-Gj for control@debbugs.gnu.org; Thu, 04 Feb 2016 06:52:32 +0100 Date: Thu, 04 Feb 2016 16:52:27 +1100 Message-Id: <87k2ml10pw.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22380 X-MailScanner-ID: 1aRCqF-0008GA-Gj X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455169952.50378@EBVRcQEw8mZDD+pRfqtelg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 22380 fixed close 22380 25.1