From ian@digg.com Sun Feb 8 14:15:12 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 8 Feb 2009 22:15:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n18MF4Ri012642 for ; Sun, 8 Feb 2009 14:15:05 -0800 Received: from mx10.gnu.org ([199.232.76.166]:50854) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LWHtl-0004AT-Qn for emacs-pretest-bug@gnu.org; Sun, 08 Feb 2009 17:13:09 -0500 Received: from mail.digg.com ([64.191.203.36]:46177) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LWHvb-0005Pj-Bu for emacs-pretest-bug@gnu.org; Sun, 08 Feb 2009 17:15:03 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 2B431A85067 for ; Sun, 8 Feb 2009 14:15:02 -0800 (PST) X-Virus-Scanned: amavisd-new at Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zgw7-P20IqyE for ; Sun, 8 Feb 2009 14:15:01 -0800 (PST) Received: from [192.168.1.100] (adsl-69-104-91-111.dsl.pltn13.pacbell.net [69.104.91.111]) by mail.digg.com (Postfix) with ESMTP id 2132EA85062 for ; Sun, 8 Feb 2009 14:14:33 -0800 (PST) Message-Id: From: Ian Eure To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.930.3) Mime-Version: 1.0 (Apple Message framework v930.3) Subject: 23.0.90; [PATCH] Regression in python.el Date: Sun, 8 Feb 2009 14:13:32 -0800 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) In Emacs 22, python-mode had an option, python-use-skeletons, which controlled whether you would get a skeleton when you entered "def", or the plain text. This option is missing from Emacs 23 CVS, and I want the behavior back, as I find the skeletons to be obnoxious and undesirable. Patch is against current CVS HEAD. In GNU Emacs 23.0.90.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-02-03 on 64-71-7-199.static.wiline.com Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Diff Minor modes in effect: diff-auto-refine-mode: t twit-mode: t yas/minor-mode: t which-function-mode: t ime-bindings: t shell-dirtrack-mode: t show-paren-mode: t recentf-mode: t iswitchb-mode: t cua-mode: t auto-insert-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: M-/ C-M-h C-M-\ C-_ C-x C-s C-x b s h e l C-g C-c ! l s d i f f SPC - u SPC P p y SPC p y . M-p SPC > SPC ~ / u s e - M-b p y h o n t h i n o n C-e C-b C-b C-b C-b - C-e s k e l e t o n s . d i f f m v SPC ~ / p y ~ D / D e C-x C-f ~ / P r e m C-x C-d - n a m e SPC p y t h o n . e l C-s ; ; SPC s k e l e t C-e C-x 4 b p y C-n C-p C-n C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-SPC C-n C-n C-n C-n C-n C-e M-w C-x o C-y C-n C-v C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p M-m M-1 M-( o r i f SPC p y M-/ M-/ u s M-/ SPC C-o C-n C-n C-p C-p M-m C-SPC C-n C-n C-e C-n C-M-\ C-x C-s C-x v = C-x C-w ~ / p y t h o n - u s e - s k e l e t o n s . C-b - C V S H E A D C-e d i f f Recent messages: Completed [2 times] find-dired *Find* finished. Loading vc-cvs...done Mark saved where search started Mark set [3 times] Saving file /Users/ieure/Projects/emacs/lisp/progmodes/python.el... Mark set Wrote /Users/ieure/Projects/emacs/lisp/progmodes/python.el Finding changes in /Users/ieure/Projects/emacs/lisp/progmodes/python.el...done Wrote /Users/ieure/python-use-skeletons-CVSHEAD.diff From ian@digg.com Sun Feb 8 14:44:55 2009 Received: (at 2238) by emacsbugs.donarmstrong.com; 8 Feb 2009 22:44:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.digg.com (zimbra.digg.com [64.191.203.36]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n18MirEK019734 for <2238@emacsbugs.donarmstrong.com>; Sun, 8 Feb 2009 14:44:54 -0800 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 3E0E2A8505C for <2238@emacsbugs.donarmstrong.com>; Sun, 8 Feb 2009 14:44:48 -0800 (PST) X-Virus-Scanned: amavisd-new at Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MaQqjf9Iz52X for <2238@emacsbugs.donarmstrong.com>; Sun, 8 Feb 2009 14:44:47 -0800 (PST) Received: from [192.168.1.100] (adsl-69-104-91-111.dsl.pltn13.pacbell.net [69.104.91.111]) by mail.digg.com (Postfix) with ESMTP id B0166A85056 for <2238@emacsbugs.donarmstrong.com>; Sun, 8 Feb 2009 14:44:47 -0800 (PST) Message-Id: <27292569-94DB-4C83-A2EF-7BCBF3FFF339@digg.com> From: Ian Eure To: 2238@debbugs.gnu.org In-Reply-To: Content-Type: multipart/mixed; boundary=Apple-Mail-1-275333189 X-Mailer: Apple Mail (2.930.3) Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: bug#2238: Acknowledgement (23.0.90; [PATCH] Regression in python.el) Date: Sun, 8 Feb 2009 14:44:47 -0800 References: --Apple-Mail-1-275333189 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Forgot to attach the patch, here it is. --Apple-Mail-1-275333189 Content-Disposition: attachment; filename=python-use-skeletons-CVSHEAD.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="python-use-skeletons-CVSHEAD.diff" Content-Transfer-Encoding: quoted-printable ---=20python.el.~1.93.~=092009-02-02=2020:13:17.000000000=20-0800=0A+++=20= python.el=092009-02-08=2014:10:37.000000000=20-0800=0A@@=20-2205,6=20= +2205,13=20@@=0A=20=0C=0A=20;;;;=20Skeletons=0A=20=0A+(defcustom=20= python-use-skeletons=20nil=0A+=20=20"Non-nil=20means=20template=20= skeletons=20will=20be=20automagically=20inserted.=0A+This=20happens=20= when=20pressing=20\"if\",=20for=20example,=20to=20prompt=20for=0A= +the=20if=20condition."=0A+=20=20:type=20'boolean=0A+=20=20:group=20= 'python)=0A+=0A=20(define-abbrev-table=20'python-mode-abbrev-table=20()=0A= =20=20=20"Abbrev=20table=20for=20Python=20mode."=0A=20=20=20:case-fixed=20= t=0A@@=20-2221,9=20+2228,10=20@@=0A=20=20=20=20=20`(progn=0A=20=20=20=20=20= =20=20=20;;=20Usual=20technique=20for=20inserting=20a=20skeleton,=20but=20= expand=0A=20=20=20=20=20=20=20=20;;=20to=20the=20original=20abbrev=20= instead=20if=20in=20a=20comment=20or=20string.=0A-=20=20=20=20=20=20=20= (define-abbrev=20python-mode-abbrev-table=20,name=20""=0A-=09=20= ',function=0A-=09=20nil=20t)=09=09=09=09;=20system=20abbrev=0A+=20=20=20=20= =20=20=20(if=20python-use-skeletons=20=0A+=20=20=20=20=20=20=20=20=20=20=20= (define-abbrev=20python-mode-abbrev-table=20,name=20""=0A+=20=20=20=20=20= =20=20=20=20=20=20=20=20',function=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20nil=20t))=09=09=09=09;=20system=20abbrev=0A=20=20=20=20=20=20=20=20= (define-skeleton=20,function=0A=20=09=20,(format=20"Insert=20Python=20= \"%s\"=20template."=20name)=0A=20=09=20,@elements)))))=0A= --Apple-Mail-1-275333189 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit --Apple-Mail-1-275333189-- From monnier@iro.umontreal.ca Sun Feb 8 16:42:02 2009 Received: (at 2238) by emacsbugs.donarmstrong.com; 9 Feb 2009 00:42:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n190fxjf017203 for <2238@emacsbugs.donarmstrong.com>; Sun, 8 Feb 2009 16:42:00 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AikFACoLj0lFxIvi/2dsb2JhbACBbssjhBoGgx0 X-IronPort-AV: E=Sophos;i="4.37,401,1231131600"; d="scan'208";a="33557915" Received: from 69-196-139-226.dsl.teksavvy.com (HELO ceviche.home) ([69.196.139.226]) by ironport2-out.teksavvy.com with ESMTP; 08 Feb 2009 19:41:53 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 02131B4015; Sun, 8 Feb 2009 19:32:08 -0500 (EST) From: Stefan Monnier To: Ian Eure Cc: 2238@debbugs.gnu.org Subject: Re: bug#2238: Acknowledgement (23.0.90; [PATCH] Regression in python.el) Message-ID: References: <27292569-94DB-4C83-A2EF-7BCBF3FFF339@digg.com> Date: Sun, 08 Feb 2009 19:32:08 -0500 In-Reply-To: <27292569-94DB-4C83-A2EF-7BCBF3FFF339@digg.com> (Ian Eure's message of "Sun, 8 Feb 2009 14:44:47 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Forgot to attach the patch, here it is. How 'bout this patch instead? The main advantage is that it will correctly react to changes to python-use-skeletons without having to reload the mode. The main disadvantage is that it will control all abbrev expansions, not just the skeleton ones. Stefan --- python.el.~1.93.~ 2009-02-07 11:23:02.000000000 -0500 +++ python.el 2009-02-08 19:30:38.000000000 -0500 @@ -2205,13 +2205,21 @@ ;;;; Skeletons +(defcustom python-use-skeletons nil + "Non-nil means template skeletons will be automagically inserted. +This happens when pressing \"if\", for example, to prompt for +the if condition." + :type 'boolean + :group 'python) + (define-abbrev-table 'python-mode-abbrev-table () "Abbrev table for Python mode." :case-fixed t ;; Allow / inside abbrevs. :regexp "\\(?:^\\|[^/]\\)\\<\\([[:word:]/]+\\)\\W*" ;; Only expand in code. - :enable-function (lambda () (not (python-in-string/comment)))) + :enable-function (lambda () (and python-use-skeletons + (not (python-in-string/comment))))) (eval-when-compile ;; Define a user-level skeleton and add it to the abbrev table. From ian@digg.com Sun Feb 8 22:12:31 2009 Received: (at 2238) by emacsbugs.donarmstrong.com; 9 Feb 2009 06:12:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.digg.com (zimbra.digg.com [64.191.203.36]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n196CSei002684 for <2238@emacsbugs.donarmstrong.com>; Sun, 8 Feb 2009 22:12:29 -0800 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 47D94A8508F; Sun, 8 Feb 2009 22:12:23 -0800 (PST) X-Virus-Scanned: amavisd-new at Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id is2ygBkJx8FL; Sun, 8 Feb 2009 22:12:22 -0800 (PST) Received: from [192.168.1.100] (adsl-69-104-91-111.dsl.pltn13.pacbell.net [69.104.91.111]) by mail.digg.com (Postfix) with ESMTP id 6C089A85062; Sun, 8 Feb 2009 22:12:22 -0800 (PST) Cc: 2238@debbugs.gnu.org Message-Id: From: Ian Eure To: Stefan Monnier In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.930.3) Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: bug#2238: Acknowledgement (23.0.90; [PATCH] Regression in python.el) Date: Sun, 8 Feb 2009 22:12:21 -0800 References: <27292569-94DB-4C83-A2EF-7BCBF3FFF339@digg.com> On Feb 8, 2009, at 4:32 PM, Stefan Monnier wrote: >> Forgot to attach the patch, here it is. > > How 'bout this patch instead? The main advantage is that it will > correctly react to changes to python-use-skeletons without having to > reload the mode. The main disadvantage is that it will control all > abbrev expansions, not just the skeleton ones. > I like using abbrevs when coding Python, just not the invasive default ones. It also doesn't seem too friendly to kill people's python abbrevs when they upgrade from Emacs 22 to 23. I'd prefer the behavior in Emacs 22. From lekktu@gmail.com Mon Feb 9 13:05:30 2009 Received: (at control) by emacsbugs.donarmstrong.com; 9 Feb 2009 21:05:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT,NOSUBJECT, VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n19L5MAf031968 for ; Mon, 9 Feb 2009 13:05:23 -0800 Received: by ewy3 with SMTP id 3so2811189ewy.1 for ; Mon, 09 Feb 2009 13:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=eGdJRALjHU4/ReXmsiJAHpNrfxHlk7R2MDQXK1qV5vc=; b=HPSc/ktCFU2ByPEjpf0MhBLAG8h5Yn6LVnSUL9BJNiAZn6Q2RdDS8Jt2Bzchpo4DrR lBP6aj5rjr4sFO4gw4qDGQDJ8t7z9L/+Ty9Xucs/yriSJVsdmIZPoH2nM6hjZIRopLNi 4qVdq0G+cd+Zdfd9gYXbhwjAbtdXB7Q6gKZPc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=WXm/Z4MCXc/T41zL/OoD1yLBkkVPtS/I+/Nyu8qgvcOCAmIvlmVcYdQksdblI0X7XE CqMZbiC9jc7+jdsD+bBaxiL3bx0rw94Ec+AwvFZRkEqCucQaAnkM1JmlgL1It8iMJPy4 OUoeQhKdrbgP7+BUx8lj/X9vaPQbfx8lz4UL0= MIME-Version: 1.0 Received: by 10.210.89.4 with SMTP id m4mr4150900ebb.102.1234213516663; Mon, 09 Feb 2009 13:05:16 -0800 (PST) Date: Mon, 9 Feb 2009 22:05:16 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit reassign 2238 emacs,python reassign 2246 spam reassign 2251 emacs,rmail reassign 2252 emacs,python reassign 2253 spam reassign 2254 spam quit From rgm@gnu.org Thu Feb 12 20:11:26 2009 Received: (at 2238-done) by emacsbugs.donarmstrong.com; 13 Feb 2009 04:11:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1D4BN7r026864 for <2238-done@emacsbugs.donarmstrong.com>; Thu, 12 Feb 2009 20:11:25 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LXpMh-0006b0-UR; Thu, 12 Feb 2009 23:09:23 -0500 From: Glenn Morris To: 2238-done@debbugs.gnu.org Subject: Re: bug#2238: 23.0.90; [PATCH] Regression in python.el References: <27292569-94DB-4C83-A2EF-7BCBF3FFF339@digg.com> X-Spook: Abbas BLU-97 A/B Rumsfeld Firewalls Peking Merlin high X-Ran: 1PA9V1m}=*,D\kNmpZcNe:@tIO$b~$[.0_Z.lt_ki^/Ln\@wRDdMy_.cfcb&_}MPM,Fe{z X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 12 Feb 2009 23:09:23 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii 2009-02-12 Stefan Monnier * progmodes/python.el (python-use-skeletons): Re-add. (def-python-skeleton): Use it. From unknown Thu Aug 14 18:39:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Mar 2009 14:24:05 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator