GNU bug report logs - #22324
25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead)

Previous Next

Full log

Message #57 received at 22324 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 22324 <at> debbugs.gnu.org
Subject: Re: bug#22324: 25.0.50; completion-category-defaults style doesn't
 override completion-styles (gets prepended instead)
Date: Mon, 24 Jan 2022 10:46:51 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> So the fix I had in mind looks like:
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index d58c23af8f..0aee55f33c 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -1043,7 +1043,7 @@ completion--styles
>    (let* ((cat (completion-metadata-get metadata 'category))
>           (over (completion--category-override cat 'styles)))
>      (if over
> -        (delete-dups (append (cdr over) (copy-sequence completion-styles)))
> +        (cdr over)
>         completion-styles)))

Oh, I see.  Hm...  that would change the behaviour for those that depend
on this working the old way.

Perhaps it'd make more sense to add a new variable to allow real overrides?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.