GNU bug report logs - #22307
wildcards dir-locals causes significant build slow-down in some cases

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22307 in the body.
You can then email your comments to 22307 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #1 received at quiet <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: quiet <at> debbugs.gnu.org
Subject: wildcards dir-locals causes significant build slow-down in some cases
Date: Mon, 04 Jan 2016 20:24:23 -0500

Package: emacs
Version: 25.0.50

commit 2e8488858c (allow wildcards in dir-locals) caused a significant
(~20%) build slow down in some cases.

Ref thread:
http://lists.gnu.org/archive/html/emacs-devel/2015-12/msg00636.html 

Message #14 received at 22307 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 22307 <at> debbugs.gnu.org
Subject: Re: wildcards dir-locals causes significant build slow-down in some
 cases
Date: Sat, 02 Sep 2017 15:37:18 +0300

unblock 24655 by 22307
thanks

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Mon, 04 Jan 2016 20:24:23 -0500
> 
> Package: emacs
> Version: 25.0.50
> 
> commit 2e8488858c (allow wildcards in dir-locals) caused a significant
> (~20%) build slow down in some cases.
> 
> Ref thread:
> http://lists.gnu.org/archive/html/emacs-devel/2015-12/msg00636.html 

Having read that thread, and given the one and a half years since the
original report, this doesn't look like a problem that should block
the release of Emacs 26.1.

Thanks.

Message #19 received at 22307 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 22307 <at> debbugs.gnu.org
Subject: Re: wildcards dir-locals causes significant build slow-down in some
 cases
Date: Sat, 02 Sep 2017 21:10:26 -0400

Eli Zaretskii wrote:

> Having read that thread, and given the one and a half years since the
> original report, this doesn't look like a problem that should block
> the release of Emacs 26.1.

It was already reverted from the previous release branch because it
wasn't considered suitable for a release. Personally I think allowing
two dir-locals (as it is now) is just not a good idea; and it's not just
me, eg http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01581.html

Anyway, the plan was to improve it for 26:

    We can also just revert it from the release branch for the moment,
    and postpone it until emacs 26 while we settle on a preferred
    interface/implementation.

Nothing's happened since then AFAIK.
But I don't have anything else to say on the issue.

Message #22 received at 22307 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 22307 <at> debbugs.gnu.org
Subject: Re: bug#22307: wildcards dir-locals causes significant build
 slow-down in some cases
Date: Sun, 03 Dec 2017 22:02:34 -0500

There's no interest in addressing this issue. Closing as wontfix.

Message #29 received at 22307 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 22307 <at> debbugs.gnu.org
Subject: Re: bug#22307: wildcards dir-locals causes significant build
 slow-down in some cases
Date: Sun, 03 Dec 2017 22:38:36 -0500

Glenn Morris <rgm <at> gnu.org> writes:

> There's no interest in addressing this issue. Closing as wontfix.

I was going to take a look at this for Emacs 27, improving build times
is of interest to me.  Though the bug thread here is a bit unclear, it
talks about the wildcards being the problem, but then weren't the
general wildcards replaced with the more limited dir-locals-2 thing?

Message #32 received at 22307 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: rgm <at> gnu.org, 22307 <at> debbugs.gnu.org
Subject: Re: bug#22307: wildcards dir-locals causes significant build
 slow-down in some cases
Date: Mon, 04 Dec 2017 17:15:42 +0200

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Sun, 03 Dec 2017 22:38:36 -0500
> Cc: 22307 <at> debbugs.gnu.org
> 
> Glenn Morris <rgm <at> gnu.org> writes:
> 
> > There's no interest in addressing this issue. Closing as wontfix.
> 
> I was going to take a look at this for Emacs 27, improving build times
> is of interest to me.  Though the bug thread here is a bit unclear, it
> talks about the wildcards being the problem, but then weren't the
> general wildcards replaced with the more limited dir-locals-2 thing?

Feel free to reopen if you would like to work on this.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.