GNU bug report logs - #22295
viper-mode undo bug introduced between Nov 10 and Nov 14

Previous Next

Full log

Message #100 received at 22295 <at> debbugs.gnu.org (full text, mbox):

From: phillip.lord <at> russet.org.uk (Phillip Lord)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jwiegley <at> gmail.com, 22295 <at> debbugs.gnu.org, Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#22295: viper-mode undo bug introduced between Nov 10 and Nov
 14
Date: Fri, 20 May 2016 12:46:14 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> FWIW, I think this should go to emacs-25, since (a) the changes affect
> only viper-mode, and (b) users of that mode will be most unhappy
> without these changes.

Not quite true. I've changed simple.el.

The change is minimal, and just allows downstream developers to disable
the auto-undo boundary. However, if a developer does do this in a bad
way, then Emacs does produce pretty intrusive "this is probably a bug"
warnings.


> However, we should add comments to viper-cmd.el that document the
> special handling of 'undo' by viper-mode, and how that interacts with
> the core 'undo' functionalities.  We should also comment in simple.el
> that undo-auto-disable-boundaries is used by viper-mode, and document
> that variable in the ELisp manual.  Phillip, can you add these bits to
> the branch, please?


Oh, yeah, sorry forgot the manual. I updated most of the rest last
night. I think that the branch is ready, bar squashing.

Phil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.