From unknown Sun Jun 22 22:43:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#22278 <22278@debbugs.gnu.org> To: bug#22278 <22278@debbugs.gnu.org> Subject: Status: [PATCH] grep: report line-buffered write error right away Reply-To: bug#22278 <22278@debbugs.gnu.org> Date: Mon, 23 Jun 2025 05:43:32 +0000 retitle 22278 [PATCH] grep: report line-buffered write error right away reassign 22278 grep submitter 22278 Paul Eggert severity 22278 normal tag 22278 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 31 02:38:51 2015 Received: (at submit) by debbugs.gnu.org; 31 Dec 2015 07:38:51 +0000 Received: from localhost ([127.0.0.1]:50885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aEXox-0003SG-2Y for submit@debbugs.gnu.org; Thu, 31 Dec 2015 02:38:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45508) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aEXov-0003S5-KH for submit@debbugs.gnu.org; Thu, 31 Dec 2015 02:38:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aEXop-0000NI-IQ for submit@debbugs.gnu.org; Thu, 31 Dec 2015 02:38:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEXop-0000NE-F5 for submit@debbugs.gnu.org; Thu, 31 Dec 2015 02:38:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEXoo-0000Ec-Li for bug-grep@gnu.org; Thu, 31 Dec 2015 02:38:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aEXol-0000MY-G2 for bug-grep@gnu.org; Thu, 31 Dec 2015 02:38:42 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEXol-0000MS-AD for bug-grep@gnu.org; Thu, 31 Dec 2015 02:38:39 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 65B41160ED8 for ; Wed, 30 Dec 2015 23:38:38 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZyRdi_8YLBRr; Wed, 30 Dec 2015 23:38:37 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B387A160ED7; Wed, 30 Dec 2015 23:38:37 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MUJOBAsvrQqW; Wed, 30 Dec 2015 23:38:37 -0800 (PST) Received: from day.fios-router.home (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 84226160ED0; Wed, 30 Dec 2015 23:38:37 -0800 (PST) From: Paul Eggert To: bug-grep@gnu.org Subject: [PATCH] grep: report line-buffered write error right away Date: Wed, 30 Dec 2015 23:38:24 -0800 Message-Id: <1451547504-11076-1-git-send-email-eggert@cs.ucla.edu> X-Mailer: git-send-email 2.5.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * src/grep.c (prline): When line buffered, if there is a write error, report it immediately rather than waiting until the next line of output. --- src/grep.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/grep.c b/src/grep.c index 06f315d..696f4ce 100644 --- a/src/grep.c +++ b/src/grep.c @@ -1180,6 +1180,9 @@ prline (char *beg, char *lim, char sep) if (!only_matching && lim > beg) fwrite (beg, 1, lim - beg, stdout); + if (line_buffered) + fflush (stdout); + if (ferror (stdout)) { write_error_seen = true; @@ -1187,9 +1190,6 @@ prline (char *beg, char *lim, char sep) } lastout = lim; - - if (line_buffered) - fflush (stdout); } /* Print pending lines of trailing context prior to LIM. Trailing context ends -- 2.5.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 31 03:55:23 2015 Received: (at control) by debbugs.gnu.org; 31 Dec 2015 08:55:23 +0000 Received: from localhost ([127.0.0.1]:50938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aEZ11-0005OJ-J5 for submit@debbugs.gnu.org; Thu, 31 Dec 2015 03:55:23 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41868) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aEZ0z-0005O1-Ht for control@debbugs.gnu.org; Thu, 31 Dec 2015 03:55:21 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2C836160ED6 for ; Thu, 31 Dec 2015 00:55:16 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Dsi6TvFEL1b3 for ; Thu, 31 Dec 2015 00:55:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4FFD0160ED7 for ; Thu, 31 Dec 2015 00:55:15 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EnJ9ehm4awCT for ; Thu, 31 Dec 2015 00:55:15 -0800 (PST) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3587F160ED6 for ; Thu, 31 Dec 2015 00:55:15 -0800 (PST) To: control@debbugs.gnu.org From: Paul Eggert Subject: grep bug maintenance Organization: UCLA Computer Science Department Message-ID: <5684ED73.6060403@cs.ucla.edu> Date: Thu, 31 Dec 2015 00:55:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) severity 22059 wishlist severity 21865 wishlist close 22278 close 22279 close 21755 close 21700 tags 21554 wontfix tags 21527 moreinfo From unknown Sun Jun 22 22:43:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 28 Jan 2016 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator