GNU bug report logs - #22257
25.0.50; bidi-paragraph-direction is sticky in eww (patch)

Previous Next

Package: emacs;

Reported by: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>

Date: Mon, 28 Dec 2015 16:40:02 UTC

Severity: normal

Found in version 25.0.50

Fixed in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
Cc: 22257 <at> debbugs.gnu.org
Subject: bug#22257: 25.0.50; bidi-paragraph-direction is sticky in eww (patch)
Date: Mon, 28 Dec 2015 18:13:05 +0100

Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net> writes:

> When I have visited a page in eww that contains Hebrew text and than
> switch to a non-Hebrew page, bidi-paragraph-direction is still set RTL.
> A simple fix is attached.  The bug will still happen if the LTR page
> does not have an <html> element at all, but we may not care.

I think we do care.  :-)

Does the following fix the problem?  (Included in the Emacs 25 branch in
a jiffy...)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 5755a94..d455577 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -401,6 +401,7 @@ eww-display-html
 	(source (and (null document)
 		     (buffer-substring (point) (point-max)))))
     (with-current-buffer buffer
+      (setq bidi-paragraph-direction 'left-to-right)
       (plist-put eww-data :source source)
       (plist-put eww-data :dom document)
       (let ((inhibit-read-only t)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 9 years and 231 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.