From unknown Thu Sep 11 06:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22257: 25.0.50; bidi-paragraph-direction is sticky in eww (patch) Resent-From: Benjamin Riefenstahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22257@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145132075210790 (code B ref -1); Mon, 28 Dec 2015 16:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Dec 2015 16:39:12 +0000 Received: from localhost ([127.0.0.1]:46594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDapD-0002ny-Ob for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36015) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDapC-0002nm-MN for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDap6-0002EZ-Ep for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDap6-0002EV-B1 for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDap5-0007ZA-7t for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:39:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDap2-0002D6-0L for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:39:03 -0500 Received: from odoacer.turtle-trading.net ([217.91.34.180]:55541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDap1-0002D0-OR for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:38:59 -0500 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1aDap0-0001df-KL; Mon, 28 Dec 2015 17:38:58 +0100 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84) (envelope-from ) id 1aDap0-0001EP-Gz; Mon, 28 Dec 2015 17:38:58 +0100 From: Benjamin Riefenstahl Date: Mon, 28 Dec 2015 17:38:58 +0100 Message-ID: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain When I have visited a page in eww that contains Hebrew text and than switch to a non-Hebrew page, bidi-paragraph-direction is still set RTL. A simple fix is attached. The bug will still happen if the LTR page does not have an element at all, but we may not care. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=bidi-sticky.patch diff --git a/lisp/net/shr.el b/lisp/net/shr.el index c28e0b8..47f7f9c 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1103,12 +1103,9 @@ shr-previous-newline-padding-width ;;; Tag-specific rendering rules. (defun shr-tag-html (dom) - (let ((dir (dom-attr dom 'dir))) - (cond - ((equal dir "ltr") - (setq bidi-paragraph-direction 'left-to-right)) - ((equal dir "rtl") - (setq bidi-paragraph-direction 'right-to-left)))) + (if (equal dir(dom-attr dom 'dir) "rtl") + (setq bidi-paragraph-direction 'right-to-left) + (setq bidi-paragraph-direction 'left-to-right)) (shr-generic dom)) (defun shr-tag-body (dom) --=-=-= Content-Type: text/plain In GNU Emacs 25.0.50.8 (i686-pc-linux-gnu, GTK+ Version 2.24.25) of 2015-12-28 built on justinian Repository revision: f9d87dd8791d4e77929f21e4f73d92ef966722cc Windowing system distributor 'The X.Org Foundation', version 11.0.11604000 System Description: Debian GNU/Linux 8.2 (jessie) Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix --=-=-=-- From unknown Thu Sep 11 06:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22257: 25.0.50; bidi-paragraph-direction is sticky in eww (patch) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benjamin Riefenstahl Cc: 22257@debbugs.gnu.org Received: via spool by 22257-submit@debbugs.gnu.org id=B22257.145132281020217 (code B ref 22257); Mon, 28 Dec 2015 17:14:01 +0000 Received: (at 22257) by debbugs.gnu.org; 28 Dec 2015 17:13:30 +0000 Received: from localhost ([127.0.0.1]:46619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDbMQ-0005G1-0C for submit@debbugs.gnu.org; Mon, 28 Dec 2015 12:13:30 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:39814) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDbMO-0005Ft-Dq for 22257@debbugs.gnu.org; Mon, 28 Dec 2015 12:13:28 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDbM2-0002rG-4f; Mon, 28 Dec 2015 18:13:06 +0100 From: Lars Ingebrigtsen References: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> Date: Mon, 28 Dec 2015 18:13:05 +0100 In-Reply-To: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> (Benjamin Riefenstahl's message of "Mon, 28 Dec 2015 17:38:58 +0100") Message-ID: <87r3i6v6n2.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDbM2-0002rG-4f X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451927587.18981@Elf5EDxkEvnH5I17aPuMUQ X-Spam-Status: No X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Benjamin Riefenstahl writes: > When I have visited a page in eww that contains Hebrew text and than > switch to a non-Hebrew page, bidi-paragraph-direction is still set RTL. > A simple fix is attached. The bug will still happen if the LTR page > does not have an element at all, but we may not care. I think we do care. :-) Does the following fix the problem? (Included in the Emacs 25 branch in a jiffy...) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 5755a94..d455577 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -401,6 +401,7 @@ eww-display-html (source (and (null document) (buffer-substring (point) (point-max))))) (with-current-buffer buffer + (setq bidi-paragraph-direction 'left-to-right) (plist-put eww-data :source source) (plist-put eww-data :dom document) (let ((inhibit-read-only t) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Sep 11 06:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22257: 25.0.50; bidi-paragraph-direction is sticky in eww (patch) Resent-From: Benjamin Riefenstahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 22257@debbugs.gnu.org Received: via spool by 22257-submit@debbugs.gnu.org id=B22257.145132712526954 (code B ref 22257); Mon, 28 Dec 2015 18:26:02 +0000 Received: (at 22257) by debbugs.gnu.org; 28 Dec 2015 18:25:25 +0000 Received: from localhost ([127.0.0.1]:46670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDcU1-00070f-8X for submit@debbugs.gnu.org; Mon, 28 Dec 2015 13:25:25 -0500 Received: from odoacer.turtle-trading.net ([217.91.34.180]:48804) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDcTz-00070Q-Q9 for 22257@debbugs.gnu.org; Mon, 28 Dec 2015 13:25:24 -0500 Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1aDcTu-0001iZ-3L; Mon, 28 Dec 2015 19:25:18 +0100 Received: from benny by justinian.turtle-trading.net with local (Exim 4.84) (envelope-from ) id 1aDcTu-0001WL-0I; Mon, 28 Dec 2015 19:25:18 +0100 From: Benjamin Riefenstahl References: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> <87r3i6v6n2.fsf@gnus.org> Date: Mon, 28 Dec 2015 19:25:17 +0100 In-Reply-To: <87r3i6v6n2.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Dec 2015 18:13:05 +0100") Message-ID: <87fuymig6q.fsf@justinian.turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Lars Ingebrigtsen writes: > Does the following fix the problem? (Included in the Emacs 25 branch in > a jiffy...) Sure, that does it, too. I guess the setq for bidi-paragraph-direction in eww-mode is redundant than. From unknown Thu Sep 11 06:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22257: 25.0.50; bidi-paragraph-direction is sticky in eww (patch) Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benjamin Riefenstahl Cc: 22257@debbugs.gnu.org Received: via spool by 22257-submit@debbugs.gnu.org id=B22257.145133300410154 (code B ref 22257); Mon, 28 Dec 2015 20:04:02 +0000 Received: (at 22257) by debbugs.gnu.org; 28 Dec 2015 20:03:24 +0000 Received: from localhost ([127.0.0.1]:46763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDe0q-0002di-2L for submit@debbugs.gnu.org; Mon, 28 Dec 2015 15:03:24 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:36700) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDe0o-0002dZ-Eb for 22257@debbugs.gnu.org; Mon, 28 Dec 2015 15:03:22 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDe0S-00050W-8A; Mon, 28 Dec 2015 21:03:00 +0100 From: Lars Ingebrigtsen References: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> <87r3i6v6n2.fsf@gnus.org> <87fuymig6q.fsf@justinian.turtle-trading.net> Date: Mon, 28 Dec 2015 21:02:59 +0100 In-Reply-To: <87fuymig6q.fsf@justinian.turtle-trading.net> (Benjamin Riefenstahl's message of "Mon, 28 Dec 2015 19:25:17 +0100") Message-ID: <87y4ces5n0.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aDe0S-00050W-8A X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451937780.45683@ifcd5dx4JHFQAQrkTOqGGA X-Spam-Status: No X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Benjamin Riefenstahl writes: > Lars Ingebrigtsen writes: >> Does the following fix the problem? (Included in the Emacs 25 branch in >> a jiffy...) > > Sure, that does it, too. I guess the setq for bidi-paragraph-direction > in eww-mode is redundant than. Yup. Removed now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 28 15:03:34 2015 Received: (at control) by debbugs.gnu.org; 28 Dec 2015 20:03:34 +0000 Received: from localhost ([127.0.0.1]:46766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDe10-0002e8-9P for submit@debbugs.gnu.org; Mon, 28 Dec 2015 15:03:34 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:36706) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDe0y-0002e0-Ir for control@debbugs.gnu.org; Mon, 28 Dec 2015 15:03:32 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDe0b-00050g-VL for control@debbugs.gnu.org; Mon, 28 Dec 2015 21:03:10 +0100 Date: Mon, 28 Dec 2015 21:03:09 +0100 Message-Id: <87wprys5mq.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22257 X-MailScanner-ID: 1aDe0b-00050g-VL X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451937790.71754@Q033b9z9gLvY3xHqShBFSw X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 22257 25.1