GNU bug report logs - #22241
25.0.50; etags Ruby parser problems

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Sat, 26 Dec 2015 04:00:02 UTC

Severity: normal

Found in version 25.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 22241 <at> debbugs.gnu.org
Subject: bug#22241: 25.0.50; etags Ruby parser problems
Date: Thu, 04 Feb 2016 05:43:40 +0200
> Cc: 22241 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Thu, 4 Feb 2016 02:21:53 +0300
> 
> One nitpick:
> 
> attr_WHATEVER :foo, bar
> 
> will generate the methods for 'foo', and whatever the value of bar is. 
> But bar is not very likely to have the value :bar, so we should only 
> generate the tags for 'foo'.
> 
> IOW, skip the arguments that are not Ruby Symbols (don't start with a 
> colon). The current implementation treats them the same.

Yes, because etags is not supposed to do sensible things with
syntactically incorrect programs.

I'm not sure I understand the rules, though: is the "no colon, don't
tag" rule valid for any symbol following the attr_WHATEVER, or is that
applicable only to the 2nd, 3rd, etc. symbols?  IOW, what, if
anything, should be tagged here:

  attr_reader foo




This bug report was last modified 9 years and 162 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.