GNU bug report logs - #22181
endless loop in grep 2.22

Previous Next

Full log

Message #46 received at 22181 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Christian Boltz <grep-bug <at> cboltz.de>, 22181 <at> debbugs.gnu.org,
 Seth Arnold <seth.arnold <at> canonical.com>
Subject: Re: bug#22181: endless loop in grep 2.22
Date: Sat, 9 Jan 2016 11:33:56 -0800

On Sat, Jan 9, 2016 at 11:27 AM, Jim Meyering <jim <at> meyering.net> wrote:
> On Sat, Jan 9, 2016 at 10:20 AM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
>> Jim Meyering wrote:
>>>
>>> Hah! TIL head -N and yes are not portable. Thank you.
>>> I've been spoiled/corrupted by writing coreutils tests for so long.
>>>
>>> I would prefer to continue to use "yes" via the following, at least
>>> in the first test. That way is clearer. In the second, I could go either
>>> way, since your awk process replaces both yes and head, at the
>>> expense of being a bit less concise and less readable.
>>
>>
>> I could go either way too.
>>
>> Though it's not needed for these particular tests, the shell function can be
>> tweaked to default to 'y' and to output quotes and backlashes in the arg
>> as-is, like BSD 'yes'.  Something like this, perhaps?
>>
>> yes() { line=${*-y} ${AWK-awk} 'BEGIN{for (;;) print ENVIRON["line"]}'; }
>
> Indeed, I thought of quotes and backslashes a little too late.
> Nice hack. I will use that, probably with an added "local ",
> since init.sh ensures that the test-run shell supports that.
> Hmm... I see that gnulib's init.sh has a stray (new) use
> of local. Will remove.

I will *not* be adding a "local " prefix. Not required. That "line" is
an envvar, so just fine as-is.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.