GNU bug report logs - #2217
[PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring

Previous Next

Package: emacs;

Reported by: Jari Aalto <jari.aalto <at> cante.net>

Date: Fri, 6 Feb 2009 04:10:04 UTC

Severity: minor

Tags: patch

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2217 in the body.
You can then email your comments to 2217 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#2217; Package emacs. (Fri, 06 Feb 2009 04:10:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jari Aalto <jari.aalto <at> cante.net>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Fri, 06 Feb 2009 04:10:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: Emacs bug BTS <submit <at> debbugs.gnu.org>
Subject: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring
Date: Fri, 06 Feb 2009 06:02:24 +0200
Tags: patch

2009-02-06  Jari Aalto  <jari.aalto <at> cante.net>

       * add-log.el: Improve docstring by mentioning submatch 1.

From d936b3faf4372e5538bee950f2145870196e257c Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Fri, 6 Feb 2009 06:01:53 +0200
Subject: [PATCH] lisp/add-log.el: (add-log-current-defun-header-regexp): Improve docstring

Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/add-log.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/add-log.el b/lisp/add-log.el
index 00e3172..c43a548 100644
--- a/lisp/add-log.el
+++ b/lisp/add-log.el
@@ -1095,7 +1095,9 @@ Prefix arg means justify as well."
 
 (defcustom add-log-current-defun-header-regexp
   "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]"
-  "Heuristic regexp used by `add-log-current-defun' for unknown major modes."
+  "Heuristic regexp used by `add-log-current-defun' for unknown major modes.
+The regular expression's submatch 1 is used for the text in '(parenthesis)'."
+text in '(parentheses)'."
   :type 'regexp
   :group 'change-log)
 
-- 
1.5.6.5





Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#2217; Package emacs. (Fri, 06 Feb 2009 04:35:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jari Aalto <jari.aalto <at> cante.net>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Fri, 06 Feb 2009 04:35:03 GMT) Full text and rfc822 format available.

Message #10 received at 2217 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: 2217 <at> debbugs.gnu.org
Subject: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring
Date: Fri, 06 Feb 2009 06:28:05 +0200
severity: minor
thanks

The value is also case sensitive. Here is slightly improved patch.

2009-02-06  Jari Aalto  <jari.aalto <at> cante.net>

       * add-log.el: Improve docstring by mentioning submatch 1.

From 60a95c697ccc35abbfce6950f081100549b0b3fd Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Fri, 6 Feb 2009 06:25:04 +0200
Subject: [PATCH] lisp/add-log.el: (add-log-current-defun-header-regexp): Improve docstring

Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/add-log.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/add-log.el b/lisp/add-log.el
index 00e3172..c63e96d 100644
--- a/lisp/add-log.el
+++ b/lisp/add-log.el
@@ -1095,7 +1095,9 @@ Prefix arg means justify as well."
 
 (defcustom add-log-current-defun-header-regexp
   "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]"
-  "Heuristic regexp used by `add-log-current-defun' for unknown major modes."
+  "Heuristic regexp used by `add-log-current-defun' for unknown major modes.
+The regular expression's submatch 1 is used for the text in '(parenthesis)'.
+The value is case-sensitive."
   :type 'regexp
   :group 'change-log)
 
-- 
1.5.6.5





Severity set to `minor' from `normal' Request was from Jari Aalto <jari.aalto <at> cante.net> to control <at> emacsbugs.donarmstrong.com. (Fri, 06 Feb 2009 05:20:02 GMT) Full text and rfc822 format available.

Reply sent to Chong Yidong <cyd <at> stupidchicken.com>:
You have taken responsibility. (Mon, 06 Jul 2009 13:45:29 GMT) Full text and rfc822 format available.

Notification sent to Jari Aalto <jari.aalto <at> cante.net>:
bug acknowledged by developer. (Mon, 06 Jul 2009 13:45:29 GMT) Full text and rfc822 format available.

Message #17 received at 2217-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 2217-done <at> debbugs.gnu.org
Subject: Re: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring
Date: Sun, 05 Jul 2009 00:54:21 -0400
> * add-log.el: Improve docstring by mentioning submatch 1.

I checked in a slightly different fix.  Thanks for reporting the
problem.



bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> emacsbugs.donarmstrong.com. (Mon, 03 Aug 2009 14:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 16 years and 17 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.