GNU bug report logs - #22160
24.5; "M-x browse-url-emacs" on a 404 page

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#22160: closed (24.5; "M-x browse-url-emacs" on a 404 page)
Date: Sat, 19 Dec 2015 10:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 19 Dec 2015 12:01:43 +0200
with message-id <83vb7uvjso.fsf <at> gnu.org>
and subject line Re: bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page
has caused the debbugs.gnu.org bug report #22160,
regarding 24.5; "M-x browse-url-emacs" on a 404 page
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
22160: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22160
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Kost <alezost <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; "M-x browse-url-emacs" on a 404 page
Date: Sun, 13 Dec 2015 13:39:13 +0300

Hello, I've noticed an unhandled error when I tried the following:

1. emacs -Q
2. M-x browse-url-emacs RET http://hydra.gnu.org/build/12345

And the error is:

    find-file-noselect-1: Wrong type argument: arrayp, nil

As (file-truename buffer-file-name) fails when buffer-file-name is nil.

It would be good to have a more "friendly" error, like the one that
(url-insert-file-contents "http://hydra.gnu.org/build/12345") produces.

Thanks.

-- 
Alex

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alex Kost <alezost <at> gmail.com>
Cc: 22160-done <at> debbugs.gnu.org
Subject: Re: bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page
Date: Sat, 19 Dec 2015 12:01:43 +0200

> From: Alex Kost <alezost <at> gmail.com>
> Date: Sun, 13 Dec 2015 13:39:13 +0300
> 
> Hello, I've noticed an unhandled error when I tried the following:
> 
> 1. emacs -Q
> 2. M-x browse-url-emacs RET http://hydra.gnu.org/build/12345
> 
> And the error is:
> 
>     find-file-noselect-1: Wrong type argument: arrayp, nil
> 
> As (file-truename buffer-file-name) fails when buffer-file-name is nil.
> 
> It would be good to have a more "friendly" error, like the one that
> (url-insert-file-contents "http://hydra.gnu.org/build/12345") produces.

browse-url-emacs is not supposed to display error messages for URLs
that don't exist or cannot be accessed.  That function is a fancy way
of visiting a "file buffer" with the HTML source of the URL, so it
should react like "C-x C-f" when the file does not exist.  "C-x C-f"
says "New file" and shows an empty buffer; browse-url-emacs's
equivalent is IMO a buffer with the error returned by the server, in
this case the standard 404 response.

So this is what I did in commit bcf4913 on the emacs-25 branch.  The
previous code in url-insert-file-contents signaled an error when it
received one of the 4xx responses, disregarding the VISIT argument,
which was a mistake (introduced when we fixed bug#16733, where VISIT
is nil).  Now it follows more closely the behavior of
insert-file-contents in that case.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.