From unknown Sun Jun 22 00:53:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Dec 2015 10:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22160 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22160@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145000316019096 (code B ref -1); Sun, 13 Dec 2015 10:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Dec 2015 10:39:20 +0000 Received: from localhost ([127.0.0.1]:49893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a843k-0004xw-6Z for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54265) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a843i-0004xl-TM for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a843c-0005GG-Vw for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a843c-0005GC-TL for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a843b-0005r8-VO for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2015 05:39:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a843Y-0005Fo-No for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2015 05:39:11 -0500 Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:33930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a843Y-0005Fi-Fv for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2015 05:39:08 -0500 Received: by lbbcs9 with SMTP id cs9so91677115lbb.1 for ; Sun, 13 Dec 2015 02:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Y0hqM5+IBjS4HqZ1hgmLLwFepMUFzHkSowHWzN9GCj0=; b=sGsRjT4YqWHiqPB53RrF3qsvhgJ98ZwI2dt6pbE8m3CW4GYLD1N0mNd8tq/XNeRyHJ c6g+x5XYmTr/afF2BZUws82s6rXjkVsybv6V2Ga4olof4kgBD5tw9wClQ+dTxuAb8Sc5 UYmAd0G/l8tQmdIMGReIuo/Chw2/TOiV/pX04SZKpVZTEDRCHo9VUaiuPRUlkjndMAu7 h7aGXpmILUccVmujjBJWRBCFqelKTg8mqaRIE2ffXkYwkHiTTzmc6KpkBWBBdAeoGFmN tlPupH13y8YRKSlUUfgpGg9kW1zkCkq53b/IfXEIbrQ2JUSqN1gOHnGZr++0pvGqmzfe 2itw== X-Received: by 10.112.150.102 with SMTP id uh6mr10938106lbb.16.1450003147376; Sun, 13 Dec 2015 02:39:07 -0800 (PST) Received: from leviafan ([217.107.192.146]) by smtp.gmail.com with ESMTPSA id ak1sm4589350lbc.2.2015.12.13.02.39.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Dec 2015 02:39:06 -0800 (PST) From: Alex Kost Date: Sun, 13 Dec 2015 13:39:13 +0300 Message-ID: <871taqljji.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, I've noticed an unhandled error when I tried the following: 1. emacs -Q 2. M-x browse-url-emacs RET http://hydra.gnu.org/build/12345 And the error is: find-file-noselect-1: Wrong type argument: arrayp, nil As (file-truename buffer-file-name) fails when buffer-file-name is nil. It would be good to have a more "friendly" error, like the one that (url-insert-file-contents "http://hydra.gnu.org/build/12345") produces. Thanks. -- Alex From unknown Sun Jun 22 00:53:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alex Kost Subject: bug#22160: closed (Re: bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page) Message-ID: References: <83vb7uvjso.fsf@gnu.org> <871taqljji.fsf@gmail.com> X-Gnu-PR-Message: they-closed 22160 X-Gnu-PR-Package: emacs Reply-To: 22160@debbugs.gnu.org Date: Sat, 19 Dec 2015 10:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1450519322-16928-1" This is a multi-part message in MIME format... ------------=_1450519322-16928-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #22160: 24.5; "M-x browse-url-emacs" on a 404 page which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 22160@debbugs.gnu.org. --=20 22160: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22160 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1450519322-16928-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 22160-done) by debbugs.gnu.org; 19 Dec 2015 10:01:30 +0000 Received: from localhost ([127.0.0.1]:56244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aAEKQ-0004OK-0C for submit@debbugs.gnu.org; Sat, 19 Dec 2015 05:01:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40872) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aAEKO-0004O7-Rk for 22160-done@debbugs.gnu.org; Sat, 19 Dec 2015 05:01:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAEKG-0001Ed-Ch for 22160-done@debbugs.gnu.org; Sat, 19 Dec 2015 05:01:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAEKG-0001EV-99; Sat, 19 Dec 2015 05:01:20 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3398 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aAEKF-0002Hf-4c; Sat, 19 Dec 2015 05:01:19 -0500 Date: Sat, 19 Dec 2015 12:01:43 +0200 Message-Id: <83vb7uvjso.fsf@gnu.org> From: Eli Zaretskii To: Alex Kost In-reply-to: <871taqljji.fsf@gmail.com> (message from Alex Kost on Sun, 13 Dec 2015 13:39:13 +0300) Subject: Re: bug#22160: 24.5; "M-x browse-url-emacs" on a 404 page References: <871taqljji.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22160-done Cc: 22160-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alex Kost > Date: Sun, 13 Dec 2015 13:39:13 +0300 > > Hello, I've noticed an unhandled error when I tried the following: > > 1. emacs -Q > 2. M-x browse-url-emacs RET http://hydra.gnu.org/build/12345 > > And the error is: > > find-file-noselect-1: Wrong type argument: arrayp, nil > > As (file-truename buffer-file-name) fails when buffer-file-name is nil. > > It would be good to have a more "friendly" error, like the one that > (url-insert-file-contents "http://hydra.gnu.org/build/12345") produces. browse-url-emacs is not supposed to display error messages for URLs that don't exist or cannot be accessed. That function is a fancy way of visiting a "file buffer" with the HTML source of the URL, so it should react like "C-x C-f" when the file does not exist. "C-x C-f" says "New file" and shows an empty buffer; browse-url-emacs's equivalent is IMO a buffer with the error returned by the server, in this case the standard 404 response. So this is what I did in commit bcf4913 on the emacs-25 branch. The previous code in url-insert-file-contents signaled an error when it received one of the 4xx responses, disregarding the VISIT argument, which was a mistake (introduced when we fixed bug#16733, where VISIT is nil). Now it follows more closely the behavior of insert-file-contents in that case. Thanks. ------------=_1450519322-16928-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Dec 2015 10:39:20 +0000 Received: from localhost ([127.0.0.1]:49893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a843k-0004xw-6Z for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54265) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a843i-0004xl-TM for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a843c-0005GG-Vw for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a843c-0005GC-TL for submit@debbugs.gnu.org; Sun, 13 Dec 2015 05:39:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a843b-0005r8-VO for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2015 05:39:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a843Y-0005Fo-No for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2015 05:39:11 -0500 Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:33930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a843Y-0005Fi-Fv for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2015 05:39:08 -0500 Received: by lbbcs9 with SMTP id cs9so91677115lbb.1 for ; Sun, 13 Dec 2015 02:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Y0hqM5+IBjS4HqZ1hgmLLwFepMUFzHkSowHWzN9GCj0=; b=sGsRjT4YqWHiqPB53RrF3qsvhgJ98ZwI2dt6pbE8m3CW4GYLD1N0mNd8tq/XNeRyHJ c6g+x5XYmTr/afF2BZUws82s6rXjkVsybv6V2Ga4olof4kgBD5tw9wClQ+dTxuAb8Sc5 UYmAd0G/l8tQmdIMGReIuo/Chw2/TOiV/pX04SZKpVZTEDRCHo9VUaiuPRUlkjndMAu7 h7aGXpmILUccVmujjBJWRBCFqelKTg8mqaRIE2ffXkYwkHiTTzmc6KpkBWBBdAeoGFmN tlPupH13y8YRKSlUUfgpGg9kW1zkCkq53b/IfXEIbrQ2JUSqN1gOHnGZr++0pvGqmzfe 2itw== X-Received: by 10.112.150.102 with SMTP id uh6mr10938106lbb.16.1450003147376; Sun, 13 Dec 2015 02:39:07 -0800 (PST) Received: from leviafan ([217.107.192.146]) by smtp.gmail.com with ESMTPSA id ak1sm4589350lbc.2.2015.12.13.02.39.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Dec 2015 02:39:06 -0800 (PST) From: Alex Kost To: bug-gnu-emacs@gnu.org Subject: 24.5; "M-x browse-url-emacs" on a 404 page Date: Sun, 13 Dec 2015 13:39:13 +0300 Message-ID: <871taqljji.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, I've noticed an unhandled error when I tried the following: 1. emacs -Q 2. M-x browse-url-emacs RET http://hydra.gnu.org/build/12345 And the error is: find-file-noselect-1: Wrong type argument: arrayp, nil As (file-truename buffer-file-name) fails when buffer-file-name is nil. It would be good to have a more "friendly" error, like the one that (url-insert-file-contents "http://hydra.gnu.org/build/12345") produces. Thanks. -- Alex ------------=_1450519322-16928-1--