GNU bug report logs - #22114
24.5; [PATCH] Allow profiler.el to display reports after stopping

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 22114 <at> debbugs.gnu.org, v.schneidermann <at> gmail.com
Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping
Date: Thu, 27 Jun 2019 17:09:02 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Vasilij Schneidermann <v.schneidermann <at> gmail.com>,  22114 <at> debbugs.gnu.org
> Date: Tue, 25 Jun 2019 16:46:47 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I don't really understand why profiler.el insists on having the
> > profiler running for providing the profile.  The much simpler patch
> > below makes it possible for me to invoke profiler-report whether a
> > profile is running or not.  Does it work for you?  If not, can you
> > tell what I missed?
> >
> > --- lisp/profiler.el~4	2015-11-11 07:57:32.000000000 +0200
> > +++ lisp/profiler.el	2015-12-08 17:54:27.380084700 +0200
> > @@ -216,19 +216,17 @@
> >
> >  (defun profiler-cpu-profile ()
> >    "Return CPU profile."
> > -  (when (profiler-running-p 'cpu)
> > -    (profiler-make-profile
> > -     :type 'cpu
> > -     :timestamp (current-time)
> > -     :log (profiler-cpu-log))))
> > +  (profiler-make-profile
> > +   :type 'cpu
> > +   :timestamp (current-time)
> > +   :log (profiler-cpu-log)))
> 
> [etc]
> 
> The discussion then turned to other things (like getting in-progress
> reports), but this seems like the simplest solution that solves the
> originally stated problem.  But it wasn't applied -- I can do that now,
> if that's convenient...

I think Stefan endorsed the last patch posted there, so maybe that's
what should be pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.