GNU bug report logs - #2211
server-socket-dir and make-temp-file

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2211 in the body.
You can then email your comments to 2211 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Roland Winkler" <Roland.Winkler <at> physik.uni-erlangen.de>
To: bug-gnu-emacs <at> gnu.org
Subject: server-socket-dir and make-temp-file
Date: Thu, 05 Feb 2009 18:28:19 +0100

server-socket-dir is by default a directory in /tmp. With CVS emacs
it also takes the TMPDIR environment variable into account.
Shouldn't this variable be initialized using make-temp-file so that
it obeys any customization of temporary-file-directory?

Actually, I ran the following command in the emacs directory
$ grep "\"/tmp\"" lisp/*el lisp/*/*el
Browsing through the matches, it seems to me that
pmail-mime-attachment-dirs-alist and url-temporary-directory
should be updated, too.

A related issue: I do not quite understand a piece of code like

  (make-temp-file
   (concat (file-name-as-directory
            (or (getenv "TMPDIR") "/tmp"))
            "artist-stdin."))

used in the function artist-system. If the PREFIX arg of
make-temp-file is an absolute directory as in the example above,
make-temp-file will ignore any user customization of
temporary-file-directory. The function ps-run-make-tmp-filename
behaves similarly.


In GNU Emacs 22.2.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2008-03-27 on tfkp07

Message #10 received at 2211 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Roland Winkler <Roland.Winkler <at> physik.uni-erlangen.de>
Cc: 2211 <at> debbugs.gnu.org
Subject: Re: bug#2211: server-socket-dir and make-temp-file
Date: Thu, 05 Feb 2009 14:51:02 -0500

> server-socket-dir is by default a directory in /tmp. With CVS emacs
> it also takes the TMPDIR environment variable into account.
> Shouldn't this variable be initialized using make-temp-file so that
> it obeys any customization of temporary-file-directory?

No, because emacsclient needs to access server-socket-dir but doesn't
read the .emacs so can't adapt to changes in temporary-file-directory
(it does pay attention to $TMPDIR, on the other hand).

> Actually, I ran the following command in the emacs directory
> $ grep "\"/tmp\"" lisp/*el lisp/*/*el
> Browsing through the matches, it seems to me that
> pmail-mime-attachment-dirs-alist and url-temporary-directory
> should be updated, too.

You're probably right on these ones.

> A related issue: I do not quite understand a piece of code like

>   (make-temp-file
>    (concat (file-name-as-directory
>             (or (getenv "TMPDIR") "/tmp"))
>             "artist-stdin."))

> used in the function artist-system. If the PREFIX arg of
> make-temp-file is an absolute directory as in the example above,
> make-temp-file will ignore any user customization of
> temporary-file-directory. The function ps-run-make-tmp-filename
> behaves similarly.

At first, I was going to say that

     (concat (file-name-as-directory
              (or (getenv "TMPDIR") "/tmp"))
             "artist-stdin.")

should be replaced by

     (expand-file-name "artist-stdin." (or (getenv "TMPDIR") "/tmp"))

but indeed, it's better to just skip it all and let `make-temp-file' use
temporary-file-directory.


        Stefan

Message #15 received at 2211 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Roland Winkler" <Roland.Winkler <at> physik.uni-erlangen.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 2211 <at> debbugs.gnu.org
Subject: Re: bug#2211: server-socket-dir and make-temp-file
Date: Sat, 7 Feb 2009 17:32:59 +0100

On Thu Feb 5 2009 Stefan Monnier wrote:
> > server-socket-dir is by default a directory in /tmp. With CVS emacs
> > it also takes the TMPDIR environment variable into account.
> > Shouldn't this variable be initialized using make-temp-file so that
> > it obeys any customization of temporary-file-directory?
> 
> No, because emacsclient needs to access server-socket-dir but doesn't
> read the .emacs so can't adapt to changes in temporary-file-directory
> (it does pay attention to $TMPDIR, on the other hand).

Thanks, I see. The lisp code defining server-socket-dir for emacs
matches a corresponding piece of C code in emacsclient.c

> > Actually, I ran the following command in the emacs directory
> > $ grep "\"/tmp\"" lisp/*el lisp/*/*el
> > Browsing through the matches, it seems to me that
> > pmail-mime-attachment-dirs-alist and url-temporary-directory
> > should be updated, too.
> 
> You're probably right on these ones.

I could update those. Yet I just realized that emacs 23 is already
in pretest. Is this the kind of thing that should be changed
nonethless or should I better wait?

> At first, I was going to say that
> 
>      (concat (file-name-as-directory
>               (or (getenv "TMPDIR") "/tmp"))
>              "artist-stdin.")
> 
> should be replaced by
> 
>      (expand-file-name "artist-stdin." (or (getenv "TMPDIR") "/tmp"))
> 
> but indeed, it's better to just skip it all and let `make-temp-file' use
> temporary-file-directory.

Same for these changes: better do them now or wait?

Thanks,

Roland

Message #20 received at 2211 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Roland Winkler" <Roland.Winkler <at> physik.uni-erlangen.de>
Cc: 2211 <at> debbugs.gnu.org
Subject: Re: bug#2211: server-socket-dir and make-temp-file
Date: Sat, 07 Feb 2009 16:15:42 -0500

> Thanks, I see.  The lisp code defining server-socket-dir for Emacs
> matches a corresponding piece of C code in emacsclient.c

It deserves a comment (in both places), indeed.

>> You're probably right on these ones.
> I could update those. Yet I just realized that emacs 23 is already
> in pretest. Is this the kind of thing that should be changed
> nonethless or should I better wait?

I'd rather postpone those things to 23.2.


        Stefan

Message #25 received at 2211-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Roland Winkler" <Roland.Winkler <at> physik.uni-erlangen.de>
Cc: 2211-done <at> debbugs.gnu.org
Subject: Re: bug#2211: server-socket-dir and make-temp-file
Date: Sat, 07 Feb 2009 16:58:46 -0500

> I could update those. Yet I just realized that emacs 23 is already in
> pretest. Is this the kind of thing that should be changed nonethless
> or should I better wait?

I think it's better to fix these now.  I've just done that.  Thanks for
finding the problem.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.