GNU bug report logs - #22107
this-command-keys no longer returns prefix argument

Previous Next

Package: emacs;

Reported by: bruce.connor.am <at> gmail.com

Date: Mon, 7 Dec 2015 15:43:02 UTC

Severity: normal

Tags: fixed

Merged with 22111

Found in versions 25.0.50, 25.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #142 received at 22107 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 22107 <at> debbugs.gnu.org
Subject: Re: this-command-keys no longer returns prefix argument
Date: Fri, 13 May 2016 11:52:41 +0000
[Message part 1 (text/plain, inline)]
On Wed, May 11, 2016, 10:22 AM Stefan MonnierOnonnier <at> iro.umontreal.ca>
wrote:

> You mean, are this-command-keys-vector and this-single-command-keys
> 100% equivalent all the time?  I wish I was able to give you an answer.
> They appear to be
>

At this point it is a documentation bug. this-command-keys and
this-single-command-keys are equivalent. But the documentaion still says
that this-single-command-keys does not return prefix argument unlike
this-command-keys. In fact, none of them return the prefix arg.

So

(1) The docstring of this-single-command-keys needs to be fixed.
(2) NEWS also needs to mention that this-command-keys no longer returns
prefix arg.

Going forward (not for this bug or emacs-25): If someone can review
that this-command-keys-vector and this-single-command-keys are ACTUALLY the
same, can then this-single-command-keys be marked obsolete and an alias to
the other for the next release? If that seems like the next action, I can
file a separate bug report for that.

> --

-- 
Kaushal Modi
[Message part 2 (text/html, inline)]

This bug report was last modified 4 years and 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.