From unknown Fri Jun 13 10:57:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22099: Path to fix bug in function erc-kill-query-buffers Resent-From: Francis Litterio Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2015 01:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22099 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 22099@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144936447313305 (code B ref -1); Sun, 06 Dec 2015 01:15:03 +0000 Received: (at submit) by debbugs.gnu.org; 6 Dec 2015 01:14:33 +0000 Received: from localhost ([127.0.0.1]:40190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5NuK-0003SW-Su for submit@debbugs.gnu.org; Sat, 05 Dec 2015 20:14:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39546) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5Nu0-0003S2-IL for submit@debbugs.gnu.org; Sat, 05 Dec 2015 20:14:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5Ntz-0004d6-EL for submit@debbugs.gnu.org; Sat, 05 Dec 2015 20:14:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Ntz-0004cy-BG for submit@debbugs.gnu.org; Sat, 05 Dec 2015 20:14:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Nty-0005yo-Fc for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 20:14:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5Ntv-0004br-7y for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 20:14:10 -0500 Received: from plane.gmane.org ([80.91.229.3]:53672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Ntv-0004bm-10 for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 20:14:07 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1a5Ntq-0006K1-7V for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2015 02:14:02 +0100 Received: from 176.sub-70-192-37.myvzw.com ([70.192.37.176]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 06 Dec 2015 02:14:02 +0100 Received: from flitterio by 176.sub-70-192-37.myvzw.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 06 Dec 2015 02:14:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ From: Francis Litterio Date: Sun, 6 Dec 2015 01:13:57 +0000 (UTC) Lines: 37 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 70.192.37.176 (Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) In the latest Emacs sources (Git branch "master"), function erc-kill-query-buffers fails to protect against being passed nil for argument PROCESS, which causes all channel buffers on all servers to be deleted! This can happen if command /QUIT is issued in a disconnected server buffer and variable erc-kill-queries-on-quit is non-nil. This patch fixes this problem. -- Fran flitterio gmail.com --- erc.el~ 2015-08-09 16:04:46.097043200 -0400 +++ erc.el 2015-08-09 16:07:19.082925200 -0400 @@ -6071,13 +6071,14 @@ (or (file-accessible-directory-p dir) (error "Cannot access %s" dir))) (defun erc-kill-query-buffers (process) - "Kill all buffers of PROCESS." + "Kill all buffers of PROCESS. Does nothing if PROCESS is not a process object." ;; here, we only want to match the channel buffers, to avoid ;; "selecting killed buffers" b0rkage. - (erc-with-all-buffers-of-server process - (lambda () - (not (erc-server-buffer-p))) - (kill-buffer (current-buffer)))) + (if (processp process) + (erc-with-all-buffers-of-server process + (lambda () + (not (erc-server-buffer-p))) + (kill-buffer (current-buffer)))) (defun erc-nick-at-point () "Give information about the nickname at `point'. From unknown Fri Jun 13 10:57:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22099: Path to fix bug in function erc-kill-query-buffers Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 07:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22099 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Francis Litterio Cc: 22099@debbugs.gnu.org Received: via spool by 22099-submit@debbugs.gnu.org id=B22099.145120225312117 (code B ref 22099); Sun, 27 Dec 2015 07:45:01 +0000 Received: (at 22099) by debbugs.gnu.org; 27 Dec 2015 07:44:13 +0000 Received: from localhost ([127.0.0.1]:42360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD5zx-00039N-3M for submit@debbugs.gnu.org; Sun, 27 Dec 2015 02:44:13 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:45267) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD5zt-00039D-VL for 22099@debbugs.gnu.org; Sun, 27 Dec 2015 02:44:11 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aD5zY-0003Yc-BL; Sun, 27 Dec 2015 08:43:48 +0100 From: Lars Ingebrigtsen References: Date: Sun, 27 Dec 2015 08:43:47 +0100 In-Reply-To: (Francis Litterio's message of "Sun, 6 Dec 2015 01:13:57 +0000 (UTC)") Message-ID: <87oadcibf0.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aD5zY-0003Yc-BL X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451807028.83777@qc6bc12bQOl2Me9WRtDysw X-Spam-Status: No X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Francis Litterio writes: > In the latest Emacs sources (Git branch "master"), function > erc-kill-query-buffers fails to protect against being passed nil > for argument PROCESS, which causes all channel buffers on all > servers to be deleted! This can happen if command /QUIT is issued > in a disconnected server buffer and variable erc-kill-queries-on-quit > is non-nil. > > This patch fixes this problem. Thanks; but the patch seems malformed (probably during transmission). Can you attach it instead? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 00:56:37 2016 Received: (at control) by debbugs.gnu.org; 4 Feb 2016 05:56:37 +0000 Received: from localhost ([127.0.0.1]:58778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCuC-0003iA-PK for submit@debbugs.gnu.org; Thu, 04 Feb 2016 00:56:36 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:41008) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCuA-0003i2-Lj for control@debbugs.gnu.org; Thu, 04 Feb 2016 00:56:35 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRCtg-0008JM-3F for control@debbugs.gnu.org; Thu, 04 Feb 2016 06:56:04 +0100 Date: Thu, 04 Feb 2016 16:56:00 +1100 Message-Id: <87fux910jz.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22099 X-MailScanner-ID: 1aRCtg-0008JM-3F X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455170169.79557@ZW5JLqwsc3MIUWDke8a5EA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 22099 fixed close 22099 25.1 From unknown Fri Jun 13 10:57:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22099: Path to fix bug in function erc-kill-query-buffers Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2016 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22099 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Francis Litterio Cc: 22099@debbugs.gnu.org Received: via spool by 22099-submit@debbugs.gnu.org id=B22099.145456569420125 (code B ref 22099); Thu, 04 Feb 2016 06:02:02 +0000 Received: (at 22099) by debbugs.gnu.org; 4 Feb 2016 06:01:34 +0000 Received: from localhost ([127.0.0.1]:58784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCz0-0005EH-BT for submit@debbugs.gnu.org; Thu, 04 Feb 2016 01:01:34 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:46846) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aRCyy-0005CI-Il for 22099@debbugs.gnu.org; Thu, 04 Feb 2016 01:01:32 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aRCtY-0008Is-CA; Thu, 04 Feb 2016 06:55:57 +0100 From: Lars Ingebrigtsen References: Date: Thu, 04 Feb 2016 16:55:52 +1100 In-Reply-To: (Francis Litterio's message of "Sun, 6 Dec 2015 01:13:57 +0000 (UTC)") Message-ID: <87h9hp10k7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aRCtY-0008Is-CA X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1455170469.07075@5mWBGPiTnpPHIp4j0XsCjw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Francis Litterio writes: > In the latest Emacs sources (Git branch "master"), function > erc-kill-query-buffers fails to protect against being passed nil > for argument PROCESS, which causes all channel buffers on all > servers to be deleted! This can happen if command /QUIT is issued > in a disconnected server buffer and variable erc-kill-queries-on-quit > is non-nil. > > This patch fixes this problem. Thanks; applied to emacs-25. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no