From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 16:37:15 2015 Received: (at submit) by debbugs.gnu.org; 2 Dec 2015 21:37:15 +0000 Received: from localhost ([127.0.0.1]:36625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4F5O-0001aT-DG for submit@debbugs.gnu.org; Wed, 02 Dec 2015 16:37:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45088) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4F54-0001Zk-F6 for submit@debbugs.gnu.org; Wed, 02 Dec 2015 16:37:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4F53-0004I6-7X for submit@debbugs.gnu.org; Wed, 02 Dec 2015 16:36:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4F53-0004I2-4K for submit@debbugs.gnu.org; Wed, 02 Dec 2015 16:36:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4F52-0000Dc-1s for bug-auctex@gnu.org; Wed, 02 Dec 2015 16:36:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4F4y-0004FV-R5 for bug-auctex@gnu.org; Wed, 02 Dec 2015 16:36:51 -0500 Received: from plane.gmane.org ([80.91.229.3]:47336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4F4y-0004FG-KK for bug-auctex@gnu.org; Wed, 02 Dec 2015 16:36:48 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1a4F4w-0003EB-1p for bug-auctex@gnu.org; Wed, 02 Dec 2015 22:36:46 +0100 Received: from hsi-kbw-37-49-5-178.hsi14.kabel-badenwuerttemberg.de ([37.49.5.178]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Dec 2015 22:36:46 +0100 Received: from esbati by hsi-kbw-37-49-5-178.hsi14.kabel-badenwuerttemberg.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Dec 2015 22:36:46 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-auctex@gnu.org To: bug-auctex@gnu.org From: Arash Esbati Subject: Possible bug in `reftex-what-index-tag' Date: Wed, 02 Dec 2015 22:33:53 +0100 Lines: 73 Message-ID: Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: hsi-kbw-37-49-5-178.hsi14.kabel-badenwuerttemberg.de Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hi all, please consider the following example: --8<---------------cut here---------------start------------->8--- \documentclass{article} \usepackage{index} \newindex{aut}{adx}{and}{Name Index} \begin{document} `C-c C-m index RET aut RET' enters `\index[aut]' in buffer and exits with `(wrong-type-argument integer-or-marker-p nil)'. \end{document} --8<---------------cut here---------------end--------------->8--- Debugger says: --8<---------------cut here---------------start------------->8--- Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil) reftex-what-index-tag() TeX-arg-index(nil) TeX-parse-argument(nil TeX-arg-index) TeX-parse-arguments(([TeX-arg-index-tag] TeX-arg-index)) TeX-parse-macro("index" ([TeX-arg-index-tag] TeX-arg-index)) TeX-insert-macro("index") call-interactively(TeX-insert-macro nil nil) command-execute(TeX-insert-macro) --8<---------------cut here---------------end--------------->8--- If I get this correctly, the problem is in `(match-end 1)' part of `reftex-what-index-tag' defined in `reftex-auc.el': --8<---------------cut here---------------start------------->8--- (defun reftex-what-index-tag () ;; Look backward to find out what index the macro at point belongs to (let ((macro (save-excursion (and (re-search-backward "\\\\[a-zA-Z*]+" nil t) (match-string 0)))) tag entry) (when (and macro (setq entry (assoc macro reftex-index-macro-alist))) (setq tag (nth 1 entry)) (cond ((stringp tag) tag) ((integerp tag) (save-excursion (goto-char (match-end 1)) (or (reftex-nth-arg tag (nth 6 entry)) "idx"))) (t "idx"))))) --8<---------------cut here---------------end--------------->8--- I think it should be `(match-end 0)' since the last search had no parenthesized expression in regexp. In short: --8<---------------cut here---------------start------------->8--- diff --git a/lisp/textmodes/reftex-auc.el b/lisp/textmodes/reftex-auc.el index bbad065..151be59 100644 --- a/lisp/textmodes/reftex-auc.el +++ b/lisp/textmodes/reftex-auc.el @@ -137,7 +137,7 @@ reftex-what-index-tag ((stringp tag) tag) ((integerp tag) (save-excursion - (goto-char (match-end 1)) + (goto-char (match-end 0)) (or (reftex-nth-arg tag (nth 6 entry)) "idx"))) (t "idx"))))) --8<---------------cut here---------------end--------------->8--- Any comments? I could make a proper patch for this. Best, Arash From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 17:49:14 2015 Received: (at submit) by debbugs.gnu.org; 2 Dec 2015 22:49:14 +0000 Received: from localhost ([127.0.0.1]:36646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4GD3-0003IW-Hu for submit@debbugs.gnu.org; Wed, 02 Dec 2015 17:49:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60981) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4GCj-0003He-9v for submit@debbugs.gnu.org; Wed, 02 Dec 2015 17:49:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4GCi-0000MB-7S for submit@debbugs.gnu.org; Wed, 02 Dec 2015 17:48:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4GCi-0000M7-4O for submit@debbugs.gnu.org; Wed, 02 Dec 2015 17:48:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4GCh-0000ob-4v for bug-auctex@gnu.org; Wed, 02 Dec 2015 17:48:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4GCc-0000LT-Vn for bug-auctex@gnu.org; Wed, 02 Dec 2015 17:48:51 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4GCc-0000LN-SR for bug-auctex@gnu.org; Wed, 02 Dec 2015 17:48:46 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33195) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_ARCFOUR_SHA1:128) (Exim 4.82) (envelope-from ) id 1a4GCc-0004g4-GN for bug-auctex@gnu.org; Wed, 02 Dec 2015 17:48:46 -0500 Received: by wmec201 with SMTP id c201so1283109wme.0 for ; Wed, 02 Dec 2015 14:48:45 -0800 (PST) X-Received: by 10.194.116.133 with SMTP id jw5mr7422707wjb.110.1449096525464; Wed, 02 Dec 2015 14:48:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.152.72 with HTTP; Wed, 2 Dec 2015 14:48:06 -0800 (PST) In-Reply-To: References: From: =?UTF-8?Q?Mos=C3=A8_Giordano?= Date: Wed, 2 Dec 2015 23:48:06 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#22077: Possible bug in `reftex-what-index-tag' To: bug-auctex Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: 22077@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Arash, 2015-12-02 22:33 GMT+01:00 Arash Esbati : > Hi all, > > please consider the following example: > > --8<---------------cut here---------------start------------->8--- > \documentclass{article} > > \usepackage{index} > \newindex{aut}{adx}{and}{Name Index} > > \begin{document} > `C-c C-m index RET aut RET' enters `\index[aut]' in buffer > and exits with `(wrong-type-argument integer-or-marker-p nil)'. > \end{document} > --8<---------------cut here---------------end--------------->8--- > > Debugger says: > > --8<---------------cut here---------------start------------->8--- > Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p ni= l) > reftex-what-index-tag() > TeX-arg-index(nil) > TeX-parse-argument(nil TeX-arg-index) > TeX-parse-arguments(([TeX-arg-index-tag] TeX-arg-index)) > TeX-parse-macro("index" ([TeX-arg-index-tag] TeX-arg-index)) > TeX-insert-macro("index") > call-interactively(TeX-insert-macro nil nil) > command-execute(TeX-insert-macro) > --8<---------------cut here---------------end--------------->8--- > > If I get this correctly, the problem is in `(match-end 1)' part of > `reftex-what-index-tag' defined in `reftex-auc.el': > > --8<---------------cut here---------------start------------->8--- > (defun reftex-what-index-tag () > ;; Look backward to find out what index the macro at point belongs to > (let ((macro (save-excursion > (and (re-search-backward "\\\\[a-zA-Z*]+" nil t) > (match-string 0)))) > tag entry) > (when (and macro > (setq entry (assoc macro reftex-index-macro-alist))) > (setq tag (nth 1 entry)) > (cond > ((stringp tag) tag) > ((integerp tag) > (save-excursion > (goto-char (match-end 1)) > (or (reftex-nth-arg tag (nth 6 entry)) "idx"))) > (t "idx"))))) > --8<---------------cut here---------------end--------------->8--- > > I think it should be `(match-end 0)' since the last search had no > parenthesized expression in regexp. In short: > > --8<---------------cut here---------------start------------->8--- > diff --git a/lisp/textmodes/reftex-auc.el b/lisp/textmodes/reftex-auc.el > index bbad065..151be59 100644 > --- a/lisp/textmodes/reftex-auc.el > +++ b/lisp/textmodes/reftex-auc.el > @@ -137,7 +137,7 @@ reftex-what-index-tag > ((stringp tag) tag) > ((integerp tag) > (save-excursion > - (goto-char (match-end 1)) > + (goto-char (match-end 0)) > (or (reftex-nth-arg tag (nth 6 entry)) "idx"))) > (t "idx"))))) > --8<---------------cut here---------------end--------------->8--- > > Any comments? I could make a proper patch for this. Yes, you're right, `goto-char' is called with nil argument. And yes, a proper patch would be useful, even if it's a one-liner change. BTW, you signed the copyright paper only for AUCTeX, should you want to provide more substantial contributions for RefTeX you have to sign the copyright paper for Emacs as well. Bye, Mos=C3=A8 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 15:15:18 2015 Received: (at 22077) by debbugs.gnu.org; 4 Dec 2015 20:15:18 +0000 Received: from localhost ([127.0.0.1]:39425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4wlB-0006dD-QK for submit@debbugs.gnu.org; Fri, 04 Dec 2015 15:15:18 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37361) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4wkr-0006cE-PJ for 22077@debbugs.gnu.org; Fri, 04 Dec 2015 15:15:16 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 22DF520829 for <22077@debbugs.gnu.org>; Fri, 4 Dec 2015 15:14:57 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Fri, 04 Dec 2015 15:14:57 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=BwTSj+FiyB4MImn U74czFelTKAE=; b=kWAu2HY+A5S19ESxeE01amonEiWeFsrVJe8EPT5sDuiTDiZ AU9gjd8OdqcyliQDNymMZL/sLVkg45bPan4uJySljilHGdRqC/XMLZNyq6BFB29M ceYAbkFrDqxqmko9xOKLPlIfk0KRk5WO2jnLNpN5s0uxNge23D/0o92d8O2s= X-Sasl-enc: 387TubYchZgOxMvKqGgItoIRYHWKx6lbLsl+LKyJAHwn 1449260096 Received: from thinkpad-t440p (unknown [2.161.144.68]) by mail.messagingengine.com (Postfix) with ESMTPA id 56F1A680110; Fri, 4 Dec 2015 15:14:56 -0500 (EST) From: Tassilo Horn To: =?utf-8?Q?Mos=C3=A8?= Giordano Subject: Re: bug#22077: Possible bug in `reftex-what-index-tag' References: Date: Fri, 04 Dec 2015 21:14:53 +0100 In-Reply-To: (=?utf-8?Q?=22Mos=C3=A8?= Giordano"'s message of "Wed, 2 Dec 2015 23:48:06 +0100") Message-ID: <87si3i0y4i.fsf@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 22077 Cc: 22077@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Mos=C3=A8 Giordano writes: >> I think it should be `(match-end 0)' since the last search had no >> parenthesized expression in regexp. In short: >> >> --8<---------------cut here---------------start------------->8--- >> diff --git a/lisp/textmodes/reftex-auc.el b/lisp/textmodes/reftex-auc.el >> index bbad065..151be59 100644 >> --- a/lisp/textmodes/reftex-auc.el >> +++ b/lisp/textmodes/reftex-auc.el >> @@ -137,7 +137,7 @@ reftex-what-index-tag >> ((stringp tag) tag) >> ((integerp tag) >> (save-excursion >> - (goto-char (match-end 1)) >> + (goto-char (match-end 0)) >> (or (reftex-nth-arg tag (nth 6 entry)) "idx"))) >> (t "idx"))))) >> --8<---------------cut here---------------end--------------->8--- >> >> Any comments? I could make a proper patch for this. > > Yes, you're right, `goto-char' is called with nil argument. And yes, > a proper patch would be useful, even if it's a one-liner change. I've just committed this trivial patch under Arash's name. > BTW, you signed the copyright paper only for AUCTeX, should you want > to provide more substantial contributions for RefTeX you have to sign > the copyright paper for Emacs as well. Yes, that would be good anyway. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 15:15:25 2015 Received: (at 22077-done) by debbugs.gnu.org; 4 Dec 2015 20:15:25 +0000 Received: from localhost ([127.0.0.1]:39428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4wlI-0006dX-S6 for submit@debbugs.gnu.org; Fri, 04 Dec 2015 15:15:25 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57737) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4wlG-0006dO-Da for 22077-done@debbugs.gnu.org; Fri, 04 Dec 2015 15:15:22 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 530C320A41 for <22077-done@debbugs.gnu.org>; Fri, 4 Dec 2015 15:15:22 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Fri, 04 Dec 2015 15:15:22 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=KZtVsI2HsQA14xImXb9r9H6jvu8=; b=GrHCZ +8boa1qOoWwpgyWfhz9BuVPS8Ajwb8kaVDBOVeJ72oCS5m68Q3Al6Fl3qB6mlcf6 OlOAp8dcuYwLujbg8kTOJ8KdIm1M0C6chnpLiJ7HyZg6ckzexdwrxLNkI6HaEiu5 tv4Sc4cv0bS3QH230slfH7S719on4fxfS8DdX4= X-Sasl-enc: JQiFHtCx+48DsatT3r6CE2p7E5p+hvMuIfEQkklh6xGI 1449260121 Received: from thinkpad-t440p (unknown [2.161.144.68]) by mail.messagingengine.com (Postfix) with ESMTPA id 9DD6E680110; Fri, 4 Dec 2015 15:15:21 -0500 (EST) From: Tassilo Horn To: =?utf-8?Q?Mos=C3=A8?= Giordano Subject: Re: bug#22077: Possible bug in `reftex-what-index-tag' References: Date: Fri, 04 Dec 2015 21:15:19 +0100 In-Reply-To: (=?utf-8?Q?=22Mos=C3=A8?= Giordano"'s message of "Wed, 2 Dec 2015 23:48:06 +0100") Message-ID: <87oae60y3s.fsf@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 22077-done Cc: 22077-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Ups, forgotten to close... Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 04 16:55:15 2015 Received: (at 22077) by debbugs.gnu.org; 4 Dec 2015 21:55:15 +0000 Received: from localhost ([127.0.0.1]:39464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4yJu-0000Tf-UL for submit@debbugs.gnu.org; Fri, 04 Dec 2015 16:55:15 -0500 Received: from mo4-p05-ob.smtp.rzone.de ([81.169.146.181]:14281) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4yJZ-0000Ss-SG for 22077@debbugs.gnu.org; Fri, 04 Dec 2015 16:55:12 -0500 X-RZG-AUTH: :LX4FZkiIfuylNuAdMHQ4lncSR35KjR0W31pc2hVA+gGAVv3+6WyhJicb1liiRg== X-RZG-CLASS-ID: mo05 Received: from mutant (p5795EF33.dip0.t-ipconnect.de [87.149.239.51]) by smtp.strato.de (RZmta 37.14 DYNA|AUTH) with ESMTPA id j03e48rB4LsopUE; Fri, 4 Dec 2015 22:54:50 +0100 (CET) From: Arash Esbati To: Tassilo Horn Subject: Re: bug#22077: Possible bug in `reftex-what-index-tag' References: <87si3i0y4i.fsf@gnu.org> Date: Fri, 04 Dec 2015 22:54:19 +0100 In-Reply-To: <87si3i0y4i.fsf@gnu.org> (Tassilo Horn's message of "Fri, 04 Dec 2015 21:14:53 +0100") Message-ID: <864mfxkhh0.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 22077 Cc: 22077@debbugs.gnu.org, =?iso-8859-1?Q?Mos=E8?= Giordano X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Tassilo Horn writes: > Mos=E8 Giordano writes: > >>> I think it should be `(match-end 0)' since the last search had no >>> parenthesized expression in regexp. In short: >>> >>> --8<---------------cut here---------------start------------->8--- >>> diff --git a/lisp/textmodes/reftex-auc.el b/lisp/textmodes/reftex-auc.el >>> index bbad065..151be59 100644 >>> --- a/lisp/textmodes/reftex-auc.el >>> +++ b/lisp/textmodes/reftex-auc.el >>> @@ -137,7 +137,7 @@ reftex-what-index-tag >>> ((stringp tag) tag) >>> ((integerp tag) >>> (save-excursion >>> - (goto-char (match-end 1)) >>> + (goto-char (match-end 0)) >>> (or (reftex-nth-arg tag (nth 6 entry)) "idx"))) >>> (t "idx"))))) >>> --8<---------------cut here---------------end--------------->8--- >>> >>> Any comments? I could make a proper patch for this. >> >> Yes, you're right, `goto-char' is called with nil argument. And yes, >> a proper patch would be useful, even if it's a one-liner change. Mos=E8, many thanks for double-checking and the thumbs up. > I've just committed this trivial patch under Arash's name. Tassilo, many thanks for applying the one-liner. I was about to prepare a patch. >> BTW, you signed the copyright paper only for AUCTeX, should you want >> to provide more substantial contributions for RefTeX you have to sign >> the copyright paper for Emacs as well. > > Yes, that would be good anyway. Actually, I'm trying hard to avoid RefTeX realms ;-) (The code is not easy to understand) I will sign the copyright paper for Emacs as well. Thanks, Arash From unknown Sun Jun 15 01:08:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Jan 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator