GNU bug report logs - #22072
Error in display-startup-screen if create-image fails

Previous Next

Full log

Message #14 received at 22072 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stephen Leake <stephen_leake <at> stephe-leake.org>
Cc: Richard Copley <rcopley <at> gmail.com>, 22072 <at> debbugs.gnu.org
Subject: Re: bug#22072: Error in display-startup-screen if create-image fails
Date: Thu, 26 Sep 2019 18:27:51 +0200

Stephen Leake <stephen_leake <at> stephe-leake.org> writes:

> Richard Copley <rcopley <at> gmail.com> writes:
>
> Can you test this patch:

[...]

> -	(let* ((img (create-image (fancy-splash-image-file)))
> -	       (image-height (and img (cdr (image-size img nil frame))))
> -	       ;; We test frame-height so that, if the frame is split
> -	       ;; by displaying a warning, that doesn't cause the normal
> -	       ;; splash screen to be used.
> -	       (frame-height (1- (frame-height frame))))
> -	  (> frame-height (+ image-height 19)))))))
> +	(let ((img (create-image (fancy-splash-image-file))))
> +              (image-height (and img (cdr (image-size img nil frame))))
> +              ;; We test frame-height so that, if the frame is split
> +              ;; by displaying a warning, that doesn't cause the normal
> +              ;; splash screen to be used.
> +              (frame-height (and img (1- (frame-height frame)))))
> +	  (and img (> frame-height (+ image-height 19))))))))

I've now fixed this on the trunk inspired by this patch, but slightly
differently.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.