From unknown Fri Jun 20 07:21:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#22072 <22072@debbugs.gnu.org> To: bug#22072 <22072@debbugs.gnu.org> Subject: Status: Error in display-startup-screen if create-image fails Reply-To: bug#22072 <22072@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:21:39 +0000 retitle 22072 Error in display-startup-screen if create-image fails reassign 22072 emacs submitter 22072 Richard Copley severity 22072 normal tag 22072 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 01 20:54:03 2015 Received: (at submit) by debbugs.gnu.org; 2 Dec 2015 01:54:03 +0000 Received: from localhost ([127.0.0.1]:35509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a3wcN-0008PE-8w for submit@debbugs.gnu.org; Tue, 01 Dec 2015 20:54:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58591) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a3wc3-0008OR-LG for submit@debbugs.gnu.org; Tue, 01 Dec 2015 20:54:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3wc2-0003hH-6l for submit@debbugs.gnu.org; Tue, 01 Dec 2015 20:53:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3wc2-0003hD-3q for submit@debbugs.gnu.org; Tue, 01 Dec 2015 20:53:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3wc0-0008At-SC for bug-gnu-emacs@gnu.org; Tue, 01 Dec 2015 20:53:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3wbz-0003h1-Pm for bug-gnu-emacs@gnu.org; Tue, 01 Dec 2015 20:53:40 -0500 Received: from mail-yk0-x22e.google.com ([2607:f8b0:4002:c07::22e]:36105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3wbz-0003gx-Kk for bug-gnu-emacs@gnu.org; Tue, 01 Dec 2015 20:53:39 -0500 Received: by ykdr82 with SMTP id r82so30560921ykd.3 for ; Tue, 01 Dec 2015 17:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=swzkeqiA3SjAWsi+8OeTzMyIm6tJrGvnfjBdLGUfYKo=; b=pCU+t5pjUlRkmtveceim4OgW8CcrvyQy/4iHZMeAjkjE35rbAuUvcbq7p7PMcshEyt AftWqHvlKhMH0PCWvReZ5PFRRfZKp7MXKykTUtYx31vIXiXuRhgnMfYqxzM1FdYwNbp6 FgOuFMqa+dznPXI9l4WYpbzBmJkfO7210aFhSGqvwTch8CCKJfOy2n+cYqFlRHdMuA0R Z9hn6Gw9uvYIPHJ77r8KQtYkZbqHKq7kTyHfMJrjejueKM+lhZo9WIXwkkrcu9SXPg1O mzXCmzxc9UcoTjfAxqjaTD0JkRVUiI6OdlH3YVAVUMJyJiC4f79XZTVNiDB+0Gi0GQKO ulvw== MIME-Version: 1.0 X-Received: by 10.129.53.148 with SMTP id c142mr415692ywa.138.1449021218943; Tue, 01 Dec 2015 17:53:38 -0800 (PST) Received: by 10.37.195.129 with HTTP; Tue, 1 Dec 2015 17:53:38 -0800 (PST) Date: Wed, 2 Dec 2015 01:53:38 +0000 Message-ID: Subject: Error in display-startup-screen if create-image fails From: Richard Copley To: "bug-gnu-emacs@gnu.org" Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) There's a mistake in the function "use-fancy-splash-screens-p" in startup.el. It can set the local variable "image-height" to nil (if creating an image from the fancy-splash-image-file fails), but later it uses the value of "image-height" in an arithmetic expression, and gives the error "Wrong type argument: number-or-marker-p, nil". (The reason create-image has suddenly started failing for me is a difference in my build environment. I'm trying out a build using only stuff available from the MSYS2 package manager. I haven't noticed any other problems so far. The create-image problem goes away if I configure --without-imagemagick.) In GNU Emacs 25.1.50.1 (x86_64-w64-mingw32) of 2015-12-02 Repository revision: 098738ff1a193ff6e6af71071461f75635d1b790 Windowing system distributor 'Microsoft Corp.', version 10.0.10586 Configured using: 'configure --prefix /c/emacs/emacs-20151201-205551 --disable-dependency-tracking --enable-locallisppath=%emacs_dir%/../site-lisp 'CFLAGS=-Og -g -ggdb'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS Important settings: value of $LANG: ENG locale-coding-system: cp1252 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. display-startup-screen: Wrong type argument: number-or-marker-p, nil Features: (shadow sort gnus-util mail-extr emacsbug message dired format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils advice time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify dbusbind w32 multi-tty make-network-process emacs) Memory information: ((conses 16 84676 9280) (symbols 56 19141 0) (miscs 48 36 128) (strings 32 14569 3411) (string-bytes 1 399450) (vectors 16 11586) (vector-slots 8 411206 1940) (floats 8 141 49) (intervals 56 243 0) (buffers 976 11)) From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 07:37:07 2015 Received: (at 22072) by debbugs.gnu.org; 2 Dec 2015 12:37:07 +0000 Received: from localhost ([127.0.0.1]:35750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a46eg-0008PU-Qq for submit@debbugs.gnu.org; Wed, 02 Dec 2015 07:37:07 -0500 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:39675) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1a46ed-0008PL-KG for 22072@debbugs.gnu.org; Wed, 02 Dec 2015 07:37:05 -0500 Received: (qmail 21340 invoked by uid 0); 2 Dec 2015 12:36:57 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy4.mail.unifiedlayer.com with SMTP; 2 Dec 2015 12:36:57 -0000 Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw3 with id ojcr1r00A2UdiVW01jcunY; Wed, 02 Dec 2015 12:36:54 -0700 X-Authority-Analysis: v=2.1 cv=Caqbutbl c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=wUQvQvOEmiQA:10 a=pGLkceISAAAA:8 a=cwJsGDipi4G-k-tNeckA:9 Received: from [76.218.37.33] (port=58166 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1a46eT-0000yF-IM; Wed, 02 Dec 2015 05:36:53 -0700 From: Stephen Leake To: Richard Copley Subject: Re: bug#22072: Error in display-startup-screen if create-image fails References: Date: Wed, 02 Dec 2015 06:36:48 -0600 In-Reply-To: (Richard Copley's message of "Wed, 2 Dec 2015 01:53:38 +0000") Message-ID: <86mvttm3hb.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 22072 Cc: 22072@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Richard Copley writes: Can you test this patch: diff --git a/lisp/startup.el b/lisp/startup.el index 1346310..a281f86 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -1874,13 +1874,13 @@ we put it on this frame." (image-type-available-p 'pbm))) (let ((frame (fancy-splash-frame))) (when frame - (let* ((img (create-image (fancy-splash-image-file))) - (image-height (and img (cdr (image-size img nil frame)))) - ;; We test frame-height so that, if the frame is split - ;; by displaying a warning, that doesn't cause the normal - ;; splash screen to be used. - (frame-height (1- (frame-height frame)))) - (> frame-height (+ image-height 19))))))) + (let ((img (create-image (fancy-splash-image-file)))) + (image-height (and img (cdr (image-size img nil frame)))) + ;; We test frame-height so that, if the frame is split + ;; by displaying a warning, that doesn't cause the normal + ;; splash screen to be used. + (frame-height (and img (1- (frame-height frame))))) + (and img (> frame-height (+ image-height 19)))))))) -- -- Stephe From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 02 15:07:05 2015 Received: (at 22072) by debbugs.gnu.org; 2 Dec 2015 20:07:05 +0000 Received: from localhost ([127.0.0.1]:36598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4Dg9-0007vR-08 for submit@debbugs.gnu.org; Wed, 02 Dec 2015 15:07:05 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:33526) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a4Dg6-0007vI-Dp for 22072@debbugs.gnu.org; Wed, 02 Dec 2015 15:07:03 -0500 Received: by ykdv3 with SMTP id v3so60475424ykd.0 for <22072@debbugs.gnu.org>; Wed, 02 Dec 2015 12:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wOk3ndjH7EBWlYwm3zsuAKnhIFu8bkVAzlZBpts607k=; b=H+nzxD4m8KA7wvvrfFVJPeyMFMhi6cyCPGjbt1o4+55sHWU5k73jkazteigUe+cKek QHFDCg6vHCv+LvcXgcuGqFlfZe7xn8u9cfVEnCt7EOY5sqLQKGgsUJKSmcmy1d+r4lkZ 8e/MXNkSOkuWcTqhDC5OagznvuQrsQZEh/ghfL1oe4poxHLc8bYg8m43MVqqUvqpmJpT iHVgRbtI55q6FdRIOwV8PQV1ubK2hoqUEaFOpIIHxEP14SUseM6uCvd5V4NZYUy71rvY 3Oz355j2OvZ+IbQOnR8FVoyykhDmhWZoG1E50ig9zBpARtJgdmAB/Jn7ehk+MmjITPPQ mtBw== MIME-Version: 1.0 X-Received: by 10.13.219.85 with SMTP id d82mr3728560ywe.136.1449086821868; Wed, 02 Dec 2015 12:07:01 -0800 (PST) Received: by 10.37.195.129 with HTTP; Wed, 2 Dec 2015 12:07:01 -0800 (PST) In-Reply-To: <86mvttm3hb.fsf@stephe-leake.org> References: <86mvttm3hb.fsf@stephe-leake.org> Date: Wed, 2 Dec 2015 20:07:01 +0000 Message-ID: Subject: Re: bug#22072: Error in display-startup-screen if create-image fails From: Richard Copley To: Stephen Leake Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22072 Cc: 22072@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thanks Stephen. More haste, less speed ... you shouldn't have changed "let*" to "let" and the parentheses don't match. After fixing those things, yes, doing as you suggest allows my broken Emacs to start without the fancy image and without error. On 2 December 2015 at 12:36, Stephen Leake wrote: > Richard Copley writes: > > Can you test this patch: > > diff --git a/lisp/startup.el b/lisp/startup.el > index 1346310..a281f86 100644 > --- a/lisp/startup.el > +++ b/lisp/startup.el > @@ -1874,13 +1874,13 @@ we put it on this frame." > (image-type-available-p 'pbm))) > (let ((frame (fancy-splash-frame))) > (when frame > - (let* ((img (create-image (fancy-splash-image-file))) > - (image-height (and img (cdr (image-size img nil frame)))) > - ;; We test frame-height so that, if the frame is split > - ;; by displaying a warning, that doesn't cause the normal > - ;; splash screen to be used. > - (frame-height (1- (frame-height frame)))) > - (> frame-height (+ image-height 19))))))) > + (let ((img (create-image (fancy-splash-image-file)))) > + (image-height (and img (cdr (image-size img nil frame)))) > + ;; We test frame-height so that, if the frame is split > + ;; by displaying a warning, that doesn't cause the normal > + ;; splash screen to be used. > + (frame-height (and img (1- (frame-height frame))))) > + (and img (> frame-height (+ image-height 19)))))))) > > -- > -- Stephe From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 12:27:57 2019 Received: (at 22072) by debbugs.gnu.org; 26 Sep 2019 16:27:57 +0000 Received: from localhost ([127.0.0.1]:44500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDWcX-00040x-AI for submit@debbugs.gnu.org; Thu, 26 Sep 2019 12:27:57 -0400 Received: from quimby.gnus.org ([80.91.231.51]:35566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDWcV-00040p-Sg for 22072@debbugs.gnu.org; Thu, 26 Sep 2019 12:27:56 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDWcR-000571-Kh; Thu, 26 Sep 2019 18:27:54 +0200 From: Lars Ingebrigtsen To: Stephen Leake Subject: Re: bug#22072: Error in display-startup-screen if create-image fails References: <86mvttm3hb.fsf@stephe-leake.org> Date: Thu, 26 Sep 2019 18:27:51 +0200 In-Reply-To: <86mvttm3hb.fsf@stephe-leake.org> (Stephen Leake's message of "Wed, 02 Dec 2015 06:36:48 -0600") Message-ID: <87d0fnowe0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Leake writes: > Richard Copley writes: > > Can you test this patch: [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22072 Cc: Richard Copley , 22072@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Leake writes: > Richard Copley writes: > > Can you test this patch: [...] > - (let* ((img (create-image (fancy-splash-image-file))) > - (image-height (and img (cdr (image-size img nil frame)))) > - ;; We test frame-height so that, if the frame is split > - ;; by displaying a warning, that doesn't cause the normal > - ;; splash screen to be used. > - (frame-height (1- (frame-height frame)))) > - (> frame-height (+ image-height 19))))))) > + (let ((img (create-image (fancy-splash-image-file)))) > + (image-height (and img (cdr (image-size img nil frame)))) > + ;; We test frame-height so that, if the frame is split > + ;; by displaying a warning, that doesn't cause the normal > + ;; splash screen to be used. > + (frame-height (and img (1- (frame-height frame))))) > + (and img (> frame-height (+ image-height 19)))))))) I've now fixed this on the trunk inspired by this patch, but slightly differently. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 12:28:00 2019 Received: (at control) by debbugs.gnu.org; 26 Sep 2019 16:28:00 +0000 Received: from localhost ([127.0.0.1]:44503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDWca-00041D-J3 for submit@debbugs.gnu.org; Thu, 26 Sep 2019 12:28:00 -0400 Received: from quimby.gnus.org ([80.91.231.51]:35584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDWcZ-000415-7s for control@debbugs.gnu.org; Thu, 26 Sep 2019 12:27:59 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDWcW-000579-Hf for control@debbugs.gnu.org; Thu, 26 Sep 2019 18:27:58 +0200 Date: Thu, 26 Sep 2019 18:27:56 +0200 Message-Id: <87blv7owdv.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22072 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 22072 fixed close 22072 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 22072 fixed close 22072 27.1 quit From unknown Fri Jun 20 07:21:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Oct 2019 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator