GNU bug report logs - #22067
[bug-diffutils] bug#20062: bug#20062: [PATCH] diff: add support for --color

Previous Next

Full log

Message #44 received at 22067 <at> debbugs.gnu.org (full text, mbox):

From: Giuseppe Scrivano <gscrivano <at> gnu.org>
To: Jim Meyering <jim <at> meyering.net>
Cc: Gisle Vanem <gvanem <at> yahoo.no>, 22067 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#22067: bug#22067: bug#20062: bug#20062:
 [PATCH] diff: add support for --color
Date: Mon, 07 Mar 2016 17:17:48 +0100

Jim Meyering <jim <at> meyering.net> writes:

> Thank you, and sorry about the delay.
> I noticed that on OS X, the new test passed even without
> the fix, but didn't want to let that hold up the fix any longer.
> I've adjusted the test slightly, to eliminate the tr pipes.
> Will wait for your "ack", before pushing.

Unfortunately I have no access to OS X to test it out by myself.

It is fine by me without the 'tr' so ACK from me.

Thanks for the review,
Giuseppe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.