GNU bug report logs - #22009
Inconsistent handling of window splitting with margins

Previous Next

Package: emacs;

Reported by: Joost Kremers <joostkremers <at> fastmail.fm>

Date: Wed, 25 Nov 2015 13:08:01 UTC

Severity: normal

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Joost Kremers <joostkremers <at> fastmail.fm>
Cc: 22009 <at> debbugs.gnu.org
Subject: bug#22009: PATCH: Use `window-total-width' in `window-splittable-p'
Date: Mon, 07 Sep 2020 18:48:13 +0200
Joost Kremers <joostkremers <at> fastmail.fm> writes:

> Following discussion on emacs-devel (thread "Window splitting issues
> with margins"), this patch replaces the call to `window-width' in
> `window-splittable-p' with `window-total-width'. This takes the window
> margins into account when determining if a window can be split
> horizontally.

[...]

> -	       (>= (window-width window)
> +	       (>= (window-total-width window)

[...]

>>> I'm not sure that would be able to handle cases where different modes
>>> use the margins for different purposes.
>>
>> I think this is the actual challenge in this bug report: design a way
>> that would make it possible.
>
> Yes. We discussed a possible way of doing this in the thread on
> emacs-devel. I'll start a new thread there with a summary of the issues
> and a proposal on how to solve them.

Skimming this bug report, I think everybody pretty much agreed that this
patch was better than the current behaviour, but that this new behaviour
isn't completely correct (especially for those mode that use the margins
to display useful information).

Did the discussion on emacs-devel come to any sort of useful conclusion?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 261 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.