GNU bug report logs - #22000
25.0.50; Running dired changes frame width, gtk_distribute_natural_allocation throws assertion

Previous Next

Package: emacs;

Reported by: David Engster <deng <at> randomsample.de>

Date: Mon, 23 Nov 2015 20:56:02 UTC

Severity: normal

Merged with 15700, 18270, 22898, 25313, 31626

Found in versions 24.3, 24.5, 25.0.50

Full log

Message #162 received at 22000 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Vivek Dasmohapatra <vivek <at> etla.org>
Cc: "eliz <at> gnu.org" <eliz <at> gnu.org>, 22000 <at> debbugs.gnu.org,
 David Engster <deng <at> randomsample.de>
Subject: Re: bug#22000: Patch addressing the menu-bar frame-resize interaction
Date: Thu, 18 Oct 2018 10:06:27 +0200

> New patch series - I think this has all the features and functionality
> discussed so far.

Everything's alright with two nitpicks:

(1) The version tag of 'menu-bar-scrollbar-mode' must be 26.2 unless Eli
decides that this may go to master only.

(2) Please make the 'showhide-menu-bar-scrollbar-menu' dependent on
whether GTK is used.  Something like

(when (featurep 'gtk)
  (defvar menu-bar-showhide-menu-bar-scrollbar-mode-menu

and

    (when (featurep 'gtk)
      (bindings--define-key menu [showhide-menu-bar-scrollbar-menu]

Eli, I think this should go to the release branch.  If it introduces any
problems, we should find out soon enough - I think that most of our GTK
users leave the menu bar on.  But it is not just a cosmetic change.  It
would have helped if anyone else tested this but unfortunately this was
not the case.

martin
This bug report was last modified 5 years and 267 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.