From unknown Thu Aug 14 21:50:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#21988: 24.5; keyword 'our' not being fontified in perl-mode Resent-From: Thomas Uhle Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2015 23:22:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21988 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 21988@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.144823449725036 (code B ref -1); Sun, 22 Nov 2015 23:22:04 +0000 Received: (at submit) by debbugs.gnu.org; 22 Nov 2015 23:21:37 +0000 Received: from localhost ([127.0.0.1]:48653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0dwu-0006Vj-4x for submit@debbugs.gnu.org; Sun, 22 Nov 2015 18:21:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34982) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0WiS-0002LT-1G for submit@debbugs.gnu.org; Sun, 22 Nov 2015 10:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0WiQ-0006k9-MX for submit@debbugs.gnu.org; Sun, 22 Nov 2015 10:38:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0WiQ-0006k5-JN for submit@debbugs.gnu.org; Sun, 22 Nov 2015 10:38:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0WiP-0000f6-M0 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 10:38:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0WiM-0006jq-WD for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 10:38:09 -0500 Received: from mailout2.zih.tu-dresden.de ([141.30.67.73]:60680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0WiM-0006jh-Ph for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 10:38:06 -0500 Received: from mail.zih.tu-dresden.de ([141.76.14.4]) by mailout2.zih.tu-dresden.de with esmtp (Exim 4.63) (envelope-from ) id 1a0WiK-0003c1-V0 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 16:38:05 +0100 Received: from login2.zih.tu-dresden.de ([141.30.61.141] helo=login2) by server-50.mailclusterdns.zih.tu-dresden.de with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (envelope-from ) id 1a0WiK-0005LN-R0 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 16:38:04 +0100 Date: Sun, 22 Nov 2015 16:38:01 +0100 (CET) From: Thomas Uhle X-X-Sender: tu176834@login2 Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="512593213-1116957065-1448206684=:21369" X-TUD-Virus-Scanned: mailout2.zih.tu-dresden.de X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Sun, 22 Nov 2015 18:21:34 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --512593213-1116957065-1448206684=:21369 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Hello, the keyword 'our' opposed to the keywords 'my' and 'local' is not being fontified in perl-mode. The simple patch that is attached to this bug report is fixing this issue. Best regards, Thomas Uhle --512593213-1116957065-1448206684=:21369 Content-Type: TEXT/x-patch; name=perl-mode-elisp.diff Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=perl-mode-elisp.diff LS0tIGxpc3AvcHJvZ21vZGVzL3BlcmwtbW9kZS5lbH4JMjAxNS0wNi0xNCAy MTo0NzoyOSArMDIwMA0KKysrIGxpc3AvcHJvZ21vZGVzL3BlcmwtbW9kZS5l bAkyMDE1LTExLTIyIDE2OjAxOjI2ICswMTAwDQpAQCAtMTk0LDggKzE5NCw4 IEBADQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICJCRUdJTiIgIkVO RCIgInJldHVybiIgImV4ZWMiICJldmFsIikgdCkNCiAgICAgICAgICAgICAg ICJcXD4iKQ0KICAgICAgOzsNCi0gICAgIDs7IEZvbnRpZnkgbG9jYWwgYW5k IG15IGtleXdvcmRzIGFzIHR5cGVzLg0KLSAgICAgKCJcXDxcXChsb2NhbFxc fG15XFwpXFw+IiAuIGZvbnQtbG9jay10eXBlLWZhY2UpDQorICAgICA7OyBG b250aWZ5IGxvY2FsLCBteSBhbmQgb3VyIGtleXdvcmRzIGFzIHR5cGVzLg0K KyAgICAgKCJcXDxcXChsb2NhbFxcfG15XFx8b3VyXFwpXFw+IiAuIGZvbnQt bG9jay10eXBlLWZhY2UpDQogICAgICA7Ow0KICAgICAgOzsgRm9udGlmeSBm dW5jdGlvbiwgdmFyaWFibGUgYW5kIGZpbGUgbmFtZSByZWZlcmVuY2VzLg0K ICAgICAgKCImXFwoXFxzdytcXCg6Olxcc3crXFwpKlxcKSIgMSBmb250LWxv Y2stZnVuY3Rpb24tbmFtZS1mYWNlKQ0K --512593213-1116957065-1448206684=:21369-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 23:04:46 2017 Received: (at control) by debbugs.gnu.org; 8 Jul 2017 03:04:47 +0000 Received: from localhost ([127.0.0.1]:57208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTg34-0003xR-Mc for submit@debbugs.gnu.org; Fri, 07 Jul 2017 23:04:46 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:35876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTg33-0003xE-5c for control@debbugs.gnu.org; Fri, 07 Jul 2017 23:04:45 -0400 Received: by mail-io0-f182.google.com with SMTP id z62so4608577ioi.3 for ; Fri, 07 Jul 2017 20:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=GxXeKlp6MQ+mWOz0E2d2iJsvOJSEwT1FBKknUmXBYyI=; b=eK8oT811uTefauaB0HlAMO9G/0Xi3BPCnNyCyYCL0vrKugx8SaNM4zQWEhZiFCWM8R yDumoa6iG09SEYCiRqAWIxQQ3qC4O9k8VLoyzh8npwERcS9/TnQ17nTGkAQzkra9ZF0/ nW+irxElmWq8MLYpaResBxcjP+JiV/EtfZZ3+eudax9li/zOvw81nHlCSSYajNs8jWQ4 v/FiSIv8PiB7wYosVX7chJgedYPbp6XRexcTGREg2ru6KOo5NQqzfLDhtk3ChYeRKlEH gvc21BSS1GXgso9qnGBvIeSxgDvJas2MVSCE0oBjSTPYUrBFKSLKgMVxvGWEtsW3n4nP uiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=GxXeKlp6MQ+mWOz0E2d2iJsvOJSEwT1FBKknUmXBYyI=; b=GNhTheArEyCrBo52Vy0FJf1XpvKjgrgh91/vwhtZ6RKQ7oXoJB4RVUyFsl4g6V3Umj U4XTX/7TjqRQ0lW2hmI+Pl+3IQsIt7dMjJri51BxbjLt0kbjMN6MU8bf3XOIKs1l69dT +CQf5lVJHpvf6p//4w+v/cNQdFWFsbP5ZBDyeFj0ZDy7zo9CWFi5wMY3VwXy3oBXXjt3 Xd54wUnuNFJ55bteDEvzbxisXcSTNvMzYzVGQArE7lr5U5bREoA4gADZTT3+8YTcuGAR 7FTUWUjlvDVqOnH9+bYJ2pBeS8ijjgqFuZFfH4kJHYkPSqj0gC4W7BbDeJ98DzyWcyZ9 5DlQ== X-Gm-Message-State: AKS2vOysFCvpY8HcSVuM0m95omDzZz+W10J4H7TY5og6SL95awRgY7L+ eriPfh4ZxDExPygJ X-Received: by 10.107.142.21 with SMTP id q21mr57777072iod.225.1499483079291; Fri, 07 Jul 2017 20:04:39 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g198sm2362012itb.3.2017.07.07.20.04.37 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jul 2017 20:04:38 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #21988 Date: Fri, 07 Jul 2017 23:06:06 -0400 Message-ID: <87eftrhbkx.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) forcemerge 21988 27613 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 25 23:08:13 2017 Received: (at control) by debbugs.gnu.org; 26 Aug 2017 03:08:13 +0000 Received: from localhost ([127.0.0.1]:55536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlRSH-0005Dz-5A for submit@debbugs.gnu.org; Fri, 25 Aug 2017 23:08:13 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:36801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlRSF-0005Di-H6; Fri, 25 Aug 2017 23:08:11 -0400 Received: by mail-io0-f195.google.com with SMTP id v96so897530ioi.3; Fri, 25 Aug 2017 20:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TIw6GVJJaFHXx9QysVxj5kMagwB2VkUcvQbI3jfsazc=; b=OK1RiYW1aSG5eR0kdXnE+WfbJVBuc9f7UaNfm21Sm7ePepvBq7S+weIiEyLgyIzXXy 1DvQ6LVwL8TGGuETGgVcmEo9kqo7hOArAtomLqFn4NufNj4jgshezGTh7WD8Tx0M+UY1 8CexumlxNgCAqYFcmupXs46P86LbHMfFUVOpSCKog1czdTYByuTKL2ci1stUFIJY+sht Rm9R4pvGbMV+5W2IrMqXJlzsulf+hBSPeoT2wlI+NIpCqHa68oodjgErtZypTFv1orZA XFbBsS3UHjOCix2Eaq0suwlyMaWDWQKIHR31cy80hvjMwB7Gtwf/fNAWe27nn4wf2lWS EKmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=TIw6GVJJaFHXx9QysVxj5kMagwB2VkUcvQbI3jfsazc=; b=q7jQItQQgEPwMgjLMKnCU8YEmoGNxtwT/CevrfMt3MWoZLO1lY6oinzmAZqC3iVVO8 qwvjEg8nSAY7dn+4Kfn4FgjiIAu2OCcqyVvy+prtt7N1gqfZ2iiK1/o5Jc87Ty74MFBQ nUhA8GGlNIXJ/I2A+/2K0QE/uJJTYUyJuFo0cYLe+4gbRQKndB2P7KdHHeyPoRWyrzss RXIuSnnT+R0uXr4NTIySjtpsminKT+lQmHxEnv6ulPEG93WB8/2tBBM0hH5etsUiKTN9 gRF7JCsafSSB3LJvf1twj75t+Ptm2J+V41GYt7lxoqlukHEWj7G9gTqrzJK0Mm80+I4U abxA== X-Gm-Message-State: AHYfb5hrs5mMMrjbw5WJ68PhG5y6ffv9rAnkX6+jQBPgjAQDoy45j7Je qjO7xMutGipeN3ZF X-Received: by 10.107.167.197 with SMTP id q188mr360398ioe.347.1503716885596; Fri, 25 Aug 2017 20:08:05 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id z80sm1404121itc.10.2017.08.25.20.08.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Aug 2017 20:08:04 -0700 (PDT) From: npostavs@users.sourceforge.net To: Jefferson Carpenter Subject: Re: bug#27613: [PATCH] Support all perl variable declarators and prefixes References: <20170707220852.2542-1-jeffersoncarpenter2@gmail.com> <871so5d5ad.fsf@users.sourceforge.net> Date: Fri, 25 Aug 2017 23:09:44 -0400 In-Reply-To: (Jefferson Carpenter's message of "Wed, 23 Aug 2017 16:09:33 -0500") Message-ID: <877exr9g93.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control Cc: 27613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 27613 fixed close 27613 26.1 quit Jefferson Carpenter writes: > Thanks for looking it over. No, I have not done copyright assignment. Okay, pushed to master. [1: feecb66b6f]: 2017-08-25 22:50:15 -0400 Support all perl variable declarators and prefixes (Bug#27613) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=feecb66b6fe41c977b8e11b5f2d419c9544f42de> From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 20 20:26:50 2018 Received: (at control) by debbugs.gnu.org; 21 Mar 2018 00:26:50 +0000 Received: from localhost ([127.0.0.1]:44438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyRac-0008Sd-JQ for submit@debbugs.gnu.org; Tue, 20 Mar 2018 20:26:50 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:36528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyRaZ-0008SM-Im; Tue, 20 Mar 2018 20:26:48 -0400 Received: by mail-io0-f180.google.com with SMTP id o4so4562111iod.3; Tue, 20 Mar 2018 17:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=PEE25MI5hvGepB3nJh5YuxfW6fZF3QAyXU+5akxjk3A=; b=udTOfD4aO8fPgY6pjk6Q9zDOHKJNdS3aQKr05ViqpJUsrrLKJSqZNsT7GoCLf4DYQR kw4ZMy8XgFcAm1JbVl3GkzDtIwQEmbridWKBGNd/qsk4D0NMezIktcXzWaOFKvRPdFgi u+H8F25Iqy6/vSeG3DcuYkmcYHICL5bAmTxzf/NkVH5Ujo69ItVGyawq4AR0mt7P2eYe 3Gwk/848yjZGXPvgl74gEj3ozfjlhixwrWLnZMXNuOQDFew3AWgDi8OL4KQBLqMXJcwc F7VoJOfvRqU4fXOUMe29GJqtDCpt+IU1E/MqyfK1RCZ3yAzhyeKWrxgJUz6f2IoNdiKB V4DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=PEE25MI5hvGepB3nJh5YuxfW6fZF3QAyXU+5akxjk3A=; b=U9fw8FEkG73L721RiFae9pKyBfcH/CzMKKbs85fYybYf+/7ggMupggc9HG3jYflNlF 9UmlQkRuXIDnJfcmlVX+20sZfvDZKm80EL1ceuKZ7Q9HEKTWzm4YrzcAwok9UpvyoAlk BmOMXWWify/ac145ZXybQgDEiUcFB3FQhUGyiR+js44YwdJot1k4j16ILG2qC4zXxZIn WC2XlL54Gtm5L9eaYSdHhHt9W6bnx+bSZ4SX4sS5UoAfteg5J7CCSiWkfCL8w36jnuqk lDQgcu/RoHtTpnsfA/QnJo1+A1DY8ENNuqUNp5OouJ0fKNCwGT3PeNFQStpM3/ivVTmh W56w== X-Gm-Message-State: AElRT7F/x/G31b5SwL5tbVhjCbmLN0wf5KD8VI3aT/u5XkKPEVYN8hxQ 5hxsC7X0VEYViiVREgcYFnvbcw== X-Google-Smtp-Source: AG47ELsEcfiG83RsxNEIID3sglAwfUNKGSsijjsE4Q+iBbxJyhIenk4y0E0mOvmU6b417OTCIqiJbA== X-Received: by 10.107.144.197 with SMTP id s188mr19661606iod.147.1521592001943; Tue, 20 Mar 2018 17:26:41 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 12-v6sm2252618itm.0.2018.03.20.17.26.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Mar 2018 17:26:41 -0700 (PDT) From: Noam Postavsky To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel Subject: Re: bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de) References: Date: Tue, 20 Mar 2018 20:26:39 -0400 In-Reply-To: (=?utf-8?Q?=22Cl=C3=A9ment?= Pit-Claudel"'s message of "Tue, 13 Mar 2018 19:14:56 -0400") Message-ID: <874llatgsg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 30812@debbugs.gnu.org, jeffersoncarpenter2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) unarchive 27613 notfixed 27613 26.1 quit Cl=C3=A9ment Pit-Claudel writes: > I think the following commit was a bit too enthusiastic, as variables > like @temp are now highlighted in font-lock-type-face. I've reverted this from emacs-26 [1: f8cad16bb3]. > - ("\\<\\(local\\|my\\)\\>" . font-lock-type-face) > + ;; Fontify declarators and prefixes as types. > + ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersed= e\\)\\>" . font-lock-type-face) ; declarators > + ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes > Am I missing something? (I don't speak Perl, so I noticed this in a regre= ssion test) I missed this in the originating thread, but according to what I'm getting from web searches, most of those keywords are perl 6 specific. I think perl-mode shouldn't support them. [1: f8cad16bb3]: 2018-03-20 20:14:40 -0400 Revert "Support all perl variable declarators and prefixes" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Df8cad16bb3272a80= 69b3008019f9d18516aef1a5>