GNU bug report logs - #21985
25.0.50; PATCH] Extend the test suite for json.el

Previous Next

Package: emacs;

Reported by: Simen Heggestøyl <simenheg <at> gmail.com>

Date: Sun, 22 Nov 2015 21:31:02 UTC

Severity: wishlist

Tags: patch

Found in version 25.0.50

Done: Simen Heggestøyl <simenheg <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 21985 in the body.
You can then email your comments to 21985 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#21985; Package emacs. (Sun, 22 Nov 2015 21:31:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Simen Heggestøyl <simenheg <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 22 Nov 2015 21:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Dmitry Gutov <dgutov <at> yandex.ru>
Subject: 25.0.50; PATCH] Extend the test suite for json.el
Date: Sun, 22 Nov 2015 22:30:19 +0100

[Message part 1 (text/plain, inline)]
Hi,

I've tried to strengthen the test suite for json.el a bit. Most of the
public functions have now received a corresponding test.

I was unsure how to best test `json-encode' without duplicating what
the other tests (`test-json-encode-string',
`test-json-encode-keyword', and so on) already do test.

-- Simen



[Message part 2 (text/html, inline)]
[0001-Extend-the-test-suite-for-json.el.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21985; Package emacs. (Sun, 22 Nov 2015 23:16:01 GMT) Full text and rfc822 format available.

Message #8 received at 21985 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> gmail.com>,
 21985 <at> debbugs.gnu.org
Subject: Re: bug#21985: 25.0.50; PATCH] Extend the test suite for json.el
Date: Mon, 23 Nov 2015 01:15:07 +0200

On 11/22/2015 11:30 PM, Simen Heggestøyl wrote:

> I was unsure how to best test `json-encode' without duplicating what
> the other tests (`test-json-encode-string',
> `test-json-encode-keyword', and so on) already do test.

IMO, there's no too much need to exhaustively test `json-encode', aside 
from one encode test (with any value), one decode test, and maybe one 
try-to-encode-something-unusual-and-end-up-with-an-error test.

Testing all contents of json-readtable would seem excessive to me. But 
hey, if we miscalculate, we can add more tests as we fix regressions, later.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21985; Package emacs. (Tue, 24 Nov 2015 20:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 21985 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 21985 <at> debbugs.gnu.org
Subject: Re: bug#21985: 25.0.50; PATCH] Extend the test suite for json.el
Date: Tue, 24 Nov 2015 21:25:29 +0100

[Message part 1 (text/plain, inline)]
On Mon, Nov 23, 2015 at 12:15 AM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> IMO, there's no too much need to exhaustively test `json-encode', 
> aside from one encode test (with any value), one decode test, and 
> maybe one try-to-encode-something-unusual-and-end-up-with-an-error 
> test.
> 
> Testing all contents of json-readtable would seem excessive to me. 
> But hey, if we miscalculate, we can add more tests as we fix 
> regressions, later.

Alright!

I've attached an updated patch.

-- Simen

[Message part 2 (text/html, inline)]
[0001-Extend-the-test-suite-for-json.el.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#21985; Package emacs. (Tue, 24 Nov 2015 20:54:01 GMT) Full text and rfc822 format available.

Message #14 received at 21985 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 21985 <at> debbugs.gnu.org
Subject: Re: bug#21985: 25.0.50; PATCH] Extend the test suite for json.el
Date: Tue, 24 Nov 2015 22:53:54 +0200

On 11/24/2015 10:25 PM, Simen Heggestøyl wrote:

> I've attached an updated patch.

Please go ahead, you obviously know what you're doing there.
Reply sent to Simen Heggestøyl <simenheg <at> gmail.com>:
You have taken responsibility. (Tue, 24 Nov 2015 22:17:02 GMT) Full text and rfc822 format available.
Notification sent to Simen Heggestøyl <simenheg <at> gmail.com>:
bug acknowledged by developer. (Tue, 24 Nov 2015 22:17:02 GMT) Full text and rfc822 format available.

Message #19 received at 21985-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 21985-done <at> debbugs.gnu.org
Subject: Re: bug#21985: 25.0.50; PATCH] Extend the test suite for json.el
Date: Tue, 24 Nov 2015 23:16:31 +0100

[Message part 1 (text/plain, inline)]
On Tue, Nov 24, 2015 at 9:53 PM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> On 11/24/2015 10:25 PM, Simen Heggestøyl wrote:
> 
>> I've attached an updated patch.
> 
> Please go ahead, you obviously know what you're doing there.

Thanks, installed.

-- Simen

[Message part 2 (text/html, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 23 Dec 2015 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 9 years and 182 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.