GNU bug report logs - #21981
request: dired: require dired-x by default

Previous Next

To reply to this bug, email your comments to 21981 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Hoffman <gmane3-hoffman <at> sneakemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: request: dired: require dired-x by default
Date: Sun, 22 Nov 2015 09:57:01 -0500

The dired-x package is included in Emacs and is highly useful. Can 
`(require 'dired-x)` be added to dired.el so users will no longer need 
to set up a dired-load-hook to use dired-x?

Message #8 received at 21981 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Michael Hoffman <gmane3-hoffman <at> sneakemail.com>
Cc: 21981 <at> debbugs.gnu.org
Subject: Re: bug#21981: request: dired: require dired-x by default
Date: Mon, 23 Nov 2015 13:47:42 -0500

Michael Hoffman wrote:

> The dired-x package is included in Emacs and is highly useful. Can
> (require 'dired-x)` be added to dired.el so users will no longer need
> to set up a dired-load-hook to use dired-x?

My opinion remains the same:

http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00718.html

AFAIK we are still waiting for someone to

  [add] the remaining useful functionality of dired-x into dired and
  then [make] dired-x obsolete.

Message #11 received at 21981 <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <jwiegley <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 21981 <at> debbugs.gnu.org, Michael Hoffman <gmane3-hoffman <at> sneakemail.com>
Subject: Re: bug#21981: request: dired: require dired-x by default
Date: Mon, 23 Nov 2015 14:06:38 -0800

>>>>> Glenn Morris <rgm <at> gnu.org> writes:

> AFAIK we are still waiting for someone to
>   [add] the remaining useful functionality of dired-x into dired and
>   then [make] dired-x obsolete.

I would prefer this also, rather than pulling in all of dired-x. Michael,
would you like to review the parts of dired-x that should move over?

John

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Hoffman <gmane3-hoffman <at> sneakemail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: 21981 <at> debbugs.gnu.org
Subject: Re: bug#21981: request: dired: require dired-x by default
Date: Mon, 23 Nov 2015 21:41:00 -0500

On 11/23/2015 5:06 PM, John Wiegley wrote:
>>>>>> Glenn Morris <rgm <at> gnu.org> writes:
>
>> AFAIK we are still waiting for someone to
>>    [add] the remaining useful functionality of dired-x into dired and
>>    then [make] dired-x obsolete.
>
> I would prefer this also, rather than pulling in all of dired-x. Michael,
> would you like to review the parts of dired-x that should move over?

dired-x.el is divided into a number of sections for different features. 
I use these features myself:

;;; JUMP.
;;; OMITTING.
;;; GUESS SHELL COMMAND.

These features look useful:

;;; EXTENSION MARKING FUNCTIONS.
;;; RELATIVE SYMBOLIC LINKS.
;;; VISIT ALL MARKED FILES SIMULTANEOUSLY.

This is pretty esoteric. It may be worth having this in a separate file 
from dired.el since its use is disjoint from normal use of dired:

;;; VIRTUAL DIRED MODE.

These look obsolete to me:

;;; FIND FILE AT POINT.
;;; SMART SHELL.
;;; LOCAL VARIABLES FOR DIRED BUFFERS.

Within the miscellaneous section, the following might have some utility:

- dired-man
- dired-info
- dired-rmail

The following look obsolete:

- dired-vm
- dired-do-run-mail seems unnecessary without VM

Message #17 received at 21981 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Michael Hoffman <gmane3-hoffman <at> sneakemail.com>, 21981 <at> debbugs.gnu.org
Subject: RE: bug#21981: request: dired: require dired-x by default
Date: Mon, 23 Nov 2015 18:49:22 -0800 (PST)

Why make dired-x obsolete if you are not going to add all
of its features to dired.el?  That makes no sense.

If you're not going to add all of the features then keep
dired-x.el, for now - and until you do add all of its
features.

Why should you, today, decide what Dired users might want
to use from dired-x.el?  It's been around for decades.  Are
you going to guess what bits users use?  And why should you?

I was in favor of moving dired-x.el to dired.el until you
started talking about removing features.

Or rather, I was, and still am, in favor of loading
dired-x.el along with dired.el.  I'm also in favor of loading
dired-aux.el along with the other two.

Is this some kind of (misguided) optimization?  What's
the reason for this kind of filtering?  Just leave it
alone, please, if you can't stop yourselves from removing
features.

Message #23 received at 21981 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: John Wiegley <jwiegley <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 21981 <at> debbugs.gnu.org,
 Michael Hoffman <gmane3-hoffman <at> sneakemail.com>
Subject: Re: bug#21981: request: dired: require dired-x by default
Date: Sat, 29 Aug 2020 09:16:20 -0700

[Message part 1 (text/plain, inline)]

John Wiegley <jwiegley <at> gmail.com> writes:

>>>>>> Glenn Morris <rgm <at> gnu.org> writes:
>
>> AFAIK we are still waiting for someone to
>>   [add] the remaining useful functionality of dired-x into dired and
>>   then [make] dired-x obsolete.
>
> I would prefer this also, rather than pulling in all of dired-x. Michael,
> would you like to review the parts of dired-x that should move over?

I took a stab at one part of this: dired-jump and
dired-jump-other-window.  Please see the attached patch.

The patch is slightly opinionated in that it obsoletes `dired-bind-jump'
and makes it a no-op: it binds `C-x C-j' and `C-x 4 C-j'
unconditionally.  As a replacement, it documents in NEWS how to unbind
them in your init file.  I think this makes much more sense as an
interface to this functionality.

I also moved the corresponding documentation to the Manual and took the
opportunity to rewrite and improve the documentation of those commands.

Best regards,
Stefan Kangas

[0001-Move-dired-jump-from-dired-x-to-dired-Bug-21981.patch (text/x-diff, attachment)]

Message #26 received at 21981 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: John Wiegley <jwiegley <at> gmail.com>, 21981 <at> debbugs.gnu.org,
 Michael Hoffman <gmane3-hoffman <at> sneakemail.com>, Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#21981: request: dired: require dired-x by default
Date: Mon, 31 Aug 2020 11:53:22 +0200

>>>>> On Sat, 29 Aug 2020 09:16:20 -0700, Stefan Kangas <stefan <at> marxist.se> said:
    Stefan> +@findex dired-jump
    Stefan> +@findex dired-jump-other-window
    Stefan> +@kindex C-x C-j
    Stefan> +@kindex C-x 4 C-j
    Stefan> +  Typing @kbd{C-x C-j} (@code{dired-jump}) in any buffer will open a
    Stefan> +Dired buffer and move point to the line of the current file.  In

I had to read dired-jump's docstring before I understood this. Perhaps
'to the line corresponding to the current file.'?

 
    Stefan> ++++
    Stefan> +*** Moved commands from dired-x.

*** 'dired-jump' and 'dired-jump-other-window' moved from dired-x to dired.

    Stefan> +The 'dired-jump' and 'dired-jump-other-window' commands have been
    Stefan> +moved from the 'dired-x' package to 'dired'.  The variable

I think we call this a 'user option'

    Stefan> +'dired-bind-jump' no longer has any effect and is now obsolete.
    Stefan> +The commands are bound to 'C-x C-j' and 'C-x 4 C-j'.

"are now bound to 'C-x C-j' and 'C-x 4 C-j' by default."

Message #29 received at 21981 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: John Wiegley <jwiegley <at> gmail.com>, 21981 <at> debbugs.gnu.org,
 Michael Hoffman <gmane3-hoffman <at> sneakemail.com>, Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#21981: request: dired: require dired-x by default
Date: Mon, 31 Aug 2020 11:48:05 +0000

[Message part 1 (text/plain, inline)]

Thanks for the review.  I've attached a new version of the patch which
makes all your suggested changes.

Best regards,
Stefan Kangas

[0001-Move-dired-jump-from-dired-x-to-dired-Bug-21981.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.